[jira] [Commented] (CASSANDRA-19020) cqlsh should allow failure to import cqlshlib.serverversion
[ https://issues.apache.org/jira/browse/CASSANDRA-19020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785565#comment-17785565 ] Michael Semb Wever commented on CASSANDRA-19020: +1, thanks. > cqlsh should allow failure to import cqlshlib.serverversion > --- > > Key: CASSANDRA-19020 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19020 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.0.x, 5.x > > > cqlshlib.serverversion is created by ant, recording the server's version so > that python can see if it matches cqlsh later. This can make work for other > things that need to be aware of it like CASSANDRA-18594, so we should relax > it a bit since this really has no value outside of warning humans they have a > mismatch. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19020) cqlsh should allow failure to import cqlshlib.serverversion
[ https://issues.apache.org/jira/browse/CASSANDRA-19020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785530#comment-17785530 ] Paulo Motta commented on CASSANDRA-19020: - +1 after CI looks good. > cqlsh should allow failure to import cqlshlib.serverversion > --- > > Key: CASSANDRA-19020 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19020 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.0.x, 5.x > > > cqlshlib.serverversion is created by ant, recording the server's version so > that python can see if it matches cqlsh later. This can make work for other > things that need to be aware of it like CASSANDRA-18594, so we should relax > it a bit since this really has no value outside of warning humans they have a > mismatch. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19020) cqlsh should allow failure to import cqlshlib.serverversion
[ https://issues.apache.org/jira/browse/CASSANDRA-19020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785528#comment-17785528 ] Brandon Williams commented on CASSANDRA-19020: -- Trivial patch to set build_version to UNKNOWN if not present. ||Branch||CI|| |[3.0|https://github.com/driftx/cassandra/tree/CASSANDRA-19020-3.0]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1365/workflows/ea048e44-cf33-4817-9fd8-6b8f82b2c6ef]| |[3.11|https://github.com/driftx/cassandra/tree/CASSANDRA-19020-3.11]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1369/workflows/016f14a7-3545-4b57-8418-7bced1784708]| |[4.0|https://github.com/driftx/cassandra/tree/CASSANDRA-19020-4.0]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1368/workflows/2b5463b3-62a7-4485-90c2-6ad4c2974d58], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1368/workflows/ac2dd534-1e9f-45a3-ab12-1466d2057feb]| |[4.1|https://github.com/driftx/cassandra/tree/CASSANDRA-19020-4.1]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1366/workflows/d9050b33-9b2e-4a98-8fa9-4a48f85e766f], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1366/workflows/e40c822e-f35a-4b6c-877c-7cded397c2b9]| |[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-19020-trunk]|[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1367/workflows/f623481e-ac1a-4005-9443-b5095e9c6c88], [j17|https://app.circleci.com/pipelines/github/driftx/cassandra/1367/workflows/8b7607fa-1bd4-4560-a293-36a9821b7af6]| > cqlsh should allow failure to import cqlshlib.serverversion > --- > > Key: CASSANDRA-19020 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19020 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.0.x, 5.x > > > cqlshlib.serverversion is created by ant, recording the server's version so > that python can see if it matches cqlsh later. This can make work for other > things that need to be aware of it like CASSANDRA-18594, so we should relax > it a bit since this really has no value outside of warning humans they have a > mismatch. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
