[jira] [Commented] (CASSANDRA-19050) Enhanced usage of test method names in CQLTester for better test debugging
[
https://issues.apache.org/jira/browse/CASSANDRA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808039#comment-17808039
]
Berenguer Blasi commented on CASSANDRA-19050:
-
Thanks for the review!
> Enhanced usage of test method names in CQLTester for better test debugging
> --
>
> Key: CASSANDRA-19050
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19050
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 5.0, 5.x
>
>
> All views, tables, ks,... created in CQLTester are of the form {{table_00}}:
> - While debugging tests and flakies this makes it really hard to match logs
> to test methods.
> - Some async operations can spill log lines from a previous test method into
> the next's log lines which is incredibly confusing
> - It's hard on the eyes and easy to mix up
> - When comparing logs from 2 different branches, envs,... it's really hard to
> match logs
> The proposed solution is for {{CQLTester}} to decorate these with the test
> name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19050) Enhanced usage of test method names in CQLTester for better test debugging
[
https://issues.apache.org/jira/browse/CASSANDRA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807668#comment-17807668
]
Benjamin Lerer commented on CASSANDRA-19050:
The patches look good to me.
> Enhanced usage of test method names in CQLTester for better test debugging
> --
>
> Key: CASSANDRA-19050
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19050
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
>
> All views, tables, ks,... created in CQLTester are of the form {{table_00}}:
> - While debugging tests and flakies this makes it really hard to match logs
> to test methods.
> - Some async operations can spill log lines from a previous test method into
> the next's log lines which is incredibly confusing
> - It's hard on the eyes and easy to mix up
> - When comparing logs from 2 different branches, envs,... it's really hard to
> match logs
> The proposed solution is for {{CQLTester}} to decorate these with the test
> name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19050) Enhanced usage of test method names in CQLTester for better test debugging
[
https://issues.apache.org/jira/browse/CASSANDRA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805577#comment-17805577
]
Benjamin Lerer commented on CASSANDRA-19050:
The patch had a minor issue. The new version is
[here|https://github.com/blerer/cassandra/commit/a650fbce6a5092bc9004ca47fe25a424623b1d6e].
The unit test run is
[green|https://app.circleci.com/pipelines/github/blerer/cassandra/370/workflows/8fbcb82b-a5c4-4ac8-baf7-e54909209eaa].
> Enhanced usage of test method names in CQLTester for better test debugging
> --
>
> Key: CASSANDRA-19050
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19050
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
>
> All views, tables, ks,... created in CQLTester are of the form {{table_00}}:
> - While debugging tests and flakies this makes it really hard to match logs
> to test methods.
> - Some async operations can spill log lines from a previous test method into
> the next's log lines which is incredibly confusing
> - It's hard on the eyes and easy to mix up
> - When comparing logs from 2 different branches, envs,... it's really hard to
> match logs
> The proposed solution is for {{CQLTester}} to decorate these with the test
> name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19050) Enhanced usage of test method names in CQLTester for better test debugging
[
https://issues.apache.org/jira/browse/CASSANDRA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805400#comment-17805400
]
Berenguer Blasi commented on CASSANDRA-19050:
-
^I think that will fail when seqNumber is 99 and jumps to 100, that's why you
need a loop instead of making room for N characters. I [also
tried|https://github.com/apache/cassandra/pull/2927#issuecomment-1822322918]
your approach and decided against it. Can you fire a test run?
> Enhanced usage of test method names in CQLTester for better test debugging
> --
>
> Key: CASSANDRA-19050
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19050
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
>
> All views, tables, ks,... created in CQLTester are of the form {{table_00}}:
> - While debugging tests and flakies this makes it really hard to match logs
> to test methods.
> - Some async operations can spill log lines from a previous test method into
> the next's log lines which is incredibly confusing
> - It's hard on the eyes and easy to mix up
> - When comparing logs from 2 different branches, envs,... it's really hard to
> match logs
> The proposed solution is for {{CQLTester}} to decorate these with the test
> name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19050) Enhanced usage of test method names in CQLTester for better test debugging
[
https://issues.apache.org/jira/browse/CASSANDRA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805244#comment-17805244
]
Benjamin Lerer commented on CASSANDRA-19050:
[~bereng] I posted my suggestion
[here|https://github.com/blerer/cassandra/commit/3b32229b2bb0d8aaa7ed1a676e9d453d203f212c].
Ignore the change to the {{java.util}} imports.
> Enhanced usage of test method names in CQLTester for better test debugging
> --
>
> Key: CASSANDRA-19050
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19050
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
>
> All views, tables, ks,... created in CQLTester are of the form {{table_00}}:
> - While debugging tests and flakies this makes it really hard to match logs
> to test methods.
> - Some async operations can spill log lines from a previous test method into
> the next's log lines which is incredibly confusing
> - It's hard on the eyes and easy to mix up
> - When comparing logs from 2 different branches, envs,... it's really hard to
> match logs
> The proposed solution is for {{CQLTester}} to decorate these with the test
> name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19050) Enhanced usage of test method names in CQLTester for better test debugging
[
https://issues.apache.org/jira/browse/CASSANDRA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804209#comment-17804209
]
Berenguer Blasi commented on CASSANDRA-19050:
-
ping [~blerer]
> Enhanced usage of test method names in CQLTester for better test debugging
> --
>
> Key: CASSANDRA-19050
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19050
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
>
> All views, tables, ks,... created in CQLTester are of the form {{table_00}}:
> - While debugging tests and flakies this makes it really hard to match logs
> to test methods.
> - Some async operations can spill log lines from a previous test method into
> the next's log lines which is incredibly confusing
> - It's hard on the eyes and easy to mix up
> - When comparing logs from 2 different branches, envs,... it's really hard to
> match logs
> The proposed solution is for {{CQLTester}} to decorate these with the test
> name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19050) Enhanced usage of test method names in CQLTester for better test debugging
[
https://issues.apache.org/jira/browse/CASSANDRA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795255#comment-17795255
]
Berenguer Blasi commented on CASSANDRA-19050:
-
[~blerer] do you think you'll have a gap to look into this so we can commit
it?. Thx
> Enhanced usage of test method names in CQLTester for better test debugging
> --
>
> Key: CASSANDRA-19050
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19050
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
>
> All views, tables, ks,... created in CQLTester are of the form {{table_00}}:
> - While debugging tests and flakies this makes it really hard to match logs
> to test methods.
> - Some async operations can spill log lines from a previous test method into
> the next's log lines which is incredibly confusing
> - It's hard on the eyes and easy to mix up
> - When comparing logs from 2 different branches, envs,... it's really hard to
> match logs
> The proposed solution is for {{CQLTester}} to decorate these with the test
> name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19050) Enhanced usage of test method names in CQLTester for better test debugging
[
https://issues.apache.org/jira/browse/CASSANDRA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791548#comment-17791548
]
Berenguer Blasi commented on CASSANDRA-19050:
-
I took that into account. But you still need to change table names if you
compare logs from different envs like local vs circle. Also it's hard on the
eyes when table_01 and table_10 are totally different things etc
> Enhanced usage of test method names in CQLTester for better test debugging
> --
>
> Key: CASSANDRA-19050
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19050
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
>
> All views, tables, ks,... created in CQLTester are of the form {{table_00}}:
> - While debugging tests and flakies this makes it really hard to match logs
> to test methods.
> - Some async operations can spill log lines from a previous test method into
> the next's log lines which is incredibly confusing
> - It's hard on the eyes and easy to mix up
> - When comparing logs from 2 different branches, envs,... it's really hard to
> match logs
> The proposed solution is for {{CQLTester}} to decorate these with the test
> name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19050) Enhanced usage of test method names in CQLTester for better test debugging
[
https://issues.apache.org/jira/browse/CASSANDRA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791543#comment-17791543
]
Jacek Lewandowski commented on CASSANDRA-19050:
---
With CASSANDRA-19026 there will no more async processing related to the
previous test case overlapping the next test case.
I also think that we should have a rule defined in CQLTester which puts a log
line before / after each test case. Therefore we would not have to change the
table names
> Enhanced usage of test method names in CQLTester for better test debugging
> --
>
> Key: CASSANDRA-19050
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19050
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
>
> All views, tables, ks,... created in CQLTester are of the form {{table_00}}:
> - While debugging tests and flakies this makes it really hard to match logs
> to test methods.
> - Some async operations can spill log lines from a previous test method into
> the next's log lines which is incredibly confusing
> - It's hard on the eyes and easy to mix up
> - When comparing logs from 2 different branches, envs,... it's really hard to
> match logs
> The proposed solution is for {{CQLTester}} to decorate these with the test
> name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19050) Enhanced usage of test method names in CQLTester for better test debugging
[
https://issues.apache.org/jira/browse/CASSANDRA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790572#comment-17790572
]
Benjamin Lerer commented on CASSANDRA-19050:
I had a talk with [~bereng] as I would like to propose a different approach for
the patch today or tomorrow.
> Enhanced usage of test method names in CQLTester for better test debugging
> --
>
> Key: CASSANDRA-19050
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19050
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
>
> All views, tables, ks,... created in CQLTester are of the form {{table_00}}:
> - While debugging tests and flakies this makes it really hard to match logs
> to test methods.
> - Some async operations can spill log lines from a previous test method into
> the next's log lines which is incredibly confusing
> - It's hard on the eyes and easy to mix up
> - When comparing logs from 2 different branches, envs,... it's really hard to
> match logs
> The proposed solution is for {{CQLTester}} to decorate these with the test
> name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19050) Enhanced usage of test method names in CQLTester for better test debugging
[
https://issues.apache.org/jira/browse/CASSANDRA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790463#comment-17790463
]
Alex Petrov commented on CASSANDRA-19050:
-
Wanted to mention that TCM merge related tests are
[documented|https://issues.apache.org/jira/browse/CASSANDRA-19055], and there
are rather few of them by now. If you see any failure that is not in the list,
there’s a chance it is not TCM related. There have been flakes we have fixed
that existed in trunk, too.
I suggest in this interim period, we list test failures and cross-reference
them against the TCM list. For example,
org.apache.cassandra.index.sai.cql.StorageAttachedIndexDDLTest#concurrentTruncateWithIndexBuilding-oa_jdk17
is not TCM related, and there seems to be an issue open about it:
[CASSANDRA-19032]. Another that looks like unfamiliar one is
https://app.circleci.com/pipelines/github/bereng/cassandra/1122/workflows/31c7e520-ca04-4278-b0c8-a9fa32b3a0f9/jobs/34616/tests
I have not checked all pipelines, but this is something that stood out. Does
not seem to be broken because of this patch though.
I just think attributing all test failures, especially flakes, to TCM is also
not the best way to go forward.
> Enhanced usage of test method names in CQLTester for better test debugging
> --
>
> Key: CASSANDRA-19050
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19050
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
>
> All views, tables, ks,... created in CQLTester are of the form {{table_00}}:
> - While debugging tests and flakies this makes it really hard to match logs
> to test methods.
> - Some async operations can spill log lines from a previous test method into
> the next's log lines which is incredibly confusing
> - It's hard on the eyes and easy to mix up
> - When comparing logs from 2 different branches, envs,... it's really hard to
> match logs
> The proposed solution is for {{CQLTester}} to decorate these with the test
> name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19050) Enhanced usage of test method names in CQLTester for better test debugging
[
https://issues.apache.org/jira/browse/CASSANDRA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790458#comment-17790458
]
Berenguer Blasi commented on CASSANDRA-19050:
-
They're in the PRs.
> Enhanced usage of test method names in CQLTester for better test debugging
> --
>
> Key: CASSANDRA-19050
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19050
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
>
> All views, tables, ks,... created in CQLTester are of the form {{table_00}}:
> - While debugging tests and flakies this makes it really hard to match logs
> to test methods.
> - Some async operations can spill log lines from a previous test method into
> the next's log lines which is incredibly confusing
> - It's hard on the eyes and easy to mix up
> - When comparing logs from 2 different branches, envs,... it's really hard to
> match logs
> The proposed solution is for {{CQLTester}} to decorate these with the test
> name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19050) Enhanced usage of test method names in CQLTester for better test debugging
[
https://issues.apache.org/jira/browse/CASSANDRA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790443#comment-17790443
]
Marcus Eriksson commented on CASSANDRA-19050:
-
could you post the CI results please?
> Enhanced usage of test method names in CQLTester for better test debugging
> --
>
> Key: CASSANDRA-19050
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19050
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
>
> All views, tables, ks,... created in CQLTester are of the form {{table_00}}:
> - While debugging tests and flakies this makes it really hard to match logs
> to test methods.
> - Some async operations can spill log lines from a previous test method into
> the next's log lines which is incredibly confusing
> - It's hard on the eyes and easy to mix up
> - When comparing logs from 2 different branches, envs,... it's really hard to
> match logs
> The proposed solution is for {{CQLTester}} to decorate these with the test
> name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19050) Enhanced usage of test method names in CQLTester for better test debugging
[
https://issues.apache.org/jira/browse/CASSANDRA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790431#comment-17790431
]
Berenguer Blasi commented on CASSANDRA-19050:
-
Added trunk PR and failures seem TCM merge related. Do you agree [~mck]? if you
do I'll merge
> Enhanced usage of test method names in CQLTester for better test debugging
> --
>
> Key: CASSANDRA-19050
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19050
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 5.0-rc, 5.x
>
>
> All views, tables, ks,... created in CQLTester are of the form {{table_00}}:
> - While debugging tests and flakies this makes it really hard to match logs
> to test methods.
> - Some async operations can spill log lines from a previous test method into
> the next's log lines which is incredibly confusing
> - It's hard on the eyes and easy to mix up
> - When comparing logs from 2 different branches, envs,... it's really hard to
> match logs
> The proposed solution is for {{CQLTester}} to decorate these with the test
> name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
