[jira] [Commented] (CASSANDRA-19105) Using Capture to save results in CQLSH with Tracing on incorrectly saves the trace details
[ https://issues.apache.org/jira/browse/CASSANDRA-19105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846469#comment-17846469 ] Gautam G commented on CASSANDRA-19105: -- Hi [~bschoeni], These were my final changes ([https://github.com/apache/cassandra/pull/3307).] I dint get a change to look at it later. Let me know if I can do anything. I am interested to take it. > Using Capture to save results in CQLSH with Tracing on incorrectly saves the > trace details > -- > > Key: CASSANDRA-19105 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19105 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Gautam G >Priority: Normal > > When using *Tracing* in CQLSH, it's sometimes helpful to use *Capture* to > avoid paging through output when you want to see the trace results. However, > the trace results are also incorrectly captured to the output file. > According to *Help Capture* (below), only the query result should be saved. > The correct behavior should display the trace results and only capture the > query results. > {_}Help capture message{_}: Only query result output is captured. > Errors and output from cqlsh-only commands will still be shown in the cqlsh > session. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19105) Using Capture to save results in CQLSH with Tracing on incorrectly saves the trace details
[ https://issues.apache.org/jira/browse/CASSANDRA-19105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802377#comment-17802377 ] Gautam G commented on CASSANDRA-19105: -- I need to check issue# 2 once in my end. When I implemented the changes I expect Tracing session id to be printed in the file on capturing. When the query is given the first time the Tracing session id does appear, but appears in the file from the next runs. > Using Capture to save results in CQLSH with Tracing on incorrectly saves the > trace details > -- > > Key: CASSANDRA-19105 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19105 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Gautam G >Priority: Normal > > When using *Tracing* in CQLSH, it's sometimes helpful to use *Capture* to > avoid paging through output when you want to see the trace results. However, > the trace results are also incorrectly captured to the output file. > According to *Help Capture* (below), only the query result should be saved. > The correct behavior should display the trace results and only capture the > query results. > {_}Help capture message{_}: Only query result output is captured. > Errors and output from cqlsh-only commands will still be shown in the cqlsh > session. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19105) Using Capture to save results in CQLSH with Tracing on incorrectly saves the trace details
[ https://issues.apache.org/jira/browse/CASSANDRA-19105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802002#comment-17802002 ] Brad Schoening commented on CASSANDRA-19105: [~gautamg] yes, looks ok. My view is that the color isn't too important. I don't understand issue #2. > Using Capture to save results in CQLSH with Tracing on incorrectly saves the > trace details > -- > > Key: CASSANDRA-19105 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19105 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Gautam G >Priority: Normal > > When using *Tracing* in CQLSH, it's sometimes helpful to use *Capture* to > avoid paging through output when you want to see the trace results. However, > the trace results are also incorrectly captured to the output file. > According to *Help Capture* (below), only the query result should be saved. > The correct behavior should display the trace results and only capture the > query results. > {_}Help capture message{_}: Only query result output is captured. > Errors and output from cqlsh-only commands will still be shown in the cqlsh > session. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19105) Using Capture to save results in CQLSH with Tracing on incorrectly saves the trace details
[ https://issues.apache.org/jira/browse/CASSANDRA-19105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801920#comment-17801920 ] Gautam G commented on CASSANDRA-19105: -- [~bschoeni] i tried to make some changes [github|https://github.com/GautamGottipati/cassandra/commit/4a1228f2721476db94d1bc3692a2a880b7099708?diff=split=0] Some of the issues after these changes : 1) When we enable capture the self.color becomes false (line 1649 in qlshmain.py), due to this the trace is not colored when printed in shell( sysout) 2) There is some issue on printing Tracing session to the file. The Tracing session: does n't appear in the first run, it appears in the next runs. Wanted to know if I am on right track. Open for suggestions. Thank you > Using Capture to save results in CQLSH with Tracing on incorrectly saves the > trace details > -- > > Key: CASSANDRA-19105 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19105 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Gautam G >Priority: Normal > > When using *Tracing* in CQLSH, it's sometimes helpful to use *Capture* to > avoid paging through output when you want to see the trace results. However, > the trace results are also incorrectly captured to the output file. > According to *Help Capture* (below), only the query result should be saved. > The correct behavior should display the trace results and only capture the > query results. > {_}Help capture message{_}: Only query result output is captured. > Errors and output from cqlsh-only commands will still be shown in the cqlsh > session. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19105) Using Capture to save results in CQLSH with Tracing on incorrectly saves the trace details
[ https://issues.apache.org/jira/browse/CASSANDRA-19105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801260#comment-17801260 ] Gautam G commented on CASSANDRA-19105: -- Thank you [~bschoeni] . I wanted to know if I make any changes to the code, how do I test it locally. Do we build (ant jar) and then do ./bin/cqlsh. or do we have any other process. > Using Capture to save results in CQLSH with Tracing on incorrectly saves the > trace details > -- > > Key: CASSANDRA-19105 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19105 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Gautam G >Priority: Normal > > When using *Tracing* in CQLSH, it's sometimes helpful to use *Capture* to > avoid paging through output when you want to see the trace results. However, > the trace results are also incorrectly captured to the output file. > According to *Help Capture* (below), only the query result should be saved. > The correct behavior should display the trace results and only capture the > query results. > {_}Help capture message{_}: Only query result output is captured. > Errors and output from cqlsh-only commands will still be shown in the cqlsh > session. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19105) Using Capture to save results in CQLSH with Tracing on incorrectly saves the trace details
[ https://issues.apache.org/jira/browse/CASSANDRA-19105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801060#comment-17801060 ] Brad Schoening commented on CASSANDRA-19105: [~gautamg] Yes, but not an option. If you enable '{*}capture{*}' for query output, you don't expect *trace* output to be sent there. So the behavior for trace output should change to always go to stdio (which can be redirected at the Linux shell). > Using Capture to save results in CQLSH with Tracing on incorrectly saves the > trace details > -- > > Key: CASSANDRA-19105 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19105 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Gautam G >Priority: Normal > > When using *Tracing* in CQLSH, it's sometimes helpful to use *Capture* to > avoid paging through output when you want to see the trace results. However, > the trace results are also incorrectly captured to the output file. > According to *Help Capture* (below), only the query result should be saved. > The correct behavior should display the trace results and only capture the > query results. > {_}Help capture message{_}: Only query result output is captured. > Errors and output from cqlsh-only commands will still be shown in the cqlsh > session. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19105) Using Capture to save results in CQLSH with Tracing on incorrectly saves the trace details
[ https://issues.apache.org/jira/browse/CASSANDRA-19105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801057#comment-17801057 ] Gautam G commented on CASSANDRA-19105: -- Got it [~bschoeni] . So, we plan provide an option where we only capture the query output to the file and the trace output should be displayed in the shell. Correct me if I have understood it wrong. Thank you. > Using Capture to save results in CQLSH with Tracing on incorrectly saves the > trace details > -- > > Key: CASSANDRA-19105 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19105 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Gautam G >Priority: Normal > > When using *Tracing* in CQLSH, it's sometimes helpful to use *Capture* to > avoid paging through output when you want to see the trace results. However, > the trace results are also incorrectly captured to the output file. > According to *Help Capture* (below), only the query result should be saved. > The correct behavior should display the trace results and only capture the > query results. > {_}Help capture message{_}: Only query result output is captured. > Errors and output from cqlsh-only commands will still be shown in the cqlsh > session. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org