[jira] [Commented] (CASSANDRA-2325) invalidateKeyCache / invalidateRowCache should remove saved cache files from disk
[ https://issues.apache.org/jira/browse/CASSANDRA-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13083479#comment-13083479 ] Hudson commented on CASSANDRA-2325: --- Integrated in Cassandra-0.8 #272 (See [https://builds.apache.org/job/Cassandra-0.8/272/]) cache invalidate removes saved cache files patch by Ed Capriolo; reviewed by jbellis for CASSANDRA-2325 jbellis : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1156772 Files : * /cassandra/branches/cassandra-0.8/CHANGES.txt * /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/db/ColumnFamilyStore.java invalidateKeyCache / invalidateRowCache should remove saved cache files from disk - Key: CASSANDRA-2325 URL: https://issues.apache.org/jira/browse/CASSANDRA-2325 Project: Cassandra Issue Type: Improvement Affects Versions: 0.6 Reporter: Matthew F. Dennis Assignee: Edward Capriolo Priority: Minor Fix For: 0.8.5 Attachments: cassandra-2325-1.patch.txt, cassandra-2325-3.patch.txt, cassandra-2325.patch.2.txt the invalidate[Key|Row]Cache calls don't remove the saved caches from disk. It seems logical that if you are clearing the caches you don't expect them to be reinstantiated with the old values the next time C* starts. This is not a huge issue since next time the caches are saved the old values will be removed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2325) invalidateKeyCache / invalidateRowCache should remove saved cache files from disk
[ https://issues.apache.org/jira/browse/CASSANDRA-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13081920#comment-13081920 ] Jonathan Ellis commented on CASSANDRA-2325: --- Shouldn't we check that the file exists first? otherwise we log spurious errors. invalidateKeyCache / invalidateRowCache should remove saved cache files from disk - Key: CASSANDRA-2325 URL: https://issues.apache.org/jira/browse/CASSANDRA-2325 Project: Cassandra Issue Type: Improvement Affects Versions: 0.6 Reporter: Matthew F. Dennis Assignee: Edward Capriolo Priority: Minor Fix For: 0.8.4 Attachments: cassandra-2325-1.patch.txt, cassandra-2325.patch.2.txt the invalidate[Key|Row]Cache calls don't remove the saved caches from disk. It seems logical that if you are clearing the caches you don't expect them to be reinstantiated with the old values the next time C* starts. This is not a huge issue since next time the caches are saved the old values will be removed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2325) invalidateKeyCache / invalidateRowCache should remove saved cache files from disk
[
https://issues.apache.org/jira/browse/CASSANDRA-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13080194#comment-13080194
]
Edward Capriolo commented on CASSANDRA-2325:
@Jonathon,
We could do this
{noformat}
public void invalidateKeyCache()
{
keyCache.clear();
if (!keyCache.getCachePath().delete()){
logger.error(KeyCache +columnFamily+ delete failed.);
}
}
{noformat}
But I am wondering how that effects systems like the Memcache row caching that
are not physical files. I was just assuming the other call was more future
proof. I will dig into the code a bit.
invalidateKeyCache / invalidateRowCache should remove saved cache files from
disk
-
Key: CASSANDRA-2325
URL: https://issues.apache.org/jira/browse/CASSANDRA-2325
Project: Cassandra
Issue Type: Improvement
Affects Versions: 0.7.8, 0.8.2
Reporter: Matthew F. Dennis
Assignee: Edward Capriolo
Priority: Minor
Attachments: cassandra-2325-1.patch.txt
the invalidate[Key|Row]Cache calls don't remove the saved caches from disk.
It seems logical that if you are clearing the caches you don't expect them to
be reinstantiated with the old values the next time C* starts.
This is not a huge issue since next time the caches are saved the old values
will be removed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2325) invalidateKeyCache / invalidateRowCache should remove saved cache files from disk
[ https://issues.apache.org/jira/browse/CASSANDRA-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13080198#comment-13080198 ] Jonathan Ellis commented on CASSANDRA-2325: --- The row cache doesn't actually save row contents, just keys that are re-populated on startup. (Otherwise every write would have to update the cache file too.) invalidateKeyCache / invalidateRowCache should remove saved cache files from disk - Key: CASSANDRA-2325 URL: https://issues.apache.org/jira/browse/CASSANDRA-2325 Project: Cassandra Issue Type: Improvement Affects Versions: 0.7.8, 0.8.2 Reporter: Matthew F. Dennis Assignee: Edward Capriolo Priority: Minor Attachments: cassandra-2325-1.patch.txt the invalidate[Key|Row]Cache calls don't remove the saved caches from disk. It seems logical that if you are clearing the caches you don't expect them to be reinstantiated with the old values the next time C* starts. This is not a huge issue since next time the caches are saved the old values will be removed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
