[jira] [Commented] (CASSANDRA-4952) Add blocking force compaction (and anything else) calls to NodeProbe
[ https://issues.apache.org/jira/browse/CASSANDRA-4952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13750639#comment-13750639 ] Jonathan Ellis commented on CASSANDRA-4952: --- LGTY Michael? Add blocking force compaction (and anything else) calls to NodeProbe Key: CASSANDRA-4952 URL: https://issues.apache.org/jira/browse/CASSANDRA-4952 Project: Cassandra Issue Type: Improvement Components: Core Affects Versions: 1.1.6 Reporter: Michael Harris Assignee: Jonathan Ellis Priority: Minor Labels: lhf Attachments: 4952.txt There are times when I'd like to get feedback about when compactions complete. For example, if I'm deleting data from cassandra and want to know when it is 100% removed from cassandra (tombstones collected and all). This is completely trivial to implement based on the existing code (the method called by the non-blocking version returns a future, so you could just wait on that, potentially with a timeout). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4952) Add blocking force compaction (and anything else) calls to NodeProbe
[ https://issues.apache.org/jira/browse/CASSANDRA-4952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13750645#comment-13750645 ] Michael Harris commented on CASSANDRA-4952: --- yep, looks totally fine to me Add blocking force compaction (and anything else) calls to NodeProbe Key: CASSANDRA-4952 URL: https://issues.apache.org/jira/browse/CASSANDRA-4952 Project: Cassandra Issue Type: Improvement Components: Core Affects Versions: 1.1.6 Reporter: Michael Harris Assignee: Jonathan Ellis Priority: Minor Labels: lhf Attachments: 4952.txt There are times when I'd like to get feedback about when compactions complete. For example, if I'm deleting data from cassandra and want to know when it is 100% removed from cassandra (tombstones collected and all). This is completely trivial to implement based on the existing code (the method called by the non-blocking version returns a future, so you could just wait on that, potentially with a timeout). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4952) Add blocking force compaction (and anything else) calls to NodeProbe
[ https://issues.apache.org/jira/browse/CASSANDRA-4952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13750716#comment-13750716 ] Jonathan Ellis commented on CASSANDRA-4952: --- Committed. Add blocking force compaction (and anything else) calls to NodeProbe Key: CASSANDRA-4952 URL: https://issues.apache.org/jira/browse/CASSANDRA-4952 Project: Cassandra Issue Type: Improvement Components: Core Affects Versions: 1.1.6 Reporter: Michael Harris Assignee: Jonathan Ellis Priority: Minor Labels: lhf Fix For: 1.2.10, 2.0.1 Attachments: 4952.txt There are times when I'd like to get feedback about when compactions complete. For example, if I'm deleting data from cassandra and want to know when it is 100% removed from cassandra (tombstones collected and all). This is completely trivial to implement based on the existing code (the method called by the non-blocking version returns a future, so you could just wait on that, potentially with a timeout). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4952) Add blocking force compaction (and anything else) calls to NodeProbe
[ https://issues.apache.org/jira/browse/CASSANDRA-4952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13746544#comment-13746544 ] Michael Harris commented on CASSANDRA-4952: --- It doesn't look like user defined compaction has this property, however. Unless 1.2 does and I'm still looking at 1.1 code. Add blocking force compaction (and anything else) calls to NodeProbe Key: CASSANDRA-4952 URL: https://issues.apache.org/jira/browse/CASSANDRA-4952 Project: Cassandra Issue Type: Improvement Components: Core Affects Versions: 1.1.6 Reporter: Michael Harris Priority: Minor Labels: lhf There are times when I'd like to get feedback about when compactions complete. For example, if I'm deleting data from cassandra and want to know when it is 100% removed from cassandra (tombstones collected and all). This is completely trivial to implement based on the existing code (the method called by the non-blocking version returns a future, so you could just wait on that, potentially with a timeout). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4952) Add blocking force compaction (and anything else) calls to NodeProbe
[ https://issues.apache.org/jira/browse/CASSANDRA-4952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13745736#comment-13745736 ] Greg DeAngelis commented on CASSANDRA-4952: --- I think I misinterpreted what was being asked for. After digging further I realized that the compaction command exposed via nodetool already does a blocking compaction. Given that, is this ticket still valid? Add blocking force compaction (and anything else) calls to NodeProbe Key: CASSANDRA-4952 URL: https://issues.apache.org/jira/browse/CASSANDRA-4952 Project: Cassandra Issue Type: Improvement Components: Core Affects Versions: 1.1.6 Reporter: Michael Harris Priority: Minor Labels: lhf There are times when I'd like to get feedback about when compactions complete. For example, if I'm deleting data from cassandra and want to know when it is 100% removed from cassandra (tombstones collected and all). This is completely trivial to implement based on the existing code (the method called by the non-blocking version returns a future, so you could just wait on that, potentially with a timeout). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4952) Add blocking force compaction (and anything else) calls to NodeProbe
[ https://issues.apache.org/jira/browse/CASSANDRA-4952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13742833#comment-13742833 ] Michael Harris commented on CASSANDRA-4952: --- it might even be better to expose the timeout as a parameter to the compaction (with a reasonable default, sure). I'd love to be able to specify a very high timeout because I might be compacting a 100GB+ collection of column families, which could take a while. Add blocking force compaction (and anything else) calls to NodeProbe Key: CASSANDRA-4952 URL: https://issues.apache.org/jira/browse/CASSANDRA-4952 Project: Cassandra Issue Type: Improvement Components: Core Affects Versions: 1.1.6 Reporter: Michael Harris Priority: Minor Labels: lhf There are times when I'd like to get feedback about when compactions complete. For example, if I'm deleting data from cassandra and want to know when it is 100% removed from cassandra (tombstones collected and all). This is completely trivial to implement based on the existing code (the method called by the non-blocking version returns a future, so you could just wait on that, potentially with a timeout). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4952) Add blocking force compaction (and anything else) calls to NodeProbe
[ https://issues.apache.org/jira/browse/CASSANDRA-4952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13741820#comment-13741820 ] Greg DeAngelis commented on CASSANDRA-4952: --- Hi I'm new to the project and would like to start contributing. Before I try to work on this I just wanted to validate what I think needs to be done. As I understand it, what is being asked for is a blocking version of forceUserDefinedCompaction. This looks like it involves following what is done in forceUserDefinedCompaction for creating the list of keyspace/column family pairs, using the work done to construct the runnable in submitUserDefined (minus the executor.submit) to create a list of runnables then calling executor.invokeAll with some default timeout. Does this sound about right? Add blocking force compaction (and anything else) calls to NodeProbe Key: CASSANDRA-4952 URL: https://issues.apache.org/jira/browse/CASSANDRA-4952 Project: Cassandra Issue Type: Improvement Components: Core Affects Versions: 1.1.6 Reporter: Michael Harris Priority: Minor Labels: lhf There are times when I'd like to get feedback about when compactions complete. For example, if I'm deleting data from cassandra and want to know when it is 100% removed from cassandra (tombstones collected and all). This is completely trivial to implement based on the existing code (the method called by the non-blocking version returns a future, so you could just wait on that, potentially with a timeout). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
