[jira] [Commented] (CASSANDRA-5958) Unable to find property errors from snakeyaml are confusing

2013-09-02 Thread Jonathan Ellis (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-5958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13756342#comment-13756342
 ] 

Jonathan Ellis commented on CASSANDRA-5958:
---

does HashSet.toString actually give us a human-readable error?

 Unable to find property errors from snakeyaml are confusing
 -

 Key: CASSANDRA-5958
 URL: https://issues.apache.org/jira/browse/CASSANDRA-5958
 Project: Cassandra
  Issue Type: Bug
Reporter: J.B. Langston
Priority: Minor
 Attachments: trunk-5958-skip-missing-properties.patch, 
 trunk-5958-v2-print-all-invalid-properties.patch


 When an unexpected property is present in cassandra.yaml (e.g. after 
 upgrading), snakeyaml outputs the following message:
 {code}Unable to find property 'some_property' on class: 
 org.apache.cassandra.config.Config{code}
 The error message is kind of counterintuitive because at first glance it 
 seems to suggest the property is missing from the yaml file, when in fact the 
 error is caused by the *presence* of an unrecognized property.  I know if you 
 read it carefully it says it can't find the property on the class, but this 
 has confused more than one user.
 I think we should catch this exception and wrap it in another exception that 
 says something like this:
 {code}Please remove 'some_property' from your cassandra.yaml. It is not 
 recognized by this version of Cassandra.{code}
 Also, it might make sense to make this a warning instead of a fatal error, 
 and just ignore the unwanted property.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (CASSANDRA-5958) Unable to find property errors from snakeyaml are confusing

2013-09-02 Thread Mikhail Stepura (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-5958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13756348#comment-13756348
 ] 

Mikhail Stepura commented on CASSANDRA-5958:


For example I have the following in my cassandra.yaml

{code:title=cassandra.yaml}
oh: my
bla: bla
{code}

Then the stacktrace will be
{code}
ERROR 04:06:57 Fatal configuration error
org.apache.cassandra.exceptions.ConfigurationException: Invalid yaml. Please 
remove properties [bla, oh] from your cassandra.yaml
at 
org.apache.cassandra.config.YamlConfigurationLoader$MissingPropertiesChecker.check(YamlConfigurationLoader.java:131)
 ~[main/:na]
at 
org.apache.cassandra.config.YamlConfigurationLoader.loadConfig(YamlConfigurationLoader.java:94)
 ~[main/:na]
at 
org.apache.cassandra.config.DatabaseDescriptor.loadConfig(DatabaseDescriptor.java:128)
 ~[main/:na]
at 
org.apache.cassandra.config.DatabaseDescriptor.clinit(DatabaseDescriptor.java:104)
 ~[main/:na]
at 
org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:153) 
~[main/:na]
at 
org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:391) 
~[main/:na]
at 
org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:434) 
~[main/:na]
Invalid yaml. Please remove properties [bla, oh] from your cassandra.yaml
Fatal configuration error; unable to start. See log for stacktrace.
{code}

 Unable to find property errors from snakeyaml are confusing
 -

 Key: CASSANDRA-5958
 URL: https://issues.apache.org/jira/browse/CASSANDRA-5958
 Project: Cassandra
  Issue Type: Bug
Reporter: J.B. Langston
Priority: Minor
 Attachments: trunk-5958-skip-missing-properties.patch, 
 trunk-5958-v2-print-all-invalid-properties.patch


 When an unexpected property is present in cassandra.yaml (e.g. after 
 upgrading), snakeyaml outputs the following message:
 {code}Unable to find property 'some_property' on class: 
 org.apache.cassandra.config.Config{code}
 The error message is kind of counterintuitive because at first glance it 
 seems to suggest the property is missing from the yaml file, when in fact the 
 error is caused by the *presence* of an unrecognized property.  I know if you 
 read it carefully it says it can't find the property on the class, but this 
 has confused more than one user.
 I think we should catch this exception and wrap it in another exception that 
 says something like this:
 {code}Please remove 'some_property' from your cassandra.yaml. It is not 
 recognized by this version of Cassandra.{code}
 Also, it might make sense to make this a warning instead of a fatal error, 
 and just ignore the unwanted property.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (CASSANDRA-5958) Unable to find property errors from snakeyaml are confusing

2013-09-01 Thread Jonathan Ellis (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-5958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13755865#comment-13755865
 ] 

Jonathan Ellis commented on CASSANDRA-5958:
---

# Skipping missing properties looks like the inverse of the problem here, which 
is dealing with properties that don't exist in the Config class
# We don't want to skip over errors, just turn the stacktrace into a friendlier 
message

 Unable to find property errors from snakeyaml are confusing
 -

 Key: CASSANDRA-5958
 URL: https://issues.apache.org/jira/browse/CASSANDRA-5958
 Project: Cassandra
  Issue Type: Bug
Reporter: J.B. Langston
Priority: Minor
 Attachments: trunk-5958-skip-missing-properties.patch


 When an unexpected property is present in cassandra.yaml (e.g. after 
 upgrading), snakeyaml outputs the following message:
 {code}Unable to find property 'some_property' on class: 
 org.apache.cassandra.config.Config{code}
 The error message is kind of counterintuitive because at first glance it 
 seems to suggest the property is missing from the yaml file, when in fact the 
 error is caused by the *presence* of an unrecognized property.  I know if you 
 read it carefully it says it can't find the property on the class, but this 
 has confused more than one user.
 I think we should catch this exception and wrap it in another exception that 
 says something like this:
 {code}Please remove 'some_property' from your cassandra.yaml. It is not 
 recognized by this version of Cassandra.{code}
 Also, it might make sense to make this a warning instead of a fatal error, 
 and just ignore the unwanted property.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (CASSANDRA-5958) Unable to find property errors from snakeyaml are confusing

2013-08-30 Thread Chris Burroughs (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-5958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754771#comment-13754771
 ] 

Chris Burroughs commented on CASSANDRA-5958:


Which version is this with?  We upgraded snakyaml in 2.0.x and it might have 
improved error messages.

 Unable to find property errors from snakeyaml are confusing
 -

 Key: CASSANDRA-5958
 URL: https://issues.apache.org/jira/browse/CASSANDRA-5958
 Project: Cassandra
  Issue Type: Bug
Reporter: J.B. Langston
Priority: Minor

 When an unexpected property is present in cassandra.yaml (e.g. after 
 upgrading), snakeyaml outputs the following message:
 {code}Unable to find property 'some_property' on class: 
 org.apache.cassandra.config.Config{code}
 The error message is kind of counterintuitive because at first glance it 
 seems to suggest the property is missing from the yaml file, when in fact the 
 error is caused by the *presence* of an unrecognized property.  I know if you 
 read it carefully it says it can't find the property on the class, but this 
 has confused more than one user.
 I think we should catch this exception and wrap it in another exception that 
 says something like this:
 {code}Please remove 'some_property' from your cassandra.yaml. It is not 
 recognized by this version of Cassandra.{code}
 Also, it might make sense to make this a warning instead of a fatal error, 
 and just ignore the unwanted property.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (CASSANDRA-5958) Unable to find property errors from snakeyaml are confusing

2013-08-30 Thread J.B. Langston (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-5958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754836#comment-13754836
 ] 

J.B. Langston commented on CASSANDRA-5958:
--

1.2 and prior

 Unable to find property errors from snakeyaml are confusing
 -

 Key: CASSANDRA-5958
 URL: https://issues.apache.org/jira/browse/CASSANDRA-5958
 Project: Cassandra
  Issue Type: Bug
Reporter: J.B. Langston
Priority: Minor

 When an unexpected property is present in cassandra.yaml (e.g. after 
 upgrading), snakeyaml outputs the following message:
 {code}Unable to find property 'some_property' on class: 
 org.apache.cassandra.config.Config{code}
 The error message is kind of counterintuitive because at first glance it 
 seems to suggest the property is missing from the yaml file, when in fact the 
 error is caused by the *presence* of an unrecognized property.  I know if you 
 read it carefully it says it can't find the property on the class, but this 
 has confused more than one user.
 I think we should catch this exception and wrap it in another exception that 
 says something like this:
 {code}Please remove 'some_property' from your cassandra.yaml. It is not 
 recognized by this version of Cassandra.{code}
 Also, it might make sense to make this a warning instead of a fatal error, 
 and just ignore the unwanted property.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (CASSANDRA-5958) Unable to find property errors from snakeyaml are confusing

2013-08-30 Thread J.B. Langston (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-5958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754928#comment-13754928
 ] 

J.B. Langston commented on CASSANDRA-5958:
--

I just tested with 2.0.0-rc2 and the message is the same as before.

 Unable to find property errors from snakeyaml are confusing
 -

 Key: CASSANDRA-5958
 URL: https://issues.apache.org/jira/browse/CASSANDRA-5958
 Project: Cassandra
  Issue Type: Bug
Reporter: J.B. Langston
Priority: Minor

 When an unexpected property is present in cassandra.yaml (e.g. after 
 upgrading), snakeyaml outputs the following message:
 {code}Unable to find property 'some_property' on class: 
 org.apache.cassandra.config.Config{code}
 The error message is kind of counterintuitive because at first glance it 
 seems to suggest the property is missing from the yaml file, when in fact the 
 error is caused by the *presence* of an unrecognized property.  I know if you 
 read it carefully it says it can't find the property on the class, but this 
 has confused more than one user.
 I think we should catch this exception and wrap it in another exception that 
 says something like this:
 {code}Please remove 'some_property' from your cassandra.yaml. It is not 
 recognized by this version of Cassandra.{code}
 Also, it might make sense to make this a warning instead of a fatal error, 
 and just ignore the unwanted property.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira