[jira] [Commented] (CASSANDRA-7189) Repair hang when specified CF does not exist

2014-05-12 Thread Yuki Morishita (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13995702#comment-13995702
 ] 

Yuki Morishita commented on CASSANDRA-7189:
---

[~mshuler] I pushed the fix in 3fab711ee76c081c0ab5874d64b78673334f9071 to fix 
repair hang when no CF names are given.

 Repair hang when specified CF does not exist
 

 Key: CASSANDRA-7189
 URL: https://issues.apache.org/jira/browse/CASSANDRA-7189
 Project: Cassandra
  Issue Type: Bug
Reporter: Yuki Morishita
Assignee: Yuki Morishita
Priority: Minor
 Fix For: 2.1 rc1

 Attachments: 
 0001-Prevent-repair-from-hanging-when-specified-CF-not-ex.patch


 StorageService#getValidColumnFamilies throws IllegalArgumentException when 
 given CF name does not exist.
 We need to catch that in order to prevent repair from hanging.
 (2.1+ only)



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CASSANDRA-7189) Repair hang when specified CF does not exist

2014-05-12 Thread Michael Shuler (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13995848#comment-13995848
 ] 

Michael Shuler commented on CASSANDRA-7189:
---

Thanks for the patch, [~yukim], repair_test runs fine on 2.1/trunk again  :)

 Repair hang when specified CF does not exist
 

 Key: CASSANDRA-7189
 URL: https://issues.apache.org/jira/browse/CASSANDRA-7189
 Project: Cassandra
  Issue Type: Bug
Reporter: Yuki Morishita
Assignee: Yuki Morishita
Priority: Minor
 Fix For: 2.1 rc1

 Attachments: 
 0001-Prevent-repair-from-hanging-when-specified-CF-not-ex.patch


 StorageService#getValidColumnFamilies throws IllegalArgumentException when 
 given CF name does not exist.
 We need to catch that in order to prevent repair from hanging.
 (2.1+ only)



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CASSANDRA-7189) Repair hang when specified CF does not exist

2014-05-10 Thread Marcus Eriksson (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13993444#comment-13993444
 ] 

Marcus Eriksson commented on CASSANDRA-7189:


+1

nit, i guess we can remove the if(cfStore == null) check in 
getValidColumnFamilies since keyspace.getColumnFamilyStore(..) will never 
return null

 Repair hang when specified CF does not exist
 

 Key: CASSANDRA-7189
 URL: https://issues.apache.org/jira/browse/CASSANDRA-7189
 Project: Cassandra
  Issue Type: Bug
Reporter: Yuki Morishita
Assignee: Yuki Morishita
Priority: Minor
 Fix For: 2.1 rc1

 Attachments: 
 0001-Prevent-repair-from-hanging-when-specified-CF-not-ex.patch


 StorageService#getValidColumnFamilies throws IllegalArgumentException when 
 given CF name does not exist.
 We need to catch that in order to prevent repair from hanging.
 (2.1+ only)



--
This message was sent by Atlassian JIRA
(v6.2#6252)