[jira] [Commented] (CASSANDRA-7595) EmbeddedCassandraService class should provide a stop method

2014-08-04 Thread Lyuben Todorov (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14084426#comment-14084426
 ] 

Lyuben Todorov commented on CASSANDRA-7595:
---

[~mirko.tschaeni] WDUT?

 EmbeddedCassandraService class should provide a stop method
 ---

 Key: CASSANDRA-7595
 URL: https://issues.apache.org/jira/browse/CASSANDRA-7595
 Project: Cassandra
  Issue Type: Improvement
  Components: Core
Reporter: Mirko Tschäni
Assignee: Mirko Tschäni
Priority: Minor
 Fix For: 1.2.19, 2.0.10, 2.1.1

 Attachments: 7595.diff


 The EmbeddedCassandraService does only provide a start method. 
 It should also provide a stop method.
 We use EmbeddedCassandraService to embed cassandra in a osgi application and 
 need to be able to shut down cassandra so that no non daemon threads remain.
 Implementation would be straight forward:
 add the following method to EmbeddedCassandraService:
 public void stop() {
  cassandraDaemon.stop();
 }
 I have tested this implementation locally and it worked as expected (stops 
 all non daemon threads).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (CASSANDRA-7595) EmbeddedCassandraService class should provide a stop method

2014-08-04 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14084442#comment-14084442
 ] 

Mirko Tschäni commented on CASSANDRA-7595:
--

The solution proposed in 7595.diff is exactly what we would like to have. 
Calling CasandraDaemon#deactivate instead of stop is perfect.

 EmbeddedCassandraService class should provide a stop method
 ---

 Key: CASSANDRA-7595
 URL: https://issues.apache.org/jira/browse/CASSANDRA-7595
 Project: Cassandra
  Issue Type: Improvement
  Components: Core
Reporter: Mirko Tschäni
Assignee: Mirko Tschäni
Priority: Minor
 Fix For: 1.2.19, 2.0.10, 2.1.1

 Attachments: 7595.diff


 The EmbeddedCassandraService does only provide a start method. 
 It should also provide a stop method.
 We use EmbeddedCassandraService to embed cassandra in a osgi application and 
 need to be able to shut down cassandra so that no non daemon threads remain.
 Implementation would be straight forward:
 add the following method to EmbeddedCassandraService:
 public void stop() {
  cassandraDaemon.stop();
 }
 I have tested this implementation locally and it worked as expected (stops 
 all non daemon threads).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (CASSANDRA-7595) EmbeddedCassandraService class should provide a stop method

2014-07-23 Thread Lyuben Todorov (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14071614#comment-14071614
 ] 

Lyuben Todorov commented on CASSANDRA-7595:
---

Makes sense, it would be better to call the {{CasandraDaemon#deactivate}} 
method instead of stop incase JSVC hooks are added in the future. 

 EmbeddedCassandraService class should provide a stop method
 ---

 Key: CASSANDRA-7595
 URL: https://issues.apache.org/jira/browse/CASSANDRA-7595
 Project: Cassandra
  Issue Type: Bug
  Components: Core
Reporter: Mirko Tschäni
Priority: Minor

 The EmbeddedCassandraService does only provide a start method. 
 It should also provide a stop method.
 We use EmbeddedCassandraService to embed cassandra in a osgi application and 
 need to be able to shut down cassandra so that no non daemon threads remain.
 Implementation would be straight forward:
 add the following method to EmbeddedCassandraService:
 public void stop() {
  cassandraDaemon.stop();
 }
 I have tested this implementation locally and it worked as expected (stops 
 all non daemon threads).



--
This message was sent by Atlassian JIRA
(v6.2#6252)