[jira] [Commented] (CASSANDRA-7874) Validate functionality of different JSR-223 providers in UDFs
[ https://issues.apache.org/jira/browse/CASSANDRA-7874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14224277#comment-14224277 ] Robert Stupp commented on CASSANDRA-7874: - bq. for some reason I'm unable to apply the patch Hm ... tried it against current trunk (395720c) and the patch applies. {code} snazy in ~/devel/cassandra/trunk on trunk ⚡ git apply ../7874v6.txt ../7874v6.txt:29: trailing whitespace. ../7874v6.txt:30: trailing whitespace. REM JSR223 - collect all JSR223 engines' jars ../7874v6.txt:31: trailing whitespace. for /D %%P in (%CASSANDRA_HOME%\lib\jsr223\*.*) do ( ../7874v6.txt:32: trailing whitespace. for %%i in (%%P\*.jar) do call :append %%i ../7874v6.txt:33: trailing whitespace. ) warning: squelched 77 whitespace errors warning: 82 lines add whitespace errors. {code} Validate functionality of different JSR-223 providers in UDFs - Key: CASSANDRA-7874 URL: https://issues.apache.org/jira/browse/CASSANDRA-7874 Project: Cassandra Issue Type: Task Components: Core Reporter: Robert Stupp Assignee: Robert Stupp Labels: udf Fix For: 3.0 Attachments: 7874.txt, 7874v2.txt, 7874v3.txt, 7874v4.txt, 7874v5.txt, 7874v6.txt CASSANDRA-7526 introduces ability to support optional JSR-223 providers like Clojure, Jython, Groovy or JRuby. This ticket is about to test functionality with these providers but not to include them in C* distribution. Expected result is a how to document, wiki page or similar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7874) Validate functionality of different JSR-223 providers in UDFs
[ https://issues.apache.org/jira/browse/CASSANDRA-7874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14223046#comment-14223046 ] Joshua McKenzie commented on CASSANDRA-7874: +1 from me on the Windows changes Validate functionality of different JSR-223 providers in UDFs - Key: CASSANDRA-7874 URL: https://issues.apache.org/jira/browse/CASSANDRA-7874 Project: Cassandra Issue Type: Task Components: Core Reporter: Robert Stupp Assignee: Robert Stupp Labels: udf Fix For: 3.0 Attachments: 7874.txt, 7874v2.txt, 7874v3.txt, 7874v4.txt, 7874v5.txt, 7874v6.txt CASSANDRA-7526 introduces ability to support optional JSR-223 providers like Clojure, Jython, Groovy or JRuby. This ticket is about to test functionality with these providers but not to include them in C* distribution. Expected result is a how to document, wiki page or similar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7874) Validate functionality of different JSR-223 providers in UDFs
[ https://issues.apache.org/jira/browse/CASSANDRA-7874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14223655#comment-14223655 ] Mikhail Stepura commented on CASSANDRA-7874: for some reason I'm unable to apply the patch {code} 4:21 $ git apply 7874v6.txt 7874v6.txt:29: trailing whitespace. 7874v6.txt:30: trailing whitespace. REM JSR223 - collect all JSR223 engines' jars 7874v6.txt:31: trailing whitespace. for /D %%P in (%CASSANDRA_HOME%\lib\jsr223\*.*) do ( 7874v6.txt:32: trailing whitespace. for %%i in (%%P\*.jar) do call :append %%i 7874v6.txt:33: trailing whitespace. ) error: patch failed: bin/cassandra.bat:85 error: bin/cassandra.bat: patch does not apply error: patch failed: bin/cassandra.in.bat:49 error: bin/cassandra.in.bat: patch does not apply error: patch failed: conf/cassandra-env.ps1:197 error: conf/cassandra-env.ps1: patch does not apply ✘-1 ~/Documents/workspace/cassandra [trunk|…1⚑ 5] {code} Validate functionality of different JSR-223 providers in UDFs - Key: CASSANDRA-7874 URL: https://issues.apache.org/jira/browse/CASSANDRA-7874 Project: Cassandra Issue Type: Task Components: Core Reporter: Robert Stupp Assignee: Robert Stupp Labels: udf Fix For: 3.0 Attachments: 7874.txt, 7874v2.txt, 7874v3.txt, 7874v4.txt, 7874v5.txt, 7874v6.txt CASSANDRA-7526 introduces ability to support optional JSR-223 providers like Clojure, Jython, Groovy or JRuby. This ticket is about to test functionality with these providers but not to include them in C* distribution. Expected result is a how to document, wiki page or similar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7874) Validate functionality of different JSR-223 providers in UDFs
[ https://issues.apache.org/jira/browse/CASSANDRA-7874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14222461#comment-14222461 ] Robert Stupp commented on CASSANDRA-7874: - Seems eligible for commit? Validate functionality of different JSR-223 providers in UDFs - Key: CASSANDRA-7874 URL: https://issues.apache.org/jira/browse/CASSANDRA-7874 Project: Cassandra Issue Type: Task Components: Core Reporter: Robert Stupp Assignee: Robert Stupp Labels: udf Fix For: 3.0 Attachments: 7874.txt, 7874v2.txt, 7874v3.txt, 7874v4.txt, 7874v5.txt, 7874v6.txt CASSANDRA-7526 introduces ability to support optional JSR-223 providers like Clojure, Jython, Groovy or JRuby. This ticket is about to test functionality with these providers but not to include them in C* distribution. Expected result is a how to document, wiki page or similar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7874) Validate functionality of different JSR-223 providers in UDFs
[ https://issues.apache.org/jira/browse/CASSANDRA-7874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14205140#comment-14205140 ] Mikhail Stepura commented on CASSANDRA-7874: @JoshuaMcKenzie could you please review v5 ? Validate functionality of different JSR-223 providers in UDFs - Key: CASSANDRA-7874 URL: https://issues.apache.org/jira/browse/CASSANDRA-7874 Project: Cassandra Issue Type: Task Components: Core Reporter: Robert Stupp Assignee: Robert Stupp Labels: udf Fix For: 3.0 Attachments: 7874.txt, 7874v2.txt, 7874v3.txt, 7874v4.txt, 7874v5.txt CASSANDRA-7526 introduces ability to support optional JSR-223 providers like Clojure, Jython, Groovy or JRuby. This ticket is about to test functionality with these providers but not to include them in C* distribution. Expected result is a how to document, wiki page or similar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7874) Validate functionality of different JSR-223 providers in UDFs
[ https://issues.apache.org/jira/browse/CASSANDRA-7874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14205292#comment-14205292 ] Joshua McKenzie commented on CASSANDRA-7874: v5 has some garbage in cassandra-env.ps1: {code} diff --git a/conf/cassandra-env.ps1 b/conf/cassandra-env.ps1 index 685a86f..cfb281d 100644 --- a/conf/cassandra-env.ps1 +++ b/conf/cassandra-env.ps1 @@ -195,6 +195,42 @@ Function CalculateHeapSizes $env:HEAP_NEWSIZE = [System.Convert]::ToString($desiredYG) + M } } + {code} Similar in cassandra.bat: {code} diff --git a/bin/cassandra.bat b/bin/cassandra.bat index 02f9677..4e3cafc 100644 --- a/bin/cassandra.bat +++ b/bin/cassandra.bat @@ -85,6 +85,33 @@ goto :eof REM - :okClasspath + +REM JSR223 - collect all JSR223 engines' jars {code} Also - we should remove the printed Detected jruby N etc at runtime. All that being said, both legacy .bat run and .ps1 run work w/the garbage removed. A few tweaks and the Windows side is gtg. Validate functionality of different JSR-223 providers in UDFs - Key: CASSANDRA-7874 URL: https://issues.apache.org/jira/browse/CASSANDRA-7874 Project: Cassandra Issue Type: Task Components: Core Reporter: Robert Stupp Assignee: Robert Stupp Labels: udf Fix For: 3.0 Attachments: 7874.txt, 7874v2.txt, 7874v3.txt, 7874v4.txt, 7874v5.txt CASSANDRA-7526 introduces ability to support optional JSR-223 providers like Clojure, Jython, Groovy or JRuby. This ticket is about to test functionality with these providers but not to include them in C* distribution. Expected result is a how to document, wiki page or similar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7874) Validate functionality of different JSR-223 providers in UDFs
[ https://issues.apache.org/jira/browse/CASSANDRA-7874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14196311#comment-14196311 ] Joshua McKenzie commented on CASSANDRA-7874: I can review and test the Windows changes once you have that done. Validate functionality of different JSR-223 providers in UDFs - Key: CASSANDRA-7874 URL: https://issues.apache.org/jira/browse/CASSANDRA-7874 Project: Cassandra Issue Type: Task Components: Core Reporter: Robert Stupp Assignee: Robert Stupp Labels: udf Fix For: 3.0 Attachments: 7874.txt, 7874v2.txt, 7874v3.txt, 7874v4.txt CASSANDRA-7526 introduces ability to support optional JSR-223 providers like Clojure, Jython, Groovy or JRuby. This ticket is about to test functionality with these providers but not to include them in C* distribution. Expected result is a how to document, wiki page or similar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7874) Validate functionality of different JSR-223 providers in UDFs
[ https://issues.apache.org/jira/browse/CASSANDRA-7874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14195072#comment-14195072 ] Mikhail Stepura commented on CASSANDRA-7874: [~snazy] I've verified all the instructions and they are correct, thanks! But you need to port your changes to windows .bat/.ps1 files as well. Validate functionality of different JSR-223 providers in UDFs - Key: CASSANDRA-7874 URL: https://issues.apache.org/jira/browse/CASSANDRA-7874 Project: Cassandra Issue Type: Task Components: Core Reporter: Robert Stupp Assignee: Robert Stupp Labels: udf Fix For: 3.0 Attachments: 7874.txt, 7874v2.txt, 7874v3.txt, 7874v4.txt CASSANDRA-7526 introduces ability to support optional JSR-223 providers like Clojure, Jython, Groovy or JRuby. This ticket is about to test functionality with these providers but not to include them in C* distribution. Expected result is a how to document, wiki page or similar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7874) Validate functionality of different JSR-223 providers in UDFs
[ https://issues.apache.org/jira/browse/CASSANDRA-7874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14195192#comment-14195192 ] Robert Stupp commented on CASSANDRA-7874: - Then I'll remove the dust from that Windows VM and go ahead... ;) Validate functionality of different JSR-223 providers in UDFs - Key: CASSANDRA-7874 URL: https://issues.apache.org/jira/browse/CASSANDRA-7874 Project: Cassandra Issue Type: Task Components: Core Reporter: Robert Stupp Assignee: Robert Stupp Labels: udf Fix For: 3.0 Attachments: 7874.txt, 7874v2.txt, 7874v3.txt, 7874v4.txt CASSANDRA-7526 introduces ability to support optional JSR-223 providers like Clojure, Jython, Groovy or JRuby. This ticket is about to test functionality with these providers but not to include them in C* distribution. Expected result is a how to document, wiki page or similar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7874) Validate functionality of different JSR-223 providers in UDFs
[ https://issues.apache.org/jira/browse/CASSANDRA-7874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14193499#comment-14193499 ] Robert Stupp commented on CASSANDRA-7874: - ping for review ;) Validate functionality of different JSR-223 providers in UDFs - Key: CASSANDRA-7874 URL: https://issues.apache.org/jira/browse/CASSANDRA-7874 Project: Cassandra Issue Type: Task Components: Core Reporter: Robert Stupp Assignee: Robert Stupp Labels: udf Attachments: 7874.txt, 7874v2.txt, 7874v3.txt CASSANDRA-7526 introduces ability to support optional JSR-223 providers like Clojure, Jython, Groovy or JRuby. This ticket is about to test functionality with these providers but not to include them in C* distribution. Expected result is a how to document, wiki page or similar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7874) Validate functionality of different JSR-223 providers in UDFs
[ https://issues.apache.org/jira/browse/CASSANDRA-7874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14193633#comment-14193633 ] Mikhail Stepura commented on CASSANDRA-7874: [~snazy] do we really need those changes for {{DatacenterWriteResponseHandler}} and {{ConsistencyLevel}} in this patch? Validate functionality of different JSR-223 providers in UDFs - Key: CASSANDRA-7874 URL: https://issues.apache.org/jira/browse/CASSANDRA-7874 Project: Cassandra Issue Type: Task Components: Core Reporter: Robert Stupp Assignee: Robert Stupp Labels: udf Attachments: 7874.txt, 7874v2.txt, 7874v3.txt CASSANDRA-7526 introduces ability to support optional JSR-223 providers like Clojure, Jython, Groovy or JRuby. This ticket is about to test functionality with these providers but not to include them in C* distribution. Expected result is a how to document, wiki page or similar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7874) Validate functionality of different JSR-223 providers in UDFs
[ https://issues.apache.org/jira/browse/CASSANDRA-7874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14125363#comment-14125363 ] Robert Stupp commented on CASSANDRA-7874: - {{invokedynamic}} notes: Currently only Groovy and JRuby (on Java8) support invokedynamic. * Groovy provides two variants - one with and one without InvokeDynamic - the readme in contains instructions to use the one with InvokeDynamic. * Jython currently targets Java6 only. They want to switch to J7 + invokedynamic in Jython 3. * Scala 2.10 has J6 support only. 2.11 has experimental indy support. 2.12 introduces an upgrade directly to Java8 (https://stackoverflow.com/questions/14285894/advantages-of-scala-emitting-bytecode-for-the-jvm-1-7). * JRuby uses indy by default on J8 but not on J7 according to https://github.com/jruby/jruby/wiki/PerformanceTuning. Validate functionality of different JSR-223 providers in UDFs - Key: CASSANDRA-7874 URL: https://issues.apache.org/jira/browse/CASSANDRA-7874 Project: Cassandra Issue Type: Task Components: Core Reporter: Robert Stupp Assignee: Robert Stupp Labels: udf Attachments: 7874.txt CASSANDRA-7526 introduces ability to support optional JSR-223 providers like Clojure, Jython, Groovy or JRuby. This ticket is about to test functionality with these providers but not to include them in C* distribution. Expected result is a how to document, wiki page or similar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-7874) Validate functionality of different JSR-223 providers in UDFs
[ https://issues.apache.org/jira/browse/CASSANDRA-7874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14120470#comment-14120470 ] Tyler Hobbs commented on CASSANDRA-7874: For what it's worth, when I was testing CASSANDRA-7526, I discovered that the Python implementation on https://java.net/projects/scripting/ was no good, but just dropping a recent Jython jar in {{/lib}} worked. Validate functionality of different JSR-223 providers in UDFs - Key: CASSANDRA-7874 URL: https://issues.apache.org/jira/browse/CASSANDRA-7874 Project: Cassandra Issue Type: Task Components: Core Reporter: Robert Stupp Assignee: Robert Stupp Labels: udf CASSANDRA-7526 introduces ability to support optional JSR-223 providers like Clojure, Jython, Groovy or JRuby. This ticket is about to test functionality with these providers but not to include them in C* distribution. Expected result is a how to document, wiki page or similar. -- This message was sent by Atlassian JIRA (v6.3.4#6332)