[jira] [Commented] (CASSANDRA-8514) ArrayIndexOutOfBoundsException in nodetool cfhistograms
[
https://issues.apache.org/jira/browse/CASSANDRA-8514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14289977#comment-14289977
]
Benjamin Lerer commented on CASSANDRA-8514:
---
[~jbellis] I need an other review when you have time
ArrayIndexOutOfBoundsException in nodetool cfhistograms
---
Key: CASSANDRA-8514
URL: https://issues.apache.org/jira/browse/CASSANDRA-8514
Project: Cassandra
Issue Type: Bug
Components: Tools
Environment: OSX
Reporter: Philip Thompson
Assignee: Benjamin Lerer
Fix For: 2.1.3
Attachments: CASSANDRA-8514-V2.txt, CASSANDRA-8514-V3.txt,
cassandra-2.1-8514-1.txt
When running nodetool cfhistograms on 2.1-HEAD, I am seeing the following
exception:
{code}
04:02 PM:~/cstar/cassandra[cassandra-2.1*]$ bin/nodetool cfhistograms
keyspace1 standard1
objc[58738]: Class JavaLaunchHelper is implemented in both
/Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/bin/java and
/Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/jre/lib/libinstrument.dylib.
One of the two will be used. Which one is undefined.
error: 0
-- StackTrace --
java.lang.ArrayIndexOutOfBoundsException: 0
at
org.apache.cassandra.utils.EstimatedHistogram.newOffsets(EstimatedHistogram.java:75)
at
org.apache.cassandra.utils.EstimatedHistogram.init(EstimatedHistogram.java:60)
at
org.apache.cassandra.tools.NodeTool$CfHistograms.execute(NodeTool.java:946)
at
org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:250)
at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:164){code}
I can reproduce this with these simple steps:
Start a new C* 2.1-HEAD node
Run {{cassandra-stress write n=1}}
Run {{nodetool cfhistograms keyspace1 standard1}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8514) ArrayIndexOutOfBoundsException in nodetool cfhistograms
[
https://issues.apache.org/jira/browse/CASSANDRA-8514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14290014#comment-14290014
]
Jonathan Ellis commented on CASSANDRA-8514:
---
+1
ArrayIndexOutOfBoundsException in nodetool cfhistograms
---
Key: CASSANDRA-8514
URL: https://issues.apache.org/jira/browse/CASSANDRA-8514
Project: Cassandra
Issue Type: Bug
Components: Tools
Environment: OSX
Reporter: Philip Thompson
Assignee: Benjamin Lerer
Fix For: 2.1.3
Attachments: CASSANDRA-8514-V2.txt, CASSANDRA-8514-V3.txt,
cassandra-2.1-8514-1.txt
When running nodetool cfhistograms on 2.1-HEAD, I am seeing the following
exception:
{code}
04:02 PM:~/cstar/cassandra[cassandra-2.1*]$ bin/nodetool cfhistograms
keyspace1 standard1
objc[58738]: Class JavaLaunchHelper is implemented in both
/Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/bin/java and
/Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/jre/lib/libinstrument.dylib.
One of the two will be used. Which one is undefined.
error: 0
-- StackTrace --
java.lang.ArrayIndexOutOfBoundsException: 0
at
org.apache.cassandra.utils.EstimatedHistogram.newOffsets(EstimatedHistogram.java:75)
at
org.apache.cassandra.utils.EstimatedHistogram.init(EstimatedHistogram.java:60)
at
org.apache.cassandra.tools.NodeTool$CfHistograms.execute(NodeTool.java:946)
at
org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:250)
at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:164){code}
I can reproduce this with these simple steps:
Start a new C* 2.1-HEAD node
Run {{cassandra-stress write n=1}}
Run {{nodetool cfhistograms keyspace1 standard1}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8514) ArrayIndexOutOfBoundsException in nodetool cfhistograms
[
https://issues.apache.org/jira/browse/CASSANDRA-8514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14285799#comment-14285799
]
Jimmy Mårdell commented on CASSANDRA-8514:
--
No problem [~blerer], feel free to work on it. I just submitted a quick patch
but as [~jbellis] points out, it's better to fix the underlying problem.
ArrayIndexOutOfBoundsException in nodetool cfhistograms
---
Key: CASSANDRA-8514
URL: https://issues.apache.org/jira/browse/CASSANDRA-8514
Project: Cassandra
Issue Type: Bug
Components: Tools
Environment: OSX
Reporter: Philip Thompson
Assignee: Jimmy Mårdell
Fix For: 2.1.3
Attachments: cassandra-2.1-8514-1.txt
When running nodetool cfhistograms on 2.1-HEAD, I am seeing the following
exception:
{code}
04:02 PM:~/cstar/cassandra[cassandra-2.1*]$ bin/nodetool cfhistograms
keyspace1 standard1
objc[58738]: Class JavaLaunchHelper is implemented in both
/Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/bin/java and
/Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/jre/lib/libinstrument.dylib.
One of the two will be used. Which one is undefined.
error: 0
-- StackTrace --
java.lang.ArrayIndexOutOfBoundsException: 0
at
org.apache.cassandra.utils.EstimatedHistogram.newOffsets(EstimatedHistogram.java:75)
at
org.apache.cassandra.utils.EstimatedHistogram.init(EstimatedHistogram.java:60)
at
org.apache.cassandra.tools.NodeTool$CfHistograms.execute(NodeTool.java:946)
at
org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:250)
at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:164){code}
I can reproduce this with these simple steps:
Start a new C* 2.1-HEAD node
Run {{cassandra-stress write n=1}}
Run {{nodetool cfhistograms keyspace1 standard1}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8514) ArrayIndexOutOfBoundsException in nodetool cfhistograms
[
https://issues.apache.org/jira/browse/CASSANDRA-8514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14285795#comment-14285795
]
Benjamin Lerer commented on CASSANDRA-8514:
---
Sorry [~yarin] did not realized that you had started to work on that ticket.
ArrayIndexOutOfBoundsException in nodetool cfhistograms
---
Key: CASSANDRA-8514
URL: https://issues.apache.org/jira/browse/CASSANDRA-8514
Project: Cassandra
Issue Type: Bug
Components: Tools
Environment: OSX
Reporter: Philip Thompson
Assignee: Jimmy Mårdell
Fix For: 2.1.3
Attachments: cassandra-2.1-8514-1.txt
When running nodetool cfhistograms on 2.1-HEAD, I am seeing the following
exception:
{code}
04:02 PM:~/cstar/cassandra[cassandra-2.1*]$ bin/nodetool cfhistograms
keyspace1 standard1
objc[58738]: Class JavaLaunchHelper is implemented in both
/Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/bin/java and
/Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/jre/lib/libinstrument.dylib.
One of the two will be used. Which one is undefined.
error: 0
-- StackTrace --
java.lang.ArrayIndexOutOfBoundsException: 0
at
org.apache.cassandra.utils.EstimatedHistogram.newOffsets(EstimatedHistogram.java:75)
at
org.apache.cassandra.utils.EstimatedHistogram.init(EstimatedHistogram.java:60)
at
org.apache.cassandra.tools.NodeTool$CfHistograms.execute(NodeTool.java:946)
at
org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:250)
at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:164){code}
I can reproduce this with these simple steps:
Start a new C* 2.1-HEAD node
Run {{cassandra-stress write n=1}}
Run {{nodetool cfhistograms keyspace1 standard1}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8514) ArrayIndexOutOfBoundsException in nodetool cfhistograms
[
https://issues.apache.org/jira/browse/CASSANDRA-8514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14285875#comment-14285875
]
Benjamin Lerer commented on CASSANDRA-8514:
---
[~jbellis] do you want to be the reviewer?
ArrayIndexOutOfBoundsException in nodetool cfhistograms
---
Key: CASSANDRA-8514
URL: https://issues.apache.org/jira/browse/CASSANDRA-8514
Project: Cassandra
Issue Type: Bug
Components: Tools
Environment: OSX
Reporter: Philip Thompson
Assignee: Benjamin Lerer
Fix For: 2.1.3
Attachments: CASSANDRA-8514-V2.txt, cassandra-2.1-8514-1.txt
When running nodetool cfhistograms on 2.1-HEAD, I am seeing the following
exception:
{code}
04:02 PM:~/cstar/cassandra[cassandra-2.1*]$ bin/nodetool cfhistograms
keyspace1 standard1
objc[58738]: Class JavaLaunchHelper is implemented in both
/Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/bin/java and
/Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/jre/lib/libinstrument.dylib.
One of the two will be used. Which one is undefined.
error: 0
-- StackTrace --
java.lang.ArrayIndexOutOfBoundsException: 0
at
org.apache.cassandra.utils.EstimatedHistogram.newOffsets(EstimatedHistogram.java:75)
at
org.apache.cassandra.utils.EstimatedHistogram.init(EstimatedHistogram.java:60)
at
org.apache.cassandra.tools.NodeTool$CfHistograms.execute(NodeTool.java:946)
at
org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:250)
at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:164){code}
I can reproduce this with these simple steps:
Start a new C* 2.1-HEAD node
Run {{cassandra-stress write n=1}}
Run {{nodetool cfhistograms keyspace1 standard1}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8514) ArrayIndexOutOfBoundsException in nodetool cfhistograms
[
https://issues.apache.org/jira/browse/CASSANDRA-8514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14286442#comment-14286442
]
Jonathan Ellis commented on CASSANDRA-8514:
---
I still think null is a better nothing is here value than empty array (NPE is
more obvious that someone forgot to handle a special case than AIOOB) but I'm
not going to argue, +1 from me.
ArrayIndexOutOfBoundsException in nodetool cfhistograms
---
Key: CASSANDRA-8514
URL: https://issues.apache.org/jira/browse/CASSANDRA-8514
Project: Cassandra
Issue Type: Bug
Components: Tools
Environment: OSX
Reporter: Philip Thompson
Assignee: Benjamin Lerer
Fix For: 2.1.3
Attachments: CASSANDRA-8514-V2.txt, cassandra-2.1-8514-1.txt
When running nodetool cfhistograms on 2.1-HEAD, I am seeing the following
exception:
{code}
04:02 PM:~/cstar/cassandra[cassandra-2.1*]$ bin/nodetool cfhistograms
keyspace1 standard1
objc[58738]: Class JavaLaunchHelper is implemented in both
/Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/bin/java and
/Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/jre/lib/libinstrument.dylib.
One of the two will be used. Which one is undefined.
error: 0
-- StackTrace --
java.lang.ArrayIndexOutOfBoundsException: 0
at
org.apache.cassandra.utils.EstimatedHistogram.newOffsets(EstimatedHistogram.java:75)
at
org.apache.cassandra.utils.EstimatedHistogram.init(EstimatedHistogram.java:60)
at
org.apache.cassandra.tools.NodeTool$CfHistograms.execute(NodeTool.java:946)
at
org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:250)
at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:164){code}
I can reproduce this with these simple steps:
Start a new C* 2.1-HEAD node
Run {{cassandra-stress write n=1}}
Run {{nodetool cfhistograms keyspace1 standard1}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8514) ArrayIndexOutOfBoundsException in nodetool cfhistograms
[
https://issues.apache.org/jira/browse/CASSANDRA-8514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14285493#comment-14285493
]
Benjamin Lerer commented on CASSANDRA-8514:
---
I have to work on nodeTool today. So I will give a look to that problem.
ArrayIndexOutOfBoundsException in nodetool cfhistograms
---
Key: CASSANDRA-8514
URL: https://issues.apache.org/jira/browse/CASSANDRA-8514
Project: Cassandra
Issue Type: Bug
Components: Tools
Environment: OSX
Reporter: Philip Thompson
Assignee: Benjamin Lerer
Fix For: 2.1.3
Attachments: cassandra-2.1-8514-1.txt
When running nodetool cfhistograms on 2.1-HEAD, I am seeing the following
exception:
{code}
04:02 PM:~/cstar/cassandra[cassandra-2.1*]$ bin/nodetool cfhistograms
keyspace1 standard1
objc[58738]: Class JavaLaunchHelper is implemented in both
/Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/bin/java and
/Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/jre/lib/libinstrument.dylib.
One of the two will be used. Which one is undefined.
error: 0
-- StackTrace --
java.lang.ArrayIndexOutOfBoundsException: 0
at
org.apache.cassandra.utils.EstimatedHistogram.newOffsets(EstimatedHistogram.java:75)
at
org.apache.cassandra.utils.EstimatedHistogram.init(EstimatedHistogram.java:60)
at
org.apache.cassandra.tools.NodeTool$CfHistograms.execute(NodeTool.java:946)
at
org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:250)
at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:164){code}
I can reproduce this with these simple steps:
Start a new C* 2.1-HEAD node
Run {{cassandra-stress write n=1}}
Run {{nodetool cfhistograms keyspace1 standard1}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8514) ArrayIndexOutOfBoundsException in nodetool cfhistograms
[
https://issues.apache.org/jira/browse/CASSANDRA-8514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14276206#comment-14276206
]
Jonathan Ellis commented on CASSANDRA-8514:
---
It looks to me like the cause is this:
{code}
private static long[] combineHistograms(IterableSSTableReader sstables,
GetHistogram getHistogram)
{
IteratorSSTableReader iterator = sstables.iterator();
if (!iterator.hasNext())
{
return new long[0];
}
{code}
... which really isn't a valid histogram bucket array. So rather than hacking
histogram to try to turn nonsense back into a histogram, would it make more
sense to return null and deal with that correctly in nodetool?
/cc [~carlyeks]
ArrayIndexOutOfBoundsException in nodetool cfhistograms
---
Key: CASSANDRA-8514
URL: https://issues.apache.org/jira/browse/CASSANDRA-8514
Project: Cassandra
Issue Type: Bug
Components: Tools
Environment: OSX
Reporter: Philip Thompson
Fix For: 2.1.3
Attachments: cassandra-2.1-8514-1.txt
When running nodetool cfhistograms on 2.1-HEAD, I am seeing the following
exception:
{code}
04:02 PM:~/cstar/cassandra[cassandra-2.1*]$ bin/nodetool cfhistograms
keyspace1 standard1
objc[58738]: Class JavaLaunchHelper is implemented in both
/Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/bin/java and
/Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/jre/lib/libinstrument.dylib.
One of the two will be used. Which one is undefined.
error: 0
-- StackTrace --
java.lang.ArrayIndexOutOfBoundsException: 0
at
org.apache.cassandra.utils.EstimatedHistogram.newOffsets(EstimatedHistogram.java:75)
at
org.apache.cassandra.utils.EstimatedHistogram.init(EstimatedHistogram.java:60)
at
org.apache.cassandra.tools.NodeTool$CfHistograms.execute(NodeTool.java:946)
at
org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:250)
at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:164){code}
I can reproduce this with these simple steps:
Start a new C* 2.1-HEAD node
Run {{cassandra-stress write n=1}}
Run {{nodetool cfhistograms keyspace1 standard1}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8514) ArrayIndexOutOfBoundsException in nodetool cfhistograms
[
https://issues.apache.org/jira/browse/CASSANDRA-8514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14272017#comment-14272017
]
Jimmy Mårdell commented on CASSANDRA-8514:
--
Yes, I've seen this as well. Simple patch attached.
ArrayIndexOutOfBoundsException in nodetool cfhistograms
---
Key: CASSANDRA-8514
URL: https://issues.apache.org/jira/browse/CASSANDRA-8514
Project: Cassandra
Issue Type: Bug
Components: Tools
Environment: OSX
Reporter: Philip Thompson
Fix For: 2.1.3
Attachments: cassandra-2.1-8514-1.txt
When running nodetool cfhistograms on 2.1-HEAD, I am seeing the following
exception:
{code}
04:02 PM:~/cstar/cassandra[cassandra-2.1*]$ bin/nodetool cfhistograms
keyspace1 standard1
objc[58738]: Class JavaLaunchHelper is implemented in both
/Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/bin/java and
/Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/jre/lib/libinstrument.dylib.
One of the two will be used. Which one is undefined.
error: 0
-- StackTrace --
java.lang.ArrayIndexOutOfBoundsException: 0
at
org.apache.cassandra.utils.EstimatedHistogram.newOffsets(EstimatedHistogram.java:75)
at
org.apache.cassandra.utils.EstimatedHistogram.init(EstimatedHistogram.java:60)
at
org.apache.cassandra.tools.NodeTool$CfHistograms.execute(NodeTool.java:946)
at
org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:250)
at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:164){code}
I can reproduce this with these simple steps:
Start a new C* 2.1-HEAD node
Run {{cassandra-stress write n=1}}
Run {{nodetool cfhistograms keyspace1 standard1}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
