[jira] [Commented] (CASSANDRA-8662) Switch cfhistograms from using yammer metrics in 2.1
[ https://issues.apache.org/jira/browse/CASSANDRA-8662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14287616#comment-14287616 ] Aleksey Yeschenko commented on CASSANDRA-8662: -- Committed to 2.1 only (as is, but with now unused metricPercentilesAsArray(JmxReporter.HistogramMBean) method killed). Thanks! Switch cfhistograms from using yammer metrics in 2.1 Key: CASSANDRA-8662 URL: https://issues.apache.org/jira/browse/CASSANDRA-8662 Project: Cassandra Issue Type: Improvement Components: Core Reporter: Chris Lohfink Assignee: Chris Lohfink Fix For: 2.1.3 Attachments: CASSANDRA-8662v1.txt cfhistograms was changed to use the yammer histograms CASSANDRA-5871. Until CASSANDRA-5657's change to metrics we shouldn't represent the yammer histogram for latency metrics. Yammer's histogram is based on assumption of a normal distribution and is bad at representing the tail percentiles with skewed distributions. So revert the change just in the 2.1 branch but leave it for 3.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8662) Switch cfhistograms from using yammer metrics in 2.1
[ https://issues.apache.org/jira/browse/CASSANDRA-8662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14286083#comment-14286083 ] Aleksey Yeschenko commented on CASSANDRA-8662: -- Would love to, but not sure if we can do it without breaking backward compatibility in a minor release (looking at pluggable metrics reporting breakage). Also, it's a reasonable amount of codes, probably too much for a 2.1 minor :( Switch cfhistograms from using yammer metrics in 2.1 Key: CASSANDRA-8662 URL: https://issues.apache.org/jira/browse/CASSANDRA-8662 Project: Cassandra Issue Type: Improvement Components: Core Reporter: Chris Lohfink Assignee: Chris Lohfink Fix For: 2.1.3 Attachments: CASSANDRA-8662v1.txt cfhistograms was changed to use the yammer histograms CASSANDRA-5871. Until CASSANDRA-5657's change to metrics we shouldn't represent the yammer histogram for latency metrics. Yammer's histogram is based on assumption of a normal distribution and is bad at representing the tail percentiles with skewed distributions. So revert the change just in the 2.1 branch but leave it for 3.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8662) Switch cfhistograms from using yammer metrics in 2.1
[ https://issues.apache.org/jira/browse/CASSANDRA-8662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14286112#comment-14286112 ] Aleksey Yeschenko commented on CASSANDRA-8662: -- Oh well. My bad for not looking into it well enough (haven't noticed the patch, thought you wanted to backport CASSANDRA-5657. This - we can do. Switch cfhistograms from using yammer metrics in 2.1 Key: CASSANDRA-8662 URL: https://issues.apache.org/jira/browse/CASSANDRA-8662 Project: Cassandra Issue Type: Improvement Components: Core Reporter: Chris Lohfink Assignee: Chris Lohfink Fix For: 2.1.3 Attachments: CASSANDRA-8662v1.txt cfhistograms was changed to use the yammer histograms CASSANDRA-5871. Until CASSANDRA-5657's change to metrics we shouldn't represent the yammer histogram for latency metrics. Yammer's histogram is based on assumption of a normal distribution and is bad at representing the tail percentiles with skewed distributions. So revert the change just in the 2.1 branch but leave it for 3.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-8662) Switch cfhistograms from using yammer metrics in 2.1
[ https://issues.apache.org/jira/browse/CASSANDRA-8662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14286105#comment-14286105 ] Chris Lohfink commented on CASSANDRA-8662: -- In attached patch the output would be the same, just changing from backing it with the Histogram to using the EstimatedHistogram (which 2 of the 5 metrics used anyway). Switch cfhistograms from using yammer metrics in 2.1 Key: CASSANDRA-8662 URL: https://issues.apache.org/jira/browse/CASSANDRA-8662 Project: Cassandra Issue Type: Improvement Components: Core Reporter: Chris Lohfink Assignee: Chris Lohfink Fix For: 2.1.3 Attachments: CASSANDRA-8662v1.txt cfhistograms was changed to use the yammer histograms CASSANDRA-5871. Until CASSANDRA-5657's change to metrics we shouldn't represent the yammer histogram for latency metrics. Yammer's histogram is based on assumption of a normal distribution and is bad at representing the tail percentiles with skewed distributions. So revert the change just in the 2.1 branch but leave it for 3.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)