[jira] [Commented] (CASSANDRA-9378) Instrument the logger with error count metrics by level
[ https://issues.apache.org/jira/browse/CASSANDRA-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14588236#comment-14588236 ] Jeremiah Jordan commented on CASSANDRA-9378: I think we should probably make the appender name in the logback.xml LockbackMetrics or something not just Logback. Otherwise +1 a Logback metric shows up in JMX. Instrument the logger with error count metrics by level --- Key: CASSANDRA-9378 URL: https://issues.apache.org/jira/browse/CASSANDRA-9378 Project: Cassandra Issue Type: Improvement Components: Core, Tools Reporter: Jonathan Shook Assignee: Yuki Morishita Priority: Minor Fix For: 2.2.x The ability to do sanity checks against logged errors and warning counts could be helpful for several reasons. One of the most obvious would be as a way to verify that no errors were logged during a (semi-) automated upgrade or restart process. Fortunately, this is easy to enable as described here: https://dropwizard.github.io/metrics/3.1.0/manual/logback/ It was pointed out by [~jjordan] that this ability should exist in current version if the user is willing to drop in the right jars and modify the appender config. It would also be helpful as a programmatic feature with a toggle to enable or disable, possibly with a cassandra.yaml config parameter. There may be some users who would prefer to disable it to avoid calling another appender. If testing shows the overhead for this to be sufficiently low, we could just leave it on by default. These should be exposed via JMX when they are enabled. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9378) Instrument the logger with error count metrics by level
[ https://issues.apache.org/jira/browse/CASSANDRA-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14573089#comment-14573089 ] Jonathan Ellis commented on CASSANDRA-9378: --- [~jjordan] or [~jshook] to review? Instrument the logger with error count metrics by level --- Key: CASSANDRA-9378 URL: https://issues.apache.org/jira/browse/CASSANDRA-9378 Project: Cassandra Issue Type: Improvement Components: Core, Tools Reporter: Jonathan Shook Assignee: Yuki Morishita Priority: Minor Fix For: 2.2.x The ability to do sanity checks against logged errors and warning counts could be helpful for several reasons. One of the most obvious would be as a way to verify that no errors were logged during a (semi-) automated upgrade or restart process. Fortunately, this is easy to enable as described here: https://dropwizard.github.io/metrics/3.1.0/manual/logback/ It was pointed out by [~jjordan] that this ability should exist in current version if the user is willing to drop in the right jars and modify the appender config. It would also be helpful as a programmatic feature with a toggle to enable or disable, possibly with a cassandra.yaml config parameter. There may be some users who would prefer to disable it to avoid calling another appender. If testing shows the overhead for this to be sufficiently low, we could just leave it on by default. These should be exposed via JMX when they are enabled. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9378) Instrument the logger with error count metrics by level
[ https://issues.apache.org/jira/browse/CASSANDRA-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14572998#comment-14572998 ] Yuki Morishita commented on CASSANDRA-9378: --- Initial patch here: https://github.com/yukim/cassandra/tree/9378 * Users can opt in logback metrics only by enabling it in logback.xml * Little draw back for this approach is I had to remove access to Logger in CassandraMetrics, since instrumented appender is created when LoggerFactory is accessed. We want to configure metrics then initialize Logger. But this way we can catch metrics from the beginning. Instrument the logger with error count metrics by level --- Key: CASSANDRA-9378 URL: https://issues.apache.org/jira/browse/CASSANDRA-9378 Project: Cassandra Issue Type: Improvement Components: Core, Tools Reporter: Jonathan Shook Assignee: Yuki Morishita Priority: Minor Fix For: 2.2.x The ability to do sanity checks against logged errors and warning counts could be helpful for several reasons. One of the most obvious would be as a way to verify that no errors were logged during a (semi-) automated upgrade or restart process. Fortunately, this is easy to enable as described here: https://dropwizard.github.io/metrics/3.1.0/manual/logback/ It was pointed out by [~jjordan] that this ability should exist in current version if the user is willing to drop in the right jars and modify the appender config. It would also be helpful as a programmatic feature with a toggle to enable or disable, possibly with a cassandra.yaml config parameter. There may be some users who would prefer to disable it to avoid calling another appender. If testing shows the overhead for this to be sufficiently low, we could just leave it on by default. These should be exposed via JMX when they are enabled. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9378) Instrument the logger with error count metrics by level
[ https://issues.apache.org/jira/browse/CASSANDRA-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14543199#comment-14543199 ] Jonathan Ellis commented on CASSANDRA-9378: --- (We're already on Metrics 3.1 in trunk, so this should be easy to enable in 2.2.x per [~yukim].) Instrument the logger with error count metrics by level --- Key: CASSANDRA-9378 URL: https://issues.apache.org/jira/browse/CASSANDRA-9378 Project: Cassandra Issue Type: Improvement Components: Core, Tools Reporter: Jonathan Shook Priority: Minor Fix For: 2.2.x The ability to do sanity checks against logged errors and warning counts could be helpful for several reasons. One of the most obvious would be as a way to verify that no errors were logged during a (semi-) automated upgrade or restart process. Fortunately, this is easy to enable as described here: https://dropwizard.github.io/metrics/3.1.0/manual/logback/ It was pointed out by [~jjordan] that this ability should exist in current version if the user is willing to drop in the right jars and modify the appender config. It would also be helpful as a programmatic feature with a toggle to enable or disable, possibly with a cassandra.yaml config parameter. There may be some users who would prefer to disable it to avoid calling another appender. If testing shows the overhead for this to be sufficiently low, we could just leave it on by default. These should be exposed via JMX when they are enabled. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
