[jira] [Commented] (CASSANDRA-9452) Remove configuration of storage-conf from tools
[
https://issues.apache.org/jira/browse/CASSANDRA-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399987#comment-16399987
]
Vinay Chella commented on CASSANDRA-9452:
-
[~jolynch] [~jjirsa] Cleaned up unused {{test/resources/functions}} folder.
Updated patch is attached as CASSANDRA-14092-trunk_v1.txt
Here is the
[circleci|https://circleci.com/gh/vinaykumarchella/cassandra/tree/CASSANDRA-9452]
> Remove configuration of storage-conf from tools
> ---
>
> Key: CASSANDRA-9452
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9452
> Project: Cassandra
> Issue Type: Task
> Components: Configuration, Testing, Tools
>Reporter: Mike Adamson
>Assignee: Vinay Chella
>Priority: Minor
> Labels: lhf
> Fix For: 4.x
>
> Attachments: CASSANDRA-14092-trunk_v1.txt, CASSANDRA-9452-trunk.txt
>
>
> The following files still making reference to storage-config and/or
> storage-conf.xml
> * ./build.xml
> * ./bin/nodetool
> * ./bin/sstablekeys
> * ./test/resources/functions/configure_cassandra.sh
> * ./test/resources/functions/install_cassandra.sh
> * ./tools/bin/json2sstable
> * ./tools/bin/sstable2json
> * ./tools/bin/sstablelevelreset
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-9452) Remove configuration of storage-conf from tools
[ https://issues.apache.org/jira/browse/CASSANDRA-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395719#comment-16395719 ] Vinay Chella commented on CASSANDRA-9452: - [~jjirsa][~mshuler] Yes, I could not find any references to either. Any concerns if I attempt to clean up this directory? > Remove configuration of storage-conf from tools > --- > > Key: CASSANDRA-9452 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9452 > Project: Cassandra > Issue Type: Task > Components: Configuration, Testing, Tools >Reporter: Mike Adamson >Assignee: Vinay Chella >Priority: Minor > Labels: lhf > Fix For: 4.x > > Attachments: CASSANDRA-9452-trunk.txt > > > The following files still making reference to storage-config and/or > storage-conf.xml > * ./build.xml > * ./bin/nodetool > * ./bin/sstablekeys > * ./test/resources/functions/configure_cassandra.sh > * ./test/resources/functions/install_cassandra.sh > * ./tools/bin/json2sstable > * ./tools/bin/sstable2json > * ./tools/bin/sstablelevelreset -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-9452) Remove configuration of storage-conf from tools
[
https://issues.apache.org/jira/browse/CASSANDRA-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393723#comment-16393723
]
Michael Shuler commented on CASSANDRA-9452:
---
I don't see these functions used anywhere else in-tree.
{noformat}
(trunk)mshuler@hana:~/git/cassandra$ for f in `ls -1 test/resources/functions/|
cut -d . -f 1`; do git grep $f; done
test/resources/functions/configure_cassandra.sh:function configure_cassandra() {
test/resources/functions/install_cassandra.sh:function install_cassandra() {
test/resources/functions/nodetool_cassandra.sh:function nodetool_cassandra() {
test/resources/functions/start_cassandra.sh:function start_cassandra() {
test/resources/functions/stop_cassandra.sh:function stop_cassandra() {
test/resources/functions/wipe_cassandra.sh:function wipe_cassandra() {
{noformat}
> Remove configuration of storage-conf from tools
> ---
>
> Key: CASSANDRA-9452
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9452
> Project: Cassandra
> Issue Type: Task
> Components: Configuration, Testing, Tools
>Reporter: Mike Adamson
>Assignee: Vinay Chella
>Priority: Minor
> Labels: lhf
> Fix For: 4.x
>
> Attachments: CASSANDRA-9452-trunk.txt
>
>
> The following files still making reference to storage-config and/or
> storage-conf.xml
> * ./build.xml
> * ./bin/nodetool
> * ./bin/sstablekeys
> * ./test/resources/functions/configure_cassandra.sh
> * ./test/resources/functions/install_cassandra.sh
> * ./tools/bin/json2sstable
> * ./tools/bin/sstable2json
> * ./tools/bin/sstablelevelreset
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-9452) Remove configuration of storage-conf from tools
[ https://issues.apache.org/jira/browse/CASSANDRA-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393715#comment-16393715 ] Michael Shuler commented on CASSANDRA-9452: --- `git log test/resources/functions/install_cassandra.sh` shows an old 0.8 svn merge commit and one for log4j -> logback. Wouldn't be Debian packaging. The script installs some env vars, an /etc/rc.local line, etc. so looks like just a helpful old manual install remnant script to me. > Remove configuration of storage-conf from tools > --- > > Key: CASSANDRA-9452 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9452 > Project: Cassandra > Issue Type: Task > Components: Configuration, Testing, Tools >Reporter: Mike Adamson >Assignee: Vinay Chella >Priority: Minor > Labels: lhf > Fix For: 4.x > > Attachments: CASSANDRA-9452-trunk.txt > > > The following files still making reference to storage-config and/or > storage-conf.xml > * ./build.xml > * ./bin/nodetool > * ./bin/sstablekeys > * ./test/resources/functions/configure_cassandra.sh > * ./test/resources/functions/install_cassandra.sh > * ./tools/bin/json2sstable > * ./tools/bin/sstable2json > * ./tools/bin/sstablelevelreset -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-9452) Remove configuration of storage-conf from tools
[ https://issues.apache.org/jira/browse/CASSANDRA-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393696#comment-16393696 ] Jeff Jirsa commented on CASSANDRA-9452: --- I dont , but maybe [~urandom] , [~tjake] or [~mshuler] may? Old debian packaging? > Remove configuration of storage-conf from tools > --- > > Key: CASSANDRA-9452 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9452 > Project: Cassandra > Issue Type: Task > Components: Configuration, Testing, Tools >Reporter: Mike Adamson >Assignee: Vinay Chella >Priority: Minor > Labels: lhf > Fix For: 4.x > > Attachments: CASSANDRA-9452-trunk.txt > > > The following files still making reference to storage-config and/or > storage-conf.xml > * ./build.xml > * ./bin/nodetool > * ./bin/sstablekeys > * ./test/resources/functions/configure_cassandra.sh > * ./test/resources/functions/install_cassandra.sh > * ./tools/bin/json2sstable > * ./tools/bin/sstable2json > * ./tools/bin/sstablelevelreset -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-9452) Remove configuration of storage-conf from tools
[
https://issues.apache.org/jira/browse/CASSANDRA-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393694#comment-16393694
]
Vinay Chella commented on CASSANDRA-9452:
-
Not sure if {{test/resources/functions/install_cassandra.sh}} is used
anywhere. I could not find the references to it. I will open separate JIRA to
clean up {{test/resources/functions}} folder.
[~jjirsa] Do you have context on
{{test/resources/functions/install_cassandra.sh}} ?
> Remove configuration of storage-conf from tools
> ---
>
> Key: CASSANDRA-9452
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9452
> Project: Cassandra
> Issue Type: Task
> Components: Configuration, Testing, Tools
>Reporter: Mike Adamson
>Assignee: Vinay Chella
>Priority: Minor
> Labels: lhf
> Fix For: 4.x
>
> Attachments: CASSANDRA-9452-trunk.txt
>
>
> The following files still making reference to storage-config and/or
> storage-conf.xml
> * ./build.xml
> * ./bin/nodetool
> * ./bin/sstablekeys
> * ./test/resources/functions/configure_cassandra.sh
> * ./test/resources/functions/install_cassandra.sh
> * ./tools/bin/json2sstable
> * ./tools/bin/sstable2json
> * ./tools/bin/sstablelevelreset
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-9452) Remove configuration of storage-conf from tools
[
https://issues.apache.org/jira/browse/CASSANDRA-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393393#comment-16393393
]
Joseph Lynch commented on CASSANDRA-9452:
-
lg2m
Can you remove the entire 0.6 version check from {{install_cassandra.sh}} while
you're at it. Actually looking at it I'm not even sure if
{{test/resources/functions/install_cassandra.sh}} is used at all?
> Remove configuration of storage-conf from tools
> ---
>
> Key: CASSANDRA-9452
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9452
> Project: Cassandra
> Issue Type: Task
> Components: Configuration, Testing, Tools
>Reporter: Mike Adamson
>Assignee: Vinay Chella
>Priority: Minor
> Labels: lhf
> Fix For: 4.x
>
> Attachments: CASSANDRA-9452-trunk.txt
>
>
> The following files still making reference to storage-config and/or
> storage-conf.xml
> * ./build.xml
> * ./bin/nodetool
> * ./bin/sstablekeys
> * ./test/resources/functions/configure_cassandra.sh
> * ./test/resources/functions/install_cassandra.sh
> * ./tools/bin/json2sstable
> * ./tools/bin/sstable2json
> * ./tools/bin/sstablelevelreset
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-9452) Remove configuration of storage-conf from tools
[ https://issues.apache.org/jira/browse/CASSANDRA-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390549#comment-16390549 ] Vinay Chella commented on CASSANDRA-9452: - Attaching the patch. Tried to clean up wherever I could found the references to storage-conf. Here is the circleci build status - https://circleci.com/gh/vinaykumarchella/cassandra/tree/CASSANDRA-9452 > Remove configuration of storage-conf from tools > --- > > Key: CASSANDRA-9452 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9452 > Project: Cassandra > Issue Type: Task > Components: Configuration, Testing, Tools >Reporter: Mike Adamson >Priority: Minor > Labels: lhf > Fix For: 4.x > > Attachments: CASSANDRA-9452.diff > > > The following files still making reference to storage-config and/or > storage-conf.xml > * ./build.xml > * ./bin/nodetool > * ./bin/sstablekeys > * ./test/resources/functions/configure_cassandra.sh > * ./test/resources/functions/install_cassandra.sh > * ./tools/bin/json2sstable > * ./tools/bin/sstable2json > * ./tools/bin/sstablelevelreset -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-9452) Remove configuration of storage-conf from tools
[
https://issues.apache.org/jira/browse/CASSANDRA-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287124#comment-16287124
]
Jeff Jirsa commented on CASSANDRA-9452:
---
Remarkably still true as we enter 2018, now only in {{build.xml}} and
{{test/resources/functions/install_cassandra.sh}} .
> Remove configuration of storage-conf from tools
> ---
>
> Key: CASSANDRA-9452
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9452
> Project: Cassandra
> Issue Type: Task
> Components: Configuration, Testing, Tools
>Reporter: Mike Adamson
>Priority: Minor
> Labels: lhf
> Fix For: 4.x
>
>
> The following files still making reference to storage-config and/or
> storage-conf.xml
> * ./build.xml
> * ./bin/nodetool
> * ./bin/sstablekeys
> * ./test/resources/functions/configure_cassandra.sh
> * ./test/resources/functions/install_cassandra.sh
> * ./tools/bin/json2sstable
> * ./tools/bin/sstable2json
> * ./tools/bin/sstablelevelreset
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
