[jira] [Commented] (CASSANDRA-9875) Rebuild from targeted replica
[ https://issues.apache.org/jira/browse/CASSANDRA-9875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218755#comment-17218755 ] Cameron Zemek commented on CASSANDRA-9875: -- I have attached backport of this patch for 2.1 in order to support rebuild tool we are releasing. > Rebuild from targeted replica > - > > Key: CASSANDRA-9875 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9875 > Project: Cassandra > Issue Type: Improvement >Reporter: Sankalp Kohli >Assignee: Geoffrey Yu >Priority: Low > Labels: lhf > Fix For: 3.10 > > Attachments: 9875-dtest-master-v2.txt, 9875-dtest-master.txt, > 9875-trunk-v2.txt, 9875-trunk.txt, rebuild21.patch > > > Nodetool rebuild command will rebuild all the token ranges handled by the > endpoint. Sometimes we want to rebuild only a certain token range. We should > add this ability to rebuild command. We should also add the ability to stream > from a given replica. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-9875) Rebuild from targeted replica
[ https://issues.apache.org/jira/browse/CASSANDRA-9875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435213#comment-15435213 ] Aleksey Yeschenko commented on CASSANDRA-9875: -- Committed as [824cb768d2aa45e1889653ab2c98cc0bc63e594e|https://github.com/apache/cassandra/commit/824cb768d2aa45e1889653ab2c98cc0bc63e594e] to trunk, thanks. > Rebuild from targeted replica > - > > Key: CASSANDRA-9875 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9875 > Project: Cassandra > Issue Type: Improvement >Reporter: sankalp kohli >Assignee: Geoffrey Yu >Priority: Minor > Labels: lhf > Fix For: 3.x > > Attachments: 9875-dtest-master-v2.txt, 9875-dtest-master.txt, > 9875-trunk-v2.txt, 9875-trunk.txt > > > Nodetool rebuild command will rebuild all the token ranges handled by the > endpoint. Sometimes we want to rebuild only a certain token range. We should > add this ability to rebuild command. We should also add the ability to stream > from a given replica. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9875) Rebuild from targeted replica
[ https://issues.apache.org/jira/browse/CASSANDRA-9875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15433601#comment-15433601 ] Geoffrey Yu commented on CASSANDRA-9875: Thanks! I've opened a PR for the dtests [here|https://github.com/riptano/cassandra-dtest/pull/1273]. I'll keep an eye on the tests and look in to any failures that come up. > Rebuild from targeted replica > - > > Key: CASSANDRA-9875 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9875 > Project: Cassandra > Issue Type: Improvement >Reporter: sankalp kohli >Assignee: Geoffrey Yu >Priority: Minor > Labels: lhf > Fix For: 3.x > > Attachments: 9875-dtest-master-v2.txt, 9875-dtest-master.txt, > 9875-trunk-v2.txt, 9875-trunk.txt > > > Nodetool rebuild command will rebuild all the token ranges handled by the > endpoint. Sometimes we want to rebuild only a certain token range. We should > add this ability to rebuild command. We should also add the ability to stream > from a given replica. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9875) Rebuild from targeted replica
[ https://issues.apache.org/jira/browse/CASSANDRA-9875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15433383#comment-15433383 ] Paulo Motta commented on CASSANDRA-9875: Thanks for the quick update, I think this looks great! I prepared the patch for commit and submitted CI runs: ||trunk|| |[branch|https://github.com/apache/cassandra/compare/trunk...pauloricardomg:trunk-9875]| |[testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-trunk-9875-testall/lastCompletedBuild/testReport/]| |[dtest|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-trunk-9875-dtest/lastCompletedBuild/testReport/]| I will mark this as ready to commit after CI results look good. Could you please open a [cassandra-dtest|https://github.com/riptano/cassandra-dtest] pull request? > Rebuild from targeted replica > - > > Key: CASSANDRA-9875 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9875 > Project: Cassandra > Issue Type: Improvement >Reporter: sankalp kohli >Assignee: Geoffrey Yu >Priority: Minor > Labels: lhf > Fix For: 3.x > > Attachments: 9875-dtest-master-v2.txt, 9875-dtest-master.txt, > 9875-trunk-v2.txt, 9875-trunk.txt > > > Nodetool rebuild command will rebuild all the token ranges handled by the > endpoint. Sometimes we want to rebuild only a certain token range. We should > add this ability to rebuild command. We should also add the ability to stream > from a given replica. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9875) Rebuild from targeted replica
[
https://issues.apache.org/jira/browse/CASSANDRA-9875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432940#comment-15432940
]
Paulo Motta commented on CASSANDRA-9875:
Thanks for the follow-up! Implementation looks great and much cleaner now.
Dtests also look good, can you just add an additional test (or perhaps just
extend {{disallow_rebuild_nonlocal_range}} so a new setup is not needed),
verifying that the error {{Unable to find sufficient sources for streaming
range}} is thrown if you specify a non-replica as {{-hosts}} ? Also, can you
add {{@no_vnodes}} annotation so the test are only run in the no vnodes suite?
Thanks!
> Rebuild from targeted replica
> -
>
> Key: CASSANDRA-9875
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9875
> Project: Cassandra
> Issue Type: Improvement
>Reporter: sankalp kohli
>Assignee: Geoffrey Yu
>Priority: Minor
> Labels: lhf
> Fix For: 3.x
>
> Attachments: 9875-dtest-master.txt, 9875-trunk-v2.txt, 9875-trunk.txt
>
>
> Nodetool rebuild command will rebuild all the token ranges handled by the
> endpoint. Sometimes we want to rebuild only a certain token range. We should
> add this ability to rebuild command. We should also add the ability to stream
> from a given replica.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9875) Rebuild from targeted replica
[
https://issues.apache.org/jira/browse/CASSANDRA-9875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428458#comment-15428458
]
Geoffrey Yu commented on CASSANDRA-9875:
No worries about the delay! Yeah I totally agree, adding a host whitelist would
be a better interface. I somehow missed the source filter in the
{{RangeStreamer}}. I'll take a look, make the changes, and add a dtest.
> Rebuild from targeted replica
> -
>
> Key: CASSANDRA-9875
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9875
> Project: Cassandra
> Issue Type: Improvement
>Reporter: sankalp kohli
>Assignee: Geoffrey Yu
>Priority: Minor
> Labels: lhf
> Fix For: 3.x
>
> Attachments: 9875-trunk.txt
>
>
> Nodetool rebuild command will rebuild all the token ranges handled by the
> endpoint. Sometimes we want to rebuild only a certain token range. We should
> add this ability to rebuild command. We should also add the ability to stream
> from a given replica.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-9875) Rebuild from targeted replica
[
https://issues.apache.org/jira/browse/CASSANDRA-9875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427414#comment-15427414
]
Paulo Motta commented on CASSANDRA-9875:
Sorry for the delay here. Implementation looks mostly good, but I find the UI a
bit counter-intuitive, since if you want to rebuild multiple ranges from a
single or small set of sources (a typical use case IMO), you'd need to repeat a
source multiple times (one for each specified range). Unless you have a use
case in mind for this, I think a more intuitive interface would be a host
whitelist (similar to repair {{--hosts}}), and this would also make
implementation a bit simpler, since you could simply add a source filter to
RangeStreamer (avoiding the need for {{addRangesWithSources}}). This would
still allow you to specify a direct range-source mapping by running multiple
rebuild commands. WDYT?
Also, could you add a simple dtest?
> Rebuild from targeted replica
> -
>
> Key: CASSANDRA-9875
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9875
> Project: Cassandra
> Issue Type: Improvement
>Reporter: sankalp kohli
>Assignee: Geoffrey Yu
>Priority: Minor
> Labels: lhf
> Fix For: 3.x
>
> Attachments: 9875-trunk.txt
>
>
> Nodetool rebuild command will rebuild all the token ranges handled by the
> endpoint. Sometimes we want to rebuild only a certain token range. We should
> add this ability to rebuild command. We should also add the ability to stream
> from a given replica.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
