[jira] [Commented] (CASSANDRASC-50) Remove deprecate health endpoint containing instance segment
[
https://issues.apache.org/jira/browse/CASSANDRASC-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730238#comment-17730238
]
ASF subversion and git services commented on CASSANDRASC-50:
Commit 5d2cbaf5cb810f53689bf227e2c1f78a9a2b2e9f in cassandra-sidecar's branch
refs/heads/trunk from Francisco Guerrero
[ https://gitbox.apache.org/repos/asf?p=cassandra-sidecar.git;h=5d2cbaf ]
CASSANDRASC-50: Deprecate the sidecar cassandra health endpoint containing
instance segment
This commit deprecates the Cassandra Health endpoint containing the instance
segment
in the path. This endpoint is currently unused and it is replaced by the health
endpoint with the `instanceId` query string parameter. Since the `instanceId`
is optional
we move the path param (mandatory) to the query param (optional).
This commit also moves the CassandraHealthService from jax RS to a vertx
Handler.
It also moves the HealthService to a inlined handler, simplifying the service.
patch by Francisco Guerrero; reviewed by Yifan Cai, Dinesh Joshi for
CASSANDRASC-50
> Remove deprecate health endpoint containing instance segment
>
>
> Key: CASSANDRASC-50
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-50
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Rest API
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
> Fix For: 1.0
>
>
> The Cassandra Health endpoint containing the instance segment in the path
> usage is deprecated. This endpoint is currently unused and it is replaced by
> the health endpoint with the {{instanceId}} query string parameter. Since the
> {{instanceId}} is optional we move the path param (mandatory) to the query
> param (optional).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-50) Remove deprecate health endpoint containing instance segment
[
https://issues.apache.org/jira/browse/CASSANDRASC-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730201#comment-17730201
]
Yifan Cai commented on CASSANDRASC-50:
--
Some test failures showed on CI. They are unrelated with the patch. Both me and
Francisco ran the test locally and cannot reproduce. I am going ahead to
commit.
> Remove deprecate health endpoint containing instance segment
>
>
> Key: CASSANDRASC-50
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-50
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Rest API
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> The Cassandra Health endpoint containing the instance segment in the path
> usage is deprecated. This endpoint is currently unused and it is replaced by
> the health endpoint with the {{instanceId}} query string parameter. Since the
> {{instanceId}} is optional we move the path param (mandatory) to the query
> param (optional).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-50) Remove deprecate health endpoint containing instance segment
[
https://issues.apache.org/jira/browse/CASSANDRASC-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729846#comment-17729846
]
Francisco Guerrero commented on CASSANDRASC-50:
---
CI: https://app.circleci.com/pipelines/github/frankgh/cassandra-sidecar/144
> Remove deprecate health endpoint containing instance segment
>
>
> Key: CASSANDRASC-50
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-50
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Rest API
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> The Cassandra Health endpoint containing the instance segment in the path
> usage is deprecated. This endpoint is currently unused and it is replaced by
> the health endpoint with the {{instanceId}} query string parameter. Since the
> {{instanceId}} is optional we move the path param (mandatory) to the query
> param (optional).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-50) Remove deprecate health endpoint containing instance segment
[
https://issues.apache.org/jira/browse/CASSANDRASC-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729845#comment-17729845
]
Yifan Cai commented on CASSANDRASC-50:
--
+1 on the patch.
> Remove deprecate health endpoint containing instance segment
>
>
> Key: CASSANDRASC-50
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-50
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Rest API
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> The Cassandra Health endpoint containing the instance segment in the path
> usage is deprecated. This endpoint is currently unused and it is replaced by
> the health endpoint with the {{instanceId}} query string parameter. Since the
> {{instanceId}} is optional we move the path param (mandatory) to the query
> param (optional).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-50) Remove deprecate health endpoint containing instance segment
[
https://issues.apache.org/jira/browse/CASSANDRASC-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728986#comment-17728986
]
Dinesh Joshi commented on CASSANDRASC-50:
-
+1, thanks for the patch!
> Remove deprecate health endpoint containing instance segment
>
>
> Key: CASSANDRASC-50
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-50
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Rest API
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> The Cassandra Health endpoint containing the instance segment in the path
> usage is deprecated. This endpoint is currently unused and it is replaced by
> the health endpoint with the {{instanceId}} query string parameter. Since the
> {{instanceId}} is optional we move the path param (mandatory) to the query
> param (optional).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
