Dmitry Konstantinov created CASSANDRA-19651:
-----------------------------------------------
Summary: idealCLWriteLatency metric reports the worst response
time instead of the time when ideal CL is satisfied
Key: CASSANDRA-19651
URL: https://issues.apache.org/jira/browse/CASSANDRA-19651
Project: Cassandra
Issue Type: Bug
Reporter: Dmitry Konstantinov
{code:java}
private final void decrementResponseOrExpired()
{
int decrementedValue = responsesAndExpirations.decrementAndGet();
if (decrementedValue == 0)
{
// The condition being signaled is a valid proxy for the CL being
achieved
// Only mark it as failed if the requested CL was achieved.
if (!condition.isSignalled() && requestedCLAchieved)
{
replicaPlan.keyspace().metric.writeFailedIdealCL.inc();
}
else
{
replicaPlan.keyspace().metric.idealCLWriteLatency.addNano(nanoTime() -
queryStartNanoTime);
}
}
} {code}
Actual result: responsesAndExpirations is a total number of replicas across all
DCs which does not depend on the ideal CL, so the metric value for
replicaPlan.keyspace().metric.idealCLWriteLatency is updated when we get the
latest response/timeout for all replicas.
Expected result: replicaPlan.keyspace().metric.idealCLWriteLatency is updated
when we get enough responses from replicas according to the ideal CL.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
