[jira] [Updated] (CASSANDRA-11450) Should not search for the index of a column if the table is not using secondaryIndex.
[
https://issues.apache.org/jira/browse/CASSANDRA-11450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Tunnicliffe updated CASSANDRA-11450:
Resolution: Fixed
Fix Version/s: (was: 2.2.x)
2.2.6
Status: Resolved (was: Patch Available)
Thanks, looks like this was an oversight in the patch for CASSANDRA-5549, but
isn't a problem in 3.0+, as it's implemented in a slightly different way. I've
committed to 2.2 in {{a821539bc3eb90f204064b3fd9f86b7253d2b84b}} (with the
condition slightly modified to match {{updaterFor}}).
||branch||testall||dtest||
|[11450-2.2|https://github.com/beobal/cassandra/tree/11450-2.2]|[testall|http://cassci.datastax.com/view/Dev/view/beobal/job/beobal-11450-2.2-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/beobal/job/beobal-11450-2.2-dtest]|
> Should not search for the index of a column if the table is not using
> secondaryIndex.
> -
>
> Key: CASSANDRA-11450
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11450
> Project: Cassandra
> Issue Type: Bug
> Components: Compaction
>Reporter: Dikang Gu
>Assignee: Dikang Gu
> Fix For: 2.2.6
>
> Attachments:
> 0001-return-nullupdater-for-table-do-not-have-indexes.patch
>
>
> We are not using secondary index in our cluster, but when I profile the
> compaction, I find that ~5.5% of the compaction time is spent on this line of
> the code function LazilyCompactedRow.Reducer.reduce():
> if (cell.isLive() && !container.getColumn(cell.name()).equals(cell))
> before this line there is check to skip the look up, which seems to be not
> working:
> // skip the index-update checks if there is no indexing needed since they
> are a bit expensive
> if (indexer == SecondaryIndexManager.nullUpdater)
> return;
> My patch is to set the indexer to be nullUpdater if the table has no
> associated index.
> Let me know if it's the right fix.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (CASSANDRA-11450) Should not search for the index of a column if the table is not using secondaryIndex.
[ https://issues.apache.org/jira/browse/CASSANDRA-11450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Tunnicliffe updated CASSANDRA-11450: Reviewer: Sam Tunnicliffe (was: Marcus Eriksson) > Should not search for the index of a column if the table is not using > secondaryIndex. > - > > Key: CASSANDRA-11450 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11450 > Project: Cassandra > Issue Type: Bug > Components: Compaction >Reporter: Dikang Gu >Assignee: Dikang Gu > Fix For: 2.2.x > > Attachments: > 0001-return-nullupdater-for-table-do-not-have-indexes.patch > > > We are not using secondary index in our cluster, but when I profile the > compaction, I find that ~5.5% of the compaction time is spent on this line of > the code function LazilyCompactedRow.Reducer.reduce(): > if (cell.isLive() && !container.getColumn(cell.name()).equals(cell)) > before this line there is check to skip the look up, which seems to be not > working: > // skip the index-update checks if there is no indexing needed since they > are a bit expensive > if (indexer == SecondaryIndexManager.nullUpdater) > return; > My patch is to set the indexer to be nullUpdater if the table has no > associated index. > Let me know if it's the right fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-11450) Should not search for the index of a column if the table is not using secondaryIndex.
[ https://issues.apache.org/jira/browse/CASSANDRA-11450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dikang Gu updated CASSANDRA-11450: -- Attachment: 0001-return-nullupdater-for-table-do-not-have-indexes.patch > Should not search for the index of a column if the table is not using > secondaryIndex. > - > > Key: CASSANDRA-11450 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11450 > Project: Cassandra > Issue Type: Bug > Components: Compaction >Reporter: Dikang Gu >Assignee: Dikang Gu > Fix For: 2.2.x > > Attachments: > 0001-return-nullupdater-for-table-do-not-have-indexes.patch > > > We are not using secondary index in our cluster, but when I profile the > compaction, I find that ~5.5% of the compaction time is spent on this line of > the code function LazilyCompactedRow.Reducer.reduce(): > if (cell.isLive() && !container.getColumn(cell.name()).equals(cell)) > before this line there is check to skip the look up, which seems to be not > working: > // skip the index-update checks if there is no indexing needed since they > are a bit expensive > if (indexer == SecondaryIndexManager.nullUpdater) > return; > My patch is to set the indexer to be nullUpdater if the table has no > associated index. > Let me know if it's the right fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-11450) Should not search for the index of a column if the table is not using secondaryIndex.
[ https://issues.apache.org/jira/browse/CASSANDRA-11450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dikang Gu updated CASSANDRA-11450: -- Reviewer: Marcus Eriksson Status: Patch Available (was: Open) > Should not search for the index of a column if the table is not using > secondaryIndex. > - > > Key: CASSANDRA-11450 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11450 > Project: Cassandra > Issue Type: Bug > Components: Compaction >Reporter: Dikang Gu >Assignee: Dikang Gu > Fix For: 2.2.x > > > We are not using secondary index in our cluster, but when I profile the > compaction, I find that ~5.5% of the compaction time is spent on this line of > the code function LazilyCompactedRow.Reducer.reduce(): > if (cell.isLive() && !container.getColumn(cell.name()).equals(cell)) > before this line there is check to skip the look up, which seems to be not > working: > // skip the index-update checks if there is no indexing needed since they > are a bit expensive > if (indexer == SecondaryIndexManager.nullUpdater) > return; > My patch is to set the indexer to be nullUpdater if the table has no > associated index. > Let me know if it's the right fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
