[jira] [Updated] (CASSANDRA-13012) Paxos regression from CASSANDRA-12716
[ https://issues.apache.org/jira/browse/CASSANDRA-13012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylvain Lebresne updated CASSANDRA-13012: - Resolution: Fixed Fix Version/s: 4.0 Status: Resolved (was: Ready to Commit) Yes, sorry, could have swear I had indicated the ticket. Anyway, this is trunk only and didn't make it into any release, just had to be fixed. Committed, thanks. > Paxos regression from CASSANDRA-12716 > - > > Key: CASSANDRA-13012 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13012 > Project: Cassandra > Issue Type: Bug >Reporter: Sylvain Lebresne >Assignee: Sylvain Lebresne >Priority: Minor > Fix For: 4.0 > > > I introduced a dumb bug when reading the Paxos state in > {{SystemKeyspace.loadPaxosState}} where the new condition on > {{proposal_version}} and {{most_recent_commit_version}} is obviously way too > strong, and actually entirely unnecessary. > This is consistently breaking the > {{paxos_tests.TestPaxos.contention_test_many_threads}} so I'm not sure why I > didn't caught that, sorry. Thanks to [~jkni] who noticed that first. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-13012) Paxos regression from CASSANDRA-12716
[ https://issues.apache.org/jira/browse/CASSANDRA-13012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Knighton updated CASSANDRA-13012: -- Status: Ready to Commit (was: Patch Available) > Paxos regression from CASSANDRA-12716 > - > > Key: CASSANDRA-13012 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13012 > Project: Cassandra > Issue Type: Bug >Reporter: Sylvain Lebresne >Assignee: Sylvain Lebresne >Priority: Minor > > I introduced a dumb bug when reading the Paxos state in > {{SystemKeyspace.loadPaxosState}} where the new condition on > {{proposal_version}} and {{most_recent_commit_version}} is obviously way too > strong, and actually entirely unnecessary. > This is consistently breaking the > {{paxos_tests.TestPaxos.contention_test_many_threads}} so I'm not sure why I > didn't caught that, sorry. Thanks to [~jkni] who noticed that first. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-13012) Paxos regression from CASSANDRA-12716
[ https://issues.apache.org/jira/browse/CASSANDRA-13012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylvain Lebresne updated CASSANDRA-13012: - Reviewer: Joel Knighton Status: Patch Available (was: Open) Simple patch that just remove the broken condition below: | [13012|https://github.com/pcmanus/cassandra/commits/13012] | [utests|http://cassci.datastax.com/job/pcmanus-13012-testall] | [dtests|http://cassci.datastax.com/job/pcmanus-13012-dtest] | > Paxos regression from CASSANDRA-12716 > - > > Key: CASSANDRA-13012 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13012 > Project: Cassandra > Issue Type: Bug >Reporter: Sylvain Lebresne >Assignee: Sylvain Lebresne >Priority: Minor > > I introduced a dumb bug when reading the Paxos state in > {{SystemKeyspace.loadPaxosState}} where the new condition on > {{proposal_version}} and {{most_recent_commit_version}} is obviously way too > strong, and actually entirely unnecessary. > This is consistently breaking the > {{paxos_tests.TestPaxos.contention_test_many_threads}} so I'm not sure why I > didn't caught that, sorry. Thanks to [~jkni] who noticed that first. -- This message was sent by Atlassian JIRA (v6.3.4#6332)