[jira] [Updated] (CASSANDRA-13163) NPE in StorageService.excise
[ https://issues.apache.org/jira/browse/CASSANDRA-13163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ariel Weisberg updated CASSANDRA-13163: --- Fix Version/s: (was: 3.11.x) (was: 4.x) (was: 3.0.x) 4.0 3.11.0 3.0.14 > NPE in StorageService.excise > > > Key: CASSANDRA-13163 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13163 > Project: Cassandra > Issue Type: Bug > Components: Core >Reporter: Ariel Weisberg >Assignee: Ariel Weisberg > Fix For: 3.0.14, 3.11.0, 4.0 > > > {code} > private void excise(Collection tokens, InetAddress endpoint) > { > logger.info("Removing tokens {} for {}", tokens, endpoint); > if (tokenMetadata.isMember(endpoint)) > HintsService.instance.excise(tokenMetadata.getHostId(endpoint)); > {code} > The check for TMD.isMember() is not enough to guarantee that TMD.getHostId() > will not return null. If HintsService.excise() is called with null you get an > NPE in a map lookup. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13163) NPE in StorageService.excise
[ https://issues.apache.org/jira/browse/CASSANDRA-13163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ariel Weisberg updated CASSANDRA-13163: --- Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed as [18b77c3e0b8988956e42b1362eb350dfada27eb0|https://github.com/apache/cassandra/commit/18b77c3e0b8988956e42b1362eb350dfada27eb0] > NPE in StorageService.excise > > > Key: CASSANDRA-13163 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13163 > Project: Cassandra > Issue Type: Bug > Components: Core >Reporter: Ariel Weisberg >Assignee: Ariel Weisberg > Fix For: 3.0.x, 3.11.x, 4.x > > > {code} > private void excise(Collection tokens, InetAddress endpoint) > { > logger.info("Removing tokens {} for {}", tokens, endpoint); > if (tokenMetadata.isMember(endpoint)) > HintsService.instance.excise(tokenMetadata.getHostId(endpoint)); > {code} > The check for TMD.isMember() is not enough to guarantee that TMD.getHostId() > will not return null. If HintsService.excise() is called with null you get an > NPE in a map lookup. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13163) NPE in StorageService.excise
[ https://issues.apache.org/jira/browse/CASSANDRA-13163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ariel Weisberg updated CASSANDRA-13163: --- Status: Ready to Commit (was: Patch Available) > NPE in StorageService.excise > > > Key: CASSANDRA-13163 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13163 > Project: Cassandra > Issue Type: Bug > Components: Core >Reporter: Ariel Weisberg >Assignee: Ariel Weisberg > Fix For: 3.0.x, 3.11.x, 4.x > > > {code} > private void excise(Collection tokens, InetAddress endpoint) > { > logger.info("Removing tokens {} for {}", tokens, endpoint); > if (tokenMetadata.isMember(endpoint)) > HintsService.instance.excise(tokenMetadata.getHostId(endpoint)); > {code} > The check for TMD.isMember() is not enough to guarantee that TMD.getHostId() > will not return null. If HintsService.excise() is called with null you get an > NPE in a map lookup. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13163) NPE in StorageService.excise
[ https://issues.apache.org/jira/browse/CASSANDRA-13163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ariel Weisberg updated CASSANDRA-13163: --- Description: {code} private void excise(Collection tokens, InetAddress endpoint) { logger.info("Removing tokens {} for {}", tokens, endpoint); if (tokenMetadata.isMember(endpoint)) HintsService.instance.excise(tokenMetadata.getHostId(endpoint)); {code} The check for TMD.isMember() is not enough to guarantee that TMD.getHostId() will not return null. If HintsService.excise() is called with null you get an NPE in a map lookup. was: {code} private void excise(Collection tokens, InetAddress endpoint) { logger.info("Removing tokens {} for {}", tokens, endpoint); if (tokenMetadata.isMember(endpoint)) HintsService.instance.excise(tokenMetadata.getHostId(endpoint)); {code} The check for TMD.isMember() is not enough to guarantee that TMD.getHodtId() will not return null. If HintsService.excise() is called with null you get an NPE in a map lookup. > NPE in StorageService.excise > > > Key: CASSANDRA-13163 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13163 > Project: Cassandra > Issue Type: Bug > Components: Core >Reporter: Ariel Weisberg >Assignee: Ariel Weisberg > Fix For: 3.0.x, 3.x, 4.x > > > {code} > private void excise(Collection tokens, InetAddress endpoint) > { > logger.info("Removing tokens {} for {}", tokens, endpoint); > if (tokenMetadata.isMember(endpoint)) > HintsService.instance.excise(tokenMetadata.getHostId(endpoint)); > {code} > The check for TMD.isMember() is not enough to guarantee that TMD.getHostId() > will not return null. If HintsService.excise() is called with null you get an > NPE in a map lookup. -- This message was sent by Atlassian JIRA (v6.3.4#6332)