[jira] [Updated] (CASSANDRA-13764) SelectTest.testMixedTTLOnColumnsWide is flaky
[ https://issues.apache.org/jira/browse/CASSANDRA-13764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Jirsa updated CASSANDRA-13764: --- Resolution: Fixed Reviewer: Joel Knighton Fix Version/s: 4.0 3.11.1 3.0.15 Status: Resolved (was: Ready to Commit) Thanks Joel. Committed to 3.0 as {{67ac1496cc9e7d9d15be28b9536e9cdbce42473d}} and merged to 3.11 and trunk WITHOUT adding CHANGES.txt entry, because it's just a test fix and never hit a release (not quite a ninja). > SelectTest.testMixedTTLOnColumnsWide is flaky > - > > Key: CASSANDRA-13764 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13764 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Joel Knighton >Assignee: Jeff Jirsa >Priority: Trivial > Fix For: 3.0.15, 3.11.1, 4.0 > > > {{org.apache.cassandra.cql3.validation.operations.SelectTest.testMixedTTLOnColumnsWide}} > is flaky. This is because it inserts rows and then asserts their contents > using {{ttl()}} in the select, but if the test is sufficiently slow, the > remaining ttl may change by the time the select is run. Anecdotally, > {{testSelectWithAlias}} in the same class uses a fudge factor of 1 second > that would fix all the failures I've seen, but it might make more sense to > measure the elapsed time in the test and calculate the acceptable variation > from that time. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13764) SelectTest.testMixedTTLOnColumnsWide is flaky
[ https://issues.apache.org/jira/browse/CASSANDRA-13764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Jirsa updated CASSANDRA-13764: --- Status: Ready to Commit (was: Patch Available) > SelectTest.testMixedTTLOnColumnsWide is flaky > - > > Key: CASSANDRA-13764 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13764 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Joel Knighton >Assignee: Jeff Jirsa >Priority: Trivial > > {{org.apache.cassandra.cql3.validation.operations.SelectTest.testMixedTTLOnColumnsWide}} > is flaky. This is because it inserts rows and then asserts their contents > using {{ttl()}} in the select, but if the test is sufficiently slow, the > remaining ttl may change by the time the select is run. Anecdotally, > {{testSelectWithAlias}} in the same class uses a fudge factor of 1 second > that would fix all the failures I've seen, but it might make more sense to > measure the elapsed time in the test and calculate the acceptable variation > from that time. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13764) SelectTest.testMixedTTLOnColumnsWide is flaky
[ https://issues.apache.org/jira/browse/CASSANDRA-13764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Jirsa updated CASSANDRA-13764: --- Status: Patch Available (was: In Progress) > SelectTest.testMixedTTLOnColumnsWide is flaky > - > > Key: CASSANDRA-13764 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13764 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Joel Knighton >Assignee: Jeff Jirsa >Priority: Trivial > > {{org.apache.cassandra.cql3.validation.operations.SelectTest.testMixedTTLOnColumnsWide}} > is flaky. This is because it inserts rows and then asserts their contents > using {{ttl()}} in the select, but if the test is sufficiently slow, the > remaining ttl may change by the time the select is run. Anecdotally, > {{testSelectWithAlias}} in the same class uses a fudge factor of 1 second > that would fix all the failures I've seen, but it might make more sense to > measure the elapsed time in the test and calculate the acceptable variation > from that time. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org