[jira] [Updated] (CASSANDRA-14540) Internode messaging handshake sends wrong messaging version number

2018-06-25 Thread Jason Brown (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-14540:

   Resolution: Fixed
Fix Version/s: (was: 4.x)
   4.0
   Status: Resolved  (was: Patch Available)

committed as sha {{5db822b71ad7278ca6443455d029dd79e22388d8}}.

> Internode messaging handshake sends wrong messaging version number
> --
>
> Key: CASSANDRA-14540
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14540
> Project: Cassandra
>  Issue Type: Bug
>  Components: Streaming and Messaging
>Reporter: Jason Brown
>Assignee: Jason Brown
>Priority: Blocker
> Fix For: 4.0
>
>
> With the refactor of internode messaging to netty in 4.0, we abstracted the 
> protocol handshakes messages into a class and handlers. There is a bug when 
> the initiator of the connection sends, in the third message of the handshake, 
> it's own default protocol version number 
> ({{MessagingService.current_version}}), rather than the negotiated version. 
> This was not causing any obvious problems when CASSANDRA-8457 was initially 
> committed, but the bug is exposed after CASSANDRA-7544. The problem is during 
> rolling upgrades of 3.0/3.X to 4.0, nodes cannot correctly connect. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14540) Internode messaging handshake sends wrong messaging version number

2018-06-24 Thread Dinesh Joshi (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dinesh Joshi updated CASSANDRA-14540:
-
Status: Patch Available  (was: Open)

> Internode messaging handshake sends wrong messaging version number
> --
>
> Key: CASSANDRA-14540
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14540
> Project: Cassandra
>  Issue Type: Bug
>  Components: Streaming and Messaging
>Reporter: Jason Brown
>Assignee: Jason Brown
>Priority: Blocker
> Fix For: 4.x
>
>
> With the refactor of internode messaging to netty in 4.0, we abstracted the 
> protocol handshakes messages into a class and handlers. There is a bug when 
> the initiator of the connection sends, in the third message of the handshake, 
> it's own default protocol version number 
> ({{MessagingService.current_version}}), rather than the negotiated version. 
> This was not causing any obvious problems when CASSANDRA-8457 was initially 
> committed, but the bug is exposed after CASSANDRA-7544. The problem is during 
> rolling upgrades of 3.0/3.X to 4.0, nodes cannot correctly connect. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-14540) Internode messaging handshake sends wrong messaging version number

2018-06-24 Thread Dinesh Joshi (JIRA)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dinesh Joshi updated CASSANDRA-14540:
-
Reviewer: Dinesh Joshi

> Internode messaging handshake sends wrong messaging version number
> --
>
> Key: CASSANDRA-14540
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14540
> Project: Cassandra
>  Issue Type: Bug
>  Components: Streaming and Messaging
>Reporter: Jason Brown
>Assignee: Jason Brown
>Priority: Blocker
> Fix For: 4.x
>
>
> With the refactor of internode messaging to netty in 4.0, we abstracted the 
> protocol handshakes messages into a class and handlers. There is a bug when 
> the initiator of the connection sends, in the third message of the handshake, 
> it's own default protocol version number 
> ({{MessagingService.current_version}}), rather than the negotiated version. 
> This was not causing any obvious problems when CASSANDRA-8457 was initially 
> committed, but the bug is exposed after CASSANDRA-7544. The problem is during 
> rolling upgrades of 3.0/3.X to 4.0, nodes cannot correctly connect. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org