[jira] [Updated] (CASSANDRA-15173) fix log for inconsistent-left-subrange in merkle-tree
[
https://issues.apache.org/jira/browse/CASSANDRA-15173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeff Jirsa updated CASSANDRA-15173:
---
Fix Version/s: 4.0
Source Control Link:
https://github.com/apache/cassandra/commit/802989dce75847f87a5a47e2fe5d590d02f086fa
Status: Resolved (was: Ready to Commit)
Resolution: Fixed
Committed as {{802989dce75847f87a5a47e2fe5d590d02f086fa}}
> fix log for inconsistent-left-subrange in merkle-tree
> -
>
> Key: CASSANDRA-15173
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15173
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Streaming and Messaging
>Reporter: Nathan Jackels
>Assignee: Nathan Jackels
>Priority: Low
> Labels: pull-request-available
> Fix For: 4.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> One of the logs added in CASSANDRA-13052 is called with incorrect arguments.
> In org.apache.cassandra.utils.MerkleTree::differenceHelper the right-side
> subrange logs with right:
> {code:java}
> else if (!rreso)
> {
> logger.debug("({}) Right sub-range fully inconsistent {}",
> active.depth, right);
> rdiff = FULLY_INCONSISTENT;
> }
> {code}
> but left side is also (incorrectly) logged with right:
> {code:java}
> else if (!lreso)
> {
> logger.debug("({}) Left sub-range fully inconsistent {}",
> active.depth, right);
> ldiff = FULLY_INCONSISTENT;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15173) fix log for inconsistent-left-subrange in merkle-tree
[
https://issues.apache.org/jira/browse/CASSANDRA-15173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeff Jirsa updated CASSANDRA-15173:
---
Test and Documentation Plan:
Patch in PR #327
Trivial patch. No tests/docs required.
Status: Patch Available (was: Open)
> fix log for inconsistent-left-subrange in merkle-tree
> -
>
> Key: CASSANDRA-15173
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15173
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Streaming and Messaging
>Reporter: Nathan Jackels
>Assignee: Nathan Jackels
>Priority: Low
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> One of the logs added in CASSANDRA-13052 is called with incorrect arguments.
> In org.apache.cassandra.utils.MerkleTree::differenceHelper the right-side
> subrange logs with right:
> {code:java}
> else if (!rreso)
> {
> logger.debug("({}) Right sub-range fully inconsistent {}",
> active.depth, right);
> rdiff = FULLY_INCONSISTENT;
> }
> {code}
> but left side is also (incorrectly) logged with right:
> {code:java}
> else if (!lreso)
> {
> logger.debug("({}) Left sub-range fully inconsistent {}",
> active.depth, right);
> ldiff = FULLY_INCONSISTENT;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15173) fix log for inconsistent-left-subrange in merkle-tree
[
https://issues.apache.org/jira/browse/CASSANDRA-15173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeff Jirsa updated CASSANDRA-15173:
---
Status: Ready to Commit (was: Review In Progress)
> fix log for inconsistent-left-subrange in merkle-tree
> -
>
> Key: CASSANDRA-15173
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15173
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Streaming and Messaging
>Reporter: Nathan Jackels
>Assignee: Nathan Jackels
>Priority: Low
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> One of the logs added in CASSANDRA-13052 is called with incorrect arguments.
> In org.apache.cassandra.utils.MerkleTree::differenceHelper the right-side
> subrange logs with right:
> {code:java}
> else if (!rreso)
> {
> logger.debug("({}) Right sub-range fully inconsistent {}",
> active.depth, right);
> rdiff = FULLY_INCONSISTENT;
> }
> {code}
> but left side is also (incorrectly) logged with right:
> {code:java}
> else if (!lreso)
> {
> logger.debug("({}) Left sub-range fully inconsistent {}",
> active.depth, right);
> ldiff = FULLY_INCONSISTENT;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15173) fix log for inconsistent-left-subrange in merkle-tree
[
https://issues.apache.org/jira/browse/CASSANDRA-15173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeff Jirsa updated CASSANDRA-15173:
---
Status: Review In Progress (was: Patch Available)
+1
> fix log for inconsistent-left-subrange in merkle-tree
> -
>
> Key: CASSANDRA-15173
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15173
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Streaming and Messaging
>Reporter: Nathan Jackels
>Assignee: Nathan Jackels
>Priority: Low
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> One of the logs added in CASSANDRA-13052 is called with incorrect arguments.
> In org.apache.cassandra.utils.MerkleTree::differenceHelper the right-side
> subrange logs with right:
> {code:java}
> else if (!rreso)
> {
> logger.debug("({}) Right sub-range fully inconsistent {}",
> active.depth, right);
> rdiff = FULLY_INCONSISTENT;
> }
> {code}
> but left side is also (incorrectly) logged with right:
> {code:java}
> else if (!lreso)
> {
> logger.debug("({}) Left sub-range fully inconsistent {}",
> active.depth, right);
> ldiff = FULLY_INCONSISTENT;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15173) fix log for inconsistent-left-subrange in merkle-tree
[
https://issues.apache.org/jira/browse/CASSANDRA-15173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeff Jirsa updated CASSANDRA-15173:
---
Complexity: Low Hanging Fruit
Priority: Low (was: Normal)
Assignee: Nathan Jackels
Change Category: Operability
Reviewers: Jeff Jirsa
Status: Open (was: Triage Needed)
Thanks for the report!
> fix log for inconsistent-left-subrange in merkle-tree
> -
>
> Key: CASSANDRA-15173
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15173
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Streaming and Messaging
>Reporter: Nathan Jackels
>Assignee: Nathan Jackels
>Priority: Low
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> One of the logs added in CASSANDRA-13052 is called with incorrect arguments.
> In org.apache.cassandra.utils.MerkleTree::differenceHelper the right-side
> subrange logs with right:
> {code:java}
> else if (!rreso)
> {
> logger.debug("({}) Right sub-range fully inconsistent {}",
> active.depth, right);
> rdiff = FULLY_INCONSISTENT;
> }
> {code}
> but left side is also (incorrectly) logged with right:
> {code:java}
> else if (!lreso)
> {
> logger.debug("({}) Left sub-range fully inconsistent {}",
> active.depth, right);
> ldiff = FULLY_INCONSISTENT;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15173) fix log for inconsistent-left-subrange in merkle-tree
[
https://issues.apache.org/jira/browse/CASSANDRA-15173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated CASSANDRA-15173:
---
Labels: pull-request-available (was: )
> fix log for inconsistent-left-subrange in merkle-tree
> -
>
> Key: CASSANDRA-15173
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15173
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Streaming and Messaging
>Reporter: Nathan Jackels
>Priority: Normal
> Labels: pull-request-available
>
> One of the logs added in CASSANDRA-13052 is called with incorrect arguments.
> In org.apache.cassandra.utils.MerkleTree::differenceHelper the right-side
> subrange logs with right:
> {code:java}
> else if (!rreso)
> {
> logger.debug("({}) Right sub-range fully inconsistent {}",
> active.depth, right);
> rdiff = FULLY_INCONSISTENT;
> }
> {code}
> but left side is also (incorrectly) logged with right:
> {code:java}
> else if (!lreso)
> {
> logger.debug("({}) Left sub-range fully inconsistent {}",
> active.depth, right);
> ldiff = FULLY_INCONSISTENT;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
