[jira] [Updated] (CASSANDRA-15287) Inaccurate exception message with nodetool snapshot

2019-08-23 Thread Jeff Jirsa (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-15287:
---
  Fix Version/s: 4.0
  Since Version: 2.1.5
Source Control Link: 
https://github.com/apache/cassandra/commit/a145a485206f6a32b07979dfb1b983addf49dd10
 Resolution: Fixed
 Status: Resolved  (was: Ready to Commit)

Thanks for the patch. I've taken the liberty of rewording it SLIGHTLY to make 
it more clear. Hope you don't object. Committed as 
[a145a485206f6a32b07979dfb1b983addf49dd10|https://github.com/apache/cassandra/commit/a145a485206f6a32b07979dfb1b983addf49dd10]

> Inaccurate exception message with nodetool snapshot 
> 
>
> Key: CASSANDRA-15287
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15287
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/nodetool
>Reporter: DeepakVohra
>Assignee: Josh Turner
>Priority: Normal
> Fix For: 4.0
>
> Attachments: 15287.trunk, 15287.trunk.withchanges
>
>
> 1. Create a keyspace _cqlkeyspace_ (arbitrary name)
> 2. Create two tables (t1 and  t2)
> 3. Run _nodetool snapshot_ to create snapshot for multiple tables in same 
> command. Include the keyspace name as argument (which is not what the command 
> syntax allows)
> {code:java}
> nodetool snapshot --kt-list cqlkeyspace.t1,cqlkeyspace.t2 --tag multi-table   
> --cqlkeyspace
> {code}
> 4. Exception message is inaccurate in that it is referring to columnfamily 
> when it should be referring to keyspace.
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a 
> snapshot, you should not specify columnfamily
> {code}
> Exception message should be:
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a 
> snapshot, you should not specify keyspace
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15287) Inaccurate exception message with nodetool snapshot

2019-08-23 Thread Jeff Jirsa (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-15287:
---
Reviewers: Jeff Jirsa, Jeff Jirsa  (was: Jeff Jirsa)
   Jeff Jirsa, Jeff Jirsa
   Status: Review In Progress  (was: Patch Available)

> Inaccurate exception message with nodetool snapshot 
> 
>
> Key: CASSANDRA-15287
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15287
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/nodetool
>Reporter: DeepakVohra
>Assignee: Josh Turner
>Priority: Normal
> Attachments: 15287.trunk, 15287.trunk.withchanges
>
>
> 1. Create a keyspace _cqlkeyspace_ (arbitrary name)
> 2. Create two tables (t1 and  t2)
> 3. Run _nodetool snapshot_ to create snapshot for multiple tables in same 
> command. Include the keyspace name as argument (which is not what the command 
> syntax allows)
> {code:java}
> nodetool snapshot --kt-list cqlkeyspace.t1,cqlkeyspace.t2 --tag multi-table   
> --cqlkeyspace
> {code}
> 4. Exception message is inaccurate in that it is referring to columnfamily 
> when it should be referring to keyspace.
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a 
> snapshot, you should not specify columnfamily
> {code}
> Exception message should be:
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a 
> snapshot, you should not specify keyspace
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15287) Inaccurate exception message with nodetool snapshot

2019-08-23 Thread Jeff Jirsa (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-15287:
---
Status: Ready to Commit  (was: Review In Progress)

> Inaccurate exception message with nodetool snapshot 
> 
>
> Key: CASSANDRA-15287
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15287
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/nodetool
>Reporter: DeepakVohra
>Assignee: Josh Turner
>Priority: Normal
> Attachments: 15287.trunk, 15287.trunk.withchanges
>
>
> 1. Create a keyspace _cqlkeyspace_ (arbitrary name)
> 2. Create two tables (t1 and  t2)
> 3. Run _nodetool snapshot_ to create snapshot for multiple tables in same 
> command. Include the keyspace name as argument (which is not what the command 
> syntax allows)
> {code:java}
> nodetool snapshot --kt-list cqlkeyspace.t1,cqlkeyspace.t2 --tag multi-table   
> --cqlkeyspace
> {code}
> 4. Exception message is inaccurate in that it is referring to columnfamily 
> when it should be referring to keyspace.
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a 
> snapshot, you should not specify columnfamily
> {code}
> Exception message should be:
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a 
> snapshot, you should not specify keyspace
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15287) Inaccurate exception message with nodetool snapshot

2019-08-22 Thread Josh Turner (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Josh Turner updated CASSANDRA-15287:

Test and Documentation Plan: 
Reproduced error message:

 
{code:java}
bin/cqlsh << EOF
CREATE KEYSPACE k1 WITH replication = {'class': 'SimpleStrategy', 
'replication_factor': '1'} AND durable_writes = true;

CREATE TABLE k1.t2 (
id uuid PRIMARY KEY,
val text
);

CREATE TABLE k1.t1 (
id uuid PRIMARY KEY,
val text
);
EOF

bin/nodetool snapshot --kt-list k1.t1,k1.t2 --k1
{code}
 

 

Before Patch:

 
{code:java}
error: When specifying the Keyspace columfamily list for a snapshot, you should 
not specify columnfamilyerror: When specifying the Keyspace columfamily list 
for a snapshot, you should not specify columnfamily
-- StackTrace --
java.io.IOException: When specifying the Keyspace columfamily list for a 
snapshot, you should not specify columnfamily at 
org.apache.cassandra.tools.nodetool.Snapshot.execute(Snapshot.java:73) at 
org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:307) at 
org.apache.cassandra.tools.NodeTool.main(NodeTool.java:218)
{code}
 

 

After Patch:

 
{code:java}
error: When specifying the Keyspace columfamily list for a snapshot, you should 
not specify keyspaceerror: When specifying the Keyspace columfamily list for a 
snapshot, you should not specify keyspace
-- StackTrace --
java.io.IOException: When specifying the Keyspace columfamily list for a 
snapshot, you should not specify keyspace at 
org.apache.cassandra.tools.nodetool.Snapshot.execute(Snapshot.java:73) at 
org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:307) at 
org.apache.cassandra.tools.NodeTool.main(NodeTool.java:218)
{code}
 

 
 Status: Patch Available  (was: Open)

> Inaccurate exception message with nodetool snapshot 
> 
>
> Key: CASSANDRA-15287
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15287
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/nodetool
>Reporter: DeepakVohra
>Assignee: Josh Turner
>Priority: Normal
> Attachments: 15287.trunk, 15287.trunk.withchanges
>
>
> 1. Create a keyspace _cqlkeyspace_ (arbitrary name)
> 2. Create two tables (t1 and  t2)
> 3. Run _nodetool snapshot_ to create snapshot for multiple tables in same 
> command. Include the keyspace name as argument (which is not what the command 
> syntax allows)
> {code:java}
> nodetool snapshot --kt-list cqlkeyspace.t1,cqlkeyspace.t2 --tag multi-table   
> --cqlkeyspace
> {code}
> 4. Exception message is inaccurate in that it is referring to columnfamily 
> when it should be referring to keyspace.
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a 
> snapshot, you should not specify columnfamily
> {code}
> Exception message should be:
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a 
> snapshot, you should not specify keyspace
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15287) Inaccurate exception message with nodetool snapshot

2019-08-22 Thread Josh Turner (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Josh Turner updated CASSANDRA-15287:

Attachment: 15287.trunk.withchanges
15287.trunk

> Inaccurate exception message with nodetool snapshot 
> 
>
> Key: CASSANDRA-15287
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15287
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/nodetool
>Reporter: DeepakVohra
>Assignee: Josh Turner
>Priority: Normal
> Attachments: 15287.trunk, 15287.trunk.withchanges
>
>
> 1. Create a keyspace _cqlkeyspace_ (arbitrary name)
> 2. Create two tables (t1 and  t2)
> 3. Run _nodetool snapshot_ to create snapshot for multiple tables in same 
> command. Include the keyspace name as argument (which is not what the command 
> syntax allows)
> {code:java}
> nodetool snapshot --kt-list cqlkeyspace.t1,cqlkeyspace.t2 --tag multi-table   
> --cqlkeyspace
> {code}
> 4. Exception message is inaccurate in that it is referring to columnfamily 
> when it should be referring to keyspace.
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a 
> snapshot, you should not specify columnfamily
> {code}
> Exception message should be:
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a 
> snapshot, you should not specify keyspace
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15287) Inaccurate exception message with nodetool snapshot

2019-08-22 Thread Josh Turner (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Josh Turner updated CASSANDRA-15287:

Attachment: 15287.trunk
15287.trunk.withchanges

> Inaccurate exception message with nodetool snapshot 
> 
>
> Key: CASSANDRA-15287
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15287
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/nodetool
>Reporter: DeepakVohra
>Assignee: Josh Turner
>Priority: Normal
>
> 1. Create a keyspace _cqlkeyspace_ (arbitrary name)
> 2. Create two tables (t1 and  t2)
> 3. Run _nodetool snapshot_ to create snapshot for multiple tables in same 
> command. Include the keyspace name as argument (which is not what the command 
> syntax allows)
> {code:java}
> nodetool snapshot --kt-list cqlkeyspace.t1,cqlkeyspace.t2 --tag multi-table   
> --cqlkeyspace
> {code}
> 4. Exception message is inaccurate in that it is referring to columnfamily 
> when it should be referring to keyspace.
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a 
> snapshot, you should not specify columnfamily
> {code}
> Exception message should be:
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a 
> snapshot, you should not specify keyspace
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15287) Inaccurate exception message with nodetool snapshot

2019-08-22 Thread Josh Turner (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Josh Turner updated CASSANDRA-15287:

Attachment: (was: 15287.trunk)

> Inaccurate exception message with nodetool snapshot 
> 
>
> Key: CASSANDRA-15287
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15287
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/nodetool
>Reporter: DeepakVohra
>Assignee: Josh Turner
>Priority: Normal
>
> 1. Create a keyspace _cqlkeyspace_ (arbitrary name)
> 2. Create two tables (t1 and  t2)
> 3. Run _nodetool snapshot_ to create snapshot for multiple tables in same 
> command. Include the keyspace name as argument (which is not what the command 
> syntax allows)
> {code:java}
> nodetool snapshot --kt-list cqlkeyspace.t1,cqlkeyspace.t2 --tag multi-table   
> --cqlkeyspace
> {code}
> 4. Exception message is inaccurate in that it is referring to columnfamily 
> when it should be referring to keyspace.
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a 
> snapshot, you should not specify columnfamily
> {code}
> Exception message should be:
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a 
> snapshot, you should not specify keyspace
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15287) Inaccurate exception message with nodetool snapshot

2019-08-22 Thread Josh Turner (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Josh Turner updated CASSANDRA-15287:

Attachment: (was: 15287.trunk.withchanges)

> Inaccurate exception message with nodetool snapshot 
> 
>
> Key: CASSANDRA-15287
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15287
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/nodetool
>Reporter: DeepakVohra
>Assignee: Josh Turner
>Priority: Normal
>
> 1. Create a keyspace _cqlkeyspace_ (arbitrary name)
> 2. Create two tables (t1 and  t2)
> 3. Run _nodetool snapshot_ to create snapshot for multiple tables in same 
> command. Include the keyspace name as argument (which is not what the command 
> syntax allows)
> {code:java}
> nodetool snapshot --kt-list cqlkeyspace.t1,cqlkeyspace.t2 --tag multi-table   
> --cqlkeyspace
> {code}
> 4. Exception message is inaccurate in that it is referring to columnfamily 
> when it should be referring to keyspace.
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a 
> snapshot, you should not specify columnfamily
> {code}
> Exception message should be:
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a 
> snapshot, you should not specify keyspace
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15287) Inaccurate exception message with nodetool snapshot

2019-08-22 Thread Josh Turner (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Josh Turner updated CASSANDRA-15287:

 Bug Category: Parent values: Code(13163)Level 1 values: Bug - Unclear 
Impact(13164)
   Complexity: Low Hanging Fruit
Discovered By: User Report
 Severity: Low
   Status: Open  (was: Triage Needed)

> Inaccurate exception message with nodetool snapshot 
> 
>
> Key: CASSANDRA-15287
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15287
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tool/nodetool
>Reporter: DeepakVohra
>Assignee: Josh Turner
>Priority: Normal
>
> 1. Create a keyspace _cqlkeyspace_ (arbitrary name)
> 2. Create two tables (t1 and  t2)
> 3. Run _nodetool snapshot_ to create snapshot for multiple tables in same 
> command. Include the keyspace name as argument (which is not what the command 
> syntax allows)
> {code:java}
> nodetool snapshot --kt-list cqlkeyspace.t1,cqlkeyspace.t2 --tag multi-table   
> --cqlkeyspace
> {code}
> 4. Exception message is inaccurate in that it is referring to columnfamily 
> when it should be referring to keyspace.
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a 
> snapshot, you should not specify columnfamily
> {code}
> Exception message should be:
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a 
> snapshot, you should not specify keyspace
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org