[jira] [Updated] (CASSANDRA-15335) Node can corrupt gossip state and become unreplaceable

2019-10-07 Thread Blake Eggleston (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Eggleston updated CASSANDRA-15335:

  Since Version: 3.0.0
Source Control Link: 
https://github.com/apache/cassandra/commit/39a431d9d821cf6bcb54da7198b6a64e09b0f120
 Resolution: Fixed
 Status: Resolved  (was: Ready to Commit)

committed to 3.0 as [39a431d9d821cf6bcb54da7198b6a64e09b0f120 
|https://github.com/apache/cassandra/commit/39a431d9d821cf6bcb54da7198b6a64e09b0f120]
 and merged up, thanks!

> Node can corrupt gossip state and become unreplaceable
> --
>
> Key: CASSANDRA-15335
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15335
> Project: Cassandra
>  Issue Type: Bug
>  Components: Cluster/Gossip
>Reporter: Blake Eggleston
>Assignee: Blake Eggleston
>Priority: Normal
> Fix For: 3.0.19, 3.11.5, 4.0
>
>
> In {{StorageService#prepareToJoin}}, a starting node first sends out an 
> endpoint state without any tokens. Later, in 
> {{StorageService#finishJoiningRing}} it sends out an endpoint state _with_ 
> it’s tokens. If that node dies between these 2 events and cannot be restarted 
> due to some unrecoverable error, the ring’s gossip state will be missing 
> tokens for that node. This won’t cause any immediate data loss since TMD is 
> populated from system.peers, but it will prevent a replacement node from 
> associating that address with it’s tokens and replacing it. It could also 
> cause data loss if other nodes are added to the ring and don’t see an owned 
> token where there should be one.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15335) Node can corrupt gossip state and become unreplaceable

2019-10-04 Thread Marcus Eriksson (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcus Eriksson updated CASSANDRA-15335:

Reviewers: Marcus Eriksson, Sam Tunnicliffe  (was: Sam Tunnicliffe)

> Node can corrupt gossip state and become unreplaceable
> --
>
> Key: CASSANDRA-15335
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15335
> Project: Cassandra
>  Issue Type: Bug
>  Components: Cluster/Gossip
>Reporter: Blake Eggleston
>Assignee: Blake Eggleston
>Priority: Normal
> Fix For: 3.0.19, 3.11.5, 4.0
>
>
> In {{StorageService#prepareToJoin}}, a starting node first sends out an 
> endpoint state without any tokens. Later, in 
> {{StorageService#finishJoiningRing}} it sends out an endpoint state _with_ 
> it’s tokens. If that node dies between these 2 events and cannot be restarted 
> due to some unrecoverable error, the ring’s gossip state will be missing 
> tokens for that node. This won’t cause any immediate data loss since TMD is 
> populated from system.peers, but it will prevent a replacement node from 
> associating that address with it’s tokens and replacing it. It could also 
> cause data loss if other nodes are added to the ring and don’t see an owned 
> token where there should be one.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15335) Node can corrupt gossip state and become unreplaceable

2019-10-03 Thread Sam Tunnicliffe (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sam Tunnicliffe updated CASSANDRA-15335:

Reviewers: Sam Tunnicliffe  (was: beobal, Sam Tunnicliffe)

> Node can corrupt gossip state and become unreplaceable
> --
>
> Key: CASSANDRA-15335
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15335
> Project: Cassandra
>  Issue Type: Bug
>  Components: Cluster/Gossip
>Reporter: Blake Eggleston
>Assignee: Blake Eggleston
>Priority: Normal
> Fix For: 3.0.19, 3.11.5, 4.0
>
>
> In {{StorageService#prepareToJoin}}, a starting node first sends out an 
> endpoint state without any tokens. Later, in 
> {{StorageService#finishJoiningRing}} it sends out an endpoint state _with_ 
> it’s tokens. If that node dies between these 2 events and cannot be restarted 
> due to some unrecoverable error, the ring’s gossip state will be missing 
> tokens for that node. This won’t cause any immediate data loss since TMD is 
> populated from system.peers, but it will prevent a replacement node from 
> associating that address with it’s tokens and replacing it. It could also 
> cause data loss if other nodes are added to the ring and don’t see an owned 
> token where there should be one.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15335) Node can corrupt gossip state and become unreplaceable

2019-10-03 Thread Sam Tunnicliffe (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sam Tunnicliffe updated CASSANDRA-15335:

Status: Ready to Commit  (was: Review In Progress)

+1 LGTM too

> Node can corrupt gossip state and become unreplaceable
> --
>
> Key: CASSANDRA-15335
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15335
> Project: Cassandra
>  Issue Type: Bug
>  Components: Cluster/Gossip
>Reporter: Blake Eggleston
>Assignee: Blake Eggleston
>Priority: Normal
> Fix For: 3.0.19, 3.11.5, 4.0
>
>
> In {{StorageService#prepareToJoin}}, a starting node first sends out an 
> endpoint state without any tokens. Later, in 
> {{StorageService#finishJoiningRing}} it sends out an endpoint state _with_ 
> it’s tokens. If that node dies between these 2 events and cannot be restarted 
> due to some unrecoverable error, the ring’s gossip state will be missing 
> tokens for that node. This won’t cause any immediate data loss since TMD is 
> populated from system.peers, but it will prevent a replacement node from 
> associating that address with it’s tokens and replacing it. It could also 
> cause data loss if other nodes are added to the ring and don’t see an owned 
> token where there should be one.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15335) Node can corrupt gossip state and become unreplaceable

2019-10-03 Thread Sam Tunnicliffe (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sam Tunnicliffe updated CASSANDRA-15335:

Reviewers: beobal, Sam Tunnicliffe
   Status: Review In Progress  (was: Patch Available)

> Node can corrupt gossip state and become unreplaceable
> --
>
> Key: CASSANDRA-15335
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15335
> Project: Cassandra
>  Issue Type: Bug
>  Components: Cluster/Gossip
>Reporter: Blake Eggleston
>Assignee: Blake Eggleston
>Priority: Normal
> Fix For: 3.0.19, 3.11.5, 4.0
>
>
> In {{StorageService#prepareToJoin}}, a starting node first sends out an 
> endpoint state without any tokens. Later, in 
> {{StorageService#finishJoiningRing}} it sends out an endpoint state _with_ 
> it’s tokens. If that node dies between these 2 events and cannot be restarted 
> due to some unrecoverable error, the ring’s gossip state will be missing 
> tokens for that node. This won’t cause any immediate data loss since TMD is 
> populated from system.peers, but it will prevent a replacement node from 
> associating that address with it’s tokens and replacing it. It could also 
> cause data loss if other nodes are added to the ring and don’t see an owned 
> token where there should be one.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15335) Node can corrupt gossip state and become unreplaceable

2019-09-30 Thread Blake Eggleston (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Eggleston updated CASSANDRA-15335:

Test and Documentation Plan: circle
 Status: Patch Available  (was: Open)

|[3.0|https://github.com/bdeggleston/cassandra/tree/15335-3.0]|[circle|https://circleci.com/gh/bdeggleston/workflows/cassandra/tree/15335-3.0]|
|[3.11|https://github.com/bdeggleston/cassandra/tree/15335-3.11]|[circle|https://circleci.com/gh/bdeggleston/workflows/cassandra/tree/15335-3.11]|
|[trunk|https://github.com/bdeggleston/cassandra/tree/15335-trunk]|[circle|https://circleci.com/gh/bdeggleston/workflows/cassandra/tree/15335-trunk]|

> Node can corrupt gossip state and become unreplaceable
> --
>
> Key: CASSANDRA-15335
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15335
> Project: Cassandra
>  Issue Type: Bug
>  Components: Cluster/Gossip
>Reporter: Blake Eggleston
>Assignee: Blake Eggleston
>Priority: Normal
> Fix For: 3.0.19, 3.11.5, 4.0
>
>
> In {{StorageService#prepareToJoin}}, a starting node first sends out an 
> endpoint state without any tokens. Later, in 
> {{StorageService#finishJoiningRing}} it sends out an endpoint state _with_ 
> it’s tokens. If that node dies between these 2 events and cannot be restarted 
> due to some unrecoverable error, the ring’s gossip state will be missing 
> tokens for that node. This won’t cause any immediate data loss since TMD is 
> populated from system.peers, but it will prevent a replacement node from 
> associating that address with it’s tokens and replacing it. It could also 
> cause data loss if other nodes are added to the ring and don’t see an owned 
> token where there should be one.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-15335) Node can corrupt gossip state and become unreplaceable

2019-09-24 Thread Blake Eggleston (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Eggleston updated CASSANDRA-15335:

 Bug Category: Parent values: Correctness(12982)Level 1 values: 
Consistency(12989)
   Complexity: Normal
  Component/s: Cluster/Gossip
Discovered By: User Report
Fix Version/s: 4.0
   3.11.5
   3.0.19
 Severity: Low
 Assignee: Blake Eggleston
   Status: Open  (was: Triage Needed)

> Node can corrupt gossip state and become unreplaceable
> --
>
> Key: CASSANDRA-15335
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15335
> Project: Cassandra
>  Issue Type: Bug
>  Components: Cluster/Gossip
>Reporter: Blake Eggleston
>Assignee: Blake Eggleston
>Priority: Normal
> Fix For: 3.0.19, 3.11.5, 4.0
>
>
> In {{StorageService#prepareToJoin}}, a starting node first sends out an 
> endpoint state without any tokens. Later, in 
> {{StorageService#finishJoiningRing}} it sends out an endpoint state _with_ 
> it’s tokens. If that node dies between these 2 events and cannot be restarted 
> due to some unrecoverable error, the ring’s gossip state will be missing 
> tokens for that node. This won’t cause any immediate data loss since TMD is 
> populated from system.peers, but it will prevent a replacement node from 
> associating that address with it’s tokens and replacing it. It could also 
> cause data loss if other nodes are added to the ring and don’t see an owned 
> token where there should be one.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org