[jira] [Updated] (CASSANDRA-16629) Rafactor tests for NodeTool commands
[ https://issues.apache.org/jira/browse/CASSANDRA-16629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Zotov updated CASSANDRA-16629: - Test and Documentation Plan: These changes are purely cosmetic and affect unit tests only. Hence, no test and documentation plans are required. (was: These change are purely cosmetic and affect unit tests only. Hence, no test and documentation plans are required.) > Rafactor tests for NodeTool commands > > > Key: CASSANDRA-16629 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16629 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Alexey Zotov >Assignee: Alexey Zotov >Priority: Low > Fix For: 4.0.x > > Time Spent: 10m > Remaining Estimate: 0h > > h3. Overview > As a part of CASSANDRA-16404, I've been working on {{NodeTool}} commands for > invalidation of the auth caches. While working on that, I've mentioned that > the existing NodeTool unit tests are written in a different manner and reside > in wrong packages. I've made the following changes to them: > # moved them to the proper packages (that match original command class) > # unified naming, formatting, imports > # migrated from {{org.assertj}} to {{hamcrest}} for assertions (though it is > not smth really required) > # made a general cleanup > PR: https://github.com/apache/cassandra/pull/982 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16629) Rafactor tests for NodeTool commands
[ https://issues.apache.org/jira/browse/CASSANDRA-16629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Zotov updated CASSANDRA-16629: - Test and Documentation Plan: These change are purely cosmetic and affect unit tests only. Hence, no test and documentation plans are required. Status: Patch Available (was: Open) > Rafactor tests for NodeTool commands > > > Key: CASSANDRA-16629 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16629 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Alexey Zotov >Assignee: Alexey Zotov >Priority: Low > Fix For: 4.0.x > > Time Spent: 10m > Remaining Estimate: 0h > > h3. Overview > As a part of CASSANDRA-16404, I've been working on {{NodeTool}} commands for > invalidation of the auth caches. While working on that, I've mentioned that > the existing NodeTool unit tests are written in a different manner and reside > in wrong packages. I've made the following changes to them: > # moved them to the proper packages (that match original command class) > # unified naming, formatting, imports > # migrated from {{org.assertj}} to {{hamcrest}} for assertions (though it is > not smth really required) > # made a general cleanup > PR: https://github.com/apache/cassandra/pull/982 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16629) Rafactor tests for NodeTool commands
[ https://issues.apache.org/jira/browse/CASSANDRA-16629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Zotov updated CASSANDRA-16629: - Change Category: Code Clarity Complexity: Low Hanging Fruit Priority: Low (was: Normal) Status: Open (was: Triage Needed) > Rafactor tests for NodeTool commands > > > Key: CASSANDRA-16629 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16629 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Alexey Zotov >Assignee: Alexey Zotov >Priority: Low > Fix For: 4.0.x > > Time Spent: 10m > Remaining Estimate: 0h > > h3. Overview > As a part of CASSANDRA-16404, I've been working on {{NodeTool}} commands for > invalidation of the auth caches. While working on that, I've mentioned that > the existing NodeTool unit tests are written in a different manner and reside > in wrong packages. I've made the following changes to them: > # moved them to the proper packages (that match original command class) > # unified naming, formatting, imports > # migrated from {{org.assertj}} to {{hamcrest}} for assertions (though it is > not smth really required) > # made a general cleanup > PR: https://github.com/apache/cassandra/pull/982 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16629) Rafactor tests for NodeTool commands
[ https://issues.apache.org/jira/browse/CASSANDRA-16629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Zotov updated CASSANDRA-16629: - Description: h3. Overview As a part of CASSANDRA-16404, I've been working on {{NodeTool}} commands for invalidation of the auth caches. While working on that, I've mentioned that the existing NodeTool unit tests are written in a different manner and reside in wrong packages. I've made the following changes to them: # moved them to the proper packages (that match original command class) # unified naming, formatting, imports # migrated from {{org.assertj}} to {{hamcrest}} for assertions (though it is not smth really required) # made a general cleanup PR: https://github.com/apache/cassandra/pull/982 was: h3. Overview As a part of CASSANDRA-16404, I've been working on {{NodeTool}} commands for invalidation of the auth caches. While working on that, I've mentioned that the existing NodeTool unit tests are written in a different manner and reside in wrong packages. I've made the following changes to them: # moved them to the proper packages (that match original command class) # unified naming, formatting, imports # migrated from {{org.assertj}} to {{hamcrest}} for assertions (though it is not smth really required) # made a general cleanup > Rafactor tests for NodeTool commands > > > Key: CASSANDRA-16629 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16629 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Alexey Zotov >Assignee: Alexey Zotov >Priority: Normal > Fix For: 4.0.x > > Time Spent: 10m > Remaining Estimate: 0h > > h3. Overview > As a part of CASSANDRA-16404, I've been working on {{NodeTool}} commands for > invalidation of the auth caches. While working on that, I've mentioned that > the existing NodeTool unit tests are written in a different manner and reside > in wrong packages. I've made the following changes to them: > # moved them to the proper packages (that match original command class) > # unified naming, formatting, imports > # migrated from {{org.assertj}} to {{hamcrest}} for assertions (though it is > not smth really required) > # made a general cleanup > PR: https://github.com/apache/cassandra/pull/982 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16629) Rafactor tests for NodeTool commands
[ https://issues.apache.org/jira/browse/CASSANDRA-16629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Zotov updated CASSANDRA-16629: - Fix Version/s: 4.0.x > Rafactor tests for NodeTool commands > > > Key: CASSANDRA-16629 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16629 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Alexey Zotov >Assignee: Alexey Zotov >Priority: Normal > Fix For: 4.0.x > > Time Spent: 10m > Remaining Estimate: 0h > > h3. Overview > As a part of CASSANDRA-16404, I've been working on {{NodeTool}} commands for > invalidation of the auth caches. While working on that, I've mentioned that > the existing NodeTool unit tests are written in a different manner and reside > in wrong packages. I've made the following changes to them: > # moved them to the proper packages (that match original command class) > # unified naming, formatting, imports > # migrated from {{org.assertj}} to {{hamcrest}} for assertions (though it is > not smth really required) > # made a general cleanup -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16629) Rafactor tests for NodeTool commands
[ https://issues.apache.org/jira/browse/CASSANDRA-16629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Zotov updated CASSANDRA-16629: - Description: h3. Overview As a part of CASSANDRA-16404, I've been working on {{NodeTool}} commands for invalidation of the auth caches. While working on that, I've mentioned that the existing NodeTool unit tests are written in a different manner and reside in wrong packages. I've made the following changes to them: # moved them to the proper packages (that match original command class) # unified naming, formatting, imports # migrated from {{org.assertj}} to {{hamcrest}} for assertions (though it is not smth really required) # made a general cleanup was: h3. Overview As a part of CASSANDRA-16404, I've been working on {{NodeTool}} commands for invalidation of the auth caches. While working on that, I've mentioned that the existing NodeTool unit tests are written in a different manner and reside in wrong packages. I've made the following changes to them: # moved them to the proper packages (that match original command class) # unified naming, formatting, imports # migrated from {{org.assertj}} to {{junit}} + {{hamcrest}} (though it is not smth really required) # made a general cleanup > Rafactor tests for NodeTool commands > > > Key: CASSANDRA-16629 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16629 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Alexey Zotov >Assignee: Alexey Zotov >Priority: Normal > > h3. Overview > As a part of CASSANDRA-16404, I've been working on {{NodeTool}} commands for > invalidation of the auth caches. While working on that, I've mentioned that > the existing NodeTool unit tests are written in a different manner and reside > in wrong packages. I've made the following changes to them: > # moved them to the proper packages (that match original command class) > # unified naming, formatting, imports > # migrated from {{org.assertj}} to {{hamcrest}} for assertions (though it is > not smth really required) > # made a general cleanup -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org