[jira] [Updated] (CASSANDRA-16707) JmxHistogram#getRecentValues() is not thread-safe
[
https://issues.apache.org/jira/browse/CASSANDRA-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Semb Wever updated CASSANDRA-16707:
---
Fix Version/s: (was: 4.0.x)
(was: 4.x)
4.1
4.0.1
> JmxHistogram#getRecentValues() is not thread-safe
> -
>
> Key: CASSANDRA-16707
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16707
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/JMX
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.1, 4.1
>
>
> Published {{JmxHistogram}} instances do not protect their “last” field. This
> isn’t a hot path, and there is a multi-part calculation based on it in
> {{getRecentValues()}}, so we should probably just synchronize that method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16707) JmxHistogram#getRecentValues() is not thread-safe
[
https://issues.apache.org/jira/browse/CASSANDRA-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-16707:
Since Version: 4.0-rc2
Source Control Link:
https://github.com/apache/cassandra/commit/e6946e7ddb76bd72109995664289e988b0e9818c
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Committed as
https://github.com/apache/cassandra/commit/e6946e7ddb76bd72109995664289e988b0e9818c
> JmxHistogram#getRecentValues() is not thread-safe
> -
>
> Key: CASSANDRA-16707
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16707
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/JMX
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> Published {{JmxHistogram}} instances do not protect their “last” field. This
> isn’t a hot path, and there is a multi-part calculation based on it in
> {{getRecentValues()}}, so we should probably just synchronize that method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16707) JmxHistogram#getRecentValues() is not thread-safe
[
https://issues.apache.org/jira/browse/CASSANDRA-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-16707:
Status: Ready to Commit (was: Review In Progress)
> JmxHistogram#getRecentValues() is not thread-safe
> -
>
> Key: CASSANDRA-16707
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16707
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/JMX
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> Published {{JmxHistogram}} instances do not protect their “last” field. This
> isn’t a hot path, and there is a multi-part calculation based on it in
> {{getRecentValues()}}, so we should probably just synchronize that method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16707) JmxHistogram#getRecentValues() is not thread-safe
[
https://issues.apache.org/jira/browse/CASSANDRA-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-16707:
Reviewers: Brandon Williams, Yifan Cai (was: Brandon Williams, Caleb
Rackliffe, Yifan Cai)
> JmxHistogram#getRecentValues() is not thread-safe
> -
>
> Key: CASSANDRA-16707
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16707
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/JMX
>Reporter: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> Published {{JmxHistogram}} instances do not protect their “last” field. This
> isn’t a hot path, and there is a multi-part calculation based on it in
> {{getRecentValues()}}, so we should probably just synchronize that method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16707) JmxHistogram#getRecentValues() is not thread-safe
[
https://issues.apache.org/jira/browse/CASSANDRA-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-16707:
Reviewers: Brandon Williams, Yifan Cai, Caleb Rackliffe (was: Brandon
Williams, Caleb Rackliffe, Yifan Cai)
Brandon Williams, Yifan Cai, Caleb Rackliffe (was: Brandon
Williams, Yifan Cai)
Status: Review In Progress (was: Patch Available)
> JmxHistogram#getRecentValues() is not thread-safe
> -
>
> Key: CASSANDRA-16707
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16707
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/JMX
>Reporter: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> Published {{JmxHistogram}} instances do not protect their “last” field. This
> isn’t a hot path, and there is a multi-part calculation based on it in
> {{getRecentValues()}}, so we should probably just synchronize that method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16707) JmxHistogram#getRecentValues() is not thread-safe
[
https://issues.apache.org/jira/browse/CASSANDRA-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-16707:
Reviewers: Brandon Williams, Yifan Cai (was: Brandon Williams)
> JmxHistogram#getRecentValues() is not thread-safe
> -
>
> Key: CASSANDRA-16707
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16707
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/JMX
>Reporter: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> Published {{JmxHistogram}} instances do not protect their “last” field. This
> isn’t a hot path, and there is a multi-part calculation based on it in
> {{getRecentValues()}}, so we should probably just synchronize that method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16707) JmxHistogram#getRecentValues() is not thread-safe
[
https://issues.apache.org/jira/browse/CASSANDRA-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-16707:
Test and Documentation Plan: n/a
Status: Patch Available (was: In Progress)
[patch|https://github.com/apache/cassandra/pull/1035],
[j8|https://app.circleci.com/pipelines/github/maedhroz/cassandra/248/workflows/e3aa2faf-e8c9-415e-9bbc-d6bab47a7123],
[j11|https://app.circleci.com/pipelines/github/maedhroz/cassandra/248/workflows/117c61b9-165c-4006-a2fd-6c220d6460d2]
> JmxHistogram#getRecentValues() is not thread-safe
> -
>
> Key: CASSANDRA-16707
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16707
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/JMX
>Reporter: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> Published {{JmxHistogram}} instances do not protect their “last” field. This
> isn’t a hot path, and there is a multi-part calculation based on it in
> {{getRecentValues()}}, so we should probably just synchronize that method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16707) JmxHistogram#getRecentValues() is not thread-safe
[
https://issues.apache.org/jira/browse/CASSANDRA-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-16707:
Reviewers: Brandon Williams
> JmxHistogram#getRecentValues() is not thread-safe
> -
>
> Key: CASSANDRA-16707
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16707
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/JMX
>Reporter: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> Published {{JmxHistogram}} instances do not protect their “last” field. This
> isn’t a hot path, and there is a multi-part calculation based on it in
> {{getRecentValues()}}, so we should probably just synchronize that method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16707) JmxHistogram#getRecentValues() is not thread-safe
[
https://issues.apache.org/jira/browse/CASSANDRA-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-16707:
Bug Category: Parent values: Correctness(12982)Level 1 values: Transient
Incorrect Response(12987)
Complexity: Low Hanging Fruit
Discovered By: Code Inspection
Fix Version/s: 4.x
4.0.x
Severity: Low
Status: Open (was: Triage Needed)
> JmxHistogram#getRecentValues() is not thread-safe
> -
>
> Key: CASSANDRA-16707
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16707
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/JMX
>Reporter: Caleb Rackliffe
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> Published {{JmxHistogram}} instances do not protect their “last” field. This
> isn’t a hot path, and there is a multi-part calculation based on it in
> {{getRecentValues()}}, so we should probably just synchronize that method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
