[jira] [Updated] (CASSANDRA-17874) Only reload compaction strategies if disk boundaries change
[ https://issues.apache.org/jira/browse/CASSANDRA-17874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-17874: Fix Version/s: 4.2 (was: 4.x) Source Control Link: https://github.com/apache/cassandra/commit/94bcb4e5ec4fb99b73276d90b9d08def6f3b4d30 Resolution: Fixed Status: Resolved (was: Ready to Commit) And committed, thanks test run; https://app.circleci.com/pipelines/github/krummas/cassandra/847/workflows/ac3511aa-9c61-4c2f-b7cb-c1853c7014a7 > Only reload compaction strategies if disk boundaries change > --- > > Key: CASSANDRA-17874 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17874 > Project: Cassandra > Issue Type: Improvement > Components: Local/Compaction >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Low > Fix For: 4.2 > > > We currently reload compaction strategies every time ringVersion changes - we > should change this to only reload if the ring version change actually changes > the disk boundaries. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17874) Only reload compaction strategies if disk boundaries change
[
https://issues.apache.org/jira/browse/CASSANDRA-17874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksey Yeschenko updated CASSANDRA-17874:
--
Status: Ready to Commit (was: Review In Progress)
Suggested some cleanup to pre-existing code as part of the patch, since this is
going to trunk, to make {{CSM#reload()}} and its callsites easier to reason
about, ultimately splitting it into several. Patch LGTM with or without
accepting cleanup suggestions.
> Only reload compaction strategies if disk boundaries change
> ---
>
> Key: CASSANDRA-17874
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17874
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Compaction
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Low
> Fix For: 4.x
>
>
> We currently reload compaction strategies every time ringVersion changes - we
> should change this to only reload if the ring version change actually changes
> the disk boundaries.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17874) Only reload compaction strategies if disk boundaries change
[ https://issues.apache.org/jira/browse/CASSANDRA-17874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko updated CASSANDRA-17874: -- Status: Review In Progress (was: Patch Available) > Only reload compaction strategies if disk boundaries change > --- > > Key: CASSANDRA-17874 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17874 > Project: Cassandra > Issue Type: Improvement > Components: Local/Compaction >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Low > Fix For: 4.x > > > We currently reload compaction strategies every time ringVersion changes - we > should change this to only reload if the ring version change actually changes > the disk boundaries. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17874) Only reload compaction strategies if disk boundaries change
[ https://issues.apache.org/jira/browse/CASSANDRA-17874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-17874: Change Category: Performance Complexity: Low Hanging Fruit Component/s: Local/Compaction Fix Version/s: 4.x Reviewers: Aleksey Yeschenko Priority: Low (was: Normal) Status: Open (was: Triage Needed) > Only reload compaction strategies if disk boundaries change > --- > > Key: CASSANDRA-17874 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17874 > Project: Cassandra > Issue Type: Improvement > Components: Local/Compaction >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Low > Fix For: 4.x > > > We currently reload compaction strategies every time ringVersion changes - we > should change this to only reload if the ring version change actually changes > the disk boundaries. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17874) Only reload compaction strategies if disk boundaries change
[ https://issues.apache.org/jira/browse/CASSANDRA-17874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-17874: Test and Documentation Plan: cci run Status: Patch Available (was: Open) https://github.com/apache/cassandra/pull/1833 https://app.circleci.com/pipelines/github/krummas/cassandra/820/workflows/0d3dc10e-0e45-4f4a-843a-94c4e1a75c17 > Only reload compaction strategies if disk boundaries change > --- > > Key: CASSANDRA-17874 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17874 > Project: Cassandra > Issue Type: Improvement > Components: Local/Compaction >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Low > Fix For: 4.x > > > We currently reload compaction strategies every time ringVersion changes - we > should change this to only reload if the ring version change actually changes > the disk boundaries. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
