[jira] [Updated] (CASSANDRA-7269) Make CqlInputFormat and CqlRecordReader consistent with comments
[ https://issues.apache.org/jira/browse/CASSANDRA-7269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Thompson updated CASSANDRA-7269: --- Reviewer: Brandon Williams Fix Version/s: 2.1.3 > Make CqlInputFormat and CqlRecordReader consistent with comments > > > Key: CASSANDRA-7269 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7269 > Project: Cassandra > Issue Type: Bug > Components: Hadoop >Reporter: Jeremy Hanna >Assignee: Rekha Joshi >Priority: Minor > Labels: hadoop > Fix For: 2.1.3 > > Attachments: CASSANDRA-7269.txt > > > Both the CqlInputFormat and CqlPagingInputFormat have the following comment: > {code} > /** > ... > * the number of CQL rows per page > * CQLConfigHelper.setInputCQLPageRowSize. The default page row size is > 1000. You > * should set it to "as big as possible, but no bigger." It set the LIMIT > for the CQL > * query, so you need set it big enough to minimize the network overhead, > and also > * not too big to avoid out of memory issue. > ... > **/ > {code} > The property is used in both classes, but the default is only set to 1000 in > CqlPagingRecordReader explicitly. > We should either make the default part of the CqlConfigHelper so it's set in > both places or update the comments in the CqlInputFormat to say that if it's > not set, it will default to the java driver fetch size which is 5000. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-7269) Make CqlInputFormat and CqlRecordReader consistent with comments
[ https://issues.apache.org/jira/browse/CASSANDRA-7269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rekha Joshi updated CASSANDRA-7269: --- Attachment: CASSANDRA-7269.txt > Make CqlInputFormat and CqlRecordReader consistent with comments > > > Key: CASSANDRA-7269 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7269 > Project: Cassandra > Issue Type: Bug > Components: Hadoop >Reporter: Jeremy Hanna >Priority: Minor > Labels: hadoop > Attachments: CASSANDRA-7269.txt > > > Both the CqlInputFormat and CqlPagingInputFormat have the following comment: > {code} > /** > ... > * the number of CQL rows per page > * CQLConfigHelper.setInputCQLPageRowSize. The default page row size is > 1000. You > * should set it to "as big as possible, but no bigger." It set the LIMIT > for the CQL > * query, so you need set it big enough to minimize the network overhead, > and also > * not too big to avoid out of memory issue. > ... > **/ > {code} > The property is used in both classes, but the default is only set to 1000 in > CqlPagingRecordReader explicitly. > We should either make the default part of the CqlConfigHelper so it's set in > both places or update the comments in the CqlInputFormat to say that if it's > not set, it will default to the java driver fetch size which is 5000. -- This message was sent by Atlassian JIRA (v6.3.4#6332)