[jira] [Updated] (CASSANDRA-9477) nodetool repair should exit with non-zero status on failure
[ https://issues.apache.org/jira/browse/CASSANDRA-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylvain Lebresne updated CASSANDRA-9477: Fix Version/s: (was: 2.1.x) > nodetool repair should exit with non-zero status on failure > --- > > Key: CASSANDRA-9477 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9477 > Project: Cassandra > Issue Type: Bug > Components: Tools >Reporter: Randy Fradin >Assignee: Clément Lardeur >Priority: Minor > Attachments: cassandra-2.1-9477.patch > > > Previously nodetool repair would exit with a non-zero status code when it > experienced an error (like in CASSANDRA-5203), e.g. due a neighbor being down > or a failed stream. It appears this is no longer the case, which makes it a > bit harder to automate repair. I suspect it's been this way since > CASSANDRA-6381 was implemented, and that it probably affects other nodetool > commands as well. > It looks like NodeProbe tracks when a failure occurs and this is accessible > via NodeProbe.isFailed(), but that value is not being used anywhere. I think > the problem could be fixed inside NodeTool.NodeToolCmd.run(), if after the > execute function is called, probe.isFailed() is checked and a > RuntimeException is thrown if a failure has occurred. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-9477) nodetool repair should exit with non-zero status on failure
[ https://issues.apache.org/jira/browse/CASSANDRA-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis updated CASSANDRA-9477: -- Reviewer: Randy Fradin Since that looks like what Randy had in mind I'll assume he is okay with it. Marking ready for test. > nodetool repair should exit with non-zero status on failure > --- > > Key: CASSANDRA-9477 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9477 > Project: Cassandra > Issue Type: Bug > Components: Tools >Reporter: Randy Fradin >Assignee: Clément Lardeur >Priority: Minor > Fix For: 2.1.x > > Attachments: cassandra-2.1-9477.patch > > > Previously nodetool repair would exit with a non-zero status code when it > experienced an error (like in CASSANDRA-5203), e.g. due a neighbor being down > or a failed stream. It appears this is no longer the case, which makes it a > bit harder to automate repair. I suspect it's been this way since > CASSANDRA-6381 was implemented, and that it probably affects other nodetool > commands as well. > It looks like NodeProbe tracks when a failure occurs and this is accessible > via NodeProbe.isFailed(), but that value is not being used anywhere. I think > the problem could be fixed inside NodeTool.NodeToolCmd.run(), if after the > execute function is called, probe.isFailed() is checked and a > RuntimeException is thrown if a failure has occurred. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-9477) nodetool repair should exit with non-zero status on failure
[ https://issues.apache.org/jira/browse/CASSANDRA-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clément Lardeur updated CASSANDRA-9477: --- Attachment: cassandra-2.1-9477.patch Throw a runtime exception and exit with non-zero status code when JMX command has failed. > nodetool repair should exit with non-zero status on failure > --- > > Key: CASSANDRA-9477 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9477 > Project: Cassandra > Issue Type: Bug > Components: Tools >Reporter: Randy Fradin >Assignee: Clément Lardeur >Priority: Minor > Fix For: 2.1.x > > Attachments: cassandra-2.1-9477.patch > > > Previously nodetool repair would exit with a non-zero status code when it > experienced an error (like in CASSANDRA-5203), e.g. due a neighbor being down > or a failed stream. It appears this is no longer the case, which makes it a > bit harder to automate repair. I suspect it's been this way since > CASSANDRA-6381 was implemented, and that it probably affects other nodetool > commands as well. > It looks like NodeProbe tracks when a failure occurs and this is accessible > via NodeProbe.isFailed(), but that value is not being used anywhere. I think > the problem could be fixed inside NodeTool.NodeToolCmd.run(), if after the > execute function is called, probe.isFailed() is checked and a > RuntimeException is thrown if a failure has occurred. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-9477) nodetool repair should exit with non-zero status on failure
[ https://issues.apache.org/jira/browse/CASSANDRA-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis updated CASSANDRA-9477: -- Fix Version/s: 2.1.x > nodetool repair should exit with non-zero status on failure > --- > > Key: CASSANDRA-9477 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9477 > Project: Cassandra > Issue Type: Bug > Components: Tools >Reporter: Randy Fradin > Fix For: 2.1.x > > > Previously nodetool repair would exit with a non-zero status code when it > experienced an error (like in CASSANDRA-5203), e.g. due a neighbor being down > or a failed stream. It appears this is no longer the case, which makes it a > bit harder to automate repair. I suspect it's been this way since > CASSANDRA-6381 was implemented, and that it probably affects other nodetool > commands as well. > It looks like NodeProbe tracks when a failure occurs and this is accessible > via NodeProbe.isFailed(), but that value is not being used anywhere. I think > the problem could be fixed inside NodeTool.NodeToolCmd.run(), if after the > execute function is called, probe.isFailed() is checked and a > RuntimeException is thrown if a failure has occurred. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (CASSANDRA-9477) nodetool repair should exit with non-zero status on failure
[ https://issues.apache.org/jira/browse/CASSANDRA-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Ellis updated CASSANDRA-9477: -- Priority: Minor (was: Major) > nodetool repair should exit with non-zero status on failure > --- > > Key: CASSANDRA-9477 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9477 > Project: Cassandra > Issue Type: Bug > Components: Tools >Reporter: Randy Fradin >Priority: Minor > Fix For: 2.1.x > > > Previously nodetool repair would exit with a non-zero status code when it > experienced an error (like in CASSANDRA-5203), e.g. due a neighbor being down > or a failed stream. It appears this is no longer the case, which makes it a > bit harder to automate repair. I suspect it's been this way since > CASSANDRA-6381 was implemented, and that it probably affects other nodetool > commands as well. > It looks like NodeProbe tracks when a failure occurs and this is accessible > via NodeProbe.isFailed(), but that value is not being used anywhere. I think > the problem could be fixed inside NodeTool.NodeToolCmd.run(), if after the > execute function is called, probe.isFailed() is checked and a > RuntimeException is thrown if a failure has occurred. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
