[jira] [Updated] (CASSANDRASC-69) Refactor Configuration
[
https://issues.apache.org/jira/browse/CASSANDRASC-69?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yifan Cai updated CASSANDRASC-69:
-
Fix Version/s: 1.0
Source Control Link:
https://github.com/apache/cassandra-sidecar/commit/63292010803875af6496ce7c787f404e66311375
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Refactor Configuration
> --
>
> Key: CASSANDRASC-69
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-69
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
> Fix For: 1.0
>
>
> Currently, the Sidecar Configuration is provided via a yaml file. The yaml
> file is parsed and a the configuration is used during the Sidecar application
> runtime.
> The configuration parsing is done manually, and adding a new configuration to
> the yaml file has become a big task where multiple files need to be touched.
> Ideally, we should add the configuration POJOs needed for new configurations
> and add the new fields in the yaml file.
> Additionally, we are leaking the configuration implementation to the
> {{InstancesConfig}}. We should improve the separation of concerns from the
> yaml configuration and the instances configuration.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-69) Refactor Configuration
[
https://issues.apache.org/jira/browse/CASSANDRASC-69?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yifan Cai updated CASSANDRASC-69:
-
Reviewers: Dinesh Joshi, Yifan Cai (was: Yifan Cai)
> Refactor Configuration
> --
>
> Key: CASSANDRASC-69
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-69
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> Currently, the Sidecar Configuration is provided via a yaml file. The yaml
> file is parsed and a the configuration is used during the Sidecar application
> runtime.
> The configuration parsing is done manually, and adding a new configuration to
> the yaml file has become a big task where multiple files need to be touched.
> Ideally, we should add the configuration POJOs needed for new configurations
> and add the new fields in the yaml file.
> Additionally, we are leaking the configuration implementation to the
> {{InstancesConfig}}. We should improve the separation of concerns from the
> yaml configuration and the instances configuration.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-69) Refactor Configuration
[
https://issues.apache.org/jira/browse/CASSANDRASC-69?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yifan Cai updated CASSANDRASC-69:
-
Status: Ready to Commit (was: Review In Progress)
> Refactor Configuration
> --
>
> Key: CASSANDRASC-69
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-69
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> Currently, the Sidecar Configuration is provided via a yaml file. The yaml
> file is parsed and a the configuration is used during the Sidecar application
> runtime.
> The configuration parsing is done manually, and adding a new configuration to
> the yaml file has become a big task where multiple files need to be touched.
> Ideally, we should add the configuration POJOs needed for new configurations
> and add the new fields in the yaml file.
> Additionally, we are leaking the configuration implementation to the
> {{InstancesConfig}}. We should improve the separation of concerns from the
> yaml configuration and the instances configuration.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-69) Refactor Configuration
[
https://issues.apache.org/jira/browse/CASSANDRASC-69?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yifan Cai updated CASSANDRASC-69:
-
Reviewers: Yifan Cai
Status: Review In Progress (was: Patch Available)
+1 on the patch. Thank you for addressing my comments!
> Refactor Configuration
> --
>
> Key: CASSANDRASC-69
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-69
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> Currently, the Sidecar Configuration is provided via a yaml file. The yaml
> file is parsed and a the configuration is used during the Sidecar application
> runtime.
> The configuration parsing is done manually, and adding a new configuration to
> the yaml file has become a big task where multiple files need to be touched.
> Ideally, we should add the configuration POJOs needed for new configurations
> and add the new fields in the yaml file.
> Additionally, we are leaking the configuration implementation to the
> {{InstancesConfig}}. We should improve the separation of concerns from the
> yaml configuration and the instances configuration.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-69) Refactor Configuration
[
https://issues.apache.org/jira/browse/CASSANDRASC-69?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francisco Guerrero updated CASSANDRASC-69:
--
Test and Documentation Plan: Added tests to validate parsing of yaml
configuration files. Updated existing test that use configuration
Status: Patch Available (was: In Progress)
> Refactor Configuration
> --
>
> Key: CASSANDRASC-69
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-69
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> Currently, the Sidecar Configuration is provided via a yaml file. The yaml
> file is parsed and a the configuration is used during the Sidecar application
> runtime.
> The configuration parsing is done manually, and adding a new configuration to
> the yaml file has become a big task where multiple files need to be touched.
> Ideally, we should add the configuration POJOs needed for new configurations
> and add the new fields in the yaml file.
> Additionally, we are leaking the configuration implementation to the
> {{InstancesConfig}}. We should improve the separation of concerns from the
> yaml configuration and the instances configuration.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-69) Refactor Configuration
[
https://issues.apache.org/jira/browse/CASSANDRASC-69?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated CASSANDRASC-69:
--
Labels: pull-request-available (was: )
> Refactor Configuration
> --
>
> Key: CASSANDRASC-69
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-69
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> Currently, the Sidecar Configuration is provided via a yaml file. The yaml
> file is parsed and a the configuration is used during the Sidecar application
> runtime.
> The configuration parsing is done manually, and adding a new configuration to
> the yaml file has become a big task where multiple files need to be touched.
> Ideally, we should add the configuration POJOs needed for new configurations
> and add the new fields in the yaml file.
> Additionally, we are leaking the configuration implementation to the
> {{InstancesConfig}}. We should improve the separation of concerns from the
> yaml configuration and the instances configuration.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-69) Refactor Configuration
[
https://issues.apache.org/jira/browse/CASSANDRASC-69?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francisco Guerrero updated CASSANDRASC-69:
--
Change Category: Semantic
Complexity: Normal
Component/s: Configuration
Status: Open (was: Triage Needed)
> Refactor Configuration
> --
>
> Key: CASSANDRASC-69
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-69
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
>
> Currently, the Sidecar Configuration is provided via a yaml file. The yaml
> file is parsed and a the configuration is used during the Sidecar application
> runtime.
> The configuration parsing is done manually, and adding a new configuration to
> the yaml file has become a big task where multiple files need to be touched.
> Ideally, we should add the configuration POJOs needed for new configurations
> and add the new fields in the yaml file.
> Additionally, we are leaking the configuration implementation to the
> {{InstancesConfig}}. We should improve the separation of concerns from the
> yaml configuration and the instances configuration.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
