[jira] [Commented] (CASSANDRA-2352) zero-length strings should result in zero-length ByteBuffers

2011-03-22 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13009949#comment-13009949
 ] 

Hudson commented on CASSANDRA-2352:
---

Integrated in Cassandra #797 (See 
[https://hudson.apache.org/hudson/job/Cassandra/797/])


 zero-length strings should result in zero-length ByteBuffers
 

 Key: CASSANDRA-2352
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2352
 Project: Cassandra
  Issue Type: Bug
  Components: API, Core
Reporter: Eric Evans
Assignee: Eric Evans
  Labels: cql
 Fix For: 0.8

 Attachments: 
 v1-0001-CASSANDRA-2352-AT.fromString-should-return-empty-BB-fo.txt


 The {{o.a.c.db.marshal.AbstractType.fromString()}} methods should return an 
 empty {{ByteBuffer}} when passed a zero-length string, (empty bytes do 
 {{validate()}} properly).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (CASSANDRA-2352) zero-length strings should result in zero-length ByteBuffers

2011-03-18 Thread Stu Hood (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13008359#comment-13008359
 ] 

Stu Hood commented on CASSANDRA-2352:
-

Does this mean empty strings will validate as column names?

 zero-length strings should result in zero-length ByteBuffers
 

 Key: CASSANDRA-2352
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2352
 Project: Cassandra
  Issue Type: Bug
  Components: API, Core
Reporter: Eric Evans
Assignee: Eric Evans
  Labels: cql
 Fix For: 0.8

 Attachments: 
 v1-0001-CASSANDRA-2352-AT.fromString-should-return-empty-BB-fo.txt


 The {{o.a.c.db.marshal.AbstractType.fromString()}} methods should return an 
 empty {{ByteBuffer}} when passed a zero-length string, (empty bytes do 
 {{validate()}} properly).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (CASSANDRA-2352) zero-length strings should result in zero-length ByteBuffers

2011-03-18 Thread Jonathan Ellis (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13008423#comment-13008423
 ] 

Jonathan Ellis commented on CASSANDRA-2352:
---

We have separate checks in ThriftValidation for name.remaining() != 0.

I'm guessing this is to make it easier to do slicing, where empty start is 
valid?

 zero-length strings should result in zero-length ByteBuffers
 

 Key: CASSANDRA-2352
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2352
 Project: Cassandra
  Issue Type: Bug
  Components: API, Core
Reporter: Eric Evans
Assignee: Eric Evans
  Labels: cql
 Fix For: 0.8

 Attachments: 
 v1-0001-CASSANDRA-2352-AT.fromString-should-return-empty-BB-fo.txt


 The {{o.a.c.db.marshal.AbstractType.fromString()}} methods should return an 
 empty {{ByteBuffer}} when passed a zero-length string, (empty bytes do 
 {{validate()}} properly).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (CASSANDRA-2352) zero-length strings should result in zero-length ByteBuffers

2011-03-18 Thread Eric Evans (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13008467#comment-13008467
 ] 

Eric Evans commented on CASSANDRA-2352:
---

bq. Does this mean empty strings will validate as column names?

The {{AbstractType.validate()}} methods already allow this.  As Jonathan says, 
wherever that's not acceptable, {{ThriftValidation}} has tests to ensure 
name.remaining() != 0.

 zero-length strings should result in zero-length ByteBuffers
 

 Key: CASSANDRA-2352
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2352
 Project: Cassandra
  Issue Type: Bug
  Components: API, Core
Reporter: Eric Evans
Assignee: Eric Evans
  Labels: cql
 Fix For: 0.8

 Attachments: 
 v1-0001-CASSANDRA-2352-AT.fromString-should-return-empty-BB-fo.txt


 The {{o.a.c.db.marshal.AbstractType.fromString()}} methods should return an 
 empty {{ByteBuffer}} when passed a zero-length string, (empty bytes do 
 {{validate()}} properly).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (CASSANDRA-2352) zero-length strings should result in zero-length ByteBuffers

2011-03-17 Thread Gary Dusbabek (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13008143#comment-13008143
 ] 

Gary Dusbabek commented on CASSANDRA-2352:
--

+1

 zero-length strings should result in zero-length ByteBuffers
 

 Key: CASSANDRA-2352
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2352
 Project: Cassandra
  Issue Type: Bug
  Components: API, Core
Reporter: Eric Evans
Assignee: Eric Evans
  Labels: cql
 Fix For: 0.8

 Attachments: 
 v1-0001-CASSANDRA-2352-AT.fromString-should-return-empty-BB-fo.txt


 The {{o.a.c.db.marshal.AbstractType.fromString()}} methods should return an 
 empty {{ByteBuffer}} when passed a zero-length string, (empty bytes do 
 {{validate()}} properly).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (CASSANDRA-2352) zero-length strings should result in zero-length ByteBuffers

2011-03-17 Thread Jonathan Ellis (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13008176#comment-13008176
 ] 

Jonathan Ellis commented on CASSANDRA-2352:
---

we actually keep BBUtil.EMPTY_BYTE_BUFFER to avoid allocating lots of 
zero-length BBs, can you update post-commit?

 zero-length strings should result in zero-length ByteBuffers
 

 Key: CASSANDRA-2352
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2352
 Project: Cassandra
  Issue Type: Bug
  Components: API, Core
Reporter: Eric Evans
Assignee: Eric Evans
  Labels: cql
 Fix For: 0.8

 Attachments: 
 v1-0001-CASSANDRA-2352-AT.fromString-should-return-empty-BB-fo.txt


 The {{o.a.c.db.marshal.AbstractType.fromString()}} methods should return an 
 empty {{ByteBuffer}} when passed a zero-length string, (empty bytes do 
 {{validate()}} properly).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (CASSANDRA-2352) zero-length strings should result in zero-length ByteBuffers

2011-03-17 Thread Jonathan Ellis (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13008289#comment-13008289
 ] 

Jonathan Ellis commented on CASSANDRA-2352:
---

went ahead and did this.

 zero-length strings should result in zero-length ByteBuffers
 

 Key: CASSANDRA-2352
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2352
 Project: Cassandra
  Issue Type: Bug
  Components: API, Core
Reporter: Eric Evans
Assignee: Eric Evans
  Labels: cql
 Fix For: 0.8

 Attachments: 
 v1-0001-CASSANDRA-2352-AT.fromString-should-return-empty-BB-fo.txt


 The {{o.a.c.db.marshal.AbstractType.fromString()}} methods should return an 
 empty {{ByteBuffer}} when passed a zero-length string, (empty bytes do 
 {{validate()}} properly).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (CASSANDRA-2352) zero-length strings should result in zero-length ByteBuffers

2011-03-17 Thread Eric Evans (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13008318#comment-13008318
 ] 

Eric Evans commented on CASSANDRA-2352:
---

Thanks Jonathan!

 zero-length strings should result in zero-length ByteBuffers
 

 Key: CASSANDRA-2352
 URL: https://issues.apache.org/jira/browse/CASSANDRA-2352
 Project: Cassandra
  Issue Type: Bug
  Components: API, Core
Reporter: Eric Evans
Assignee: Eric Evans
  Labels: cql
 Fix For: 0.8

 Attachments: 
 v1-0001-CASSANDRA-2352-AT.fromString-should-return-empty-BB-fo.txt


 The {{o.a.c.db.marshal.AbstractType.fromString()}} methods should return an 
 empty {{ByteBuffer}} when passed a zero-length string, (empty bytes do 
 {{validate()}} properly).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira