cassandra git commit: use StringBuilder correctly

2016-09-04 Thread dbrosius 
Repository: cassandra
Updated Branches:
  refs/heads/trunk 7d593b760 -> 3c95d4731


use StringBuilder correctly


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/3c95d473
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/3c95d473
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/3c95d473

Branch: refs/heads/trunk
Commit: 3c95d4731cfc1ad575f92e6c1944bf6f881e74d2
Parents: 7d593b7
Author: Dave Brosius 
Authored: Sun Sep 4 12:19:16 2016 -0400
Committer: Dave Brosius 
Committed: Sun Sep 4 12:19:16 2016 -0400

--
 src/java/org/apache/cassandra/metrics/TableMetrics.java |  2 +-
 src/java/org/apache/cassandra/tools/nodetool/Ring.java  |  4 ++--
 .../org/apache/cassandra/tools/nodetool/Status.java |  4 ++--
 .../src/org/apache/cassandra/stress/StressProfile.java  |  4 ++--
 .../stress/settings/OptionAnyProbabilities.java | 10 +-
 .../apache/cassandra/stress/settings/OptionMulti.java   | 12 ++--
 6 files changed, 18 insertions(+), 18 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/3c95d473/src/java/org/apache/cassandra/metrics/TableMetrics.java
--
diff --git a/src/java/org/apache/cassandra/metrics/TableMetrics.java 
b/src/java/org/apache/cassandra/metrics/TableMetrics.java
index c57f240..0a726d4 100644
--- a/src/java/org/apache/cassandra/metrics/TableMetrics.java
+++ b/src/java/org/apache/cassandra/metrics/TableMetrics.java
@@ -952,7 +952,7 @@ public class TableMetrics
 String groupName = TableMetrics.class.getPackage().getName();
 StringBuilder mbeanName = new StringBuilder();
 mbeanName.append(groupName).append(":");
-mbeanName.append("type=" + type);
+mbeanName.append("type=").append(type);
 mbeanName.append(",name=").append(metricName);
 return new CassandraMetricsRegistry.MetricName(groupName, type, 
metricName, "all", mbeanName.toString());
 }

http://git-wip-us.apache.org/repos/asf/cassandra/blob/3c95d473/src/java/org/apache/cassandra/tools/nodetool/Ring.java
--
diff --git a/src/java/org/apache/cassandra/tools/nodetool/Ring.java 
b/src/java/org/apache/cassandra/tools/nodetool/Ring.java
index 55220a1..c6b9af1 100644
--- a/src/java/org/apache/cassandra/tools/nodetool/Ring.java
+++ b/src/java/org/apache/cassandra/tools/nodetool/Ring.java
@@ -72,7 +72,7 @@ public class Ring extends NodeToolCmd
 String formatPlaceholder = "%%-%ds  
%%-12s%%-7s%%-8s%%-16s%%-20s%%-44s%%n";
 String format = format(formatPlaceholder, maxAddressLength);
 
-StringBuffer errors = new StringBuffer();
+StringBuilder errors = new StringBuilder();
 boolean showEffectiveOwnership = true;
 // Calculate per-token ownership of the ring
 Map ownerships;
@@ -83,7 +83,7 @@ public class Ring extends NodeToolCmd
 catch (IllegalStateException ex)
 {
 ownerships = probe.getOwnership();
-errors.append("Note: " + ex.getMessage() + "%n");
+errors.append("Note: ").append(ex.getMessage()).append("%n");
 showEffectiveOwnership = false;
 }
 catch (IllegalArgumentException ex)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/3c95d473/src/java/org/apache/cassandra/tools/nodetool/Status.java
--
diff --git a/src/java/org/apache/cassandra/tools/nodetool/Status.java 
b/src/java/org/apache/cassandra/tools/nodetool/Status.java
index a43b703..f7bb1e5 100644
--- a/src/java/org/apache/cassandra/tools/nodetool/Status.java
+++ b/src/java/org/apache/cassandra/tools/nodetool/Status.java
@@ -65,7 +65,7 @@ public class Status extends NodeToolCmd
 hostIDMap = probe.getHostIdMap();
 epSnitchInfo = probe.getEndpointSnitchInfoProxy();
 
-StringBuffer errors = new StringBuffer();
+StringBuilder errors = new StringBuilder();
 
 Map ownerships = null;
 boolean hasEffectiveOwns = false;
@@ -77,7 +77,7 @@ public class Status extends NodeToolCmd
 catch (IllegalStateException e)
 {
 ownerships = probe.getOwnership();
-errors.append("Note: " + e.getMessage() + "%n");
+errors.append("Note: ").append(e.getMessage()).append("%n");
 }
 catch (IllegalArgumentException ex)
 {

http://git-wip-us.apache.org/repos/asf/cassandra/blob/3c95d473/tools/stress/src/org/apache/cassandra/stress/StressProfile.java

cassandra git commit: use StringBuilder correctly

2016-08-01 Thread dbrosius 
Repository: cassandra
Updated Branches:
  refs/heads/trunk eaf4b91ae -> f59a78b76


use StringBuilder correctly


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/f59a78b7
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/f59a78b7
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/f59a78b7

Branch: refs/heads/trunk
Commit: f59a78b7625f7679794c3db1a185344af1353ebd
Parents: eaf4b91
Author: Dave Brosius 
Authored: Mon Aug 1 19:35:51 2016 -0400
Committer: Dave Brosius 
Committed: Mon Aug 1 19:35:51 2016 -0400

--
 src/java/org/apache/cassandra/db/ColumnFamilyStoreCQLHelper.java | 2 +-
 src/java/org/apache/cassandra/gms/FailureDetector.java   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/f59a78b7/src/java/org/apache/cassandra/db/ColumnFamilyStoreCQLHelper.java
--
diff --git a/src/java/org/apache/cassandra/db/ColumnFamilyStoreCQLHelper.java 
b/src/java/org/apache/cassandra/db/ColumnFamilyStoreCQLHelper.java
index f040575..91c04a8 100644
--- a/src/java/org/apache/cassandra/db/ColumnFamilyStoreCQLHelper.java
+++ b/src/java/org/apache/cassandra/db/ColumnFamilyStoreCQLHelper.java
@@ -330,7 +330,7 @@ public class ColumnFamilyStoreCQLHelper
 {
 builder.append(singleQuote(entry.getKey()));
 builder.append(": ");
-builder.append("0x" + ByteBufferUtil.bytesToHex(entry.getValue()));
+
builder.append("0x").append(ByteBufferUtil.bytesToHex(entry.getValue()));
 }
 builder.append(" }");
 return builder.toString();

http://git-wip-us.apache.org/repos/asf/cassandra/blob/f59a78b7/src/java/org/apache/cassandra/gms/FailureDetector.java
--
diff --git a/src/java/org/apache/cassandra/gms/FailureDetector.java 
b/src/java/org/apache/cassandra/gms/FailureDetector.java
index 7d8b88b..c73cc07 100644
--- a/src/java/org/apache/cassandra/gms/FailureDetector.java
+++ b/src/java/org/apache/cassandra/gms/FailureDetector.java
@@ -351,7 +351,7 @@ public class FailureDetector implements IFailureDetector, 
FailureDetectorMBean
 for (InetAddress ep : eps)
 {
 ArrivalWindow hWnd = arrivalSamples.get(ep);
-sb.append(ep + " : ");
+sb.append(ep).append(" : ");
 sb.append(hWnd);
 sb.append(System.getProperty("line.separator"));
 }