[jira] [Closed] (CELIX-421) Android Docker build fails due to missing zlib dependency

2018-01-29 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-421.
--

> Android Docker build fails due to missing zlib dependency
> -
>
> Key: CELIX-421
> URL: https://issues.apache.org/jira/browse/CELIX-421
> Project: Celix
>  Issue Type: Bug
>Reporter: Bjoern Petri
>Priority: Trivial
>
> When using the Docker environment for building an Android version, the 
> according docker image cannot be created. This is caused by the usage of zlib 
> library 1.2.8 which is not availabe anymore at the set url.  
> It seems that the build progress works fine  when using zlib 1.2.11. Though I 
> still need to check the build artefact.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (CELIX-421) Android Docker build fails due to missing zlib dependency

2018-01-29 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri resolved CELIX-421.

Resolution: Fixed

This has already been resolved by CELIX-387.

> Android Docker build fails due to missing zlib dependency
> -
>
> Key: CELIX-421
> URL: https://issues.apache.org/jira/browse/CELIX-421
> Project: Celix
>  Issue Type: Bug
>Reporter: Bjoern Petri
>Priority: Trivial
>
> When using the Docker environment for building an Android version, the 
> according docker image cannot be created. This is caused by the usage of zlib 
> library 1.2.8 which is not availabe anymore at the set url.  
> It seems that the build progress works fine  when using zlib 1.2.11. Though I 
> still need to check the build artefact.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (CELIX-421) Android Docker build fails due to missing zlib dependency

2018-01-28 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-421:
--

 Summary: Android Docker build fails due to missing zlib dependency
 Key: CELIX-421
 URL: https://issues.apache.org/jira/browse/CELIX-421
 Project: Celix
  Issue Type: Bug
Reporter: Bjoern Petri


When using the Docker environment for building an Android version, the 
according docker image cannot be created. This is caused by the usage of zlib 
library 1.2.8 which is not availabe anymore at the set url.  

It seems that the build progress works fine  when using zlib 1.2.11. Though I 
still need to check the build artefact.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CELIX-151) Sync issue with Topology Manager during shutdown

2016-07-06 Thread Bjoern Petri (JIRA)

[ 
https://issues.apache.org/jira/browse/CELIX-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15365659#comment-15365659
 ] 

Bjoern Petri commented on CELIX-151:


I don't think so, but I'll doublecheck and close this issue if that's the case.

> Sync issue with Topology Manager during shutdown
> 
>
> Key: CELIX-151
> URL: https://issues.apache.org/jira/browse/CELIX-151
> Project: Celix
>  Issue Type: Bug
>  Components: Framework
>Reporter: Bjoern Petri
>Assignee: Bjoern Petri
>
> During the shutdown, the topology manager can close rexport Registrations 
> which leads to an uninstallation of the according endpoint/proxy bundle and 
> therefore the removal from the bundle_pt structure in the installedBundleMap.
> This wil mess up the hashMapIterator in framework_shutdown and lead to an 
> endless loop.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-333) integrate coverity scans

2016-01-16 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-333.
--
Resolution: Fixed

Travis is set up to init a coverity scan every 5th build. This is needed 
because there are some limitations concerning the usage of the coverity API. 
Also note that this only works if the 5th build is executed on the 
develop-branch and not on one of the feature branches. 

> integrate coverity scans
> 
>
> Key: CELIX-333
> URL: https://issues.apache.org/jira/browse/CELIX-333
> Project: Celix
>  Issue Type: Improvement
>Reporter: Bjoern Petri
>Assignee: Bjoern Petri
>
> Add support for automated coverity scans (see 
> https://scan.coverity.com/projects/apache-celix?tab=overview)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-341) Fix coverity issues in Shell / Shell TUI

2016-01-16 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-341:
--

 Summary: Fix coverity issues in Shell / Shell TUI
 Key: CELIX-341
 URL: https://issues.apache.org/jira/browse/CELIX-341
 Project: Celix
  Issue Type: Improvement
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Minor



I use this issue to check some of the coverity issues. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)



[jira] [Commented] (CELIX-332) filter tests absent, small bugs in the source

2016-01-13 Thread Bjoern Petri (JIRA)

[ 
https://issues.apache.org/jira/browse/CELIX-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15095794#comment-15095794
 ] 

Bjoern Petri commented on CELIX-332:


Menno, I applied your patch  - Thanks for the work! Please close this issue if 
okay.

> filter tests absent, small bugs in the source
> -
>
> Key: CELIX-332
> URL: https://issues.apache.org/jira/browse/CELIX-332
> Project: Celix
>  Issue Type: Bug
>  Components: Framework
>Reporter: Menno van der Graaf
> Attachments: filter_crashes_and_test_v2.patch
>
>
> there are no tests for "framework/filter.c".
> after a short look at the source i found some small style errors,
> there is also rumored to be a memory leak in the recursive part of the filter 
> functions, have not found it yet.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-340) Discovery ETCD: fix locking

2016-01-13 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-340:
--

 Summary: Discovery ETCD: fix locking
 Key: CELIX-340
 URL: https://issues.apache.org/jira/browse/CELIX-340
 Project: Celix
  Issue Type: Bug
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Minor


In case the creation of the thread fails, the according unlock is never called.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-334) Race Condition in Topology Manager causes spurious segfaults

2016-01-11 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-334.
--
Resolution: Fixed

> Race Condition in Topology Manager causes spurious segfaults
> 
>
> Key: CELIX-334
> URL: https://issues.apache.org/jira/browse/CELIX-334
> Project: Celix
>  Issue Type: Bug
>Reporter: Bjoern Petri
>Assignee: Bjoern Petri
>
> When adding imported/exported Services, the Topology Manager creates a copy 
> of the rsaList. Although a comment mentioned that this is done to prevent 
> threading issues, this is causing a race condition btwn topology manager and 
> the remote service admin:
> {code}
> =
> ==6392== ERROR: AddressSanitizer: heap-use-after-free on address 
> 0x601c9fe8 at pc 0x2ab837b9c59a bp 0x2ab8370384d0 sp 0x2ab8370384c8
> READ of size 8 at 0x601c9fe8 thread T72
> #0 0x2ab837b9c599 in remoteServiceAdmin_importService 
> /home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/remote_service_admin_shm/private/src/remote_service_admin_impl.c:825:0
> #1 0x2ab8396f5a61 in topologyManager_addImportedService 
> /home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/topology_manager/private/src/topology_manager.c:549:0
> #2 0x2ab837ffead3 in discovery_informEndpointListeners 
> /home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/discovery/private/src/discovery.c:173:0
> #3 0x2ab837fff0d0 in discovery_addDiscoveredEndpoint 
> /home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/discovery/private/src/discovery.c:209:0
> #4 0x2ab838006cf5 in endpointDiscoveryPoller_poll 
> /home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/discovery/private/src/endpoint_discovery_poller.c:271:0
> #5 0x2ab838005fca in endpointDiscoveryPoller_addDiscoveryEndpoint 
> /home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/discovery/private/src/endpoint_discovery_poller.c:193:0
> #6 0x2ab837ff9c69 in discoveryShmWatcher_syncEndpoints 
> /home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/discovery_shm/private/src/discovery_shmWatcher.c:119:0
> #7 0x2ab837ffa554 in discoveryShmWatcher_run 
> /home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/discovery_shm/private/src/discovery_shmWatcher.c:168:0
> #8 0x2ab82af4db97 in __asan_describe_address ??:?
> #9 0x2ab82e42f181 in start_thread 
> /build/buildd/eglibc-2.19/nptl/pthread_create.c:312 (discriminator 2)
> #10 0x2ab82ef5f47c in clone 
> /build/buildd/eglibc-2.19/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:111
> 0x601c9fe8 is located 104 bytes inside of 152-byte region 
> [0x601c9f80,0x601ca018)
> freed by thread T0 here:
> #0 0x2ab82af4a33a in __interceptor_free ??:?
> #1 0x2ab837b9339d in remoteServiceAdmin_destroy 
> /home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/remote_service_admin_shm/private/src/remote_service_admin_impl.c:101:0
> #2 0x2ab837b9dff2 in bundleActivator_stop 
> /home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/remote_service_admin_shm/private/src/remote_service_admin_activator.c:107:0
> #3 0x2ab82df1526c in fw_stopBundle 
> /home/bjoern/Development/celix/git/celix.current.plain/celix/framework/private/src/framework.c:875:0
> #4 0x2ab82def33d4 in bundle_stopWithOptions 
> /home/bjoern/Development/celix/git/celix.current.plain/celix/framework/private/src/bundle.c:325:0
> #5 0x2ab82def3166 in bundle_stop 
> /home/bjoern/Development/celix/git/celix.current.plain/celix/framework/private/src/bundle.c:313:0
> #6 0x41b2b3 in stopStartPermutation 
> /home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/remote_service_admin_shm/private/test/rsa_client_server_tests.cpp:250:0
> #7 0x41e3c6 in testImport 
> /home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/remote_service_admin_shm/private/test/rsa_client_server_tests.cpp:338:0
> #8 0x422e4e in 
> _ZN44TEST_RsaShmClientServerTests_TestImport_Test8testBodyEv 
> /home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/remote_service_admin_shm/private/test/rsa_client_server_tests.cpp:479:0
> #9 0x42fe00 in PlatformSpecificSetJmpImplementation 
> /home/bjoern/Progs/cpputest/cpputest-3.7.1/src/Platforms/Gcc/UtestPlatform.cpp:144:0
> addr2line: '': No such file
> #10 0x60107f9f in
> previously allocated by thread T0 here:
> #0 0x2ab82af4a4e5 in calloc ??:?
> #1 0x2ab837b929db in remoteServiceAdmin_create 
> 

[jira] [Commented] (CELIX-339) celix_log_mock doesnt show logs to the user

2016-01-11 Thread Bjoern Petri (JIRA)

[ 
https://issues.apache.org/jira/browse/CELIX-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15091631#comment-15091631
 ] 

Bjoern Petri commented on CELIX-339:


Nice one - Thank you!  I already applied the patch. Please close this issue if 
okay.

> celix_log_mock doesnt show logs to the user
> ---
>
> Key: CELIX-339
> URL: https://issues.apache.org/jira/browse/CELIX-339
> Project: Celix
>  Issue Type: Improvement
>  Components: Framework
>Reporter: Menno van der Graaf
>Priority: Minor
> Attachments: log_mock_print.patch
>
>
> mocking out the framework logger helps tests to detect when an exception is 
> noted by the code under test. The current implementation only registers the 
> "actual call" with the mock framework though, it does not output anything to 
> the user (tester/developer). This can make debugging of the failing tests 
> somewhat difficult, since the mocking framework never registers WHEN a call 
> to the logger was made.
> attached will be a file that fixes "celix_log_mock.c", so that both the 
> "actual call" is registered, and the error string is written to STDOUT.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CELIX-336) resolver_test doesn't compile

2016-01-11 Thread Bjoern Petri (JIRA)

[ 
https://issues.apache.org/jira/browse/CELIX-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15091624#comment-15091624
 ] 

Bjoern Petri commented on CELIX-336:


I applied your patch. Thanks for the work and close this issue if okay.

> resolver_test doesn't compile
> -
>
> Key: CELIX-336
> URL: https://issues.apache.org/jira/browse/CELIX-336
> Project: Celix
>  Issue Type: Bug
>  Components: Framework
>Reporter: Menno van der Graaf
>Priority: Minor
> Attachments: resolver_test_include.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CELIX-338) Building instructions are outdated

2016-01-11 Thread Bjoern Petri (JIRA)

[ 
https://issues.apache.org/jira/browse/CELIX-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15091632#comment-15091632
 ] 

Bjoern Petri commented on CELIX-338:


Thanks for keeping the documentation up-to-date. I recognized that there are 
some more things which could be updated in this document, but I'll do this 
separate from this issue. Hence, you can close this issue.

> Building instructions are outdated
> --
>
> Key: CELIX-338
> URL: https://issues.apache.org/jira/browse/CELIX-338
> Project: Celix
>  Issue Type: Documentation
>Reporter: Menno van der Graaf
>Priority: Minor
> Attachments: building_instructions.patch
>
>
> The testing part of the BUILDING document is outdated, and still speaks about 
> cUnit and CppUTest forks, atached is a patch that updates this information, 
> please review it, since my wording might not perfect



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-334) Race Condition in Topology Manager causes spurious segfaults

2016-01-07 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-334:
--

 Summary: Race Condition in Topology Manager causes spurious 
segfaults
 Key: CELIX-334
 URL: https://issues.apache.org/jira/browse/CELIX-334
 Project: Celix
  Issue Type: Bug
Reporter: Bjoern Petri
Assignee: Bjoern Petri



When adding imported/exported Services, the Topology Manager creates a copy of 
the rsaList. Although a comment mentioned that this is done to prevent 
threading issues, this is causing a race condition btwn topology manager and 
the remote service admin:

{code}
=
==6392== ERROR: AddressSanitizer: heap-use-after-free on address 0x601c9fe8 
at pc 0x2ab837b9c59a bp 0x2ab8370384d0 sp 0x2ab8370384c8
READ of size 8 at 0x601c9fe8 thread T72
#0 0x2ab837b9c599 in remoteServiceAdmin_importService 
/home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/remote_service_admin_shm/private/src/remote_service_admin_impl.c:825:0
#1 0x2ab8396f5a61 in topologyManager_addImportedService 
/home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/topology_manager/private/src/topology_manager.c:549:0
#2 0x2ab837ffead3 in discovery_informEndpointListeners 
/home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/discovery/private/src/discovery.c:173:0
#3 0x2ab837fff0d0 in discovery_addDiscoveredEndpoint 
/home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/discovery/private/src/discovery.c:209:0
#4 0x2ab838006cf5 in endpointDiscoveryPoller_poll 
/home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/discovery/private/src/endpoint_discovery_poller.c:271:0
#5 0x2ab838005fca in endpointDiscoveryPoller_addDiscoveryEndpoint 
/home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/discovery/private/src/endpoint_discovery_poller.c:193:0
#6 0x2ab837ff9c69 in discoveryShmWatcher_syncEndpoints 
/home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/discovery_shm/private/src/discovery_shmWatcher.c:119:0
#7 0x2ab837ffa554 in discoveryShmWatcher_run 
/home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/discovery_shm/private/src/discovery_shmWatcher.c:168:0
#8 0x2ab82af4db97 in __asan_describe_address ??:?
#9 0x2ab82e42f181 in start_thread 
/build/buildd/eglibc-2.19/nptl/pthread_create.c:312 (discriminator 2)
#10 0x2ab82ef5f47c in clone 
/build/buildd/eglibc-2.19/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:111
0x601c9fe8 is located 104 bytes inside of 152-byte region 
[0x601c9f80,0x601ca018)
freed by thread T0 here:
#0 0x2ab82af4a33a in __interceptor_free ??:?
#1 0x2ab837b9339d in remoteServiceAdmin_destroy 
/home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/remote_service_admin_shm/private/src/remote_service_admin_impl.c:101:0
#2 0x2ab837b9dff2 in bundleActivator_stop 
/home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/remote_service_admin_shm/private/src/remote_service_admin_activator.c:107:0
#3 0x2ab82df1526c in fw_stopBundle 
/home/bjoern/Development/celix/git/celix.current.plain/celix/framework/private/src/framework.c:875:0
#4 0x2ab82def33d4 in bundle_stopWithOptions 
/home/bjoern/Development/celix/git/celix.current.plain/celix/framework/private/src/bundle.c:325:0
#5 0x2ab82def3166 in bundle_stop 
/home/bjoern/Development/celix/git/celix.current.plain/celix/framework/private/src/bundle.c:313:0
#6 0x41b2b3 in stopStartPermutation 
/home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/remote_service_admin_shm/private/test/rsa_client_server_tests.cpp:250:0
#7 0x41e3c6 in testImport 
/home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/remote_service_admin_shm/private/test/rsa_client_server_tests.cpp:338:0
#8 0x422e4e in _ZN44TEST_RsaShmClientServerTests_TestImport_Test8testBodyEv 
/home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/remote_service_admin_shm/private/test/rsa_client_server_tests.cpp:479:0
#9 0x42fe00 in PlatformSpecificSetJmpImplementation 
/home/bjoern/Progs/cpputest/cpputest-3.7.1/src/Platforms/Gcc/UtestPlatform.cpp:144:0
addr2line: '': No such file
#10 0x60107f9f in
previously allocated by thread T0 here:
#0 0x2ab82af4a4e5 in calloc ??:?
#1 0x2ab837b929db in remoteServiceAdmin_create 
/home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/remote_service_admin_shm/private/src/remote_service_admin_impl.c:70
#2 0x2ab837b9d9f2 in bundleActivator_start 
/home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/remote_service_admin_shm/private/src/remote_service_admin_activator.c:63
#3 0x2ab82df1317f in fw_startBundle 

[jira] [Closed] (CELIX-300) Invalid read in serviceRegistry during framework_shutdown

2016-01-06 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-300.
--
Resolution: Fixed
  Assignee: Bjoern Petri

> Invalid read in serviceRegistry during framework_shutdown
> -
>
> Key: CELIX-300
> URL: https://issues.apache.org/jira/browse/CELIX-300
> Project: Celix
>  Issue Type: Bug
>Reporter: Gabriele Ricciardi
>Assignee: Bjoern Petri
> Attachments: sr_invalidread.patch
>
>
> During the framework_shutdown phase, there is the possibility a service 
> reference is destroyed and then reaccessed: this generates an invalid read.
> Attached a patch that fixes the invalid read.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-296) Framework unit tests improvement

2016-01-06 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-296.
--
Resolution: Fixed
  Assignee: Bjoern Petri

> Framework unit tests improvement
> 
>
> Key: CELIX-296
> URL: https://issues.apache.org/jira/browse/CELIX-296
> Project: Celix
>  Issue Type: Improvement
>Reporter: Gabriele Ricciardi
>Assignee: Bjoern Petri
> Attachments: fw_test.patch
>
>
> Attached a patch that extends some framework unit tests



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-298) Memory leaks in rsa_dfi

2016-01-06 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-298.
--
Resolution: Fixed
  Assignee: Bjoern Petri

> Memory leaks in rsa_dfi
> ---
>
> Key: CELIX-298
> URL: https://issues.apache.org/jira/browse/CELIX-298
> Project: Celix
>  Issue Type: Bug
>Reporter: Gabriele Ricciardi
>Assignee: Bjoern Petri
> Attachments: rsa_dfi_leaks.patch
>
>
> After Valgrind analysis of the rsa_dfi unit tests, many leaks were found.
> Attached patch that fixex the leaks.
> The patch also excludes couple of hanging framework tests (they will be 
> restored when fixed)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-305) Memory leaks in RSA_SHM, RSA_DFI, RSA_HTTP

2016-01-06 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-305.
--
Resolution: Fixed
  Assignee: Bjoern Petri

> Memory leaks in RSA_SHM, RSA_DFI, RSA_HTTP
> --
>
> Key: CELIX-305
> URL: https://issues.apache.org/jira/browse/CELIX-305
> Project: Celix
>  Issue Type: Bug
>Reporter: Gabriele Ricciardi
>Assignee: Bjoern Petri
> Attachments: rsa_shm_dfi_http_leaks.patch
>
>
> During RemoteServices Unit tests run under Valgrind, several memory leaks 
> were found.
> Attached patch that fixes those leaks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-319) Missing Jansson depencency in TopologyManager CMakeLists

2016-01-06 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-319.
--
Resolution: Fixed
  Assignee: Bjoern Petri

> Missing Jansson depencency in TopologyManager CMakeLists
> 
>
> Key: CELIX-319
> URL: https://issues.apache.org/jira/browse/CELIX-319
> Project: Celix
>  Issue Type: Bug
>Reporter: Gabriele Ricciardi
>Assignee: Bjoern Petri
> Attachments: tm_cmakelist.patch
>
>
> Topology Manager now uses Jansson library, but dependency is not declared in 
> CMakeLists.txt . This can break the build in case Jansson path is set via 
> command line cmake.
> Attached small patch that add such a dependency



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-318) DFI Unit tests for negative cases

2016-01-06 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-318.
--
Resolution: Fixed
  Assignee: Bjoern Petri

> DFI Unit tests for negative cases
> -
>
> Key: CELIX-318
> URL: https://issues.apache.org/jira/browse/CELIX-318
> Project: Celix
>  Issue Type: Test
>Reporter: Gabriele Ricciardi
>Assignee: Bjoern Petri
> Attachments: dfi_negative_tests.patch
>
>
> DFI library misses unit tests for negative cases (e.g. invalid descriptors, 
> invalid formats...). 
> Thanks to those negative cases, an invalid read was found in 
> dynCommon_eatChar error logging
> Attached patch that fixes the invalid read and extends unit tests suite 
> (after this, code coverage for DFI is above 90%).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CELIX-303) Memory leaks in Topology Manager and RSA_SHM

2016-01-06 Thread Bjoern Petri (JIRA)

[ 
https://issues.apache.org/jira/browse/CELIX-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085259#comment-15085259
 ] 

Bjoern Petri commented on CELIX-303:


This patch has been applied, please close if okay. Thanks for your work.

> Memory leaks in Topology Manager and RSA_SHM
> 
>
> Key: CELIX-303
> URL: https://issues.apache.org/jira/browse/CELIX-303
> Project: Celix
>  Issue Type: Bug
>Reporter: Gabriele Ricciardi
> Attachments: tm_rsashm_leaks.patch
>
>
> During unit test run, many leaks were found for Topology Manager and RSA_SHM.
> Attached a patch that fix them



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-180) framework_tests do not compile

2016-01-06 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-180.
--
Resolution: Fixed

The framework tests have been adapted by Menno to compile again. 

> framework_tests do not compile 
> ---
>
> Key: CELIX-180
> URL: https://issues.apache.org/jira/browse/CELIX-180
> Project: Celix
>  Issue Type: Bug
>Reporter: Bjoern Petri
>Assignee: Bjoern Petri
>
> Well .. not much to add here. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-302) Service Tracker Test error breaks the build

2016-01-06 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-302.
--
Resolution: Fixed
  Assignee: Bjoern Petri

The test seems to work by now, so I close this issue

> Service Tracker Test error breaks the build
> ---
>
> Key: CELIX-302
> URL: https://issues.apache.org/jira/browse/CELIX-302
> Project: Celix
>  Issue Type: Bug
>Reporter: Gabriele Ricciardi
>Assignee: Bjoern Petri
> Attachments: st_test.patch
>
>
> A field name in the service_tracker struct was updated but not in the related 
> test. This broke the whole build.
> Attached a patch that fix the build (but the test itself is not run because 
> it hangs due to some failure)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CELIX-312) ServiceReference usage counter inconsistent state

2016-01-06 Thread Bjoern Petri (JIRA)

[ 
https://issues.apache.org/jira/browse/CELIX-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085230#comment-15085230
 ] 

Bjoern Petri commented on CELIX-312:


Took a bit longer, but I applied your patch - thanks for your work! Please 
close if okay.

> ServiceReference usage counter inconsistent state
> -
>
> Key: CELIX-312
> URL: https://issues.apache.org/jira/browse/CELIX-312
> Project: Celix
>  Issue Type: Bug
>  Components: Dependency Manager, Framework, Shell Textual User 
> Interface
>Reporter: Gabriele Ricciardi
> Attachments: sr_count.patch
>
>
> While running the dm_example, the output reported inconsistent usage counter 
> state for service references during the shutdown phase.
> That was caused by
> - Missing ungetService* calls in the shell_tui stop
> - Wrong check in the service_registry (log output was not consistent)
> - Missing ungetService in dm_service_dependency
> Attached patch that fixes the issue



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CELIX-328) Service version support for RSA DFI

2016-01-05 Thread Bjoern Petri (JIRA)

[ 
https://issues.apache.org/jira/browse/CELIX-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083225#comment-15083225
 ] 

Bjoern Petri commented on CELIX-328:


Thanks for your work, Gabriele. I applied the patch - please close if okay.

> Service version support for RSA DFI
> ---
>
> Key: CELIX-328
> URL: https://issues.apache.org/jira/browse/CELIX-328
> Project: Celix
>  Issue Type: Improvement
>Reporter: Gabriele Ricciardi
> Attachments: dfi_version_support.patch
>
>
> RSA DFI is missing support for version checking (i.e. if the service versions 
> present in client and server side's descriptor are compatible following the 
> semantic versioning rules)
> Attached a patch that:
> - Implements the version support in RSA DFI
> - Fix a double free in importRegistration_destroy
> - Add a isCompatible function to version.c for checking if two versions are 
> semantically compatible (the unit tests are updated as well)
> - Fix the CMake files adding the DFI_LIBRARY_PATH
> - Fix and improve the calculator example
> - Add a deploy target for RSA DFI based on calculator example and 
> discovery_etcd



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-333) integrate coverity scans

2016-01-05 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-333:
--

 Summary: integrate coverity scans
 Key: CELIX-333
 URL: https://issues.apache.org/jira/browse/CELIX-333
 Project: Celix
  Issue Type: Improvement
Reporter: Bjoern Petri
Assignee: Bjoern Petri


Add support for automated coverity scans (see 
https://scan.coverity.com/projects/apache-celix?tab=overview)




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CELIX-329) framework "service_" tests are outdates, some small bugs in the sources

2015-12-20 Thread Bjoern Petri (JIRA)

[ 
https://issues.apache.org/jira/browse/CELIX-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15065856#comment-15065856
 ] 

Bjoern Petri commented on CELIX-329:


Menno, you're right. After updating to cpputest 3.7, the error does not occur 
anymore. I applied your patch - please close this issue. Thanks!

> framework "service_" tests are outdates, some small bugs in the sources
> ---
>
> Key: CELIX-329
> URL: https://issues.apache.org/jira/browse/CELIX-329
> Project: Celix
>  Issue Type: Bug
>  Components: Framework
>Reporter: Menno van der Graaf
> Attachments: service_refactor_tests.patch
>
>
> The tests for the "service_reference", "service_registry", and 
> "service_tracker" are out of date (after the refactoring of the registry)
> there are also some small bugs in the "service_registry"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-331) test configuraiton needs update for newer CMake

2015-12-18 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-331:
--

 Summary: test configuraiton needs update for newer CMake
 Key: CELIX-331
 URL: https://issues.apache.org/jira/browse/CELIX-331
 Project: Celix
  Issue Type: Bug
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Minor


CMake version 3.1 introduces a new policy CMP0053 that simplifies variable 
reference and escape sequence evaluation 
(https://cmake.org/cmake/help/v3.1/policy/CMP0053.html) 

This breaks the evaluation of the @VAR@ syntax used within the test property 
files and leads to a failing test. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CELIX-329) framework "service_" tests are outdates, some small bugs in the sources

2015-12-17 Thread Bjoern Petri (JIRA)

[ 
https://issues.apache.org/jira/browse/CELIX-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063620#comment-15063620
 ] 

Bjoern Petri commented on CELIX-329:


Menno, after applying your patch  the service_registry_test fails for me. Could 
you do me the favor and check this: 

{code}
/home/bjoern/Development/celix/framework/private/test/service_registry_test.cpp:454:
 error: Failure in TEST(service_registry, getServiceReference_unknownRef)
expected <0x50>
but was  <0x0>
{code}

Thanks, 
Bjoern

> framework "service_" tests are outdates, some small bugs in the sources
> ---
>
> Key: CELIX-329
> URL: https://issues.apache.org/jira/browse/CELIX-329
> Project: Celix
>  Issue Type: Bug
>  Components: Framework
>Reporter: Menno van der Graaf
> Attachments: service_refactor_tests.patch
>
>
> The tests for the "service_reference", "service_registry", and 
> "service_tracker" are out of date (after the refactoring of the registry)
> there are also some small bugs in the "service_registry"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-327) Filter does not support greater than and lesser than operators

2015-12-15 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-327:
--

 Summary: Filter does not support greater than and lesser than 
operators
 Key: CELIX-327
 URL: https://issues.apache.org/jira/browse/CELIX-327
 Project: Celix
  Issue Type: Improvement
Reporter: Bjoern Petri
Priority: Minor



Our current filter implementation does neither support '<' nor '>' as 
operators. It only supports '>=' and '<='



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CELIX-325) Bundle test sporadicly fails

2015-12-14 Thread Bjoern Petri (JIRA)

[ 
https://issues.apache.org/jira/browse/CELIX-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15057401#comment-15057401
 ] 

Bjoern Petri commented on CELIX-325:


Menno - up to now - it looks good: I committed your patch and up to now the 
bundle_test didn't fail any more.

> Bundle test sporadicly fails
> 
>
> Key: CELIX-325
> URL: https://issues.apache.org/jira/browse/CELIX-325
> Project: Celix
>  Issue Type: Bug
>  Components: Framework
>Reporter: Menno van der Graaf
>Priority: Minor
> Attachments: bundle_test_random_failure.patch
>
>
> The bundle test seems to randomly fail on travis builds, cannot reproduce it 
> localy.
> travis test output is:
> Test command: 
> /home/travis/build/apache/celix/build/framework/bundle_test
> Test timeout computed to be: 9.99988e+06
> ... 
> /home/travis/build/apache/celix/framework/private/test/bundle_test.cpp:633: 
> error: Failure in TEST(bundle, revise)
> Mock Failure: Unexpected call to function: module_getVersion
> EXPECTED calls that did NOT happen:
> bundleArchive_revise -> void* archive: <0x2>, const char* location: 
> , const char* inputFile: 
> bundleArchive_getCurrentRevision -> void* archive: <0x2>const void* revision: 
> 
> bundleRevision_getManifest -> void* revision: <0xf1ec50>const void* manifest: 
> 
> bundleArchive_getId -> void* archive: <0x2>const void* id: 
> resolver_addModule -> void* module: <0x0>
> ACTUAL calls that did happen (in call order):
> bundleArchive_revise -> void* archive: <0x2>, const char* location: 
> , const char* inputFile: 
> bundleArchive_getCurrentRevision -> void* archive: <0x2>const void* revision: 
> 
> bundleRevision_getManifest -> void* revision: <0xf1ec50>const void* manifest: 
> 
> bundleArchive_getId -> void* archive: <0x2>const void* id: 
> module_create -> void* headerMap: <0xf222d0>, const char* moduleId: <666.0>, 
> void* bundle: <0xf21d20>
> .
> Errors (1 failures, 32 tests, 32 ran, 244 checks, 0 ignored, 0 filtered out, 
> 2 
> 9/32 Test  #9: bundle_test ...***Failed0.01 sec



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-326) Add service version support to dependency manager

2015-12-14 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-326:
--

 Summary: Add service version support to dependency manager
 Key: CELIX-326
 URL: https://issues.apache.org/jira/browse/CELIX-326
 Project: Celix
  Issue Type: Improvement
Reporter: Bjoern Petri
Assignee: Bjoern Petri


Add service version support to Apache Celix using the dependency manager using 
symantic versioning.

* The support versions layout should be 
[.][.][.]
* A version should be provided with the component_addService method.
* If no version is supplied a warning should be logged

 * The version range format should be , [,) and 
[version]
* A version range should be provided with the serviceDependency_setService.
* If the version range is not supplied a warning should be logged.

* The dependency manager should add a property "version" when registering 
services.
* The dependency manager should add a filter for the version range when 
tracking service dependencies.

* Update services with a macro _VERSION and _RANGE



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CELIX-318) DFI Unit tests for negative cases

2015-12-14 Thread Bjoern Petri (JIRA)

[ 
https://issues.apache.org/jira/browse/CELIX-318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15056039#comment-15056039
 ] 

Bjoern Petri commented on CELIX-318:


Applied! Thanks a lot for your work!

> DFI Unit tests for negative cases
> -
>
> Key: CELIX-318
> URL: https://issues.apache.org/jira/browse/CELIX-318
> Project: Celix
>  Issue Type: Test
>Reporter: Gabriele Ricciardi
> Attachments: dfi_negative_tests.patch
>
>
> DFI library misses unit tests for negative cases (e.g. invalid descriptors, 
> invalid formats...). 
> Thanks to those negative cases, an invalid read was found in 
> dynCommon_eatChar error logging
> Attached patch that fixes the invalid read and extends unit tests suite 
> (after this, code coverage for DFI is above 90%).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CELIX-324) Version support in dfi library

2015-12-14 Thread Bjoern Petri (JIRA)

[ 
https://issues.apache.org/jira/browse/CELIX-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15056333#comment-15056333
 ] 

Bjoern Petri commented on CELIX-324:


Gabriele, applied your patch but I think you've missed the mentioned version.c 
changes within this patch. I've now fixed it on my own. Could you shortly 
verify the commit with your local code and close if okay?! Thanks

> Version support in dfi library
> --
>
> Key: CELIX-324
> URL: https://issues.apache.org/jira/browse/CELIX-324
> Project: Celix
>  Issue Type: Bug
>Reporter: Gabriele Ricciardi
> Attachments: dfi_version_support.patch
>
>
> dyn_message and dyn_interface miss version support.
> Attached patch implementing the new field for both structures (and also 
> extends the existing unit tests)
> The patch fixes also an invalid write in version_createFromString function 
> (the strtok_r in the function creates side effect on the input string)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CELIX-322) Memory leaks in resolver and framework tests

2015-12-10 Thread Bjoern Petri (JIRA)

[ 
https://issues.apache.org/jira/browse/CELIX-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15051083#comment-15051083
 ] 

Bjoern Petri commented on CELIX-322:


I applied your patch, thanks for the work. Please close if okay.

> Memory leaks in resolver and framework tests
> 
>
> Key: CELIX-322
> URL: https://issues.apache.org/jira/browse/CELIX-322
> Project: Celix
>  Issue Type: Bug
>  Components: Framework
>Reporter: Menno van der Graaf
>Priority: Minor
> Attachments: memoryleaks_resolver_context_cache.patch
>
>
> There are some merory leaks in:
> resolver, resolver test, bundle_cache test, bundle_context test



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CELIX-320) outdated utils tests (threads, hashmap)

2015-12-10 Thread Bjoern Petri (JIRA)

[ 
https://issues.apache.org/jira/browse/CELIX-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15051076#comment-15051076
 ] 

Bjoern Petri commented on CELIX-320:


I applied your patch, thanks for the work. I also enabled the tests within the 
travis cfg. Please close if okay.

> outdated utils tests (threads, hashmap)
> ---
>
> Key: CELIX-320
> URL: https://issues.apache.org/jira/browse/CELIX-320
> Project: Celix
>  Issue Type: Improvement
>  Components: Utils
>Reporter: Menno van der Graaf
>Priority: Minor
> Attachments: utils_tests_threads_hashmap_cmakelist_fixed.patch
>
>
> the celix_threads tests are outdated/missing: no tests for the r/w-lock, no 
> test for the thread_kill
> there is a compile warning in the hashmap tests: comparing the pointer of a 
> function pointer, instead of the function pointer itself
> the utils CMakeList is incorrect: some old statements still commented, the 
> new celix_threads tests require an extra library linked, the option 
> "UTILS-TESTS" is declared but not used



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-315) data race in rsa export tests leads to spurious fails

2015-12-02 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-315:
--

 Summary: data race in rsa export tests leads to spurious fails
 Key: CELIX-315
 URL: https://issues.apache.org/jira/browse/CELIX-315
 Project: Celix
  Issue Type: Bug
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Minor


when running the rsa export tests, there is no chance for the client side to 
drop the imported endpoints between two tests:

- Server runs stop/start cycle 1, exporting endpoint/services A
- Client imports endpoints and according services A, runs test 
- Server runs stop/start cycle 2, exporting endpoint/services B
- Client runs test but still picks up A, although it should wait for the import 
of b, because there was no time yet to remove them. With the next discovery 
poll of the client the endpoint is removed and the belonging service 
invalidated -> the test fails. 






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CELIX-310) "serviceRegistry_getRegisteredServices" deadlocks

2015-12-01 Thread Bjoern Petri (JIRA)

[ 
https://issues.apache.org/jira/browse/CELIX-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15034435#comment-15034435
 ] 

Bjoern Petri commented on CELIX-310:


I applied the patch. Please close this issue, if it's fine.

> "serviceRegistry_getRegisteredServices" deadlocks
> -
>
> Key: CELIX-310
> URL: https://issues.apache.org/jira/browse/CELIX-310
> Project: Celix
>  Issue Type: Bug
>Reporter: Menno van der Graaf
> Attachments: registry_deadlock.patch
>
>
> Tests of the "service_registry" deadlocked, the issue is in the 
> "getRegisteredServices" function, locking the rw_lock before calling 
> "getServiceReference" which also tries to lock.
> Added a patch that fixes this problem



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CELIX-305) Memory leaks in RSA_SHM, RSA_DFI, RSA_HTTP

2015-11-25 Thread Bjoern Petri (JIRA)

[ 
https://issues.apache.org/jira/browse/CELIX-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026537#comment-15026537
 ] 

Bjoern Petri commented on CELIX-305:


Gabriele, I applied your patch but it seems that there are some issues: while 
all travis builds failed, I could not reproduce this on my machine. But testing 
this on an ubuntu trusty 64 machine indeed leads to spurious segfaults - 
unfortunately only in case I do not use gdb or valgrind. 

Nevertheless, I have the impression that your patch fixes some leaks, so I will 
leave it applied for now and continue investigation what causes this strange 
behavior.

> Memory leaks in RSA_SHM, RSA_DFI, RSA_HTTP
> --
>
> Key: CELIX-305
> URL: https://issues.apache.org/jira/browse/CELIX-305
> Project: Celix
>  Issue Type: Bug
>Reporter: Gabriele Ricciardi
> Attachments: rsa_shm_dfi_http_leaks.patch
>
>
> During RemoteServices Unit tests run under Valgrind, several memory leaks 
> were found.
> Attached patch that fixes those leaks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CELIX-304) Memory leaks in manifest parser, requirement, capability; out-of-date tests

2015-11-24 Thread Bjoern Petri (JIRA)

[ 
https://issues.apache.org/jira/browse/CELIX-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025002#comment-15025002
 ] 

Bjoern Petri commented on CELIX-304:


I applied the patch - thanks for your work! Please close this issue if it is ok.

> Memory leaks in manifest parser, requirement, capability; out-of-date tests
> ---
>
> Key: CELIX-304
> URL: https://issues.apache.org/jira/browse/CELIX-304
> Project: Celix
>  Issue Type: Bug
>  Components: Framework
>Reporter: Menno van der Graaf
>Priority: Minor
> Attachments: manifest_req_cap_utils.patch
>
>
> Some memory leaks found in the manifest parser, requirement and capability
> Tests for the manifest, manifestparser, requirement, capability, properties 
> and utils are out of date



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CELIX-302) Service Tracker Test error breaks the build

2015-11-23 Thread Bjoern Petri (JIRA)

[ 
https://issues.apache.org/jira/browse/CELIX-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15023804#comment-15023804
 ] 

Bjoern Petri commented on CELIX-302:


Gabriele, thanks for the patch - I applied  it but will  leave this issue open 
until the test itself is fixed.

> Service Tracker Test error breaks the build
> ---
>
> Key: CELIX-302
> URL: https://issues.apache.org/jira/browse/CELIX-302
> Project: Celix
>  Issue Type: Bug
>Reporter: Gabriele Ricciardi
> Attachments: st_test.patch
>
>
> A field name in the service_tracker struct was updated but not in the related 
> test. This broke the whole build.
> Attached a patch that fix the build (but the test itself is not run because 
> it hangs due to some failure)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CELIX-298) Memory leaks in rsa_dfi

2015-11-19 Thread Bjoern Petri (JIRA)

[ 
https://issues.apache.org/jira/browse/CELIX-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013276#comment-15013276
 ] 

Bjoern Petri commented on CELIX-298:


Applied the patch. Please close if it is ok. Thanks for the work!

> Memory leaks in rsa_dfi
> ---
>
> Key: CELIX-298
> URL: https://issues.apache.org/jira/browse/CELIX-298
> Project: Celix
>  Issue Type: Bug
>Reporter: Gabriele Ricciardi
> Attachments: rsa_dfi_leaks.patch
>
>
> After Valgrind analysis of the rsa_dfi unit tests, many leaks were found.
> Attached patch that fixex the leaks.
> The patch also excludes couple of hanging framework tests (they will be 
> restored when fixed)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CELIX-294) changed dfi library from static to shared

2015-11-16 Thread Bjoern Petri (JIRA)

[ 
https://issues.apache.org/jira/browse/CELIX-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006339#comment-15006339
 ] 

Bjoern Petri commented on CELIX-294:


Applied the patch. Please close if it is ok. Thanks for the work!

> changed dfi library from static to shared
> -
>
> Key: CELIX-294
> URL: https://issues.apache.org/jira/browse/CELIX-294
> Project: Celix
>  Issue Type: Bug
>  Components: Remote Service Admin
>Reporter: Menno van der Graaf
>Priority: Minor
> Attachments: dfi_cmaklist.patch
>
>
> the dfi library is static



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-293) Refactoring Discovery SHM / RSA SHM

2015-11-13 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-293:
--

 Summary: Refactoring Discovery SHM / RSA SHM 
 Key: CELIX-293
 URL: https://issues.apache.org/jira/browse/CELIX-293
 Project: Celix
  Issue Type: Improvement
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Minor


Both, discovery SHM / RSA SHM are still using fw_lock and pthread instead of 
the logHelper and the celixThread. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CELIX-290) Mock fixes, CMakelist fix, build warning fix

2015-11-11 Thread Bjoern Petri (JIRA)

[ 
https://issues.apache.org/jira/browse/CELIX-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001776#comment-15001776
 ] 

Bjoern Petri commented on CELIX-290:


Applied the patch. Please close if it is ok. Thanks for the work!


> Mock fixes, CMakelist fix, build warning fix
> 
>
> Key: CELIX-290
> URL: https://issues.apache.org/jira/browse/CELIX-290
> Project: Celix
>  Issue Type: Bug
>  Components: Framework
>Reporter: Menno van der Graaf
>  Labels: newbie, patch, test
> Attachments: fw_test.patch
>
>
> Bugs:
> -unit tests failing, exhibiting undefined behavior. the framework mocks are 
> incorrectly implemented, and as a result, the reliant tests fail.
> -Cmake warning in framework "framework/Cmakelist.txt"
> -sub-par coverage of framework "resolver.c"
> -build warnings in the framework unit tests.
> Please find attached the patch that implements the following:
> Changes/fixes:
> -fixed cmake warning in framework/CMakelist.txt (removed brackets from 
> [COPYONLY] at line 351/353)
> -fixed build warning in framework bundle_cache_test.cpp (mktemp depricated, 
> used mkstemp instead)
> -fixed a dev note accidentaly left in framework service_registry_test.cpp 
> (used preprocessor symbol as dev note, will not do again)
> -fixed a lot of the framework mocks, used to not assign any of the output 
> parameters, resulting in undefined behaviour
> -updated most framework tests to accommodate for the mock changes
> -expanded framework resolver test (WIP)
> now how does this patch stuff work..



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-291) setenv/getenv for framework uuid does not work w/ multiple fw test environment

2015-11-11 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-291:
--

 Summary: setenv/getenv for framework uuid does not work w/ 
multiple fw test environment
 Key: CELIX-291
 URL: https://issues.apache.org/jira/browse/CELIX-291
 Project: Celix
  Issue Type: Bug
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Minor


By using the refactored launcher we can now start several frameworks from 
within one cpputest. This does collide with the usage of getenv/setenv for 
saving the framework uuid: after the first framework has set the uuid, every 
other starting framework will subsequently overwrite the uuid. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-285) Discovery SHM: remove obsolete jansson dependency

2015-11-04 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-285:
--

 Summary: Discovery SHM: remove obsolete jansson dependency
 Key: CELIX-285
 URL: https://issues.apache.org/jira/browse/CELIX-285
 Project: Celix
  Issue Type: Improvement
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Minor






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-279) Celix fails to compile w/ CMake 3.3

2015-10-29 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-279.
--
Resolution: Fixed

> Celix fails to compile w/ CMake 3.3
> ---
>
> Key: CELIX-279
> URL: https://issues.apache.org/jira/browse/CELIX-279
> Project: Celix
>  Issue Type: Bug
>Reporter: Bjoern Petri
>Assignee: Bjoern Petri
>
> Celix fails to compile with the current Cmake Version 3.3. 
> While the cmake step still works fine, the cpack step fails when executing 
> the pre-install target. The Logfile contains an error message stating that 
> the Cache couldn't be found/loaded.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CELIX-279) Celix fails to compile w/ CMake 3.3

2015-10-24 Thread Bjoern Petri (JIRA)

[ 
https://issues.apache.org/jira/browse/CELIX-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14972448#comment-14972448
 ] 

Bjoern Petri commented on CELIX-279:


It seems that the behavior is caused by the following bug:
https://public.kitware.com/Bug/view.php?id=15696.

Building Celix w/ CMake 3.2 and CMake 3.4 RC2 works without a problem.  I added 
a check add the beginning of our CMake Configuration:  in case CMake 3.3. is 
used an message is printed asking the user to switch the CMake Version and the 
build is aborted. 

> Celix fails to compile w/ CMake 3.3
> ---
>
> Key: CELIX-279
> URL: https://issues.apache.org/jira/browse/CELIX-279
> Project: Celix
>  Issue Type: Bug
>Reporter: Bjoern Petri
>Assignee: Bjoern Petri
>
> Celix fails to compile with the current Cmake Version 3.3. 
> While the cmake step still works fine, the cpack step fails when executing 
> the pre-install target. The Logfile contains an error message stating that 
> the Cache couldn't be found/loaded.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-280) deployment_admin misses proper shutdown functionality

2015-10-23 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-280:
--

 Summary: deployment_admin misses proper shutdown functionality
 Key: CELIX-280
 URL: https://issues.apache.org/jira/browse/CELIX-280
 Project: Celix
  Issue Type: Bug
Reporter: Bjoern Petri
Assignee: Bjoern Petri


The deployment_admin uses a polling thread to check for changes in the 
provisioning configuration. This thread runs as long as the boolean variable 
running is set to true. 

It seems that neither this variable is ever set to false nor is the thread ever 
exited properly.





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (CELIX-279) Celix fails to compile w/ CMake 3.3

2015-10-23 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri updated CELIX-279:
---
Summary: Celix fails to compile w/ CMake 3.3  (was: Celix failed to compile 
w/ CMake 3.3)

> Celix fails to compile w/ CMake 3.3
> ---
>
> Key: CELIX-279
> URL: https://issues.apache.org/jira/browse/CELIX-279
> Project: Celix
>  Issue Type: Bug
>Reporter: Bjoern Petri
>Assignee: Bjoern Petri
>
> Celix fails to compile with the current Cmake Version 3.3. 
> While the cmake step still works fine, the cpack step fails when executing 
> the pre-install target. The Logfile contains an error message stating that 
> the Cache couldn't be found/loaded.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-277) Discovery SHM / RSA SHM do not compile using OSX

2015-10-17 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-277:
--

 Summary: Discovery SHM / RSA SHM do not compile using OSX
 Key: CELIX-277
 URL: https://issues.apache.org/jira/browse/CELIX-277
 Project: Celix
  Issue Type: Bug
Reporter: Bjoern Petri
Assignee: Bjoern Petri


Neither the Discovery SHM nor the RSA SHM compile under macos. 

Discovery SHM uses robust futexes which are not supported, while RSA SHM 
stumbles over an enum redefinition.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-259) dispatcherThread does not perform a graceful shutdown

2015-10-16 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-259.
--
Resolution: Fixed

> dispatcherThread does not perform a graceful shutdown
> -
>
> Key: CELIX-259
> URL: https://issues.apache.org/jira/browse/CELIX-259
> Project: Celix
>  Issue Type: Improvement
>  Components: Framework
>Reporter: Bjoern Petri
>Assignee: Bjoern Petri
>Priority: Minor
>
> The framework performs a pthread_cancel of the dispatcherThread during 
> shutdown. This could be replaced by a proper shutdown function.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-260) missing include in deployment admin

2015-10-16 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-260.
--
Resolution: Fixed

> missing include in deployment admin
> ---
>
> Key: CELIX-260
> URL: https://issues.apache.org/jira/browse/CELIX-260
> Project: Celix
>  Issue Type: Bug
>Reporter: Bjoern Petri
>Priority: Minor
>
> The Cmakefile of the deployment_admin misses the include of uuid.h



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-275) Can't do mkstemp on root system (deploymentAdmin_download)

2015-10-15 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-275.
--
Resolution: Fixed
  Assignee: Bjoern Petri

I applied you patch to the develop branch. Thanks for the contribution! 

> Can't do mkstemp on root system (deploymentAdmin_download)
> --
>
> Key: CELIX-275
> URL: https://issues.apache.org/jira/browse/CELIX-275
> Project: Celix
>  Issue Type: Improvement
>  Components: Deployment Admin
> Environment: Android
>Reporter: Marco Jansen
>Assignee: Bjoern Petri
>Priority: Minor
> Attachments: deployment_admin.patch
>
>
> mkstemp can only be done on a few locations within Android. The corresponding 
> patch is below. (based on develop branch of the celix github)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-276) TopologyManager: missing importRegistration_close during RSA Removal

2015-10-15 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-276:
--

 Summary: TopologyManager: missing importRegistration_close during 
RSA Removal
 Key: CELIX-276
 URL: https://issues.apache.org/jira/browse/CELIX-276
 Project: Celix
  Issue Type: Bug
Reporter: Bjoern Petri
Assignee: Bjoern Petri


The TopologyManager does not handle imported Services when the RSA is removed 
(topologyManager_rsaRemoved).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-270) Fix Code Coverage

2015-10-12 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-270.
--
Resolution: Fixed

> Fix Code Coverage
> -
>
> Key: CELIX-270
> URL: https://issues.apache.org/jira/browse/CELIX-270
> Project: Celix
>  Issue Type: Bug
>Reporter: Bjoern Petri
>Assignee: Bjoern Petri
>Priority: Minor
>
> The make target to create the code coverage report does not work any more.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-272) framework: add locking

2015-10-11 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-272:
--

 Summary: framework: add locking
 Key: CELIX-272
 URL: https://issues.apache.org/jira/browse/CELIX-272
 Project: Celix
  Issue Type: Bug
Reporter: Bjoern Petri
Assignee: Bjoern Petri


There is some locking missing within the framework. Especially when interacting 
with the shell (e.g. retrieve installed bundles), or when using remote services 
(e.g. dynamically installing of endpoints).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-271) setup coveralls.io

2015-10-10 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-271:
--

 Summary: setup coveralls.io
 Key: CELIX-271
 URL: https://issues.apache.org/jira/browse/CELIX-271
 Project: Celix
  Issue Type: Bug
Reporter: Bjoern Petri
Assignee: Bjoern Petri


Coveralls.io is a web service, which can help us to track our code coverage 
over time.

See https://coveralls.io/github/apache/celix



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-267) RSA segfaults when endpoint is not available

2015-10-07 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-267:
--

 Summary: RSA segfaults when endpoint is not available
 Key: CELIX-267
 URL: https://issues.apache.org/jira/browse/CELIX-267
 Project: Celix
  Issue Type: Bug
  Components: Remote Service Admin
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Critical



Although the endpoint is not available, an exportRegistration is created and 
maintained in a RSA list. Once the endpoint becomes available, a reference to 
this endpoint is set within the exportRegistration. 

Nevertheless, the service is announced within discovery.  Independent whether 
an endpoint is availabe or not. When another RSA tries to use this service it 
is not checked whether the endpoint is available or not resulting in a segfault 
when not available.

This has particular impact when using celix together with Apache Ace: In this 
case we also deploy the endpoint - so it is not available rightaway.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-266) bundleArchive_setRefreshCount uses wrong file

2015-10-07 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-266.
--
Resolution: Fixed
  Assignee: Bjoern Petri

> bundleArchive_setRefreshCount uses wrong file
> -
>
> Key: CELIX-266
> URL: https://issues.apache.org/jira/browse/CELIX-266
> Project: Celix
>  Issue Type: Bug
>Reporter: Bjoern Petri
>Assignee: Bjoern Petri
>Priority: Trivial
>
> bundleArchive_setRefreshCount uses bundle.state which should be 
> refresh.counter



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-266) bundleArchive_setRefreshCount uses wrong file

2015-10-05 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-266:
--

 Summary: bundleArchive_setRefreshCount uses wrong file
 Key: CELIX-266
 URL: https://issues.apache.org/jira/browse/CELIX-266
 Project: Celix
  Issue Type: Bug
Reporter: Bjoern Petri
Priority: Trivial


bundleArchive_setRefreshCount uses bundle.state which should be refresh.counter



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-252) discovery_etcd cannot handle celix restarts

2015-10-05 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-252.
--
Resolution: Fixed

> discovery_etcd cannot handle celix restarts
> ---
>
> Key: CELIX-252
> URL: https://issues.apache.org/jira/browse/CELIX-252
> Project: Celix
>  Issue Type: Bug
>Reporter: Bjoern Petri
>Assignee: Bjoern Petri
>
> When restarting celix, the same IP adress for the (http) discovery endpoint 
> server might be written using a different etcd key (we usually use the fw 
> uuid). 
> Unfortunately the key itself is not taken into account when a previous etcd 
> entry containing the same IP adress expires leading to a removal of the 
> imported services.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-261) Fix memory leaks in shell

2015-10-03 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-261:
--

 Summary: Fix memory leaks in shell
 Key: CELIX-261
 URL: https://issues.apache.org/jira/browse/CELIX-261
 Project: Celix
  Issue Type: Bug
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Minor


Some of the arraylists are not destroyed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (CELIX-264) Missing strdup leads to invalid free

2015-10-03 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri updated CELIX-264:
---
Description: When falling back to the DEFAULT_IP in RSA/Discovery no string 
copy is done. This leads to an invalid free call when destroying the bundle.  
(was: When falling back to the DEFAULT_IP in RSA/Discovery now string copy is 
done. This leads to an invalid free call when destroying the bundle.)

> Missing strdup leads to invalid free
> 
>
> Key: CELIX-264
> URL: https://issues.apache.org/jira/browse/CELIX-264
> Project: Celix
>  Issue Type: Bug
>  Components: Remote Service Admin
>Reporter: Bjoern Petri
>Assignee: Bjoern Petri
>Priority: Minor
>
> When falling back to the DEFAULT_IP in RSA/Discovery no string copy is done. 
> This leads to an invalid free call when destroying the bundle.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-258) framework uses dlopen/dlsym to set the bundleActivator

2015-09-25 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-258:
--

 Summary: framework uses  dlopen/dlsym to set the bundleActivator
 Key: CELIX-258
 URL: https://issues.apache.org/jira/browse/CELIX-258
 Project: Celix
  Issue Type: Improvement
  Components: Framework
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Minor


Similar to bundles, the framework uses  dlopen and dlsym to retrieve and set 
the bundleActivator for the framework bundle. 

While it might be more comprehensive to set the function pointer directly, this 
also does not work on Android.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-257) discovery endpoint poller is not triggered when adding url

2015-09-15 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-257:
--

 Summary: discovery endpoint poller is not triggered when adding url
 Key: CELIX-257
 URL: https://issues.apache.org/jira/browse/CELIX-257
 Project: Celix
  Issue Type: Improvement
Reporter: Bjoern Petri
Assignee: Bjoern Petri


By default the discovery endpoint poller polls every 10 seconds all added urls 
for new endpoints. This causes some inconvenient delay when  e.g. using 
discovery_etcd. 

An improvement would be to directly poll the url, once it is added.





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-252) discovery_etcd cannot handle celix restarts

2015-08-23 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-252:
--

 Summary: discovery_etcd cannot handle celix restarts
 Key: CELIX-252
 URL: https://issues.apache.org/jira/browse/CELIX-252
 Project: Celix
  Issue Type: Bug
Reporter: Bjoern Petri
Assignee: Bjoern Petri


When restarting celix, the same IP adress for the (http) discovery endpoint 
server might be written using a different etcd key (we usually use the fw 
uuid). 
Unfortunately the key itself is not taken into account when a previous etcd 
entry containing the same IP adress expires leading to a removal of the 
imported services.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-251) missing includes in device access example

2015-08-17 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-251:
--

 Summary: missing includes in device access example
 Key: CELIX-251
 URL: https://issues.apache.org/jira/browse/CELIX-251
 Project: Celix
  Issue Type: Improvement
Reporter: Bjoern Petri
Priority: Minor


There are some warnings when compiling the device access example about some 
implicit declarations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-250) config.h is not exported

2015-08-17 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-250:
--

 Summary: config.h is not exported
 Key: CELIX-250
 URL: https://issues.apache.org/jira/browse/CELIX-250
 Project: Celix
  Issue Type: Bug
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Minor


To be able to implement a dedicated launcher, framework.h and in turn config.h 
are needed within the include path. While first is exported, latter is not. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-208) Remove APR from examples

2015-08-11 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-208.
--
Resolution: Fixed
  Assignee: Bjoern Petri

 Remove APR from examples
 

 Key: CELIX-208
 URL: https://issues.apache.org/jira/browse/CELIX-208
 Project: Celix
  Issue Type: Task
  Components: Examples
Reporter: Alexander Broekhuis
Assignee: Bjoern Petri





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-246) enable Travis CI for Apache Celix

2015-07-09 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-246.
--
Resolution: Fixed

 enable Travis CI for Apache Celix
 -

 Key: CELIX-246
 URL: https://issues.apache.org/jira/browse/CELIX-246
 Project: Celix
  Issue Type: Improvement
Reporter: Bjoern Petri
Assignee: Bjoern Petri

 To be able to easily test committed code, travis ci can be enabled. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-246) enable Travis CI for Apache Celix

2015-07-02 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-246:
--

 Summary: enable Travis CI for Apache Celix
 Key: CELIX-246
 URL: https://issues.apache.org/jira/browse/CELIX-246
 Project: Celix
  Issue Type: Improvement
Reporter: Bjoern Petri
Assignee: Bjoern Petri


To be able to easily test committed code, travis ci can be enabled. 





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-245) Update civetweb to latest version

2015-07-01 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-245:
--

 Summary: Update civetweb to latest version
 Key: CELIX-245
 URL: https://issues.apache.org/jira/browse/CELIX-245
 Project: Celix
  Issue Type: Improvement
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Minor


I sometimes experienced http errors when testing the endpoint server. It seems 
that they don't occur with the latest version. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-242) Fix Warnings

2015-07-01 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-242.
--
Resolution: Fixed

 Fix Warnings
 

 Key: CELIX-242
 URL: https://issues.apache.org/jira/browse/CELIX-242
 Project: Celix
  Issue Type: Improvement
Reporter: Bjoern Petri
Priority: Trivial

 When compiling with clang  there are still some warnings. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-244) remote shell crashes during shutdown

2015-06-27 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-244:
--

 Summary: remote shell crashes during shutdown
 Key: CELIX-244
 URL: https://issues.apache.org/jira/browse/CELIX-244
 Project: Celix
  Issue Type: Bug
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Minor


The remoteShell crashes when stopped because it gets used after it is already 
destroyed.

{code}
ogram received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffecae3700 (LWP 20314)]
0x7fffed2e8a65 in logHelper_log (loghelper=0x0, level=OSGI_LOGSERVICE_INFO, 
message=0x7fffed2e8be0 CONNECTION_LISTENER: Stopping thread\n)
at 
/home/bjoern/Development/inaetics/update.Provisioning/celix/celix/log_service/public/src/log_helper.c:185
185 if (!logged  loghelper-stdOutFallback) {
(gdb) 
(gdb) bt 
#0  0x7fffed2e8a65 in logHelper_log (loghelper=0x0, 
level=OSGI_LOGSERVICE_INFO, 
message=0x7fffed2e8be0 CONNECTION_LISTENER: Stopping thread\n)
at 
/home/bjoern/Development/inaetics/update.Provisioning/celix/celix/log_service/public/src/log_helper.c:185
#1  0x7fffed2e728b in connectionListener_stop (instance=0x60f160)
at 
/home/bjoern/Development/inaetics/update.Provisioning/celix/celix/remote_shell/private/src/connection_listener.c:100
#2  0x7fffed2e6f6f in bundleActivator_stop (userData=0x60d3d0, 
context=0x60e1b0)
at 
/home/bjoern/Development/inaetics/update.Provisioning/celix/celix/remote_shell/private/src/activator.c:106
#3  0x77bbcdb4 in fw_stopBundle (framework=0x604060, bundle=0x619490, 
record=false)
at 
/home/bjoern/Development/inaetics/update.Provisioning/celix/celix/framework/private/src/framework.c:898
#4  0x77bc01a1 in framework_shutdown (framework=0x604060)
at 
/home/bjoern/Development/inaetics/update.Provisioning/celix/celix/framework/private/src/framework.c:2063
#5  0x75d12182 in start_thread (arg=0x7fffecae3700) at 
pthread_create.c:312
#6  0x7747147d in clone () at 
../sysdeps/unix/sysv/linux/x86_64/clone.S:111
{code}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-240) RSA: deadlock when stopping

2015-06-26 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-240.
--
Resolution: Fixed

 RSA: deadlock when stopping
 ---

 Key: CELIX-240
 URL: https://issues.apache.org/jira/browse/CELIX-240
 Project: Celix
  Issue Type: Bug
  Components: Remote Service Admin
Reporter: Bjoern Petri
Assignee: Bjoern Petri

 When a service is exported and the RSA is shut down first it'll stop the 
 endpoint tracker, which triggers the call of 
 remoteServiceAdmin_removeExportedService. 
 In both cases the access to the list of exported services is protected by a 
 lock. Hence, when calling  remoteServiceAdmin_removeExportedService the lock 
 is already been locked by remoteServiceAdmin_stop resulting in a deadlock.
 {code}
 Thread 54 (Thread 0x7fff597f2700 (LWP 2417)):
 #0  __lll_lock_wait () at 
 ../nptl/sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:135
 #1  0x75ae3657 in _L_lock_909 () from 
 /lib/x86_64-linux-gnu/libpthread.so.0
 #2  0x75ae3480 in __GI___pthread_mutex_lock (mutex=0x61da30) at 
 ../nptl/pthread_mutex_lock.c:79
 #3  0x77741f3e in celixThreadMutex_lock (mutex=0x61da30) at 
 /home/bjoern/Development/celix/git/celix.current.plain/celix/utils/private/src/celix_threads.c:92
 #4  0x718d9046 in remoteServiceAdmin_removeExportedService 
 (registration=0x6079d0)
 at 
 /home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/remote_service_admin_http/private/src/remote_service_admin_impl.c:444
 #5  0x718da690 in exportRegistration_endpointRemoved 
 (handle=0x6079d0, reference=0x609f10, service=0x6088e0)
 at 
 /home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/remote_service_admin/private/src/export_registration_impl.c:168
 #6  0x77bc9ce6 in serviceTracker_untrack (tracker=0x609ac0, 
 reference=0x609f10, event=0x0)
 at 
 /home/bjoern/Development/celix/git/celix.current.plain/celix/framework/private/src/service_tracker.c:332
 #7  0x77bc9590 in serviceTracker_close (tracker=0x609ac0) at 
 /home/bjoern/Development/celix/git/celix.current.plain/celix/framework/private/src/service_tracker.c:142
 #8  0x718da3ad in exportRegistration_stopTracking 
 (registration=0x6079d0)
 at 
 /home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/remote_service_admin/private/src/export_registration_impl.c:91
 #9  0x718d83a5 in remoteServiceAdmin_stop (admin=0x61da20)
 at 
 /home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/remote_service_admin_http/private/src/remote_service_admin_impl.c:216
 #10 0x718da181 in bundleActivator_stop (userData=0x61cfd0, 
 context=0x61c980)
 at 
 /home/bjoern/Development/celix/git/celix.current.plain/celix/remote_services/remote_service_admin_http/private/src/remote_service_admin_activator.c:102
 #11 0x77bbcf7f in fw_stopBundle (framework=0x604130, bundle=0x619a30, 
 record=false)
 at 
 /home/bjoern/Development/celix/git/celix.current.plain/celix/framework/private/src/framework.c:884
 #12 0x77bb44dd in bundle_stopWithOptions (bundle=0x619a30, options=0) 
 at 
 /home/bjoern/Development/celix/git/celix.current.plain/celix/framework/private/src/bundle.c:326
 #13 0x7fffc43f1025 in stopCommand_execute (command=0x60e230, 
 line=0x7fff597f1d70 stop, out=0x7fffc41e9f65 shellTui_write, 
 err=0x7fffc41e9f65 shellTui_write)
 at 
 /home/bjoern/Development/celix/git/celix.current.plain/celix/shell/private/src/stop_command.c:73
 #14 0x7fffc43f0434 in shell_executeCommand (shell=0x60c800, 
 commandLine=0x7fff597f1d70 stop, out=0x7fffc41e9f65 shellTui_write, 
 error=0x7fffc41e9f65 shellTui_write)
 at 
 /home/bjoern/Development/celix/git/celix.current.plain/celix/shell/private/src/shell.c:157
 #15 0x7fffc41ea152 in shellTui_runnable (data=0x60a030) at 
 /home/bjoern/Development/celix/git/celix.current.plain/celix/shell_tui/private/src/shell_tui.c:86
 #16 0x75ae1182 in start_thread (arg=0x7fff597f2700) at 
 pthread_create.c:312
 #17 0x7724047d in clone () at 
 ../sysdeps/unix/sysv/linux/x86_64/clone.S:111
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-241) remote_interface incorrect

2015-06-26 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-241.
--
Resolution: Fixed

 remote_interface incorrect
 --

 Key: CELIX-241
 URL: https://issues.apache.org/jira/browse/CELIX-241
 Project: Celix
  Issue Type: Bug
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Trivial

 While investigating CELIX-240, I tried to use calculator_endpoint2 next to 
 calculator_endpoint. This did not work because the remote_interface in the 
 service was still set to calculator instead of calculator2.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-242) Fix Warnings

2015-06-20 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-242:
--

 Summary: Fix Warnings
 Key: CELIX-242
 URL: https://issues.apache.org/jira/browse/CELIX-242
 Project: Celix
  Issue Type: Improvement
Reporter: Bjoern Petri
Priority: Trivial


When compiling with clang  there are still some warnings. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-239) TopologyManager does not maintain exportedServices

2015-06-18 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-239.
--
Resolution: Fixed


serviceListener replaced w/ serviceTracker

 TopologyManager does not maintain exportedServices 
 ---

 Key: CELIX-239
 URL: https://issues.apache.org/jira/browse/CELIX-239
 Project: Celix
  Issue Type: Bug
Reporter: Bjoern Petri
Assignee: Bjoern Petri

 When a service gets exported, the TopologyManager uses a 
 bundleContext_getServiceReferences-call to retrieve all currently available 
 endpointListenerServices and inform them about the newly available service. 
 In case new endpointListeners are added, they are not informed about already 
 exported services.  This leads to missing service-announcements in case 
 discovery starts after the topology manager.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-235) DataRace in fw_invokeBundleListener / framework_setBundleStateAndNotify

2015-05-15 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-235:
--

 Summary: DataRace in fw_invokeBundleListener / 
framework_setBundleStateAndNotify
 Key: CELIX-235
 URL: https://issues.apache.org/jira/browse/CELIX-235
 Project: Celix
  Issue Type: Bug
  Components: Framework
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Minor


The state of a bundle is not protected and can be set to a new value (via 
framework_setBundleStateAndNotify) while or before the fw_dispatcher was able 
to process the according event.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-234) DataRace in fw_invokeBundleListener / framework_setBundleStateAndNotify

2015-05-15 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-234:
--

 Summary: DataRace in fw_invokeBundleListener / 
framework_setBundleStateAndNotify
 Key: CELIX-234
 URL: https://issues.apache.org/jira/browse/CELIX-234
 Project: Celix
  Issue Type: Bug
  Components: Framework
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Minor


The state of a bundle is not protected and can be set to a new value (via 
framework_setBundleStateAndNotify) while or before the fw_dispatcher was able 
to process the according event.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-235) DataRace in fw_invokeBundleListener / framework_setBundleStateAndNotify

2015-05-15 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-235.
--
Resolution: Duplicate

 DataRace in fw_invokeBundleListener / framework_setBundleStateAndNotify
 ---

 Key: CELIX-235
 URL: https://issues.apache.org/jira/browse/CELIX-235
 Project: Celix
  Issue Type: Bug
  Components: Framework
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Minor

 The state of a bundle is not protected and can be set to a new value (via 
 framework_setBundleStateAndNotify) while or before the fw_dispatcher was able 
 to process the according event.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-233) Replace booleans as sync primitives

2015-05-15 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-233:
--

 Summary: Replace booleans as sync primitives
 Key: CELIX-233
 URL: https://issues.apache.org/jira/browse/CELIX-233
 Project: Celix
  Issue Type: Bug
Reporter: Bjoern Petri
Assignee: Bjoern Petri


In a lot of cases we use boolean variables (e.g. bool running) to determine 
whether a critical section can be executed. Usually those variables are not 
declared volatile, so the they may be cached in registers. Before the value in 
the register is written to memory, another thread might be scheduled to run, 
resulting in that thread reading stale data.

But even when declaring a variable as volatile (although the volatile qualifier 
guarantees that the reads and writes will happen in the exact order specified 
in the source code), the compiler may generate code which reorders a volatile 
read or write with non-volatile reads or writes, thus limiting its usefulness 
as an interthread flag or mutex.

That's why it should be preferable to use e.g. a mutex as sync primitive




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-231) Missing log_helper creation in discovery_etcd

2015-04-09 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-231.
--
Resolution: Fixed

Fixed in branch  hotfix/CELIX-231_Missing_log_helper_creation, merged back to 
master and develop

 Missing log_helper creation in discovery_etcd
 -

 Key: CELIX-231
 URL: https://issues.apache.org/jira/browse/CELIX-231
 Project: Celix
  Issue Type: Bug
Reporter: Bjoern Petri
Assignee: Bjoern Petri

 The discovery_create of the discovery etcd bundle does not initalize the 
 loghelper causing a segfault as soon as it is used 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-231) Missing log_helper creation in discovery_etcd

2015-04-08 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-231:
--

 Summary: Missing log_helper creation in discovery_etcd
 Key: CELIX-231
 URL: https://issues.apache.org/jira/browse/CELIX-231
 Project: Celix
  Issue Type: Bug
Reporter: Bjoern Petri
Assignee: Bjoern Petri


The discovery_create of the discovery etcd bundle does not initalize the 
loghelper causing a segfault as soon as it is used 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-226) __unused atttibute does not work with Linux

2015-02-19 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-226.
--
Resolution: Fixed

 __unused atttibute does not work with  Linux
 

 Key: CELIX-226
 URL: https://issues.apache.org/jira/browse/CELIX-226
 Project: Celix
  Issue Type: Bug
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Minor

 Specifying the unused attribute via __unused  seems to not work within 
 Linux. The attribute needs to be specified with __attribute__((unused)).
 It needs to be checked whether this works for MacOS. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-226) __unused atttibute does not work with Linux

2015-02-15 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-226:
--

 Summary: __unused atttibute does not work with  Linux
 Key: CELIX-226
 URL: https://issues.apache.org/jira/browse/CELIX-226
 Project: Celix
  Issue Type: Bug
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Minor


Specifying the unused attribute via __unused  seems to not work within Linux. 
The attribute needs to be specified with __attribute__((unused)).

It needs to be checked whether this works for MacOS. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (CELIX-190) remote services memory leaks

2014-12-02 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri updated CELIX-190:
---
Description: There are several minor memory leaks in the current remote 
services (rsa and discovery) implementation  (was: There are several minor 
memory leaks in the current rsa implementation)
   Assignee: Bjoern Petri
Summary: remote services memory leaks  (was: RSA memory leaks)

 remote services memory leaks
 

 Key: CELIX-190
 URL: https://issues.apache.org/jira/browse/CELIX-190
 Project: Celix
  Issue Type: Bug
  Components: Remote Service Admin
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Minor

 There are several minor memory leaks in the current remote services (rsa and 
 discovery) implementation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-186) deployment_admin segfaults while downloading bundle

2014-12-01 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-186.
--
Resolution: Fixed

 deployment_admin segfaults while downloading bundle
 ---

 Key: CELIX-186
 URL: https://issues.apache.org/jira/browse/CELIX-186
 Project: Celix
  Issue Type: Bug
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Minor

 the deployment admin currenlty segfaults when trying to download a new bundle:
 {code}
 (gdb) bt 
 #0  0x76cb826d in __gen_tempname () from /lib64/libc.so.6
 #1  0x759619ee in deploymentAdmin_download (url=0x6286e0 
 http://localhost:8080/deployment/celix/versions/1.0.0;, 
 inputFile=0x71565e78)
 at 
 /home/bjoern/Development/celix.current/deployment_admin/private/src/deployment_admin.c:324
 #2  0x75960f7b in deploymentAdmin_poll (thd=0x6286a8, 
 deploymentAdmin=0x628600)
 at 
 /home/bjoern/Development/celix.current/deployment_admin/private/src/deployment_admin.c:196
 #3  0x76a39ee5 in start_thread () from /lib64/libpthread.so.0
 #4  0x76d43b8d in clone () from /lib64/libc.so.6
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-146) Replace printfs wit fw_log calls

2014-12-01 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-146.
--
Resolution: Fixed

 Replace printfs wit fw_log calls
 

 Key: CELIX-146
 URL: https://issues.apache.org/jira/browse/CELIX-146
 Project: Celix
  Issue Type: Improvement
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Minor

 Most component still contains plenty of printfs, which should be replaced by 
 according fw_log calls.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-186) deployment_admin segfaults while downloading bundle

2014-11-19 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-186:
--

 Summary: deployment_admin segfaults while downloading bundle
 Key: CELIX-186
 URL: https://issues.apache.org/jira/browse/CELIX-186
 Project: Celix
  Issue Type: Bug
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Minor



the deployment admin currenlty segfaults when trying to download a new bundle:

{code}
(gdb) bt 
#0  0x76cb826d in __gen_tempname () from /lib64/libc.so.6
#1  0x759619ee in deploymentAdmin_download (url=0x6286e0 
http://localhost:8080/deployment/celix/versions/1.0.0;, 
inputFile=0x71565e78)
at 
/home/bjoern/Development/celix.current/deployment_admin/private/src/deployment_admin.c:324
#2  0x75960f7b in deploymentAdmin_poll (thd=0x6286a8, 
deploymentAdmin=0x628600)
at 
/home/bjoern/Development/celix.current/deployment_admin/private/src/deployment_admin.c:196
#3  0x76a39ee5 in start_thread () from /lib64/libpthread.so.0
#4  0x76d43b8d in clone () from /lib64/libc.so.6
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-183) RSA_HTTP: add support for http status 204 (no content)

2014-11-17 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-183.
--
Resolution: Fixed

 RSA_HTTP: add support for http status  204 (no content)
 ---

 Key: CELIX-183
 URL: https://issues.apache.org/jira/browse/CELIX-183
 Project: Celix
  Issue Type: Improvement
  Components: Remote Service Admin
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Minor

 When calling a service method exported from Amdatu and returning a void the 
 Amdatu RSA HTTP returns a 204 status. This behavior is  currenlty not 
 supported by the Celix RSA HTTP and gives therefore problems when implemented 
 by Celix and called by Amdatu (Celix returns currenlty 404 if no reply is set 
 within the endpoint).   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-179) memory leak in rsa_http callback

2014-11-05 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-179:
--

 Summary: memory leak in rsa_http callback
 Key: CELIX-179
 URL: https://issues.apache.org/jira/browse/CELIX-179
 Project: Celix
  Issue Type: Bug
  Components: Remote Service Admin
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Critical


The response of the endpoint is not free'd in the rsa_http:

{code}
char *response = NULL;  
export-endpoint-handleRequest(export-endpoint-endpoint, data, response);

if (response != NULL) {
mg_write(conn, response_headers, strlen(response_headers));
mg_write(conn, response, strlen(response));

result = 1;
}
[...]
{code}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-179) memory leak in rsa_http callback

2014-11-05 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-179.
--
Resolution: Fixed

 memory leak in rsa_http callback
 

 Key: CELIX-179
 URL: https://issues.apache.org/jira/browse/CELIX-179
 Project: Celix
  Issue Type: Bug
  Components: Remote Service Admin
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Critical

 The response of the endpoint is not free'd in the rsa_http:
 {code}
 char *response = NULL;
 export-endpoint-handleRequest(export-endpoint-endpoint, data, response);
 if (response != NULL) {
 mg_write(conn, response_headers, strlen(response_headers));
 mg_write(conn, response, strlen(response));
 result = 1;
 }
 [...]
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CELIX-178) Shell_Tui bundle hangs on stop

2014-11-03 Thread Bjoern Petri (JIRA)

[ 
https://issues.apache.org/jira/browse/CELIX-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14194814#comment-14194814
 ] 

Bjoern Petri commented on CELIX-178:


Applied patch. Please verify and close if ok. Thanks for your work Gabriele - 
you fixed the most annoying thing in celix :)


r1636411 | bpetri | 2014-11-03 19:02:45 +0100 (Mon, 03 Nov 2014) | 1 line
Changed paths:
   M /celix/trunk/shell_tui/private/src/shell_tui.c

CELIX-178: Applied provided patch to prevent hanging fgets.


 Shell_Tui bundle hangs on stop
 --

 Key: CELIX-178
 URL: https://issues.apache.org/jira/browse/CELIX-178
 Project: Celix
  Issue Type: Bug
Reporter: Gabriele Ricciardi
 Attachments: shell_tui.c.patch


 During the stopBundle phase, the input management thread of the shell_tui 
 bundle is blocked on a fgets. This prevent the stopBundle to be completed, 
 since it waits for the blocked thread.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-175) segfault during shutdown when calculator is already stopped

2014-11-01 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-175.
--
Resolution: Fixed

 segfault during shutdown when calculator is already stopped
 ---

 Key: CELIX-175
 URL: https://issues.apache.org/jira/browse/CELIX-175
 Project: Celix
  Issue Type: Bug
 Environment: Revision: 1634019
Reporter: Bjoern Petri

 Using the remote-services-cfg deployment, I can reproduce a segfault when 
 stopping the apache_celix_remoting_calculator_impl manually before shutting 
 down:
 {code}
 - ps
   IDStateName
   0 Active   framework
   1 Active   apache_celix_rsa_discovery_configured
   2 Active   apache_celix_rs_topology_manager
   3 Active   apache_celix_remote_service_admin_http
   4 Active   apache_celix_remoting_calculator_impl
   5 Active   apache_celix_shell
   6 Active   apache_celix_shell_tui
   7 Active   apache_celix_log_service
   8 Active   apache_celix_log_writer
   9 Active   apache_celix_remoting_calculator_endpoint
   10Active   apache_celix_remoting_calculator2_endpoint
 - stop 4
 INFO: TOPOLOGY_MANAGER: Remove exported service (6).
 INFO: TOPOLOGY_MANAGER: listener with filter 
 ((objectClass=remote_endpoint)(remote.interface=org.apache.celix.calc.api.Calculator))
  removed.
 LogWriter: BUNDLE_EVENT_STOPPED from apache_celix_remoting_calculator_endpoint
 LogWriter: BUNDLE_EVENT_UNRESOLVED from 
 apache_celix_remoting_calculator_endpoint
 LogWriter: BUNDLE_EVENT_UNINSTALLED from 
 apache_celix_remoting_calculator_endpoint
 INFO: TOPOLOGY_MANAGER: Remove imported service 
 (org.apache.celix.calc.api.Calculator; fd7d5d34-aa36-4ecc-a7d7-dbb9bf63ea8d).
 INFO: Endpoint for org.apache.celix.calc.api.Calculator, with filter (null) 
 removed...
 INFO: removing endpoint fd7d5d34-aa36-4ecc-a7d7-dbb9bf63ea8d...
 INFO: TOPOLOGY_MANAGER: Remove exported service (8).
 INFO: TOPOLOGY_MANAGER: listener with filter 
 ((objectClass=remote_endpoint)(remote.interface=org.apache.celix.calc.api.Calculator2))
  removed.
 LogWriter: BUNDLE_EVENT_STOPPED from 
 apache_celix_remoting_calculator2_endpoint
 LogWriter: BUNDLE_EVENT_UNRESOLVED from 
 apache_celix_remoting_calculator2_endpoint
 LogWriter: BUNDLE_EVENT_UNINSTALLED from 
 apache_celix_remoting_calculator2_endpoint
 INFO: TOPOLOGY_MANAGER: Remove imported service 
 (org.apache.celix.calc.api.Calculator2; 62d9a3c8-0340-4a69-95c3-325a0f5d1be4).
 INFO: Endpoint for org.apache.celix.calc.api.Calculator2, with filter 
 (null) removed...
 INFO: removing endpoint 62d9a3c8-0340-4a69-95c3-325a0f5d1be4...
 - LogWriter: BUNDLE_EVENT_STOPPED from apache_celix_remoting_calculator_impl
 - stop 0
 INFO: FRAMEWORK: Start shutdownthread
 [New Thread 0x7fff567ec700 (LWP 10466)]
 - INFO: FRAMEWORK: Shutdown
 INFO: TOPOLOGY_MANAGER: listener with filter (objectClass=shellService) 
 removed.
 LogWriter: BUNDLE_EVENT_STOPPED from framework
 [Thread 0x7fff577ee700 (LWP 10462) exited]
 LogWriter: BUNDLE_EVENT_STOPPED from apache_celix_shell_tui
 DEBUG: TOPOLOGY_MANAGER: Ignore myself.
 INFO: TOPOLOGY_MANAGER: Removed RSA
 *** Error in `/home/bjoern/Development/build.current/launcher/celix': double 
 free or corruption (out): 0x00647cb0 ***
 [..]
 (gdb) bt
 #0  0x76c84877 in raise () from /lib64/libc.so.6
 #1  0x76c85f68 in abort () from /lib64/libc.so.6
 #2  0x76cc4a54 in __libc_message () from /lib64/libc.so.6
 #3  0x76ccbd78 in _int_free () from /lib64/libc.so.6
 #4  0x77969b73 in arrayList_destroy (list=0x641070)
 at 
 /home/bjoern/Development/celix.current/utils/private/src/array_list.c:53
 #5  0x7fffef7d108c in topologyManager_rsaRemoved (handle=0x61a320, 
 reference=0x63c0b0, 
 service=0x632290)
 at 
 /home/bjoern/Development/celix.current/remote_services/topology_manager/private/src/topology_manager.c:224
 #6  0x77bb3c75 in serviceTracker_untrack (tracker=0x61a6f0, 
 reference=0x63c0b0, event=0x0)
 at 
 /home/bjoern/Development/celix.current/framework/private/src/service_tracker.c:325
 #7  0x77bb2f54 in serviceTracker_close (tracker=0x61a6f0)
 at 
 /home/bjoern/Development/celix.current/framework/private/src/service_tracker.c:135
 #8  0x7fffef7d3688 in bundleActivator_stop (userData=0x618490, 
 context=0x619c90)
 at 
 /home/bjoern/Development/celix.current/remote_services/topology_manager/private/src/activator.c:175
 #9  0x77b9e8b5 in fw_stopBundle (framework=0x60e200, bundle=0x623040, 
 record=false)
 at 
 /home/bjoern/Development/celix.current/framework/private/src/framework.c:843
 #10 0x77ba402d in framework_shutdown (framework=0x60e200)
 at 
 

[jira] [Created] (CELIX-173) stopping rsa_http bundle does not stop rsa webserver

2014-10-22 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-173:
--

 Summary: stopping rsa_http bundle does not stop rsa webserver  
 Key: CELIX-173
 URL: https://issues.apache.org/jira/browse/CELIX-173
 Project: Celix
  Issue Type: Bug
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Minor


After starting and stopping the rsa-http bundle, the port is still blocked. 
Another start of the rsa-http bundle leads to a bind on a new port. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (CELIX-149) Add log_writer_syslog

2014-10-19 Thread Bjoern Petri (JIRA)

 [ 
https://issues.apache.org/jira/browse/CELIX-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bjoern Petri closed CELIX-149.
--
Resolution: Fixed

 Add log_writer_syslog
 -

 Key: CELIX-149
 URL: https://issues.apache.org/jira/browse/CELIX-149
 Project: Celix
  Issue Type: Improvement
Reporter: Bjoern Petri
Assignee: Bjoern Petri
Priority: Minor

 I restructured the log-writer in a common part, a stdout part and a syslog 
 part. For the syslog part I added a corresponding cmake syslog function.
 I still need to test this a little bit more, but whoever wants can take a 
 look as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-161) newly added RSA cannot manage already exported/imported services

2014-10-01 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-161:
--

 Summary: newly added RSA cannot manage already exported/imported 
services
 Key: CELIX-161
 URL: https://issues.apache.org/jira/browse/CELIX-161
 Project: Celix
  Issue Type: Bug
Reporter: Bjoern Petri
Assignee: Bjoern Petri


When an RSA is started, after an service has been exported or imported, it does 
not know about those exports/imports.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CELIX-152) Added Discovery/ETCD support

2014-09-19 Thread Bjoern Petri (JIRA)
Bjoern Petri created CELIX-152:
--

 Summary: Added Discovery/ETCD support 
 Key: CELIX-152
 URL: https://issues.apache.org/jira/browse/CELIX-152
 Project: Celix
  Issue Type: Improvement
Reporter: Bjoern Petri
Assignee: Bjoern Petri


Re-using the discovery_cfg, I added a bundle which supports discovery based on 
etcd.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


  1   2   >