[GitHub] marcaurele commented on issue #2247: CLOUDSTACK-10012: Load SQL schema scripts from JAR
marcaurele commented on issue #2247: CLOUDSTACK-10012: Load SQL schema scripts from JAR URL: https://github.com/apache/cloudstack/pull/2247#issuecomment-349888539 @rhtyd all checks are green, can you have a look or push further testing on this branch. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bwsw commented on issue #2320: CLOUDSTACK-10178: Hotfixes to make 4.10 work
bwsw commented on issue #2320: CLOUDSTACK-10178: Hotfixes to make 4.10 work URL: https://github.com/apache/cloudstack/pull/2320#issuecomment-349869988 @GabrielBrascher updated. Please, take a look. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2318: [4.9] Smoketest health checkrun baseline
blueorangutan commented on issue #2318: [4.9] Smoketest health checkrun baseline URL: https://github.com/apache/cloudstack/pull/2318#issuecomment-349842516 Trillian test result (tid-1739) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 55132 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2318-t1739-vmware-55u3.zip Test /marvin/tests/smoke/test_accounts.py took 2005 seconds Test /marvin/tests/smoke/test_affinity_groups_projects.py took 323 seconds Test /marvin/tests/smoke/test_affinity_groups.py took 293 seconds Test /marvin/tests/smoke/test_certauthority_root.py took 39 seconds Test /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py took 475 seconds Test /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py took 6 seconds Test /marvin/tests/smoke/test_deploy_vm_iso.py took 253 seconds Test /marvin/tests/smoke/test_deploy_vm_root_resize.py took 122 seconds Test /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py took 983 seconds Test /marvin/tests/smoke/test_deploy_vm_with_userdata.py took 725 seconds Test /marvin/tests/smoke/test_disk_offerings.py took 6 seconds Test /marvin/tests/smoke/test_dynamicroles.py took 103 seconds Test /marvin/tests/smoke/test_global_settings.py took 5 seconds Test /marvin/tests/smoke/test_guest_vlan_range.py took 26 seconds Test /marvin/tests/smoke/test_host_annotations.py took 13 seconds Test /marvin/tests/smoke/test_hostha_simulator.py took 6 seconds Test /marvin/tests/smoke/test_host_maintenance.py took 1117 seconds Test /marvin/tests/smoke/test_hosts.py took 7 seconds Test /marvin/tests/smoke/test_internal_lb.py took 3624 seconds Test /marvin/tests/smoke/test_iso.py took 264 seconds Test /marvin/tests/smoke/test_list_ids_parameter.py took 1983 seconds Test /marvin/tests/smoke/test_loadbalance.py took 1245 seconds Test /marvin/tests/smoke/test_login.py took 24 seconds Test /marvin/tests/smoke/test_metrics_api.py took 477 seconds Test /marvin/tests/smoke/test_multipleips_per_nic.py took 414 seconds Test /marvin/tests/smoke/test_nested_virtualization.py took 661 seconds Test /marvin/tests/smoke/test_network_acl.py took 383 seconds Test /marvin/tests/smoke/test_network.py took 2962 seconds Test /marvin/tests/smoke/test_nic_adapter_type.py took 11 seconds Test /marvin/tests/smoke/test_nic.py took 2374 seconds Test /marvin/tests/smoke/test_non_contigiousvlan.py took 20 seconds Test /marvin/tests/smoke/test_outofbandmanagement_nestedplugin.py took 88 seconds Test /marvin/tests/smoke/test_outofbandmanagement.py took 235 seconds Test /marvin/tests/smoke/test_over_provisioning.py took 5 seconds Test /marvin/tests/smoke/test_password_server.py took 633 seconds Test /marvin/tests/smoke/test_portable_publicip.py took 52 seconds Test /marvin/tests/smoke/test_portforwardingrules.py took 414 seconds Test /marvin/tests/smoke/test_primary_storage.py took 955 seconds Test /marvin/tests/smoke/test_privategw_acl.py took 2685 seconds Test /marvin/tests/smoke/test_projects.py took 894 seconds Test /marvin/tests/smoke/test_public_ip_range.py took 11 seconds Test /marvin/tests/smoke/test_pvlan.py took 11 seconds Test /marvin/tests/smoke/test_regions.py took 6 seconds Test /marvin/tests/smoke/test_reset_vm_on_reboot.py took 534 seconds Test /marvin/tests/smoke/test_resource_detail.py took 16 seconds Test /marvin/tests/smoke/test_router_dhcphosts.py took 1280 seconds Test /marvin/tests/smoke/test_router_dns.py took 425 seconds Test /marvin/tests/smoke/test_router_dnsservice.py took 499 seconds Test /marvin/tests/smoke/test_routers_iptables_default_policy.py took 924 seconds Test /marvin/tests/smoke/test_routers_network_ops.py took 2526 seconds Test /marvin/tests/smoke/test_routers.py took 711 seconds Test /marvin/tests/smoke/test_scale_vm.py took 306 seconds Test /marvin/tests/smoke/test_secondary_storage.py took 5 seconds Test /marvin/tests/smoke/test_service_offerings.py took 460 seconds Test /marvin/tests/smoke/test_snapshots.py took 414 seconds Test /marvin/tests/smoke/test_ssvm.py took 1312 seconds Test /marvin/tests/smoke/test_staticroles.py took 5 seconds Test /marvin/tests/smoke/test_templates.py took 1970 seconds Test /marvin/tests/smoke/test_usage_events.py took 5 seconds Test /marvin/tests/smoke/test_usage.py took 2852 seconds Test /marvin/tests/smoke/test_vm_life_cycle.py took 1618 seconds Test /marvin/tests/smoke/test_vm_snapshots.py took 1514 seconds Test /marvin/tests/smoke/test_volumes.py took 968 seconds Test /marvin/tests/smoke/test_vpc_redundant.py took 4884 seconds Test /marvin/tests/smoke/test_vpc_router_nics.py took 1510 seconds Test /marvin/tests/smoke/test_vpc_vpn.py took 1732 seconds Test /marvin/tests/smoke/test_hostha_kvm.py took 5 seconds Test completed. 57
[GitHub] blueorangutan commented on issue #2355: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python scr?
blueorangutan commented on issue #2355: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python scr? URL: https://github.com/apache/cloudstack/pull/2355#issuecomment-349841679 Trillian test result (tid-1740) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 29843 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2355-t1740-kvm-centos7.zip Test /marvin/tests/smoke/test_accounts.py took 1285 seconds Test /marvin/tests/smoke/test_affinity_groups_projects.py took 200 seconds Test /marvin/tests/smoke/test_affinity_groups.py took 100 seconds Test /marvin/tests/smoke/test_certauthority_root.py took 43 seconds Test /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py took 4 seconds Test /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py took 1516 seconds Test /marvin/tests/smoke/test_deploy_vm_iso.py took 85 seconds Test /marvin/tests/smoke/test_deploy_vm_root_resize.py took 120 seconds Test /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py took 180 seconds Test /marvin/tests/smoke/test_deploy_vm_with_userdata.py took 90 seconds Test /marvin/tests/smoke/test_disk_offerings.py took 4 seconds Test /marvin/tests/smoke/test_dynamicroles.py took 107 seconds Test /marvin/tests/smoke/test_global_settings.py took 4 seconds Test /marvin/tests/smoke/test_guest_vlan_range.py took 25 seconds Test /marvin/tests/smoke/test_host_annotations.py took 13 seconds Test /marvin/tests/smoke/test_hostha_simulator.py took 5 seconds Test /marvin/tests/smoke/test_host_maintenance.py took 295 seconds Test /marvin/tests/smoke/test_hosts.py took 5 seconds Test /marvin/tests/smoke/test_internal_lb.py took 1516 seconds Test /marvin/tests/smoke/test_iso.py took 242 seconds Test /marvin/tests/smoke/test_list_ids_parameter.py took 640 seconds Test /marvin/tests/smoke/test_loadbalance.py took 666 seconds Test /marvin/tests/smoke/test_login.py took 21 seconds Test /marvin/tests/smoke/test_metrics_api.py took 112 seconds Test /marvin/tests/smoke/test_multipleips_per_nic.py took 136 seconds Test /marvin/tests/smoke/test_nested_virtualization.py took 9 seconds Test /marvin/tests/smoke/test_network_acl.py took 81 seconds Test /marvin/tests/smoke/test_network.py took 1398 seconds Test /marvin/tests/smoke/test_nic_adapter_type.py took 9 seconds Test /marvin/tests/smoke/test_nic.py took 462 seconds Test /marvin/tests/smoke/test_non_contigiousvlan.py took 19 seconds Test /marvin/tests/smoke/test_outofbandmanagement_nestedplugin.py took 90 seconds Test /marvin/tests/smoke/test_outofbandmanagement.py took 235 seconds Test /marvin/tests/smoke/test_over_provisioning.py took 4 seconds Test /marvin/tests/smoke/test_password_server.py took 265 seconds Test /marvin/tests/smoke/test_portable_publicip.py took 50 seconds Test /marvin/tests/smoke/test_portforwardingrules.py took 116 seconds Test /marvin/tests/smoke/test_primary_storage.py took 546 seconds Test /marvin/tests/smoke/test_privategw_acl.py took 864 seconds Test /marvin/tests/smoke/test_projects.py took 602 seconds Test /marvin/tests/smoke/test_public_ip_range.py took 10 seconds Test /marvin/tests/smoke/test_pvlan.py took 9 seconds Test /marvin/tests/smoke/test_regions.py took 5 seconds Test /marvin/tests/smoke/test_reset_vm_on_reboot.py took 256 seconds Test /marvin/tests/smoke/test_resource_detail.py took 14 seconds Test /marvin/tests/smoke/test_router_dhcphosts.py took 421 seconds Test /marvin/tests/smoke/test_router_dns.py took 197 seconds Test /marvin/tests/smoke/test_router_dnsservice.py took 174 seconds Test /marvin/tests/smoke/test_routers_iptables_default_policy.py took 320 seconds Test /marvin/tests/smoke/test_routers_network_ops.py took 950 seconds Test /marvin/tests/smoke/test_routers.py took 269 seconds Test /marvin/tests/smoke/test_scale_vm.py took 3 seconds Test /marvin/tests/smoke/test_secondary_storage.py took 4 seconds Test /marvin/tests/smoke/test_service_offerings.py took 370 seconds Test /marvin/tests/smoke/test_snapshots.py took 208 seconds Test /marvin/tests/smoke/test_ssvm.py took 886 seconds Test /marvin/tests/smoke/test_staticroles.py took 3 seconds Test /marvin/tests/smoke/test_templates.py took 1211 seconds Test /marvin/tests/smoke/test_usage_events.py took 4 seconds Test /marvin/tests/smoke/test_usage.py took 1579 seconds Test /marvin/tests/smoke/test_vm_life_cycle.py took 1394 seconds Test /marvin/tests/smoke/test_vm_snapshots.py took 634 seconds Test /marvin/tests/smoke/test_volumes.py took 2212 seconds Test /marvin/tests/smoke/test_vpc_redundant.py took 2728 seconds Test /marvin/tests/smoke/test_vpc_router_nics.py took 674 seconds Test /marvin/tests/smoke/test_vpc_vpn.py took 696 seconds Test /marvin/tests/smoke/test_hostha_kvm.py took 833 seconds Test
[GitHub] khos2ow commented on a change in pull request #2352: CLOUDSTACK-10175: prevent VPC list leakage
khos2ow commented on a change in pull request #2352: CLOUDSTACK-10175: prevent
VPC list leakage
URL: https://github.com/apache/cloudstack/pull/2352#discussion_r155375932
##
File path: server/src/com/cloud/user/AccountManagerImpl.java
##
@@ -2472,6 +2464,11 @@ public void buildACLSearchParameters(Account caller,
Long id, String accountName
if (projectId.longValue() == -1) {
if (caller.getType() == Account.ACCOUNT_TYPE_NORMAL) {
permittedAccounts.addAll(_projectMgr.listPermittedProjectAccounts(caller.getId()));
+
+//permittedAccounts can be empty when the caller is
not a part of any project (a domain account)
+if (permittedAccounts.isEmpty()) {
Review comment:
I would say so.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rafaelweingartner commented on a change in pull request #2352: CLOUDSTACK-10175: prevent VPC list leakage
rafaelweingartner commented on a change in pull request #2352:
CLOUDSTACK-10175: prevent VPC list leakage
URL: https://github.com/apache/cloudstack/pull/2352#discussion_r155369392
##
File path: server/src/com/cloud/user/AccountManagerImpl.java
##
@@ -2472,6 +2464,11 @@ public void buildACLSearchParameters(Account caller,
Long id, String accountName
if (projectId.longValue() == -1) {
if (caller.getType() == Account.ACCOUNT_TYPE_NORMAL) {
permittedAccounts.addAll(_projectMgr.listPermittedProjectAccounts(caller.getId()));
+
+//permittedAccounts can be empty when the caller is
not a part of any project (a domain account)
+if (permittedAccounts.isEmpty()) {
Review comment:
thanks!
So, it seems that the code was not formatted properly before.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] khos2ow commented on a change in pull request #2352: CLOUDSTACK-10175: prevent VPC list leakage
khos2ow commented on a change in pull request #2352: CLOUDSTACK-10175: prevent
VPC list leakage
URL: https://github.com/apache/cloudstack/pull/2352#discussion_r155365083
##
File path: server/src/com/cloud/user/AccountManagerImpl.java
##
@@ -2472,6 +2464,11 @@ public void buildACLSearchParameters(Account caller,
Long id, String accountName
if (projectId.longValue() == -1) {
if (caller.getType() == Account.ACCOUNT_TYPE_NORMAL) {
permittedAccounts.addAll(_projectMgr.listPermittedProjectAccounts(caller.getId()));
+
+//permittedAccounts can be empty when the caller is
not a part of any project (a domain account)
+if (permittedAccounts.isEmpty()) {
Review comment:
and yes, I'm using the same code formatter (checked in the repo) in Eclipse
and not the `eclipse.epf`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] khos2ow commented on a change in pull request #2352: CLOUDSTACK-10175: prevent VPC list leakage
khos2ow commented on a change in pull request #2352: CLOUDSTACK-10175: prevent
VPC list leakage
URL: https://github.com/apache/cloudstack/pull/2352#discussion_r155357942
##
File path: server/src/com/cloud/user/AccountManagerImpl.java
##
@@ -2472,6 +2464,11 @@ public void buildACLSearchParameters(Account caller,
Long id, String accountName
if (projectId.longValue() == -1) {
if (caller.getType() == Account.ACCOUNT_TYPE_NORMAL) {
permittedAccounts.addAll(_projectMgr.listPermittedProjectAccounts(caller.getId()));
+
+//permittedAccounts can be empty when the caller is
not a part of any project (a domain account)
+if (permittedAccounts.isEmpty()) {
Review comment:
There are multiple places which call
`AccountManagerImpl#buildACLSearchParameters` and all of them have `List
permittedAccounts = new ArrayList();`. So technically there's no need to
check for null or use `CollectionUtils`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rafaelweingartner commented on a change in pull request #2352: CLOUDSTACK-10175: prevent VPC list leakage
rafaelweingartner commented on a change in pull request #2352:
CLOUDSTACK-10175: prevent VPC list leakage
URL: https://github.com/apache/cloudstack/pull/2352#discussion_r155338301
##
File path: server/src/com/cloud/user/AccountManagerImpl.java
##
@@ -2472,6 +2464,11 @@ public void buildACLSearchParameters(Account caller,
Long id, String accountName
if (projectId.longValue() == -1) {
if (caller.getType() == Account.ACCOUNT_TYPE_NORMAL) {
permittedAccounts.addAll(_projectMgr.listPermittedProjectAccounts(caller.getId()));
+
+//permittedAccounts can be empty when the caller is
not a part of any project (a domain account)
+if (permittedAccounts.isEmpty()) {
Review comment:
Is it possible for this `permittedAccounts` be null?
If not, the code is ok, otherwise it might be a good idea to use
`CollectionUtils.isEmpty`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] GabrielBrascher commented on issue #2320: Hotfixes to make 4.10 work
GabrielBrascher commented on issue #2320: Hotfixes to make 4.10 work URL: https://github.com/apache/cloudstack/pull/2320#issuecomment-349729896 Thanks for the PR @bwsw. Can you please create a JIRA ticket for this PR and append the ticket id with PR name? > CLOUDSTACK-X: Hotfixes to make 4.10 work Additionally, the description `This PR implements several fixes which are vital for CS 4.10 to work` doesn't tell much about this PR. Can you please provide more details? You can describe fixed bug(s), code improvements that have been done, etc. Such documentation helps us keeping track of issues and PRs; thus, we can detect what is already being handled. For instance, PR #2355 (avoid sending a null IPv6 address to Security Group Python script) tackles a problem already handled by this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9
blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-349729490 Trillian test result (tid-1736) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 99133 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1736-vmware-55u3.zip Test /marvin/tests/smoke/test_accounts.py took 2221 seconds Test /marvin/tests/smoke/test_affinity_groups_projects.py took 421 seconds Test /marvin/tests/smoke/test_affinity_groups.py took 268 seconds Test /marvin/tests/smoke/test_certauthority_root.py took 44 seconds Test /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py took 501 seconds Test /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py took 6 seconds Test /marvin/tests/smoke/test_deploy_vm_iso.py took 244 seconds Test /marvin/tests/smoke/test_deploy_vm_root_resize.py took 158 seconds Test /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py took 674 seconds Test /marvin/tests/smoke/test_deploy_vm_with_userdata.py took 400 seconds Test /marvin/tests/smoke/test_disk_offerings.py took 5 seconds Test /marvin/tests/smoke/test_dynamicroles.py took 115 seconds Test /marvin/tests/smoke/test_global_settings.py took 5 seconds Test /marvin/tests/smoke/test_guest_vlan_range.py took 26 seconds Test /marvin/tests/smoke/test_host_annotations.py took 14 seconds Test /marvin/tests/smoke/test_hostha_simulator.py took 6 seconds Test /marvin/tests/smoke/test_host_maintenance.py took 772 seconds Test /marvin/tests/smoke/test_internal_lb.py took 16104 seconds Test /marvin/tests/smoke/test_iso.py took 278 seconds Test /marvin/tests/smoke/test_list_ids_parameter.py took 1883 seconds Test /marvin/tests/smoke/test_loadbalance.py took 2814 seconds Test /marvin/tests/smoke/test_login.py took 25 seconds Test /marvin/tests/smoke/test_metrics_api.py took 367 seconds Test /marvin/tests/smoke/test_multipleips_per_nic.py took 268 seconds Test /marvin/tests/smoke/test_nested_virtualization.py took 415 seconds Test /marvin/tests/smoke/test_network_acl.py took 364 seconds Test /marvin/tests/smoke/test_network.py took 3628 seconds Test /marvin/tests/smoke/test_nic_adapter_type.py took 12 seconds Test /marvin/tests/smoke/test_nic.py took 1676 seconds Test /marvin/tests/smoke/test_non_contigiousvlan.py took 21 seconds Test /marvin/tests/smoke/test_outofbandmanagement_nestedplugin.py took 93 seconds Test /marvin/tests/smoke/test_outofbandmanagement.py took 230 seconds Test /marvin/tests/smoke/test_over_provisioning.py took 5 seconds Test /marvin/tests/smoke/test_password_server.py took 500 seconds Test /marvin/tests/smoke/test_portable_publicip.py took 58 seconds Test /marvin/tests/smoke/test_portforwardingrules.py took 355 seconds Test /marvin/tests/smoke/test_primary_storage.py took 1098 seconds Test /marvin/tests/smoke/test_privategw_acl.py took 2634 seconds Test /marvin/tests/smoke/test_projects.py took 865 seconds Test /marvin/tests/smoke/test_public_ip_range.py took 11 seconds Test /marvin/tests/smoke/test_pvlan.py took 10 seconds Test /marvin/tests/smoke/test_regions.py took 6 seconds Test /marvin/tests/smoke/test_reset_vm_on_reboot.py took 420 seconds Test /marvin/tests/smoke/test_resource_detail.py took 16 seconds Test /marvin/tests/smoke/test_router_dhcphosts.py took 1491 seconds Test /marvin/tests/smoke/test_router_dns.py took 366 seconds Test /marvin/tests/smoke/test_router_dnsservice.py took 395 seconds Test /marvin/tests/smoke/test_routers_iptables_default_policy.py took 1605 seconds Test /marvin/tests/smoke/test_routers_network_ops.py took 3760 seconds Test /marvin/tests/smoke/test_routers.py took 800 seconds Test /marvin/tests/smoke/test_scale_vm.py took 438 seconds Test /marvin/tests/smoke/test_secondary_storage.py took 6 seconds Test /marvin/tests/smoke/test_service_offerings.py took 497 seconds Test /marvin/tests/smoke/test_snapshots.py took 390 seconds Test /marvin/tests/smoke/test_ssvm.py took 1142 seconds Test /marvin/tests/smoke/test_staticroles.py took 5 seconds Test /marvin/tests/smoke/test_templates.py took 2172 seconds Test /marvin/tests/smoke/test_usage_events.py took 5 seconds Test /marvin/tests/smoke/test_usage.py took 3223 seconds Test /marvin/tests/smoke/test_vm_life_cycle.py took 3197 seconds Test /marvin/tests/smoke/test_vm_snapshots.py took 1677 seconds Test /marvin/tests/smoke/test_volumes.py took 707 seconds Test /marvin/tests/smoke/test_vpc_redundant.py took 13551 seconds Test /marvin/tests/smoke/test_vpc_router_nics.py took 7245 seconds Test /marvin/tests/smoke/test_vpc_vpn.py took 14599 seconds Test /marvin/tests/smoke/test_hostha_kvm.py took 13 seconds Test completed. 51 look OK, 15 have error(s) T
[GitHub] blueorangutan commented on issue #2355: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python scr?
blueorangutan commented on issue #2355: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python scr? URL: https://github.com/apache/cloudstack/pull/2355#issuecomment-349725092 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2355: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python scr?
rhtyd commented on issue #2355: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python scr? URL: https://github.com/apache/cloudstack/pull/2355#issuecomment-349724914 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2355: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python scr?
blueorangutan commented on issue #2355: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python scr? URL: https://github.com/apache/cloudstack/pull/2355#issuecomment-349721192 Packaging result: ?centos6 ?centos7 ?debian. JID-1350 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9
blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-349721189 Packaging result: ?centos6 ?centos7 ?debian. JID-1349 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage
blueorangutan commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage URL: https://github.com/apache/cloudstack/pull/1709#issuecomment-349720045 Packaging result: ?centos6 ?centos7 ?debian. JID-1348 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2355: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python scr?
blueorangutan commented on issue #2355: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python scr? URL: https://github.com/apache/cloudstack/pull/2355#issuecomment-349712175 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2355: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python scr?
rhtyd commented on issue #2355: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python scr? URL: https://github.com/apache/cloudstack/pull/2355#issuecomment-349711855 LGTM. @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2355: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python scr?
rhtyd commented on a change in pull request #2355: CLOUDSTACK-10177: Only pass
IPv6 address to Security Group Python scr?
URL: https://github.com/apache/cloudstack/pull/2355#discussion_r155301499
##
File path:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##
@@ -3478,7 +3478,9 @@ public boolean addNetworkRules(final String vmName,
final String vmId, final Str
cmd.add("--vmname", vmName);
cmd.add("--vmid", vmId);
cmd.add("--vmip", guestIP);
-cmd.add("--vmip6", guestIP6);
+if (StringUtils.isNotBlank(guestIP6)) {
Review comment:
@wido Can you use `!String.isNullOrEmpty()` instead?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rhtyd commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage
rhtyd commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage URL: https://github.com/apache/cloudstack/pull/1709#issuecomment-349710332 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage
blueorangutan commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage URL: https://github.com/apache/cloudstack/pull/1709#issuecomment-349710387 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #1762: CLOUDSTACK-9595 Transactions are not getting retried in case of datab?
blueorangutan commented on issue #1762: CLOUDSTACK-9595 Transactions are not getting retried in case of datab? URL: https://github.com/apache/cloudstack/pull/1762#issuecomment-349701211 Trillian test result (tid-1738) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28467 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1762-t1738-kvm-centos7.zip Test /marvin/tests/smoke/test_accounts.py took 1328 seconds Test /marvin/tests/smoke/test_affinity_groups_projects.py took 203 seconds Test /marvin/tests/smoke/test_affinity_groups.py took 96 seconds Test /marvin/tests/smoke/test_certauthority_root.py took 47 seconds Test /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py took 6 seconds Test /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py took 804 seconds Test /marvin/tests/smoke/test_deploy_vm_iso.py took 81 seconds Test /marvin/tests/smoke/test_deploy_vm_root_resize.py took 107 seconds Test /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py took 213 seconds Test /marvin/tests/smoke/test_deploy_vm_with_userdata.py took 92 seconds Test /marvin/tests/smoke/test_disk_offerings.py took 5 seconds Test /marvin/tests/smoke/test_dynamicroles.py took 109 seconds Test /marvin/tests/smoke/test_global_settings.py took 6 seconds Test /marvin/tests/smoke/test_guest_vlan_range.py took 26 seconds Test /marvin/tests/smoke/test_host_annotations.py took 13 seconds Test /marvin/tests/smoke/test_hostha_simulator.py took 6 seconds Test /marvin/tests/smoke/test_host_maintenance.py took 323 seconds Test /marvin/tests/smoke/test_hosts.py took 5 seconds Test /marvin/tests/smoke/test_internal_lb.py took 1246 seconds Test /marvin/tests/smoke/test_iso.py took 244 seconds Test /marvin/tests/smoke/test_list_ids_parameter.py took 561 seconds Test /marvin/tests/smoke/test_loadbalance.py took 653 seconds Test /marvin/tests/smoke/test_login.py took 24 seconds Test /marvin/tests/smoke/test_metrics_api.py took 79 seconds Test /marvin/tests/smoke/test_multipleips_per_nic.py took 103 seconds Test /marvin/tests/smoke/test_nested_virtualization.py took 12 seconds Test /marvin/tests/smoke/test_network_acl.py took 127 seconds Test /marvin/tests/smoke/test_network.py took 1359 seconds Test /marvin/tests/smoke/test_nic_adapter_type.py took 11 seconds Test /marvin/tests/smoke/test_nic.py took 494 seconds Test /marvin/tests/smoke/test_non_contigiousvlan.py took 20 seconds Test /marvin/tests/smoke/test_outofbandmanagement_nestedplugin.py took 87 seconds Test /marvin/tests/smoke/test_outofbandmanagement.py took 247 seconds Test /marvin/tests/smoke/test_over_provisioning.py took 5 seconds Test /marvin/tests/smoke/test_password_server.py took 216 seconds Test /marvin/tests/smoke/test_portable_publicip.py took 52 seconds Test /marvin/tests/smoke/test_portforwardingrules.py took 112 seconds Test /marvin/tests/smoke/test_primary_storage.py took 429 seconds Test /marvin/tests/smoke/test_privategw_acl.py took 763 seconds Test /marvin/tests/smoke/test_projects.py took 513 seconds Test /marvin/tests/smoke/test_public_ip_range.py took 11 seconds Test /marvin/tests/smoke/test_pvlan.py took 11 seconds Test /marvin/tests/smoke/test_regions.py took 6 seconds Test /marvin/tests/smoke/test_reset_vm_on_reboot.py took 294 seconds Test /marvin/tests/smoke/test_resource_detail.py took 16 seconds Test /marvin/tests/smoke/test_router_dhcphosts.py took 331 seconds Test /marvin/tests/smoke/test_router_dns.py took 165 seconds Test /marvin/tests/smoke/test_router_dnsservice.py took 201 seconds Test /marvin/tests/smoke/test_routers_iptables_default_policy.py took 324 seconds Test /marvin/tests/smoke/test_routers_network_ops.py took 920 seconds Test /marvin/tests/smoke/test_routers.py took 256 seconds Test /marvin/tests/smoke/test_scale_vm.py took 5 seconds Test /marvin/tests/smoke/test_secondary_storage.py took 5 seconds Test /marvin/tests/smoke/test_service_offerings.py took 312 seconds Test /marvin/tests/smoke/test_snapshots.py took 235 seconds Test /marvin/tests/smoke/test_ssvm.py took 818 seconds Test /marvin/tests/smoke/test_staticroles.py took 5 seconds Test /marvin/tests/smoke/test_templates.py took 1190 seconds Test /marvin/tests/smoke/test_usage_events.py took 5 seconds Test /marvin/tests/smoke/test_usage.py took 1523 seconds Test /marvin/tests/smoke/test_vm_life_cycle.py took 751 seconds Test /marvin/tests/smoke/test_vm_snapshots.py took 632 seconds Test /marvin/tests/smoke/test_volumes.py took 2180 seconds Test /marvin/tests/smoke/test_vpc_redundant.py took 3155 seconds Test /marvin/tests/smoke/test_vpc_router_nics.py took 716 seconds Test /marvin/tests/smoke/test_vpc_vpn.py took 684 seconds Test /marvin/tests/smoke/test_hostha_kvm.py took 620 seconds Test
[GitHub] borisstoyanov commented on issue #2301: CLOUDSTACK-10121 moveUser
borisstoyanov commented on issue #2301: CLOUDSTACK-10121 moveUser URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-349692791 @DaanHoogland I think I did a bit of mess here, should we do some cherry picking to resolve this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bwsw commented on issue #2355: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python scr?
bwsw commented on issue #2355: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python scr? URL: https://github.com/apache/cloudstack/pull/2355#issuecomment-349687296 @GabrielBrascher @wido Also, this fix already present in previous PRs in broader edition, because I cherry picked it to #2320 from somewhere. Also, please take a look at security_groups.py because there are still cases when ICMPv6 can lead to exceptions without proper handling. E.g. passing -1,-1 for icmp v6 SG. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bwsw commented on issue #2355: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python scr?
bwsw commented on issue #2355: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python scr? URL: https://github.com/apache/cloudstack/pull/2355#issuecomment-349687296 @GabrielBrascher @wido Also, this fix already introduced somewhere in previous PRs in broader edition, because I cherry picked it to #2320 from somewhere. Also, please take a look at security_groups.py because there are still cases when ICMPv6 can lead to exceptions without proper handling. E.g. passing -1,-1 for icmp v6 SG. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on issue #2355: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python scr?
GabrielBrascher commented on issue #2355: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python scr? URL: https://github.com/apache/cloudstack/pull/2355#issuecomment-349685684 Thanks for pointing out PR #2320 @bwsw. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bwsw commented on issue #2355: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python scr?
bwsw commented on issue #2355: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python scr? URL: https://github.com/apache/cloudstack/pull/2355#issuecomment-349684938 @wido @GabrielBrascher Hi, take a look here. Massive fixes to make 4.10 work. Includes this fix and other ipv6 mods. https://github.com/apache/cloudstack/pull/2320 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage
blueorangutan commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage URL: https://github.com/apache/cloudstack/pull/1709#issuecomment-349678250 Packaging result: ?centos6 ?centos7 ?debian. JID-1347 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wido opened a new pull request #2355: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python scr?
wido opened a new pull request #2355: CLOUDSTACK-10177: Only pass IPv6 address to Security Group Python scr? URL: https://github.com/apache/cloudstack/pull/2355 ?ipt if present Otherwise we send down a 'null' to a ProcessBuilder in Java instead of a String and this causes a NPE. We should check first if the Instance has a IPv6 address before sending it there. Signed-off-by: Wido den Hollander This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage
blueorangutan commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage URL: https://github.com/apache/cloudstack/pull/1709#issuecomment-349671194 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage
DaanHoogland commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage URL: https://github.com/apache/cloudstack/pull/1709#issuecomment-349671045 I see @marcaurele I will investigate the marvin error. the other one i a plain compilation error though: ``` /home/travis/build/apache/cloudstack/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java:[3842,19] error: no suitable constructor found for MigrateWithStorageAnswer(MigrateWithStorageCommand,List) [ERROR] constructor MigrateWithStorageAnswer.MigrateWithStorageAnswer(MigrateWithStorageCommand,boolean,boolean,Exception) is not applicable (actual and formal argument lists differ in length) constructor MigrateWithStorageAnswer.MigrateWithStorageAnswer(MigrateWithStorageCommand,List,boolean,String) is not applicable (actual and formal argument lists differ in length) /home/travis/build/apache/cloudstack/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java:[3851,19] error: no suitable constructor found for MigrateWithStorageAnswer(MigrateWithStorageCommand,Exception) ``` @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcaurele commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage
marcaurele commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage URL: https://github.com/apache/cloudstack/pull/1709#issuecomment-34968 @DaanHoogland I know about those failures, but I cannot access the mgmt logs to get the error/exception. And since we're not using upstream, I cannot run this version in our test lab either to debug it. I would appreciate if anyone can post the proper exception thrown during those failed tests. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2301: CLOUDSTACK-10121 moveUser
DaanHoogland commented on issue #2301: CLOUDSTACK-10121 moveUser URL: https://github.com/apache/cloudstack/pull/2301#issuecomment-349619415 @borisstoyanov yes that might well be the only answer, sorry. Do you still have it locally? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage
DaanHoogland commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage URL: https://github.com/apache/cloudstack/pull/1709#issuecomment-349618998 @marcaurele in travis there is a unit test and a marvin test failing, both concerning migration. Can you have a look? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage
DaanHoogland commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage URL: https://github.com/apache/cloudstack/pull/1709#issuecomment-349614207 I appreciate that @marcaurele. The issue with shared storage is that, when it is cluster wide, migration *may or may not* still have to include volumes. So either of the call will have to include the check if the target can reach the storage in use and then delegate to the other API based on the outcome of that check. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2353: CLOUDSTACK-9986: Use host table to iterate for zone/cluster metrics
rhtyd commented on issue #2353: CLOUDSTACK-9986: Use host table to iterate for zone/cluster metrics URL: https://github.com/apache/cloudstack/pull/2353#issuecomment-349611391 The changes are specific to metrics plugin, Travis test results are sufficient to validate the change. Please review - @DaanHoogland @nvazquez @borisstoyanov and others. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2353: CLOUDSTACK-9986: Use host table to iterate for zone/cluster metrics
blueorangutan commented on issue #2353: CLOUDSTACK-9986: Use host table to iterate for zone/cluster metrics URL: https://github.com/apache/cloudstack/pull/2353#issuecomment-349607851 Packaging result: ?centos6 ?centos7 ?debian. JID-1346 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2318: [4.9] Smoketest health checkrun baseline
blueorangutan commented on issue #2318: [4.9] Smoketest health checkrun baseline URL: https://github.com/apache/cloudstack/pull/2318#issuecomment-349607645 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2318: [4.9] Smoketest health checkrun baseline
rhtyd commented on issue #2318: [4.9] Smoketest health checkrun baseline URL: https://github.com/apache/cloudstack/pull/2318#issuecomment-349607529 @blueorangutan test centos7 vmware-55u3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] niteshsarda opened a new pull request #2354: CLOUDSTACK-10176:VM Start Api Job returns success for failed Job
niteshsarda opened a new pull request #2354: CLOUDSTACK-10176:VM Start Api Job returns success for failed Job URL: https://github.com/apache/cloudstack/pull/2354 **ISSUE :** VM start API Job returns success for failed Job **STEPS TO REPRODUCE :** 1. Stop VM instance. 2. Mark state of associate router as Stopping from DB 3. Execute startVirtualMachine Api from rest client. 4. VM will not start but still main job will return the status as SUCCEEDED, whereas sub-job for command VmWorkStart will return status as failed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2353: CLOUDSTACK-9986: Use host table to iterate for zone/cluster metrics
blueorangutan commented on issue #2353: CLOUDSTACK-9986: Use host table to iterate for zone/cluster metrics URL: https://github.com/apache/cloudstack/pull/2353#issuecomment-349601932 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd opened a new pull request #2353: CLOUDSTACK-9986:: Use host table to iterate for zone/cluster metrics
rhtyd opened a new pull request #2353: CLOUDSTACK-9986:: Use host table to iterate for zone/cluster metrics URL: https://github.com/apache/cloudstack/pull/2353 The host_view may contain duplicate entries when hosts have tags. Changing the host_view may cause unseen regressions so to fix the issues we've modified the zone/cluster metrics code to use the `host` table (hostdao) to iterate through the list of hosts in a cluster during zone/cluster metrics listing. @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #1762: CLOUDSTACK-9595 Transactions are not getting retried in case of datab?
blueorangutan commented on issue #1762: CLOUDSTACK-9595 Transactions are not getting retried in case of datab? URL: https://github.com/apache/cloudstack/pull/1762#issuecomment-349574859 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #1762: CLOUDSTACK-9595 Transactions are not getting retried in case of datab?
rhtyd commented on issue #1762: CLOUDSTACK-9595 Transactions are not getting retried in case of datab? URL: https://github.com/apache/cloudstack/pull/1762#issuecomment-349574707 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #1762: CLOUDSTACK-9595 Transactions are not getting retried in case of datab?
blueorangutan commented on issue #1762: CLOUDSTACK-9595 Transactions are not getting retried in case of datab? URL: https://github.com/apache/cloudstack/pull/1762#issuecomment-349574582 Packaging result: ?centos6 ?centos7 ?debian. JID-1345 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #1762: CLOUDSTACK-9595 Transactions are not getting retried in case of datab?
blueorangutan commented on issue #1762: CLOUDSTACK-9595 Transactions are not getting retried in case of datab? URL: https://github.com/apache/cloudstack/pull/1762#issuecomment-349569113 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #1762: CLOUDSTACK-9595 Transactions are not getting retried in case of datab?
rhtyd commented on issue #1762: CLOUDSTACK-9595 Transactions are not getting retried in case of datab? URL: https://github.com/apache/cloudstack/pull/1762#issuecomment-349569004 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
