[GitHub] greut commented on issue #2392: dateutil: constistency of tzdate input and output

[GitBox]

greut commented on issue #2392: dateutil: constistency of tzdate input and 
output
URL: https://github.com/apache/cloudstack/pull/2392#issuecomment-367932264
 
 
   @rafaelweingartner after a rebase, the only thing I see is _The job exceeded 
the maximum time limit for jobs, and has been terminated._


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] niteshsarda commented on issue #2451: CLOUDSTACK-10284:Creating a snapshot from VM Snapshot generates error if hypervisor is not KVM.

[GitBox]

niteshsarda commented on issue #2451: CLOUDSTACK-10284:Creating a snapshot from 
VM Snapshot generates error if hypervisor is not KVM.
URL: https://github.com/apache/cloudstack/pull/2451#issuecomment-367904712
 
 
   @rhtyd @rafaelweingartner  : As there are issues in rebasing against 4.11, I 
am fine if we put it in master and make this fix available in next release.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2454: CLOUDSTACK-10283: Sudo to setup agent keystore, fail on host add failure

[GitBox]

blueorangutan commented on issue #2454: CLOUDSTACK-10283: Sudo to setup agent 
keystore, fail on host add failure
URL: https://github.com/apache/cloudstack/pull/2454#issuecomment-367856506
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1731


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering

[GitBox]

rafaelweingartner commented on issue #2231: [CLOUDSTACK-10039] Adding IOPS/GB 
offering
URL: https://github.com/apache/cloudstack/pull/2231#issuecomment-367855144
 
 
   Ping @syed 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2271: CLOUDSTACK-10087 Template registration errors out when template URL i?

[GitBox]

rafaelweingartner commented on issue #2271: CLOUDSTACK-10087 Template 
registration errors out when template URL i?
URL: https://github.com/apache/cloudstack/pull/2271#issuecomment-367854738
 
 
   Ping @SudharmaJain 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2244: CLOUDSTACK-10054:Volume download times out in 3600 seconds

[GitBox]

rafaelweingartner commented on issue #2244: CLOUDSTACK-10054:Volume download 
times out in 3600 seconds
URL: https://github.com/apache/cloudstack/pull/2244#issuecomment-367854564
 
 
   @DaanHoogland and @rhtyd what are your stances here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2275: CLOUDSTACK-9975: Allow customizing system VM templates for SSVM and Console Proxy

[GitBox]

rafaelweingartner commented on issue #2275: CLOUDSTACK-9975: Allow customizing 
system VM templates for SSVM and Console Proxy
URL: https://github.com/apache/cloudstack/pull/2275#issuecomment-367854135
 
 
   @GabrielBrascher can you rebase and fix conflicts?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2392: dateutil: constistency of tzdate input and output

[GitBox]

rafaelweingartner commented on issue #2392: dateutil: constistency of tzdate 
input and output
URL: https://github.com/apache/cloudstack/pull/2392#issuecomment-367853792
 
 
   @greut can you take a look into travis failures?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2400: CLOUDSTACK-8900 listLdapUsers with listType=new only filters users for logged-in user account

[GitBox]

rafaelweingartner commented on issue #2400: CLOUDSTACK-8900 listLdapUsers with 
listType=new only filters users for logged-in user account
URL: https://github.com/apache/cloudstack/pull/2400#issuecomment-367853649
 
 
   Ping @SudharmaJain 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary?

[GitBox]

rafaelweingartner commented on issue #2412: CLOUDSTACK-9677: Adding storage 
policy support for swift as secondary?
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-367853242
 
 
   @khos2ow can you provide some inputs regarding @rhtyd inquiry? 
   This one is ready to go.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2422: [CLOUDSTACK-10254] checkstyle: add package name declaration validation

[GitBox]

rafaelweingartner commented on issue #2422: [CLOUDSTACK-10254] checkstyle: add 
package name declaration validation
URL: https://github.com/apache/cloudstack/pull/2422#issuecomment-367852939
 
 
   Ok, no problem. Can you look into travis errors?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2428: CLOUDSTACK-10253: JSON response for SuccessResponse as boolean instead of string

[GitBox]

rafaelweingartner commented on issue #2428: CLOUDSTACK-10253: JSON response for 
SuccessResponse as boolean instead of string
URL: https://github.com/apache/cloudstack/pull/2428#issuecomment-367852746
 
 
   @marcaurele there are some tests using an assert with a string `'true'`, and 
not a Boolean.
   Can you fix them?
   
   ```
   
"/home/travis/build/apache/cloudstack/test/integration/smoke/test_hostha_simulator.py",
 line 164, in configureSimulatorHAProviderState
   self.assertEqual(response.success, 'true')
   ```
   
   There are others, but that is only one example.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance 
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-367851868
 
 
   @rhtyd what is your stance here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] annotated tag 4.8.2.0 updated (4a1f7ed -> 8c948ac)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to annotated tag 4.8.2.0
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


*** WARNING: tag 4.8.2.0 was modified! ***

from 4a1f7ed  (commit)
  to 8c948ac  (tag)
 tagging 4a1f7ed8bc51d859c5e0e5b9c3ad513752ff8c40 (commit)
 replaces 4.8.0
  by Rohit Yadav
  on Sat Dec 10 08:32:22 2016 +0530

- Log -
Tagging release 4.8.2.0 on branch 4.8.
-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQIcBAABAgAGBQJYS3A+AAoJEEhCSCEO49iETJAQAJ+NJ3q5PokXXB50HUjtDsh3
3iL9H1CB/OJaKMr9IO3MFzWjzc7OvfmSuwu0Tp70bQGqnor93ObQo+cBlv/6tN7r
jz/l/lZBdjvXJaMplVktbKGDLATzxyxzGYkk+1Z87YYOEY3LG/eP3omM4ah5F4Cw
hWgLhwXsNuWuiCQT+VPEAdTJtqN3wNZbUnGDM1NPBXIo+izeQifNFNt4n50jFqIb
DoFLfIXfzlFC6uJjq8sLWFN9hZHDNc3/KnvpcgF5mVUU2YGJUvgUpz85KVaHlgvR
H8zgJ0UfdQCteefv1B02NbadiMdwYZkKhst1dl/EukZn6huOAR0odpSC7kcmMkLF
QS5IVmMZfKw0Tfhwl9adMswgNMyRb2zW036/8aFxJJFfqxeGQhyuvrCIrfF8XFhZ
j/imMLQ7VSdAKiA5a8F/Vla8hhukQ1L9QrE+aGFYU1LlJqjGRoqUZR7bONzK64MB
Eid7XDj8JG2THKx4EpFmGeKSDotkrbaix4OQYKRLQjYLMBZA3p9ElyIEcaQ7a2XD
GzL/WJKoXAnTSfYUAGlLUw7u5RF/UUv1j42y9lVsl7lEuDTy3vpNqvrcLnPEnsmG
thxt9ObdzJQn3rnPUXh+FfEy8YvSDaAhKcgfT0rqyOe3rDtRtGMPleaFhGn2XeU1
xWjOHo3TdbBADDhbWoJX
=6AG4
-END PGP SIGNATURE-
---


No new revisions were added by this update.

Summary of changes:

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[cloudstack] annotated tag portgroup_no_gc_tag updated (9a8841d -> ffe8428)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to annotated tag portgroup_no_gc_tag
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


*** WARNING: tag portgroup_no_gc_tag was modified! ***

from 9a8841d  (commit)
  to ffe8428  (tag)
 tagging 9a8841d0d9a9e6ad51846d527127ea0175029746 (commit)
 replaces 4.8.0
  by Murali Reddy
  on Thu Dec 15 23:48:34 2016 +0530

- Log -
do not gc tag port group
---


No new revisions were added by this update.

Summary of changes:

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[cloudstack] annotated tag 4.9.1-RC1 updated (af26799 -> 2d788ee)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to annotated tag 4.9.1-RC1
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


*** WARNING: tag 4.9.1-RC1 was modified! ***

from af26799  (commit)
  to 2d788ee  (tag)
 tagging af2679959b634d095b93b8265c6da294d360065d (commit)
 replaces portgroup_no_gc_tag
  by Boris
  on Mon Dec 12 15:44:56 2016 +0200

- Log -
4.9.1-RC1
---


No new revisions were added by this update.

Summary of changes:

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[GitHub] blueorangutan commented on issue #2454: CLOUDSTACK-10283: Sudo to setup agent keystore, fail on host add failure

[GitBox]

blueorangutan commented on issue #2454: CLOUDSTACK-10283: Sudo to setup agent 
keystore, fail on host add failure
URL: https://github.com/apache/cloudstack/pull/2454#issuecomment-367848555
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] 01/01: Merge pull request #2454 from shapeblue/keystore-utils-sudoer

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit cae32925608815f7defa76621ed9c6a23fab1cef
Merge: 264036b f1cf5f9
Author: Rafael Weingärtner 
AuthorDate: Thu Feb 22 19:44:24 2018 -0300

Merge pull request #2454 from shapeblue/keystore-utils-sudoer

CLOUDSTACK-10283: Sudo to setup agent keystore, fail on host add failure

 agent/src/com/cloud/agent/Agent.java|  4 ++--
 .../kvm/discoverer/LibvirtServerDiscoverer.java | 17 +++--
 2 files changed, 9 insertions(+), 12 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[GitHub] rafaelweingartner closed pull request #2454: CLOUDSTACK-10283: Sudo to setup agent keystore, fail on host add failure

[GitBox]

rafaelweingartner closed pull request #2454: CLOUDSTACK-10283: Sudo to setup 
agent keystore, fail on host add failure
URL: https://github.com/apache/cloudstack/pull/2454
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/agent/src/com/cloud/agent/Agent.java 
b/agent/src/com/cloud/agent/Agent.java
index d2669c03aeb..1c5417bf767 100644
--- a/agent/src/com/cloud/agent/Agent.java
+++ b/agent/src/com/cloud/agent/Agent.java
@@ -647,7 +647,7 @@ public Answer setupAgentKeystore(final SetupKeyStoreCommand 
cmd) {
 _shell.setPersistentProperty(null, 
KeyStoreUtils.passphrasePropertyName, storedPassword);
 }
 
-Script script = new Script(_keystoreSetupPath, 6, s_logger);
+Script script = new Script(true, _keystoreSetupPath, 6, s_logger);
 script.add(agentFile.getAbsolutePath());
 script.add(keyStoreFile);
 script.add(storedPassword);
@@ -691,7 +691,7 @@ private Answer setupAgentCertificate(final 
SetupCertificateCommand cmd) {
 throw new CloudRuntimeException("Unable to save received agent 
client and ca certificates", e);
 }
 
-Script script = new Script(_keystoreCertImportPath, 6, s_logger);
+Script script = new Script(true, _keystoreCertImportPath, 6, 
s_logger);
 script.add(agentFile.getAbsolutePath());
 script.add(keyStoreFile);
 script.add(KeyStoreUtils.agentMode);
diff --git 
a/server/src/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java 
b/server/src/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java
index 63a44b83518..c1afc9a6f88 100644
--- 
a/server/src/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java
+++ 
b/server/src/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java
@@ -62,6 +62,7 @@
 import com.cloud.resource.UnableDeleteHostException;
 import com.cloud.utils.PasswordGenerator;
 import com.cloud.utils.StringUtils;
+import com.cloud.utils.exception.CloudRuntimeException;
 import com.cloud.utils.ssh.SSHCmdHelper;
 import com.trilead.ssh2.Connection;
 
@@ -144,8 +145,7 @@ private void setupAgentSecurity(final Connection 
sshConnection, final String age
 }
 
 if (sshConnection == null) {
-s_logger.warn("Cannot secure agent communication because ssh 
connection is invalid for host ip=" + agentIp);
-return;
+throw new CloudRuntimeException("Cannot secure agent communication 
because ssh connection is invalid for host ip=" + agentIp);
 }
 
 Integer validityPeriod = CAManager.CertValidityPeriod.value();
@@ -154,7 +154,7 @@ private void setupAgentSecurity(final Connection 
sshConnection, final String age
 }
 
 final SSHCmdHelper.SSHCmdResult keystoreSetupResult = 
SSHCmdHelper.sshExecuteCmdWithResult(sshConnection,
-String.format("/usr/share/cloudstack-common/scripts/util/%s " +
+String.format("sudo 
/usr/share/cloudstack-common/scripts/util/%s " +
 "/etc/cloudstack/agent/agent.properties " +
 "/etc/cloudstack/agent/%s " +
 "%s %d " +
@@ -166,19 +166,17 @@ private void setupAgentSecurity(final Connection 
sshConnection, final String age
 KeyStoreUtils.defaultCsrFile));
 
 if (!keystoreSetupResult.isSuccess()) {
-s_logger.error("Failing, the keystore setup script failed 
execution on the KVM host: " + agentIp);
-return;
+throw new CloudRuntimeException("Failed to setup keystore on the 
KVM host: " + agentIp);
 }
 
 final Certificate certificate = 
caManager.issueCertificate(keystoreSetupResult.getStdOut(), 
Collections.singletonList(agentHostname), Collections.singletonList(agentIp), 
null, null);
 if (certificate == null || certificate.getClientCertificate() == null) 
{
-s_logger.error("Failing, the configured CA plugin failed to issue 
certificates for KVM host agent: " + agentIp);
-return;
+throw new CloudRuntimeException("Failed to issue certificates for 
KVM host agent: " + agentIp);
 }
 
 final SetupCertificateCommand certificateCommand = new 
SetupCertificateCommand(certificate);
 final SSHCmdHelper.SSHCmdResult setupCertResult = 
SSHCmdHelper.sshExecuteCmdWithResult(sshConnection,
-
String.format("/usr/share/cloudstack-common/scripts/util/%s " +
+String.format("sudo 
/usr/share/cloudstack-common/scripts/util/%s " +
 "/etc/cloudstack/agent/agent.properties " +
 "/etc/cloudstack/agent/%s %s " +
   

[cloudstack] branch 4.11 updated (264036b -> cae3292)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 264036b  Merge pull request #2402 from 
rafaelweingartner/fixCLOUDSTACK-10128
 add f1cf5f9  CLOUDSTACK-10283: Sudo to setup agent keystore, fail on host 
add failure
 new cae3292  Merge pull request #2454 from shapeblue/keystore-utils-sudoer

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 agent/src/com/cloud/agent/Agent.java|  4 ++--
 .../kvm/discoverer/LibvirtServerDiscoverer.java | 17 +++--
 2 files changed, 9 insertions(+), 12 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[GitHub] rafaelweingartner commented on issue #2454: CLOUDSTACK-10283: Sudo to setup agent keystore, fail on host add failure

[GitBox]

rafaelweingartner commented on issue #2454: CLOUDSTACK-10283: Sudo to setup 
agent keystore, fail on host add failure
URL: https://github.com/apache/cloudstack/pull/2454#issuecomment-367848375
 
 
   Tests and reviews are ok. I will merge this one then.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner closed pull request #2457: CLOUDSTACK-10295 Marvin: add support for password-enabled templates

[GitBox]

rafaelweingartner closed pull request #2457: CLOUDSTACK-10295 Marvin: add 
support for password-enabled templates
URL: https://github.com/apache/cloudstack/pull/2457
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/tools/marvin/marvin/lib/base.py b/tools/marvin/marvin/lib/base.py
index 23621991cc2..e0253896271 100755
--- a/tools/marvin/marvin/lib/base.py
+++ b/tools/marvin/marvin/lib/base.py
@@ -593,6 +593,10 @@ def create(cls, apiclient, services, templateid=None, 
accountid=None,
 
 virtual_machine = apiclient.deployVirtualMachine(cmd, method=method)
 
+if 'password' in virtual_machine.__dict__.keys():
+if virtual_machine.password:
+services['password'] = virtual_machine.password
+
 virtual_machine.ssh_ip = virtual_machine.nic[0].ipaddress
 if startvm is False:
 virtual_machine.public_ip = virtual_machine.nic[0].ipaddress


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated (e9da30b -> 06c2948)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from e9da30b  Merge pull request #2456 from 
rafaelweingartner/CLOUDSTACK-10293
 add eeba3e4  CLOUDSTACK-10295 Marvin: add support for password-enabled 
templates
 new 06c2948  Merge pull request #2457 from HiagData/CLOUDSTACK-10295

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 tools/marvin/marvin/lib/base.py | 4 
 1 file changed, 4 insertions(+)

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[cloudstack] 01/01: Merge pull request #2457 from HiagData/CLOUDSTACK-10295

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 06c2948c65512e52eee26c37ee7d0650f558b658
Merge: e9da30b eeba3e4
Author: Rafael Weingärtner 
AuthorDate: Thu Feb 22 19:41:39 2018 -0300

Merge pull request #2457 from HiagData/CLOUDSTACK-10295

CLOUDSTACK-10295 Marvin: add support for password-enabled templates

 tools/marvin/marvin/lib/base.py | 4 
 1 file changed, 4 insertions(+)

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[GitHub] rafaelweingartner commented on issue #2457: CLOUDSTACK-10295 Marvin: add support for password-enabled templates

[GitBox]

rafaelweingartner commented on issue #2457: CLOUDSTACK-10295 Marvin: add 
support for password-enabled templates
URL: https://github.com/apache/cloudstack/pull/2457#issuecomment-367847724
 
 
   The tests that failed do not seem to be related to changes introduced here. 
So, the PR has integration tests, Marvin and reviews. I will merge it then.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] 01/01: Merge pull request #2456 from rafaelweingartner/CLOUDSTACK-10293

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit e9da30b24e8d4df4b22451488e459361435da80c
Merge: e532b57 a436426
Author: Rafael Weingärtner 
AuthorDate: Thu Feb 22 19:36:09 2018 -0300

Merge pull request #2456 from rafaelweingartner/CLOUDSTACK-10293

[CLOUDSTACK-10293] Single view network ACL rules listing

 ui/css/cloudstack3.css |  61 ++--
 ui/l10n/ar.js  |   5 +
 ui/l10n/ca.js  |   5 +
 ui/l10n/de_DE.js   |   5 +
 ui/l10n/en.js  |   8 +-
 ui/l10n/es.js  |   5 +
 ui/l10n/fr_FR.js   |   5 +
 ui/l10n/hu.js  |   5 +
 ui/l10n/it_IT.js   |   5 +
 ui/l10n/ja_JP.js   |   5 +
 ui/l10n/ko_KR.js   |   5 +
 ui/l10n/nb_NO.js   |   5 +
 ui/l10n/nl_NL.js   |   5 +
 ui/l10n/pl.js  |   5 +
 ui/l10n/pt_BR.js   |   5 +
 ui/l10n/ru_RU.js   |   5 +
 ui/l10n/zh_CN.js   |   5 +
 ui/scripts/ui/widgets/multiEdit.js | 300 -
 ui/scripts/vpc.js  | 295 +++-
 19 files changed, 448 insertions(+), 291 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[GitHub] rafaelweingartner closed pull request #2456: [CLOUDSTACK-10293] Single view network ACL rules listing

[GitBox]

rafaelweingartner closed pull request #2456: [CLOUDSTACK-10293] Single view 
network ACL rules listing
URL: https://github.com/apache/cloudstack/pull/2456
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ui/css/cloudstack3.css b/ui/css/cloudstack3.css
index 519778ba59b..9b4e7638001 100644
--- a/ui/css/cloudstack3.css
+++ b/ui/css/cloudstack3.css
@@ -8391,7 +8391,6 @@ div.container div.panel 
div#details-tab-addloadBalancer.detail-group div.loadBal
   border-right: 1px solid #CFC9C9;
   height: 15px;
   overflow: auto;
-  padding-right: 0;
 }
 
 .multi-edit .data .data-body .data-item > table tbody tr td span {
@@ -8426,8 +8425,44 @@ div.container div.panel 
div#details-tab-addloadBalancer.detail-group div.loadBal
   color: #FF;
 }
 
-.multi-edit .data .data-body .data-item table tbody tr td.multi-actions {
-  border-right: none;
+div#details-tab-aclRules table.multi-edit tr th.number,
+div#details-tab-aclRules div.data-item table tr td.number {
+  width: 45px !important;
+  min-width: 45px !important;
+  max-width: 45px !important;
+}
+
+div#details-tab-aclRules div.multi-edit table tr th.action,
+div#details-tab-aclRules div.multi-edit table tr td.action {
+width: 40px !important;
+min-width: 40px !important;
+max-width: 40px !important;
+}
+
+div#details-tab-aclRules div.multi-edit table tr th.protocol,
+div#details-tab-aclRules div.multi-edit table tr td.protocol {
+width: 50px !important;
+min-width: 50px !important;
+max-width: 50px !important;
+}
+
+div#details-tab-aclRules div.multi-edit table tr th.protocolnumber,
+div#details-tab-aclRules div.multi-edit table tr td.protocolnumber {
+width: 60px !important;
+min-width: 60px !important;
+max-width: 60px !important;
+}
+
+div#details-tab-aclRules div.multi-edit table tr th.startport, 
div#details-tab-aclRules div.multi-edit table tr td.startport,
+div#details-tab-aclRules div.multi-edit table tr th.endport, 
div#details-tab-aclRules div.multi-edit table tr td.endport {
+width: 70px !important;
+min-width: 70px !important;
+max-width: 70px !important;
+}
+
+div#details-tab-aclRules td.cidrlist span {
+   text-align: center;
+   width: 100%;
 }
 
 .multi-edit .data .data-body .data-item table tbody tr td.multi-actions 
.action {
@@ -8548,17 +8583,18 @@ div.container div.panel 
div#details-tab-addloadBalancer.detail-group div.loadBal
 
 .detail-view .multi-edit table tr th,
 .detail-view .multi-edit table tr td {
-  width: 87px !important;
-  min-width: 87px !important;
-  max-width: 87px !important;
+  width: 84px !important;
+  min-width: 84px !important;
+  max-width: 84px !important;
   font-size: 10px;
 }
 
 /* special case for 'Source CIDR' column - make it wide enough to fit a CIDR 
without ellipsizing*/
 .detail-view .multi-edit table tr th.cidrlist,
 .detail-view .multi-edit table tr td.cidrlist {
-  min-width: 112px !important;
-  max-width: 112px !important;
+  min-width: 118px !important;
+  max-width: 118px !important;
+  padding: 0 0 0 0;
 }
 .detail-view .multi-edit td.cidrlist input {
   width: 85%;
@@ -8615,9 +8651,9 @@ div.container div.panel 
div#details-tab-addloadBalancer.detail-group div.loadBal
 /*Sortable*/
 .multi-edit table tbody tr td.reorder,
 .multi-edit table thead tr th.reorder {
-  width: 30px !important;
-  min-width: 30px !important;
-  max-width: 30px !important;
+  width: 16px !important;
+  min-width: 16px !important;
+  max-width: 16px !important;
 }
 
 /*Security Rules*/
@@ -13037,7 +13073,7 @@ div.ui-dialog div.autoscaler div.field-group 
div.form-container form div.form-it
   -khtml-border-radius: 10px;
   border-radius: 10px;
   border-radius: 10px 10px 10px 10px;
-  background-position: -74px -162px;
+  background-position: -82px -162px;
 }
 
 .moveDrag:hover .icon {
@@ -13357,4 +13393,3 @@ div.panel.copy-template-destination-list div.list-view 
div.fixed-header{
 .multi-edit-add-list .ui-button.copytemplatecancel {
 left: 310px;
 }
-
diff --git a/ui/l10n/ar.js b/ui/l10n/ar.js
index 3b560a86e72..9c10afcea00 100644
--- a/ui/l10n/ar.js
+++ b/ui/l10n/ar.js
@@ -16,7 +16,9 @@
 // under the License.
 var dictionary = {
 "ICMP.code": "ICMP Code",
+"ICMP.code.desc": "Please specify -1 if you want to allow all ICMP codes",
 "ICMP.type": "ICMP Type",
+"ICMP.type.desc": "Please specify -1 if you want to allow all ICMP types.",
 "changed.item.properties": " ? ??",
 "confirm.enable.s3": " ?? ??  ??? ?? ??? S3 
??? .",
 "confirm.enable.swift": "Please fill in the following information to 
enable support for Swift",
@@ -367,6 +369,7 @@ var dictionary = {
 "label.add.role": "Add Role",
 "label.add.route": "? ",
 

[cloudstack] branch master updated (e532b57 -> e9da30b)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from e532b57  Forward merge #2402 merged on '4.11' branch
 add 6897155  [CLOUDSTACK-10293] Single view network ACL rules listing
 add a436426  Externalize ICMP type/code and add new ACL rule descriptions 
in property files
 new e9da30b  Merge pull request #2456 from 
rafaelweingartner/CLOUDSTACK-10293

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 ui/css/cloudstack3.css |  61 ++--
 ui/l10n/ar.js  |   5 +
 ui/l10n/ca.js  |   5 +
 ui/l10n/de_DE.js   |   5 +
 ui/l10n/en.js  |   8 +-
 ui/l10n/es.js  |   5 +
 ui/l10n/fr_FR.js   |   5 +
 ui/l10n/hu.js  |   5 +
 ui/l10n/it_IT.js   |   5 +
 ui/l10n/ja_JP.js   |   5 +
 ui/l10n/ko_KR.js   |   5 +
 ui/l10n/nb_NO.js   |   5 +
 ui/l10n/nl_NL.js   |   5 +
 ui/l10n/pl.js  |   5 +
 ui/l10n/pt_BR.js   |   5 +
 ui/l10n/ru_RU.js   |   5 +
 ui/l10n/zh_CN.js   |   5 +
 ui/scripts/ui/widgets/multiEdit.js | 300 -
 ui/scripts/vpc.js  | 295 +++-
 19 files changed, 448 insertions(+), 291 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[GitHub] rafaelweingartner commented on issue #2456: [CLOUDSTACK-10293] Single view network ACL rules listing

[GitBox]

rafaelweingartner commented on issue #2456: [CLOUDSTACK-10293] Single view 
network ACL rules listing
URL: https://github.com/apache/cloudstack/pull/2456#issuecomment-367846443
 
 
   Two LGTMs, and as it is only a change in JavaScript there is no need for the 
integration tests. I will merge this one then.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly

[GitBox]

rafaelweingartner commented on issue #2443:  [CLOUDSTACK-9338] ACS is not 
accounting resources of VMs with custom service offering properly
URL: https://github.com/apache/cloudstack/pull/2443#issuecomment-367846158
 
 
   @bwsw are you +1  here?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly

[GitBox]

blueorangutan commented on issue #2443:  [CLOUDSTACK-9338] ACS is not 
accounting resources of VMs with custom service offering properly
URL: https://github.com/apache/cloudstack/pull/2443#issuecomment-367845502
 
 
   Trillian test result (tid-2277)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 28307 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2443-t2277-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 67 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] GabrielBrascher commented on issue #2456: [CLOUDSTACK-10293] Single view network ACL rules listing

[GitBox]

GabrielBrascher commented on issue #2456: [CLOUDSTACK-10293] Single view 
network ACL rules listing
URL: https://github.com/apache/cloudstack/pull/2456#issuecomment-367841826
 
 
   Thanks, @rafaelweingartner! Code and Screenshots LGTM.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

rafaelweingartner commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR 
to run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-367841653
 
 
   @khos2ow and @pdion891 thanks for this one!
   BTW, when you mean a load test, you are only talking about reboot/reset? are 
you planning a load test in the sense of multiple VRs in the same host, to see 
how XenServer will deal with all of them using this approach?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

khos2ow commented on a change in pull request #2465: CLOUDSTACK-10232: 
SystemVMs and VR to run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#discussion_r170110155
 
 

 ##
 File path: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ##
 @@ -1368,12 +1368,23 @@ public VM createVmFromTemplate(final Connection conn, 
final VirtualMachineTO vmS
 
 final String bootArgs = vmSpec.getBootArgs();
 if (bootArgs != null && bootArgs.length() > 0) {
+// send boot args for PV instances
 String pvargs = vm.getPVArgs(conn);
 pvargs = pvargs + vmSpec.getBootArgs().replaceAll(" ", "%");
 if (s_logger.isDebugEnabled()) {
 s_logger.debug("PV args are " + pvargs);
 }
 vm.setPVArgs(conn, pvargs);
+
+// send boot args into xenstore-data for HVM instances
+Map xenstoreData = new HashMap<>();
+
+xenstoreData.put("vm-data/cloudstack/init", bootArgs);
+vm.setXenstoreData(conn, xenstoreData);
+
+if (s_logger.isDebugEnabled()) {
+s_logger.debug("HVM args are " + bootArgs);
 
 Review comment:
   Makes totally sense to me. Removed the IF condition.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2439: [CLOUDSTACK-10259] Missing float part of secondary storage data in listAccounts method

[GitBox]

rafaelweingartner commented on issue #2439: [CLOUDSTACK-10259] Missing float 
part of secondary storage data in listAccounts method
URL: https://github.com/apache/cloudstack/pull/2439#issuecomment-367838927
 
 
   Do we need to wait for the integration tests on this one?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

[GitBox]

rafaelweingartner commented on issue #2449: WIP CLOUDSTACK-10278 idempotent 
column addition
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-367838510
 
 
   Folks, what are the thoughts here? use this ad-hoc approach? Work a bit 
harder to a more comprehensive solution using a framework/system to control DB 
data model upgrades?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2466: Rare race condition in KVM migration

[GitBox]

rafaelweingartner commented on issue #2466: Rare race condition in KVM migration
URL: https://github.com/apache/cloudstack/pull/2466#issuecomment-367837741
 
 
   So, the idea to solve this rare case, is just ignore the exception that 
happens when you reach such conditions? Will everything else be ok, even if 
that exception happens? Also, if the conditions happens, you do not need to 
suspend the VM?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2451: CLOUDSTACK-10284:Creating a snapshot from VM Snapshot generates error if hypervisor is not KVM.

[GitBox]

rafaelweingartner commented on issue #2451: CLOUDSTACK-10284:Creating a 
snapshot from VM Snapshot generates error if hypervisor is not KVM.
URL: https://github.com/apache/cloudstack/pull/2451#issuecomment-367836751
 
 
   @niteshsarda can you please provide us a feedback regarding @rhtyd inquiry?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pdion891 commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

pdion891 commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as 
HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-367834144
 
 
   BTW we are doing some test of this on our side, to make sure we keep support 
of VR running as PV on legacy deployments and support now default HVM VR on 
xenserver 7.1+...
   
   So far the xenstore method work well but still need few tests under high 
workload, VR reboot, reset,...  we should have more news in a week, our QA will 
only focus on xenserver 7.1 including 7.1.1(cumulative updates)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

rafaelweingartner commented on a change in pull request #2465: 
CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#discussion_r170083404
 
 

 ##
 File path: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ##
 @@ -1368,12 +1368,23 @@ public VM createVmFromTemplate(final Connection conn, 
final VirtualMachineTO vmS
 
 final String bootArgs = vmSpec.getBootArgs();
 if (bootArgs != null && bootArgs.length() > 0) {
+// send boot args for PV instances
 String pvargs = vm.getPVArgs(conn);
 pvargs = pvargs + vmSpec.getBootArgs().replaceAll(" ", "%");
 if (s_logger.isDebugEnabled()) {
 s_logger.debug("PV args are " + pvargs);
 }
 vm.setPVArgs(conn, pvargs);
+
+// send boot args into xenstore-data for HVM instances
+Map xenstoreData = new HashMap<>();
+
+xenstoreData.put("vm-data/cloudstack/init", bootArgs);
+vm.setXenstoreData(conn, xenstoreData);
+
+if (s_logger.isDebugEnabled()) {
+s_logger.debug("HVM args are " + bootArgs);
 
 Review comment:
   What I meant is that, in a Web API drive system such as ACS, everything is 
synchronous (or almost everything). Therefore, the 1 nanoseconds of improvement 
that the use of this IF conditional can bring is negligible. This means that 
the code (the code used to create this optimization) is not worth it (in my 
perspective).
   
   I normally see people using this approach of checking log level before 
logging when creating log messages using String.format, which uses quite some 
processing. However, even in those cases, I do not see much need to check the 
log level before logging (in most cases).
   
   I just commented to give some context on the use of this isEnabled 
method. The only time I used this approach of checking log level was when I 
developed some standalone optimization algorithms that had a time constraint to 
be executed. Therefore, there was no space to waste clock cycles creating a log 
message that is not going to be used.
   
   In summary; if I were coding, I would not use it. However, we have these 
things spread all over our code base. I normally remove them, but if you want 
to use, the choice is yours.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

khos2ow commented on a change in pull request #2465: CLOUDSTACK-10232: 
SystemVMs and VR to run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#discussion_r170077117
 
 

 ##
 File path: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ##
 @@ -1368,12 +1368,23 @@ public VM createVmFromTemplate(final Connection conn, 
final VirtualMachineTO vmS
 
 final String bootArgs = vmSpec.getBootArgs();
 if (bootArgs != null && bootArgs.length() > 0) {
+// send boot args for PV instances
 String pvargs = vm.getPVArgs(conn);
 pvargs = pvargs + vmSpec.getBootArgs().replaceAll(" ", "%");
 if (s_logger.isDebugEnabled()) {
 s_logger.debug("PV args are " + pvargs);
 }
 vm.setPVArgs(conn, pvargs);
+
+// send boot args into xenstore-data for HVM instances
+Map xenstoreData = new HashMap<>();
+
+xenstoreData.put("vm-data/cloudstack/init", bootArgs);
+vm.setXenstoreData(conn, xenstoreData);
+
+if (s_logger.isDebugEnabled()) {
+s_logger.debug("HVM args are " + bootArgs);
 
 Review comment:
   I didn't get your point! Are your pro on this specific IF block or against 
it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

rafaelweingartner commented on a change in pull request #2465: 
CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#discussion_r170073522
 
 

 ##
 File path: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ##
 @@ -1368,12 +1368,23 @@ public VM createVmFromTemplate(final Connection conn, 
final VirtualMachineTO vmS
 
 final String bootArgs = vmSpec.getBootArgs();
 if (bootArgs != null && bootArgs.length() > 0) {
+// send boot args for PV instances
 String pvargs = vm.getPVArgs(conn);
 pvargs = pvargs + vmSpec.getBootArgs().replaceAll(" ", "%");
 if (s_logger.isDebugEnabled()) {
 s_logger.debug("PV args are " + pvargs);
 }
 vm.setPVArgs(conn, pvargs);
+
+// send boot args into xenstore-data for HVM instances
+Map xenstoreData = new HashMap<>();
+
+xenstoreData.put("vm-data/cloudstack/init", bootArgs);
+vm.setXenstoreData(conn, xenstoreData);
+
+if (s_logger.isDebugEnabled()) {
+s_logger.debug("HVM args are " + bootArgs);
 
 Review comment:
   In this type of system such as ACS, I believe it is worth the cost of a tiny 
bit of more processing to remove an If statement. Specially in cases such as 
this one, when you already have others IFs where this one is nested.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

khos2ow commented on a change in pull request #2465: CLOUDSTACK-10232: 
SystemVMs and VR to run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#discussion_r170060637
 
 

 ##
 File path: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ##
 @@ -1368,12 +1368,23 @@ public VM createVmFromTemplate(final Connection conn, 
final VirtualMachineTO vmS
 
 final String bootArgs = vmSpec.getBootArgs();
 if (bootArgs != null && bootArgs.length() > 0) {
+// send boot args for PV instances
 String pvargs = vm.getPVArgs(conn);
 pvargs = pvargs + vmSpec.getBootArgs().replaceAll(" ", "%");
 if (s_logger.isDebugEnabled()) {
 s_logger.debug("PV args are " + pvargs);
 }
 vm.setPVArgs(conn, pvargs);
+
+// send boot args into xenstore-data for HVM instances
+Map xenstoreData = new HashMap<>();
+
+xenstoreData.put("vm-data/cloudstack/init", bootArgs);
 
 Review comment:
   sure.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] syed commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

syed commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs 
and VR to run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#discussion_r170059191
 
 

 ##
 File path: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ##
 @@ -1368,12 +1368,23 @@ public VM createVmFromTemplate(final Connection conn, 
final VirtualMachineTO vmS
 
 final String bootArgs = vmSpec.getBootArgs();
 if (bootArgs != null && bootArgs.length() > 0) {
+// send boot args for PV instances
 String pvargs = vm.getPVArgs(conn);
 pvargs = pvargs + vmSpec.getBootArgs().replaceAll(" ", "%");
 if (s_logger.isDebugEnabled()) {
 s_logger.debug("PV args are " + pvargs);
 }
 vm.setPVArgs(conn, pvargs);
+
+// send boot args into xenstore-data for HVM instances
+Map xenstoreData = new HashMap<>();
+
+xenstoreData.put("vm-data/cloudstack/init", bootArgs);
 
 Review comment:
   Could you please move the `vm-data/cloudstack/init` string into a class 
constant.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

khos2ow commented on a change in pull request #2465: CLOUDSTACK-10232: 
SystemVMs and VR to run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#discussion_r170022564
 
 

 ##
 File path: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ##
 @@ -1368,12 +1368,23 @@ public VM createVmFromTemplate(final Connection conn, 
final VirtualMachineTO vmS
 
 final String bootArgs = vmSpec.getBootArgs();
 if (bootArgs != null && bootArgs.length() > 0) {
+// send boot args for PV instances
 String pvargs = vm.getPVArgs(conn);
 pvargs = pvargs + vmSpec.getBootArgs().replaceAll(" ", "%");
 if (s_logger.isDebugEnabled()) {
 s_logger.debug("PV args are " + pvargs);
 }
 vm.setPVArgs(conn, pvargs);
+
+// send boot args into xenstore-data for HVM instances
+Map xenstoreData = new HashMap<>();
+
+xenstoreData.put("vm-data/cloudstack/init", bootArgs);
+vm.setXenstoreData(conn, xenstoreData);
+
+if (s_logger.isDebugEnabled()) {
+s_logger.debug("HVM args are " + bootArgs);
 
 Review comment:
   Technically it can be removed, but as its javadoc says: `This function is 
intended to lessen the computational cost of disabled log debug statements.` 
and the fact that they are used all over the place I added the same if block.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

blueorangutan commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to 
run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-367741560
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1730


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

khos2ow commented on a change in pull request #2465: CLOUDSTACK-10232: 
SystemVMs and VR to run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#discussion_r170010228
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/setup/cloud-early-config
 ##
 @@ -42,7 +42,14 @@ hypervisor() {
   grep -q QEMU /var/log/messages && echo "kvm" && return 0
 
   [ -d /proc/xen ] && mount -t xenfs none /proc/xen
-  [ -d /proc/xen ] && echo "xen-domU" && return 0
+  if [ -d /proc/xen ]; then
+`dmesg | grep -q "Xen HVM"`
 
 Review comment:
   sure.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

wido commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs 
and VR to run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#discussion_r170009008
 
 

 ##
 File path: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ##
 @@ -1368,12 +1368,23 @@ public VM createVmFromTemplate(final Connection conn, 
final VirtualMachineTO vmS
 
 final String bootArgs = vmSpec.getBootArgs();
 if (bootArgs != null && bootArgs.length() > 0) {
+// send boot args for PV instances
 String pvargs = vm.getPVArgs(conn);
 pvargs = pvargs + vmSpec.getBootArgs().replaceAll(" ", "%");
 if (s_logger.isDebugEnabled()) {
 s_logger.debug("PV args are " + pvargs);
 }
 vm.setPVArgs(conn, pvargs);
+
+// send boot args into xenstore-data for HVM instances
+Map xenstoreData = new HashMap<>();
+
+xenstoreData.put("vm-data/cloudstack/init", bootArgs);
+vm.setXenstoreData(conn, xenstoreData);
+
+if (s_logger.isDebugEnabled()) {
+s_logger.debug("HVM args are " + bootArgs);
 
 Review comment:
   Is this if statement still required to check if debug is enabled?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

blueorangutan commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to 
run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-367728567
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

rhtyd commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as 
HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-367728245
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

rhtyd commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs 
and VR to run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#discussion_r170005233
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/setup/cloud-early-config
 ##
 @@ -42,7 +42,14 @@ hypervisor() {
   grep -q QEMU /var/log/messages && echo "kvm" && return 0
 
   [ -d /proc/xen ] && mount -t xenfs none /proc/xen
-  [ -d /proc/xen ] && echo "xen-domU" && return 0
+  if [ -d /proc/xen ]; then
+`dmesg | grep -q "Xen HVM"`
 
 Review comment:
   For consistency, can you use this instead $(command here)?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

khos2ow commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as 
HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-367725070
 
 
   Ping for review: @DaanHoogland @rafaelweingartner @rhtyd @wido 
   /cc @syed @pdion891 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

khos2ow commented on issue #2465: CLOUDSTACK-10232: SystemVMs and VR to run as 
HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#issuecomment-367725070
 
 
   Ping for review: @DaanHoogland @rafaelweingartner @rhtyd @wido 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2455: CLOUDSTACK-10292:Hostname in metadata when using external DNS is inco?

[GitBox]

rafaelweingartner commented on a change in pull request #2455: 
CLOUDSTACK-10292:Hostname in metadata when using external DNS is inco?
URL: https://github.com/apache/cloudstack/pull/2455#discussion_r169993368
 
 

 ##
 File path: 
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
 ##
 @@ -2526,7 +2526,7 @@ private void orchestrateMigrateWithStorage(final String 
vmUuid, final long srcHo
 final String zoneName = 
_dcDao.findById(vm.getDataCenterId()).getName();
 boolean isWindows = 
_guestOSCategoryDao.findById(_guestOSDao.findById(vm.getGuestOSId()).getCategoryId()).getName().equalsIgnoreCase("Windows");
 
-vmData = 
_networkModel.generateVmData(userVm.getUserData(), serviceOffering, zoneName, 
vm.getInstanceName(), vm.getId(),
+vmData = 
_networkModel.generateVmData(userVm.getUserData(), serviceOffering, zoneName, 
vm.getInstanceName(), vm.getHostName(), vm.getId(),
 
 Review comment:
   Of course there is. I am not talking about the object you create with the 
call `generateVmData`. I am talking about the object from which you are 
retrieving data `vm`. That object is an instance of `UserVmVO`, which extends 
`VMInstanceVO`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2455: CLOUDSTACK-10292:Hostname in metadata when using external DNS is inco?

[GitBox]

rafaelweingartner commented on a change in pull request #2455: 
CLOUDSTACK-10292:Hostname in metadata when using external DNS is inco?
URL: https://github.com/apache/cloudstack/pull/2455#discussion_r169993368
 
 

 ##
 File path: 
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
 ##
 @@ -2526,7 +2526,7 @@ private void orchestrateMigrateWithStorage(final String 
vmUuid, final long srcHo
 final String zoneName = 
_dcDao.findById(vm.getDataCenterId()).getName();
 boolean isWindows = 
_guestOSCategoryDao.findById(_guestOSDao.findById(vm.getGuestOSId()).getCategoryId()).getName().equalsIgnoreCase("Windows");
 
-vmData = 
_networkModel.generateVmData(userVm.getUserData(), serviceOffering, zoneName, 
vm.getInstanceName(), vm.getId(),
+vmData = 
_networkModel.generateVmData(userVm.getUserData(), serviceOffering, zoneName, 
vm.getInstanceName(), vm.getHostName(), vm.getId(),
 
 Review comment:
   Of course there is. I am not talking about the object you create we the call 
`generateVmData`. I am talking about the object from which you are retrieving 
data `vm`. That object is an instance of `UserVmVO`, which extends 
`VMInstanceVO`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrunalinikankariya commented on a change in pull request #2455: CLOUDSTACK-10292:Hostname in metadata when using external DNS is inco?

[GitBox]

mrunalinikankariya commented on a change in pull request #2455: 
CLOUDSTACK-10292:Hostname in metadata when using external DNS is inco?
URL: https://github.com/apache/cloudstack/pull/2455#discussion_r169992289
 
 

 ##
 File path: 
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
 ##
 @@ -2526,7 +2526,7 @@ private void orchestrateMigrateWithStorage(final String 
vmUuid, final long srcHo
 final String zoneName = 
_dcDao.findById(vm.getDataCenterId()).getName();
 boolean isWindows = 
_guestOSCategoryDao.findById(_guestOSDao.findById(vm.getGuestOSId()).getCategoryId()).getName().equalsIgnoreCase("Windows");
 
-vmData = 
_networkModel.generateVmData(userVm.getUserData(), serviceOffering, zoneName, 
vm.getInstanceName(), vm.getId(),
+vmData = 
_networkModel.generateVmData(userVm.getUserData(), serviceOffering, zoneName, 
vm.getInstanceName(), vm.getHostName(), vm.getId(),
 
 Review comment:
   There is no displayname parameter in VirtualMachine.java. Also hostName 
refers to name parameter only


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez opened a new pull request #2466: Rare race condition in KVM migration

[GitBox]

nvazquez opened a new pull request #2466: Rare race condition in KVM migration
URL: https://github.com/apache/cloudstack/pull/2466
 
 
   There is a race condition in the monitoring of the migration process on KVM. 
If the monitor wakes up in the tight window after the migration succeeds, but 
before the migration thread terminates, the monitor will get a LibvirtException 
?Domain not found: no domain with matching uuid? when checking on the migration 
status. This in turn causes CloudStack to sync the VM state to stop, in which 
it issues a defensive StopCommand to ensure it is correctly synced.
   
   Fix: Prevent `LibvirtException: "Domain not found"` caused by the call to 
`dm.getInfo()`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly

[GitBox]

blueorangutan commented on issue #2443:  [CLOUDSTACK-9338] ACS is not 
accounting resources of VMs with custom service offering properly
URL: https://github.com/apache/cloudstack/pull/2443#issuecomment-367692266
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly

[GitBox]

borisstoyanov commented on issue #2443:  [CLOUDSTACK-9338] ACS is not 
accounting resources of VMs with custom service offering properly
URL: https://github.com/apache/cloudstack/pull/2443#issuecomment-367692200
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2455: CLOUDSTACK-10292:Hostname in metadata when using external DNS is inco?

[GitBox]

rafaelweingartner commented on a change in pull request #2455: 
CLOUDSTACK-10292:Hostname in metadata when using external DNS is inco?
URL: https://github.com/apache/cloudstack/pull/2455#discussion_r169939634
 
 

 ##
 File path: 
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
 ##
 @@ -2526,7 +2526,7 @@ private void orchestrateMigrateWithStorage(final String 
vmUuid, final long srcHo
 final String zoneName = 
_dcDao.findById(vm.getDataCenterId()).getName();
 boolean isWindows = 
_guestOSCategoryDao.findById(_guestOSDao.findById(vm.getGuestOSId()).getCategoryId()).getName().equalsIgnoreCase("Windows");
 
-vmData = 
_networkModel.generateVmData(userVm.getUserData(), serviceOffering, zoneName, 
vm.getInstanceName(), vm.getId(),
+vmData = 
_networkModel.generateVmData(userVm.getUserData(), serviceOffering, zoneName, 
vm.getInstanceName(), vm.getHostName(), vm.getId(),
 
 Review comment:
   @mrunalinikankariya you want to send the name set by the user for the given 
VM, right? They are the parameters "displayname" and "name" that the user can 
enter when deploying a VM. 
   
   Even though this "hostName" contains that parameter "name", I get the 
feeling that it is not the right one to use. It looks like an inconsistent sent 
of value that can and should be fixed in the future. If you look into the VM's 
POJO, we have hostId and hostName; for sanity, I would consider them the same 
thing. Therefore, hostId is the id of the host where the VM is running, and the 
hostName is the name of the host where the VM is running.
   
   Therefore, I believe you should use "displayName" or "name" attributes 
instead of the "hostName".


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] marcaurele commented on issue #2422: [CLOUDSTACK-10254] checkstyle: add package name declaration validation

[GitBox]

marcaurele commented on issue #2422: [CLOUDSTACK-10254] checkstyle: add package 
name declaration validation
URL: https://github.com/apache/cloudstack/pull/2422#issuecomment-367614531
 
 
   @rafaelweingartner I'd rather push all together since it does not disturb 
the build. I had a hard time finding the solution for the generated classes. 
I'm down to the apidoc project, which requires a fix and it should all be good.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services