[GitHub] rhtyd commented on issue #2492: Fix the name of the column used to hold IPv4 range in 'vlan' table.

[GitBox]

rhtyd commented on issue #2492: Fix the name of the column used to hold IPv4 
range in 'vlan' table.
URL: https://github.com/apache/cloudstack/pull/2492#issuecomment-373585492
 
 
   Can you check the build  failures @rafaelweingartner? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed pull request #2491: Fix "agent-lb" project

[GitBox]

rhtyd closed pull request #2491: Fix "agent-lb" project
URL: https://github.com/apache/cloudstack/pull/2491
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/core/src/org/apache/cloudstack/agent/lb/SetupMSListAnswer.java 
b/core/src/main/java/org/apache/cloudstack/agent/lb/SetupMSListAnswer.java
similarity index 100%
rename from core/src/org/apache/cloudstack/agent/lb/SetupMSListAnswer.java
rename to 
core/src/main/java/org/apache/cloudstack/agent/lb/SetupMSListAnswer.java
diff --git a/core/src/org/apache/cloudstack/agent/lb/SetupMSListCommand.java 
b/core/src/main/java/org/apache/cloudstack/agent/lb/SetupMSListCommand.java
similarity index 100%
rename from core/src/org/apache/cloudstack/agent/lb/SetupMSListCommand.java
rename to 
core/src/main/java/org/apache/cloudstack/agent/lb/SetupMSListCommand.java
diff --git a/framework/agent-lb/pom.xml b/framework/agent-lb/pom.xml
index 7d14a3a4a7e..8f16f2b085d 100644
--- a/framework/agent-lb/pom.xml
+++ b/framework/agent-lb/pom.xml
@@ -25,7 +25,7 @@
 
 cloudstack-framework
 org.apache.cloudstack
-4.11.1.0-SNAPSHOT
+4.12.0.0-SNAPSHOT
 ../pom.xml
 
 
diff --git 
a/framework/agent-lb/src/org/apache/cloudstack/agent/lb/IndirectAgentLB.java 
b/framework/agent-lb/src/main/java/org/apache/cloudstack/agent/lb/IndirectAgentLB.java
similarity index 100%
rename from 
framework/agent-lb/src/org/apache/cloudstack/agent/lb/IndirectAgentLB.java
rename to 
framework/agent-lb/src/main/java/org/apache/cloudstack/agent/lb/IndirectAgentLB.java
diff --git 
a/framework/agent-lb/src/org/apache/cloudstack/agent/lb/IndirectAgentLBAlgorithm.java
 
b/framework/agent-lb/src/main/java/org/apache/cloudstack/agent/lb/IndirectAgentLBAlgorithm.java
similarity index 100%
rename from 
framework/agent-lb/src/org/apache/cloudstack/agent/lb/IndirectAgentLBAlgorithm.java
rename to 
framework/agent-lb/src/main/java/org/apache/cloudstack/agent/lb/IndirectAgentLBAlgorithm.java
diff --git 
a/server/src/org/apache/cloudstack/agent/lb/IndirectAgentLBServiceImpl.java 
b/server/src/main/java/org/apache/cloudstack/agent/lb/IndirectAgentLBServiceImpl.java
similarity index 100%
rename from 
server/src/org/apache/cloudstack/agent/lb/IndirectAgentLBServiceImpl.java
rename to 
server/src/main/java/org/apache/cloudstack/agent/lb/IndirectAgentLBServiceImpl.java
diff --git 
a/server/src/org/apache/cloudstack/agent/lb/algorithm/IndirectAgentLBRoundRobinAlgorithm.java
 
b/server/src/main/java/org/apache/cloudstack/agent/lb/algorithm/IndirectAgentLBRoundRobinAlgorithm.java
similarity index 100%
rename from 
server/src/org/apache/cloudstack/agent/lb/algorithm/IndirectAgentLBRoundRobinAlgorithm.java
rename to 
server/src/main/java/org/apache/cloudstack/agent/lb/algorithm/IndirectAgentLBRoundRobinAlgorithm.java
diff --git 
a/server/src/org/apache/cloudstack/agent/lb/algorithm/IndirectAgentLBShuffleAlgorithm.java
 
b/server/src/main/java/org/apache/cloudstack/agent/lb/algorithm/IndirectAgentLBShuffleAlgorithm.java
similarity index 100%
rename from 
server/src/org/apache/cloudstack/agent/lb/algorithm/IndirectAgentLBShuffleAlgorithm.java
rename to 
server/src/main/java/org/apache/cloudstack/agent/lb/algorithm/IndirectAgentLBShuffleAlgorithm.java
diff --git 
a/server/src/org/apache/cloudstack/agent/lb/algorithm/IndirectAgentLBStaticAlgorithm.java
 
b/server/src/main/java/org/apache/cloudstack/agent/lb/algorithm/IndirectAgentLBStaticAlgorithm.java
similarity index 100%
rename from 
server/src/org/apache/cloudstack/agent/lb/algorithm/IndirectAgentLBStaticAlgorithm.java
rename to 
server/src/main/java/org/apache/cloudstack/agent/lb/algorithm/IndirectAgentLBStaticAlgorithm.java


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: CLOUDSTACK-10132: Fix POM of "agent-lb" project (#2491)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 8a3943b  CLOUDSTACK-10132: Fix POM of "agent-lb" project (#2491)
8a3943b is described below

commit 8a3943b7632eddf3856a19e7d9a3fee82dd325be
Author: Rafael Weingärtner 
AuthorDate: Thu Mar 15 23:34:22 2018 -0300

CLOUDSTACK-10132: Fix POM of "agent-lb" project (#2491)

Post fwd merging, this fixes build issues.
---
 .../java}/org/apache/cloudstack/agent/lb/SetupMSListAnswer.java | 0
 .../java}/org/apache/cloudstack/agent/lb/SetupMSListCommand.java| 0
 framework/agent-lb/pom.xml  | 2 +-
 .../{ => main/java}/org/apache/cloudstack/agent/lb/IndirectAgentLB.java | 0
 .../java}/org/apache/cloudstack/agent/lb/IndirectAgentLBAlgorithm.java  | 0
 .../org/apache/cloudstack/agent/lb/IndirectAgentLBServiceImpl.java  | 0
 .../agent/lb/algorithm/IndirectAgentLBRoundRobinAlgorithm.java  | 0
 .../cloudstack/agent/lb/algorithm/IndirectAgentLBShuffleAlgorithm.java  | 0
 .../cloudstack/agent/lb/algorithm/IndirectAgentLBStaticAlgorithm.java   | 0
 9 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/src/org/apache/cloudstack/agent/lb/SetupMSListAnswer.java 
b/core/src/main/java/org/apache/cloudstack/agent/lb/SetupMSListAnswer.java
similarity index 100%
rename from core/src/org/apache/cloudstack/agent/lb/SetupMSListAnswer.java
rename to 
core/src/main/java/org/apache/cloudstack/agent/lb/SetupMSListAnswer.java
diff --git a/core/src/org/apache/cloudstack/agent/lb/SetupMSListCommand.java 
b/core/src/main/java/org/apache/cloudstack/agent/lb/SetupMSListCommand.java
similarity index 100%
rename from core/src/org/apache/cloudstack/agent/lb/SetupMSListCommand.java
rename to 
core/src/main/java/org/apache/cloudstack/agent/lb/SetupMSListCommand.java
diff --git a/framework/agent-lb/pom.xml b/framework/agent-lb/pom.xml
index 7d14a3a..8f16f2b 100644
--- a/framework/agent-lb/pom.xml
+++ b/framework/agent-lb/pom.xml
@@ -25,7 +25,7 @@
 
 cloudstack-framework
 org.apache.cloudstack
-4.11.1.0-SNAPSHOT
+4.12.0.0-SNAPSHOT
 ../pom.xml
 
 
diff --git 
a/framework/agent-lb/src/org/apache/cloudstack/agent/lb/IndirectAgentLB.java 
b/framework/agent-lb/src/main/java/org/apache/cloudstack/agent/lb/IndirectAgentLB.java
similarity index 100%
rename from 
framework/agent-lb/src/org/apache/cloudstack/agent/lb/IndirectAgentLB.java
rename to 
framework/agent-lb/src/main/java/org/apache/cloudstack/agent/lb/IndirectAgentLB.java
diff --git 
a/framework/agent-lb/src/org/apache/cloudstack/agent/lb/IndirectAgentLBAlgorithm.java
 
b/framework/agent-lb/src/main/java/org/apache/cloudstack/agent/lb/IndirectAgentLBAlgorithm.java
similarity index 100%
rename from 
framework/agent-lb/src/org/apache/cloudstack/agent/lb/IndirectAgentLBAlgorithm.java
rename to 
framework/agent-lb/src/main/java/org/apache/cloudstack/agent/lb/IndirectAgentLBAlgorithm.java
diff --git 
a/server/src/org/apache/cloudstack/agent/lb/IndirectAgentLBServiceImpl.java 
b/server/src/main/java/org/apache/cloudstack/agent/lb/IndirectAgentLBServiceImpl.java
similarity index 100%
rename from 
server/src/org/apache/cloudstack/agent/lb/IndirectAgentLBServiceImpl.java
rename to 
server/src/main/java/org/apache/cloudstack/agent/lb/IndirectAgentLBServiceImpl.java
diff --git 
a/server/src/org/apache/cloudstack/agent/lb/algorithm/IndirectAgentLBRoundRobinAlgorithm.java
 
b/server/src/main/java/org/apache/cloudstack/agent/lb/algorithm/IndirectAgentLBRoundRobinAlgorithm.java
similarity index 100%
rename from 
server/src/org/apache/cloudstack/agent/lb/algorithm/IndirectAgentLBRoundRobinAlgorithm.java
rename to 
server/src/main/java/org/apache/cloudstack/agent/lb/algorithm/IndirectAgentLBRoundRobinAlgorithm.java
diff --git 
a/server/src/org/apache/cloudstack/agent/lb/algorithm/IndirectAgentLBShuffleAlgorithm.java
 
b/server/src/main/java/org/apache/cloudstack/agent/lb/algorithm/IndirectAgentLBShuffleAlgorithm.java
similarity index 100%
rename from 
server/src/org/apache/cloudstack/agent/lb/algorithm/IndirectAgentLBShuffleAlgorithm.java
rename to 
server/src/main/java/org/apache/cloudstack/agent/lb/algorithm/IndirectAgentLBShuffleAlgorithm.java
diff --git 
a/server/src/org/apache/cloudstack/agent/lb/algorithm/IndirectAgentLBStaticAlgorithm.java
 
b/server/src/main/java/org/apache/cloudstack/agent/lb/algorithm/IndirectAgentLBStaticAlgorithm.java
similarity index 100%
rename from 
server/src/org/apache/cloudstack/agent/lb/algorithm/IndirectAgentLBStaticAlgorithm.java
rename to 
server/src/main/java/org/apache/cloudstack/agent/lb/algorithm/IndirectAgentLBStaticAlgorithm.java

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[GitHub] rhtyd commented on issue #2491: Fix "agent-lb" project

[GitBox]

rhtyd commented on issue #2491: Fix "agent-lb" project
URL: https://github.com/apache/cloudstack/pull/2491#issuecomment-373584993
 
 
   Yes, tests lgtm


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez opened a new pull request #2493: CLOUDSTACK-10326: Prevent hosts fall into Maintenance when there are running VMs on it

[GitBox]

nvazquez opened a new pull request #2493: CLOUDSTACK-10326: Prevent hosts fall 
into Maintenance when there are running VMs on it
URL: https://github.com/apache/cloudstack/pull/2493
 
 
   JIRA Ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-10326
   
   This issue was discovered, fixed and tested on KVM, but applies for every 
hypervisor.
   
   ### Background
   When enabling maintenance mode in a host, host state is put into 
'PrepareForMaintenance' and running VMs are migrated into another host. After 
every VM is migrated, host goes to 'Maintenance' state.
   
   Checks are performed on `ResourceManagerImpl.checkAndMaintan()` method:
   
   - List VMs with host_id = HOST_ID
   - List VMs with last_host_id = HOST_ID and state=Migrating
   
   When both queries are empty, then the host can be put into Maintenance.
   
   When a VM is being migrated to DEST_HOST, its host_id column is set to 
DEST_HOST, last_host_id = ORIGIN_HOST and state = Migrating. If then migration 
fails, host_id = last_host_id = ORIGIN_HOST 
   
   ### Issue
   This sequence:
   
   - Enable maintenance mode on ORIGIN_HOST
   - VMs start being migrated to a host, say DEST_HOST
   - checkAndMaintain() starts:
  - First check passes (no VM with host_id = ORIGIN_HOST_ID as those are 
being migrated)
  - Before the second check, one or more migrations fail
  - Second check passes, however there are VMs running on the host as 
migrations have failed.
   - Host goes into Maintenance state.
   
   Screenshots attached, query executed on each case:
   `select id, name, instance_name, state, host_id, last_host_id from 
vm_instance;`
   
   Before enabling maintenance mode on host 4:
   
![cloudstack-10326-initialstate](https://user-images.githubusercontent.com/5295080/37496971-54f6a482-2894-11e8-9976-5097434608b1.png)
   
   While host = 'PrepareForMaintenance' and VM is being migrated to host 1:
   
![cloudstack-10326-migrating](https://user-images.githubusercontent.com/5295080/37497029-a31d6a38-2894-11e8-8e7e-6df725b69252.png)
   
   At this point the first check is performed:
   
![cloudstack-10326-debug1](https://user-images.githubusercontent.com/5295080/37497097-fe6df646-2894-11e8-8dd5-a7e2a8869398.png)
   
   Made migrations fail adding these rules on host 4:
   
   iptables -I OUTPUT -j REJECT -m state --state NEW -m tcp -p tcp --dport 
49152:49215 -m comment --comment 'test block migrations'
   iptables -I OUTPUT -j REJECT -m state --state NEW -m tcp -p tcp --dport 
16509 -m comment --comment 'test block migrations'
   
   Migration failed and VM goes Running into host 4:
   
![cloudstack-10326-migrationfailed](https://user-images.githubusercontent.com/5295080/37497071-dcf8ee76-2894-11e8-8064-0870870ba422.png)
   
   Second check passes and host goes into Maintenance
   
![cloudstack-10326-debug](https://user-images.githubusercontent.com/5295080/37497109-0bc56ae0-2895-11e8-94e9-a00ed1195502.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2491: Fix "agent-lb" project

[GitBox]

rafaelweingartner commented on issue #2491: Fix "agent-lb" project
URL: https://github.com/apache/cloudstack/pull/2491#issuecomment-373556333
 
 
   Are these errors something that we need to take a look into? No code has 
been changed here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2491: Fix "agent-lb" project

[GitBox]

blueorangutan commented on issue #2491: Fix "agent-lb" project
URL: https://github.com/apache/cloudstack/pull/2491#issuecomment-37332
 
 
   Trillian test result (tid-2379)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 20697 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2491-t2379-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 66 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 443.94 | 
test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 302.29 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 325.00 | test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

[GitBox]

DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column 
addition
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-373545553
 
 
   @fmaximus @rafaelweingartner @marcaurele @rhtyd @ustcweizhou , can we please 
have further reviews for this? (or mpre discussion) Of couse a flyway kind of 
solution need to be our long term solution.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

[GitBox]

blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column 
addition
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-373544092
 
 
   Trillian test result (tid-2377)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 27933 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2449-t2377-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 65 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 502.65 | 
test_vpc_redundant.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 2.79 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings

[GitBox]

blueorangutan commented on issue #2490: Create database upgrade from 4.11.0.0 
to 4.11.1.0 & VMWare version to OS mappings
URL: https://github.com/apache/cloudstack/pull/2490#issuecomment-373542688
 
 
   Trillian test result (tid-2378)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 27771 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2490-t2378-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 62 look OK, 5 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_extract_template | `Failure` | 128.35 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_06_download_detached_volume | `Failure` | 136.59 | test_volumes.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 446.87 | 
test_vpc_redundant.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 2.45 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance 
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-373530890
 
 
   Trillian test result (tid-2374)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 30030 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2433-t2374-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 66 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_vpc_privategw_static_routes | `Failure` | 181.86 | 
test_privategw_acl.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on a change in pull request #2489: PULL_REQUEST_TEMPLATE: Add pull request template

[GitBox]

khos2ow commented on a change in pull request #2489: PULL_REQUEST_TEMPLATE: Add 
pull request template
URL: https://github.com/apache/cloudstack/pull/2489#discussion_r174936147
 
 

 ##
 File path: PULL_REQUEST_TEMPLATE.md
 ##
 @@ -0,0 +1,32 @@
+## Description
+
+
+
+
+
+## Types of changes
+
+- [ ] Bug fix (non-breaking change which fixes an issue)
+- [ ] New feature (non-breaking change which adds functionality)
+- [ ] Breaking change (fix or feature that would cause existing functionality 
to change)
+
 
 Review comment:
   Correct! Those two make sense as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2489: PULL_REQUEST_TEMPLATE: Add pull request template

[GitBox]

rafaelweingartner commented on a change in pull request #2489: 
PULL_REQUEST_TEMPLATE: Add pull request template
URL: https://github.com/apache/cloudstack/pull/2489#discussion_r174935589
 
 

 ##
 File path: PULL_REQUEST_TEMPLATE.md
 ##
 @@ -0,0 +1,32 @@
+## Description
+
+
+
+
+
+## Types of changes
+
+- [ ] Bug fix (non-breaking change which fixes an issue)
+- [ ] New feature (non-breaking change which adds functionality)
+- [ ] Breaking change (fix or feature that would cause existing functionality 
to change)
+
 
 Review comment:
   Also, what about code cleanup and PRs, which only add test cases?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on a change in pull request #2489: PULL_REQUEST_TEMPLATE: Add pull request template

[GitBox]

khos2ow commented on a change in pull request #2489: PULL_REQUEST_TEMPLATE: Add 
pull request template
URL: https://github.com/apache/cloudstack/pull/2489#discussion_r174935002
 
 

 ##
 File path: PULL_REQUEST_TEMPLATE.md
 ##
 @@ -0,0 +1,32 @@
+## Description
+
+
+
+
+
+## Types of changes
+
+- [ ] Bug fix (non-breaking change which fixes an issue)
+- [ ] New feature (non-breaking change which adds functionality)
+- [ ] Breaking change (fix or feature that would cause existing functionality 
to change)
+
 
 Review comment:
   I think we can have "improvement" and/or "enhancement" here too, because 
there could be a case which the PR falls on neither of above because of the two 
mentioned states.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on a change in pull request #2489: PULL_REQUEST_TEMPLATE: Add pull request template

[GitBox]

khos2ow commented on a change in pull request #2489: PULL_REQUEST_TEMPLATE: Add 
pull request template
URL: https://github.com/apache/cloudstack/pull/2489#discussion_r174934081
 
 

 ##
 File path: PULL_REQUEST_TEMPLATE.md
 ##
 @@ -0,0 +1,32 @@
+## Description
+
+
+
+
+
+## Types of changes
+
+- [ ] Bug fix (non-breaking change which fixes an issue)
+- [ ] New feature (non-breaking change which adds functionality)
+- [ ] Breaking change (fix or feature that would cause existing functionality 
to change)
+
+## Screenshots (if appropriate):
+
+## How Has This Been Tested?
+
+
+
+
+
+## Checklist:
+
+
+- [ ] I have read the **CONTRIBUTING** document.
 
 Review comment:
   It would be nice to hyperlink the "CONTRIBUTING" text.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner opened a new pull request #2492: Fix the name of the column used to hold IPv4 range in 'vlan' table.

[GitBox]

rafaelweingartner opened a new pull request #2492: Fix the name of the column 
used to hold IPv4 range in 'vlan' table.
URL: https://github.com/apache/cloudstack/pull/2492
 
 
   The title says everything...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

[GitBox]

blueorangutan commented on issue #2387: CLOUDSTACK-8855 Improve Error Message 
for Host Alert State and reconnect host API.
URL: https://github.com/apache/cloudstack/pull/2387#issuecomment-373480133
 
 
   Trillian test result (tid-2373)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 19887 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2387-t2373-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 66 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 0.93 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

[GitBox]

rhtyd commented on issue #2458: CLOUDSTACK-10296: Find time different from last 
timestamp
URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-373457537
 
 
   No @DaanHoogland it's the trigger that is sometimes caused by github that 
kicks these pkging jobs post merge. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2491: Fix "agent-lb" project

[GitBox]

blueorangutan commented on issue #2491: Fix "agent-lb" project
URL: https://github.com/apache/cloudstack/pull/2491#issuecomment-373456949
 
 
   Packaging result: ✔centos6 ✔centos7 ✖debian. JID-1784


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2491: Fix "agent-lb" project

[GitBox]

rhtyd commented on issue #2491: Fix "agent-lb" project
URL: https://github.com/apache/cloudstack/pull/2491#issuecomment-373457093
 
 
   @blueorangutan test 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2491: Fix "agent-lb" project

[GitBox]

blueorangutan commented on issue #2491: Fix "agent-lb" project
URL: https://github.com/apache/cloudstack/pull/2491#issuecomment-373457173
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2491: Fix "agent-lb" project

[GitBox]

blueorangutan commented on issue #2491: Fix "agent-lb" project
URL: https://github.com/apache/cloudstack/pull/2491#issuecomment-373444789
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2491: Fix "agent-lb" project

[GitBox]

rhtyd commented on issue #2491: Fix "agent-lb" project
URL: https://github.com/apache/cloudstack/pull/2491#issuecomment-37348
 
 
   @blueorangutan package 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2491: Fix "agent-lb" project

[GitBox]

rafaelweingartner commented on issue #2491: Fix "agent-lb" project
URL: https://github.com/apache/cloudstack/pull/2491#issuecomment-373428991
 
 
   As soon as travis and Jenkins are green, do we need the integration tests 
before merging?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2491: Fix "agent-lb" project

[GitBox]

rafaelweingartner commented on issue #2491: Fix "agent-lb" project
URL: https://github.com/apache/cloudstack/pull/2491#issuecomment-373428991
 
 
   As soon as travis and Jenkins are green, do we need the integration tests?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on issue #2489: PULL_REQUEST_TEMPLATE: Add pull request template

[GitBox]

nvazquez commented on issue #2489: PULL_REQUEST_TEMPLATE: Add pull request 
template
URL: https://github.com/apache/cloudstack/pull/2489#issuecomment-373425421
 
 
   Sorry, thought packaging too. Then LGTM as it is


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2489: PULL_REQUEST_TEMPLATE: Add pull request template

[GitBox]

rhtyd commented on issue #2489: PULL_REQUEST_TEMPLATE: Add pull request template
URL: https://github.com/apache/cloudstack/pull/2489#issuecomment-373422909
 
 
   Thanks Nicolas, bo pkg can be requested by anyone on apache/cloudstack repo. 
But only authorized users can run tests. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack-www] 01/01: Merge branch 'master' into asf-site

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git

commit b2bcb1ad50cdc7d5001e39bf5d33de8ab25c4e11
Merge: 839004f ca509de
Author: Daan Hoogland 
AuthorDate: Thu Mar 15 15:56:11 2018 +0100

Merge branch 'master' into asf-site

 content/about.html|   1 +
 content/api.html  |   1 +
 content/api_archives.html |   1 +
 content/archives.html |   1 +
 content/bylaws.html   |   1 +
 content/cloudstack-faq.html   |   1 +
 content/contribute.html   |   1 +
 content/developers.html   |   1 +
 content/downloads.html|   1 +
 content/features.html |   1 +
 content/history.html  |   1 +
 content/index.html|   1 +
 content/mailing-lists.html|  30 ---
 content/security.html |   1 +
 content/software.html |   1 +
 content/stylesheets/custom.css|  26 ++
 content/survey.html   |   1 +
 content/trademark-guidelines.html |   1 +
 content/users.html|   1 +
 content/videos.html   |   1 +
 content/who.html  |   1 +
 source/layouts/layout.erb |   1 +
 source/mailing-lists.markdown |  29 ---
 source/stylesheets/all.css| 173 --
 source/stylesheets/custom.css |  25 ++
 25 files changed, 108 insertions(+), 195 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
d...@apache.org.

[cloudstack-www] branch asf-site updated (839004f -> b2bcb1a)

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch asf-site
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git.


from 839004f  publish site
 add fd2ec87  Change mailing list search mechanism in CloudStack's web site
 add 5fe416d  Merge pull request #43 from rafaelweingartner/mailSearch
 add ca509de  updated #43 to include compiled content for changes mailist 
archives
 new b2bcb1a  Merge branch 'master' into asf-site

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 content/about.html|   1 +
 content/api.html  |   1 +
 content/api_archives.html |   1 +
 content/archives.html |   1 +
 content/bylaws.html   |   1 +
 content/cloudstack-faq.html   |   1 +
 content/contribute.html   |   1 +
 content/developers.html   |   1 +
 content/downloads.html|   1 +
 content/features.html |   1 +
 content/history.html  |   1 +
 content/index.html|   1 +
 content/mailing-lists.html|  30 ---
 content/security.html |   1 +
 content/software.html |   1 +
 content/stylesheets/custom.css|  26 ++
 content/survey.html   |   1 +
 content/trademark-guidelines.html |   1 +
 content/users.html|   1 +
 content/videos.html   |   1 +
 content/who.html  |   1 +
 source/layouts/layout.erb |   1 +
 source/mailing-lists.markdown |  29 ---
 source/stylesheets/all.css| 173 --
 source/stylesheets/custom.css |  25 ++
 25 files changed, 108 insertions(+), 195 deletions(-)
 create mode 100644 content/stylesheets/custom.css
 delete mode 100644 source/stylesheets/all.css
 create mode 100644 source/stylesheets/custom.css

-- 
To stop receiving notification emails like this one, please contact
d...@apache.org.

[cloudstack-www] branch master updated: updated #43 to include compiled content for changes mailist archives

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git


The following commit(s) were added to refs/heads/master by this push:
 new ca509de  updated #43 to include compiled content for changes mailist 
archives
ca509de is described below

commit ca509de306108be380ffd695d0a2ad7251d73721
Author: Daan Hoogland 
AuthorDate: Thu Mar 15 15:53:50 2018 +0100

updated #43 to include compiled content for changes mailist archives
---
 content/about.html|   1 +
 content/api.html  |   3 ++-
 content/api_archives.html |   1 +
 content/archives.html |   8 ++-
 content/bylaws.html   |   1 +
 content/cloudstack-faq.html   |   1 +
 content/contribute.html   |   1 +
 content/developers.html   |   3 ++-
 content/downloads.html|  48 +++---
 content/features.html |   1 +
 content/history.html  |   1 +
 content/images/favicon.ico| Bin 0 -> 14318 bytes
 content/index.html|   3 ++-
 content/mailing-lists.html|  30 +++-
 content/security.html |   1 +
 content/software.html |   1 +
 content/stylesheets/custom.css|  26 +
 content/survey.html   |   1 +
 content/trademark-guidelines.html |   1 +
 content/users.html|   1 +
 content/videos.html   |   1 +
 content/who.html  |  17 +++---
 22 files changed, 99 insertions(+), 52 deletions(-)

diff --git a/content/about.html b/content/about.html
index dbdf895..eab011e 100644
--- a/content/about.html
+++ b/content/about.html
@@ -25,6 +25,7 @@
 
 
 
+
 
 
 
diff --git a/content/api.html b/content/api.html
index 9aa05dd..450b86c 100644
--- a/content/api.html
+++ b/content/api.html
@@ -25,6 +25,7 @@
 
 
 
+
 
 
 
@@ -148,7 +149,7 @@ or by submitting a patch.
 4.11.x
 
 
-  All API
+  All API
 
 
 4.10.x
diff --git a/content/api_archives.html b/content/api_archives.html
index 41eea72..2b7ca5c 100644
--- a/content/api_archives.html
+++ b/content/api_archives.html
@@ -25,6 +25,7 @@
 
 
 
+
 
 
 
diff --git a/content/archives.html b/content/archives.html
index 2523630..214383f 100644
--- a/content/archives.html
+++ b/content/archives.html
@@ -25,6 +25,7 @@
 
 
 
+
 
 
 
@@ -127,7 +128,12 @@
 Archived Releases
 
 
-  4.1
+  4.11
+
+  http://archive.apache.org/dist/cloudstack/releases/4.11.0.0/apache-cloudstack-4.11.0.0-src.tar.bz2;>apache-cloudstack-4.11.0.0.src.tar.bz2
 [ http://archive.apache.org/dist/cloudstack/releases/4.11.0.0/apache-cloudstack-4.11.0.0-src.tar.bz2.asc;>PGP
 ][ http://archive.apache.org/dist/cloudstack/releases/4.11.0.0/apache-cloudstack-4.11.0.0-src.tar.bz2.md5;>MD5
 ][ http://archive.apache.org/dist/cloudstack/releases/4.11.0.0/apache-clou 
[...]
+
+  
+  4.10
 
   http://archive.apache.org/dist/cloudstack/releases/4.10.0.0/apache-cloudstack-4.10.0.0-src.tar.bz2;>apache-cloudstack-4.10.0.0.src.tar.bz2
 [ http://archive.apache.org/dist/cloudstack/releases/4.10.0.0/apache-cloudstack-4.10.0.0-src.tar.bz2.asc;>PGP
 ][ http://archive.apache.org/dist/cloudstack/releases/4.10.0.0/apache-cloudstack-4.10.0.0-src.tar.bz2.md5;>MD5
 ][ http://archive.apache.org/dist/cloudstack/releases/4.10.0.0/apache-clou 
[...]
 
diff --git a/content/bylaws.html b/content/bylaws.html
index 5c36f57..cb24759 100644
--- a/content/bylaws.html
+++ b/content/bylaws.html
@@ -25,6 +25,7 @@
 
 
 
+
 
 
 
diff --git a/content/cloudstack-faq.html b/content/cloudstack-faq.html
index 22561ac..011 100644
--- a/content/cloudstack-faq.html
+++ b/content/cloudstack-faq.html
@@ -25,6 +25,7 @@
 
 
 
+
 
 
 
diff --git a/content/contribute.html b/content/contribute.html
index 5860b92..641417e 100644
--- a/content/contribute.html
+++ b/content/contribute.html
@@ -25,6 +25,7 @@
 
 
 
+
 
 
 
diff --git a/content/developers.html b/content/developers.html
index 38f7bf4..9e34140 100644
--- a/content/developers.html
+++ b/content/developers.html
@@ -25,6 +25,7 @@
 
 
 
+
 
 
 
@@ -156,7 +157,7 @@
 
 Apache CloudStack has a read-only mirror on https://github.com/apache/cloudstack; target="_blank">GitHub that is 
kept in sync with the canonical Git repo maintained by the Apache Software 
Foundation. Submitting GitHub pull requests is the easiest way to get your 
contribution upstream. For detailed instructions see the link below:
 
-https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md; 
target="_blank">GitHub Contribution Guidelines/br
+https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md; 

[GitHub] nvazquez commented on issue #2408: CLOUDSTACK-10231: Asserted fixes for Direct Download on KVM

[GitBox]

nvazquez commented on issue #2408: CLOUDSTACK-10231: Asserted fixes for Direct 
Download on KVM
URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-373400478
 
 
   @rhtyd done


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on issue #2408: asserted fixes for direct downloads

[GitBox]

nvazquez commented on issue #2408: asserted fixes for direct downloads
URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-373393680
 
 
   @rhtyd let me squash the entire PR to single Jira ID


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

[GitBox]

rafaelweingartner commented on issue #2486: [CLOUDSTACK-10323] Allow changing 
disk offering during volume migration 
URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-373391397
 
 
   Yes. However, that is a consequence of the last merge and is fixed with: 
#2491


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack-www] 01/01: Merge pull request #43 from rafaelweingartner/mailSearch

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git

commit 5fe416dea2fe2f28db0b4aa20b0ee8feb66dda91
Merge: 09353fb fd2ec87
Author: dahn 
AuthorDate: Thu Mar 15 14:18:45 2018 +

Merge pull request #43 from rafaelweingartner/mailSearch

Change mailing list search mechanism in CloudStack's web site

 source/layouts/layout.erb |   1 +
 source/mailing-lists.markdown |  29 ---
 source/stylesheets/all.css| 173 --
 source/stylesheets/custom.css |  25 ++
 4 files changed, 44 insertions(+), 184 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
d...@apache.org.

[cloudstack-www] branch master updated (09353fb -> 5fe416d)

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git.


from 09353fb  s/Berlin/Frankfurt
 add fd2ec87  Change mailing list search mechanism in CloudStack's web site
 new 5fe416d  Merge pull request #43 from rafaelweingartner/mailSearch

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 source/layouts/layout.erb |   1 +
 source/mailing-lists.markdown |  29 ---
 source/stylesheets/all.css| 173 --
 source/stylesheets/custom.css |  25 ++
 4 files changed, 44 insertions(+), 184 deletions(-)
 delete mode 100644 source/stylesheets/all.css
 create mode 100644 source/stylesheets/custom.css

-- 
To stop receiving notification emails like this one, please contact
d...@apache.org.

[GitHub] DaanHoogland commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

[GitBox]

DaanHoogland commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk 
offering during volume migration 
URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-373391096
 
 
   debian packaging failed and so did jenkins and travis!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings

[GitBox]

blueorangutan commented on issue #2490: Create database upgrade from 4.11.0.0 
to 4.11.1.0 & VMWare version to OS mappings
URL: https://github.com/apache/cloudstack/pull/2490#issuecomment-373390998
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings

[GitBox]

DaanHoogland commented on issue #2490: Create database upgrade from 4.11.0.0 to 
4.11.1.0 & VMWare version to OS mappings
URL: https://github.com/apache/cloudstack/pull/2490#issuecomment-373390726
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

[GitBox]

blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column 
addition
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-373390643
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

[GitBox]

DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column 
addition
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-373390590
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

[GitBox]

rafaelweingartner commented on issue #2449: WIP CLOUDSTACK-10278 idempotent 
column addition
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-373380723
 
 
   I believe so, but we still need to find a better way technical and protocol 
to better manage data model changes in the database.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

[GitBox]

blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column 
addition
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-373380619
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1783


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings

[GitBox]

blueorangutan commented on issue #2490: Create database upgrade from 4.11.0.0 
to 4.11.1.0 & VMWare version to OS mappings
URL: https://github.com/apache/cloudstack/pull/2490#issuecomment-373379532
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1782


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ernjvr commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

[GitBox]

ernjvr commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-373373896
 
 
   @DaanHoogland no further comments or objections from anyone. Can the request 
be merged?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

[GitBox]

borisstoyanov commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk 
offering during volume migration 
URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-373371916
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

[GitBox]

blueorangutan commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk 
offering during volume migration 
URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-373371964
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2491: Fix POM of "agent-lb" project

[GitBox]

DaanHoogland commented on issue #2491: Fix POM of "agent-lb" project
URL: https://github.com/apache/cloudstack/pull/2491#issuecomment-373368975
 
 
   sounds like a bug in the git-merge-fwd script, @rafaelweingartner . will 
have a look


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner opened a new pull request #2491: Fix POM of "agent-lb" project

[GitBox]

rafaelweingartner opened a new pull request #2491: Fix POM of "agent-lb" project
URL: https://github.com/apache/cloudstack/pull/2491
 
 
   @DaanHoogland, @rhtyd, and @nvazquez can you take a look here?
   
   When PR #2469 got merged forward, the parent pom version was not updated.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

[GitBox]

blueorangutan commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column 
addition
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-373366996
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings

[GitBox]

DaanHoogland commented on issue #2490: Create database upgrade from 4.11.0.0 to 
4.11.1.0 & VMWare version to OS mappings
URL: https://github.com/apache/cloudstack/pull/2490#issuecomment-373364042
 
 
   looks fine @ernjvr let's give it a test sauce
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column addition

[GitBox]

DaanHoogland commented on issue #2449: WIP CLOUDSTACK-10278 idempotent column 
addition
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-373366839
 
 
   Discussion seems to go stale, are we now done with all comments @ernjvr ?
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

[GitBox]

DaanHoogland commented on issue #2458: CLOUDSTACK-10296: Find time different 
from last timestamp
URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-373365586
 
 
   wow, blueorangutan came back with a stale package result after merge! need 
more oil in the machine, something got stuck


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings

[GitBox]

blueorangutan commented on issue #2490: Create database upgrade from 4.11.0.0 
to 4.11.1.0 & VMWare version to OS mappings
URL: https://github.com/apache/cloudstack/pull/2490#issuecomment-373364129
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings

[GitBox]

DaanHoogland commented on issue #2490: Create database upgrade from 4.11.0.0 to 
4.11.1.0 & VMWare version to OS mappings
URL: https://github.com/apache/cloudstack/pull/2490#issuecomment-373364042
 
 
   looks fine @ernjvr let's give it a test souce
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ernjvr opened a new pull request #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0.

[GitBox]

ernjvr opened a new pull request #2490: Create database upgrade from 4.11.0.0 
to 4.11.1.0.
URL: https://github.com/apache/cloudstack/pull/2490
 
 
   Jira ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-10325
   
   Also, add the missing 'VMWare version to OS mappings' SQL in the 
schema-41100to41110.sql file. This fixes an upgrade failure for certain guest 
OSs where the Virtual Router fails to start when these version mappings are 
missing.
   
   Dev Tested the schema-41100to41110.sql file by executing it with the 
com/cloud/utils/db/ScriptRunner.java class. Before and after data samples 
confirm a test pass status.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

[GitBox]

blueorangutan commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk 
offering during volume migration 
URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-373354280
 
 
   Packaging result: ✔centos6 ✔centos7 ✖debian. JID-1781


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2489: PULL_REQUEST_TEMPLATE: Add pull request template

[GitBox]

blueorangutan commented on issue #2489: PULL_REQUEST_TEMPLATE: Add pull request 
template
URL: https://github.com/apache/cloudstack/pull/2489#issuecomment-373354279
 
 
   Packaging result: ✖centos6 ✔centos7 ✖debian. JID-1780


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2471: CLOUDSTACK-10311 Agent Log Rotate variable replace bug

[GitBox]

blueorangutan commented on issue #2471: CLOUDSTACK-10311 Agent Log Rotate 
variable replace bug
URL: https://github.com/apache/cloudstack/pull/2471#issuecomment-373351125
 
 
   Packaging result: ✔centos6 ✔centos7 ✖debian. JID-1779


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

[GitBox]

blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different 
from last timestamp
URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-373349665
 
 
   Packaging result: ✔centos6 ✔centos7 ✖debian. JID-1778


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2408: asserted fixes for direct downloads

[GitBox]

rhtyd commented on issue #2408: asserted fixes for direct downloads
URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-373348685
 
 
   @nvazquez can you squash commits based on JIRA id or you would like to 
squash the entire PR by a single JIRA id?
   @DaanHoogland I can merge based on regression test results, I have not 
tested the feature manually myself. Maybe @borisstoyanov and @nvazquez can 
advise?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2408: asserted fixes for direct downloads

[GitBox]

borisstoyanov commented on issue #2408: asserted fixes for direct downloads
URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-373348569
 
 
   yes @DaanHoogland, this has passed testing and it's good for merge, 
smoketests are showing good results and it has enough LGTMs. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

[GitBox]

blueorangutan commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk 
offering during volume migration 
URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-373348238
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

[GitBox]

borisstoyanov commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk 
offering during volume migration 
URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-373348135
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd opened a new pull request #2489: PULL_REQUEST_TEMPLATE: Add pull request template

[GitBox]

rhtyd opened a new pull request #2489: PULL_REQUEST_TEMPLATE: Add pull request 
template
URL: https://github.com/apache/cloudstack/pull/2489
 
 
   This adds a pull request template. That would look like below:
   
   ## Description
   
   This adds a pull request for future CloudStack PRs.
   
   ## Types of changes
   
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   Tested on Github.
   
   ## Checklist:
   
   
   - [x ] I have read the **CONTRIBUTING** document.
   - [ x] My code follows the code style of this project.
   - [ x] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   - [ ] I have added tests to cover my changes.
   - [ ] All new and existing tests passed.
   
   
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2489: PULL_REQUEST_TEMPLATE: Add pull request template

[GitBox]

blueorangutan commented on issue #2489: PULL_REQUEST_TEMPLATE: Add pull request 
template
URL: https://github.com/apache/cloudstack/pull/2489#issuecomment-373347233
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2408: asserted fixes for direct downloads

[GitBox]

DaanHoogland commented on issue #2408: asserted fixes for direct downloads
URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-373346742
 
 
   @borisstoyanov @rhtyd ^^?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2408: asserted fixes for direct downloads

[GitBox]

DaanHoogland commented on issue #2408: asserted fixes for direct downloads
URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-373345906
 
 
   though I only had minimum involvement I hesitate to merge myself.
   Can we merge?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated (1708838 -> 8ef1317)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 1708838  CLOUDSTACK-10268: Fix and enhance package script (#2433)
 add 19d6578  CLOUDSTACK-10303 : Refactor test data to nuage_test_data.py 
runnable against simulator (#2483)
 add 74db647  CLOUDSTACK-10321: CPU Cap for KVM (#2482)
 add ab0bce2  CLOUDSTACK-10296: Find time different from last timestamp 
(#2458)
 add 30175d6  CLOUDSTACK-10132: Extend support for management servers LB 
for agents (#2469)
 new 8ef1317  Merge branch '4.11'

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 agent/conf/agent.properties|   11 +
 agent/src/main/java/com/cloud/agent/Agent.java |  119 +-
 .../src/main/java/com/cloud/agent/AgentShell.java  |   58 +-
 .../src/main/java/com/cloud/agent/IAgentShell.java |   45 +-
 .../test/java/com/cloud/agent/AgentShellTest.java  |8 +-
 .../com/cloud/agent/api/to/VirtualMachineTO.java   |   10 +
 .../cloudstack/config/ApiServiceConfiguration.java |4 +-
 client/pom.xml |5 +
 .../java/com/cloud/agent/api/ReadyCommand.java |   31 +-
 .../java/com/cloud/agent/api/StartupCommand.java   |9 +
 .../cloudstack/agent/lb/SetupMSListAnswer.java}|9 +-
 .../cloudstack/agent/lb/SetupMSListCommand.java}   |   32 +-
 engine/orchestration/pom.xml   |5 +
 .../com/cloud/agent/manager/AgentManagerImpl.java  |   25 +-
 .../storage/endpoint/DefaultEndPointSelector.java  |4 +-
 framework/{direct-download => agent-lb}/pom.xml|9 +-
 .../cloudstack/agent/lb/IndirectAgentLB.java   |   53 +
 .../agent/lb/IndirectAgentLBAlgorithm.java |   45 +
 framework/pom.xml  |3 +-
 .../kvm/resource/LibvirtComputingResource.java |   28 +
 .../hypervisor/kvm/resource/LibvirtVMDef.java  |   27 +
 .../kvm/resource/LibvirtComputingResourceTest.java |   39 +
 .../cloud/agent/manager/MockStorageManager.java|6 +
 .../agent/manager/MockStorageManagerImpl.java  |   91 +-
 .../cloud/agent/manager/SimulatorManagerImpl.java  |   17 +-
 .../cloud/resource/SimulatorStorageProcessor.java  |2 +-
 .../network/lb/ElasticLoadBalancerManagerImpl.java |2 +-
 server/pom.xml |5 +
 .../configuration/ConfigurationManagerImpl.java|5 +
 .../consoleproxy/ConsoleProxyManagerImpl.java  |6 +-
 .../main/java/com/cloud/hypervisor/KVMGuru.java|   50 +
 .../kvm/discoverer/LibvirtServerDiscoverer.java|6 +-
 .../network/element/ConfigDriveNetworkElement.java |   13 +-
 .../router/VirtualNetworkApplianceManagerImpl.java |4 +-
 .../com/cloud/server/ConfigurationServerImpl.java  |4 +-
 .../core/spring-server-core-managers-context.xml   |2 +
 .../agent/lb/IndirectAgentLBServiceImpl.java   |  231 +++
 .../IndirectAgentLBRoundRobinAlgorithm.java|   59 +
 .../algorithm/IndirectAgentLBShuffleAlgorithm.java |   31 +-
 .../algorithm/IndirectAgentLBStaticAlgorithm.java} |   25 +-
 .../src/test/resources/createNetworkOffering.xml   |1 +
 server/src/test/resources/testContext.xml  |7 +-
 server/test/com/cloud/hypervisor/KVMGuruTest.java  |   99 +
 .../agent/lb/IndirectAgentLBServiceImplTest.java   |  208 ++
 .../IndirectAgentLBRoundRobinAlgorithmTest.java|   76 +
 .../IndirectAgentLBShuffleAlgorithmTest.java   |   60 +
 .../IndirectAgentLBStaticAlgorithmTest.java|   49 +
 .../SecondaryStorageManagerImpl.java   |9 +-
 systemvm/debian/opt/cloud/bin/checkrouter.sh   |7 +
 .../opt/cloud/templates/check_heartbeat.sh.templ   |   78 +-
 .../plugins/nuagevsp/libVSD}/__init__.py   |4 +
 test/integration/plugins/nuagevsp/libVSD/client.py |  135 ++
 .../integration/plugins/nuagevsp/libVSD/helpers.py |  602 ++
 test/integration/plugins/nuagevsp/nuageTestCase.py |  319 ++-
 .../plugins/nuagevsp/nuage_test_data.py| 2177 
 .../plugins/nuagevsp/test_nuage_configdrive.py |  173 +-
 .../plugins/nuagevsp/test_nuage_extra_dhcp.py  |   26 +-
 .../plugins/nuagevsp/test_nuage_internal_dns.py|  400 +---
 .../nuagevsp/test_nuage_network_migration.py   |   24 -
 .../plugins/nuagevsp/test_nuage_password_reset.py  |   11 +-
 .../test_nuage_public_sharednetwork_userdata.py|   13 +-
 .../plugins/nuagevsp/test_nuage_source_nat.py  |   19 +-
 .../plugins/nuagevsp/test_nuage_static_nat.py  |   19 +-
 .../plugins/nuagevsp/test_nuage_vpc_internal_lb.py |  250 +--
 .../nuagevsp/test_nuage_vsp_domain_template.py |4 +
 .../nuagevsp/test_nuage_vsp_mngd_subnets.py|  157 +-
 

[cloudstack] 01/01: Merge branch '4.11'

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 8ef131745a5ef0e5e6ddc7e498f3a0208f1bfb71
Merge: 1708838 30175d6
Author: Rohit Yadav 
AuthorDate: Thu Mar 15 16:46:50 2018 +0530

Merge branch '4.11'

 agent/conf/agent.properties|   11 +
 agent/src/main/java/com/cloud/agent/Agent.java |  119 +-
 .../src/main/java/com/cloud/agent/AgentShell.java  |   58 +-
 .../src/main/java/com/cloud/agent/IAgentShell.java |   45 +-
 .../test/java/com/cloud/agent/AgentShellTest.java  |8 +-
 .../com/cloud/agent/api/to/VirtualMachineTO.java   |   10 +
 .../cloudstack/config/ApiServiceConfiguration.java |4 +-
 client/pom.xml |5 +
 .../java/com/cloud/agent/api/ReadyCommand.java |   31 +-
 .../java/com/cloud/agent/api/StartupCommand.java   |9 +
 .../cloudstack/agent/lb/SetupMSListAnswer.java}|   46 +-
 .../cloudstack/agent/lb/SetupMSListCommand.java}   |   46 +-
 engine/orchestration/pom.xml   |5 +
 .../com/cloud/agent/manager/AgentManagerImpl.java  |   25 +-
 .../storage/endpoint/DefaultEndPointSelector.java  |4 +-
 framework/agent-lb/pom.xml |   32 +
 .../cloudstack/agent/lb/IndirectAgentLB.java   |   53 +
 .../agent/lb/IndirectAgentLBAlgorithm.java |   45 +
 framework/pom.xml  |3 +-
 .../kvm/resource/LibvirtComputingResource.java |   28 +
 .../hypervisor/kvm/resource/LibvirtVMDef.java  |   27 +
 .../kvm/resource/LibvirtComputingResourceTest.java |   39 +
 .../cloud/agent/manager/MockStorageManager.java|6 +
 .../agent/manager/MockStorageManagerImpl.java  |   91 +-
 .../cloud/agent/manager/SimulatorManagerImpl.java  |   17 +-
 .../cloud/resource/SimulatorStorageProcessor.java  |2 +-
 .../network/lb/ElasticLoadBalancerManagerImpl.java |2 +-
 server/pom.xml |5 +
 .../configuration/ConfigurationManagerImpl.java|5 +
 .../consoleproxy/ConsoleProxyManagerImpl.java  |6 +-
 .../main/java/com/cloud/hypervisor/KVMGuru.java|   50 +
 .../kvm/discoverer/LibvirtServerDiscoverer.java|6 +-
 .../network/element/ConfigDriveNetworkElement.java |   13 +-
 .../router/VirtualNetworkApplianceManagerImpl.java |4 +-
 .../com/cloud/server/ConfigurationServerImpl.java  |4 +-
 .../core/spring-server-core-managers-context.xml   |2 +
 .../agent/lb/IndirectAgentLBServiceImpl.java   |  231 +++
 .../IndirectAgentLBRoundRobinAlgorithm.java|   59 +
 .../algorithm/IndirectAgentLBShuffleAlgorithm.java |   44 +
 .../algorithm/IndirectAgentLBStaticAlgorithm.java  |   50 +-
 .../src/test/resources/createNetworkOffering.xml   |1 +
 server/src/test/resources/testContext.xml  |7 +-
 server/test/com/cloud/hypervisor/KVMGuruTest.java  |   99 +
 .../agent/lb/IndirectAgentLBServiceImplTest.java   |  208 ++
 .../IndirectAgentLBRoundRobinAlgorithmTest.java|   76 +
 .../IndirectAgentLBShuffleAlgorithmTest.java   |   60 +
 .../IndirectAgentLBStaticAlgorithmTest.java|   49 +
 .../SecondaryStorageManagerImpl.java   |9 +-
 systemvm/debian/opt/cloud/bin/checkrouter.sh   |7 +
 .../opt/cloud/templates/check_heartbeat.sh.templ   |   78 +-
 .../plugins/nuagevsp/libVSD/__init__.py|   22 +-
 test/integration/plugins/nuagevsp/libVSD/client.py |  135 ++
 .../integration/plugins/nuagevsp/libVSD/helpers.py |  602 ++
 test/integration/plugins/nuagevsp/nuageTestCase.py |  319 ++-
 .../plugins/nuagevsp/nuage_test_data.py| 2177 
 .../plugins/nuagevsp/test_nuage_configdrive.py |  173 +-
 .../plugins/nuagevsp/test_nuage_extra_dhcp.py  |   26 +-
 .../plugins/nuagevsp/test_nuage_internal_dns.py|  400 +---
 .../nuagevsp/test_nuage_network_migration.py   |   24 -
 .../plugins/nuagevsp/test_nuage_password_reset.py  |   11 +-
 .../test_nuage_public_sharednetwork_userdata.py|   13 +-
 .../plugins/nuagevsp/test_nuage_source_nat.py  |   19 +-
 .../plugins/nuagevsp/test_nuage_static_nat.py  |   19 +-
 .../plugins/nuagevsp/test_nuage_vpc_internal_lb.py |  250 +--
 .../nuagevsp/test_nuage_vsp_domain_template.py |4 +
 .../nuagevsp/test_nuage_vsp_mngd_subnets.py|  157 +-
 test/integration/smoke/test_service_offerings.py   |  169 +-
 tools/marvin/marvin/config/test_data.py|  876 ++--
 tools/marvin/setup.py  |2 +-
 .../src/main/java/com/cloud/utils/StringUtils.java |8 +-
 .../test/java/com/cloud/utils/StringUtilsTest.java |   11 +-
 71 files changed, 3624 insertions(+), 3637 deletions(-)

diff --cc 
engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java
index 4b80fb1,000..6091131
mode 100644,00..100644
--- 

[GitHub] rhtyd commented on issue #2471: CLOUDSTACK-10311 Agent Log Rotate variable replace bug

[GitBox]

rhtyd commented on issue #2471: CLOUDSTACK-10311 Agent Log Rotate variable 
replace bug
URL: https://github.com/apache/cloudstack/pull/2471#issuecomment-373339530
 
 
   Can you check the build failures @Slair1 ? (See travis for details, or 
confirm you're able to build without failures?).
   
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2471: CLOUDSTACK-10311 Agent Log Rotate variable replace bug

[GitBox]

blueorangutan commented on issue #2471: CLOUDSTACK-10311 Agent Log Rotate 
variable replace bug
URL: https://github.com/apache/cloudstack/pull/2471#issuecomment-373339568
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch 4.11 updated: CLOUDSTACK-10132: Extend support for management servers LB for agents (#2469)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.11 by this push:
 new 30175d6  CLOUDSTACK-10132: Extend support for management servers LB 
for agents (#2469)
30175d6 is described below

commit 30175d6879ff323f0e1abac71a9fe3a7232f8b61
Author: Rohit Yadav 
AuthorDate: Thu Mar 15 16:34:03 2018 +0530

CLOUDSTACK-10132: Extend support for management servers LB for agents 
(#2469)

The new CA framework introduced basic support for comma-separated
list of management servers for agent, which makes an external LB
unnecessary.

This extends that feature to implement LB sorting algorithms that
sorts the management server list before they are sent to the agents.
This adds a central intelligence in the management server and adds
additional enhancements to Agent class to be algorithm aware and
have a background mechanism to check/fallback to preferred management
server (assumed as the first in the list). This is support for any
indirect agent such as the KVM, CPVM and SSVM agent, and would
provide support for management server host migration during upgrade
(when instead of in-place, new hosts are used to setup new mgmt server).

This FR introduces two new global settings:

- `indirect.agent.lb.algorithm`: The algorithm for the indirect agent LB.
- `indirect.agent.lb.check.interval`: The preferred host check interval
  for the agent's background task that checks and switches to agent's
  preferred host.

The indirect.agent.lb.algorithm supports following algorithm options:

- static: use the list as provided.
- roundrobin: evenly spreads hosts across management servers based on
  host's id.
- shuffle: (pseudo) randomly sorts the list (not recommended for 
production).

Any changes to the global settings - `indirect.agent.lb.algorithm` and
`host` does not require restarting of the mangement server(s) and the
agents. A message bus based system dynamically reacts to change in these
global settings and propagates them to all connected agents.

Comma-separated management server list is propagated to agents on
following cases:
- Addition of a host (including ssvm, cpvm systevms).
- Connection or reconnection by the agents to a management server.
- After admin changes the 'host' and/or the
  'indirect.agent.lb.algorithm' global settings.

On the agent side, the 'host' setting is saved in its properties file as:
`host=@`.

First the agent connects to the management server and sends its current
management server list, which is compared by the management server and
in case of failure a new/update list is sent for the agent to persist.

From the agent's perspective, the first address in the propagated list
will be considered the preferred host. A new background task can be
activated by configuring the `indirect.agent.lb.check.interval` which is
a cluster level global setting from CloudStack and admins can also
override this by configuring the 'host.lb.check.interval' in the
`agent.properties` file.

Every time agent gets a ms-host list and the algorithm, the host specific
background check interval is also sent and it dynamically reconfigures
the background task without need to restart agents.

Note: The 'static' and 'roundrobin' algorithms, strictly checks for the
order as expected by them, however, the 'shuffle' algorithm just checks
for content and not the order of the comma separate ms host addresses.

Signed-off-by: Rohit Yadav 
---
 agent/conf/agent.properties|  11 +
 agent/src/com/cloud/agent/Agent.java   | 119 +--
 agent/src/com/cloud/agent/AgentShell.java  |  58 +-
 agent/src/com/cloud/agent/IAgentShell.java |  45 ++--
 agent/test/com/cloud/agent/AgentShellTest.java |   8 +-
 .../cloudstack/config/ApiServiceConfiguration.java |   4 +-
 client/pom.xml |   5 +
 core/src/com/cloud/agent/api/ReadyCommand.java |  31 ++-
 core/src/com/cloud/agent/api/StartupCommand.java   |   9 +
 .../cloudstack/agent/lb/SetupMSListAnswer.java}|  46 +---
 .../cloudstack/agent/lb/SetupMSListCommand.java}   |  46 ++--
 engine/orchestration/pom.xml   |   5 +
 .../com/cloud/agent/manager/AgentManagerImpl.java  |  25 ++-
 framework/agent-lb/pom.xml |  32 +++
 .../cloudstack/agent/lb/IndirectAgentLB.java   |  53 +
 .../agent/lb/IndirectAgentLBAlgorithm.java |  45 
 framework/pom.xml  |   3 +-
 .../network/lb/ElasticLoadBalancerManagerImpl.java |   2 +-
 server/pom.xml 

[GitHub] rhtyd closed pull request #2469: CLOUDSTACK-10132: Extend support for management servers LB for agents

[GitBox]

rhtyd closed pull request #2469: CLOUDSTACK-10132: Extend support for 
management servers LB for agents
URL: https://github.com/apache/cloudstack/pull/2469
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/agent/conf/agent.properties b/agent/conf/agent.properties
index 0354aceadab..ad35b96bab6 100644
--- a/agent/conf/agent.properties
+++ b/agent/conf/agent.properties
@@ -30,6 +30,17 @@ workers=5
 #host= The IP address of management server
 host=localhost
 
+# The time interval in seconds after which agent will check if connected host
+# is the preferred host (the first host in the comma-separated list is 
preferred
+# one) and will attempt to reconnect to the preferred host when it's connected
+# to one of the secondary/backup hosts. The timer task is scheduled after agent
+# connects to a management server. On connection, it receives admin configured
+# cluster-level 'indirect.agent.lb.check.interval' setting that will be used by
+# the agent as the preferred host check interval however the following setting
+# if defined overrides the received value. The value 0 and lb algorithm 
'shuffle'
+# disables this background task.
+#host.lb.check.interval=0
+
 #port = The port management server listening on, default is 8250
 port=8250
 
diff --git a/agent/src/com/cloud/agent/Agent.java 
b/agent/src/com/cloud/agent/Agent.java
index 1c5417bf767..32112540c1c 100644
--- a/agent/src/com/cloud/agent/Agent.java
+++ b/agent/src/com/cloud/agent/Agent.java
@@ -21,6 +21,8 @@
 import java.io.PrintWriter;
 import java.io.StringWriter;
 import java.net.InetAddress;
+import java.net.InetSocketAddress;
+import java.net.Socket;
 import java.net.UnknownHostException;
 import java.nio.channels.ClosedChannelException;
 import java.nio.charset.Charset;
@@ -38,12 +40,15 @@
 import javax.naming.ConfigurationException;
 
 import 
org.apache.cloudstack.agent.directdownload.SetupDirectDownloadCertificate;
+import org.apache.cloudstack.agent.lb.SetupMSListAnswer;
+import org.apache.cloudstack.agent.lb.SetupMSListCommand;
 import org.apache.cloudstack.ca.SetupCertificateAnswer;
 import org.apache.cloudstack.ca.SetupCertificateCommand;
 import org.apache.cloudstack.ca.SetupKeyStoreCommand;
 import org.apache.cloudstack.ca.SetupKeystoreAnswer;
 import org.apache.cloudstack.managed.context.ManagedContextTimerTask;
 import org.apache.cloudstack.utils.security.KeyStoreUtils;
+import org.apache.commons.collections.CollectionUtils;
 import org.apache.commons.io.FileUtils;
 import org.apache.log4j.Logger;
 import org.slf4j.MDC;
@@ -65,6 +70,7 @@
 import com.cloud.exception.AgentControlChannelException;
 import com.cloud.resource.ServerResource;
 import com.cloud.utils.PropertiesUtil;
+import com.cloud.utils.StringUtils;
 import com.cloud.utils.backoff.BackoffAlgorithm;
 import com.cloud.utils.concurrency.NamedThreadFactory;
 import com.cloud.utils.exception.CloudRuntimeException;
@@ -121,6 +127,7 @@ public int value() {
 Long _id;
 
 Timer _timer = new Timer("Agent Timer");
+Timer hostLBTimer;
 
 List _watchList = new ArrayList();
 long _sequence = 0;
@@ -144,7 +151,7 @@ public Agent(final IAgentShell shell) {
 _shell = shell;
 _link = null;
 
-_connection = new NioClient("Agent", _shell.getHost(), 
_shell.getPort(), _shell.getWorkers(), this);
+_connection = new NioClient("Agent", _shell.getNextHost(), 
_shell.getPort(), _shell.getWorkers(), this);
 
 Runtime.getRuntime().addShutdownHook(new ShutdownThread(this));
 
@@ -179,7 +186,7 @@ public Agent(final IAgentShell shell, final int 
localAgentId, final ServerResour
 throw new ConfigurationException("Unable to configure " + 
_resource.getName());
 }
 
-final String host = _shell.getHost();
+final String host = _shell.getNextHost();
 _connection = new NioClient("Agent", host, _shell.getPort(), 
_shell.getWorkers(), this);
 
 // ((NioClient)_connection).setBindAddress(_shell.getPrivateIp());
@@ -255,7 +262,7 @@ public void start() {
 s_logger.info("Attempted to connect to the server, but received an 
unexpected exception, trying again...");
 }
 while (!_connection.isStartup()) {
-final String host = _shell.getHost();
+final String host = _shell.getNextHost();
 _shell.getBackoffAlgorithm().waitBeforeRetry();
 _connection = new NioClient("Agent", host, _shell.getPort(), 
_shell.getWorkers(), this);
 s_logger.info("Connecting to host:" + host);
@@ -266,6 +273,7 @@ public void start() {
 s_logger.info("Attempted to connect to the server, but 
received an unexpected exception, trying again...");
 }
 }
+

[GitHub] rhtyd commented on issue #2469: CLOUDSTACK-10132: Extend support for management servers LB for agents

[GitBox]

rhtyd commented on issue #2469: CLOUDSTACK-10132: Extend support for management 
servers LB for agents
URL: https://github.com/apache/cloudstack/pull/2469#issuecomment-373339040
 
 
   Thanks, merging this based on test results and two LGTMs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch 4.11 updated: CLOUDSTACK-10296: Find time different from last timestamp (#2458)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.11 by this push:
 new ab0bce2  CLOUDSTACK-10296: Find time different from last timestamp 
(#2458)
ab0bce2 is described below

commit ab0bce2a1baa4e199a447e3f2d74ca93c026a037
Author: Rohit Yadav 
AuthorDate: Thu Mar 15 16:32:18 2018 +0530

CLOUDSTACK-10296: Find time different from last timestamp (#2458)

This fixes a difference issue in rVR heartbeat check script raised
recently on dev@.
Reduce logging to avoid logging to fill ramdisk
Make checkrouter return fault state when keepalived is not running

Signed-off-by: Rohit Yadav 
---
 systemvm/debian/opt/cloud/bin/checkrouter.sh   |  7 ++
 .../opt/cloud/templates/check_heartbeat.sh.templ   | 78 --
 2 files changed, 48 insertions(+), 37 deletions(-)

diff --git a/systemvm/debian/opt/cloud/bin/checkrouter.sh 
b/systemvm/debian/opt/cloud/bin/checkrouter.sh
index 0a9041b..bb6c9f8 100755
--- a/systemvm/debian/opt/cloud/bin/checkrouter.sh
+++ b/systemvm/debian/opt/cloud/bin/checkrouter.sh
@@ -17,6 +17,13 @@
 # under the License.
 
 STATUS=UNKNOWN
+
+if [ "$(systemctl is-active keepalived)" != "active" ]
+then
+echo "Status: FAULT"
+exit
+fi
+
 ROUTER_TYPE=$(cat /etc/cloudstack/cmdline.json | grep type | awk '{print $2;}' 
| sed -e 's/[,\"]//g')
 if [ "$ROUTER_TYPE" = "router" ]
 then
diff --git a/systemvm/debian/opt/cloud/templates/check_heartbeat.sh.templ 
b/systemvm/debian/opt/cloud/templates/check_heartbeat.sh.templ
index 2ab9aba..62a2b18 100755
--- a/systemvm/debian/opt/cloud/templates/check_heartbeat.sh.templ
+++ b/systemvm/debian/opt/cloud/templates/check_heartbeat.sh.templ
@@ -16,48 +16,52 @@
 # specific language governing permissions and limitations
 # under the License.
 
-ROUTER_BIN_PATH=/ramdisk/rrouter
-ROUTER_LOG=${ROUTER_BIN_PATH}/keepalived.log
+ROUTER_BIN_PATH="/ramdisk/rrouter"
+ROUTER_LOG="${ROUTER_BIN_PATH}/keepalived.log"
 STRIKE_FILE="$ROUTER_BIN_PATH/keepalived.strikes"
+TS_FILE="$ROUTER_BIN_PATH/keepalived.ts"
+CT_FILE="$ROUTER_BIN_PATH/keepalived.ct"
 
-if [ -e $ROUTER_BIN_PATH/keepalived.ts2 ]
+checktime=$(date +%s)
+hbtime=$(cat $TS_FILE)
+diff=$(($checktime - $hbtime))
+
+lastcheck=0
+if [ -e $CT_FILE ]
+then
+lastcheck=$(cat $CT_FILE 2>/dev/null)
+fi
+checkdiff=$(($checktime - $lastcheck))
+if [ $checkdiff -ge 0 ] && [ $checkdiff -lt 30 ]
+then
+exit
+fi
+echo $checktime > $CT_FILE
+
+s=0
+if [ $diff -gt 10 ]
 then
-thistime=$(cat $ROUTER_BIN_PATH/keepalived.ts)
-lasttime=$(cat $ROUTER_BIN_PATH/keepalived.ts2)
-diff=$(($lasttime - $thistime))
-s=0
-if [ $diff -ge 10 ]
+if [ -e $STRIKE_FILE ]
 then
-if [ -e $STRIKE_FILE ]
-then
-s=`cat $STRIKE_FILE 2>/dev/null`
-fi
-s=$(($s+1))
-echo $s > $STRIKE_FILE
-else
-if [ -e $STRIKE_FILE ]
-then
-rm $STRIKE_FILE
-echo keepalived.strikes file was removed! >> $ROUTER_LOG
-else
-echo keepalived.strikes file does not exist! >> $ROUTER_LOG
-fi
+s=$(cat $STRIKE_FILE 2>/dev/null)
 fi
-#3 strikes rule
-if [ $s -gt 2 ]
-then
-echo Keepalived process is dead! >> $ROUTER_LOG
-systemctl stop keepalived >> $ROUTER_LOG 2>&1
-systemctl stop conntrackd >> $ROUTER_LOG 2>&1
+s=$(($s+1))
+echo $s > $STRIKE_FILE
+echo "Check time: $checktime, last heartbeat time: $hbtime, time diff: 
$diff, strike count: $s" >> $ROUTER_LOG
+else
+rm -f $STRIKE_FILE
+fi
+
+if [ $s -gt 3 ]
+then
+systemctl stop --now keepalived >> $ROUTER_LOG 2>&1
+systemctl stop --now conntrackd >> $ROUTER_LOG 2>&1
 
-#Set fault so we have the same effect as a KeepaliveD fault.
-python /opt/cloud/bin/master.py --fault
+#Set fault so we have the same effect as a KeepaliveD fault.
+python /opt/cloud/bin/master.py --fault
 
-pkill -9 keepalived >> $ROUTER_LOG 2>&1
-pkill -9 conntrackd >> $ROUTER_LOG 2>&1
-echo Status: FAULT \(keepalived process is dead\) >> $ROUTER_LOG
-exit
-fi
+pkill -9 keepalived >> $ROUTER_LOG 2>&1 || true
+pkill -9 conntrackd >> $ROUTER_LOG 2>&1 || true
+echo Status: FAULT \(keepalived process is dead\) >> $ROUTER_LOG
+exit
 fi
-
-cp $ROUTER_BIN_PATH/keepalived.ts $ROUTER_BIN_PATH/keepalived.ts2

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[GitHub] blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

[GitBox]

blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different 
from last timestamp
URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-373338731
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed pull request #2458: CLOUDSTACK-10296: Find time different from last timestamp

[GitBox]

rhtyd closed pull request #2458: CLOUDSTACK-10296: Find time different from 
last timestamp
URL: https://github.com/apache/cloudstack/pull/2458
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/systemvm/debian/opt/cloud/bin/checkrouter.sh 
b/systemvm/debian/opt/cloud/bin/checkrouter.sh
index 0a9041bfbd1..bb6c9f8a0f2 100755
--- a/systemvm/debian/opt/cloud/bin/checkrouter.sh
+++ b/systemvm/debian/opt/cloud/bin/checkrouter.sh
@@ -17,6 +17,13 @@
 # under the License.
 
 STATUS=UNKNOWN
+
+if [ "$(systemctl is-active keepalived)" != "active" ]
+then
+echo "Status: FAULT"
+exit
+fi
+
 ROUTER_TYPE=$(cat /etc/cloudstack/cmdline.json | grep type | awk '{print $2;}' 
| sed -e 's/[,\"]//g')
 if [ "$ROUTER_TYPE" = "router" ]
 then
diff --git a/systemvm/debian/opt/cloud/templates/check_heartbeat.sh.templ 
b/systemvm/debian/opt/cloud/templates/check_heartbeat.sh.templ
index 2ab9abaa8a4..62a2b180e6c 100755
--- a/systemvm/debian/opt/cloud/templates/check_heartbeat.sh.templ
+++ b/systemvm/debian/opt/cloud/templates/check_heartbeat.sh.templ
@@ -16,48 +16,52 @@
 # specific language governing permissions and limitations
 # under the License.
 
-ROUTER_BIN_PATH=/ramdisk/rrouter
-ROUTER_LOG=${ROUTER_BIN_PATH}/keepalived.log
+ROUTER_BIN_PATH="/ramdisk/rrouter"
+ROUTER_LOG="${ROUTER_BIN_PATH}/keepalived.log"
 STRIKE_FILE="$ROUTER_BIN_PATH/keepalived.strikes"
+TS_FILE="$ROUTER_BIN_PATH/keepalived.ts"
+CT_FILE="$ROUTER_BIN_PATH/keepalived.ct"
 
-if [ -e $ROUTER_BIN_PATH/keepalived.ts2 ]
+checktime=$(date +%s)
+hbtime=$(cat $TS_FILE)
+diff=$(($checktime - $hbtime))
+
+lastcheck=0
+if [ -e $CT_FILE ]
+then
+lastcheck=$(cat $CT_FILE 2>/dev/null)
+fi
+checkdiff=$(($checktime - $lastcheck))
+if [ $checkdiff -ge 0 ] && [ $checkdiff -lt 30 ]
+then
+exit
+fi
+echo $checktime > $CT_FILE
+
+s=0
+if [ $diff -gt 10 ]
 then
-thistime=$(cat $ROUTER_BIN_PATH/keepalived.ts)
-lasttime=$(cat $ROUTER_BIN_PATH/keepalived.ts2)
-diff=$(($lasttime - $thistime))
-s=0
-if [ $diff -ge 10 ]
+if [ -e $STRIKE_FILE ]
 then
-if [ -e $STRIKE_FILE ]
-then
-s=`cat $STRIKE_FILE 2>/dev/null`
-fi
-s=$(($s+1))
-echo $s > $STRIKE_FILE
-else
-if [ -e $STRIKE_FILE ]
-then
-rm $STRIKE_FILE
-echo keepalived.strikes file was removed! >> $ROUTER_LOG
-else
-echo keepalived.strikes file does not exist! >> $ROUTER_LOG
-fi
+s=$(cat $STRIKE_FILE 2>/dev/null)
 fi
-#3 strikes rule
-if [ $s -gt 2 ]
-then
-echo Keepalived process is dead! >> $ROUTER_LOG
-systemctl stop keepalived >> $ROUTER_LOG 2>&1
-systemctl stop conntrackd >> $ROUTER_LOG 2>&1
+s=$(($s+1))
+echo $s > $STRIKE_FILE
+echo "Check time: $checktime, last heartbeat time: $hbtime, time diff: 
$diff, strike count: $s" >> $ROUTER_LOG
+else
+rm -f $STRIKE_FILE
+fi
+
+if [ $s -gt 3 ]
+then
+systemctl stop --now keepalived >> $ROUTER_LOG 2>&1
+systemctl stop --now conntrackd >> $ROUTER_LOG 2>&1
 
-#Set fault so we have the same effect as a KeepaliveD fault.
-python /opt/cloud/bin/master.py --fault
+#Set fault so we have the same effect as a KeepaliveD fault.
+python /opt/cloud/bin/master.py --fault
 
-pkill -9 keepalived >> $ROUTER_LOG 2>&1
-pkill -9 conntrackd >> $ROUTER_LOG 2>&1
-echo Status: FAULT \(keepalived process is dead\) >> $ROUTER_LOG
-exit
-fi
+pkill -9 keepalived >> $ROUTER_LOG 2>&1 || true
+pkill -9 conntrackd >> $ROUTER_LOG 2>&1 || true
+echo Status: FAULT \(keepalived process is dead\) >> $ROUTER_LOG
+exit
 fi
-
-cp $ROUTER_BIN_PATH/keepalived.ts $ROUTER_BIN_PATH/keepalived.ts2


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

[GitBox]

rhtyd commented on issue #2458: CLOUDSTACK-10296: Find time different from last 
timestamp
URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-373338575
 
 
   Merging this based on test results and review LGTMs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

[GitBox]

rafaelweingartner commented on issue #2486: [CLOUDSTACK-10323] Allow changing 
disk offering during volume migration 
URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-373338067
 
 
   Did you pushed your changes to your branch in the remote repository?
   I am checking your branch, but there is no new commit there.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd opened a new pull request #2488: smaller systemvm images using sparse disks.

[GitBox]

rhtyd opened a new pull request #2488: smaller systemvm images using sparse 
disks.
URL: https://github.com/apache/cloudstack/pull/2488
 
 
   This is from @PaulAngus 's PR https://github.com/apache/cloudstack/pull/2477 
towards 4.11.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: CLOUDSTACK-10268: Fix and enhance package script (#2433)

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 1708838  CLOUDSTACK-10268: Fix and enhance package script (#2433)
1708838 is described below

commit 1708838518299d5d04f810d0d01cfb4faf425b03
Author: Khosrow Moossavi 
AuthorDate: Thu Mar 15 06:55:29 2018 -0400

CLOUDSTACK-10268: Fix and enhance package script (#2433)

- new flag `-T, --use-timestamp` to use `timestamp` when POM version 
contains SNAPSHOT
  - in the final artifacts (jar) name
  - in the final package (rpm, deb) name
  - in `/etc/cloudstack-release` file of SystemVMs
  - in the Management Server > About dialog
- if there's a "branding" string in the POM version (e.g. 
`x.y.z.a-NAME[-SNAPSHOT]`),
the branding name will be used in the final generated pacakge name such as 
following:
  - `cloudstack-management-x.y.z.a-NAME.NUMBER.el7.centos.x86_64`
  - `cloudstack-management_x.y.z.a-NAME-NUMBER~xenial_all.deb`
- branding string can be overriden with newly added `-b, --brand` flag
- handle the new format version for VR version
- fix long opts (they were broken)
- tolerate and show a warning message for unrecognized flags
- usage help reformat

* Deprecate Version class in favor or CloudStackVersion
---
 .../cloud/upgrade/DatabaseIntegrityChecker.java|   5 +-
 packaging/build-deb.sh |  94 +-
 packaging/centos63/cloud.spec  |   7 +-
 packaging/centos7/cloud.spec   |   7 +-
 packaging/package.sh   | 190 +++--
 .../api/query/dao/DomainRouterJoinDaoImpl.java |  11 +-
 .../cloud/network/router/NetworkHelperImpl.java|  11 +-
 tools/appliance/build.sh   |  16 +-
 tools/build/setnextversion.sh  | 143 +++-
 utils/src/main/java/com/cloud/maint/Version.java   |  77 -
 .../nicira/nvp/plugin/NiciraNvpApiVersion.java |   8 +-
 .../apache/cloudstack/utils/CloudStackVersion.java | 152 +++--
 .../cloudstack/utils/CloudStackVersionTest.java| 143 +---
 13 files changed, 574 insertions(+), 290 deletions(-)

diff --git 
a/engine/schema/src/main/java/com/cloud/upgrade/DatabaseIntegrityChecker.java 
b/engine/schema/src/main/java/com/cloud/upgrade/DatabaseIntegrityChecker.java
index 6111fb1..bb75aac 100644
--- 
a/engine/schema/src/main/java/com/cloud/upgrade/DatabaseIntegrityChecker.java
+++ 
b/engine/schema/src/main/java/com/cloud/upgrade/DatabaseIntegrityChecker.java
@@ -26,7 +26,8 @@ import javax.inject.Inject;
 import org.apache.log4j.Logger;
 import org.springframework.stereotype.Component;
 
-import com.cloud.maint.Version;
+import org.apache.cloudstack.utils.CloudStackVersion;
+
 import com.cloud.upgrade.dao.VersionDao;
 import com.cloud.utils.component.AdapterBase;
 import com.cloud.utils.component.ComponentLifecycle;
@@ -210,7 +211,7 @@ public class DatabaseIntegrityChecker extends AdapterBase 
implements SystemInteg
 return false;
 }
 
-if (Version.compare(Version.trimToPatch(dbVersion), 
Version.trimToPatch("2.2.8")) != 0) {
+if (CloudStackVersion.compare(dbVersion, "2.2.8") != 0) {
 txn.commit();
 return true;
 }
diff --git a/packaging/build-deb.sh b/packaging/build-deb.sh
index d8f2f8f..52a168a 100755
--- a/packaging/build-deb.sh
+++ b/packaging/build-deb.sh
@@ -40,18 +40,104 @@
 # docker run -ti -v /tmp:/src ubuntu:14.04 /bin/bash -c "apt-get update && 
apt-get install -y dpkg-dev python debhelper openjdk-8-jdk genisoimage 
python-mysql.connector maven lsb-release devscripts dh-systemd 
python-setuptools && /src/cloudstack/packaging/build-deb.sh"
 #
 
-cd `dirname $0`
-cd ..
+function usage() {
+cat << USAGE
+Usage: ./build-deb.sh [OPTIONS]...
+Package CloudStack for Debian based distribution.
+
+If there's a "branding" string in the POM version (e.g. 
x.y.z.a-NAME[-SNAPSHOT]), the branding name will
+be used in the final generated pacakge like: 
cloudstack-management_x.y.z.a-NAME-SNAPSHOT~xenial_all.deb
+note that you can override/provide "branding" string with "-b, --brand" flag 
as well.
+
+Optional arguments:
+   -b, --brand string  Set branding to be used in package 
name (it will override any branding string in POM version)
+   -T, --use-timestamp Use epoch timestamp instead of 
SNAPSHOT in the package name (if not provided, use "SNAPSHOT")
+
+Other arguments:
+   -h, --help  Display this help message and exit
+
+Examples:
+   build-deb.sh --use-timestamp
+   build-deb.sh --brand foo
+
+USAGE
+exit 0
+}
+
+BRANDING=""
+USE_TIMESTAMP="false"

[GitHub] DaanHoogland closed pull request #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

DaanHoogland closed pull request #2433: CLOUDSTACK-10268: Fix and enhance 
package script
URL: https://github.com/apache/cloudstack/pull/2433
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/engine/schema/src/main/java/com/cloud/upgrade/DatabaseIntegrityChecker.java 
b/engine/schema/src/main/java/com/cloud/upgrade/DatabaseIntegrityChecker.java
index 6111fb16cf2..bb75aacf2b6 100644
--- 
a/engine/schema/src/main/java/com/cloud/upgrade/DatabaseIntegrityChecker.java
+++ 
b/engine/schema/src/main/java/com/cloud/upgrade/DatabaseIntegrityChecker.java
@@ -26,7 +26,8 @@
 import org.apache.log4j.Logger;
 import org.springframework.stereotype.Component;
 
-import com.cloud.maint.Version;
+import org.apache.cloudstack.utils.CloudStackVersion;
+
 import com.cloud.upgrade.dao.VersionDao;
 import com.cloud.utils.component.AdapterBase;
 import com.cloud.utils.component.ComponentLifecycle;
@@ -210,7 +211,7 @@ private boolean checkMissedPremiumUpgradeFor228() {
 return false;
 }
 
-if (Version.compare(Version.trimToPatch(dbVersion), 
Version.trimToPatch("2.2.8")) != 0) {
+if (CloudStackVersion.compare(dbVersion, "2.2.8") != 0) {
 txn.commit();
 return true;
 }
diff --git a/packaging/build-deb.sh b/packaging/build-deb.sh
index d8f2f8f09b0..52a168a95ba 100755
--- a/packaging/build-deb.sh
+++ b/packaging/build-deb.sh
@@ -40,18 +40,104 @@
 # docker run -ti -v /tmp:/src ubuntu:14.04 /bin/bash -c "apt-get update && 
apt-get install -y dpkg-dev python debhelper openjdk-8-jdk genisoimage 
python-mysql.connector maven lsb-release devscripts dh-systemd 
python-setuptools && /src/cloudstack/packaging/build-deb.sh"
 #
 
-cd `dirname $0`
-cd ..
+function usage() {
+cat << USAGE
+Usage: ./build-deb.sh [OPTIONS]...
+Package CloudStack for Debian based distribution.
+
+If there's a "branding" string in the POM version (e.g. 
x.y.z.a-NAME[-SNAPSHOT]), the branding name will
+be used in the final generated pacakge like: 
cloudstack-management_x.y.z.a-NAME-SNAPSHOT~xenial_all.deb
+note that you can override/provide "branding" string with "-b, --brand" flag 
as well.
+
+Optional arguments:
+   -b, --brand string  Set branding to be used in package 
name (it will override any branding string in POM version)
+   -T, --use-timestamp Use epoch timestamp instead of 
SNAPSHOT in the package name (if not provided, use "SNAPSHOT")
+
+Other arguments:
+   -h, --help  Display this help message and exit
+
+Examples:
+   build-deb.sh --use-timestamp
+   build-deb.sh --brand foo
+
+USAGE
+exit 0
+}
+
+BRANDING=""
+USE_TIMESTAMP="false"
+
+while [ -n "$1" ]; do
+case "$1" in
+-h | --help)
+usage
+;;
+
+-b | --brand)
+if [ -n "$BRANDING" ]; then
+echo "ERROR: you have already entered value for -b, --brand"
+exit 1
+else
+BRANDING=$2
+shift 2
+fi
+;;
+
+-T | --use-timestamp)
+if [ "$USE_TIMESTAMP" == "true" ]; then
+echo "ERROR: you have already entered value for -T, 
--use-timestamp"
+exit 1
+else
+USE_TIMESTAMP="true"
+shift 1
+fi
+;;
+
+-*|*)
+echo "ERROR: no such option $1. -h or --help for help"
+exit 1
+;;
+esac
+done
 
 DCH=$(which dch)
 if [ -z "$DCH" ] ; then
 echo -e "dch not found, please install devscripts at first. \nDEB Build 
Failed"
-exit
+exit 1
 fi
 
+NOW="$(date +%s)"
+PWD=$(cd $(dirname "$0") && pwd -P)
+cd $PWD/../
+
 VERSION=$(head -n1 debian/changelog  |awk -F [\(\)] '{print $2}')
 DISTCODE=$(lsb_release -sc)
 
+if [ "$USE_TIMESTAMP" == "true" ]; then
+# use timestamp instead of SNAPSHOT
+if echo "$VERSION" | grep -q SNAPSHOT ; then
+# apply/override branding, if provided
+if [ "$BRANDING" != "" ]; then
+VERSION=$(echo "$VERSION" | cut -d '-' -f 1) # remove any existing 
branding from POM version to be overriden
+VERSION="$VERSION-$BRANDING-$NOW"
+else
+VERSION=`echo $VERSION | sed 's/-SNAPSHOT/-'$NOW'/g'`
+fi
+
+branch=$(cd $PWD; git rev-parse --abbrev-ref HEAD)
+(cd $PWD; ./tools/build/setnextversion.sh --version $VERSION 
--sourcedir . --branch $branch --no-commit)
+fi
+else
+# apply/override branding, if provided
+if [ "$BRANDING" != "" ]; then
+VERSION=$(echo "$VERSION" | cut -d '-' -f 1) # remove any existing 
branding from POM version to be overriden
+ 

[GitHub] rhtyd closed pull request #2477: Smaller systemvm images using sparse disks.

[GitBox]

rhtyd closed pull request #2477: Smaller systemvm images using sparse disks.
URL: https://github.com/apache/cloudstack/pull/2477
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):



 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

[GitBox]

borisstoyanov commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk 
offering during volume migration 
URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-373336567
 
 
   I'm not sure I'm doing this right.. but git says there's nothing to 
compare.. 
   ![screen shot 2018-03-15 at 12 51 
51](https://user-images.githubusercontent.com/13551960/37459115-c621161e-284f-11e8-8e42-c28590568c96.png)
   any idea? @rafaelweingartner 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

[GitBox]

rafaelweingartner commented on issue #2486: [CLOUDSTACK-10323] Allow changing 
disk offering during volume migration 
URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-373328490
 
 
   Thanks!
   You can open a PR against my branch, then I can merge it here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2438: [CLOUDSTACK-10307] Remove unused things from HostDaoImpl

[GitBox]

blueorangutan commented on issue #2438: [CLOUDSTACK-10307] Remove unused things 
from HostDaoImpl
URL: https://github.com/apache/cloudstack/pull/2438#issuecomment-373321568
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2438: [CLOUDSTACK-10307] Remove unused things from HostDaoImpl

[GitBox]

borisstoyanov commented on issue #2438: [CLOUDSTACK-10307] Remove unused things 
from HostDaoImpl
URL: https://github.com/apache/cloudstack/pull/2438#issuecomment-373321486
 
 
   @blueorangutan test 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed pull request #2487: Dummy test PR

[GitBox]

rhtyd closed pull request #2487: Dummy test PR
URL: https://github.com/apache/cloudstack/pull/2487
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2487: Dummy test PR

[GitBox]

rhtyd commented on issue #2487: Dummy test PR
URL: https://github.com/apache/cloudstack/pull/2487#issuecomment-373320930
 
 
   Closing this PR, confirmed. Any new PR and its discussions end up on commits 
ML.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd opened a new pull request #2487: Dummy test PR

[GitBox]

rhtyd opened a new pull request #2487: Dummy test PR
URL: https://github.com/apache/cloudstack/pull/2487
 
 
   This is a PR to see if new PRs with any JIRA id will end up commits ML. 
Also, how projects can work here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

[GitBox]

borisstoyanov commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk 
offering during volume migration 
URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-373318892
 
 
   @rafaelweingartner I've created a marvin test but I'm not able to push to 
your repo. How can I contribute?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services