[GitHub] marcaurele commented on issue #2526: add issue template for github issues
marcaurele commented on issue #2526: add issue template for github issues URL: https://github.com/apache/cloudstack/pull/2526#issuecomment-378481686 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS)
rafaelweingartner commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS) URL: https://github.com/apache/cloudstack/pull/2524#issuecomment-378425437 @resmo yes there is a reason. The possibility of getting conflicts and having to solve them when merging forward to 4.12. It took me over 16 hours to track all of the problems after I updated the library. The Javascript part of ACS and the ad-hoc framework that we have to generate pages is pretty annoying to debug and track problems; especially when there is no error or stack trace. Sometimes information was not appearing, or windows were rendered in an odd way, and I needed to track what was going on under the hood debugging from the most basic method that I knew until the "framework" that is generating HTML elements at runtime. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS)
rafaelweingartner commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS) URL: https://github.com/apache/cloudstack/pull/2524#issuecomment-378425437 @resmo yes. The possibility of getting conflicts and having to solve them when merging forward to 4.12. It took me over 16 hours to track all of the problems. The Javascript part of ACS and the ad-hoc framework that we have to generate pages is pretty annoying to debug and track problems; especially when there is no error or stack trace. Sometimes information was not appearing, or windows were rendered in an odd way, and I needed to track what was going on under the hood debugging from the most basic method that I knew, until the framework that as generating HTML elements in runtime. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] resmo commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS)
resmo commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS) URL: https://github.com/apache/cloudstack/pull/2524#issuecomment-378420250 Any reason not targeting 4.11.1 (4.11 branch) ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] resmo opened a new issue #2528: listVirtualMachines response ostypeid is foreign DB ID, not UUID
resmo opened a new issue #2528: listVirtualMachines response ostypeid is foreign DB ID, not UUID URL: https://github.com/apache/cloudstack/issues/2528 # ISSUE TYPE * Bug Report * Enhancement # COMPONENT NAME ~~~ API ~~~ # CLOUDSTACK VERSION ~~~ 4.11 ~~~ # CONFIGURATION N/A # OS / ENVIRONMENT N/A # SUMMARY The response of `listVirtualMachines` contains the ostypeid returned as foreignkey ID of the DB, instead of UUID # STEPS TO REPRODUCE ~~~ cs listVirtualMachines id=d949e443-9bc8-4399-9e09-842bbb395cae --region simulator | jq '.virtualmachine[].ostypeid' ~~~ # EXPECTED RESULTS ~~~ ... "ostypeid": "1ef04fab-4b9a-11e7-8fea-0242ac110003", ... ~~~ # ACTUAL RESULTS ~~~ ... "ostypeid": 142, ... ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] resmo opened a new issue #2527: listResourceDetails: ID is not UUID, but DB ID
resmo opened a new issue #2527: listResourceDetails: ID is not UUID, but DB ID URL: https://github.com/apache/cloudstack/issues/2527 # ISSUE TYPE * Enhancement * Bug # COMPONENT NAME ~~~ API ~~~ # CLOUDSTACK VERSION ~~~ 4.11 ~~~ # CONFIGURATION N/A # OS / ENVIRONMENT N/A # SUMMARY The respone of `listResourceDetails` includes an ID of the primary field not the UUID # STEPS TO REPRODUCE ~~~ $ cs listResourceDetails resourcetype=uservm resourceid=d949e443-9bc8-4399-9e09-842bbb395cae --region=simulator ~~~ # EXPECTED RESULTS ~~~ { "count": 3, "resourcedetail": [ { "fordisplay": true, "key": "foo", "resourceid": "d949e443-9bc8-4399-9e09-842bbb395cae", "resourcetype": "UserVm", "value": "bar" }, ~~~ # ACTUAL RESULTS ~~~ { "count": 3, "resourcedetail": [ { "fordisplay": true, "key": "foo", "resourceid": "5", "resourcetype": "UserVm", "value": "bar" }, ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] resmo opened a new pull request #2526: add issue template for github issues
resmo opened a new pull request #2526: add issue template for github issues URL: https://github.com/apache/cloudstack/pull/2526 ## Description Issue template for new github issues ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [X] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? ## Checklist: - [ ] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document. - [X] My code follows the code style of this project. - [X] My change requires a change to the documentation. - [X] I have updated the documentation accordingly. Testing - [ ] I have added tests to cover my changes. - [X] All relevant new and existing integration tests have passed. - [ ] A full integration testsuite with all test that can run on my environment has passed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] resmo opened a new issue #2525: details not in listVirtualMachines response
resmo opened a new issue #2525: details not in listVirtualMachines response URL: https://github.com/apache/cloudstack/issues/2525 # ISSUE TYPE * [X] Bug Report * [ ] Enhancement * [ ] Feature Idea * [ ] Documentation Report # COMPONENT NAME ~~~ API ~~~ # CLOUDSTACK VERSION ~~~ 4.11 ~~~ # CONFIGURATION N/A # OS / ENVIRONMENT N/A # SUMMARY listVirtualMachines does not return `details` as doc says. # STEPS TO REPRODUCE ```yaml cs listVirtualMachines id=d949e443-9bc8-4399-9e09-842bbb395cae --region simulator ``` # EXPECTED RESULTS the resource details as below should be included in listVirtualMachines response, as the documentation of the API says or the API doc should be updated. ~~~ cs listResourceDetails resourcetype=uservm resourceid=d949e443-9bc8-4399-9e09-842bbb395cae --region=simulator { "count": 3, "resourcedetail": [ { "fordisplay": true, "key": "foo", "resourceid": "5", "resourcetype": "UserVm", "value": "bar" }, { "fordisplay": true, "key": "Message.ReservedCapacityFreed.Flag", "resourceid": "5", "resourcetype": "UserVm", "value": "false" }, { "fordisplay": true, "key": "SSH.PublicKey", "resourceid": "5", "resourcetype": "UserVm", "value": "ssh-rsa B3NzaC1yc2EDAQABgQCalaJdHI7bK4qsCMSqJ1iq7K4YuHyjlkahPuSsbMrZInN2Mo1ehjieILocEITo8ck+rFkC4NHc6mvUDF3gdUZmWKpWYfc5eKsymOHgk05Nv1e+1TjvKGWaZprisUFXD+52PkQ6DcAZUDYw1yufxGfufYuK3WWzDHriSBIiaDEcgw== \n" } ] } ~~~ # ACTUAL RESULTS ~~~ { "count": 1, "virtualmachine": [ { "account": "admin", "affinitygroup": [ { "account": "admin", "id": "2d41d761-6d4e-400a-9f26-cc0d5ef6f884", "name": "ansible-test-titan-10437836-ag" } ], "cpunumber": 1, "cpuspeed": 500, "cpuused": "10%", "created": "2018-03-31T18:07:13+", "diskioread": 0, "diskiowrite": 0, "diskkbsread": 0, "diskkbswrite": 0, "displayname": "ansible-test-titan-10437836-display-1", "displayvm": true, "domain": "ROOT", "domainid": "1f1d6aa1-4b9a-11e7-8fea-0242ac110003", "guestosid": "1ef0010d-4b9a-11e7-8fea-0242ac110003", "haenable": false, "hostid": "41adc5d5-3b6a-4035-9913-7b14fa099c1f", "hostname": "SimulatedAgent.db961dea-4e46-48c6-983e-566712333810", "hypervisor": "Simulator", "id": "d949e443-9bc8-4399-9e09-842bbb395cae", "instancename": "i-2-5-VM", "isdynamicallyscalable": false, "keypair": "ansible-test-titan-10437836-sshkey", "memory": 512, "memoryintfreekbs": 0, "memorykbs": 0, "memorytargetkbs": 0, "name": "ansible-test-titan-10437836-vm-1", "networkkbsread": 148668416, "networkkbswrite": 74334208, "nic": [ { "broadcasturi": "vlan://untagged", "gateway": "60.147.41.1", "id": "8bee0927-6506-4a18-93bc-ccce070714a2", "ipaddress": "60.147.41.246", "isdefault": true, "macaddress": "06:ce:d4:00:01:f2", "netmask": "255.255.255.0", "networkid": "6f4007a0-ddba-4cdf-ac34-c9c0e5f049b8", "networkname": "guestNetworkForBasicZone", "secondaryip": [], "traffictype": "Guest", "type": "Shared" } ], "ostypeid": 142, "passwordenabled": false, "rootdeviceid": 0, "rootdevicetype": "ROOT", "securitygroup": [ { "account": "admin", "egressrule": [], "id": "abcdb1a7-4795-4aff-82a9-ca4347b017fd", "ingressrule": [], "name": "ansible-test-titan-10437836-sg", "tags": [], "virtualmachineids": [] } ], "serviceofferingid": "a9ad69ae-391d-43ba-97a8-5f33b78a955d", "serviceofferingname": "Small Instance", "state": "Running", "tags": [], "templatedisplaytext": "CentOS 5.6 (64-bit) no GUI (Simulator)", "templateid": "4f4c3063-4b9a-11e7-8fea-0242ac110003", "templatename": "CentOS 5.6 (64-bit) no GUI (Simulator)", "userid": "1f1daf4d-4b9a-11e7-8fea-0242ac110003", "username": "admin", "zoneid": "ab54814a-b8b9-4889-ae76-cae19c0c843f", "zonename": "Sandbox-simulator-basic" } ] } ~~~ -
[cloudstack] branch CLOUDSTACK-8766 deleted (was 26700fb)
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch CLOUDSTACK-8766 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 26700fb CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal template listing The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. -- To stop receiving notification emails like this one, please contact raf...@apache.org.
[cloudstack] branch CLOUDSTACK-8560 deleted (was 5fe0696)
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch CLOUDSTACK-8560 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 5fe0696 Merge branch 'CLOUDSTACK-8560' The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. -- To stop receiving notification emails like this one, please contact raf...@apache.org.
[cloudstack] branch CLOUDSTACK-8559 deleted (was 3e3c11f)
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch CLOUDSTACK-8559 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 3e3c11f CLOUDSTACK-8559: IP Source spoofing should not be allowed The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. -- To stop receiving notification emails like this one, please contact raf...@apache.org.
[cloudstack] branch CLOUDSTACK-8530 deleted (was 43a0b6b)
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch CLOUDSTACK-8530 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 43a0b6b CLOUDSTACK-8530: KVM hosts without active agents should be in Disconnected state The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. -- To stop receiving notification emails like this one, please contact raf...@apache.org.
[cloudstack] branch CLOUDSTACK-8489 deleted (was 3894d34)
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch CLOUDSTACK-8489 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 3894d34 CLOUDSTACK-8489: Set smbios information for guest The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. -- To stop receiving notification emails like this one, please contact raf...@apache.org.
[cloudstack] branch CLOUDSTACK-8243 deleted (was 6753bee)
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch CLOUDSTACK-8243 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 6753bee CLOUDSTACK-8243: KVM agent should not use hardcoded string tails The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. -- To stop receiving notification emails like this one, please contact raf...@apache.org.
[cloudstack] branch CLOUDSTACK-8313 deleted (was a7eae53)
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch CLOUDSTACK-8313 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was a7eae53 CLOUDSTACK-8313: Allow overprovisioning of local storage pools This change permanently discards the following revisions: discard a7eae53 CLOUDSTACK-8313: Allow overprovisioning of local storage pools -- To stop receiving notification emails like this one, please contact raf...@apache.org.
[cloudstack] branch CLOUDSTACK-8301 deleted (was 2148dca)
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch CLOUDSTACK-8301 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 2148dca CLOUDSTACK-8301: Enable configuring local storage use for system VMs at zone level. This commit contains the UI changes for the feature. The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. -- To stop receiving notification emails like this one, please contact raf...@apache.org.
[cloudstack] branch CLOUDSTACK-1302 deleted (was 10c1deb)
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch CLOUDSTACK-1302 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 10c1deb CLOUDSTACK-1302: Fix passing cacheMode to hypervisor This change permanently discards the following revisions: discard 10c1deb CLOUDSTACK-1302: Fix passing cacheMode to hypervisor discard 1bc8073 CLOUDSTACK-1302: Make sure the disk cache mode is passed to the KVM Agent -- To stop receiving notification emails like this one, please contact raf...@apache.org.
[cloudstack] branch CLOUDSTACK-10012 deleted (was a04da57)
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch CLOUDSTACK-10012 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was a04da57 CLOUDSTACK-10012: Migrate to Embedded Jetty The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. -- To stop receiving notification emails like this one, please contact raf...@apache.org.
[cloudstack] branch CLOUDSTACK-2554 deleted (was 76e19d5)
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch CLOUDSTACK-2554 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 76e19d5 CLOUDSTACK-2554: Incorrect compute of minmemory and cpu This change permanently discards the following revisions: discard 76e19d5 CLOUDSTACK-2554: Incorrect compute of minmemory and cpu discard fa086d0 CLOUDSTACK-2554: Ensuring that we honor hypervisor xen's memory constraints discard ac48c38 Fixing multiple minor annoyances: discard 66303b5 CLOUDSTACK-2554: CloudStack fails to load XCP 1.6 hypervisors discard 92b3138 Better parse domain XMLs so network devices can be detached as well -- To stop receiving notification emails like this one, please contact raf...@apache.org.
[cloudstack] branch 4.9-systemdubuntupkging deleted (was c8a52c9)
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch 4.9-systemdubuntupkging in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was c8a52c9 CLOUDSTACK-9462: Refactor systemd scripts The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. -- To stop receiving notification emails like this one, please contact raf...@apache.org.
[cloudstack] branch 4.9-bountycastle-daan deleted (was b9ee34f)
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch 4.9-bountycastle-daan in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was b9ee34f maven: Upgrade bouncy castle to version 1.55 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. -- To stop receiving notification emails like this one, please contact raf...@apache.org.
[cloudstack] branch 4.9.2.0-RC20161227T1309 deleted (was d410612)
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch 4.9.2.0-RC20161227T1309 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was d410612 Updating pom.xml version numbers for release 4.9.2.0 This change permanently discards the following revisions: discard d410612 Updating pom.xml version numbers for release 4.9.2.0 -- To stop receiving notification emails like this one, please contact raf...@apache.org.
[cloudstack] branch 4.9.0-RC20160725T1656 deleted (was 227ff38)
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch 4.9.0-RC20160725T1656 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 227ff38 Updating pom.xml version numbers for release 4.9.0 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. -- To stop receiving notification emails like this one, please contact raf...@apache.org.
[cloudstack] branch 4.8.2.0-RC20161210T0832 deleted (was 4a1f7ed)
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch 4.8.2.0-RC20161210T0832 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 4a1f7ed Updating pom.xml version numbers for release 4.8.2.0 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. -- To stop receiving notification emails like this one, please contact raf...@apache.org.
[cloudstack] branch 4.9.1.0-RC20161210T0838 deleted (was af26799)
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch 4.9.1.0-RC20161210T0838 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was af26799 Updating pom.xml version numbers for release 4.9.1.0 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. -- To stop receiving notification emails like this one, please contact raf...@apache.org.
[cloudstack] branch 4.9.0-RC20160706T1546 deleted (was 643f75a)
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch 4.9.0-RC20160706T1546 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 643f75a Updating pom.xml version numbers for release 4.9.0 This change permanently discards the following revisions: discard 643f75a Updating pom.xml version numbers for release 4.9.0 -- To stop receiving notification emails like this one, please contact raf...@apache.org.
[cloudstack] branch 4.8.0-RC20160120T2343 deleted (was 62f218b)
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch 4.8.0-RC20160120T2343 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 62f218b Updating pom.xml version numbers for release 4.8.0 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. -- To stop receiving notification emails like this one, please contact raf...@apache.org.
[cloudstack] branch 4.8.1-RC20160808T1006 deleted (was a63db21)
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch 4.8.1-RC20160808T1006 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was a63db21 Updating pom.xml version numbers for release 4.8.1 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. -- To stop receiving notification emails like this one, please contact raf...@apache.org.
[cloudstack] branch 4.8.0.1-RC20160525T1247 deleted (was 6d575df)
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch 4.8.0.1-RC20160525T1247 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 6d575df Updating pom.xml version numbers for release 4.8.0.1 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. -- To stop receiving notification emails like this one, please contact raf...@apache.org.
[cloudstack] branch 4.7.1.1-RC20160525T1230 deleted (was 781775a)
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch 4.7.1.1-RC20160525T1230 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 781775a Updating pom.xml version numbers for release 4.7.1.1 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. -- To stop receiving notification emails like this one, please contact raf...@apache.org.
[cloudstack] branch 4.7.0-RC20151213T2109 deleted (was 2f26a85)
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch 4.7.0-RC20151213T2109 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 2f26a85 Updating pom.xml version numbers for release 4.7.0 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. -- To stop receiving notification emails like this one, please contact raf...@apache.org.
[cloudstack] branch 4.7.1-RC20160120T2318 deleted (was 5ea07dc)
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch 4.7.1-RC20160120T2318 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 5ea07dc Updating pom.xml version numbers for release 4.7.1 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. -- To stop receiving notification emails like this one, please contact raf...@apache.org.
[GitHub] borisstoyanov commented on issue #2499: Updates to capacity management
borisstoyanov commented on issue #2499: Updates to capacity management URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-378398946 Yes @mike-tutkowski I think that's absolutely valid. it makes me sad to see these random failures occasionally... :( @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2499: Updates to capacity management
blueorangutan commented on issue #2499: Updates to capacity management URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-378399076 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2502: [CLOUDSTACK-10352] XenServer: Support online migration of a virtual disk from non-managed to managed storage
blueorangutan commented on issue #2502: [CLOUDSTACK-10352] XenServer: Support online migration of a virtual disk from non-managed to managed storage URL: https://github.com/apache/cloudstack/pull/2502#issuecomment-378398596 @borisstoyanov a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2502: [CLOUDSTACK-10352] XenServer: Support online migration of a virtual disk from non-managed to managed storage
borisstoyanov commented on issue #2502: [CLOUDSTACK-10352] XenServer: Support online migration of a virtual disk from non-managed to managed storage URL: https://github.com/apache/cloudstack/pull/2502#issuecomment-378398232 Thanks @mike-tutkowski let me run the smoketests matrix. @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mike-tutkowski commented on issue #2502: [CLOUDSTACK-10352] XenServer: Support online migration of a virtual disk from non-managed to managed storage
mike-tutkowski commented on issue #2502: [CLOUDSTACK-10352] XenServer: Support online migration of a virtual disk from non-managed to managed storage URL: https://github.com/apache/cloudstack/pull/2502#issuecomment-378376794 Hi @borisroman - I went ahead and created a JIRA ticket for this PR. I updated the title and description of this PR to include a reference to the ticket. I'm not sure if the CloudStack Community really keeps track of all of the permutations for online storage migration in terms of what currently is supported and not supported for a given release. In this situation, the difference the user would experience is that prior to 4.12 an error would be generated if he/she tried to perform this action while now, in 4.12, it works. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS)
rafaelweingartner commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS) URL: https://github.com/apache/cloudstack/pull/2524#issuecomment-378368632 The 1.12 (the latest version) is not. However, the 1.11 is. The fix for the XSS vulnerability was first introduced in jQuery-UI 1.10. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mike-tutkowski commented on issue #2499: Updates to capacity management
mike-tutkowski commented on issue #2499: Updates to capacity management URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-378367284 I'm pretty sure none of those test failures has to do with this PR. The PR code relates only to managed storage (which none of those tests test). On top of it, the code is really concerned with somewhat of a corner case in managed storage (which none of those tests would test either). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khos2ow commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS)
khos2ow commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS) URL: https://github.com/apache/cloudstack/pull/2524#issuecomment-378360672 Cool, I didn't expect them to be compatible!! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS)
rafaelweingartner commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS) URL: https://github.com/apache/cloudstack/pull/2524#issuecomment-378358804 Yes, we need more manual testing. I already tested the most common features in ACS UI. jQuery-UI 1.11 is compatible with our jQuery version. So, there should be no problems there. On the other hand, jQuery-UI changed quite considerably from 1.8 to 1.11. I believe I caught most of the problems, but there might be something I have not tested yet. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khos2ow commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS)
khos2ow commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS) URL: https://github.com/apache/cloudstack/pull/2524#issuecomment-378357911 Thanks Rafael for the PR, but keep in mind that there are lots of changes in these two versions (and considering some functionalities won't work with older JQuery itself, so that needs to be upgraded) and most of the time these are not backward-compatible. Going forward with this PR requires a lot of manual -in browser- testing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS)
blueorangutan commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS) URL: https://github.com/apache/cloudstack/pull/2524#issuecomment-378352173 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1870 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS)
blueorangutan commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS) URL: https://github.com/apache/cloudstack/pull/2524#issuecomment-378343417 @rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner opened a new pull request #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS)
rafaelweingartner opened a new pull request #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS) URL: https://github.com/apache/cloudstack/pull/2524 ## Description This PR addresses an old security issue regarding jQuery-UI. We are updating jQuery-UI to version 1.11, instead of 1.12, because the 1.12 version requires an update of jQuery.js as well. Therefore, to reduce the surface of changes, we are first only updating the jQuery-UI library. Moreover, unnecessary CSS and image files from the jQuery-UI library were deleted. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [X] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? I tested the changes introduced here by generating the RMP packages, updating ACS in a test environment and then using ACS UI to see if I something is not working. So far I have tracked and fixed all of the problems I encountered. I would like to get some help on testing this as well. Therefore, if you have some minutes/hours to spare, please do help. ## Checklist: - [x] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document. - [x] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. Testing - [ ] I have added tests to cover my changes. - [x] All relevant new and existing integration tests have passed. - [ ] A full integration testsuite with all test that can run on my environment has passed. @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DagSonsteboSB commented on issue #2523: XCP-ng 7.4 support
DagSonsteboSB commented on issue #2523: XCP-ng 7.4 support URL: https://github.com/apache/cloudstack/issues/2523#issuecomment-378273847 Assuming the CloudStack via the host.get_all_records method retrieves data from the xapi DB, the host list on the xcp host returns as follows: [root@ref-trl-420-x-cs411-dsonstebo-xs1 ~]# xe host-list params=API-version-major,API-version-minor,API-version-vendor,edition,software-version,capabilities,allowed-operations hostname=ref-trl-420-x-cs411-dsonstebo-xs1 allowed-operations (SRO): VM.migrate; provision; VM.resume; reboot; evacuate; VM.start; shutdown API-version-major ( RO): 2 API-version-minor ( RO): 9 API-version-vendor ( RO): XenSource software-version (MRO): product_version: 7.4.0; product_version_text: 7.4; product_version_text_short: 7.4; platform_name: XCP; platform_version: 2.5.0; product_brand: XCP-ng; build_number: release/jura/master/100; hostname: localhost; date: 2018-02-19; dbv: 0.0.1; xapi: 1.20; xen: 4.7.4-4.1; linux: 4.4.0+10; xencenter_min: 2.9; xencenter_max: 2.9; network_backend: openvswitch; db_schema: 5.134 capabilities (SRO): xen-3.0-x86_64; xen-3.0-x86_32p; hvm-3.0-x86_32; hvm-3.0-x86_32p; hvm-3.0-x86_64; edition ( RO): xcp-ng This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2514: Problem with NAT configuration and VMs not accessing each other via public IPs
rafaelweingartner commented on issue #2514: Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-378257726 Sure. I did the following to test this issue: * created a VPC * then allocated an IP * deployed a VM * configured a NAT rule for port 22 to the recently deployed VM * tried to access the VM (from itself) via SSH using the public IP Without the changes introduces by this PR it is not possible to execute the last step. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2499: Updates to capacity management
blueorangutan commented on issue #2499: Updates to capacity management URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-378255294 Trillian test result (tid-2446) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 93960 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2499-t2446-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermitten failure detected: /marvin/tests/smoke/test_routers.py Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 63 look OK, 4 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 176.74 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 244.54 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 241.89 | test_privategw_acl.py test_04_restart_network_wo_cleanup | `Failure` | 3.95 | test_routers.py test_01_cancel_host_maintenace_with_no_migration_jobs | `Failure` | 0.11 | test_host_maintenance.py test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 873.09 | test_host_maintenance.py test_hostha_enable_ha_when_host_disconected | `Error` | 940.00 | test_hostha_kvm.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 4.58 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DagSonsteboSB opened a new issue #2523: XCP-ng 7.4 support
DagSonsteboSB opened a new issue #2523: XCP-ng 7.4 support URL: https://github.com/apache/cloudstack/issues/2523 # Support for XCP-ng 7.4 in Apache CloudStack The new community version of XenServer - XCP-ng 7.4 was released 31/March 2018: https://xcp-ng.github.io/news/2018/03/31/first-xcp-ng-release.html As this will become an important addition to the CloudStack hypervisor ecosystem support for this will be a great feature. Since this version should be close to feature compatible with XenServer 7.4 the existing XenServer code can hopefully be utilised. ## Test results Test environment: - CloudStack 4.11 on CentOS 7.4 - Hypervisors running first release of XCP-ng version 7.4 - NFS storage When tested in CloudStack 4.11 this was as suspected not recognised: 2018-04-03 11:34:29,334 INFO [c.c.r.ResourceManagerImpl] (qtp788117692-16:ctx-040da28f ctx-9347d25e ctx-ab04f31e) (logid:a961de98) Trying to add a new host at http://IPremoved in data center 1 2018-04-03 11:34:29,638 DEBUG [c.c.h.x.d.XcpServerDiscoverer] (qtp788117692-16:ctx-040da28f ctx-9347d25e ctx-ab04f31e) (logid:a961de98) host IPremoved doesn't have 996dd2e7-ad95-49cc-a0be-2c9adc4dfb0b Hotfix 2018-04-03 11:34:29,648 DEBUG [c.c.h.x.d.XcpServerDiscoverer] (qtp788117692-16:ctx-040da28f ctx-9347d25e ctx-ab04f31e) (logid:a961de98) host IPremoved doesn't have 0850b186-4d47-11e3-a720-001b2151a503 Hotfix 2018-04-03 11:34:29,659 WARN [c.c.h.x.d.XcpServerDiscoverer] (qtp788117692-16:ctx-040da28f ctx-9347d25e ctx-ab04f31e) (logid:a961de98) Only support XCP 1.0.0, 1.1.0, 1.4.x, 1.5 beta, 1.6.x; XenServer 5.6, XenServer 5.6 FP1, XenServer 5.6 SP2, Xenserver 6.0, 6.0.2, 6.1.0, 6.2.0, >6.4.0 but this one is XCP-ng 7.4.0 2018-04-03 11:34:29,660 DEBUG [c.c.h.x.d.XcpServerDiscoverer] (qtp788117692-16:ctx-040da28f ctx-9347d25e ctx-ab04f31e) (logid:a961de98) other exceptions: java.lang.RuntimeException: Only support XCP 1.0.0, 1.1.0, 1.4.x, 1.5 beta, 1.6.x; XenServer 5.6, XenServer 5.6 FP1, XenServer 5.6 SP2, Xenserver 6.0, 6.0.2, 6.1.0, 6.2.0, >6.4.0 but this one is XCP-ng 7.4.0 java.lang.RuntimeException: Only support XCP 1.0.0, 1.1.0, 1.4.x, 1.5 beta, 1.6.x; XenServer 5.6, XenServer 5.6 FP1, XenServer 5.6 SP2, Xenserver 6.0, 6.0.2, 6.1.0, 6.2.0, >6.4.0 but this one is XCP-ng 7.4.0 at com.cloud.hypervisor.xenserver.discoverer.XcpServerDiscoverer.createServerResource(XcpServerDiscoverer.java:439) at com.cloud.hypervisor.xenserver.discoverer.XcpServerDiscoverer.createServerResource(XcpServerDiscoverer.java:454) at com.cloud.hypervisor.xenserver.discoverer.XcpServerDiscoverer.find(XcpServerDiscoverer.java:301) at com.cloud.resource.ResourceManagerImpl.discoverHostsFull(ResourceManagerImpl.java:756) at com.cloud.resource.ResourceManagerImpl.discoverHosts(ResourceManagerImpl.java:601) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:338) at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:197) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163) at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:92) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:185) at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:212) at com.sun.proxy.$Proxy178.discoverHosts(Unknown Source) at org.apache.cloudstack.api.command.admin.host.AddHostCmd.execute(AddHostCmd.java:142) at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150) at com.cloud.api.ApiServer.queueCommand(ApiServer.java:731) at com.cloud.api.ApiServer.handleRequest(ApiServer.java:555) at com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:310) at com.cloud.api.ApiServlet$1.run(ApiServlet.java:130) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53) at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:127) at com.cloud.api.ApiServlet.doGet(Api
[GitHub] blueorangutan commented on issue #2498: CLOUDSTACK-10327: Do not invalidate the session when API command not found
blueorangutan commented on issue #2498: CLOUDSTACK-10327: Do not invalidate the session when API command not found URL: https://github.com/apache/cloudstack/pull/2498#issuecomment-378222844 Trillian test result (tid-2449) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 7042 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2498-t2449-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_accounts.py Smoke tests completed. 0 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2514: Problem with NAT configuration and VMs not accessing each other via public IPs
blueorangutan commented on issue #2514: Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-378206314 Trillian test result (tid-2443) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 91103 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2514-t2443-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermitten failure detected: /marvin/tests/smoke/test_routers.py Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 65 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_restart_network_wo_cleanup | `Failure` | 4.00 | test_routers.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 1.45 | test_hostha_kvm.py test_hostha_kvm_host_degraded | `Error` | 1992.79 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2503: Support multiple volume access groups per compute cluster
blueorangutan commented on issue #2503: Support multiple volume access groups per compute cluster URL: https://github.com/apache/cloudstack/pull/2503#issuecomment-378205832 Trillian test result (tid-2447) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 82719 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2503-t2447-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py Intermitten failure detected: /marvin/tests/smoke/test_routers.py Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py Smoke tests completed. 64 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_restart_network_wo_cleanup | `Failure` | 4.02 | test_routers.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2522: indicate scope of tests in checklist
blueorangutan commented on issue #2522: indicate scope of tests in checklist URL: https://github.com/apache/cloudstack/pull/2522#issuecomment-378205435 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1869 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcaurele commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage
marcaurele commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage URL: https://github.com/apache/cloudstack/pull/1709#issuecomment-378200820 @wido I updated the PR description with the new configuration keys required on the agent side. My logic was that each agent is responsible to give the migration flags & connection mode that it is capable of. An improvement would have been to have the possibility to overwrite the migration flags from the command. I know that @remibergsma did merge it in their cosmic cloud version. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wido commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage
wido commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage URL: https://github.com/apache/cloudstack/pull/1709#issuecomment-378199417 Thanks! @GabrielBrascher and me will take a look at this. Might take some time to bootstrap and test env, but we will test it further. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2522: indicate scope of tests in checklist
blueorangutan commented on issue #2522: indicate scope of tests in checklist URL: https://github.com/apache/cloudstack/pull/2522#issuecomment-378198459 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: indicate scope of tests in checklist (#2522)
This is an automated email from the ASF dual-hosted git repository. rafael pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 1c253a6 indicate scope of tests in checklist (#2522) 1c253a6 is described below commit 1c253a6086bf8a0293ac954fea3fd61776fc50ec Author: dahn AuthorDate: Tue Apr 3 10:06:25 2018 + indicate scope of tests in checklist (#2522) In cloudstack no-one person or organisation will ever be able to run all tests involving all kinds of hardware. make the checklist more realistic in this perspective. --- PULL_REQUEST_TEMPLATE.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index 8a5a30f..1dd6759 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -27,8 +27,10 @@ - [ ] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. +Testing - [ ] I have added tests to cover my changes. -- [ ] All new and existing tests passed. +- [ ] All relevant new and existing integration tests have passed. +- [ ] A full integration testsuite with all test that can run on my environment has passed. @blueorangutan package -- To stop receiving notification emails like this one, please contact raf...@apache.org.
[GitHub] rafaelweingartner closed pull request #2522: indicate scope of tests in checklist
rafaelweingartner closed pull request #2522: indicate scope of tests in checklist URL: https://github.com/apache/cloudstack/pull/2522 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2511: [CLOUDSTACK-10344] bug when moving ACL rules (change order with drag and drop)
blueorangutan commented on issue #2511: [CLOUDSTACK-10344] bug when moving ACL rules (change order with drag and drop) URL: https://github.com/apache/cloudstack/pull/2511#issuecomment-378193274 Trillian test result (tid-2441) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 92924 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2511-t2441-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py Intermitten failure detected: /marvin/tests/smoke/test_routers.py Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 64 look OK, 3 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_restart_network_wo_cleanup | `Failure` | 4.18 | test_routers.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 282.49 | test_vpc_redundant.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 2.11 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2517: manual mapped ldap fix
blueorangutan commented on issue #2517: manual mapped ldap fix URL: https://github.com/apache/cloudstack/pull/2517#issuecomment-378186965 Trillian test result (tid-2442) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 86914 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2517-t2442-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_routers.py Smoke tests completed. 66 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_restart_network_wo_cleanup | `Failure` | 4.04 | test_routers.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2498: CLOUDSTACK-10327: Do not invalidate the session when API command not found
blueorangutan commented on issue #2498: CLOUDSTACK-10327: Do not invalidate the session when API command not found URL: https://github.com/apache/cloudstack/pull/2498#issuecomment-378185367 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2498: CLOUDSTACK-10327: Do not invalidate the session when API command not found
borisstoyanov commented on issue #2498: CLOUDSTACK-10327: Do not invalidate the session when API command not found URL: https://github.com/apache/cloudstack/pull/2498#issuecomment-378185187 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcaurele commented on a change in pull request #1709: CLOUDSTACK-7982: KVM live migration with local storage
marcaurele commented on a change in pull request #1709: CLOUDSTACK-7982: KVM live migration with local storage URL: https://github.com/apache/cloudstack/pull/1709#discussion_r178758112 ## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateWithStorageCommandWrapper.java ## @@ -0,0 +1,56 @@ +// +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +// + +package com.cloud.hypervisor.kvm.resource.wrapper; + +import com.cloud.agent.api.Answer; +import com.cloud.agent.api.MigrateWithStorageAnswer; +import com.cloud.agent.api.MigrateWithStorageCommand; +import com.cloud.agent.api.to.DataTO; +import com.cloud.agent.api.to.DiskTO; +import com.cloud.agent.api.to.VirtualMachineTO; +import com.cloud.hypervisor.kvm.resource.LibvirtComputingResource; +import com.cloud.resource.CommandWrapper; +import com.cloud.resource.ResourceWrapper; +import org.apache.cloudstack.storage.to.VolumeObjectTO; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.List; + +@ResourceWrapper(handles = MigrateWithStorageCommand.class) +public final class LibvirtMigrateWithStorageCommandWrapper extends CommandWrapper { + +@Override +public Answer execute(final MigrateWithStorageCommand command, final LibvirtComputingResource libvirtComputingResource) { +List volumes = new ArrayList<>(); +VirtualMachineTO vm = command.getVirtualMachine(); +List disks = Arrays.asList(vm.getDisks()); +for (DiskTO disk : disks) { +DataTO data = disk.getData(); +if (data instanceof VolumeObjectTO) { +volumes.add((VolumeObjectTO) data); +} +} + +final String result = LibvirtMigrationHelper.executeMigrationWithFlags(libvirtComputingResource, vm.getName(), command.getTargetHost(), libvirtComputingResource.getMigrateWithStorageFlags(), null, true); Review comment: @wido shortcut here with `null, true` as last parameters This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wido commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage
wido commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage URL: https://github.com/apache/cloudstack/pull/1709#issuecomment-378180759 @marcaurele Awesome! Could you elaborate a bit about the shortcut? I kind find it right away in the changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2462: [CLOUDSTACK-10301] Allow updating the network ACL list name and Description
blueorangutan commented on issue #2462: [CLOUDSTACK-10301] Allow updating the network ACL list name and Description URL: https://github.com/apache/cloudstack/pull/2462#issuecomment-378178448 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2462: [CLOUDSTACK-10301] Allow updating the network ACL list name and Description
borisstoyanov commented on issue #2462: [CLOUDSTACK-10301] Allow updating the network ACL list name and Description URL: https://github.com/apache/cloudstack/pull/2462#issuecomment-378178039 Deployment has failed @rafaelweingartner, let me restart @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcaurele commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage
marcaurele commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage URL: https://github.com/apache/cloudstack/pull/1709#issuecomment-378169253 @wido some code has changed regarding migration with the local storage and I cannot find a way how to do a correct rebase and took a shotcut. I let you handle the tests from there, and I don't mind if you work further on this change to make it into a release. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services