[GitHub] blueorangutan commented on issue #2884: add date to usage server logs

2018-10-07 Thread GitBox 
blueorangutan commented on issue #2884:   add date to usage server logs
URL: https://github.com/apache/cloudstack/pull/2884#issuecomment-427717279
 
 
   Trillian test result (tid-3061)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 38897 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2884-t3061-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 61 look OK, 6 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 1168.62 | 
test_privategw_acl.py
   test_04_extract_template | `Failure` | 128.41 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_04_nonsecured_to_secured_vm_migration | `Error` | 226.32 | 
test_vm_life_cycle.py
   test_06_download_detached_volume | `Failure` | 138.61 | test_volumes.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 3.62 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2839: Enable DPDK support on KVM

2018-10-07 Thread GitBox 
blueorangutan commented on issue #2839: Enable DPDK support on KVM
URL: https://github.com/apache/cloudstack/pull/2839#issuecomment-427701090
 
 
   Trillian test result (tid-3062)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 25057 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2839-t3062-kvm-centos7.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_multipleips_per_nic.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 64 look OK, 5 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_nic_secondaryip_add_remove | `Error` | 25.11 | 
test_multipleips_per_nic.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 1107.80 | 
test_privategw_acl.py
   test_02_unsecure_vm_migration | `Error` | 130.98 | test_vm_life_cycle.py
   test_03_secured_to_nonsecured_vm_migration | `Error` | 75.52 | 
test_vm_life_cycle.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 471.46 | 
test_vpc_redundant.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 2.42 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] bdonnahue opened a new issue #2886: Cloudstack 4.11.1.0 - Static NAT not functioning in Advanced Zone with GRE Isolation

2018-10-07 Thread GitBox 
bdonnahue opened a new issue #2886: Cloudstack 4.11.1.0 - Static NAT not 
functioning in Advanced Zone with GRE Isolation
URL: https://github.com/apache/cloudstack/issues/2886
 
 
   # ISSUE TYPE
* Bug Report
   
   # COMPONENT NAME
   VPC / Router VM
   
   # CLOUDSTACK VERSION
   4.11.1.0
   
   # CONFIGURATION
   Advanced Network
   GRE Isolation
   XenServer 7.2
   1 physical network hosting all network traffic types
   
   # SUMMARY
   I am able to provision a Static NAT for a VPC defined in an Advanced Zone 
using GRE Isolation. The Static NAT does not behave as expected.
   
   From the router VM I am able to SSH to the public IP allocated for the 
Static NAT; It redirects to the instance. Looking at the Iptables and routing 
table it looks like the router VM is not prepared to forward traffic as desired.
   
   # STEPS TO REPRODUCE
   Create an Static NAT
   Try to SSH / Ping the Public IP
   
   # EXPECTED RESULTS
   Connection established / ping reply
   
   # ACTUAL RESULTS
   Connection timeout / ping timeout


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] bdonnahue opened a new issue #2885: Feature Request - Create shared network in advanced zone using GRE tunnels / OVS Plugin

2018-10-07 Thread GitBox 
bdonnahue opened a new issue #2885: Feature Request - Create shared network in 
advanced zone using GRE tunnels / OVS Plugin
URL: https://github.com/apache/cloudstack/issues/2885
 
 
   # ISSUE TYPE
* Enhancement Request
   
   # COMPONENT NAME
   OVS Plugin
   
   # CLOUDSTACK VERSION
   4.11.1.0
   
   # CONFIGURATION
   Advanced Network
   GRE Isolation
   XenServer 7.2
   1 physical network hosting all network traffic types
   
   # OS / ENVIRONMENT
   N/A
   
   # SUMMARY
   I cannot create a shared network through the GUI. I see the following error 
message in my logs:
   
   2018-09-24 22:19:07,803 ERROR [c.c.a.ApiServer] 
(qtp788117692-144094:ctx-75aeff02 ctx-93156a36) (logid:3b14107d) unhandled 
exception executing api command: [Ljava.lang.String;@11e8bdf4 
com.cloud.utils.exception.CloudRuntimeException: Unable to convert network 
offering with specified id to network profile
   
   The issue was discussed here: 
https://github.com/apache/cloudstack/issues/2863
   
   # STEPS TO REPRODUCE
   Create an advanced network and try to create shared network
   
   # EXPECTED RESULTS
   Shared network screated
   
   # ACTUAL RESULTS
   Error message displayed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated (fcc87d9 -> 1fa4f10)

2018-10-07 Thread rafael 
This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from fcc87d9  Merge branch '4.11'
 add 8da2513  api: Make networkofferingid required in migrateNetwork (#2852)
 add 70dbfa7  systemvm: export $TYPE before patching ssvm/cpvm (#2855)
 add 9c14059  Merge remote-tracking branch 'origin/4.11'
 add d53fc94  CLOUDSTACK-10365: Change the "getXXX" boolean method names to 
"isXXX" (#2847)
 add 6f1c555  agent: Fixes #2858 agent LB not working (#2859)
 add 1f9811d  Merge remote-tracking branch 'origin/4.11'
 add 769a008  tools: Remove deprecated buildw and wix plugin (#2849)
 add c2f4b36  packaging: Fixes #2857 don't overwrite agent logrotate config 
(#2860)
 add 02e2825  CLOUDSTACK-10380: Fix startvm giving another password after 
password reset.
 add 8d7a1d6  get new vr after NetworkRestartWithCleanup
 add 6041582  CLOUDSTACK-10380: Refactoring of test_configdrive
 add b0490c5  fixed test_nuage_extra_dhcp test failures due to refactoring
 add 41fcf43  Fix config drive test for Shared Network
 add b728e23  Marvin: Register template
 add cca2505  Handle review comments
 add fe10e68  Merge pull request #2743 from 
nuagenetworks/bugfix/marvin_config_drive
 add 8c0b9d6  systemvm: baremetal-vr: reduce memory usage (#2866)
 add 0c943ab  CertUtils: export private key to pem format correctly (#2875)
 add b6302d4  Merge remote-tracking branch 'origin/4.11'
 add 5db65a6  kvm: Fixes #2868 libvirt resize notify failure (#2878)
 add 5313c04  Merge remote-tracking branch 'origin/4.11'
 add f430f41  ca: Fixes #2877 mgmt server cert should have all addrs of 
default nic (#2879)
 add 1fa4f10  Merge remote-tracking branch 'origin/4.11'

No new revisions were added by this update.

Summary of changes:
 agent/src/main/java/com/cloud/agent/Agent.java |2 +-
 api/src/main/java/com/cloud/agent/api/to/S3TO.java |2 +-
 .../main/java/com/cloud/offering/DiskOffering.java |4 +-
 .../java/com/cloud/offering/NetworkOffering.java   |   30 +-
 .../java/com/cloud/offering/ServiceOffering.java   |8 +-
 api/src/main/java/com/cloud/storage/GuestOS.java   |2 +-
 .../com/cloud/template/VirtualMachineTemplate.java |4 +-
 api/src/main/java/com/cloud/vm/DiskProfile.java|2 +-
 .../command/admin/network/MigrateNetworkCmd.java   |5 +-
 .../command/user/address/AssociateIPAddrCmd.java   |2 +-
 .../api/command/user/volume/ResizeVolumeCmd.java   |2 +-
 client/pom.xml |  254 ---
 .../storage/template/S3TemplateDownloader.java |2 +-
 .../com/cloud/vm/VirtualMachineManagerImpl.java|8 +-
 .../engine/orchestration/NetworkOrchestrator.java  |   16 +-
 .../engine/orchestration/VolumeOrchestrator.java   |   10 +-
 .../cloud/vm/VirtualMachineManagerImplTest.java|8 +-
 .../java/com/cloud/network/dao/NetworkDaoImpl.java |6 +-
 .../java/com/cloud/network/vpc/PrivateIpVO.java|2 +-
 .../com/cloud/offerings/NetworkOfferingVO.java |   30 +-
 .../offerings/dao/NetworkOfferingDaoImpl.java  |2 +-
 .../java/com/cloud/service/ServiceOfferingVO.java  |   12 +-
 .../cloud/service/dao/ServiceOfferingDaoImpl.java  |   10 +-
 .../java/com/cloud/storage/DiskOfferingVO.java |4 +-
 .../src/main/java/com/cloud/storage/GuestOSVO.java |2 +-
 .../main/java/com/cloud/storage/VMTemplateVO.java  |4 +-
 .../com/cloud/storage/dao/DiskOfferingDaoImpl.java |2 +-
 .../com/cloud/upgrade/dao/Upgrade41110to41120.java |   12 +-
 .../main/java/com/cloud/vm/dao/UserVmDaoImpl.java  |   12 +-
 .../resourcedetail/ResourceDetailsDao.java |2 +
 .../resourcedetail/ResourceDetailsDaoBase.java |   14 +-
 .../storage/image/store/TemplateObject.java|8 +-
 .../storage/image/TemplateEntityImpl.java  |4 +-
 .../cloudstack/quota/vo/ServiceOfferingVO.java |   10 +-
 packaging/centos63/cloud.spec  |2 +-
 packaging/centos7/cloud.spec   |2 +-
 .../cloudstack/ca/provider/RootCAProvider.java |2 +-
 .../cloud/network/lb/LoadBalanceRuleHandler.java   |2 +-
 .../network/contrail/management/ContrailGuru.java  |2 +-
 .../contrail/management/ManagementNetworkGuru.java |2 +-
 .../network/guru/NiciraNvpGuestNetworkGuru.java|2 +-
 .../guru/NiciraNvpGuestNetworkGuruTest.java|2 +-
 .../com/cloud/network/element/NuageVspElement.java |4 +-
 .../network/guru/NuageVspGuestNetworkGuru.java |4 +-
 .../java/com/cloud/util/NuageVspEntityBuilder.java |6 +-
 .../cloud/network/element/NuageVspElementTest.java |8 +-
 .../network/guru/NuageVspGuestNetworkGuruTest.java |8 +-
 .../com/cloud/util/NuageVspEntityBuilderTest.java  |2 +-
 .../opendaylight/OpendaylightGuestNetworkGuru.java |2 +-

[cloudstack] branch master updated (1fa4f10 -> fcc87d9)

2018-10-07 Thread rafael 
This is an automated email from the ASF dual-hosted git repository.

rafael pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


omit 1fa4f10  Merge remote-tracking branch 'origin/4.11'
omit f430f41  ca: Fixes #2877 mgmt server cert should have all addrs of 
default nic (#2879)
omit 5313c04  Merge remote-tracking branch 'origin/4.11'
omit 5db65a6  kvm: Fixes #2868 libvirt resize notify failure (#2878)
omit b6302d4  Merge remote-tracking branch 'origin/4.11'
omit 0c943ab  CertUtils: export private key to pem format correctly (#2875)
omit 769a008  tools: Remove deprecated buildw and wix plugin (#2849)
omit 8c0b9d6  systemvm: baremetal-vr: reduce memory usage (#2866)
omit fe10e68  Merge pull request #2743 from 
nuagenetworks/bugfix/marvin_config_drive
omit c2f4b36  packaging: Fixes #2857 don't overwrite agent logrotate config 
(#2860)
omit 1f9811d  Merge remote-tracking branch 'origin/4.11'
omit d53fc94  CLOUDSTACK-10365: Change the "getXXX" boolean method names to 
"isXXX" (#2847)
omit 6f1c555  agent: Fixes #2858 agent LB not working (#2859)
omit cca2505  Handle review comments
omit 9c14059  Merge remote-tracking branch 'origin/4.11'
omit 70dbfa7  systemvm: export $TYPE before patching ssvm/cpvm (#2855)
omit 8da2513  api: Make networkofferingid required in migrateNetwork (#2852)
omit b728e23  Marvin: Register template
omit 41fcf43  Fix config drive test for Shared Network
omit b0490c5  fixed test_nuage_extra_dhcp test failures due to refactoring
omit 6041582  CLOUDSTACK-10380: Refactoring of test_configdrive
omit 8d7a1d6  get new vr after NetworkRestartWithCleanup
omit 02e2825  CLOUDSTACK-10380: Fix startvm giving another password after 
password reset.

This update removed existing revisions from the reference, leaving the
reference pointing at a previous point in the repository history.

 * -- * -- N   refs/heads/master (fcc87d9)
\
 O -- O -- O   (1fa4f10)

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

No new revisions were added by this update.

Summary of changes:
 agent/src/main/java/com/cloud/agent/Agent.java |2 +-
 api/src/main/java/com/cloud/agent/api/to/S3TO.java |2 +-
 .../main/java/com/cloud/offering/DiskOffering.java |4 +-
 .../java/com/cloud/offering/NetworkOffering.java   |   30 +-
 .../java/com/cloud/offering/ServiceOffering.java   |8 +-
 api/src/main/java/com/cloud/storage/GuestOS.java   |2 +-
 .../com/cloud/template/VirtualMachineTemplate.java |4 +-
 api/src/main/java/com/cloud/vm/DiskProfile.java|2 +-
 .../command/admin/network/MigrateNetworkCmd.java   |5 +-
 .../command/user/address/AssociateIPAddrCmd.java   |2 +-
 .../api/command/user/volume/ResizeVolumeCmd.java   |2 +-
 client/pom.xml |  254 +++
 .../storage/template/S3TemplateDownloader.java |2 +-
 .../com/cloud/vm/VirtualMachineManagerImpl.java|8 +-
 .../engine/orchestration/NetworkOrchestrator.java  |   16 +-
 .../engine/orchestration/VolumeOrchestrator.java   |   10 +-
 .../cloud/vm/VirtualMachineManagerImplTest.java|8 +-
 .../java/com/cloud/network/dao/NetworkDaoImpl.java |6 +-
 .../java/com/cloud/network/vpc/PrivateIpVO.java|2 +-
 .../com/cloud/offerings/NetworkOfferingVO.java |   30 +-
 .../offerings/dao/NetworkOfferingDaoImpl.java  |2 +-
 .../java/com/cloud/service/ServiceOfferingVO.java  |   12 +-
 .../cloud/service/dao/ServiceOfferingDaoImpl.java  |   10 +-
 .../java/com/cloud/storage/DiskOfferingVO.java |4 +-
 .../src/main/java/com/cloud/storage/GuestOSVO.java |2 +-
 .../main/java/com/cloud/storage/VMTemplateVO.java  |4 +-
 .../com/cloud/storage/dao/DiskOfferingDaoImpl.java |2 +-
 .../com/cloud/upgrade/dao/Upgrade41110to41120.java |   12 +-
 .../main/java/com/cloud/vm/dao/UserVmDaoImpl.java  |   12 +-
 .../resourcedetail/ResourceDetailsDao.java |2 -
 .../resourcedetail/ResourceDetailsDaoBase.java |   14 +-
 .../storage/image/store/TemplateObject.java|8 +-
 .../storage/image/TemplateEntityImpl.java  |4 +-
 .../cloudstack/quota/vo/ServiceOfferingVO.java |   10 +-
 packaging/centos63/cloud.spec  |2 +-
 packaging/centos7/cloud.spec   |2 +-
 .../cloudstack/ca/provider/RootCAProvider.java |2 +-
 .../cloud/network/lb/LoadBalanceRuleHandler.java   |2 +-
 .../network/contrail/management/ContrailGuru.java  |2 +-
 .../contrail/management/ManagementNetworkGuru.java |2 +-
 .../network/guru/NiciraNvpGuestNetworkGuru.java|2 +-
 .../guru/NiciraNvpGuestNetworkGuruTest.java|2 +-
 .../com/cloud/network/element/NuageVspElement.java |4 +-
 .../network/guru/NuageVspGuestNetworkGuru.java |4 +-

[GitHub] blueorangutan commented on issue #2839: Enable DPDK support on KVM

2018-10-07 Thread GitBox 
blueorangutan commented on issue #2839: Enable DPDK support on KVM
URL: https://github.com/apache/cloudstack/pull/2839#issuecomment-427670424
 
 
   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on issue #2839: Enable DPDK support on KVM

2018-10-07 Thread GitBox 
nvazquez commented on issue #2839: Enable DPDK support on KVM
URL: https://github.com/apache/cloudstack/pull/2839#issuecomment-427670389
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2839: Enable DPDK support on KVM

2018-10-07 Thread GitBox 
blueorangutan commented on issue #2839: Enable DPDK support on KVM
URL: https://github.com/apache/cloudstack/pull/2839#issuecomment-427669246
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2334


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2884: add date to usage server logs

2018-10-07 Thread GitBox 
blueorangutan commented on issue #2884:   add date to usage server logs
URL: https://github.com/apache/cloudstack/pull/2884#issuecomment-427667373
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2884: add date to usage server logs

2018-10-07 Thread GitBox 
rhtyd commented on issue #2884:   add date to usage server logs
URL: https://github.com/apache/cloudstack/pull/2884#issuecomment-427667350
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2839: Enable DPDK support on KVM

2018-10-07 Thread GitBox 
blueorangutan commented on issue #2839: Enable DPDK support on KVM
URL: https://github.com/apache/cloudstack/pull/2839#issuecomment-427666724
 
 
   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on issue #2839: Enable DPDK support on KVM

2018-10-07 Thread GitBox 
nvazquez commented on issue #2839: Enable DPDK support on KVM
URL: https://github.com/apache/cloudstack/pull/2839#issuecomment-42787
 
 
   Rebased master branch.
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2884: add date to usage server logs

2018-10-07 Thread GitBox 
blueorangutan commented on issue #2884:   add date to usage server logs
URL: https://github.com/apache/cloudstack/pull/2884#issuecomment-427665216
 
 
   Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2333


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2869: Fix some Marvin smoke tests

2018-10-07 Thread GitBox 
rhtyd commented on issue #2869: Fix some Marvin smoke tests
URL: https://github.com/apache/cloudstack/pull/2869#issuecomment-427663680
 
 
   @PaulAngus fixed and rebased the PR branch against 4.11, will help with 
testing/reviewing tomorrow.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2884: add date to usage server logs

2018-10-07 Thread GitBox 
rhtyd commented on issue #2884:   add date to usage server logs
URL: https://github.com/apache/cloudstack/pull/2884#issuecomment-427663042
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2883: Uilanguages

2018-10-07 Thread GitBox 
rhtyd commented on issue #2883: Uilanguages
URL: https://github.com/apache/cloudstack/pull/2883#issuecomment-427663108
 
 
   Manual UI test needed, smoketests no needed as this is pure UI change.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2884: add date to usage server logs

2018-10-07 Thread GitBox 
blueorangutan commented on issue #2884:   add date to usage server logs
URL: https://github.com/apache/cloudstack/pull/2884#issuecomment-427663097
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated (5313c04 -> 1fa4f10)

2018-10-07 Thread rohit 
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 5313c04  Merge remote-tracking branch 'origin/4.11'
 add f430f41  ca: Fixes #2877 mgmt server cert should have all addrs of 
default nic (#2879)
 new 1fa4f10  Merge remote-tracking branch 'origin/4.11'

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../cloudstack/ca/provider/RootCAProvider.java  |  2 +-
 .../src/main/java/com/cloud/utils/net/NetUtils.java | 21 +
 .../test/java/com/cloud/utils/net/NetUtilsTest.java |  5 +
 3 files changed, 27 insertions(+), 1 deletion(-)

[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.11'

2018-10-07 Thread rohit 
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 1fa4f10a9ea65f156464da1671a4dbf62cc88e06
Merge: 5313c04 f430f41
Author: Rohit Yadav 
AuthorDate: Sun Oct 7 21:12:20 2018 +0530

Merge remote-tracking branch 'origin/4.11'

Signed-off-by: Rohit Yadav 

 .../cloudstack/ca/provider/RootCAProvider.java  |  2 +-
 .../src/main/java/com/cloud/utils/net/NetUtils.java | 21 +
 .../test/java/com/cloud/utils/net/NetUtilsTest.java |  5 +
 3 files changed, 27 insertions(+), 1 deletion(-)

diff --cc utils/src/test/java/com/cloud/utils/net/NetUtilsTest.java
index 4abb87a,80d25e8..fe2e329
--- a/utils/src/test/java/com/cloud/utils/net/NetUtilsTest.java
+++ b/utils/src/test/java/com/cloud/utils/net/NetUtilsTest.java
@@@ -680,18 -680,8 +680,23 @@@ public class NetUtilsTest 
  }
  
  @Test
 +public void testIsIpv4() {
 +assertTrue(NetUtils.isIpv4("192.168.1.1"));
 +assertFalse(NetUtils.isIpv4("2a01:4f8:130:2192::2"));
 +}
 +
 +@Test(expected = IllegalArgumentException.class)
 +public void testIsIpv4ExpectException() {
 +NetUtils.isIpv4("test");
 +}
 +
 +@Test(expected = IllegalArgumentException.class)
 +public void testIsIpv4ExpectException2() {
 +NetUtils.isIpv4("2001:db8:300::/64");
 +}
++
+ public void testAllIpsOfDefaultNic() {
+ final String defaultHostIp = NetUtils.getDefaultHostIp();
+ 
assertTrue(NetUtils.getAllDefaultNicIps().stream().anyMatch(defaultHostIp::contains));
+ }
  }

[GitHub] asfgit closed issue #2877: RootCAProvider certificate validation fails if default interface has multiple IP addresses

2018-10-07 Thread GitBox 
asfgit closed issue #2877: RootCAProvider certificate validation fails if 
default interface has multiple IP addresses
URL: https://github.com/apache/cloudstack/issues/2877
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch 4.11 updated: ca: Fixes #2877 mgmt server cert should have all addrs of default nic (#2879)

2018-10-07 Thread rohit 
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.11 by this push:
 new f430f41  ca: Fixes #2877 mgmt server cert should have all addrs of 
default nic (#2879)
f430f41 is described below

commit f430f41edd32f17143bd9c4b2b9d0168b0d108fb
Author: Rohit Yadav 
AuthorDate: Sun Oct 7 21:07:10 2018 +0530

ca: Fixes #2877 mgmt server cert should have all addrs of default nic 
(#2879)

This fixes the default RootCA provider implementation to initiate
and issue certificate for mgmt server on startup for all the IP addresses
on the default nic of that host.

Signed-off-by: Rohit Yadav 
---
 .../cloudstack/ca/provider/RootCAProvider.java  |  2 +-
 .../src/main/java/com/cloud/utils/net/NetUtils.java | 21 +
 .../test/java/com/cloud/utils/net/NetUtilsTest.java |  6 ++
 3 files changed, 28 insertions(+), 1 deletion(-)

diff --git 
a/plugins/ca/root-ca/src/org/apache/cloudstack/ca/provider/RootCAProvider.java 
b/plugins/ca/root-ca/src/org/apache/cloudstack/ca/provider/RootCAProvider.java
index f36d067..d7a9985 100644
--- 
a/plugins/ca/root-ca/src/org/apache/cloudstack/ca/provider/RootCAProvider.java
+++ 
b/plugins/ca/root-ca/src/org/apache/cloudstack/ca/provider/RootCAProvider.java
@@ -359,7 +359,7 @@ public final class RootCAProvider extends AdapterBase 
implements CAProvider, Con
 return true;
 }
 final Certificate serverCertificate = 
issueCertificate(Collections.singletonList(NetUtils.getHostName()),
-Collections.singletonList(NetUtils.getDefaultHostIp()), 
getCaValidityDays());
+NetUtils.getAllDefaultNicIps(), getCaValidityDays());
 if (serverCertificate == null || serverCertificate.getPrivateKey() == 
null) {
 throw new CloudRuntimeException("Failed to generate management 
server certificate and load management server keystore");
 }
diff --git a/utils/src/main/java/com/cloud/utils/net/NetUtils.java 
b/utils/src/main/java/com/cloud/utils/net/NetUtils.java
index 1bd08a3..afe73f1 100644
--- a/utils/src/main/java/com/cloud/utils/net/NetUtils.java
+++ b/utils/src/main/java/com/cloud/utils/net/NetUtils.java
@@ -225,6 +225,27 @@ public class NetUtils {
 }
 }
 
+public static List getAllDefaultNicIps() {
+final List addrs = new ArrayList<>();
+final String pubNic = getDefaultEthDevice();
+
+if (pubNic == null) {
+return addrs;
+}
+
+NetworkInterface nic = null;
+try {
+nic = NetworkInterface.getByName(pubNic);
+} catch (final SocketException e) {
+return addrs;
+}
+
+for (InterfaceAddress address : nic.getInterfaceAddresses()) {
+addrs.add(address.getAddress().getHostAddress().split("%")[0]);
+}
+return addrs;
+}
+
 public static String getDefaultEthDevice() {
 if (SystemUtils.IS_OS_MAC) {
 final String defDev = Script.runSimpleBashScript("/sbin/route -n 
get default 2> /dev/null | grep interface | awk '{print $2}'");
diff --git a/utils/src/test/java/com/cloud/utils/net/NetUtilsTest.java 
b/utils/src/test/java/com/cloud/utils/net/NetUtilsTest.java
index bec2209..80d25e8 100644
--- a/utils/src/test/java/com/cloud/utils/net/NetUtilsTest.java
+++ b/utils/src/test/java/com/cloud/utils/net/NetUtilsTest.java
@@ -678,4 +678,10 @@ public class NetUtilsTest {
 assertFalse(NetUtils.isValidPort(-1));
 assertFalse(NetUtils.isValidPort(65536));
 }
+
+@Test
+public void testAllIpsOfDefaultNic() {
+final String defaultHostIp = NetUtils.getDefaultHostIp();
+
assertTrue(NetUtils.getAllDefaultNicIps().stream().anyMatch(defaultHostIp::contains));
+}
 }

[GitHub] rhtyd closed pull request #2879: ca: Fixes #2877 mgmt server cert should have all addrs of default nic

2018-10-07 Thread GitBox 
rhtyd closed pull request #2879: ca: Fixes #2877 mgmt server cert should have 
all addrs of default nic
URL: https://github.com/apache/cloudstack/pull/2879
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/plugins/ca/root-ca/src/org/apache/cloudstack/ca/provider/RootCAProvider.java 
b/plugins/ca/root-ca/src/org/apache/cloudstack/ca/provider/RootCAProvider.java
index f36d06799b3..d7a998537bd 100644
--- 
a/plugins/ca/root-ca/src/org/apache/cloudstack/ca/provider/RootCAProvider.java
+++ 
b/plugins/ca/root-ca/src/org/apache/cloudstack/ca/provider/RootCAProvider.java
@@ -359,7 +359,7 @@ private boolean loadManagementKeyStore() {
 return true;
 }
 final Certificate serverCertificate = 
issueCertificate(Collections.singletonList(NetUtils.getHostName()),
-Collections.singletonList(NetUtils.getDefaultHostIp()), 
getCaValidityDays());
+NetUtils.getAllDefaultNicIps(), getCaValidityDays());
 if (serverCertificate == null || serverCertificate.getPrivateKey() == 
null) {
 throw new CloudRuntimeException("Failed to generate management 
server certificate and load management server keystore");
 }
diff --git a/utils/src/main/java/com/cloud/utils/net/NetUtils.java 
b/utils/src/main/java/com/cloud/utils/net/NetUtils.java
index 1bd08a32b25..afe73f16f48 100644
--- a/utils/src/main/java/com/cloud/utils/net/NetUtils.java
+++ b/utils/src/main/java/com/cloud/utils/net/NetUtils.java
@@ -225,6 +225,27 @@ public static String getDefaultHostIp() {
 }
 }
 
+public static List getAllDefaultNicIps() {
+final List addrs = new ArrayList<>();
+final String pubNic = getDefaultEthDevice();
+
+if (pubNic == null) {
+return addrs;
+}
+
+NetworkInterface nic = null;
+try {
+nic = NetworkInterface.getByName(pubNic);
+} catch (final SocketException e) {
+return addrs;
+}
+
+for (InterfaceAddress address : nic.getInterfaceAddresses()) {
+addrs.add(address.getAddress().getHostAddress().split("%")[0]);
+}
+return addrs;
+}
+
 public static String getDefaultEthDevice() {
 if (SystemUtils.IS_OS_MAC) {
 final String defDev = Script.runSimpleBashScript("/sbin/route -n 
get default 2> /dev/null | grep interface | awk '{print $2}'");
diff --git a/utils/src/test/java/com/cloud/utils/net/NetUtilsTest.java 
b/utils/src/test/java/com/cloud/utils/net/NetUtilsTest.java
index bec22098b49..80d25e874a2 100644
--- a/utils/src/test/java/com/cloud/utils/net/NetUtilsTest.java
+++ b/utils/src/test/java/com/cloud/utils/net/NetUtilsTest.java
@@ -678,4 +678,10 @@ public void testIsValidPort() {
 assertFalse(NetUtils.isValidPort(-1));
 assertFalse(NetUtils.isValidPort(65536));
 }
+
+@Test
+public void testAllIpsOfDefaultNic() {
+final String defaultHostIp = NetUtils.getDefaultHostIp();
+
assertTrue(NetUtils.getAllDefaultNicIps().stream().anyMatch(defaultHostIp::contains));
+}
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] PaulAngus opened a new pull request #2884: add date to usage server logs

2018-10-07 Thread GitBox 
PaulAngus opened a new pull request #2884:   add date to usage server logs
URL: https://github.com/apache/cloudstack/pull/2884
 
 
   ## Description
   
   When logging operations of the usage server, a timestamp is not included, 
making the usage logs hard to interpret.
   The same timestamp as used by them management log has been added to the 
usage server logging output.
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ x ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## GitHub Issue/PRs
   
   
   
   
   
   
   Timestamp added to the log4j.xml description of output.
   Output now looks like:
   
   2018-10-07 00:15:00,001 INFO  [cloud.usage.UsageManagerImpl] 
(Usage-Job-1:null) (logid:) starting usage job...
   2018-10-07 00:15:00,016 INFO  [cloud.usage.UsageManagerImpl] 
(Usage-Job-1:null) (logid:) Parsing usage records between Sat Oct 06 00:00:00 
UTC 2018 and Sat Oct 06 23:59:59 UTC 2018
   2018-10-07 00:15:00,151 DEBUG [event.dao.UsageEventDaoImpl] 
(Usage-Job-1:null) (logid:) no recent event date, copying all events
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   
   
   This has been tested by building RPMs, installing the usage service and 
checking the log output.
   
   ## Checklist:
   
   
   - [ ] I have read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document.
   - [ x ] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   Testing
   - [ ] I have added tests to cover my changes.
   - [ x ] All relevant new and existing integration tests have passed.
   - [ x ] A full integration testsuite with all test that can run on my 
environment has passed.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] PaulAngus opened a new pull request #2883: Uilanguages

2018-10-07 Thread GitBox 
PaulAngus opened a new pull request #2883: Uilanguages
URL: https://github.com/apache/cloudstack/pull/2883
 
 
   ## Description
   
   This update changes how the languages are shown on the UI's login page.  
Previously all languages were shown in the current language of the login page. 
This meant for instance, that a Japanese speaker would have to know English to 
find their language. Likewise if the language had been changed, a German 
speaker might need to speak Korean in order to find their language.
   
   Therefore the UI has been altered to always show the name of each language 
in the appropriate language.
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ x ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## GitHub Issue/PRs
   
   
   
   
   
   
   ## Screenshots (if appropriate):
   
![ui-languages-update](https://user-images.githubusercontent.com/4810220/46582989-7fc66f80-ca47-11e8-8b3e-0c083d4e58dd.JPG)
   
   ## How Has This Been Tested?
   
   
   
   
   This has been tested by building packages, and ensuring that the login page 
still functions correctly, by switching languages has expected and showing the 
language labels in their own language.
   
   ## Checklist:
   
   
   - [ x ] I have read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document.
   - [ x ] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   Testing
   - [ ] I have added tests to cover my changes.
   - [ x ] All relevant new and existing integration tests have passed.
   - [ x ] A full integration testsuite with all test that can run on my 
environment has passed.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2879: ca: Fixes #2877 mgmt server cert should have all addrs of default nic

2018-10-07 Thread GitBox 
blueorangutan commented on issue #2879: ca: Fixes #2877 mgmt server cert should 
have all addrs of default nic
URL: https://github.com/apache/cloudstack/pull/2879#issuecomment-427629095
 
 
   Trillian test result (tid-3060)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31008 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2879-t3060-kvm-centos7.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 63 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 1128.32 | 
test_privategw_acl.py
   test_04_extract_template | `Failure` | 128.34 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_06_download_detached_volume | `Failure` | 138.55 | test_volumes.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services