[GitHub] pyr commented on issue #2901: params: allow signatureversion and expires without logging
pyr commented on issue #2901: params: allow signatureversion and expires without logging URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-430110907 @rhtyd nope, this is unrelated to #2893, signature version 3 parameters are already logged This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2902: Add checksum sanity validation on template registration
blueorangutan commented on issue #2902: Add checksum sanity validation on template registration URL: https://github.com/apache/cloudstack/pull/2902#issuecomment-430107618 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2893: ApiServer: signature v3 to accept more formats
blueorangutan commented on issue #2893: ApiServer: signature v3 to accept more formats URL: https://github.com/apache/cloudstack/pull/2893#issuecomment-430107436 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2893: ApiServer: signature v3 to accept more formats
rhtyd commented on issue #2893: ApiServer: signature v3 to accept more formats URL: https://github.com/apache/cloudstack/pull/2893#issuecomment-430107386 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2897: Allow enable the Java remote Debug for CloudStack Agent
blueorangutan commented on issue #2897: Allow enable the Java remote Debug for CloudStack Agent URL: https://github.com/apache/cloudstack/pull/2897#issuecomment-430106926 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2897: Allow enable the Java remote Debug for CloudStack Agent
rhtyd commented on issue #2897: Allow enable the Java remote Debug for CloudStack Agent URL: https://github.com/apache/cloudstack/pull/2897#issuecomment-430106798 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2902: Add checksum sanity validation on template registration
blueorangutan commented on issue #2902: Add checksum sanity validation on template registration URL: https://github.com/apache/cloudstack/pull/2902#issuecomment-430105995 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2345 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2887: NumberFormatException when adding a VM to VPC tier
rhtyd commented on issue #2887: NumberFormatException when adding a VM to VPC tier URL: https://github.com/apache/cloudstack/issues/2887#issuecomment-430105676 I'm unable to reproduce this @borisstoyanov looks like due to other env/network issue, the ssh to the VR failed that caused this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd closed issue #2873: VR seen to have memory leaks
rhtyd closed issue #2873: VR seen to have memory leaks URL: https://github.com/apache/cloudstack/issues/2873 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2873: VR seen to have memory leaks
rhtyd commented on issue #2873: VR seen to have memory leaks URL: https://github.com/apache/cloudstack/issues/2873#issuecomment-430105227 https://github.com/apache/cloudstack/pull/2892 attempts to remedy this, so closing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.11'
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 84994c841f12f13341d6537f2ae6b41c5d08d20b Merge: 272167c 11d83fa Author: Rohit Yadav AuthorDate: Tue Oct 16 10:54:39 2018 +0530 Merge remote-tracking branch 'origin/4.11' agent/conf/log4j-cloud.xml.in| 4 .../networkservice/BaremetalKickStartServiceImpl.java| 7 ++- systemvm/debian/etc/sysctl.conf | 3 +++ systemvm/debian/etc/systemd/journald.conf| 5 + systemvm/debian/etc/systemd/system/baremetal-vr.service | 12 systemvm/debian/etc/systemd/system/cloud-postinit.service| 2 +- systemvm/debian/opt/cloud/bin/setup/postinit.sh | 8 +++- 7 files changed, 34 insertions(+), 7 deletions(-)
[cloudstack] branch master updated (272167c -> 84994c8)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.
from 272167c merge forward #2876 -- PULL_REQUEST_TEMPLATE simplification
add 933ee23 vr: memory and swap optimizations (#2892)
add 11d83fa agent: set log level to INFO as default for http wire (#2903)
new 84994c8 Merge remote-tracking branch 'origin/4.11'
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
agent/conf/log4j-cloud.xml.in | 4
.../baremetal/networkservice/BaremetalKickStartServiceImpl.java | 7 ++-
systemvm/debian/etc/sysctl.conf | 3 +++
systemvm/debian/etc/systemd/journald.conf | 5 +
.../{cloud-password-server@.service => baremetal-vr.service} | 4 ++--
systemvm/debian/etc/systemd/system/cloud-postinit.service | 2 +-
systemvm/debian/opt/cloud/bin/setup/postinit.sh | 8 +++-
7 files changed, 24 insertions(+), 9 deletions(-)
create mode 100644 systemvm/debian/etc/systemd/journald.conf
copy systemvm/debian/etc/systemd/system/{cloud-password-server@.service =>
baremetal-vr.service} (60%)
[GitHub] blueorangutan commented on issue #2900: network: Allow ability to disable rolling restart feature
blueorangutan commented on issue #2900: network: Allow ability to disable rolling restart feature URL: https://github.com/apache/cloudstack/pull/2900#issuecomment-430104904 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2900: network: Allow ability to disable rolling restart feature
rhtyd commented on issue #2900: network: Allow ability to disable rolling restart feature URL: https://github.com/apache/cloudstack/pull/2900#issuecomment-430104822 @blueorangutan test centos7 vmware-55u3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2862: VR stop/start/reboot commands failed
rhtyd commented on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430104678 Unless, VR logs may be available we're unable to investigate and fix this problem @izenk @resmo thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2880: [4.11.2]: rolling upgrade of VR results in duplicate VRs
rhtyd commented on issue #2880: [4.11.2]: rolling upgrade of VR results in duplicate VRs URL: https://github.com/apache/cloudstack/issues/2880#issuecomment-430104566 Moved this to 4.11.3.0/future milestone as this with https://github.com/apache/cloudstack/pull/2900 admin can opt for legacy behaviour This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2901: params: allow signatureversion and expires without logging
rhtyd commented on issue #2901: params: allow signatureversion and expires without logging URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-430101841 is this the PR https://github.com/apache/cloudstack/pull/2893 in question @pyr ? If so, let's review and merge https://github.com/apache/cloudstack/pull/2893 before this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2902: Add checksum sanity validation on template registration
blueorangutan commented on issue #2902: Add checksum sanity validation on template registration URL: https://github.com/apache/cloudstack/pull/2902#issuecomment-430101716 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch 4.11 updated: agent: set log level to INFO as default for http wire (#2903)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.11 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.11 by this push: new 11d83fa agent: set log level to INFO as default for http wire (#2903) 11d83fa is described below commit 11d83fab43bbb6322eee5eb9dc132649ab02b68b Author: Nicolas Vazquez AuthorDate: Tue Oct 16 02:02:03 2018 -0300 agent: set log level to INFO as default for http wire (#2903) Avoid logging bytes on direct download on KVM. --- agent/conf/log4j-cloud.xml.in | 4 1 file changed, 4 insertions(+) diff --git a/agent/conf/log4j-cloud.xml.in b/agent/conf/log4j-cloud.xml.in index 6bc80f0..9ed43e0 100644 --- a/agent/conf/log4j-cloud.xml.in +++ b/agent/conf/log4j-cloud.xml.in @@ -90,6 +90,10 @@ under the License. + + + +
[GitHub] rhtyd commented on issue #2902: Add checksum sanity validation on template registration
rhtyd commented on issue #2902: Add checksum sanity validation on template registration URL: https://github.com/apache/cloudstack/pull/2902#issuecomment-430101663 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd closed pull request #2903: Set http level to INFO as default
rhtyd closed pull request #2903: Set http level to INFO as default URL: https://github.com/apache/cloudstack/pull/2903 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/agent/conf/log4j-cloud.xml.in b/agent/conf/log4j-cloud.xml.in index 6bc80f08473..9ed43e083e0 100644 --- a/agent/conf/log4j-cloud.xml.in +++ b/agent/conf/log4j-cloud.xml.in @@ -90,6 +90,10 @@ under the License. + + + + This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2903: Set http level to INFO as default
rhtyd commented on issue #2903: Set http level to INFO as default URL: https://github.com/apache/cloudstack/pull/2903#issuecomment-430101437 No explicit tests needed as changes are purely in log4j file, merging based on code reviews and travis results. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch 4.11 updated: vr: memory and swap optimizations (#2892)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.11 by this push:
new 933ee23 vr: memory and swap optimizations (#2892)
933ee23 is described below
commit 933ee23104a6e5e080c780874629ec84a6a5e72d
Author: Rohit Yadav
AuthorDate: Tue Oct 16 10:29:48 2018 +0530
vr: memory and swap optimizations (#2892)
This tries to provide a threshold based fix for #2873 where swappinness of
VR is not used until last resort. By limiting swappiness unless actually
needed, the VR system degradation can be avoided for most cases. The other
change is around not starting baremetal-vr by default on all VRs, according to
the spec
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Baremetal+Advanced+Networking+Support
only vmware VRs need to run it and that too only as the last step of the
setup/comple [...]
Signed-off-by: Rohit Yadav
---
.../networkservice/BaremetalKickStartServiceImpl.java| 7 ++-
systemvm/debian/etc/sysctl.conf | 3 +++
systemvm/debian/etc/systemd/journald.conf| 5 +
systemvm/debian/etc/systemd/system/baremetal-vr.service | 12
systemvm/debian/etc/systemd/system/cloud-postinit.service| 2 +-
systemvm/debian/opt/cloud/bin/setup/postinit.sh | 8 +++-
6 files changed, 30 insertions(+), 7 deletions(-)
diff --git
a/plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalKickStartServiceImpl.java
b/plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalKickStartServiceImpl.java
index 1bbf132..8fe3d82 100644
---
a/plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalKickStartServiceImpl.java
+++
b/plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalKickStartServiceImpl.java
@@ -226,11 +226,16 @@ public class BaremetalKickStartServiceImpl extends
BareMetalPxeServiceBase imple
throw new CloudRuntimeException(String.format("please specify
'baremetal.internal.storage.server.ip', which is the http server/nfs server
storing kickstart files and ISO files, in global setting"));
}
+Pair ret =
SshHelper.sshExecute(mgmtNic.getIPv4Address(), 3922, "root",
getSystemVMKeyFile(), null, "systemctl start baremetal-vr");
+if (!ret.first()) {
+throw new CloudRuntimeException(String.format("failed to start
baremetal agent in virtual router[id:%s]", vr.getId()));
+}
+
List tuple = parseKickstartUrl(profile);
String cmd = String.format("/opt/cloud/bin/prepare_pxe.sh %s %s %s %s
%s %s", tuple.get(1), tuple.get(2), profile.getTemplate().getUuid(),
String.format("01-%s", nic.getMacAddress().replaceAll(":",
"-")).toLowerCase(), tuple.get(0), nic.getMacAddress().toLowerCase());
s_logger.debug(String.format("prepare pxe on virtual router[ip:%s],
cmd: %s", mgmtNic.getIPv4Address(), cmd));
-Pair ret =
SshHelper.sshExecute(mgmtNic.getIPv4Address(), 3922, "root",
getSystemVMKeyFile(), null, cmd);
+ret = SshHelper.sshExecute(mgmtNic.getIPv4Address(), 3922, "root",
getSystemVMKeyFile(), null, cmd);
if (!ret.first()) {
throw new CloudRuntimeException(String.format("failed preparing
PXE in virtual router[id:%s], because %s", vr.getId(), ret.second()));
}
diff --git a/systemvm/debian/etc/sysctl.conf b/systemvm/debian/etc/sysctl.conf
index 8e6d752..5b5f818 100644
--- a/systemvm/debian/etc/sysctl.conf
+++ b/systemvm/debian/etc/sysctl.conf
@@ -60,3 +60,6 @@ net.ipv6.conf.all.forwarding = 0
net.ipv6.conf.all.accept_ra = 0
net.ipv6.conf.all.accept_redirects = 0
net.ipv6.conf.all.autoconf = 0
+
+# Minimum swappiness without disabling it
+vm.swappiness=1
diff --git a/systemvm/debian/etc/systemd/journald.conf
b/systemvm/debian/etc/systemd/journald.conf
new file mode 100644
index 000..224f375
--- /dev/null
+++ b/systemvm/debian/etc/systemd/journald.conf
@@ -0,0 +1,5 @@
+[Journal]
+Compress=yes
+SystemMaxUse=40M
+SystemMaxFileSize=10M
+RuntimeMaxUse=20M
diff --git a/systemvm/debian/etc/systemd/system/baremetal-vr.service
b/systemvm/debian/etc/systemd/system/baremetal-vr.service
new file mode 100644
index 000..f880f0c
--- /dev/null
+++ b/systemvm/debian/etc/systemd/system/baremetal-vr.service
@@ -0,0 +1,12 @@
+[Unit]
+Description=CloudStack Baremetal VR service
+After=network.target local-fs.target
+
+[Install]
+WantedBy=multi-user.target
+
+[Service]
+Type=simple
+WorkingDirectory=/opt/cloud/bin
+ExecStart=/usr/bin/python /opt/cloud/bin/baremetal-vr.py
+Restart=on-failure
diff --git a/systemvm/debian/etc/systemd/system/cloud-postinit.service
b/systemvm/debian/etc/systemd/system/cloud-postinit.service
index c23516e..a9abff4 100644
---
[GitHub] rhtyd closed pull request #2892: vr: memory and swap optimizations
rhtyd closed pull request #2892: vr: memory and swap optimizations
URL: https://github.com/apache/cloudstack/pull/2892
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalKickStartServiceImpl.java
b/plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalKickStartServiceImpl.java
index 1bbf1322b1c..8fe3d827ed4 100644
---
a/plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalKickStartServiceImpl.java
+++
b/plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalKickStartServiceImpl.java
@@ -226,11 +226,16 @@ private boolean
preparePxeInAdvancedZone(VirtualMachineProfile profile, NicProfi
throw new CloudRuntimeException(String.format("please specify
'baremetal.internal.storage.server.ip', which is the http server/nfs server
storing kickstart files and ISO files, in global setting"));
}
+Pair ret =
SshHelper.sshExecute(mgmtNic.getIPv4Address(), 3922, "root",
getSystemVMKeyFile(), null, "systemctl start baremetal-vr");
+if (!ret.first()) {
+throw new CloudRuntimeException(String.format("failed to start
baremetal agent in virtual router[id:%s]", vr.getId()));
+}
+
List tuple = parseKickstartUrl(profile);
String cmd = String.format("/opt/cloud/bin/prepare_pxe.sh %s %s %s %s
%s %s", tuple.get(1), tuple.get(2), profile.getTemplate().getUuid(),
String.format("01-%s", nic.getMacAddress().replaceAll(":",
"-")).toLowerCase(), tuple.get(0), nic.getMacAddress().toLowerCase());
s_logger.debug(String.format("prepare pxe on virtual router[ip:%s],
cmd: %s", mgmtNic.getIPv4Address(), cmd));
-Pair ret =
SshHelper.sshExecute(mgmtNic.getIPv4Address(), 3922, "root",
getSystemVMKeyFile(), null, cmd);
+ret = SshHelper.sshExecute(mgmtNic.getIPv4Address(), 3922, "root",
getSystemVMKeyFile(), null, cmd);
if (!ret.first()) {
throw new CloudRuntimeException(String.format("failed preparing
PXE in virtual router[id:%s], because %s", vr.getId(), ret.second()));
}
diff --git a/systemvm/debian/etc/sysctl.conf b/systemvm/debian/etc/sysctl.conf
index 8e6d7520006..5b5f818e76d 100644
--- a/systemvm/debian/etc/sysctl.conf
+++ b/systemvm/debian/etc/sysctl.conf
@@ -60,3 +60,6 @@ net.ipv6.conf.all.forwarding = 0
net.ipv6.conf.all.accept_ra = 0
net.ipv6.conf.all.accept_redirects = 0
net.ipv6.conf.all.autoconf = 0
+
+# Minimum swappiness without disabling it
+vm.swappiness=1
diff --git a/systemvm/debian/etc/systemd/journald.conf
b/systemvm/debian/etc/systemd/journald.conf
new file mode 100644
index 000..224f375d6b6
--- /dev/null
+++ b/systemvm/debian/etc/systemd/journald.conf
@@ -0,0 +1,5 @@
+[Journal]
+Compress=yes
+SystemMaxUse=40M
+SystemMaxFileSize=10M
+RuntimeMaxUse=20M
diff --git a/systemvm/debian/etc/systemd/system/baremetal-vr.service
b/systemvm/debian/etc/systemd/system/baremetal-vr.service
new file mode 100644
index 000..f880f0ca18a
--- /dev/null
+++ b/systemvm/debian/etc/systemd/system/baremetal-vr.service
@@ -0,0 +1,12 @@
+[Unit]
+Description=CloudStack Baremetal VR service
+After=network.target local-fs.target
+
+[Install]
+WantedBy=multi-user.target
+
+[Service]
+Type=simple
+WorkingDirectory=/opt/cloud/bin
+ExecStart=/usr/bin/python /opt/cloud/bin/baremetal-vr.py
+Restart=on-failure
diff --git a/systemvm/debian/etc/systemd/system/cloud-postinit.service
b/systemvm/debian/etc/systemd/system/cloud-postinit.service
index c23516e67ff..a9abff443fa 100644
--- a/systemvm/debian/etc/systemd/system/cloud-postinit.service
+++ b/systemvm/debian/etc/systemd/system/cloud-postinit.service
@@ -2,7 +2,7 @@
Description=CloudStack post-patching init script
After=cloud-early-config.service network.target local-fs.target
Before=ssh.service
-Requires=network.service
+Requires=networking.service
[Install]
WantedBy=multi-user.target
diff --git a/systemvm/debian/opt/cloud/bin/setup/postinit.sh
b/systemvm/debian/opt/cloud/bin/setup/postinit.sh
index f0ae5e89f0c..fc92b7e97cd 100755
--- a/systemvm/debian/opt/cloud/bin/setup/postinit.sh
+++ b/systemvm/debian/opt/cloud/bin/setup/postinit.sh
@@ -21,6 +21,9 @@
# Eject cdrom if any
eject || true
+# Restart journald for setting changes to apply
+systemctl restart systemd-journald
+
TYPE=$(grep -Po 'type=\K[a-zA-Z]*' /var/cache/cloud/cmdline)
if [ "$TYPE" == "router" ] || [ "$TYPE" == "vpcrouter" ] || [ "$TYPE" ==
"dhcpsrvr" ]
then
@@ -59,8 +62,3 @@ fi
systemctl enable --now --no-block ssh
date > /var/cache/cloud/boot_up_done
-
-if [ "$TYPE" == "router" ]
-then
-python /opt/cloud/bin/baremetal-vr.py &
-fi
[GitHub] rhtyd commented on issue #2892: vr: memory and swap optimizations
rhtyd commented on issue #2892: vr: memory and swap optimizations URL: https://github.com/apache/cloudstack/pull/2892#issuecomment-430101076 Based on several days of testing, and reviews and tests I'll merge this. I found that the VR no longer swaps until the last resort and the overall memory is saved by few 20-40MBs. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2900: network: Allow ability to disable rolling restart feature
rhtyd commented on a change in pull request #2900: network: Allow ability to
disable rolling restart feature
URL: https://github.com/apache/cloudstack/pull/2900#discussion_r225397031
##
File path:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##
@@ -2860,7 +2860,7 @@ public boolean restartNetwork(final Long networkId,
final Account callerAccount,
s_logger.debug("Implementing the network " + network + " elements and
resources as a part of network restart without cleanup");
try {
implementNetworkElementsAndResources(dest, context, network,
offering);
-setRestartRequired(network, true);
+setRestartRequired(network, false);
Review comment:
@rafaelweingartner the `restart required` flag is a presentational issue and
used to communicate to users/admins that a network requires a restart because
likely a previous restart attempt failed..
If you restart a network current without the cleanup=true flag, in the API
response and UI the network's restart required state will change to true which
is wrong. The state/flag should only be true if something went wrong in its
last restart. You may read a recent thread here:
https://markmail.org/message/bn57hymlvohf54b7
This change is in line with the logic used by the restart VPC code, i.e.
don't set the restart required flag to true if there was no problem.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2900: network: Allow ability to disable rolling restart feature
rhtyd commented on a change in pull request #2900: network: Allow ability to
disable rolling restart feature
URL: https://github.com/apache/cloudstack/pull/2900#discussion_r225397031
##
File path:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##
@@ -2860,7 +2860,7 @@ public boolean restartNetwork(final Long networkId,
final Account callerAccount,
s_logger.debug("Implementing the network " + network + " elements and
resources as a part of network restart without cleanup");
try {
implementNetworkElementsAndResources(dest, context, network,
offering);
-setRestartRequired(network, true);
+setRestartRequired(network, false);
Review comment:
@rafaelweingartner the `restart required` flag is a presentational issue and
used to communicate to users/admins that a network requires a restart because
likely a previous restart attempt failed..
If you restart a network current without the cleanup=true flag, in the API
response and UI the network's restart required state will change to true which
is wrong. The state/flag should only be true if something went wrong in its
last restart. You may read a recent thread here:
https://markmail.org/message/bn57hymlvohf54b7
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] blueorangutan commented on issue #2900: network: Allow ability to disable rolling restart feature
blueorangutan commented on issue #2900: network: Allow ability to disable rolling restart feature URL: https://github.com/apache/cloudstack/pull/2900#issuecomment-430010789 Trillian test result (tid-3074) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 30676 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2900-t3074-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Smoke tests completed. 64 look OK, 3 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_extract_template | `Failure` | 128.32 | test_templates.py ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py test_06_download_detached_volume | `Failure` | 137.55 | test_volumes.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nvazquez commented on issue #2902: Add checksum sanity validation on template registration
nvazquez commented on issue #2902: Add checksum sanity validation on template registration URL: https://github.com/apache/cloudstack/pull/2902#issuecomment-429994726 Done, thanks @rafaelweingartner for reviewing This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2892: vr: memory and swap optimizations
blueorangutan commented on issue #2892: vr: memory and swap optimizations URL: https://github.com/apache/cloudstack/pull/2892#issuecomment-429985110 Trillian test result (tid-3073) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 25636 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2892-t3073-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 66 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_redundant_vpc_site2site_vpn | `Failure` | 324.02 | test_vpc_vpn.py test_01_vpc_site2site_vpn_multiple_options | `Failure` | 194.25 | test_vpc_vpn.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2593: api: move default response from XML to JSON
rafaelweingartner commented on issue #2593: api: move default response from XML to JSON URL: https://github.com/apache/cloudstack/pull/2593#issuecomment-429967648 As we discussed in CCC Montreal, this would fit our requirements for breaking changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated (ebc6b2f -> 272167c)
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from ebc6b2f Remove push force test file add 63f4d85 PULL_REQUEST_TEMPLATE: simplify and remove unpopular sections (#2876) new 272167c merge forward #2876 -- PULL_REQUEST_TEMPLATE simplification The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: PULL_REQUEST_TEMPLATE.md | 24 +--- 1 file changed, 5 insertions(+), 19 deletions(-)
[cloudstack] 01/01: merge forward #2876 -- PULL_REQUEST_TEMPLATE simplification
This is an automated email from the ASF dual-hosted git repository. rafael pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 272167c3b3d486a97bda43c5af204f5432d645bf Merge: ebc6b2f 63f4d85 Author: Rafael Weingärtner AuthorDate: Mon Oct 15 15:33:13 2018 -0300 merge forward #2876 -- PULL_REQUEST_TEMPLATE simplification PULL_REQUEST_TEMPLATE.md | 24 +--- 1 file changed, 5 insertions(+), 19 deletions(-) diff --cc PULL_REQUEST_TEMPLATE.md index cf1f6a2,a7c739d..c56bc98 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@@ -15,27 -19,9 +19,9 @@@ ## Screenshots (if appropriate): ## How Has This Been Tested? -- - ## Checklist: - - - - [ ] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document. - - [ ] My code follows the code style of this project. - - [ ] My change requires a change to the documentation. - - [ ] I have updated the documentation accordingly. - Testing - - [ ] I have added tests to cover my changes. - - [ ] All relevant new and existing integration tests have passed. - - [ ] A full integration testsuite with all test that can run on my environment has passed. + +
[GitHub] rafaelweingartner closed pull request #2876: PULL_REQUEST_TEMPLATE: simplify and remove unpopular sections
rafaelweingartner closed pull request #2876: PULL_REQUEST_TEMPLATE: simplify and remove unpopular sections URL: https://github.com/apache/cloudstack/pull/2876 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index 17adfe69a31..a7c739d0869 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -4,6 +4,10 @@ + + + + ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) @@ -12,13 +16,6 @@ - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) -## GitHub Issue/PRs - - - - - - ## Screenshots (if appropriate): ## How Has This Been Tested? @@ -27,13 +24,4 @@ -## Checklist: - - -- [ ] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document. -- [ ] My code follows the code style of this project. -- [ ] My change requires a change to the documentation. -- [ ] I have updated the documentation accordingly. -- [ ] I have added tests to cover my changes. -- [ ] All new and existing tests passed. - + This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on a change in pull request #2894: api: don't throttle api discovery for listApis command
rafaelweingartner commented on a change in pull request #2894: api: don't throttle api discovery for listApis command URL: https://github.com/apache/cloudstack/pull/2894#discussion_r225265945 ## File path: api/src/org/apache/cloudstack/acl/APIAclChecker.java ## @@ -0,0 +1,7 @@ +package org.apache.cloudstack.acl; Review comment: You missed the license header here This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner edited a comment on issue #2901: params: allow signatureversion and expires without logging
rafaelweingartner edited a comment on issue #2901: params: allow signatureversion and expires without logging URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-429853434 Two positive feedbacks and successful functional tests executed This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on a change in pull request #2902: Add checksum sanity validation on template registration
rafaelweingartner commented on a change in pull request #2902: Add checksum
sanity validation on template registration
URL: https://github.com/apache/cloudstack/pull/2902#discussion_r225188724
##
File path:
utils/src/main/java/org/apache/cloudstack/utils/security/DigestHelper.java
##
@@ -93,4 +95,33 @@ public static boolean isAlgorithmSupported(String checksum)
{
}
return true;
}
+
+/**
+ * Checks if the algorithm prefix is provided on the checksum
+ */
+public static void checksumSanity(String checksum) {
+if(StringUtils.isNotEmpty(checksum)) {
+if (checksum.contains("{") && checksum.contains("}")) {
+int s = checksum.indexOf('{');
+int e = checksum.indexOf('}');
+if (s == 0 && e > s+1) { // we have an algorithm name of at
least 1 char
+String algorithm = checksum.substring(s + 1, e);
+Map map = creatPaddingLengths();
Review comment:
Can you please rename the method `creatPaddingLengths`? It is misleading (at
least to me).
This method actually returns a map between hashing methods and their
respective hash size. What about `getMapHashTypeBySize` or
`getMapHashByDigestSize`, or something that can express more clearly what the
method is doing.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rafaelweingartner commented on a change in pull request #2902: Add checksum sanity validation on template registration
rafaelweingartner commented on a change in pull request #2902: Add checksum
sanity validation on template registration
URL: https://github.com/apache/cloudstack/pull/2902#discussion_r225191153
##
File path:
utils/src/main/java/org/apache/cloudstack/utils/security/DigestHelper.java
##
@@ -93,4 +95,33 @@ public static boolean isAlgorithmSupported(String checksum)
{
}
return true;
}
+
+/**
+ * Checks if the algorithm prefix is provided on the checksum
+ */
+public static void checksumSanity(String checksum) {
Review comment:
what about a method name with an action that can describe what the method is
doing. E.G. `validateChecksumString`, `checkSanityOfTemplateHashes`, and so on.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rafaelweingartner commented on a change in pull request #2902: Add checksum sanity validation on template registration
rafaelweingartner commented on a change in pull request #2902: Add checksum
sanity validation on template registration
URL: https://github.com/apache/cloudstack/pull/2902#discussion_r225188724
##
File path:
utils/src/main/java/org/apache/cloudstack/utils/security/DigestHelper.java
##
@@ -93,4 +95,33 @@ public static boolean isAlgorithmSupported(String checksum)
{
}
return true;
}
+
+/**
+ * Checks if the algorithm prefix is provided on the checksum
+ */
+public static void checksumSanity(String checksum) {
+if(StringUtils.isNotEmpty(checksum)) {
+if (checksum.contains("{") && checksum.contains("}")) {
+int s = checksum.indexOf('{');
+int e = checksum.indexOf('}');
+if (s == 0 && e > s+1) { // we have an algorithm name of at
least 1 char
+String algorithm = checksum.substring(s + 1, e);
+Map map = creatPaddingLengths();
Review comment:
Can you please rename the method `creatPaddingLengths`? It is misleading (at
least to me).
This method actually returns a map between hashing methods and their
respective hash size. What about ``getMapHashTypeBySize` or
`getMapHashByDigestSize`, or something that can express more clearly what the
method is doing.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rafaelweingartner commented on a change in pull request #2902: Add checksum sanity validation on template registration
rafaelweingartner commented on a change in pull request #2902: Add checksum
sanity validation on template registration
URL: https://github.com/apache/cloudstack/pull/2902#discussion_r225191329
##
File path:
utils/src/test/java/org/apache/cloudstack/utils/security/DigestHelperTest.java
##
@@ -97,6 +97,30 @@ public static void init() throws
UnsupportedEncodingException {
public void reset() throws IOException {
inputStream.reset();
}
+
+@Test(expected = IllegalArgumentException.class)
Review comment:
*
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] nvazquez opened a new pull request #2903: Set http level to INFO as default
nvazquez opened a new pull request #2903: Set http level to INFO as default URL: https://github.com/apache/cloudstack/pull/2903 ## Description Avoid logging bytes on direct download on KVM ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## GitHub Issue/PRs ## Screenshots (if appropriate): ## How Has This Been Tested? ## Checklist: - [x] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document. - [x] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. Testing - [ ] I have added tests to cover my changes. - [ ] All relevant new and existing integration tests have passed. - [ ] A full integration testsuite with all test that can run on my environment has passed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nvazquez opened a new pull request #2902: Add checksum sanity validation on template registration
nvazquez opened a new pull request #2902: Add checksum sanity validation on
template registration
URL: https://github.com/apache/cloudstack/pull/2902
## Description
Add a checksum sanity check on template/ISO registration for direct
downloads on KVM.
Assert that:
- Algorithm is provided as a prefix between braces on the checksum
parameter: `Format: {ALG}HASH`
- Hash length matches the expected one for the provided algorithm
## Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## GitHub Issue/PRs
## Screenshots (if appropriate):
## How Has This Been Tested?
## Checklist:
- [x] I have read the
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
document.
- [x] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
Testing
- [ ] I have added tests to cover my changes.
- [ ] All relevant new and existing integration tests have passed.
- [ ] A full integration testsuite with all test that can run on my
environment has passed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] pyr commented on issue #2901: params: allow signatureversion and expires without logging
pyr commented on issue #2901: params: allow signatureversion and expires without logging URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-429853159 @rafaelweingartner provided I find where to push again, how many approvals should I wait for before merging? (it's been a while since I pushed to the project) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2901: params: allow signatureversion and expires without logging
rafaelweingartner commented on issue #2901: params: allow signatureversion and expires without logging URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-429853434 2 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers
rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r225156698 ## File path: framework/cluster/src/main/java/com/cloud/cluster/ClusterFenceManagerImpl.java ## @@ -22,6 +22,7 @@ import javax.inject.Inject; import javax.naming.ConfigurationException; +import org.apache.cloudstack.management.ManagementServerHost; Review comment: do you need this import here? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers
rafaelweingartner commented on a change in pull request #2578: api: add command
to list management servers
URL: https://github.com/apache/cloudstack/pull/2578#discussion_r225156622
##
File path: framework/cluster/pom.xml
##
@@ -47,8 +47,7 @@
org.apache.cloudstack
cloud-api
${project.version}
-test-jar
Review comment:
Why did you remove this?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers
rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r225156841 ## File path: framework/cluster/src/main/java/com/cloud/cluster/ClusterManagerListener.java ## @@ -16,6 +16,8 @@ // under the License. package com.cloud.cluster; +import org.apache.cloudstack.management.ManagementServerHost; Review comment: Import? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers
rafaelweingartner commented on a change in pull request #2578: api: add command
to list management servers
URL: https://github.com/apache/cloudstack/pull/2578#discussion_r225156473
##
File path:
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41120to41200.java
##
@@ -52,7 +57,15 @@ public boolean supportsRollingUpgrade() {
@Override
public void performDataMigration(Connection conn) {
+updateManagementServerHostUuid(conn);
+}
+private void updateManagementServerHostUuid(Connection conn) {
+try (final PreparedStatement updateStatement =
conn.prepareStatement("UPDATE cloud.mshost SET uuid=UUID()")) {
+updateStatement.executeUpdate();
+} catch (SQLException e) {
+LOG.error("Failed to set dynamic.apichecker.enabled to true,
please run migrate-dynamicroles.py script to manually migrate to dynamic
roles.", e);
Review comment:
This message looks a little bit misleading, or am I mistaken?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers
rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r225156748 ## File path: framework/cluster/src/main/java/com/cloud/cluster/ClusterManager.java ## @@ -16,6 +16,7 @@ // under the License. package com.cloud.cluster; +import org.apache.cloudstack.management.ManagementServerHost; Review comment: Same here This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers
rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r225157204 ## File path: engine/schema/src/main/resources/META-INF/db/schema-41120to41200.sql ## @@ -34,4 +34,7 @@ INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, `rule`, `permission`, INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, `rule`, `permission`, `sort_order`) values (UUID(), 3, 'moveNetworkAclItem', 'ALLOW', 302) ON DUPLICATE KEY UPDATE rule=rule; INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, `rule`, `permission`, `sort_order`) values (UUID(), 4, 'moveNetworkAclItem', 'ALLOW', 260) ON DUPLICATE KEY UPDATE rule=rule; -UPDATE `cloud`.`async_job` SET `removed` = now() WHERE `removed` IS NULL; \ No newline at end of file +UPDATE `cloud`.`async_job` SET `removed` = now() WHERE `removed` IS NULL; + +-- New column for listManagementServers API call +ALTER TABLE `mshost` ADD COLUMN `uuid` varchar(40) AFTER `name`; Review comment: shouldn't you add a default value with the UUID() function? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pyr commented on issue #2901: params: allow signatureversion and expires without logging
pyr commented on issue #2901: params: allow signatureversion and expires without logging URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-429844477 @rafaelweingartner I did not introduce the new parameters, they were introduced as part of the Signature version 3 scheme in the `ApiServer` class. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2901: params: allow signatureversion and expires without logging
rafaelweingartner commented on issue #2901: params: allow signatureversion and expires without logging URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-429843518 You are saying that these parameters are always logged as not valid ones. Therefore, I was assuming that they are somehow new parameters that were introduced by you. It is Monday morning, my brain might not be working yet. P.S. I restarted Jenkins manually. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on a change in pull request #2900: network: Allow ability to disable rolling restart feature
rafaelweingartner commented on a change in pull request #2900: network: Allow
ability to disable rolling restart feature
URL: https://github.com/apache/cloudstack/pull/2900#discussion_r225154560
##
File path:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##
@@ -2860,7 +2860,7 @@ public boolean restartNetwork(final Long networkId,
final Account callerAccount,
s_logger.debug("Implementing the network " + network + " elements and
resources as a part of network restart without cleanup");
try {
implementNetworkElementsAndResources(dest, context, network,
offering);
-setRestartRequired(network, true);
+setRestartRequired(network, false);
Review comment:
this will do the opposite? I mean, if I restart with cleanup, will not this
cause the flag to always be false? Or, is the flag from the command captured
and used somewhere else?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rafaelweingartner commented on a change in pull request #2900: network: Allow ability to disable rolling restart feature
rafaelweingartner commented on a change in pull request #2900: network: Allow
ability to disable rolling restart feature
URL: https://github.com/apache/cloudstack/pull/2900#discussion_r225154560
##
File path:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##
@@ -2860,7 +2860,7 @@ public boolean restartNetwork(final Long networkId,
final Account callerAccount,
s_logger.debug("Implementing the network " + network + " elements and
resources as a part of network restart without cleanup");
try {
implementNetworkElementsAndResources(dest, context, network,
offering);
-setRestartRequired(network, true);
+setRestartRequired(network, false);
Review comment:
this will the opposite? I mean, if I restart with cleanup, will not this
cause the flag to always be false? Or, is the flag from the command captured
and used somewhere else?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] pyr commented on issue #2901: params: allow signatureversion and expires without logging
pyr commented on issue #2901: params: allow signatureversion and expires without logging URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-429842236 I'm not sure I understand the Jenkins failure but it seems unrelated to this PR This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pyr commented on issue #2901: params: allow signatureversion and expires without logging
pyr commented on issue #2901: params: allow signatureversion and expires without logging URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-429841713 @rafaelweingartner which other PR are you referring to? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2901: params: allow signatureversion and expires without logging
rafaelweingartner commented on issue #2901: params: allow signatureversion and expires without logging URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-429841375 Has your other PR been merged already? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pyr opened a new pull request #2901: params: allow signatureversion and expires without logging
pyr opened a new pull request #2901: params: allow signatureversion and expires without logging URL: https://github.com/apache/cloudstack/pull/2901 ## Description This patch considers the new expires and signatureversion parameters valid. Without this, all calls log when using the V3 signature scheme. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [X] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2900: network: Allow ability to disable rolling restart feature
blueorangutan commented on issue #2900: network: Allow ability to disable rolling restart feature URL: https://github.com/apache/cloudstack/pull/2900#issuecomment-429822471 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2892: vr: memory and swap optimizations
blueorangutan commented on issue #2892: vr: memory and swap optimizations URL: https://github.com/apache/cloudstack/pull/2892#issuecomment-429822462 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2900: network: Allow ability to disable rolling restart feature
rhtyd commented on issue #2900: network: Allow ability to disable rolling restart feature URL: https://github.com/apache/cloudstack/pull/2900#issuecomment-429822249 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2892: vr: memory and swap optimizations
rhtyd commented on issue #2892: vr: memory and swap optimizations URL: https://github.com/apache/cloudstack/pull/2892#issuecomment-429822296 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2900: network: Allow ability to disable rolling restart feature
blueorangutan commented on issue #2900: network: Allow ability to disable rolling restart feature URL: https://github.com/apache/cloudstack/pull/2900#issuecomment-429810940 Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2344 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2897: Allow enable the Java remote Debug for CloudStack Agent
blueorangutan commented on issue #2897: Allow enable the Java remote Debug for CloudStack Agent URL: https://github.com/apache/cloudstack/pull/2897#issuecomment-429802877 Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2342 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2892: vr: memory and swap optimizations
blueorangutan commented on issue #2892: vr: memory and swap optimizations URL: https://github.com/apache/cloudstack/pull/2892#issuecomment-429802878 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2343 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2900: network: Allow ability to disable rolling restart feature
blueorangutan commented on issue #2900: network: Allow ability to disable rolling restart feature URL: https://github.com/apache/cloudstack/pull/2900#issuecomment-429802125 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2900: network: Allow ability to disable rolling restart feature
rhtyd commented on issue #2900: network: Allow ability to disable rolling restart feature URL: https://github.com/apache/cloudstack/pull/2900#issuecomment-429801851 @borisstoyanov can you help test this one (manually maybe, both cases for restart with/without cleanup with/without redundant isolated network and VPCs) /cc @PaulAngus @DagSonsteboSB @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2900: network: Allow ability to disable rolling restart feature
rhtyd commented on a change in pull request #2900: network: Allow ability to
disable rolling restart feature
URL: https://github.com/apache/cloudstack/pull/2900#discussion_r225119494
##
File path:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##
@@ -2860,7 +2860,7 @@ public boolean restartNetwork(final Long networkId,
final Account callerAccount,
s_logger.debug("Implementing the network " + network + " elements and
resources as a part of network restart without cleanup");
try {
implementNetworkElementsAndResources(dest, context, network,
offering);
-setRestartRequired(network, true);
+setRestartRequired(network, false);
Review comment:
This fixes an issue where restarting a network without cleanup always put
the network's restart required flag to true.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rhtyd opened a new pull request #2900: network: Allow ability to disable rolling restart feature
rhtyd opened a new pull request #2900: network: Allow ability to disable rolling restart feature URL: https://github.com/apache/cloudstack/pull/2900 This adds a global setting for admins who may want the lebacy behaviour of network restart with cleanup=true. In future, this setting may be removed. The examples of error are in #2880, by having this toggle switch a temporary relief may be possible for such environments. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## How Has This Been Tested? The global settings ships as 'true', so rolling restart feature is shipped as the default behaviour. If somebody wants legacy behaviour they can set the value to false and try to restart an isolated network or redundant network with cleanup enabled. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2862: VR stop/start/reboot commands failed
rhtyd commented on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-429800381 @resmo we'll need additional logs from an env/VRs where you're seeing the error to debug/investigate and fix this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2892: vr: memory and swap optimizations
blueorangutan commented on issue #2892: vr: memory and swap optimizations URL: https://github.com/apache/cloudstack/pull/2892#issuecomment-429789707 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2892: vr: memory and swap optimizations
rhtyd commented on issue #2892: vr: memory and swap optimizations URL: https://github.com/apache/cloudstack/pull/2892#issuecomment-429789496 Rebased against latest 4.11 and fixed review issues. @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2897: Allow enable the Java remote Debug for CloudStack Agent
blueorangutan commented on issue #2897: Allow enable the Java remote Debug for CloudStack Agent URL: https://github.com/apache/cloudstack/pull/2897#issuecomment-429780675 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2897: Allow enable the Java remote Debug for CloudStack Agent
rhtyd commented on issue #2897: Allow enable the Java remote Debug for CloudStack Agent URL: https://github.com/apache/cloudstack/pull/2897#issuecomment-429780361 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2578: api: add command to list management servers
rhtyd commented on issue #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#issuecomment-429757210 Looks great @marcaurele I'm busy this week with some outstanding issues wrt 4.11.2 release. I'll review this after that. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcaurele commented on issue #2898: docker: add compose file for database
marcaurele commented on issue #2898: docker: add compose file for database URL: https://github.com/apache/cloudstack/pull/2898#issuecomment-429756453 I perform my local development with that docker setup and thought I could share it to see if it can help others. Don't hesitate to close it if this is not really needed, or some sort of duplicate. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd opened a new issue #2899: Initial agent connect dropped by management server
rhtyd opened a new issue #2899: Initial agent connect dropped by management server URL: https://github.com/apache/cloudstack/issues/2899 It is observed in 4.11.1/2-rc2 that in some environments when KVM agent connects to the management server, the channel is closed just after initial cmd. After that the ModifyStoragePool fails to be sent to the kvm host as the agent is disconnected putting the host in Alert state. The agent, however, will reconnect and finally, the state will be Up. In a rare setup, where certificates were already provisioned the agent failed to connect to the mgmt server at all on setup (adding host out of band) and the auth strictness was false. # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ Agent ~~~ # CLOUDSTACK VERSION ~~~ 4.11.1 ~~~ # CONFIGURATION This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcaurele opened a new pull request #2898: docker: add compose file for database
marcaurele opened a new pull request #2898: docker: add compose file for database URL: https://github.com/apache/cloudstack/pull/2898 ## Description A docker-compose file to setup quickly the database for CS. This helps during local development and remove the need to install a local MariaDB/MySQL. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## GitHub Issue/PRs None ## Screenshots (if appropriate): ## How Has This Been Tested? `docker-compose up` starts the MariaDB 10.0 database for local development. ## Checklist: - [x] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document. - [ ] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. Testing - [ ] I have added tests to cover my changes. - [ ] All relevant new and existing integration tests have passed. - [ ] A full integration testsuite with all test that can run on my environment has passed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcaurele commented on issue #2578: api: add command to list management servers
marcaurele commented on issue #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#issuecomment-429753971 The PR is ready now. Conflicts are fixed, WUI is updated with a new block for management servers with a simple detail view. cc @rhtyd @DaanHoogland @rafaelweingartner @bwsw This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcaurele commented on issue #2578: api: add command to list management servers
marcaurele commented on issue #2578: api: add command to list management servers
URL: https://github.com/apache/cloudstack/pull/2578#issuecomment-429748052
```
› cs listManagementServers --region=dev:admin
{
"count": 3,
"managementserver": [
{
"id": "5a45d7ec-4504-4c7e-a816-76e56e030a65",
"name": "liskam",
"state": "Down",
"version": "4.12.0.0-SNAPSHOT"
},
{
"id": "2510dd9d-51e0-4523-9198-28835a7b2100",
"name": "liskam",
"state": "Down",
"version": "4.12.0.0-SNAPSHOT"
},
{
"id": "06a3eb78-cd20-42d5-ae17-9084559134d0",
"name": "liskam",
"state": "Up",
"version": "4.12.0.0-SNAPSHOT"
}
]
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] marcaurele commented on issue #2578: api: add command to list management servers
marcaurele commented on issue #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#issuecomment-429747225 Getting better, detail view is ready too  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
