[GitHub] blueorangutan commented on issue #2893: ApiServer: signature v3 to accept more formats
blueorangutan commented on issue #2893: ApiServer: signature v3 to accept more formats URL: https://github.com/apache/cloudstack/pull/2893#issuecomment-430882182 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #1448: CLOUDSTACK-9315: Removed unused Classes
rhtyd commented on issue #1448: CLOUDSTACK-9315: Removed unused Classes URL: https://github.com/apache/cloudstack/pull/1448#issuecomment-430882113 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #1448: CLOUDSTACK-9315: Removed unused Classes
blueorangutan commented on issue #1448: CLOUDSTACK-9315: Removed unused Classes URL: https://github.com/apache/cloudstack/pull/1448#issuecomment-430882175 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2893: ApiServer: signature v3 to accept more formats
rhtyd commented on issue #2893: ApiServer: signature v3 to accept more formats URL: https://github.com/apache/cloudstack/pull/2893#issuecomment-430882045 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd edited a comment on issue #2901: params: allow signatureversion and expires without logging
rhtyd edited a comment on issue #2901: params: allow signatureversion and expires without logging URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-430881076 @pyr this is not acceptable, you merged a commit on master directly without the PR id and without any testing results on them. Your change may therefore potentially break master for others. Instead of closing or pushing the change, you should have reopened this PR or create a new PR and wait for test results, even though we requested you to re-open your PR. If things were not clear you could discuss and/or ask questions but you committed the change on master. Also now the PR status is `closed` and not `merged` this will cause search/audit issues in future. You may see how other PRs get reviewed, tested and (squash) merged. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2901: params: allow signatureversion and expires without logging
blueorangutan commented on issue #2901: params: allow signatureversion and expires without logging URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-430881303 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2901: params: allow signatureversion and expires without logging
rhtyd commented on issue #2901: params: allow signatureversion and expires without logging URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-430881076 @pyr this is not acceptable, you merged a commit on master directly without the PR id and without any testing results on them. Your change may therefore potentially break master for others. Instead of closing or pushing the change, you should have reopened this PR or create a new PR and wait for test results, even though we requested you to re-open your PR. If things were not clear you could discuss and/or ask questions but you committed the change on master. You may see how other PRs get reviewed, tested and (squash) merged. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2901: params: allow signatureversion and expires without logging
rhtyd commented on issue #2901: params: allow signatureversion and expires without logging URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-430881142 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pyr commented on issue #2901: params: allow signatureversion and expires without logging
pyr commented on issue #2901: params: allow signatureversion and expires without logging URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-430852525 @rafaelweingartner I rebased on master and pushed, 58b4e71b0e62a0e96e6eb20e96234a1599d0ffd0 is on master now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #1448: CLOUDSTACK-9315: Removed unused Classes
rafaelweingartner commented on issue #1448: CLOUDSTACK-9315: Removed unused Classes URL: https://github.com/apache/cloudstack/pull/1448#issuecomment-430843227 @nvazquez do you know what happened with the tests? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2893: ApiServer: signature v3 to accept more formats
blueorangutan commented on issue #2893: ApiServer: signature v3 to accept more formats URL: https://github.com/apache/cloudstack/pull/2893#issuecomment-430825245 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2352 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2893: ApiServer: signature v3 to accept more formats
blueorangutan commented on issue #2893: ApiServer: signature v3 to accept more formats URL: https://github.com/apache/cloudstack/pull/2893#issuecomment-430819661 @rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2893: ApiServer: signature v3 to accept more formats
rafaelweingartner commented on issue #2893: ApiServer: signature v3 to accept more formats URL: https://github.com/apache/cloudstack/pull/2893#issuecomment-430819531 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2901: params: allow signatureversion and expires without logging
rafaelweingartner commented on issue #2901: params: allow signatureversion and expires without logging URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-430785887 @pyr somebody has to merge it. Your PR was not merged, and your commit is not in our code base yet. What do you mean with "went ahead and committed"? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pyr commented on issue #2901: params: allow signatureversion and expires without logging
pyr commented on issue #2901: params: allow signatureversion and expires without logging URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-430769577 @rhtyd Hi rohit, this wasn't clear to me, I went ahead and committed assuming what @rafaelweingartner mentioned was sufficient, I'm happy to revert if you think that is warranted. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner opened a new pull request #2905: Fix delete domain button in the UI to update only after deleteDomain job finishes
rafaelweingartner opened a new pull request #2905: Fix delete domain button in the UI to update only after deleteDomain job finishes URL: https://github.com/apache/cloudstack/pull/2905 ## Description When the “deleteDomain” command is sent via UI, the HTML is already updated assuming that the “deleteDomain” command will actually delete it. However, there are cases (domain with allocated resources) that will not allow ACS to remove the command; as a consequence, the UI will not be in sync with ACS state, which can lead to misunderstandings. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## How Has This Been Tested? Manually This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch 4.11.2.0-RC20181017T1751 created (now a8e53d0)
This is an automated email from the ASF dual-hosted git repository. paul_a pushed a change to branch 4.11.2.0-RC20181017T1751 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. at a8e53d0 Updating pom.xml version numbers for release 4.11.2.0 This branch includes the following new commits: new a8e53d0 Updating pom.xml version numbers for release 4.11.2.0 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[cloudstack] 01/01: Updating pom.xml version numbers for release 4.11.2.0
This is an automated email from the ASF dual-hosted git repository. paul_a pushed a commit to branch 4.11.2.0-RC20181017T1751 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit a8e53d0e9674028973c8f3a98a5a8ff15b24f5da Author: Paul Angus AuthorDate: Wed Oct 17 17:51:42 2018 +0100 Updating pom.xml version numbers for release 4.11.2.0 Signed-off-by: Paul Angus --- agent/pom.xml | 2 +- api/pom.xml | 2 +- client/pom.xml| 2 +- core/pom.xml | 2 +- debian/changelog | 6 ++ developer/pom.xml | 2 +- engine/api/pom.xml| 2 +- engine/components-api/pom.xml | 2 +- engine/network/pom.xml| 2 +- engine/orchestration/pom.xml | 2 +- engine/pom.xml| 2 +- engine/schema/pom.xml | 2 +- engine/service/pom.xml| 2 +- engine/storage/cache/pom.xml | 2 +- engine/storage/configdrive/pom.xml| 2 +- engine/storage/datamotion/pom.xml | 2 +- engine/storage/image/pom.xml | 2 +- engine/storage/integration-test/pom.xml | 2 +- engine/storage/pom.xml| 2 +- engine/storage/snapshot/pom.xml | 2 +- engine/storage/volume/pom.xml | 2 +- framework/agent-lb/pom.xml| 2 +- framework/ca/pom.xml | 2 +- framework/cluster/pom.xml | 2 +- framework/config/pom.xml | 2 +- framework/db/pom.xml | 2 +- framework/direct-download/pom.xml | 2 +- framework/events/pom.xml | 2 +- framework/ipc/pom.xml | 2 +- framework/jobs/pom.xml| 2 +- framework/managed-context/pom.xml | 2 +- framework/pom.xml | 2 +- framework/quota/pom.xml | 2 +- framework/rest/pom.xml| 2 +- framework/security/pom.xml| 2 +- framework/spring/lifecycle/pom.xml| 2 +- framework/spring/module/pom.xml | 2 +- maven-standard/pom.xml| 2 +- plugins/acl/dynamic-role-based/pom.xml| 2 +- plugins/acl/static-role-based/pom.xml | 2 +- plugins/affinity-group-processors/explicit-dedication/pom.xml | 2 +- plugins/affinity-group-processors/host-affinity/pom.xml | 2 +- plugins/affinity-group-processors/host-anti-affinity/pom.xml | 2 +- plugins/alert-handlers/snmp-alerts/pom.xml| 2 +- plugins/alert-handlers/syslog-alerts/pom.xml | 2 +- plugins/api/discovery/pom.xml | 2 +- plugins/api/rate-limit/pom.xml| 2 +- plugins/api/solidfire-intg-test/pom.xml | 2 +- plugins/api/vmware-sioc/pom.xml | 2 +- plugins/ca/root-ca/pom.xml| 2 +- plugins/database/mysql-ha/pom.xml | 2 +- plugins/database/quota/pom.xml| 2 +- plugins/dedicated-resources/pom.xml | 2 +- plugins/deployment-planners/implicit-dedication/pom.xml | 2 +- plugins/deployment-planners/user-concentrated-pod/pom.xml | 2 +- plugins/deployment-planners/user-dispersing/pom.xml | 2 +- plugins/event-bus/inmemory/pom.xml| 2 +- plugins/event-bus/kafka/pom.xml | 2 +- plugins/event-bus/rabbitmq/pom.xml| 2 +- plugins/file-systems/netapp/pom.xml | 2 +- plugins/ha-planners/skip-heurestics/pom.xml | 2 +- plugins/host-allocators/random/pom.xml| 2 +- plugins/hypervisors/baremetal/pom.xml | 2 +- plugins/hypervisors/hyperv/pom.xml| 2 +- plugins/hypervisors/kvm/pom.xml | 2 +- plugins/hypervisors/ovm/pom.xml
svn commit: r30117 - in /dev/cloudstack/4.11.2.0: apache-cloudstack-4.11.2.0-src.tar.bz2 apache-cloudstack-4.11.2.0-src.tar.bz2.asc apache-cloudstack-4.11.2.0-src.tar.bz2.md5 apache-cloudstack-4.11.2.
Author: paul_a Date: Wed Oct 17 16:53:52 2018 New Revision: 30117 Log: Committing release candidate artifacts for 4.11.2.0 to dist/dev/cloudstack in preparation for release vote Added: dev/cloudstack/4.11.2.0/apache-cloudstack-4.11.2.0-src.tar.bz2 (with props) dev/cloudstack/4.11.2.0/apache-cloudstack-4.11.2.0-src.tar.bz2.asc (with props) dev/cloudstack/4.11.2.0/apache-cloudstack-4.11.2.0-src.tar.bz2.md5 dev/cloudstack/4.11.2.0/apache-cloudstack-4.11.2.0-src.tar.bz2.sha512 Added: dev/cloudstack/4.11.2.0/apache-cloudstack-4.11.2.0-src.tar.bz2 == Binary file - no diff available. Propchange: dev/cloudstack/4.11.2.0/apache-cloudstack-4.11.2.0-src.tar.bz2 -- svn:mime-type = application/x-bzip2 Added: dev/cloudstack/4.11.2.0/apache-cloudstack-4.11.2.0-src.tar.bz2.asc == Binary file - no diff available. Propchange: dev/cloudstack/4.11.2.0/apache-cloudstack-4.11.2.0-src.tar.bz2.asc -- svn:mime-type = application/pgp-signature Added: dev/cloudstack/4.11.2.0/apache-cloudstack-4.11.2.0-src.tar.bz2.md5 == --- dev/cloudstack/4.11.2.0/apache-cloudstack-4.11.2.0-src.tar.bz2.md5 (added) +++ dev/cloudstack/4.11.2.0/apache-cloudstack-4.11.2.0-src.tar.bz2.md5 Wed Oct 17 16:53:52 2018 @@ -0,0 +1,2 @@ +apache-cloudstack-4.11.2.0-src.tar.bz2: DC E5 08 33 E0 B9 B5 DE CB 5D 0C AA 66 +65 07 E8 Added: dev/cloudstack/4.11.2.0/apache-cloudstack-4.11.2.0-src.tar.bz2.sha512 == --- dev/cloudstack/4.11.2.0/apache-cloudstack-4.11.2.0-src.tar.bz2.sha512 (added) +++ dev/cloudstack/4.11.2.0/apache-cloudstack-4.11.2.0-src.tar.bz2.sha512 Wed Oct 17 16:53:52 2018 @@ -0,0 +1,4 @@ +apache-cloudstack-4.11.2.0-src.tar.bz2: 836F55ED 03ED19FE 3562699A 8FBF1425 +88074670 FF1FD48D DB79CCC6 CB312F00 +A27E95B7 456EB9E9 724E2FE5 78E98268 +B194AB29 716615E6 834B9BFA A262E12B
[GitHub] Slair1 commented on issue #2722: CLOUDSTACK-10310 Fix KVM reboot on storage issue
Slair1 commented on issue #2722: CLOUDSTACK-10310 Fix KVM reboot on storage issue URL: https://github.com/apache/cloudstack/pull/2722#issuecomment-430704620 @somejfn maybe because I have PR #2474 also installed? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2862: VR stop/start/reboot commands failed
rhtyd commented on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430702878 @izenk the routing issue you've shared has been fixed and is in 4.11.2-rc2: https://github.com/apache/cloudstack/pull/2791/files You may wait for 4.11.2.0 release or try to manually apply changes in the VR scripts in your test VR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] somejfn commented on issue #2722: CLOUDSTACK-10310 Fix KVM reboot on storage issue
somejfn commented on issue #2722: CLOUDSTACK-10310 Fix KVM reboot on storage issue URL: https://github.com/apache/cloudstack/pull/2722#issuecomment-430702548 @Slair1 Testing with virtlockd, if the host that crashed can't come back I had to manually clear the locks for VM HA to fire and restart the VM. At that point it's the same as disabling VM HA and manually restart VM's after a KVM host crash.How is your setup different ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] somejfn commented on issue #2890: KVMHAMonitor thread blocks indefinitely while NFS not available
somejfn commented on issue #2890: KVMHAMonitor thread blocks indefinitely while NFS not available URL: https://github.com/apache/cloudstack/issues/2890#issuecomment-430701430 This morning I confirmed the behavior on 4.9 is different than 4.11. When there's a long lasting (say 15 minutes) NFS hang the agent stays Up and when NFS operations resumes everyone's happy. Note we did disable the automatic reboot in the heartbeat script for that to work. This saved us from massive reboots and VM outages before when we had a network maintenance that cut all KVM host from NFS for 22 minutes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk commented on issue #2862: VR stop/start/reboot commands failed
izenk commented on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430666789 @rhtyd no, can't I have only 4.11.1 which is 'production' This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated (e871638 -> 233f46c)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from e871638 Merge remote-tracking branch 'origin/4.11' add 5ce14df network: Allow ability to disable rolling restart feature (#2900) new 233f46c Merge remote-tracking branch 'origin/4.11' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../orchestration/service/NetworkOrchestrationService.java | 3 +++ .../cloudstack/engine/orchestration/NetworkOrchestrator.java | 10 +- server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java | 7 +++ 3 files changed, 19 insertions(+), 1 deletion(-)
[cloudstack] branch 4.11 updated: network: Allow ability to disable rolling restart feature (#2900)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.11 by this push:
new 5ce14df network: Allow ability to disable rolling restart feature
(#2900)
5ce14df is described below
commit 5ce14df31fa0477c1709d49c0a7b61e0f5c0ea7c
Author: Rohit Yadav
AuthorDate: Wed Oct 17 20:27:08 2018 +0530
network: Allow ability to disable rolling restart feature (#2900)
This adds a global setting for admins who may not want the rolling
restart of routers or are seeing any issues around it. In future, this
setting may be removed.
Signed-off-by: Rohit Yadav
---
.../orchestration/service/NetworkOrchestrationService.java | 3 +++
.../cloudstack/engine/orchestration/NetworkOrchestrator.java | 12 ++--
server/src/com/cloud/network/vpc/VpcManagerImpl.java | 7 +++
3 files changed, 20 insertions(+), 2 deletions(-)
diff --git
a/engine/api/src/org/apache/cloudstack/engine/orchestration/service/NetworkOrchestrationService.java
b/engine/api/src/org/apache/cloudstack/engine/orchestration/service/NetworkOrchestrationService.java
index 82d0566..fa7601d 100644
---
a/engine/api/src/org/apache/cloudstack/engine/orchestration/service/NetworkOrchestrationService.java
+++
b/engine/api/src/org/apache/cloudstack/engine/orchestration/service/NetworkOrchestrationService.java
@@ -93,6 +93,9 @@ public interface NetworkOrchestrationService {
ConfigKey ForgedTransmits = new ConfigKey("Advanced",
Boolean.class, "network.forged.transmits", "true",
"Whether to allow or deny forged transmits on nics for applicable
network elements such as for vswitch/dvswitch portgroups.", true);
+ConfigKey RollingRestartEnabled = new
ConfigKey("Advanced", Boolean.class, "network.rolling.restart", "true",
+"Whether to allow or deny rolling restart of network routers.",
true);
+
List setupNetwork(Account owner, NetworkOffering
offering, DeploymentPlan plan, String name, String displayText, boolean
isDefault)
throws ConcurrentOperationException;
diff --git
a/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
b/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
index 5b27203..55015ce 100644
---
a/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
+++
b/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
@@ -2860,7 +2860,7 @@ public class NetworkOrchestrator extends ManagerBase
implements NetworkOrchestra
s_logger.debug("Implementing the network " + network + " elements and
resources as a part of network restart without cleanup");
try {
implementNetworkElementsAndResources(dest, context, network,
offering);
-setRestartRequired(network, true);
+setRestartRequired(network, false);
return true;
} catch (final Exception ex) {
s_logger.warn("Failed to implement network " + network + "
elements and resources as a part of network restart due to ", ex);
@@ -2927,6 +2927,14 @@ public class NetworkOrchestrator extends ManagerBase
implements NetworkOrchestra
* @throws InsufficientCapacityException
*/
private boolean rollingRestartRouters(final NetworkVO network, final
NetworkOffering offering, final DeployDestination dest, final
ReservationContext context) throws ResourceUnavailableException,
ConcurrentOperationException, InsufficientCapacityException {
+if (!NetworkOrchestrationService.RollingRestartEnabled.value()) {
+if (shutdownNetworkElementsAndResources(context, true, network)) {
+implementNetworkElementsAndResources(dest, context, network,
offering);
+return true;
+}
+s_logger.debug("Failed to shutdown the network elements and
resources as a part of network restart: " + network.getState());
+return false;
+}
s_logger.debug("Performing rolling restart of routers of network " +
network);
destroyExpendableRouters(_routerDao.findByNetwork(network.getId()),
context);
@@ -3831,6 +3839,6 @@ public class NetworkOrchestrator extends ManagerBase
implements NetworkOrchestra
public ConfigKey[] getConfigKeys() {
return new ConfigKey[] {NetworkGcWait, NetworkGcInterval,
NetworkLockTimeout,
GuestDomainSuffix, NetworkThrottlingRate, MinVRVersion,
-PromiscuousMode, MacAddressChanges, ForgedTransmits};
+PromiscuousMode, MacAddressChanges, ForgedTransmits,
RollingRestartEnabled};
}
}
diff --git a/server/src/com/cloud/network/vpc/VpcManagerImpl.java
b/server/src/com/cloud/network/vpc/VpcManagerImpl.java
index b32498b..b8a797b 100644
---
[GitHub] rhtyd closed pull request #2900: network: Allow ability to disable rolling restart feature
rhtyd closed pull request #2900: network: Allow ability to disable rolling
restart feature
URL: https://github.com/apache/cloudstack/pull/2900
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/engine/api/src/org/apache/cloudstack/engine/orchestration/service/NetworkOrchestrationService.java
b/engine/api/src/org/apache/cloudstack/engine/orchestration/service/NetworkOrchestrationService.java
index 82d0566169a..fa7601db27d 100644
---
a/engine/api/src/org/apache/cloudstack/engine/orchestration/service/NetworkOrchestrationService.java
+++
b/engine/api/src/org/apache/cloudstack/engine/orchestration/service/NetworkOrchestrationService.java
@@ -93,6 +93,9 @@
ConfigKey ForgedTransmits = new ConfigKey("Advanced",
Boolean.class, "network.forged.transmits", "true",
"Whether to allow or deny forged transmits on nics for applicable
network elements such as for vswitch/dvswitch portgroups.", true);
+ConfigKey RollingRestartEnabled = new
ConfigKey("Advanced", Boolean.class, "network.rolling.restart", "true",
+"Whether to allow or deny rolling restart of network routers.",
true);
+
List setupNetwork(Account owner, NetworkOffering
offering, DeploymentPlan plan, String name, String displayText, boolean
isDefault)
throws ConcurrentOperationException;
diff --git
a/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
b/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
index 5b27203a7dc..55015ce68af 100644
---
a/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
+++
b/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
@@ -2860,7 +2860,7 @@ public boolean restartNetwork(final Long networkId, final
Account callerAccount,
s_logger.debug("Implementing the network " + network + " elements and
resources as a part of network restart without cleanup");
try {
implementNetworkElementsAndResources(dest, context, network,
offering);
-setRestartRequired(network, true);
+setRestartRequired(network, false);
return true;
} catch (final Exception ex) {
s_logger.warn("Failed to implement network " + network + "
elements and resources as a part of network restart due to ", ex);
@@ -2927,6 +2927,14 @@ public boolean areRoutersRunning(final List routers) {
* @throws InsufficientCapacityException
*/
private boolean rollingRestartRouters(final NetworkVO network, final
NetworkOffering offering, final DeployDestination dest, final
ReservationContext context) throws ResourceUnavailableException,
ConcurrentOperationException, InsufficientCapacityException {
+if (!NetworkOrchestrationService.RollingRestartEnabled.value()) {
+if (shutdownNetworkElementsAndResources(context, true, network)) {
+implementNetworkElementsAndResources(dest, context, network,
offering);
+return true;
+}
+s_logger.debug("Failed to shutdown the network elements and
resources as a part of network restart: " + network.getState());
+return false;
+}
s_logger.debug("Performing rolling restart of routers of network " +
network);
destroyExpendableRouters(_routerDao.findByNetwork(network.getId()),
context);
@@ -3831,6 +3839,6 @@ public String getConfigComponentName() {
public ConfigKey[] getConfigKeys() {
return new ConfigKey[] {NetworkGcWait, NetworkGcInterval,
NetworkLockTimeout,
GuestDomainSuffix, NetworkThrottlingRate, MinVRVersion,
-PromiscuousMode, MacAddressChanges, ForgedTransmits};
+PromiscuousMode, MacAddressChanges, ForgedTransmits,
RollingRestartEnabled};
}
}
diff --git a/server/src/com/cloud/network/vpc/VpcManagerImpl.java
b/server/src/com/cloud/network/vpc/VpcManagerImpl.java
index b32498b254d..b8a797b44bc 100644
--- a/server/src/com/cloud/network/vpc/VpcManagerImpl.java
+++ b/server/src/com/cloud/network/vpc/VpcManagerImpl.java
@@ -2458,6 +2458,13 @@ public boolean isSrcNatIpRequired(long vpcOfferingId) {
* @throws InsufficientCapacityException
*/
private boolean rollingRestartVpc(final Vpc vpc, final ReservationContext
context) throws ResourceUnavailableException, ConcurrentOperationException,
InsufficientCapacityException {
+if (!NetworkOrchestrationService.RollingRestartEnabled.value()) {
+if (shutdownVpc(vpc.getId())) {
+return startVpc(vpc.getId(), false);
+}
+s_logger.warn("Failed to shutdown vpc as a part of VPC " + vpc +
[GitHub] rhtyd commented on issue #2900: network: Allow ability to disable rolling restart feature
rhtyd commented on issue #2900: network: Allow ability to disable rolling restart feature URL: https://github.com/apache/cloudstack/pull/2900#issuecomment-430662570 Merging this to not further block 4.11 rc3. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2900: network: Allow ability to disable rolling restart feature
rhtyd commented on a change in pull request #2900: network: Allow ability to
disable rolling restart feature
URL: https://github.com/apache/cloudstack/pull/2900#discussion_r225965883
##
File path:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##
@@ -2927,6 +2927,14 @@ public boolean areRoutersRunning(final List routers) {
* @throws InsufficientCapacityException
*/
private boolean rollingRestartRouters(final NetworkVO network, final
NetworkOffering offering, final DeployDestination dest, final
ReservationContext context) throws ResourceUnavailableException,
ConcurrentOperationException, InsufficientCapacityException {
+if (!NetworkOrchestrationService.RollingRestartEnabled.value()) {
Review comment:
If rolling restart is false (disabled), then legacy restart behaviour will
be used, which first shutsdown and destroys VRs before starting new ones.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rhtyd commented on issue #2862: VR stop/start/reboot commands failed
rhtyd commented on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430661393 @izenk can you confirm if you tested 4.11.1 or 4.11.2-rc2? A routing related bug was fixed which is in 4.11.2-rc2. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk edited a comment on issue #2862: VR stop/start/reboot commands failed
izenk edited a comment on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430630367 @rhtyd Looks like I found the reason (not the root, but near) https://user-images.githubusercontent.com/6417697/47089951-8795c900-d22a-11e8-859f-1bc9a24f37f9.png;> rule: from all lookup Table_eth1 and in this table there is no route for 169.254.x.x, so everything goes through default via public 10.9.x.x This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk edited a comment on issue #2862: VR stop/start/reboot commands failed
izenk edited a comment on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430630367 @rhtyd Looks like I found the reason (not the root, but near) https://user-images.githubusercontent.com/6417697/47089951-8795c900-d22a-11e8-859f-1bc9a24f37f9.png;> rule: from all lookup Table_eth1 and in this table there is no route for 169.254.x.x, so everything goes through default via public 10.9.x.x This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk edited a comment on issue #2862: VR stop/start/reboot commands failed
izenk edited a comment on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430630367 @rhtyd Looks like I found the reason (not the root, but near) https://user-images.githubusercontent.com/6417697/47089951-8795c900-d22a-11e8-859f-1bc9a24f37f9.png;> rule: from all lookup Table_eth1 and in this table there is no route for 169.254 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk commented on issue #2862: VR stop/start/reboot commands failed
izenk commented on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430630367 @rhtyd Looks like I found the reason (not the root, but near) https://user-images.githubusercontent.com/6417697/47089951-8795c900-d22a-11e8-859f-1bc9a24f37f9.png;> This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk edited a comment on issue #2862: VR stop/start/reboot commands failed
izenk edited a comment on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430556491 @rhtyd I tried to ping 169.254.0.1 from "Starting" VR At the same time, on the KVM host I ran `tcpdump -nn -i any icmp` an result is: ~~~ 11:23:43.492824 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:43.492843 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:43.492846 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:43.492849 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:44.493918 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:44.493936 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:44.493939 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:44.493942 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:45.495031 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 11:23:45.495056 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 11:23:45.495060 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 11:23:45.495063 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 ~~~ 10.9.2.206 is public IP(SNAT) on eth0 on "Starting" VR iptables does not have any lines related to 10.9.2.206 and even eth0 so, from my side it looks like a routing problem (taken into account that arping is wokring) https://user-images.githubusercontent.com/6417697/47081623-dc7a1500-d213-11e8-84d6-8b6996af9101.png;> More details: if I start ping from KVM host while VR is starting, I can see a small amount if time when ping is successful, but then it starts failing. Looks likes some configuration is going during VR boot and that breaks linklocal connectivity. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk edited a comment on issue #2862: VR stop/start/reboot commands failed
izenk edited a comment on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430556491 @rhtyd I tried to ping 169.254.0.1 from "Starting" VR At the same time, on the KVM host I ran `tcpdump -nn -i any icmp` an result is: ~~~ 11:23:43.492824 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:43.492843 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:43.492846 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:43.492849 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:44.493918 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:44.493936 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:44.493939 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:44.493942 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:45.495031 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 11:23:45.495056 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 11:23:45.495060 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 11:23:45.495063 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 ~~~ 10.9.2.206 is public IP(SNAT) on eth0 on "Starting" VR iptables does not have any lines related to 10.9.2.206 and even eth0 so, from my side it looks like a routing problem (taken into account that arping is wokring) https://user-images.githubusercontent.com/6417697/47081623-dc7a1500-d213-11e8-84d6-8b6996af9101.png;> More details: if I start ping from KVM host during VR is starting, I can see a small amount if time that ping is successful, but then it starts failing. Looks likes some configuration is going during VR boot and that breaks linklocal connectivity This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on a change in pull request #2900: network: Allow ability to disable rolling restart feature
rafaelweingartner commented on a change in pull request #2900: network: Allow
ability to disable rolling restart feature
URL: https://github.com/apache/cloudstack/pull/2900#discussion_r225902370
##
File path:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##
@@ -2927,6 +2927,14 @@ public boolean areRoutersRunning(final List routers) {
* @throws InsufficientCapacityException
*/
private boolean rollingRestartRouters(final NetworkVO network, final
NetworkOffering offering, final DeployDestination dest, final
ReservationContext context) throws ResourceUnavailableException,
ConcurrentOperationException, InsufficientCapacityException {
+if (!NetworkOrchestrationService.RollingRestartEnabled.value()) {
Review comment:
If the rolling restart is not enabled, what does it mean? I mean, if the
rolling restart is not enabled, will ACS do a "traditional" VPC/router restart?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rafaelweingartner commented on a change in pull request #1448: CLOUDSTACK-9315: Removed unused Classes
rafaelweingartner commented on a change in pull request #1448: CLOUDSTACK-9315: Removed unused Classes URL: https://github.com/apache/cloudstack/pull/1448#discussion_r225895387 ## File path: server/src/main/java/com/cloud/configuration/Config.java ## @@ -1836,9 +1836,9 @@ Boolean.class, "execute.in.sequence.network.element.commands", "false", -"If set to true, DhcpEntryCommand, SavePasswordCommand, UserDataCommand, VmDataCommand will be synchronized on the agent side." Review comment: Good catch. I will fix that, and create a script to update the database. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2642: DB Exceptions seen on latest master
rhtyd commented on issue #2642: DB Exceptions seen on latest master URL: https://github.com/apache/cloudstack/issues/2642#issuecomment-430584281 On investigation, I found that this happens when cpu and memory counts are updated in a transaction where no update are performed i.e. old and new cpu/memory counts are the same. The log is seen because txn.commit() is called but txn itself is not started. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk edited a comment on issue #2862: VR stop/start/reboot commands failed
izenk edited a comment on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430556491 @rhtyd I tried to ping 169.254.0.1 from "Starting" VR At the same time, on the KVM host I ran `tcpdump -nn -i any icmp` an result is: ~~~ 11:23:43.492824 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:43.492843 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:43.492846 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:43.492849 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:44.493918 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:44.493936 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:44.493939 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:44.493942 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:45.495031 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 11:23:45.495056 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 11:23:45.495060 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 11:23:45.495063 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 ~~~ 10.9.2.206 is public IP(SNAT) on eth0 on "Starting" VR iptables does not have any lines related to 10.9.2.206 and even eth0 so, from my side it looks like a routing problem (taken into account that arping is wokring) https://user-images.githubusercontent.com/6417697/47081623-dc7a1500-d213-11e8-84d6-8b6996af9101.png;> This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk edited a comment on issue #2862: VR stop/start/reboot commands failed
izenk edited a comment on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430556491 @rhtyd I tried to ping 169.254.0.1 from "Starting" VR At the same time, on the KVM host I ran `tcpdump -nn -i any icmp` an result is: ~~~ 11:23:43.492824 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:43.492843 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:43.492846 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:43.492849 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:44.493918 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:44.493936 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:44.493939 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:44.493942 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:45.495031 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 11:23:45.495056 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 11:23:45.495060 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 11:23:45.495063 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 ~~~ 10.9.2.206 is public IP(SNAT) on eth0 on "Starting" VR iptables does not have any lines related to 10.9.2.206 and even eth0 so, from my side it looks like a routing problem (taken into account that arping is wokring) https://user-images.githubusercontent.com/6417697/47081578-b3f21b00-d213-11e8-81df-5e189d10fd66.png;> This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2900: network: Allow ability to disable rolling restart feature
rhtyd commented on issue #2900: network: Allow ability to disable rolling restart feature URL: https://github.com/apache/cloudstack/pull/2900#issuecomment-430576140 Ping @rafaelweingartner @nvasquez @PaulAngus can you review? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd edited a comment on issue #2900: network: Allow ability to disable rolling restart feature
rhtyd edited a comment on issue #2900: network: Allow ability to disable rolling restart feature URL: https://github.com/apache/cloudstack/pull/2900#issuecomment-430576140 Ping @rafaelweingartner @nvazquez @PaulAngus can you review? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk edited a comment on issue #2862: VR stop/start/reboot commands failed
izenk edited a comment on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430556491 @rhtyd I tried to ping 169.254.0.1 from "Starting" VR At the same time, on the KVM host I ran `tcpdump -nn -i any icmp` an result is: ~~~ 11:23:43.492824 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:43.492843 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:43.492846 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:43.492849 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:44.493918 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:44.493936 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:44.493939 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:44.493942 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:45.495031 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 11:23:45.495056 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 11:23:45.495060 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 11:23:45.495063 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 ~~~ 10.9.2.206 is public IP(SNAT) on eth0 on "Starting" VR iptables does not have any lines related to 10.9.2.206 and even eth0 so, from my side it looks like a routing problem (taken into account that arping is wokring) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk edited a comment on issue #2862: VR stop/start/reboot commands failed
izenk edited a comment on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430556491 I tried to ping 169.254.0.1 from "Starting" VR At the same time, on the KVM host I ran `tcpdump -nn -i any icmp` an result is: ~~~ 11:23:43.492824 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:43.492843 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:43.492846 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:43.492849 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:44.493918 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:44.493936 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:44.493939 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:44.493942 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:45.495031 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 11:23:45.495056 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 11:23:45.495060 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 11:23:45.495063 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 ~~~ 10.9.2.206 is public IP(SNAT) on eth0 on "Starting" VR iptables does not have any lines related to 10.9.2.206 and even eth0 so, from side it looks like a routing problem (taken into account that arping is wokring) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk edited a comment on issue #2862: VR stop/start/reboot commands failed
izenk edited a comment on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430556491 I tried to ping 169.254.0.1 from "Starting" VR At the same time, on the KVM host I ran `tcpdump -nn -i any icmp` an result is: ~~~ 11:23:43.492824 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:43.492843 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:43.492846 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:43.492849 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:44.493918 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:44.493936 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:44.493939 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:44.493942 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:45.495031 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 11:23:45.495056 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 11:23:45.495060 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 11:23:45.495063 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 ~~~ 10.9.2.206 is public IP(SNAT) on eth0 on "Starting" VR iptables does not have any lines related to 10.9.2.206 and even eth0 so, from my side it looks like a routing problem (taken into account that arping is wokring) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk edited a comment on issue #2862: VR stop/start/reboot commands failed
izenk edited a comment on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430556491 I tried to ping 169.254.0.1 from "Starting" VR AT the same time, on the KVM host I ran `tcpdump -nn -i any icmp` an result is: ~~~ 11:23:43.492824 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:43.492843 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:43.492846 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:43.492849 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 0, length 64 11:23:44.493918 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:44.493936 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:44.493939 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:44.493942 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 1, length 64 11:23:45.495031 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 11:23:45.495056 IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 11:23:45.495060 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 11:23:45.495063 ethertype IPv4, IP 10.9.2.206 > 169.254.0.1: ICMP echo request, id 1760, seq 2, length 64 ~~~ 10.9.2.206 is public IP(SNAT) on eth0 on "Starting" VR iptables does not have any lines related to 10.9.2.206 and even eth0 so, from side it looks like a routing problem (taken into account that arping is wokring) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk commented on issue #2862: VR stop/start/reboot commands failed
izenk commented on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430556491 I tried to ping 169.254.0.1 from "Starting" VR AT the same time, on the KVM host I ran `tcpdump -nn -i any icmp` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk edited a comment on issue #2862: VR stop/start/reboot commands failed
izenk edited a comment on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430549971 @rhtyd ok Im trying to debug issue myself. So may be some guidelines from your side.. When I click "Start" - VR starts boot. I can connect by VNC. On my installation VR (normally) has 4 interfaces: loopback eth0: linklocal (169.254.x.x) eth1: public net (10.9.x.x) eth2: vpc tier net (172.16.x.x) After connecting by VNC (while tested VR is in "Starting" state) I can see only 3 interafaces: loopback eth0: linklocal net is not working, I can **arping** 169.254.0.1 (what is on host(cloud0)) - so it's visible on link level, but can't **ping** 169.254.0.1 eth1: public net is working normally VR doesn't have vpc tier network at all. Note: Also I increased "router aggregation timeout" (router.aggregation.command.each.timeout) - what doesn't help. It seems even has no any effect: error about finalizing operation appeared after the same time as before increasing outer.aggregation.command.each.timeout. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk edited a comment on issue #2862: VR stop/start/reboot commands failed
izenk edited a comment on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430549971 @rhtyd ok Im trying to debug issue myself. So may be some guidelines from your side.. When I click "Start" - VR starts boot. I can connect by VNC. On my installation VR (normally) has 4 interfaces: loopback eth0: linklocal (169.254.x.x) eth1: public net (10.9.x.x) eth2: vpc tier net (172.16.x.x) After connecting by VNC (while tested VR is in "Starting" state) I can see only 3 interafaces: loopback eth0: linklocal net is not working, I can **arping** 169.254.0.1 (what is on host(cloud0)), but can't **ping** 169.254.0.1 eth1: public net is working normally VR doesn't have vpc tier network at all. Note: Also I increased "router aggregation timeout" (router.aggregation.command.each.timeout) - what doesn't help. It seems even has no any effect: error about finalizing operation appeared after the same time as before increasing outer.aggregation.command.each.timeout. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk edited a comment on issue #2862: VR stop/start/reboot commands failed
izenk edited a comment on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430549971 @rhtyd ok Im trying to debug issue myself. So may be some guidelines from your side.. When I click "Start" - VR starts boot. I can connect by VNC. On my installation VR (normally) has 4 interfaces: loopback eth0: linklocal (169.254.x.x) eth1: public net (10.9.x.x) eth2: vpc tier net (172.16.x.x) After connecting by VNC (while tested VR is in "Starting" state) I can see only 3 interafaces: loopback eth0: linklocal net is not working, I can **arping** 169.254.0.1 (what is on host(cloud0)), but can't **ping** 169.254.0.1 eth1: - public net is working normally Note: Also I increased "router aggregation timeout" (router.aggregation.command.each.timeout) - what doesn't help. It seems even has no any effect: error about finalizing operation appeared after the same time as before increasing outer.aggregation.command.each.timeout. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk edited a comment on issue #2862: VR stop/start/reboot commands failed
izenk edited a comment on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430549971 @rhtyd ok Im trying to debug issue myself. So may be some guidelines from your side.. When I click "Start" - VR starts boot. I can connect by VNC. On my installation VR (normally) has 4 interfaces: loopback eth0: linklocal (169.254.x.x) eth1: public net (10.9.x.x) eth2: vpc tier After connecting by VNC (while tested VR is in "Starting" state) I can see only 3 interafaces: loopback eth0: linklocal net is not working, I can **arping** 169.254.0.1 (what is on host(cloud0)), but can't **ping** 169.254.0.1 eth1: - public net is working normally Note: Also I increased "router aggregation timeout" (router.aggregation.command.each.timeout) - what doesn't help. It seems even has no any effect: error about finalizing operation appeared after the same time as before increasing outer.aggregation.command.each.timeout. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk commented on issue #2862: VR stop/start/reboot commands failed
izenk commented on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430549971 @rhtyd ok Im trying to debug issue myself. So may be some guidelines from your side.. When I click "Start" - VR starts boot. I can connect to it by VNC. On my installation VR (normally) has 4 interfaces: loopback eth0: linklocal (169) eth1: public net (10.9.x.x) eth2: vpc tier After connecting by VNC (while tested VR is in "Starting" state) I can see only 3 interafaces: loopback eth0: linklocal net is not working, I can **arping** 169.254.0.1 (what is on host(cloud0)), but can't **ping** 169.254.0.1 eth1: - public net is working normally Note: Also I increased "router aggregation timeout" (router.aggregation.command.each.timeout) - what doesn't help. It seems even has no any effect: error about finalizing operation appeared after the same time as before increasing outer.aggregation.command.each.timeout. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk edited a comment on issue #2862: VR stop/start/reboot commands failed
izenk edited a comment on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430549971 @rhtyd ok Im trying to debug issue myself. So may be some guidelines from your side.. When I click "Start" - VR starts boot. I can connect by VNC. On my installation VR (normally) has 4 interfaces: loopback eth0: linklocal (169) eth1: public net (10.9.x.x) eth2: vpc tier After connecting by VNC (while tested VR is in "Starting" state) I can see only 3 interafaces: loopback eth0: linklocal net is not working, I can **arping** 169.254.0.1 (what is on host(cloud0)), but can't **ping** 169.254.0.1 eth1: - public net is working normally Note: Also I increased "router aggregation timeout" (router.aggregation.command.each.timeout) - what doesn't help. It seems even has no any effect: error about finalizing operation appeared after the same time as before increasing outer.aggregation.command.each.timeout. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated (143fe53 -> e871638)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 143fe53 Allow enable the Java remote Debug for CloudStack Agent (#2897) add 1904a70 agent: on shutdown don't allow server reconnection (#2904) new e871638 Merge remote-tracking branch 'origin/4.11' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: agent/src/main/java/com/cloud/agent/Agent.java | 1 + 1 file changed, 1 insertion(+)
[GitHub] rhtyd closed issue #2899: Initial agent connect dropped by management server
rhtyd closed issue #2899: Initial agent connect dropped by management server URL: https://github.com/apache/cloudstack/issues/2899 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2899: Initial agent connect dropped by management server
rhtyd commented on issue #2899: Initial agent connect dropped by management server URL: https://github.com/apache/cloudstack/issues/2899#issuecomment-430528069 PR merged, closing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.11'
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit e871638dc83bde8372e00ce9e08b145f2411f2fc Merge: 143fe53 1904a70 Author: Rohit Yadav AuthorDate: Wed Oct 17 13:25:06 2018 +0530 Merge remote-tracking branch 'origin/4.11' agent/src/main/java/com/cloud/agent/Agent.java | 1 + 1 file changed, 1 insertion(+)
[GitHub] rhtyd commented on issue #2862: VR stop/start/reboot commands failed
rhtyd commented on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430527347 Given, you've a workaround for this issue and I could not reproduce this with latest 4.11 branch I'll move this to 4.11.3.0 milestone to avoid further blocking of rc3. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2869: Fix some Marvin smoke tests
rhtyd commented on a change in pull request #2869: Fix some Marvin smoke tests
URL: https://github.com/apache/cloudstack/pull/2869#discussion_r225804855
##
File path: test/integration/smoke/test_hostha_kvm.py
##
@@ -274,9 +274,12 @@ def test_hostha_enable_ha_when_host_in_maintenance(self):
Tests Enable HA when host is in Maintenance mode, should be
Ineligible
"""
self.logger.debug("Starting
test_hostha_enable_ha_when_host_in_maintenance")
-
+self.logger.debug("Pausing to wait for VMs to have finished starting")
+time.sleep(300)
Review comment:
Could be do a wait_until check here instead of sleep()?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2869: Fix some Marvin smoke tests
rhtyd commented on a change in pull request #2869: Fix some Marvin smoke tests URL: https://github.com/apache/cloudstack/pull/2869#discussion_r225804706 ## File path: test/integration/smoke/test_vm_life_cycle.py ## @@ -907,9 +907,10 @@ def unsecure_host(self, host): sed -i 's/listen_tcp.*/listen_tcp=1/g' /etc/libvirt/libvirtd.conf && \ sed -i '/.*_file=.*/d' /etc/libvirt/libvirtd.conf && \ service libvirtd restart && \ + sleep 30 && \ service cloudstack-agent restart") - -time.sleep(10) + +time.sleep(30) Review comment: Why do we need to sleep? Could be do a wait_until check here instead? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2869: Fix some Marvin smoke tests
rhtyd commented on a change in pull request #2869: Fix some Marvin smoke tests URL: https://github.com/apache/cloudstack/pull/2869#discussion_r225804562 ## File path: tools/marvin/marvin/lib/base.py ## @@ -605,22 +605,34 @@ def create(cls, apiclient, services, templateid=None, accountid=None, return VirtualMachine(virtual_machine.__dict__, services) # program ssh access over NAT via PF -if mode.lower() == 'advanced': -cls.access_ssh_over_nat( -apiclient, -services, -virtual_machine, -allow_egress=allow_egress, -networkid=cmd.networkids[0] if cmd.networkids else None) -elif mode.lower() == 'basic': -if virtual_machine.publicip is not None: -# EIP/ELB (netscaler) enabled zone -vm_ssh_ip = virtual_machine.publicip -else: -# regular basic zone with security group -vm_ssh_ip = virtual_machine.nic[0].ipaddress -virtual_machine.ssh_ip = vm_ssh_ip -virtual_machine.public_ip = vm_ssh_ip +retries = 5 +interval = 30 +while retries > 0: Review comment: Rewrite this using `wait_until`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2862: VR stop/start/reboot commands failed
rhtyd commented on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430517152 I could not reproduce the similar error with stop+start. However, with rebooting a VR I could see similar log statements, but ultimately the VR was able to start and I could not reproduce the error. There have been several VR related fixes in 4.11.2-rc2 compared to 4.11.1 so it's likely the bug is not reproducible. Please check and increase your router aggregation timeout and see if that helps? @izenk can you test against 4.11.2-rc2 using the latest 4.11.2 systemvmtemplate? See the voting thread on dev@ ML. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk edited a comment on issue #2862: VR stop/start/reboot commands failed
izenk edited a comment on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430510257 @rhtyd KVM with bridge based networking Advanced Zone without security groups During "Start" VR stucks in "Starting" state. If I connect to it through vnc I see, that public network is working (it has internet connection). VPC restart with "Clean up" option does the job. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk edited a comment on issue #2862: VR stop/start/reboot commands failed
izenk edited a comment on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430510257 @rhtyd KVM with bridge based networking Advanced Zone without security groups VPC restart with "Clean up" option does the job. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk commented on issue #2862: VR stop/start/reboot commands failed
izenk commented on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430510257 @rhtyd KVM with bridge based networking Advanced Zone without security groups This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
