[GitHub] wido commented on a change in pull request #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool
wido commented on a change in pull request #3077: ipv6: Calculate IPv6 address
instead of fetching one from a pool
URL: https://github.com/apache/cloudstack/pull/3077#discussion_r238531016
##
File path: server/src/main/java/com/cloud/network/guru/DirectNetworkGuru.java
##
@@ -367,9 +358,6 @@ public void doInTransactionWithoutResult(TransactionStatus
status) {
}
}
-if (nic.getIPv6Address() != null) {
-_ipv6Mgr.revokeDirectIpv6Address(nic.getNetworkId(),
nic.getIPv6Address());
Review comment:
@rhtyd In the IPv4 world we would have a pool of addresses which we would
use. These would need to be Allocated and Free'd again once no longer in use.
With IPv6 and SLAAC the Instance generates a IPv6 address based on it's MAC
address.
Therefor we do not have a pool of IPs which we need to keep on the
Management Server side. We just generate the EUI-64 address based on the
subnet+mac and store that at the NIC.
If we clear the NIC the address is 'Free' again, but any new Instance will
have a new MAC and thus a new IP.
SLAAC: https://howdoesinternetwork.com/2013/slaac
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] andrijapanic edited a comment on issue #2820: template downloading fails
andrijapanic edited a comment on issue #2820: template downloading fails URL: https://github.com/apache/cloudstack/issues/2820#issuecomment-443873085 I seems to NOT have issues with qcow2 template (~14GB realistic size (du -hs), though image is 100GB). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] andrijapanic commented on issue #2820: template downloading fails
andrijapanic commented on issue #2820: template downloading fails URL: https://github.com/apache/cloudstack/issues/2820#issuecomment-443873085 I seems to NOT have issues with qcow2 template (~50GB realistic size (du -hs), though image is 100GB). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool
blueorangutan commented on issue #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool URL: https://github.com/apache/cloudstack/pull/3077#issuecomment-443858513 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool
rhtyd commented on issue #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool URL: https://github.com/apache/cloudstack/pull/3077#issuecomment-443858415 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool
blueorangutan commented on issue #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool URL: https://github.com/apache/cloudstack/pull/3077#issuecomment-443855456 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2481 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on a change in pull request #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool
rhtyd commented on a change in pull request #3077: ipv6: Calculate IPv6 address
instead of fetching one from a pool
URL: https://github.com/apache/cloudstack/pull/3077#discussion_r238416289
##
File path: server/src/main/java/com/cloud/network/guru/DirectNetworkGuru.java
##
@@ -367,9 +358,6 @@ public void doInTransactionWithoutResult(TransactionStatus
status) {
}
}
-if (nic.getIPv6Address() != null) {
-_ipv6Mgr.revokeDirectIpv6Address(nic.getNetworkId(),
nic.getIPv6Address());
Review comment:
@wido I did not understand this part, who would revoke ipv6 address? Or is
the assumption that it is not needed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] blueorangutan commented on issue #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool
blueorangutan commented on issue #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool URL: https://github.com/apache/cloudstack/pull/3077#issuecomment-443849367 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch 4.11 updated: security: increase keystore setup/import timeout (#3076)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.11 by this push:
new 89c567a security: increase keystore setup/import timeout (#3076)
89c567a is described below
commit 89c567add8486ada7528dd7cb2482d7ea43b0d45
Author: Rohit Yadav
AuthorDate: Tue Dec 4 01:28:24 2018 +0530
security: increase keystore setup/import timeout (#3076)
This increases and uses a default 15mins timeout for VR scripts and for
KVM agent increases timeout from 60s to 5mins. The timeout can
specifically occur when keystore does not get enough entropy from CPU
and script gets killed due to timeout. This is a very specific corner
case and generally should not happen on baremetal/prod environment, but
sometimes seen in nested/test environments.
Signed-off-by: Rohit Yadav
---
agent/src/com/cloud/agent/Agent.java | 4 ++--
.../cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/agent/src/com/cloud/agent/Agent.java
b/agent/src/com/cloud/agent/Agent.java
index f1f2116..df0448d 100644
--- a/agent/src/com/cloud/agent/Agent.java
+++ b/agent/src/com/cloud/agent/Agent.java
@@ -729,7 +729,7 @@ public class Agent implements HandlerFactory, IAgentControl
{
_shell.setPersistentProperty(null,
KeyStoreUtils.KS_PASSPHRASE_PROPERTY, storedPassword);
}
-Script script = new Script(_keystoreSetupPath, 6, s_logger);
+Script script = new Script(_keystoreSetupPath, 30, s_logger);
script.add(agentFile.getAbsolutePath());
script.add(keyStoreFile);
script.add(storedPassword);
@@ -773,7 +773,7 @@ public class Agent implements HandlerFactory, IAgentControl
{
throw new CloudRuntimeException("Unable to save received agent
client and ca certificates", e);
}
-Script script = new Script(_keystoreCertImportPath, 6, s_logger);
+Script script = new Script(_keystoreCertImportPath, 30, s_logger);
script.add(agentFile.getAbsolutePath());
script.add(keyStoreFile);
script.add(KeyStoreUtils.AGENT_MODE);
diff --git
a/core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
b/core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
index 0ffe8cc..1367218 100644
---
a/core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
+++
b/core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
@@ -161,7 +161,7 @@ public class VirtualRoutingResource {
cmd.getKeystorePassword(),
cmd.getValidityDays(),
KeyStoreUtils.CSR_FILENAME);
-ExecutionResult result =
_vrDeployer.executeInVR(cmd.getRouterAccessIp(), KeyStoreUtils.KS_SETUP_SCRIPT,
args);
+ExecutionResult result =
_vrDeployer.executeInVR(cmd.getRouterAccessIp(), KeyStoreUtils.KS_SETUP_SCRIPT,
args, Duration.standardMinutes(15));
return new SetupKeystoreAnswer(result.getDetails());
}
@@ -179,7 +179,7 @@ public class VirtualRoutingResource {
cmd.getEncodedCaCertificates(),
KeyStoreUtils.PKEY_FILENAME,
cmd.getEncodedPrivateKey());
-ExecutionResult result =
_vrDeployer.executeInVR(cmd.getRouterAccessIp(),
KeyStoreUtils.KS_IMPORT_SCRIPT, args);
+ExecutionResult result =
_vrDeployer.executeInVR(cmd.getRouterAccessIp(),
KeyStoreUtils.KS_IMPORT_SCRIPT, args, Duration.standardMinutes(15));
return new SetupCertificateAnswer(result.isSuccess());
}
[GitHub] rhtyd commented on issue #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool
rhtyd commented on issue #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool URL: https://github.com/apache/cloudstack/pull/3077#issuecomment-443849058 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd closed pull request #3076: security: increase keystore setup/import timeout
rhtyd closed pull request #3076: security: increase keystore setup/import
timeout
URL: https://github.com/apache/cloudstack/pull/3076
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/agent/src/com/cloud/agent/Agent.java
b/agent/src/com/cloud/agent/Agent.java
index f1f2116ffae..df0448dab22 100644
--- a/agent/src/com/cloud/agent/Agent.java
+++ b/agent/src/com/cloud/agent/Agent.java
@@ -729,7 +729,7 @@ public Answer setupAgentKeystore(final SetupKeyStoreCommand
cmd) {
_shell.setPersistentProperty(null,
KeyStoreUtils.KS_PASSPHRASE_PROPERTY, storedPassword);
}
-Script script = new Script(_keystoreSetupPath, 6, s_logger);
+Script script = new Script(_keystoreSetupPath, 30, s_logger);
script.add(agentFile.getAbsolutePath());
script.add(keyStoreFile);
script.add(storedPassword);
@@ -773,7 +773,7 @@ private Answer setupAgentCertificate(final
SetupCertificateCommand cmd) {
throw new CloudRuntimeException("Unable to save received agent
client and ca certificates", e);
}
-Script script = new Script(_keystoreCertImportPath, 6, s_logger);
+Script script = new Script(_keystoreCertImportPath, 30, s_logger);
script.add(agentFile.getAbsolutePath());
script.add(keyStoreFile);
script.add(KeyStoreUtils.AGENT_MODE);
diff --git
a/core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
b/core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
index 0ffe8cc0ea2..13672186653 100644
---
a/core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
+++
b/core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
@@ -161,7 +161,7 @@ private Answer execute(final SetupKeyStoreCommand cmd) {
cmd.getKeystorePassword(),
cmd.getValidityDays(),
KeyStoreUtils.CSR_FILENAME);
-ExecutionResult result =
_vrDeployer.executeInVR(cmd.getRouterAccessIp(), KeyStoreUtils.KS_SETUP_SCRIPT,
args);
+ExecutionResult result =
_vrDeployer.executeInVR(cmd.getRouterAccessIp(), KeyStoreUtils.KS_SETUP_SCRIPT,
args, Duration.standardMinutes(15));
return new SetupKeystoreAnswer(result.getDetails());
}
@@ -179,7 +179,7 @@ private Answer execute(final SetupCertificateCommand cmd) {
cmd.getEncodedCaCertificates(),
KeyStoreUtils.PKEY_FILENAME,
cmd.getEncodedPrivateKey());
-ExecutionResult result =
_vrDeployer.executeInVR(cmd.getRouterAccessIp(),
KeyStoreUtils.KS_IMPORT_SCRIPT, args);
+ExecutionResult result =
_vrDeployer.executeInVR(cmd.getRouterAccessIp(),
KeyStoreUtils.KS_IMPORT_SCRIPT, args, Duration.standardMinutes(15));
return new SetupCertificateAnswer(result.isSuccess());
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rhtyd commented on issue #3076: security: increase keystore setup/import timeout
rhtyd commented on issue #3076: security: increase keystore setup/import timeout URL: https://github.com/apache/cloudstack/pull/3076#issuecomment-443848866 @nvazquez yes they can be made configurable, however it may make it slightly complex on how we propagate the settings in case of KVM agent and in case of systemvm (cpvm/ssvm). I've used a very high number to be on safe side, generally they should complete within 60s. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #3076: security: increase keystore setup/import timeout
blueorangutan commented on issue #3076: security: increase keystore setup/import timeout URL: https://github.com/apache/cloudstack/pull/3076#issuecomment-443845540 Trillian test result (tid-3244) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 20678 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3076-t3244-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 68 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wido opened a new pull request #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool
wido opened a new pull request #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool URL: https://github.com/apache/cloudstack/pull/3077 ## Description With IPv6 we are not using DHCP to allocate addresses, but using StateLess Address Auto Configuration (SLAAC) a Instance will calculate it's own address based on the Router Advertisements send out by the routers in the network. This Advertisement contains the IPv6 Subnet in use in that subnet and allows to calculate the stable Address the Instance will obtain based on it's MAC Address. The existing code is 'dead code' as it has been written, but was never used by any production code. SLAAC only works properly with subnets of exactly 64-bits large. ## Types of changes - [ ] Enhancement (improves an existing feature and functionality) ## Screenshots (if appropriate):   ## How Has This Been Tested? On a CloudStack test setup running from master (4.12) and trying manually. The zone is running with Advanced Networking and Guest Networks have been provided a IPv6 64-bits subnet: - Advanced Networking - Shared VXLAN network - Ubuntu 18.04 hypervisors UnitTesting has also been added to check that the code calculates the IPv6 Address as it should. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] svenvogel edited a comment on issue #3069: Update jquery and related libraries
svenvogel edited a comment on issue #3069: Update jquery and related libraries URL: https://github.com/apache/cloudstack/pull/3069#issuecomment-443718985 @rafaelweingartner @GabrielBrascher @borisstoyanov can you check? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] svenvogel removed a comment on issue #3069: Update jquery and related libraries
svenvogel removed a comment on issue #3069: Update jquery and related libraries URL: https://github.com/apache/cloudstack/pull/3069#issuecomment-443719209 @GabrielBrascher can you review too? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] svenvogel commented on issue #3069: Update jquery and related libraries
svenvogel commented on issue #3069: Update jquery and related libraries URL: https://github.com/apache/cloudstack/pull/3069#issuecomment-443719209 @GabrielBrascher can you review too? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] svenvogel commented on issue #3069: Update jquery and related libraries
svenvogel commented on issue #3069: Update jquery and related libraries URL: https://github.com/apache/cloudstack/pull/3069#issuecomment-443718985 @rafaelweingartner can you check? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #3076: security: increase keystore setup/import timeout
blueorangutan commented on issue #3076: security: increase keystore setup/import timeout URL: https://github.com/apache/cloudstack/pull/3076#issuecomment-443713608 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #3076: security: increase keystore setup/import timeout
rhtyd commented on issue #3076: security: increase keystore setup/import timeout URL: https://github.com/apache/cloudstack/pull/3076#issuecomment-443713292 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #3076: security: increase keystore setup/import timeout
blueorangutan commented on issue #3076: security: increase keystore setup/import timeout URL: https://github.com/apache/cloudstack/pull/3076#issuecomment-443705552 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2480 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #3070: kvm: Refactory VXLAN script and add IPv6 support
blueorangutan commented on issue #3070: kvm: Refactory VXLAN script and add IPv6 support URL: https://github.com/apache/cloudstack/pull/3070#issuecomment-443702153 Trillian test result (tid-3243) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 23490 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3070-t3243-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 68 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_nic_secondaryip_add_remove | `Error` | 30.25 | test_multipleips_per_nic.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 496.29 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #3076: security: increase keystore setup/import timeout
blueorangutan commented on issue #3076: security: increase keystore setup/import timeout URL: https://github.com/apache/cloudstack/pull/3076#issuecomment-443700431 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #3076: security: increase keystore setup/import timeout
rhtyd commented on issue #3076: security: increase keystore setup/import timeout URL: https://github.com/apache/cloudstack/pull/3076#issuecomment-443700348 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd opened a new pull request #3076: security: increase keystore setup/import timeout
rhtyd opened a new pull request #3076: security: increase keystore setup/import timeout URL: https://github.com/apache/cloudstack/pull/3076 This increases and uses a default 15mins timeout for VR scripts and for KVM agent increases timeout from 60s to 5mins. The timeout can specifically occur when keystore does not get enough entropy from CPU and script gets killed due to timeout. This is a very specific corner case and generally should not happen on baremetal/prod environment, but sometimes seen in nested/test environments. /cc @PaulAngus @DagSonstebo ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack-cloudmonkey] branch master updated: network: remove nested quotes in parameters
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git
The following commit(s) were added to refs/heads/master by this push:
new f3e0992 network: remove nested quotes in parameters
f3e0992 is described below
commit f3e09928f940bd2d17283f117bc61eef272670ea
Author: Rohit Yadav
AuthorDate: Mon Dec 3 17:21:07 2018 +0530
network: remove nested quotes in parameters
Signed-off-by: Rohit Yadav
---
cmd/network.go | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/cmd/network.go b/cmd/network.go
index e02c11b..3ab1358 100644
--- a/cmd/network.go
+++ b/cmd/network.go
@@ -169,7 +169,12 @@ func NewAPIRequest(r *Request, api string, args []string,
isAsync bool) (map[str
for _, arg := range args {
parts := strings.SplitN(arg, "=", 2)
if len(parts) == 2 {
- params.Add(parts[0], parts[1])
+ key := parts[0]
+ value := parts[1]
+ if strings.HasPrefix(value, "\"") &&
strings.HasSuffix(value, "\"") {
+ value = value[1 : len(value)-1]
+ }
+ params.Add(key, value)
}
}
params.Add("response", "json")
[GitHub] blueorangutan commented on issue #2848: Vmware offline migration
blueorangutan commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-443679625 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2479 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2848: Vmware offline migration
blueorangutan commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-443670693 @dhlaluku a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dhlaluku commented on issue #2848: Vmware offline migration
dhlaluku commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-443670650 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] onitake commented on issue #3039: VMware 4.11.2.0 system VMs memory consumption grows overtime until heavy swapping occurs
onitake commented on issue #3039: VMware 4.11.2.0 system VMs memory consumption grows overtime until heavy swapping occurs URL: https://github.com/apache/cloudstack/issues/3039#issuecomment-443666312 Hi @rhtyd @PaulAngus - thanks for taking on this issue. If you have any suggestions on more tests we could run, please share. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wido commented on issue #3070: kvm: Refactory VXLAN script and add IPv6 support
wido commented on issue #3070: kvm: Refactory VXLAN script and add IPv6 support URL: https://github.com/apache/cloudstack/pull/3070#issuecomment-443642615 A manual test of this script: Create a VXLAN device and a bridge. root@n01:~# /usr/share/cloudstack-common/scripts/vm/network/vnet/modifyvxlan.sh -v 3000 -p cloudbr0 -b brvx-3000 -o add multicast 239.0.11.184 for VNI 3000 on cloudbr0 vxlan: destination port not specified Will use Linux kernel default (non-standard value) Use 'dstport 4789' to get the IANA assigned value Use 'dstport 0' to get default and quiet this message root@n01:~# ip link show dev vxlan3000 182: vxlan3000: mtu 8950 qdisc noqueue master brvx-3000 state UNKNOWN mode DEFAULT group default qlen 1000 link/ether 76:e4:c1:bb:73:5c brd ff:ff:ff:ff:ff:ff root@n01:~# bridge link show|grep brvx-3000 182: vxlan3000 state UNKNOWN : mtu 8950 master brvx-3000 state forwarding priority 32 cost 100 root@n01:~# Delete the interfaces again root@n01:~# /usr/share/cloudstack-common/scripts/vm/network/vnet/modifyvxlan.sh -v 3000 -p cloudbr0 -b brvx-3000 -o delete root@n01:~# This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
