[GitHub] [cloudstack] blueorangutan commented on issue #3238: client: don't disable TLSv1, TLSv1.1 by default that breaks VMware env
blueorangutan commented on issue #3238: client: don't disable TLSv1, TLSv1.1 by default that breaks VMware env URL: https://github.com/apache/cloudstack/pull/3238#issuecomment-476904473 Trillian test result (tid-3446) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34232 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3238-t3446-vmware-55u3.zip Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py Smoke tests completed. 68 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez opened a new pull request #3239: KVM: Fix agents dont reconnect post maintenance
nvazquez opened a new pull request #3239: KVM: Fix agents dont reconnect post maintenance URL: https://github.com/apache/cloudstack/pull/3239 ## Description Before this fix, there were two possible scenarios when cancelling maintenance/prepare for maintenance on a KVM host: - If global setting 'kvm.ssh.to.agent' = true, then the management server performed SSH into the host and restarted the CloudStack agent service. - If global setting 'kvm.ssh.to.agent' = false, then the management server required that the CloudStack agent service on the host was restarted manually, for the host to become operational again. Restart was to establish a new connection between management server and the host agent, as it was closed after the host is notified to be put into maintenance After cancelling maintenance on one-time SSH password hosts, hosts did not reconnect and were not operational unless a manual restart on the CloudStack agent service was performed. This feature keeps the connection between management server and host agent alive while preparing for maintenance and when on maintenance. This imples that: - Host agent is connected during maintenance period unless it is stopped - If the host or the agent are restarted during maintenance period, a new connection will be established between the agent and the management server. - If a host agent is connected to the management server when cancelling maintenance, then the current connection is kept alive regardless the value of the global setting 'kvm.ssh.to.agent' - If a host agent is disconnected when cancelling maintenance: - If 'kvm.ssh.to.agent' = true, then the management server restarts the agent service via SSH into the host - If 'kvm.ssh.to.agent' = false, then an error is thrown indicating that the agent must be connected to the management server. ### Summary - When an admin cancels maintenance mode on a KVM host: - If 'kvm.ssh.to.agent' = false and the agent is connected then maintenance mode is cancelled, then maintenance mode is cancelled. - If 'kvm.ssh.to.agent' = true and the agent is connected, then maintenance mode is cancelled. - If 'kvm.ssh.to.agent' = true and the angent is not connected, then the management server will attempt to SSH into the host and restart the agent. If the agent connects, then maintenance mode is cancelled. If the agent still does not connect then maintenance mode fails to be cancelled and a suitable message is returned. - If 'kvm.ssh.to.agent' = false and the agent is not connected, then maintenance mode fails to be cancelled and a suitable message is returned - A host must be able to exit maintenance under the following circumstances: - Host agent has remained online throughout the maintenance period - Host agent has been restarted after host went into maintenance - KVM host has been fully restarted during the maintenance period - A host in maintenance mode and with agent connected must be shown to remain connected to CloudStack management whilst rejecting all CloudStack operations (new internal agent state = hostInMaintenance) - Hosts in which SSH is allowed (kvm.ssh.to.agent = true) must be able to still exit maintenance mode regardless of whether the host or agent have been restarted during the maintenance period. (i.e. no regressions to existing functionality) - Hosts in maintenance mode which have either or both the host itself or the host agent restarted should be reconnected to management server with the management server agent in the new internal hostInMaintenance state ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? Tested on 2xKVM hosts environment, NFS primary and secondary storage, changing values of the global setting 'kvm.ssh.to.agent' for each case to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] falcon78921 commented on a change in pull request #3174: scripts/network/ping: cleaned up code in baremetal_user_data.py
falcon78921 commented on a change in pull request #3174: scripts/network/ping: cleaned up code in baremetal_user_data.py URL: https://github.com/apache/cloudstack/pull/3174#discussion_r269299045 ## File path: scripts/network/ping/baremetal_user_data.py ## @@ -15,82 +17,75 @@ # specific language governing permissions and limitations # under the License. -''' -Created on Jul 2, 2012 +# Created on Jul 2, 2012 +# @author: frank Review comment: @rhtyd Those author comments were there previously. They're now gone :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: schema: add empty DB upgrade path from 4.12.0.0 to 4.13.0.0 (#3236)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new 671a70a schema: add empty DB upgrade path from 4.12.0.0 to 4.13.0.0
(#3236)
671a70a is described below
commit 671a70a9a5f2de0cccb81b6af6c7b27fa03dd536
Author: Rohit Yadav
AuthorDate: Wed Mar 27 00:00:47 2019 +0530
schema: add empty DB upgrade path from 4.12.0.0 to 4.13.0.0 (#3236)
This adds empty empty upgrade path from 4.12.0.0 to 4.13.0.0.
Signed-off-by: Rohit Yadav
---
.../com/cloud/upgrade/DatabaseUpgradeChecker.java | 2 +
.../com/cloud/upgrade/dao/Upgrade41200to41300.java | 72 ++
.../META-INF/db/schema-41200to41300-cleanup.sql| 21 +++
.../resources/META-INF/db/schema-41200to41300.sql | 21 +++
4 files changed, 116 insertions(+)
diff --git
a/engine/schema/src/main/java/com/cloud/upgrade/DatabaseUpgradeChecker.java
b/engine/schema/src/main/java/com/cloud/upgrade/DatabaseUpgradeChecker.java
index 6da40fb..fbb1399 100644
--- a/engine/schema/src/main/java/com/cloud/upgrade/DatabaseUpgradeChecker.java
+++ b/engine/schema/src/main/java/com/cloud/upgrade/DatabaseUpgradeChecker.java
@@ -64,6 +64,7 @@ import com.cloud.upgrade.dao.Upgrade410to420;
import com.cloud.upgrade.dao.Upgrade41100to41110;
import com.cloud.upgrade.dao.Upgrade41110to41120;
import com.cloud.upgrade.dao.Upgrade41120to41200;
+import com.cloud.upgrade.dao.Upgrade41200to41300;
import com.cloud.upgrade.dao.Upgrade420to421;
import com.cloud.upgrade.dao.Upgrade421to430;
import com.cloud.upgrade.dao.Upgrade430to440;
@@ -183,6 +184,7 @@ public class DatabaseUpgradeChecker implements
SystemIntegrityChecker {
.next("4.11.0.0", new Upgrade41100to41110())
.next("4.11.1.0", new Upgrade41110to41120())
.next("4.11.2.0", new Upgrade41120to41200())
+.next("4.12.0.0", new Upgrade41200to41300())
.build();
}
diff --git
a/engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41200to41300.java
b/engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41200to41300.java
new file mode 100644
index 000..f7e968c
--- /dev/null
+++ b/engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41200to41300.java
@@ -0,0 +1,72 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package com.cloud.upgrade.dao;
+
+import java.io.InputStream;
+import java.sql.Connection;
+
+import org.apache.log4j.Logger;
+
+import com.cloud.utils.exception.CloudRuntimeException;
+
+public class Upgrade41200to41300 implements DbUpgrade {
+
+final static Logger LOG = Logger.getLogger(Upgrade41200to41300.class);
+
+@Override
+public String[] getUpgradableVersionRange() {
+return new String[] {"4.12.0.0", "4.13.0.0"};
+}
+
+@Override
+public String getUpgradedVersion() {
+return "4.13.0.0";
+}
+
+@Override
+public boolean supportsRollingUpgrade() {
+return false;
+}
+
+@Override
+public InputStream[] getPrepareScripts() {
+final String scriptFile = "META-INF/db/schema-41200to41300.sql";
+final InputStream script =
Thread.currentThread().getContextClassLoader().getResourceAsStream(scriptFile);
+if (script == null) {
+throw new CloudRuntimeException("Unable to find " + scriptFile);
+}
+
+return new InputStream[] {script};
+}
+
+@Override
+public void performDataMigration(Connection conn) {
+
+}
+
+@Override
+public InputStream[] getCleanupScripts() {
+final String scriptFile =
"META-INF/db/schema-41200to41300-cleanup.sql";
+final InputStream script =
Thread.currentThread().getContextClassLoader().getResourceAsStream(scriptFile);
+if (script == null) {
+throw new CloudRuntimeException("Unable to find " + scriptFile);
+}
+
+return new InputStream[] {script};
+}
+}
diff --git
a/engine/schema/src/main/resources/META-INF/db/schema-41200to41300-cleanup.sql
[GitHub] [cloudstack] rhtyd merged pull request #3236: schema: add empty DB upgrade path from 4.12.0.0 to 4.13.0.0
rhtyd merged pull request #3236: schema: add empty DB upgrade path from 4.12.0.0 to 4.13.0.0 URL: https://github.com/apache/cloudstack/pull/3236 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3236: schema: add empty DB upgrade path from 4.12.0.0 to 4.13.0.0
blueorangutan commented on issue #3236: schema: add empty DB upgrade path from 4.12.0.0 to 4.13.0.0 URL: https://github.com/apache/cloudstack/pull/3236#issuecomment-476784900 Trillian test result (tid-3445) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 23928 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3236-t3445-kvm-centos7.zip Smoke tests completed. 70 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack-documentation] annotated tag 4.12.0.0 updated (15ead30 -> 951299e)
This is an automated email from the ASF dual-hosted git repository. paul_a pushed a change to annotated tag 4.12.0.0 in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. *** WARNING: tag 4.12.0.0 was modified! *** from 15ead30 (commit) to 951299e (tag) tagging 15ead30eafbfe6d3826eeaa758f617f768f5d14c (commit) replaces 4.11.1.0 by PaulAngus on Tue Mar 26 15:24:56 2019 + - Log - --- No new revisions were added by this update. Summary of changes:
[cloudstack-documentation] branch 4.12 created (now 61a6e15)
This is an automated email from the ASF dual-hosted git repository. paul_a pushed a change to branch 4.12 in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. at 61a6e15 qig: fix libvirt port (#32) No new revisions were added by this update.
[cloudstack-documentation] branch 4.12 updated: initial update for create 4.12 with updated global values
This is an automated email from the ASF dual-hosted git repository. paul_a pushed a commit to branch 4.12 in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git The following commit(s) were added to refs/heads/4.12 by this push: new 15ead30 initial update for create 4.12 with updated global values 15ead30 is described below commit 15ead30eafbfe6d3826eeaa758f617f768f5d14c Author: PaulAngus AuthorDate: Tue Mar 26 15:23:06 2019 + initial update for create 4.12 with updated global values --- source/conf.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source/conf.py b/source/conf.py index 0fbfe0d..48562e3 100644 --- a/source/conf.py +++ b/source/conf.py @@ -24,9 +24,9 @@ copyright = '2018, Apache Foundation' author = 'Apache CloudStack Project' # The short X.Y version -version = '4.11' +version = '4.12' # The full version, including alpha/beta/rc tags -release = '4.11.2.0' +release = '4.12.0.0' rst_epilog = """ .. include:: /_global.rst
[GitHub] [cloudstack] 1605200517 edited a comment on issue #3237: Allow a global CIDR list source managed by third party
1605200517 edited a comment on issue #3237: Allow a global CIDR list source managed by third party URL: https://github.com/apache/cloudstack/issues/3237#issuecomment-476635128 @bwsw then I'd still need to sync data between firewall and CS taking also access rights in account. This CS feature would enable users to manage firewalling of their accounts themselves and being independent from currently used firewall product (which can still then apply additional global protection logic). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3238: client: don't disable TLSv1, TLSv1.1 by default that breaks VMware env
blueorangutan commented on issue #3238: client: don't disable TLSv1, TLSv1.1 by default that breaks VMware env URL: https://github.com/apache/cloudstack/pull/3238#issuecomment-476663006 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3238: client: don't disable TLSv1, TLSv1.1 by default that breaks VMware env
rhtyd commented on issue #3238: client: don't disable TLSv1, TLSv1.1 by default that breaks VMware env URL: https://github.com/apache/cloudstack/pull/3238#issuecomment-476662854 @blueorangutan test centos7 vmware-55u3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] 1605200517 commented on issue #3237: Allow a global CIDR list source managed by third party
1605200517 commented on issue #3237: Allow a global CIDR list source managed by third party URL: https://github.com/apache/cloudstack/issues/3237#issuecomment-476635128 @bwsw then I'd still need to sync data between firewall and CS taking also access rights. Having this CS feature, users can manage firewalling of their accounts themselves and being independent from currently used firewall product (which can still then apply additional protection logic). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3238: client: don't disable TLSv1, TLSv1.1 by default that breaks VMware env
blueorangutan commented on issue #3238: client: don't disable TLSv1, TLSv1.1 by default that breaks VMware env URL: https://github.com/apache/cloudstack/pull/3238#issuecomment-476624491 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2648 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr commented on a change in pull request #3228: api: snapshot, snapshotpolicy tag support
shwstppr commented on a change in pull request #3228: api: snapshot, snapshotpolicy tag support URL: https://github.com/apache/cloudstack/pull/3228#discussion_r269085548 ## File path: api/src/test/java/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotPolicyCmdTest.java ## @@ -0,0 +1,30 @@ +package org.apache.cloudstack.api.command.user.snapshot; Review comment: @DaanHoogland added license This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3238: client: don't disable TLSv1, TLSv1.1 by default that breaks VMware env
blueorangutan commented on issue #3238: client: don't disable TLSv1, TLSv1.1 by default that breaks VMware env URL: https://github.com/apache/cloudstack/pull/3238#issuecomment-476612339 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3238: client: don't disable TLSv1, TLSv1.1 by default that breaks VMware env
rhtyd commented on issue #3238: client: don't disable TLSv1, TLSv1.1 by default that breaks VMware env URL: https://github.com/apache/cloudstack/pull/3238#issuecomment-476612037 Without this fix, by default the env deployment fails for older versions of VMware such as 5.5 and 6.0 (less than up3). @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd opened a new pull request #3238: client: don't disable TLSv1, TLSv1.1 by default that breaks VMware env
rhtyd opened a new pull request #3238: client: don't disable TLSv1, TLSv1.1 by default that breaks VMware env URL: https://github.com/apache/cloudstack/pull/3238 This fixes the issue that TLSv1 and TLSv1.1 are still used by CloudStack management server to communicate with VMware vCenter server. With the current defaults, the setup/deployment on VMware fails. Users/admins can however setup the security file according to their env needs to disable TLSv1 and TLSv1.1 for server sockets (8250/agent service for example). ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3218: vmware: don't use redundant worker VM to extract volume
DaanHoogland commented on a change in pull request #3218: vmware: don't use
redundant worker VM to extract volume
URL: https://github.com/apache/cloudstack/pull/3218#discussion_r269081602
##
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
##
@@ -999,15 +1000,18 @@ private String getVolumePathInDatastore(DatastoreMO
dsMo, String volumeFileName,
String datastoreVolumePath = getVolumePathInDatastore(dsMo,
volumePath + ".vmdk", searchExcludedFolders);
workerVm.attachDisk(new String[] {datastoreVolumePath}, morDs);
vmMo = workerVm;
+clonedWorkerVMNeeded = false;
+} else {
+vmMo.createSnapshot(exportName, "Temporary snapshot for
copy-volume command", false, false);
}
-vmMo.createSnapshot(exportName, "Temporary snapshot for
copy-volume command", false, false);
-
-exportVolumeToSecondaryStroage(vmMo, volumePath, secStorageUrl,
destVolumePath, exportName, hostService.getWorkerName(hyperHost.getContext(),
cmd, 1), _nfsVersion);
+exportVolumeToSecondaryStorage(vmMo, volumePath, secStorageUrl,
destVolumePath, exportName, hostService.getWorkerName(hyperHost.getContext(),
cmd, 1), _nfsVersion, clonedWorkerVMNeeded);
return new Pair<>(destVolumePath, exportName);
} finally {
-vmMo.removeSnapshot(exportName, false);
+if (vmMo != null && vmMo.getSnapshotMor(exportName) != null) {
+vmMo.removeSnapshot(exportName, false);
+}
if (workerVm != null) {
Review comment:
same here as in VmwareStorageManagerImpl.java#1020; if we move
clonedWorkerVMNeeded outside the try block we don't need this extra workerVm
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3218: vmware: don't use redundant worker VM to extract volume
DaanHoogland commented on a change in pull request #3218: vmware: don't use
redundant worker VM to extract volume
URL: https://github.com/apache/cloudstack/pull/3218#discussion_r269078559
##
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
##
@@ -961,16 +961,19 @@ private void
exportVolumeToSecondaryStroage(VirtualMachineMO vmMo, String volume
throw new Exception(msg);
}
-// 4 MB is the minimum requirement for VM memory in VMware
-vmMo.cloneFromCurrentSnapshot(workerVmName, 0, 4,
volumeDeviceInfo.second(),
VmwareHelper.getDiskDeviceDatastore(volumeDeviceInfo.first()));
-clonedVm = vmMo.getRunningHost().findVmOnHyperHost(workerVmName);
-if (clonedVm == null) {
-String msg = "Unable to create dummy VM to export volume.
volume path: " + volumePath;
-s_logger.error(msg);
-throw new Exception(msg);
+if (clonedWorkerVMNeeded) {
+// 4 MB is the minimum requirement for VM memory in VMware
+vmMo.cloneFromCurrentSnapshot(workerVmName, 0, 4,
volumeDeviceInfo.second(),
VmwareHelper.getDiskDeviceDatastore(volumeDeviceInfo.first()));
+clonedVm =
vmMo.getRunningHost().findVmOnHyperHost(workerVmName);
+if (clonedVm == null) {
+String msg = "Unable to create dummy VM to export volume.
volume path: " + volumePath;
+s_logger.error(msg);
+throw new Exception(msg);
+}
+clonedVm.exportVm(exportPath, exportName, false, false);
//Note: volss: not to create ova.
Review comment:
how about unifying both calls by assigning the clonedVm or vmMo to a local
var, so it is obvious where the real work is done in both cases?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3218: vmware: don't use redundant worker VM to extract volume
DaanHoogland commented on a change in pull request #3218: vmware: don't use
redundant worker VM to extract volume
URL: https://github.com/apache/cloudstack/pull/3218#discussion_r269079974
##
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
##
@@ -1014,16 +1018,19 @@ private void
exportVolumeToSecondaryStroage(VirtualMachineMO vmMo, String volume
String datastoreVolumePath = getVolumePathInDatastore(dsMo,
volumePath + ".vmdk", searchExcludedFolders);
workerVm.attachDisk(new String[] {datastoreVolumePath}, morDs);
vmMo = workerVm;
Review comment:
if we move clonedWorkerVMNeeded outside the try workerVm is not needed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3218: vmware: don't use redundant worker VM to extract volume
DaanHoogland commented on a change in pull request #3218: vmware: don't use
redundant worker VM to extract volume
URL: https://github.com/apache/cloudstack/pull/3218#discussion_r269082177
##
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
##
@@ -1684,14 +1688,18 @@ public Answer createTemplateFromSnapshot(CopyCommand
cmd) {
throw new Exception(msg);
}
-// 4 MB is the minimum requirement for VM memory in VMware
-Pair cloneResult =
-vmMo.cloneFromCurrentSnapshot(workerVmName, 0, 4,
volumeDeviceInfo.second(),
VmwareHelper.getDiskDeviceDatastore(volumeDeviceInfo.first()));
-clonedVm = cloneResult.first();
-String disks[] = cloneResult.second();
-
-clonedVm.exportVm(exportPath, exportName, false, false);
-return new Pair<>(volumeDeviceInfo.second(), disks);
+String diskDevice = volumeDeviceInfo.second();
+String disks[] =
vmMo.getCurrentSnapshotDiskChainDatastorePaths(diskDevice);
+if (clonedWorkerVMNeeded) {
+// 4 MB is the minimum requirement for VM memory in VMware
+Pair cloneResult =
+vmMo.cloneFromCurrentSnapshot(workerVmName, 0, 4,
diskDevice, VmwareHelper.getDiskDeviceDatastore(volumeDeviceInfo.first()));
+clonedVm = cloneResult.first();
+clonedVm.exportVm(exportPath, exportName, false, false);
Review comment:
also here, it would be nice to see just one call for doing the 'real' work.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3228: api: snapshot, snapshotpolicy tag support
DaanHoogland commented on a change in pull request #3228: api: snapshot, snapshotpolicy tag support URL: https://github.com/apache/cloudstack/pull/3228#discussion_r269069665 ## File path: api/src/test/java/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotPolicyCmdTest.java ## @@ -0,0 +1,30 @@ +package org.apache.cloudstack.api.command.user.snapshot; Review comment: license needed, @shwstppr . Can you add it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland edited a comment on issue #3173: Mock Scanner, instead of scan the computer running the test.
DaanHoogland edited a comment on issue #3173: Mock Scanner, instead of scan the computer running the test. URL: https://github.com/apache/cloudstack/pull/3173#issuecomment-476592325 @rhtyd I submitted some additions to @GabrielBrascher . I hope these can be included in this PR: https://github.com/PCextreme/cloudstack/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3173: Mock Scanner, instead of scan the computer running the test.
DaanHoogland commented on issue #3173: Mock Scanner, instead of scan the computer running the test. URL: https://github.com/apache/cloudstack/pull/3173#issuecomment-476592325 @rhtyd I submitted some additions to @GabrielBrascher . I hope these can be included in this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] PaulAngus commented on issue #2869: Fix some Marvin smoke tests
PaulAngus commented on issue #2869: Fix some Marvin smoke tests URL: https://github.com/apache/cloudstack/pull/2869#issuecomment-476556845 we've been running with them under trillian - and they have been reliable This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated (2e2b670 -> 5ee7a9c)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 2e2b670 ui: Fix behavior of multiselect in list view (#3161) new 8b25fdf tests: fix some Marvin smoketests (#2869) new 12c0d88 Merge remote-tracking branch 'origin/4.11' into 4.12 new 5ee7a9c Merge remote-tracking branch 'origin/4.12' The 31835 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../smoke/test_deploy_virtio_scsi_vm.py| 1 + test/integration/smoke/test_hostha_kvm.py | 5 ++- test/integration/smoke/test_vm_life_cycle.py | 25 +++- tools/marvin/marvin/lib/base.py| 44 ++ 4 files changed, 56 insertions(+), 19 deletions(-)
[cloudstack] branch 4.12 updated (bbf5807 -> 12c0d88)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.12 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from bbf5807 Merge remote-tracking branch 'origin/4.11' into 4.12 new 8b25fdf tests: fix some Marvin smoketests (#2869) new 12c0d88 Merge remote-tracking branch 'origin/4.11' into 4.12 The 31825 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../smoke/test_deploy_virtio_scsi_vm.py| 1 + test/integration/smoke/test_hostha_kvm.py | 5 ++- test/integration/smoke/test_vm_life_cycle.py | 25 +++- tools/marvin/marvin/lib/base.py| 44 ++ 4 files changed, 56 insertions(+), 19 deletions(-)
[cloudstack] branch 4.11 updated: tests: fix some Marvin smoketests (#2869)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.11 by this push:
new 8b25fdf tests: fix some Marvin smoketests (#2869)
8b25fdf is described below
commit 8b25fdf520abdd142d125e82dd32335a36a133cd
Author: Paul Angus
AuthorDate: Tue Mar 26 10:03:40 2019 +
tests: fix some Marvin smoketests (#2869)
Fixes intermittent failures:
- Add a pause to avoid tests restarting before VRs recovering from HA have
fully booted.
- Add some pauses to allow services to restart and hosts to reconnect
before continuing tests.
- Adding a loop around this method because sometimes VRs are overloaded and
just respond with exception, so it'll catch it and try 5 times with 30sec
cooldown. If that fails as well it'll fail the test.
- wait until host is up using explicit check
---
.../smoke/test_deploy_virtio_scsi_vm.py| 1 +
test/integration/smoke/test_hostha_kvm.py | 5 ++-
test/integration/smoke/test_vm_life_cycle.py | 25 +++-
tools/marvin/marvin/lib/base.py| 44 ++
4 files changed, 56 insertions(+), 19 deletions(-)
diff --git a/test/integration/smoke/test_deploy_virtio_scsi_vm.py
b/test/integration/smoke/test_deploy_virtio_scsi_vm.py
index df54c43..8969097 100644
--- a/test/integration/smoke/test_deploy_virtio_scsi_vm.py
+++ b/test/integration/smoke/test_deploy_virtio_scsi_vm.py
@@ -96,6 +96,7 @@ class TestDeployVirtioSCSIVM(cloudstackTestCase):
cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
cls.pod = get_pod(cls.apiclient, cls.zone.id)
cls.services['mode'] = cls.zone.networktype
+cls.cleanup = []
if cls.hypervisor.lower() not in ['kvm']:
cls.hypervisorNotSupported = True
return
diff --git a/test/integration/smoke/test_hostha_kvm.py
b/test/integration/smoke/test_hostha_kvm.py
index a4de07e..cd4a2d4 100644
--- a/test/integration/smoke/test_hostha_kvm.py
+++ b/test/integration/smoke/test_hostha_kvm.py
@@ -274,9 +274,12 @@ class TestHAKVM(cloudstackTestCase):
Tests Enable HA when host is in Maintenance mode, should be
Ineligible
"""
self.logger.debug("Starting
test_hostha_enable_ha_when_host_in_maintenance")
-
+self.logger.debug("Pausing to wait for VMs to have finished starting")
+time.sleep(300)
+
# Enable HA
self.configureAndEnableHostHa()
+
# Prepare for maintenance Host
self.setHostToMaintanance(self.host.id)
diff --git a/test/integration/smoke/test_vm_life_cycle.py
b/test/integration/smoke/test_vm_life_cycle.py
index 5906a94..d1962c4 100644
--- a/test/integration/smoke/test_vm_life_cycle.py
+++ b/test/integration/smoke/test_vm_life_cycle.py
@@ -900,6 +900,23 @@ class TestSecuredVmMigration(cloudstackTestCase):
vm_response = VirtualMachine.list(self.apiclient, id=vm.id)[0]
self.assertEqual(vm_response.hostid, dest_host.id, "Check destination
host ID of migrated VM")
+def waitUntilHostInState(self, hostId, state="Up", interval=5, retries=20):
+while retries > -1:
+print("Waiting for host: %s to be %s. %s retries left." % (hostId,
state, retries))
+time.sleep(interval)
+host = Host.list(
+self.apiclient,
+hostid=hostId,
+type='Routing'
+)[0]
+if host.state != state:
+if retries >= 0:
+retries = retries - 1
+continue
+else:
+print("Host %s now showing as %s" % (hostId, state))
+return
+
def unsecure_host(self, host):
SshClient(host.ipaddress, port=22, user=self.hostConfig["username"],
passwd=self.hostConfig["password"])\
.execute("rm -f /etc/cloudstack/agent/cloud* && \
@@ -907,9 +924,10 @@ class TestSecuredVmMigration(cloudstackTestCase):
sed -i 's/listen_tcp.*/listen_tcp=1/g'
/etc/libvirt/libvirtd.conf && \
sed -i '/.*_file=.*/d' /etc/libvirt/libvirtd.conf && \
service libvirtd restart && \
+ sleep 30 && \
service cloudstack-agent restart")
-
-time.sleep(10)
+print("Unsecuring Host: %s" % (host.name))
+self.waitUntilHostInState(hostId=host.id, state="Up")
self.check_connection(host=host, secured='false')
return host
@@ -921,6 +939,8 @@ class TestSecuredVmMigration(cloudstackTestCase):
self.apiclient.provisionCertificate(cmd)
for host in self.hosts:
+print("Securing Host %s" % host.name)
+self.waitUntilHostInState(hostId=host.id, state="Up")
[GitHub] [cloudstack] rhtyd merged pull request #2869: Fix some Marvin smoke tests
rhtyd merged pull request #2869: Fix some Marvin smoke tests URL: https://github.com/apache/cloudstack/pull/2869 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3216: api: include tags in listvmsnapshots response
blueorangutan commented on issue #3216: api: include tags in listvmsnapshots response URL: https://github.com/apache/cloudstack/pull/3216#issuecomment-476552147 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3216: api: include tags in listvmsnapshots response
rhtyd commented on issue #3216: api: include tags in listvmsnapshots response URL: https://github.com/apache/cloudstack/pull/3216#issuecomment-476551818 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3126: Improve System VM startup and memory usage
blueorangutan removed a comment on issue #3126: Improve System VM startup and memory usage URL: https://github.com/apache/cloudstack/pull/3126#issuecomment-453736329 Trillian test result (tid-3305) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 64668 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3126-t3305-xenserver-71.zip Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 48 look OK, 22 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_nic_secondaryip_add_remove | `Error` | 942.49 | test_multipleips_per_nic.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py test_01_so_removal_resource_update | `Error` | 1.35 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py test_02_routervm_iptables_policies | `Error` | 1.27 | test_routers_iptables_default_policy.py test_01_single_VPC_iptables_policies | `Error` | 5.37 | test_routers_iptables_default_policy.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 1.38 | test_routers_network_ops.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 1.36 | test_routers_network_ops.py test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Error` | 4.68 | test_routers_network_ops.py test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 5.99 | test_routers_network_ops.py test_03_RVR_Network_check_router_state | `Error` | 5.99 | test_routers_network_ops.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py ContextSuite context=TestScaleVm>:setup | `Error` | 0.00 | test_scale_vm.py test_01_sys_vm_start | `Failure` | 0.11 | test_secondary_storage.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 2.17 | test_service_offerings.py ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py test_01_list_sec_storage_vm | `Failure` | 0.03 |
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3126: Improve System VM startup and memory usage
blueorangutan removed a comment on issue #3126: Improve System VM startup and memory usage URL: https://github.com/apache/cloudstack/pull/3126#issuecomment-453748322 Trillian test result (tid-3311) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 69188 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3126-t3311-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py Smoke tests completed. 49 look OK, 21 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_nic_secondaryip_add_remove | `Error` | 895.70 | test_multipleips_per_nic.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py test_01_so_removal_resource_update | `Error` | 1.34 | test_resource_accounting.py ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py test_02_routervm_iptables_policies | `Error` | 1.31 | test_routers_iptables_default_policy.py test_01_single_VPC_iptables_policies | `Error` | 5.36 | test_routers_iptables_default_policy.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 1.37 | test_routers_network_ops.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 1.35 | test_routers_network_ops.py test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Error` | 4.68 | test_routers_network_ops.py test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 5.99 | test_routers_network_ops.py test_03_RVR_Network_check_router_state | `Error` | 6.00 | test_routers_network_ops.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py test_01_sys_vm_start | `Failure` | 0.11 | test_secondary_storage.py ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 2.18 | test_service_offerings.py ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3126: Improve System VM startup and memory usage
blueorangutan removed a comment on issue #3126: Improve System VM startup and memory usage URL: https://github.com/apache/cloudstack/pull/3126#issuecomment-453759411 Trillian test result (tid-3312) Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7 Total time taken: 78176 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3126-t3312-vmware-65.zip Intermittent failure detected: /marvin/tests/smoke/test_certauthority_root.py Intermittent failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py Intermittent failure detected: /marvin/tests/smoke/test_projects.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 48 look OK, 22 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_nic_secondaryip_add_remove | `Error` | 972.61 | test_multipleips_per_nic.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py test_01_so_removal_resource_update | `Error` | 1.38 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py test_02_routervm_iptables_policies | `Error` | 1.25 | test_routers_iptables_default_policy.py test_01_single_VPC_iptables_policies | `Error` | 5.43 | test_routers_iptables_default_policy.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 1.34 | test_routers_network_ops.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 1.34 | test_routers_network_ops.py test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Error` | 6.40 | test_routers_network_ops.py test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 6.00 | test_routers_network_ops.py test_03_RVR_Network_check_router_state | `Error` | 6.00 | test_routers_network_ops.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py ContextSuite context=TestScaleVm>:setup | `Error` | 0.00 | test_scale_vm.py test_01_sys_vm_start | `Failure` | 0.09 | test_secondary_storage.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 2.18 | test_service_offerings.py ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 |
[GitHub] [cloudstack] borisstoyanov commented on issue #2869: Fix some Marvin smoke tests
borisstoyanov commented on issue #2869: Fix some Marvin smoke tests URL: https://github.com/apache/cloudstack/pull/2869#issuecomment-476528491 yes, I believe so @rhtyd This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3218: vmware: don't use redundant worker VM to extract volume
blueorangutan commented on issue #3218: vmware: don't use redundant worker VM to extract volume URL: https://github.com/apache/cloudstack/pull/3218#issuecomment-476524112 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3218: vmware: don't use redundant worker VM to extract volume
borisstoyanov commented on issue #3218: vmware: don't use redundant worker VM to extract volume URL: https://github.com/apache/cloudstack/pull/3218#issuecomment-476524067 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3216: api: include tags in listvmsnapshots response
blueorangutan commented on issue #3216: api: include tags in listvmsnapshots response URL: https://github.com/apache/cloudstack/pull/3216#issuecomment-476521676 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2647 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3236: schema: add empty DB upgrade path from 4.12.0.0 to 4.13.0.0
ustcweizhou commented on issue #3236: schema: add empty DB upgrade path from 4.12.0.0 to 4.13.0.0 URL: https://github.com/apache/cloudstack/pull/3236#issuecomment-476521331 code LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #2479: CLOUDSTACK-10278: Introduce Flyway migration on CloudStack database
ustcweizhou commented on issue #2479: CLOUDSTACK-10278: Introduce Flyway migration on CloudStack database URL: https://github.com/apache/cloudstack/pull/2479#issuecomment-476519497 @rhtyd although I merged @fmaximus 's changes to my repo, I think it would be better to keep the upgrade procedure before 4.13 (fresh install/older version to 4.12), and use flyway migration from 4.12 to 4.13 upgrade. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack-cloudmonkey] branch master updated: performrelease: emit sha512 based checksum file
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git The following commit(s) were added to refs/heads/master by this push: new fbdd9c2 performrelease: emit sha512 based checksum file fbdd9c2 is described below commit fbdd9c2ce8821b6df50c48e00af66a5a8f04e1ea Author: Rohit Yadav AuthorDate: Tue Mar 26 13:37:19 2019 +0530 performrelease: emit sha512 based checksum file Signed-off-by: Rohit Yadav --- performrelease.sh | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/performrelease.sh b/performrelease.sh index ddc16d0..f87e0a7 100755 --- a/performrelease.sh +++ b/performrelease.sh @@ -105,8 +105,8 @@ fi echo 'md5' gpg -v --print-md MD5 apache-cloudstack-cloudmonkey-$version-src.tar.bz2 > apache-cloudstack-cloudmonkey-$version-src.tar.bz2.md5 -echo 'sha' -gpg -v --print-md SHA512 apache-cloudstack-cloudmonkey-$version-src.tar.bz2 > apache-cloudstack-cloudmonkey-$version-src.tar.bz2.sha +echo 'sha512' +gpg -v --print-md SHA512 apache-cloudstack-cloudmonkey-$version-src.tar.bz2 > apache-cloudstack-cloudmonkey-$version-src.tar.bz2.sha512 echo 'verify' gpg -v --verify apache-cloudstack-cloudmonkey-$version-src.tar.bz2.asc apache-cloudstack-cloudmonkey-$version-src.tar.bz2 @@ -138,11 +138,11 @@ if [ "$committosvn" == "yes" ]; then cp $outputdir/apache-cloudstack-cloudmonkey-$version-src.tar.bz2 . cp $outputdir/apache-cloudstack-cloudmonkey-$version-src.tar.bz2.asc . cp $outputdir/apache-cloudstack-cloudmonkey-$version-src.tar.bz2.md5 . - cp $outputdir/apache-cloudstack-cloudmonkey-$version-src.tar.bz2.sha . + cp $outputdir/apache-cloudstack-cloudmonkey-$version-src.tar.bz2.sha512 . svn add apache-cloudstack-cloudmonkey-$version-src.tar.bz2 svn add apache-cloudstack-cloudmonkey-$version-src.tar.bz2.asc svn add apache-cloudstack-cloudmonkey-$version-src.tar.bz2.md5 - svn add apache-cloudstack-cloudmonkey-$version-src.tar.bz2.sha + svn add apache-cloudstack-cloudmonkey-$version-src.tar.bz2.sha512 svn commit -m "Committing release candidate artifacts for $version to dist/dev/cloudstack in preparation for release vote" fi
[GitHub] [cloudstack] blueorangutan commented on issue #3186: Add possibility to set KVM MTU size for NIC
blueorangutan commented on issue #3186: Add possibility to set KVM MTU size for NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-476514256 Packaging result: ✖centos6 ✖centos7 ✖debian. JID-2645 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3204: server: Fix exception while update domain resource count
blueorangutan commented on issue #3204: server: Fix exception while update domain resource count URL: https://github.com/apache/cloudstack/pull/3204#issuecomment-476514258 Packaging result: ✖centos6 ✖centos7 ✖debian. JID-2646 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
blueorangutan commented on issue #2376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-476514254 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2644 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3169: ConfigDrive and all other Supported Services not available in the UI when L2 network is chosen
rhtyd commented on issue #3169: ConfigDrive and all other Supported Services not available in the UI when L2 network is chosen URL: https://github.com/apache/cloudstack/issues/3169#issuecomment-476513616 I think we have that option in UI on latest master, will check and fix if necessary. (possibly also on latest 4.11 branch) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3039: VMware 4.11.2.0 system VMs memory consumption grows overtime until heavy swapping occurs
rhtyd commented on issue #3039: VMware 4.11.2.0 system VMs memory consumption grows overtime until heavy swapping occurs URL: https://github.com/apache/cloudstack/issues/3039#issuecomment-476513377 Interesting notes from https://github.com/systemd/systemd/issues/8015#issuecomment-475324192 ``` On Debian I fix the memory consumption commenting the following line on /etc/pam.d/common-session: #session optional pam_systemd.so But, with that, the ssh sessions doesn't terminate correctly. The fix is already done: cp /usr/share/doc/openssh-client/examples/ssh-session-cleanup.service /etc/systemd/system/ systemctl enable ssh-session-cleanup.service Other alternative solution for Debian, add to the end of the file /etc/pam.d/systemd-user : @include null It doesn't include any file, because null doesn't exists. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3216: api: include tags in listvmsnapshots response
blueorangutan commented on issue #3216: api: include tags in listvmsnapshots response URL: https://github.com/apache/cloudstack/pull/3216#issuecomment-476512606 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3216: api: include tags in listvmsnapshots response
rhtyd commented on issue #3216: api: include tags in listvmsnapshots response URL: https://github.com/apache/cloudstack/pull/3216#issuecomment-476512448 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #2983: KVM live storage migration intra cluster from NFS source and destination
rhtyd commented on issue #2983: KVM live storage migration intra cluster from NFS source and destination URL: https://github.com/apache/cloudstack/pull/2983#issuecomment-476509774 On hold - we need to refactor the conflicts to make it work with the similar feature with local storage. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: ui: Fix behavior of multiselect in list view (#3161)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new 2e2b670 ui: Fix behavior of multiselect in list view (#3161)
2e2b670 is described below
commit 2e2b6700a5a17aed2a97577c8bcec9941c30112d
Author: Philipp Bankonier
AuthorDate: Tue Mar 26 08:41:41 2019 +0100
ui: Fix behavior of multiselect in list view (#3161)
Hide multiselectaction buttons when selection is resetted after a action is
performed
Use checked prop instead of attr to show/hide triggered selection when box
was clicked by a user before.
How to reproduce:
Select one entry in a multiSelect listView (e.g. instance list) and then
deselect it again. Now click on the "select all" checkbox. The entries which
were clicked previously are not displayed as selected.
Select at least one entry. Use the multiSelectAction buttons to trigger an
action. Wait for completion. The list refreshes and no entry is selected but
the multiSelectAction buttons are displayed.
Fix:
Use "checked" property instead of the attribute to select all entries. This
is necessary because when you checked an entry by clicking on it the property
gets set and the browser is preferably using this. So setting the attribute by
clicking on the "select all" checkbox had no impact anymore on the checkBox of
the previously clicked entries.
Hide the multiSelectAction buttons when the list is refreshed after an
action is performed and no element is selected anymore.
---
ui/scripts/ui/widgets/listView.js | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/ui/scripts/ui/widgets/listView.js
b/ui/scripts/ui/widgets/listView.js
index 99f6831..4a5d201 100644
--- a/ui/scripts/ui/widgets/listView.js
+++ b/ui/scripts/ui/widgets/listView.js
@@ -88,7 +88,9 @@
// Make sure the master checkbox is unselected
if (multiSelect) {
-
$instanceRow.closest('.list-view').find('input.multiSelectMasterCheckbox').attr('checked',
false);
+var $listView = $instanceRow.closest('.list-view');
+
$listView.find('input.multiSelectMasterCheckbox').prop('checked', false);
+toggleMultiSelectActions($listView, false);
}
var externalLinkAction = action.externalLink;
@@ -882,15 +884,15 @@
if (multiSelect) {
var $th = $('').addClass('multiselect').appendTo($tr);
-var content = $('')
+var $multiSelectMaster = $('')
.attr('type', 'checkbox')
-.addClass('multiSelectMasterCheckbox')
-.appendTo($th);
+.addClass('multiSelectMasterCheckbox');
+$multiSelectMaster.appendTo($th);
-content.click(function() {
-var checked = $(this).is(':checked');
-$('.multiSelectCheckbox').attr('checked', checked);
-toggleMultiSelectActions($table.closest('.list-view'),
checked);
+$multiSelectMaster.click(function() {
+var isMasterChecked = $(this).prop('checked');
+$('.multiSelectCheckbox').prop('checked', isMasterChecked);
+toggleMultiSelectActions($table.closest('.list-view'),
isMasterChecked);
});
}
[GitHub] [cloudstack] rhtyd merged pull request #3161: Fix behavior of multiselect in list view
rhtyd merged pull request #3161: Fix behavior of multiselect in list view URL: https://github.com/apache/cloudstack/pull/3161 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3174: scripts/network/ping: cleaned up code in baremetal_user_data.py
rhtyd commented on a change in pull request #3174: scripts/network/ping: cleaned up code in baremetal_user_data.py URL: https://github.com/apache/cloudstack/pull/3174#discussion_r268971400 ## File path: scripts/network/ping/baremetal_user_data.py ## @@ -15,82 +17,75 @@ # specific language governing permissions and limitations # under the License. -''' -Created on Jul 2, 2012 +# Created on Jul 2, 2012 +# @author: frank Review comment: Remove the created/author comments. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3186: Add possibility to set KVM MTU size for NIC
blueorangutan commented on issue #3186: Add possibility to set KVM MTU size for NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-476508823 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3204: server: Fix exception while update domain resource count
blueorangutan commented on issue #3204: server: Fix exception while update domain resource count URL: https://github.com/apache/cloudstack/pull/3204#issuecomment-476508834 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3186: Add possibility to set KVM MTU size for NIC
rhtyd commented on issue #3186: Add possibility to set KVM MTU size for NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-476508766 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3204: server: Fix exception while update domain resource count
rhtyd commented on issue #3204: server: Fix exception while update domain resource count URL: https://github.com/apache/cloudstack/pull/3204#issuecomment-476508533 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: ui: add start button for multiple selected instances in list view (#3160)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new b81171a ui: add start button for multiple selected instances in list
view (#3160)
b81171a is described below
commit b81171af7d549ff78d23c80aabcdc82a68e60286
Author: Philipp Bankonier
AuthorDate: Tue Mar 26 08:36:06 2019 +0100
ui: add start button for multiple selected instances in list view (#3160)
Adds start button for multiple instances in list view.
Change button order for instances listview multiselect actions.
---
ui/scripts/instances.js | 115 +++-
1 file changed, 114 insertions(+), 1 deletion(-)
diff --git a/ui/scripts/instances.js b/ui/scripts/instances.js
index 7a959df..b006447 100644
--- a/ui/scripts/instances.js
+++ b/ui/scripts/instances.js
@@ -17,6 +17,118 @@
(function($, cloudStack) {
var vmMigrationHostObjs, ostypeObjs;
+var vmStartAction = function(args) {
+ var action = {
+messages: {
+ confirm: function() {
+return 'message.action.start.instance';
+ },
+ notification: function() {
+return 'label.action.start.instance';
+ }
+},
+label: 'label.action.start.instance',
+compactLabel: 'label.start',
+addRow: 'false',
+createForm: {
+ title: 'notification.start.instance',
+ desc: 'message.action.start.instance',
+ fields: {
+hostId: {
+ label: 'label.host',
+ isHidden: function() {
+return !isAdmin();
+ },
+ select: function(args) {
+if (isAdmin()) {
+ $.ajax({
+url: createURL("listHosts=Up=Routing=" +
args.context.instances[0].zoneid),
+dataType: "json",
+async: true,
+success: function(json) {
+ if (json.listhostsresponse.host != undefined) {
+hostObjs = json.listhostsresponse.host;
+var items = [{
+ id: -1,
+ description: 'Default'
+}];
+$(hostObjs).each(function() {
+ items.push({
+id: this.id,
+description: this.name
+ });
+});
+args.response.success({
+ data: items
+});
+ } else {
+cloudStack.dialog.notice({
+ message: _l('No Hosts are avaialble')
+});
+ }
+}
+ });
+} else {
+ args.response.success({
+data: null
+ });
+}
+ }
+}
+ }
+},
+action: function(args) {
+ var instances = args.context.instances;
+ $(instances).map(function(index, instance) {
+var data = {
+ id: instance.id
+};
+if (args.$form.find('.form-item[rel=hostId]').css("display") !=
"none" && args.data.hostId != -1) {
+ $.extend(data, {
+hostid: args.data.hostId
+ });
+}
+$.ajax({
+ url: createURL("startVirtualMachine"),
+ data: data,
+ dataType: "json",
+ async: true,
+ success: function(json) {
+var jid = json.startvirtualmachineresponse.jobid;
+args.response.success({
+ _custom: {
+jobId: jid,
+getUpdatedItem: function(json) {
+ return
json.queryasyncjobresultresponse.jobresult.virtualmachine;
+},
+getActionFilter: function() {
+ return cloudStack.actionFilter.vmActionFilter;
+}
+ }
+});
+ },
+ error: function(json) {
+args.response.error(parseXMLHttpResponse(json));
+ }
+});
+ });
+},
+notification: {
+ poll: pollAsyncJobResult
+}
+ };
+
+
+ if (args && args.listView) {
+$.extend(action, {
+ isHeader: true,
+ isMultiSelectAction: true
+});
+ }
+
+ return action;
+};
+
var vmStopAction = function(args) {
var action = {
messages: {
@@ -504,8 +616,9 @@
poll: pollAsyncJobResult
[GitHub] [cloudstack] rhtyd merged pull request #3160: Add start button for multiple instances in list view
rhtyd merged pull request #3160: Add start button for multiple instances in list view URL: https://github.com/apache/cloudstack/pull/3160 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3173: Mock Scanner, instead of scan the computer running the test.
rhtyd commented on issue #3173: Mock Scanner, instead of scan the computer running the test. URL: https://github.com/apache/cloudstack/pull/3173#issuecomment-476507757 Is this good to merge @GabrielBrascher @wido ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3178: GUI project pulldown list slowdown on large number of projects
ustcweizhou commented on issue #3178: GUI project pulldown list slowdown on large number of projects URL: https://github.com/apache/cloudstack/issues/3178#issuecomment-476507455 @rhtyd will do This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd merged pull request #3165: debian: cleanup commons-daemon no longer needed by agent
rhtyd merged pull request #3165: debian: cleanup commons-daemon no longer needed by agent URL: https://github.com/apache/cloudstack/pull/3165 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: debian: cleanup commons-daemon no longer needed by agent (#3165)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new b9cc6c8 debian: cleanup commons-daemon no longer needed by agent
(#3165)
b9cc6c8 is described below
commit b9cc6c8c73fca070af8a6be7a4f080451100209d
Author: Rohit Yadav
AuthorDate: Tue Mar 26 13:02:40 2019 +0530
debian: cleanup commons-daemon no longer needed by agent (#3165)
With 4.13+ for debian, only systemd enabled distros are supported. This
removes an unnecessary dependency.
Signed-off-by: Rohit Yadav
---
debian/control | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/control b/debian/control
index 7ef3c1e..32db7c0 100644
--- a/debian/control
+++ b/debian/control
@@ -22,7 +22,7 @@ Description: CloudStack server library
Package: cloudstack-agent
Architecture: all
-Depends: ${python:Depends}, openjdk-8-jre-headless | java8-runtime-headless |
java8-runtime | openjdk-9-jre-headless, cloudstack-common (=
${source:Version}), lsb-base (>= 9), libcommons-daemon-java, openssh-client,
qemu-kvm (>= 2.5), libvirt-bin (>= 1.3) | libvirt-daemon-system (>= 3.0),
uuid-runtime, iproute2, ebtables, vlan, ipset, python-libvirt, ethtool,
iptables, lsb-release, aria2
+Depends: ${python:Depends}, openjdk-8-jre-headless | java8-runtime-headless |
java8-runtime | openjdk-9-jre-headless, cloudstack-common (=
${source:Version}), lsb-base (>= 9), openssh-client, qemu-kvm (>= 2.5),
libvirt-bin (>= 1.3) | libvirt-daemon-system (>= 3.0), uuid-runtime, iproute2,
ebtables, vlan, ipset, python-libvirt, ethtool, iptables, lsb-release, aria2
Recommends: init-system-helpers
Conflicts: cloud-agent, cloud-agent-libs, cloud-agent-deps, cloud-agent-scripts
Description: CloudStack agent
[GitHub] [cloudstack] rhtyd commented on issue #3152: Refactoring to remove duplicate code.
rhtyd commented on issue #3152: Refactoring to remove duplicate code. URL: https://github.com/apache/cloudstack/pull/3152#issuecomment-476507033 @fmaximus master is unfrozen now, can you fix the conflict. We can merge this after running a final regression test. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3146: RIP Nuage Cloudstack Plugin
rhtyd commented on issue #3146: RIP Nuage Cloudstack Plugin URL: https://github.com/apache/cloudstack/pull/3146#issuecomment-476506882 @fmaximus master is unfrozen now, sorry but can you fix the conflicts again. We can merge this after running a final regression test. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #2869: Fix some Marvin smoke tests
rhtyd commented on issue #2869: Fix some Marvin smoke tests URL: https://github.com/apache/cloudstack/pull/2869#issuecomment-476506240 are we good to merge this? @PaulAngus @borisstoyanov @rafaelweingartner ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #2479: CLOUDSTACK-10278: Introduce Flyway migration on CloudStack database
rhtyd commented on issue #2479: CLOUDSTACK-10278: Introduce Flyway migration on CloudStack database URL: https://github.com/apache/cloudstack/pull/2479#issuecomment-476505698 cc @nvazquez @PaulAngus @DagSonsteboSB This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
blueorangutan commented on issue #2376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-476505741 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #2376: [4.11] Smoketest Health Check
rhtyd commented on issue #2376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-476505573 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3178: GUI project pulldown list slowdown on large number of projects
rhtyd commented on issue #3178: GUI project pulldown list slowdown on large number of projects URL: https://github.com/apache/cloudstack/issues/3178#issuecomment-476505398 @ustcweizhou can you send a PR to master? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3236: schema: add empty DB upgrade path from 4.12.0.0 to 4.13.0.0
rhtyd commented on issue #3236: schema: add empty DB upgrade path from 4.12.0.0 to 4.13.0.0 URL: https://github.com/apache/cloudstack/pull/3236#issuecomment-476505138 4.13 systemvm links were missed in trillian config file. Re-kicked test job again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
