[cloudstack] branch 4.12.0.0-RC20190212T2301 deleted (was e5b3aa4)

2019-03-28 Thread gabriel
This is an automated email from the ASF dual-hosted git repository.

gabriel pushed a change to branch 4.12.0.0-RC20190212T2301
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was e5b3aa4  Updating pom.xml version numbers for release 4.12.0.0

The revisions that were on this branch are still contained in
other references; therefore, this change does not discard any commits
from the repository.



[cloudstack] branch 4.12.0.0-RC20190314T1011 deleted (was a137398)

2019-03-28 Thread gabriel
This is an automated email from the ASF dual-hosted git repository.

gabriel pushed a change to branch 4.12.0.0-RC20190314T1011
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was a137398  Updating pom.xml version numbers for release 4.12.0.0

The revisions that were on this branch are still contained in
other references; therefore, this change does not discard any commits
from the repository.



[cloudstack] branch 4.12.0.0-RC20190306T1109 deleted (was 9c0cbf9)

2019-03-28 Thread gabriel
This is an automated email from the ASF dual-hosted git repository.

gabriel pushed a change to branch 4.12.0.0-RC20190306T1109
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was 9c0cbf9  Updating pom.xml version numbers for release 4.12.0.0

This change permanently discards the following revisions:

 discard 9c0cbf9  Updating pom.xml version numbers for release 4.12.0.0



[GitHub] [cloudstack] blueorangutan commented on issue #3234: api: Set network name as part of the network usage response

2019-03-28 Thread GitBox
blueorangutan commented on issue #3234: api: Set network name as part of the 
network usage response
URL: https://github.com/apache/cloudstack/pull/3234#issuecomment-477702397
 
 
   Trillian test result (tid-3451)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33626 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3234-t3451-kvm-centos7.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_affinity_groups_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 66 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_DeployVmAntiAffinityGroup_in_project | `Error` | 65.51 | 
test_affinity_groups_projects.py
   test_DeployVmAntiAffinityGroup | `Error` | 37.59 | test_affinity_groups.py
   test_05_rvpc_multi_tiers | `Failure` | 413.78 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 441.94 | test_vpc_redundant.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 307.79 | 
test_hostha_kvm.py
   test_hostha_kvm_host_degraded | `Failure` | 698.07 | test_hostha_kvm.py
   test_hostha_kvm_host_fencing | `Failure` | 647.90 | test_hostha_kvm.py
   test_hostha_kvm_host_recovering | `Failure` | 646.92 | test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3247: Make the API documentation version not *hardcoded* to v4.9.0

2019-03-28 Thread GitBox
GabrielBrascher commented on a change in pull request #3247: Make the API 
documentation version not *hardcoded* to v4.9.0
URL: https://github.com/apache/cloudstack/pull/3247#discussion_r270117085
 
 

 ##
 File path: tools/apidoc/generatecommands.xsl
 ##
 @@ -57,7 +57,7 @@ version="1.0">



-   Apache 
CloudStack v4.9.0 Root Admin API Reference
+   Apache 
CloudStack v%ACS_RELEASE% Root Admin API Reference
 
 Review comment:
   Good point. I agree with you @rafaelweingartner. Updated it!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rafaelweingartner commented on a change in pull request #3247: Make the API documentation version not *hardcoded* to v4.9.0

2019-03-28 Thread GitBox
rafaelweingartner commented on a change in pull request #3247: Make the API 
documentation version not *hardcoded* to v4.9.0
URL: https://github.com/apache/cloudstack/pull/3247#discussion_r270085169
 
 

 ##
 File path: tools/apidoc/generatecommands.xsl
 ##
 @@ -57,7 +57,7 @@ version="1.0">



-   Apache 
CloudStack v4.9.0 Root Admin API Reference
+   Apache 
CloudStack v%ACS_RELEASE% Root Admin API Reference
 
 Review comment:
   do we need/want the `v`? It is always `v` anyways.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3242: [WIP DO NOT MERGE] server: add support for sorting zones in UI/API

2019-03-28 Thread GitBox
blueorangutan commented on issue #3242: [WIP DO NOT MERGE] server: add support 
for sorting zones in UI/API
URL: https://github.com/apache/cloudstack/pull/3242#issuecomment-477624455
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2660


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the

2019-03-28 Thread GitBox
blueorangutan commented on issue #3241: [WIP DO NOT MERGE] Allow users to share 
templates with Accounts or Projects through the
URL: https://github.com/apache/cloudstack/pull/3241#issuecomment-477624212
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2659


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3243: [WIP DO NOT MERGE] ui: add memory used column in instance metrics view

2019-03-28 Thread GitBox
blueorangutan commented on issue #3243: [WIP DO NOT MERGE] ui: add memory used 
column in instance metrics view
URL: https://github.com/apache/cloudstack/pull/3243#issuecomment-477621491
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2658


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] GabrielBrascher opened a new pull request #3247: Make the API documentation version not *hardcoded* to v4.9.0

2019-03-28 Thread GitBox
GabrielBrascher opened a new pull request #3247: Make the API documentation 
version not *hardcoded* to v4.9.0
URL: https://github.com/apache/cloudstack/pull/3247
 
 
   Currently, the API documentation is *hardcoded* to _v4.9.0_. This commit 
makes the API documentation automatically updated to the current project 
version. If one wants to set another version, it is possible by just editing 
the `ACS_RELEASE` variable in _build-apidoc.sh_.
   
   ## Description
   
   
   
   
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   Prior to the changes proposed in this PR the generated API documentaion was 
labeled as '4.9.0':
   
![image](https://user-images.githubusercontent.com/5025148/55164448-7393b300-514a-11e9-95d5-a8c99b71b486.png)
   
   ## How Has This Been Tested?
   
   
   
   Project API documentation page:
   
![image](https://user-images.githubusercontent.com/5025148/55164220-0d0e9500-514a-11e9-8fac-db7d75e64ff4.png)
   
   Example of a API command documentation page:
   
![image](https://user-images.githubusercontent.com/5025148/55164328-37f8e900-514a-11e9-88b0-86858e08a4c4.png)
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] PaulAngus commented on issue #3126: Improve System VM startup and memory usage

2019-03-28 Thread GitBox
PaulAngus commented on issue #3126: Improve System VM startup and memory usage
URL: https://github.com/apache/cloudstack/pull/3126#issuecomment-477601649
 
 
   ![Annotation 2019-03-28 
134017](https://user-images.githubusercontent.com/4810220/55162319-7947c380-515f-11e9-90fd-191c17a920cb.jpg)
   
   Continuing to monitor the above VR while running:
   `while true; do ssh -p3922 -i /var/cloudstack/management/.ssh/id_rsa 
root@10.2.7.101 "echo hi"; done`
   memory usage growth in negligible
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3242: [WIP DO NOT MERGE] server: add support for sorting zones in UI/API

2019-03-28 Thread GitBox
blueorangutan commented on issue #3242: [WIP DO NOT MERGE] server: add support 
for sorting zones in UI/API
URL: https://github.com/apache/cloudstack/pull/3242#issuecomment-477597440
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the

2019-03-28 Thread GitBox
blueorangutan commented on issue #3241: [WIP DO NOT MERGE] Allow users to share 
templates with Accounts or Projects through the
URL: https://github.com/apache/cloudstack/pull/3241#issuecomment-477597426
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the

2019-03-28 Thread GitBox
borisstoyanov commented on issue #3241: [WIP DO NOT MERGE] Allow users to share 
templates with Accounts or Projects through the
URL: https://github.com/apache/cloudstack/pull/3241#issuecomment-477597366
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov commented on issue #3242: [WIP DO NOT MERGE] server: add support for sorting zones in UI/API

2019-03-28 Thread GitBox
borisstoyanov commented on issue #3242: [WIP DO NOT MERGE] server: add support 
for sorting zones in UI/API
URL: https://github.com/apache/cloudstack/pull/3242#issuecomment-477597115
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3243: [WIP DO NOT MERGE] ui: add memory used column in instance metrics view

2019-03-28 Thread GitBox
blueorangutan commented on issue #3243: [WIP DO NOT MERGE] ui: add memory used 
column in instance metrics view
URL: https://github.com/apache/cloudstack/pull/3243#issuecomment-477594480
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov commented on issue #3243: [WIP DO NOT MERGE] ui: add memory used column in instance metrics view

2019-03-28 Thread GitBox
borisstoyanov commented on issue #3243: [WIP DO NOT MERGE] ui: add memory used 
column in instance metrics view
URL: https://github.com/apache/cloudstack/pull/3243#issuecomment-477594288
 
 
   @blueorangutan package
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text

2019-03-28 Thread GitBox
blueorangutan commented on issue #3240: [WIP DO NOT MERGE] api: instance and 
template details are free text
URL: https://github.com/apache/cloudstack/pull/3240#issuecomment-477575644
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2657


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text

2019-03-28 Thread GitBox
blueorangutan commented on issue #3240: [WIP DO NOT MERGE] api: instance and 
template details are free text
URL: https://github.com/apache/cloudstack/pull/3240#issuecomment-477569321
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text

2019-03-28 Thread GitBox
rhtyd commented on issue #3240: [WIP DO NOT MERGE] api: instance and template 
details are free text
URL: https://github.com/apache/cloudstack/pull/3240#issuecomment-477569115
 
 
   @borisstoyanov looks like an env issue, let's try again
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3212: storage: publish delete usage event for snapshot deletion

2019-03-28 Thread GitBox
blueorangutan commented on issue #3212: storage: publish delete usage event for 
snapshot deletion
URL: https://github.com/apache/cloudstack/pull/3212#issuecomment-477558727
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2655


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3213: server: allow admins to blacklist vm details that users should not see

2019-03-28 Thread GitBox
blueorangutan commented on issue #3213: server: allow admins to blacklist vm 
details that users should not see
URL: https://github.com/apache/cloudstack/pull/3213#issuecomment-477558725
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2656


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3217: ui: introduce new UI config file

2019-03-28 Thread GitBox
blueorangutan commented on issue #3217: ui: introduce new UI config file
URL: https://github.com/apache/cloudstack/pull/3217#issuecomment-477557335
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2654


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text

2019-03-28 Thread GitBox
blueorangutan commented on issue #3240: [WIP DO NOT MERGE] api: instance and 
template details are free text
URL: https://github.com/apache/cloudstack/pull/3240#issuecomment-477554525
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-2653


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text

2019-03-28 Thread GitBox
borisstoyanov commented on issue #3240: [WIP DO NOT MERGE] api: instance and 
template details are free text
URL: https://github.com/apache/cloudstack/pull/3240#issuecomment-477551859
 
 
   @rhtyd there's some build failures with this one, can you have a look? 
   ```
   [INFO] 
   [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-network-vcs ---
   [INFO] Deleting 
/jenkins/workspace/acs-pr-centos6-pkg-builder/dist/rpmbuild/BUILD/cloudstack-4.13.0.0-SNAPSHOT/plugins/network-elements/brocade-vcs
 (includes = [target, dist], excludes = [])
   [INFO] 
   [INFO] --- maven-checkstyle-plugin:3.0.0:check (cloudstack-checkstyle) @ 
cloud-plugin-network-vcs ---
   /opt/rh/maven30/root/usr/bin/mvn: line 9:  2041 Killed  
$M2_HOME/bin/mvn "$@"
   error: Bad exit status from /var/tmp/rpm-tmp.ozlF7H (%build)
   
   
   RPM build errors:
   Bad exit status from /var/tmp/rpm-tmp.ozlF7H (%build)
   + '[' 1 -ne 0 ']'
   + '[' false == true ']'
   + echo 'RPM Build Failed '
   RPM Build Failed 
   + exit 3
   Build step 'Execute shell' marked build as failure
   Stopping all containers
   Finished: FAILURE
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3213: server: allow admins to blacklist vm details that users should not see

2019-03-28 Thread GitBox
blueorangutan commented on issue #3213: server: allow admins to blacklist vm 
details that users should not see
URL: https://github.com/apache/cloudstack/pull/3213#issuecomment-477540076
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov commented on issue #3213: server: allow admins to blacklist vm details that users should not see

2019-03-28 Thread GitBox
borisstoyanov commented on issue #3213: server: allow admins to blacklist vm 
details that users should not see
URL: https://github.com/apache/cloudstack/pull/3213#issuecomment-477539791
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3212: storage: publish delete usage event for snapshot deletion

2019-03-28 Thread GitBox
blueorangutan commented on issue #3212: storage: publish delete usage event for 
snapshot deletion
URL: https://github.com/apache/cloudstack/pull/3212#issuecomment-477539096
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov commented on issue #3212: storage: publish delete usage event for snapshot deletion

2019-03-28 Thread GitBox
borisstoyanov commented on issue #3212: storage: publish delete usage event for 
snapshot deletion
URL: https://github.com/apache/cloudstack/pull/3212#issuecomment-477538010
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3217: ui: introduce new UI config file

2019-03-28 Thread GitBox
blueorangutan commented on issue #3217: ui: introduce new UI config file
URL: https://github.com/apache/cloudstack/pull/3217#issuecomment-477533750
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text

2019-03-28 Thread GitBox
blueorangutan commented on issue #3240: [WIP DO NOT MERGE] api: instance and 
template details are free text
URL: https://github.com/apache/cloudstack/pull/3240#issuecomment-477533126
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov commented on issue #3217: ui: introduce new UI config file

2019-03-28 Thread GitBox
borisstoyanov commented on issue #3217: ui: introduce new UI config file
URL: https://github.com/apache/cloudstack/pull/3217#issuecomment-477530530
 
 
   amazing how 3 people did the same typo...
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text

2019-03-28 Thread GitBox
borisstoyanov commented on issue #3240: [WIP DO NOT MERGE] api: instance and 
template details are free text
URL: https://github.com/apache/cloudstack/pull/3240#issuecomment-477529824
 
 
   @blueorangutan package
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] shwstppr opened a new pull request #3246: [WIP DO NOT MERGE] server: allow disk offering selection for volume from snapshot

2019-03-28 Thread GitBox
shwstppr opened a new pull request #3246: [WIP DO NOT MERGE] server: allow disk 
offering selection for volume from snapshot
URL: https://github.com/apache/cloudstack/pull/3246
 
 
   ## Description
   **Problem**: Volume created from a snapshot does not show its disk offering.
   
   **Root Cause**: The volume created from a snapshot of a root disk does not 
have a disk offering therefore the disk offering of the created volume from the 
snapshot is empty.
   
   **Solution**: Refactored createVolume API and extended UI to allow user to 
select disk offering while creating volumes using a root disk volume snapshot. 
For creating volumes using data disk volume snapshot, disk offering given by 
snapshot will be assigned. Disk offering selection in UI form volume creation 
from snapshot is depicted in screenshot below.
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [x] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   ![Screenshot from 2019-03-07 
16-15-42](https://user-images.githubusercontent.com/153340/54278789-62c73700-45b9-11e9-8d8f-158355e5d251.png)
   
   ## How Has This Been Tested?
   From UI
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] shwstppr opened a new pull request #3245: [WIP DO NOT MERGE] server: allows compute offering with or without constraints

2019-03-28 Thread GitBox
shwstppr opened a new pull request #3245: [WIP DO NOT MERGE] server: allows 
compute offering with or without constraints
URL: https://github.com/apache/cloudstack/pull/3245
 
 
   ## Description
   **Problem**: Custom compute offering does not allow setting min and max 
values for CPU and VRAM for custom VMs. 
   
   **Root Cause**: Custom compute offerings cannot be created with a given 
range of CPU number and memory instead it allows only fixed values. 
   
   **Solution**: createServiceOffering API has been modified to allow setting a 
defined range for CPU number and memory. Also, UI form for compute offering 
creation is provided with a new field named 'compute offering type’ with values 
- Fixed, Custom Constrained, Custom Constrained. It will allow creation of 
compute offerings either with a fixed CPU speed and memory for fixed compute 
offering, or with a range of CPU number and memory range for custom constrained 
compute offering or without predefined CPU number, CPU speed and memory for 
custom unconstrained compute offering. 
   
   To allow user to set CPU number, CPU speed and memory during VM deployment, 
UI form for VM deployment has been modified to provide controls to change these 
values. These controls are depicted in screenshots below for custom constrained 
and custom unconstrained compute offering types. 
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   Create compute offering form
   ![Screenshot from 2019-03-12 
17-32-13](https://user-images.githubusercontent.com/153340/54267506-5a620280-459f-11e9-8aa6-01e1cf98f3f2.png)
   ![Screenshot from 2019-03-12 
17-32-17](https://user-images.githubusercontent.com/153340/54267507-5a620280-459f-11e9-826e-baebb79d32d5.png)
   ![Screenshot from 2019-03-12 
17-32-22](https://user-images.githubusercontent.com/153340/54267508-5afa9900-459f-11e9-807a-614b7c104323.png)
   
   VM deployment form
   ![Screenshot from 2019-03-12 
17-43-52](https://user-images.githubusercontent.com/153340/54267533-677ef180-459f-11e9-94ed-b53130b2c2d4.png)
   ![Screenshot from 2019-03-12 
17-44-01](https://user-images.githubusercontent.com/153340/54267534-677ef180-459f-11e9-8541-bb8869662caf.png)
   
   ## How Has This Been Tested?
   
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] shwstppr opened a new pull request #3244: [WIP DO NOT MERGE] ui: instance settings visibility

2019-03-28 Thread GitBox
shwstppr opened a new pull request #3244: [WIP DO NOT MERGE] ui: instance 
settings visibility
URL: https://github.com/apache/cloudstack/pull/3244
 
 
   ## Description
   **Problem**: Instance settings tab is visible only for stopped VMs but 
hidden otherwise. This creates confusion as users may not know that VMs need to 
be stopped to access settings page. Some VM details need to be read-only for 
the user.
   
   **Root Cause**: The UI Code hides the settings tab for VMs that are not in 
stopped state. Instance setting tab should always be visible, but only 
changeable when VM is stopped. Required instance details are not read-only for 
the user.
   
   **Solution**: The settings tab is now always visible for VMs. If VM is not 
in the stopped state, no interactions are allowed in the settings tab view by 
greying out its content and a popup is shown to advise users for stopping the 
VM. VM details can be made read-only in UI for the user using 
“user.vm.readonly.ui.details” which accepts a comma-separated list of details. 
Read-only details will be shown in the settings tab in UI but the action button 
for them will be disabled and greyed out.
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   Snapshot when VM is stopped.
   ![screenshot from 2019-01-09 
22-08-03](https://user-images.githubusercontent.com/43956255/50913773-18abc300-145b-11e9-8786-89f91a7508c7.png)
   Snapshot when VM is not stopped but Settings tab is clicked and Popup appears
   ![screenshot from 2019-01-09 
17-54-40](https://user-images.githubusercontent.com/43956255/50913775-19445980-145b-11e9-8a25-6c945528cf96.png)
   When popup is dismissed
   ![screenshot from 2019-01-09 
17-54-55](https://user-images.githubusercontent.com/43956255/50913774-19445980-145b-11e9-8cdd-a9f450b5af81.png)
   
   VM setting/detail made read-only
   ![Screenshot from 2019-03-14 
14-13-49](https://user-images.githubusercontent.com/153340/54343019-d6258300-4663-11e9-81e7-fd7d9caaaf3a.png)
   
   
   ## How Has This Been Tested?
   
   
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd opened a new pull request #3243: ui: add memory used column in instance metrics view

2019-03-28 Thread GitBox
rhtyd opened a new pull request #3243: ui: add memory used column in instance 
metrics view
URL: https://github.com/apache/cloudstack/pull/3243
 
 
   **Problem**: The metrics view for instances does not show used memory.
   **Root Cause**: Used memory was not added as a column in the metrics view 
for instances.
   **Solution**: Metrics view for instances makes ‘listVirtualMachineMetrics’ 
API call to gather metrics. The response of this API call contains total and 
free memory with the instance. These have been used to compute used memory as a 
percentage of total memory and displayed as a new column in UI. Also fixes
   a bug for VMware, due to which incorrect memory usage was returned.
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd opened a new pull request #3242: [WIP DO NOT MERGE] server: add support for sorting zones in UI/API

2019-03-28 Thread GitBox
rhtyd opened a new pull request #3242: [WIP DO NOT MERGE] server: add support 
for sorting zones in UI/API
URL: https://github.com/apache/cloudstack/pull/3242
 
 
   **Problem**: Not able to configure a sort order for the zone that are listed 
in various views in the UI.
   **Root Cause**: There was no mechanism to accept sort key for existing zones 
or UI widget to drag them in a certain order.
   **Solution**: The order can now be configured through the editZone API by 
providing sort_key parameter for zones, or by reordering the zones in the Zones 
list in the UI. Database changes include updating table “data_center” which 
contains the “sort_key” column containing integer values and defaults to zero.
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   
![51236319-da9d2a80-1997-11e9-9c23-b8a4e5e27ccd](https://user-images.githubusercontent.com/95203/54276741-1af1e100-45b4-11e9-952a-17525343f039.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd opened a new pull request #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the

2019-03-28 Thread GitBox
rhtyd opened a new pull request #3241: [WIP DO NOT MERGE] Allow users to share 
templates with Accounts or Projects through the
URL: https://github.com/apache/cloudstack/pull/3241
 
 
   Problem: CloudStack users want the ability to share templates with other 
accounts or projects through the UI.
   
   Root Cause: The ‘updateTemplatePermissions’ is only available via API and 
needs to be integrated with the UI in order to allow users to share templates 
with other accounts within the same domain, and also with projects that the 
sharing account has access to.
   
   Solution: The CloudStack UI template view has been extended to include a 
button that allows users to update template permissions through the 
‘updateTemplatePermissions’ API. This API supports 3 operations i.e. add, 
remove or reset. The reset operation does not require any parameters and it 
simply removes all permissions for a template. The add and remove parameters 
require either accounts or projects to be specified for sharing or stop sharing 
templates. The ‘listAccounts’ API has been extended to allow users to see all 
the accounts within the same domain if the global setting 
‘allow.view.all.domain.accounts’ is set to true. This allows the accounts 
selection to be a multi-selection.
   
   
   
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   Reset Operation hides the Accounts and Project ID fields as this operation 
does not require any additional parameters to be set.
   
   Operation = Reset; Account and Project fields not displayed
   
![image](https://user-images.githubusercontent.com/19572501/53580791-0c073980-3b85-11e9-949b-57592f4ac6f8.png)
   
   Operation = Add/Remove , global setting: 
'allow.user.view.all.domain.accounts' = false;
   
![image](https://user-images.githubusercontent.com/19572501/53580711-e37f3f80-3b84-11e9-9f28-0ddf9ab98d19.png)
   
   Operation = Add , global setting: 'allow.user.view.all.domain.accounts' = 
true; Domain has 3 accounts in total (bt1, bt2 and bt3). Logged in user is bt1 
and so it is not shown on the dropdown list.
   
![image](https://user-images.githubusercontent.com/19572501/53581050-8b950880-3b85-11e9-8c7d-71b5b4b50524.png)
   
   Operation = Remove , global setting: 'allow.user.view.all.domain.accounts' = 
true; Domain has 3 accounts in total (bt1, bt2 and bt3). The current template 
was only shared with bt2 by bt1 so dropdown menu only shows accounts that the 
current template has been shared with.
   
![image](https://user-images.githubusercontent.com/19572501/53581135-b3846c00-3b85-11e9-96d8-a6e0f85a776b.png)
   
   ## How Has This Been Tested?
   - Create 2 Accounts (acc1 and acc2) within the same domain.
   - Log in to the CloudStack UI with acc1 user account and upload a private 
template for this user.
   - Navigate to the newly created UI and click on the "Update Template 
Permissions" button.
   - A new window should pop up, select "Add" for this window and input acc2 in 
the Accounts input field and then click OK.
   - With CloudMonkey/CloudStack UI, check for shared templates using acc2 user 
account. The template from acc1 user account should now be visible to acc2 
under shared templates.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd opened a new pull request #3240: [WIP DO NOT MERGE] api: instance and template details are free text

2019-03-28 Thread GitBox
rhtyd opened a new pull request #3240: [WIP DO NOT MERGE] api: instance and 
template details are free text
URL: https://github.com/apache/cloudstack/pull/3240
 
 
   Problem: Users don't know what keys/values to enter for template and VM 
details.
   Root Cause: The feature does not exist that can list possible details and 
options.
   Solution: Based on the possible VM and template details handled by the
   codebase, those details were refactored and a list API is introduced
   that can return users those details along with possible values. When
   users add details now, they will be presented with a list of key details
   and their possible options if any.
   
   Introduces a new API:
   ```
   listDetailOptions: Lists all possible details and their options for a 
resource type such as a VM or a template
   Required params: resourcetype, 
   API Params   Type Description
   ==    ===
   resourceid   string   the UUID of the resource (optional)
   resourcetype string   the resource type such as UserVm, Template 
etc.
   ```
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ![Screenshot from 2019-03-27 
18-12-18](https://user-images.githubusercontent.com/95203/55076970-b313be00-50bc-11e9-8981-c36d2c55d407.png)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3234: api: Set network name as part of the network usage response

2019-03-28 Thread GitBox
blueorangutan commented on issue #3234: api: Set network name as part of the 
network usage response
URL: https://github.com/apache/cloudstack/pull/3234#issuecomment-477486869
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov commented on issue #3234: api: Set network name as part of the network usage response

2019-03-28 Thread GitBox
borisstoyanov commented on issue #3234: api: Set network name as part of the 
network usage response
URL: https://github.com/apache/cloudstack/pull/3234#issuecomment-477486700
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services