[GitHub] [cloudstack] ustcweizhou commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts
ustcweizhou commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-493323151 @svenvogel if list projects with id, then details is not set so it will list all resource limits. if list projects without id, then details is set to min, only project information and tags will be added This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts
svenvogel commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-493237338 @ustcweizhou what is used in the UI - all or min? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3332: Switch instance to another compute/service offering
svenvogel commented on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-493236941 @nathanejohnson we use the UI. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] skattoju4 edited a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV
skattoju4 edited a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-493221612 @kiwiflyer after discussing this with @swill i have a better understanding. Essentially registering an ISO is supposed to be hypervisor agnostic. We can only know valid options for disk controller in the context of a selected hypervisor which in the case of ISOs is during VM creation. Given this it makes sense to have the option of specifying hypervisor specific options during VM creation. Currently this comes from vm details in the case of non ISO based templates but is not set the case of ISO based templates. As a result the agent tries to guess the disk controller based on the OS type specified during ISO template registration. Maintaining this guessing logic is not ideal. The deployVirtualMachine api has a details map that can be used to pass the rootDiskController value which is used by the KVM agent. We were able to verify this using cloud monkey. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nathanejohnson commented on issue #3332: Switch instance to another compute/service offering
nathanejohnson commented on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-493221767 @pbankonier from looking at the code prior to this PR, it looks like this behavior predates it. Are you using the UI or creating the service offering via API? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] skattoju4 edited a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV
skattoju4 edited a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-493221612 @kiwiflyer after discussing this with @swill i have a better understanding. Essentially registering an ISO is supposed to be hypervisor agnostic. We can only know valid options for disk controller in the context of a selected hypervisor which in the case of ISOs is during VM creation. Given this it makes sense to have the option of specifying hypervisor specific options during VM creation. The deployVirtualMachine api has a details map that can be used to pass this info. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] skattoju4 commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV
skattoju4 commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-493221612 @kiwiflyer after discussing this with @swill i have a better understanding. Essentially registering ISO is supposed to be hypervisor agnostic. We can only know valid selections for disk controller in the context of a selected hypervisor which in the case of ISOs is during VM creation. Given this it makes sense to have the option of specifying hypervisor specific options during VM creation. The deployVirtualMachine api has a details map that can be used to pass this info. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on a change in pull request #3331: api/server: Add option 'details' to listProjects and listAccounts
ustcweizhou commented on a change in pull request #3331: api/server: Add option
'details' to listProjects and listAccounts
URL: https://github.com/apache/cloudstack/pull/3331#discussion_r284835590
##
File path: server/src/main/java/com/cloud/api/query/dao/ProjectJoinDaoImpl.java
##
@@ -91,9 +94,11 @@ public ProjectResponse newProjectResponse(ProjectJoinVO
proj) {
//set resource limit/count information for the project (by getting the
info of the project's account)
Account account =
_accountDao.findByIdIncludingRemoved(proj.getProjectAccountId());
-AccountJoinVO accountJn = ApiDBUtils.newAccountView(account);
-_accountJoinDao.setResourceLimits(accountJn, false, response);
-response.setProjectAccountName(accountJn.getAccountName());
+if (details.contains(DomainDetails.all) ||
details.contains(DomainDetails.resource)) {
+AccountJoinVO accountJn = ApiDBUtils.newAccountView(account);
Review comment:
line 98 takes around 0.2 seconds for each project in my testing environment.
The actual time depends on how many accounts in your system.
```
AccountJoinVO accountJn = ApiDBUtils.newAccountView(account);
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3330: server: add newline to the SSH key content
rhtyd commented on issue #3330: server: add newline to the SSH key content URL: https://github.com/apache/cloudstack/pull/3330#issuecomment-493146906 I'll re-test using a fresh centos7 based env. I hit the problem again today, this time with virtual routers but not ssvm/cpvm with this PR. It's probably something to do openssh-client changes or possibly my env. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nathanejohnson commented on issue #3332: Switch instance to another compute/service offering
nathanejohnson commented on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-493147147 I will take a look This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] skattoju4 edited a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV
skattoju4 edited a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-493125862 I think since we always create vms from templates this should be specified when registering templates (iso or otherwise) to be consistent with the current workflow. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] skattoju4 commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV
skattoju4 commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-493125862 I think since we always create vms from templates this should be specified when registering templates to be consistent with the current workflow. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nathanejohnson commented on issue #3312: 'sed -i' need postfix on mac
nathanejohnson commented on issue #3312: 'sed -i' need postfix on mac URL: https://github.com/apache/cloudstack/pull/3312#issuecomment-493082382 @rhtyd you can easily add gnu sed to mac via homebrew as you point out, however the binary is called 'gsed' to avoid conflicting with the main sed installed in /usr/bin . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] webermaximilian92 removed a comment on issue #3328: Enhancement scss refactoring
webermaximilian92 removed a comment on issue #3328: Enhancement scss refactoring URL: https://github.com/apache/cloudstack/pull/3328#issuecomment-493061832 I am in Norway for around 3 weeks now. Let's merge this when I am back, so we can react faster to unlikely issues, then. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] webermaximilian92 commented on issue #3328: WIP - do not merge - Enhancement scss refactoring
webermaximilian92 commented on issue #3328: WIP - do not merge - Enhancement scss refactoring URL: https://github.com/apache/cloudstack/pull/3328#issuecomment-493061832 I am in Norway for around 3 weeks now. Let's merge this when I am back, so we can react faster to unlikely issues, then. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] webermaximilian92 edited a comment on issue #3328: Enhancement scss refactoring
webermaximilian92 edited a comment on issue #3328: Enhancement scss refactoring URL: https://github.com/apache/cloudstack/pull/3328#issuecomment-492978827 Hey Daan, thanks for your feedback. This is not compareable to jquery update, because it's not an upgrade of any Framework Version. New compiled CSS remains CSS. It's an refactoring of old technology. I didn't changed the code at all here but I generated a way to better work with it. The CSS script is full of redundant and outdated rules. We need to fix that anytime in future and we should begin right now. There will be no warranty, that no issues and mistakes were done by me here, but it wont be that complicated to fix small issues and I am pretty experienced by what I'm doing. Max This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] pbankonier opened a new issue #3332: Switch instance to another compute/service offering
pbankonier opened a new issue #3332: Switch instance to another compute/service
offering
URL: https://github.com/apache/cloudstack/issues/3332
# ISSUE TYPE
* Bug Report
# COMPONENT NAME
~~~
Server
# CLOUDSTACK VERSION
~~~
Master
~~~
# CONFIGURATION
~~~
N/A
~~~
# OS / ENVIRONMENT
~~~
N/A
~~~
# SUMMARY
Not possible to change a service offering for an instance to a newly created
compute offering.
The problem are the changes in
https://github.com/apache/cloudstack/pull/3133/files in the
ConfigurationManagerImpl.java.
When issystem is passed as false and iscusstomizediops is null when you
create a compute offering the values gets set to 0 instead of null.
# STEPS TO REPRODUCE
~~~
Create a new compute offering.
Change the service offering of an instance to the newly created compute
offering.
~~~
# EXPECTED RESULTS
~~~
The values for minIops and maxIops are set to null and it is possible to
change the
offering for the instance.
~~~
# ACTUAL RESULTS
~~~
The values for minIops and maxIops are set to 0.
An error is thrown ("The minIOPS value must be between 50 and 15000").
~~~
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on a change in pull request #3330: server: add newline to the SSH key content
ustcweizhou commented on a change in pull request #3330: server: add newline to
the SSH key content
URL: https://github.com/apache/cloudstack/pull/3330#discussion_r284677611
##
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtStartCommandWrapper.java
##
@@ -116,7 +116,7 @@ public Answer execute(final StartCommand command, final
LibvirtComputingResource
}
}
// try to patch and SSH into the systemvm for up to 5 minutes
-for (int count = 0; count < 10; count++) {
+for (int count = 0; count < 30; count++) {
Review comment:
@rhtyd is this change part of this commit ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3330: server: add newline to the SSH key content
blueorangutan commented on issue #3330: server: add newline to the SSH key content URL: https://github.com/apache/cloudstack/pull/3330#issuecomment-493025437 Trillian test result (tid-3555) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 25308 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3330-t3555-kvm-centos7.zip Smoke tests completed. 70 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3330: server: add newline to the SSH key content
DaanHoogland commented on a change in pull request #3330: server: add newline
to the SSH key content
URL: https://github.com/apache/cloudstack/pull/3330#discussion_r284645289
##
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtStartCommandWrapper.java
##
@@ -116,7 +116,7 @@ public Answer execute(final StartCommand command, final
LibvirtComputingResource
}
}
// try to patch and SSH into the systemvm for up to 5 minutes
-for (int count = 0; count < 10; count++) {
+for (int count = 0; count < 30; count++) {
Review comment:
should the comment above be updated to read "up to 15 minutes"?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3330: server: add newline to the SSH key content
blueorangutan commented on issue #3330: server: add newline to the SSH key content URL: https://github.com/apache/cloudstack/pull/3330#issuecomment-493014202 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2738 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3330: server: add newline to the SSH key content
blueorangutan commented on issue #3330: server: add newline to the SSH key content URL: https://github.com/apache/cloudstack/pull/3330#issuecomment-493007654 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3330: server: add newline to the SSH key content
rhtyd commented on issue #3330: server: add newline to the SSH key content URL: https://github.com/apache/cloudstack/pull/3330#issuecomment-493007638 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] webermaximilian92 edited a comment on issue #3328: Enhancement scss refactoring
webermaximilian92 edited a comment on issue #3328: Enhancement scss refactoring URL: https://github.com/apache/cloudstack/pull/3328#issuecomment-492978827 Hey Daan, thanks for feedback. This is not compareable to jquery update, because it's not an upgrade of any Framework Version. New compiled CSS remains CSS. It's an refactoring of old technology. I didn't changed the code at all here but I generated a way to better work with it. The CSS script is full of redundant and outdated rules. We need to fix that anytime in future and we should begin right now. Their will be no garantee that no issues and mistakes where done by me here, but it wont be that complicated to fix small issues and I am very experienced by what I'm doing. Max This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] webermaximilian92 commented on issue #3328: Enhancement scss refactoring
webermaximilian92 commented on issue #3328: Enhancement scss refactoring URL: https://github.com/apache/cloudstack/pull/3328#issuecomment-492978827 Hey Daan, thanks for feedback. This is not compareable to jquery update, because it's not an upgrade of any Framework Version. Final CSS keeps CSS. It's an refactoring of old technology. I didn't changed the code at all here but I generated a way to better work with it. The CSS script is full of redundant and outdated rules. We need to fix that anytime in future and we should begin right now. Their will be no garantee that no issues and mistakes where done by me here, but it wont be that complicated to fix small issues and I am very experienced by what I'm doing. Max This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3328: Enhancement scss refactoring
DaanHoogland commented on issue #3328: Enhancement scss refactoring URL: https://github.com/apache/cloudstack/pull/3328#issuecomment-492966849 I'm all for this but fear a similar situation like the latest jquery update. Not that we should back down but I'm wondering if there is a reliable way to check _all_ changes here. a visual review of cloudstack3.ccs seems fine. /me not trusting my eyes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3312: 'sed -i' need postfix on mac
DaanHoogland commented on issue #3312: 'sed -i' need postfix on mac URL: https://github.com/apache/cloudstack/pull/3312#issuecomment-492960164 > @DaanHoogland env issue, the sed on OSX is freebsd based I realize that, but it complicates build and thus inhibits people entering the playing field. I would prefer adding the extension, it is in the target dir and doesn't hurt anybody. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3326: Bug fix for zone names not appearing in dashboard
DaanHoogland commented on issue #3326: Bug fix for zone names not appearing in dashboard URL: https://github.com/apache/cloudstack/pull/3326#issuecomment-492959543 @rhtyd shouyldn't this have gone into branches 4.11 and 4.12 as well? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
