[GitHub] [cloudstack] blueorangutan commented on issue #3310: Fix removing static NAT rules with Juniper SRX
blueorangutan commented on issue #3310: Fix removing static NAT rules with Juniper SRX URL: https://github.com/apache/cloudstack/pull/3310#issuecomment-497578554 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3310: Fix removing static NAT rules with Juniper SRX
rhtyd commented on issue #3310: Fix removing static NAT rules with Juniper SRX URL: https://github.com/apache/cloudstack/pull/3310#issuecomment-497578442 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3310: Fix removing static NAT rules with Juniper SRX
blueorangutan commented on issue #3310: Fix removing static NAT rules with Juniper SRX URL: https://github.com/apache/cloudstack/pull/3310#issuecomment-497578371 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2821 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-497575969 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
rhtyd commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-497575874 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd removed a comment on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
rhtyd removed a comment on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-497478665 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
blueorangutan removed a comment on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-497478731 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
blueorangutan removed a comment on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-497539452 Trillian test result (tid-3620) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 14470 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3248-t3620-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 52 look OK, 22 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 28.06 | test_internal_lb.py test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 0.02 | test_internal_lb.py test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 28.93 | test_internal_lb.py test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 0.04 | test_internal_lb.py test_04_rvpc_privategw_static_routes | `Error` | 0.44 | test_privategw_acl.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py test_01_so_removal_resource_update | `Error` | 1.26 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py test_02_routervm_iptables_policies | `Error` | 1.19 | test_routers_iptables_default_policy.py test_01_single_VPC_iptables_policies | `Error` | 5.26 | test_routers_iptables_default_policy.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 1.28 | test_routers_network_ops.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 1.28 | test_routers_network_ops.py test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Error` | 5.14 | test_routers_network_ops.py test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 5.98 | test_routers_network_ops.py test_03_RVR_Network_check_router_state | `Error` | 6.00 | test_routers_network_ops.py test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py test_02_list_cpvm_vm | `Failure` | 0.02 | test_ssvm.py test_03_ssvm_internals | `Failure` | 0.02 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.03 | test_ssvm.py test_05_stop_ssvm | `Failure` | 0.02 | test_ssvm.py test_06_stop_cpvm | `Failure` | 0.02 | test_ssvm.py test_07_reboot_ssvm | `Failure` | 0.02 | test_ssvm.py test_08_reboot_cpvm | `Failure` | 0.02 | test_ssvm.py test_09_destroy_ssvm | `Failure` | 0.02 | test_ssvm.py test_10_destroy_cpvm | `Failure` | 0.02 | test_ssvm.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py test_01_sys_vm_start | `Failure` | 0.07 | test_secondary_storage.py ContextSuite
[cloudstack] branch 4.11 updated: vmware: fix potential NPE when memory hotplug capability is checked (#3362)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.11 by this push:
new 8c387f9 vmware: fix potential NPE when memory hotplug capability is
checked (#3362)
8c387f9 is described below
commit 8c387f9de6d76cfa983b6fa7f39b2e9df4be4266
Author: Rohit Yadav
AuthorDate: Fri May 31 10:27:36 2019 +0530
vmware: fix potential NPE when memory hotplug capability is checked (#3362)
This fixes potential NPE case when memory hotpluggability is checked
based on the guest OS descriptor.
Signed-off-by: Rohit Yadav
---
vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
b/vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
index b700b6d..1ab325b 100644
--- a/vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
+++ b/vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
@@ -3281,7 +3281,7 @@ public class VirtualMachineMO extends BaseMO {
virtualHardwareVersion = getVirtualHardwareVersion();
// Check if guest operating system supports memory hotadd
-if (guestOsDescriptor.isSupportsMemoryHotAdd()) {
+if (guestOsDescriptor != null &&
guestOsDescriptor.isSupportsMemoryHotAdd()) {
guestOsSupportsMemoryHotAdd = true;
}
// Check if virtual machine is using hardware version 7 or later.
[GitHub] [cloudstack] rhtyd merged pull request #3362: vmware: fix potential NPE when memory hotplug capability is checked
rhtyd merged pull request #3362: vmware: fix potential NPE when memory hotplug capability is checked URL: https://github.com/apache/cloudstack/pull/3362 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3313: Simulator: Better VR Redundant Status Behaviour
rhtyd commented on issue #3313: Simulator: Better VR Redundant Status Behaviour URL: https://github.com/apache/cloudstack/pull/3313#issuecomment-497575045 Smoketests are not necessary as changes are purely in simulator, Travis tests should be enough to merge this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3310: Fix removing static NAT rules with Juniper SRX
blueorangutan commented on issue #3310: Fix removing static NAT rules with Juniper SRX URL: https://github.com/apache/cloudstack/pull/3310#issuecomment-497574822 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd removed a comment on issue #3310: Fix removing static NAT rules with Juniper SRX
rhtyd removed a comment on issue #3310: Fix removing static NAT rules with Juniper SRX URL: https://github.com/apache/cloudstack/pull/3310#issuecomment-496239418 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3310: Fix removing static NAT rules with Juniper SRX
rhtyd commented on issue #3310: Fix removing static NAT rules with Juniper SRX URL: https://github.com/apache/cloudstack/pull/3310#issuecomment-497574659 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd merged pull request #3356: Increase POST timeout for local template upload
rhtyd merged pull request #3356: Increase POST timeout for local template upload URL: https://github.com/apache/cloudstack/pull/3356 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: server: increase POST timeout for local template upload (#3356)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new fd4309c server: increase POST timeout for local template upload
(#3356)
fd4309c is described below
commit fd4309cc3dc3c001a9cf77d89250af648158b5f0
Author: Andrija Panic <45762285+andrijapani...@users.noreply.github.com>
AuthorDate: Fri May 31 06:02:59 2019 +0200
server: increase POST timeout for local template upload (#3356)
Increase template upload POST timeout for local template upload to 1 hr or
60 minutes.
---
server/src/main/java/com/cloud/storage/ImageStoreUploadMonitorImpl.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/server/src/main/java/com/cloud/storage/ImageStoreUploadMonitorImpl.java
b/server/src/main/java/com/cloud/storage/ImageStoreUploadMonitorImpl.java
index 10406b5..b5ee6b5 100755
--- a/server/src/main/java/com/cloud/storage/ImageStoreUploadMonitorImpl.java
+++ b/server/src/main/java/com/cloud/storage/ImageStoreUploadMonitorImpl.java
@@ -110,7 +110,7 @@ public class ImageStoreUploadMonitorImpl extends
ManagerBase implements ImageSto
static final ConfigKey UploadMonitoringInterval = new
ConfigKey("Advanced", Integer.class, "upload.monitoring.interval",
"60",
"Interval (in seconds) to check the status of volumes that are
uploaded using HTTP POST request", true);
-static final ConfigKey UploadOperationTimeout = new
ConfigKey("Advanced", Integer.class, "upload.operation.timeout", "10",
+static final ConfigKey UploadOperationTimeout = new
ConfigKey("Advanced", Integer.class, "upload.operation.timeout", "60",
"Time (in minutes) to wait before abandoning volume upload using
HTTP POST request", true);
@Override
[GitHub] [cloudstack] blueorangutan commented on issue #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs
blueorangutan commented on issue #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs URL: https://github.com/apache/cloudstack/pull/3344#issuecomment-497552152 Trillian test result (tid-3615) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33096 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3344-t3615-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Smoke tests completed. 70 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3356: Increase POST timeout for local template upload
blueorangutan commented on issue #3356: Increase POST timeout for local template upload URL: https://github.com/apache/cloudstack/pull/3356#issuecomment-497551807 Trillian test result (tid-3617) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 29171 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3356-t3617-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Smoke tests completed. 70 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193)
blueorangutan commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193) URL: https://github.com/apache/cloudstack/pull/3194#issuecomment-497551557 Trillian test result (tid-3618) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28889 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3194-t3618-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 67 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_hostha_enable_ha_when_host_disabled | `Error` | 0.64 | test_hostha_kvm.py test_hostha_enable_ha_when_host_disconected | `Error` | 936.12 | test_hostha_kvm.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 302.81 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #2983: WIP: KVM live storage migration intra cluster from NFS source and destination
nvazquez commented on issue #2983: WIP: KVM live storage migration intra cluster from NFS source and destination URL: https://github.com/apache/cloudstack/pull/2983#issuecomment-497549793 Yes @rhtyd I'll address this tomorrow This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez opened a new pull request #3251: Add local ISO upload via UI
nvazquez opened a new pull request #3251: Add local ISO upload via UI URL: https://github.com/apache/cloudstack/pull/3251 ## Description **Problem:** Users can register ISOs from URL but cannot upload local ISOs. **Root cause:** CloudStack provides browser-based upload support for volumes and templates, but ISOs are not supported. **Solution:** The existing browser-based upload from local functionality for templates and volumes (https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=39620237) is extended to support uploading local ISOs. - Extend the UI: A new button is created under the ISOs view: 'Upload from Local'. A new dialog form is displayed in which the user must select the ISO to upload from its local file system. - Extend the API: New 'GetUploadParamsForIso' API command is created to handle the ISO upload. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate):   ## How Has This Been Tested? Templates tab -> ISOs -> Upload from local -> Select file on local file system This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez closed pull request #3251: Add local ISO upload via UI
nvazquez closed pull request #3251: Add local ISO upload via UI URL: https://github.com/apache/cloudstack/pull/3251 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on a change in pull request #3351: [WIP: DO NOT MERGE] Have persistent DHCP leases file on VRs and cleanup /etc/hosts on VM deletion
nvazquez commented on a change in pull request #3351: [WIP: DO NOT MERGE] Have
persistent DHCP leases file on VRs and cleanup /etc/hosts on VM deletion
URL: https://github.com/apache/cloudstack/pull/3351#discussion_r289235734
##
File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
##
@@ -114,8 +114,23 @@ def configure_server(self):
idx += 1
def delete_leases(self):
+macs_dhcphosts = []
try:
-open(LEASES, 'w').close()
+logging.info("Attempting to delete entries from dnsmasq.leases
file for VMs which are not on dhcphosts file")
+for host in open(DHCP_HOSTS):
+macs_dhcphosts.append(host.split(',')[0])
+
+removed = 0
+for leaseline in open(LEASES):
+lease = leaseline.split(' ')
+mac = lease[1]
+ip = lease[2]
+if mac not in macs_dhcphosts:
+cmd = "dhcp_release %s %s" % (ip, mac)
Review comment:
Thanks I'll fix this
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text
blueorangutan commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text URL: https://github.com/apache/cloudstack/pull/3240#issuecomment-497547465 Trillian test result (tid-3614) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31444 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3240-t3614-kvm-centos7.zip Smoke tests completed. 70 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-497539452 Trillian test result (tid-3620) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 14470 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3248-t3620-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 52 look OK, 22 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 28.06 | test_internal_lb.py test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 0.02 | test_internal_lb.py test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 28.93 | test_internal_lb.py test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 0.04 | test_internal_lb.py test_04_rvpc_privategw_static_routes | `Error` | 0.44 | test_privategw_acl.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py test_01_so_removal_resource_update | `Error` | 1.26 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py test_02_routervm_iptables_policies | `Error` | 1.19 | test_routers_iptables_default_policy.py test_01_single_VPC_iptables_policies | `Error` | 5.26 | test_routers_iptables_default_policy.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 1.28 | test_routers_network_ops.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 1.28 | test_routers_network_ops.py test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Error` | 5.14 | test_routers_network_ops.py test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 5.98 | test_routers_network_ops.py test_03_RVR_Network_check_router_state | `Error` | 6.00 | test_routers_network_ops.py test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py test_02_list_cpvm_vm | `Failure` | 0.02 | test_ssvm.py test_03_ssvm_internals | `Failure` | 0.02 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.03 | test_ssvm.py test_05_stop_ssvm | `Failure` | 0.02 | test_ssvm.py test_06_stop_cpvm | `Failure` | 0.02 | test_ssvm.py test_07_reboot_ssvm | `Failure` | 0.02 | test_ssvm.py test_08_reboot_cpvm | `Failure` | 0.02 | test_ssvm.py test_09_destroy_ssvm | `Failure` | 0.02 | test_ssvm.py test_10_destroy_cpvm | `Failure` | 0.02 | test_ssvm.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py test_01_sys_vm_start | `Failure` | 0.07 | test_secondary_storage.py ContextSuite
[GitHub] [cloudstack] blueorangutan commented on issue #3365: DPDK live migrations
blueorangutan commented on issue #3365: DPDK live migrations URL: https://github.com/apache/cloudstack/pull/3365#issuecomment-497509252 Trillian test result (tid-3616) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 17727 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3365-t3616-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 50 look OK, 20 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py test_01_so_removal_resource_update | `Error` | 1.42 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py test_02_routervm_iptables_policies | `Error` | 1.30 | test_routers_iptables_default_policy.py test_01_single_VPC_iptables_policies | `Error` | 4.40 | test_routers_iptables_default_policy.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 1.38 | test_routers_network_ops.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 1.40 | test_routers_network_ops.py test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Error` | 6.24 | test_routers_network_ops.py test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 5.98 | test_routers_network_ops.py test_03_RVR_Network_check_router_state | `Error` | 6.00 | test_routers_network_ops.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py test_01_sys_vm_start | `Failure` | 0.14 | test_secondary_storage.py ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 2.26 | test_service_offerings.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py test_01_list_sec_storage_vm | `Failure` | 0.04 | test_ssvm.py test_02_list_cpvm_vm | `Failure` | 0.04 | test_ssvm.py test_03_ssvm_internals | `Failure` | 0.04 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.05 | test_ssvm.py test_05_stop_ssvm | `Failure` | 0.04 | test_ssvm.py test_06_stop_cpvm | `Failure` | 0.04 | test_ssvm.py test_07_reboot_ssvm
[GitHub] [cloudstack] blueorangutan commented on issue #3365: DPDK live migrations
blueorangutan commented on issue #3365: DPDK live migrations URL: https://github.com/apache/cloudstack/pull/3365#issuecomment-497508849 Trillian test result (tid-3613) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32361 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3365-t3613-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 70 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-497478731 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
rhtyd commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-497478665 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193)
ustcweizhou commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193) URL: https://github.com/apache/cloudstack/pull/3194#issuecomment-497472821 code lgtm, tested ok. can you also add some information as part of this change to inform cloudstack/kvm users in api and on ui that vm will be suspended and resumed when take or remove a vm snapshot? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-497444047 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2820 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #2995: KVM: Improvements on upload direct download certificates
blueorangutan commented on issue #2995: KVM: Improvements on upload direct download certificates URL: https://github.com/apache/cloudstack/pull/2995#issuecomment-497443742 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2819 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on a change in pull request #2995: KVM: Improvements on upload direct download certificates
nvazquez commented on a change in pull request #2995: KVM: Improvements on
upload direct download certificates
URL: https://github.com/apache/cloudstack/pull/2995#discussion_r289120201
##
File path: agent/src/com/cloud/agent/Agent.java
##
@@ -685,31 +682,6 @@ protected void processRequest(final Request request,
final Link link) {
}
}
-private Answer
setupDirectDownloadCertificate(SetupDirectDownloadCertificate cmd) {
Review comment:
Yes, but moved to specific KVM code. Let me update the description
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rafaelweingartner commented on a change in pull request #2995: KVM: Improvements on upload direct download certificates
rafaelweingartner commented on a change in pull request #2995: KVM:
Improvements on upload direct download certificates
URL: https://github.com/apache/cloudstack/pull/2995#discussion_r289114876
##
File path: agent/src/com/cloud/agent/Agent.java
##
@@ -685,31 +682,6 @@ protected void processRequest(final Request request,
final Link link) {
}
}
-private Answer
setupDirectDownloadCertificate(SetupDirectDownloadCertificate cmd) {
Review comment:
So, this is not used anymore?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rafaelweingartner commented on issue #3294: Set default service offering over api and ui
rafaelweingartner commented on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-497434366 @pbankonier and @svenvogel thanks for the PR and your valuable contributions. I have read the discussions, but still, have a question here. What does this change mean for the current method we have to override/change the default service offerings for system VMs? I mean, currently we have the following configurations available: * consoleproxy.service.offering * internallbvm.service.offering * secstorage.service.offering I do understand that you are introduced a method to change these default for other types of VMs, such as VRs, but still, how will this play out for people that are already used to use the current global settings parameters to configure the service offering for console proxy, ssvm, and internal LB VM? I do like the UI change you are proposing, but I see that it can be implemented with the same backend we have. Of course, you are now supporting the override for other types of system VMs as well, but I guess that we could just use the "standard" we have currently in place. Now, if the proposal is to change this "standard", then we need to create/propose a migration path for people. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez opened a new pull request #3251: Add local ISO upload via UI
nvazquez opened a new pull request #3251: Add local ISO upload via UI URL: https://github.com/apache/cloudstack/pull/3251 ## Description **Problem:** Users can register ISOs from URL but cannot upload local ISOs. **Root cause:** CloudStack provides browser-based upload support for volumes and templates, but ISOs are not supported. **Solution:** The existing browser-based upload from local functionality for templates and volumes (https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=39620237) is extended to support uploading local ISOs. - Extend the UI: A new button is created under the ISOs view: 'Upload from Local'. A new dialog form is displayed in which the user must select the ISO to upload from its local file system. - Extend the API: New 'GetUploadParamsForIso' API command is created to handle the ISO upload. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate):   ## How Has This Been Tested? Templates tab -> ISOs -> Upload from local -> Select file on local file system This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez closed pull request #3251: Add local ISO upload via UI
nvazquez closed pull request #3251: Add local ISO upload via UI URL: https://github.com/apache/cloudstack/pull/3251 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3251: Add local ISO upload via UI
nvazquez commented on issue #3251: Add local ISO upload via UI URL: https://github.com/apache/cloudstack/pull/3251#issuecomment-497433564 Thanks @borisstoyanov @rhtyd, I'll close/open to re-kick Travis This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-497431486 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
rhtyd commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-497431302 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
blueorangutan removed a comment on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-497369776 Trillian test result (tid-3611) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 15124 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3248-t3611-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 52 look OK, 22 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 29.27 | test_internal_lb.py test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 0.04 | test_internal_lb.py test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 28.09 | test_internal_lb.py test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 0.02 | test_internal_lb.py test_04_rvpc_privategw_static_routes | `Error` | 0.45 | test_privategw_acl.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py test_01_so_removal_resource_update | `Error` | 1.26 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py test_02_routervm_iptables_policies | `Error` | 1.18 | test_routers_iptables_default_policy.py test_01_single_VPC_iptables_policies | `Error` | 5.27 | test_routers_iptables_default_policy.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 1.29 | test_routers_network_ops.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 1.28 | test_routers_network_ops.py test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Error` | 5.17 | test_routers_network_ops.py test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 6.00 | test_routers_network_ops.py test_03_RVR_Network_check_router_state | `Error` | 5.99 | test_routers_network_ops.py test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py test_02_list_cpvm_vm | `Failure` | 0.02 | test_ssvm.py test_03_ssvm_internals | `Failure` | 0.02 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.02 | test_ssvm.py test_05_stop_ssvm | `Failure` | 0.02 | test_ssvm.py test_06_stop_cpvm | `Failure` | 0.02 | test_ssvm.py test_07_reboot_ssvm | `Failure` | 0.02 | test_ssvm.py test_08_reboot_cpvm | `Failure` | 0.02 | test_ssvm.py test_09_destroy_ssvm | `Failure` | 0.03 | test_ssvm.py test_10_destroy_cpvm | `Failure` | 0.02 | test_ssvm.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py test_01_sys_vm_start | `Failure` | 0.07 | test_secondary_storage.py ContextSuite
[GitHub] [cloudstack] blueorangutan commented on issue #3206: server: allow dedicate ip range to a domain if ips are used by an account in the domain
blueorangutan commented on issue #3206: server: allow dedicate ip range to a domain if ips are used by an account in the domain URL: https://github.com/apache/cloudstack/pull/3206#issuecomment-497429586 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3206: server: allow dedicate ip range to a domain if ips are used by an account in the domain
rhtyd commented on issue #3206: server: allow dedicate ip range to a domain if ips are used by an account in the domain URL: https://github.com/apache/cloudstack/pull/3206#issuecomment-497429454 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3362: vmware: fix potential NPE when memory hotplug capability is checked
rhtyd commented on issue #3362: vmware: fix potential NPE when memory hotplug capability is checked URL: https://github.com/apache/cloudstack/pull/3362#issuecomment-497429290 Test lgtm, the failures were env related. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #2995: KVM: Improvements on upload direct download certificates
blueorangutan commented on issue #2995: KVM: Improvements on upload direct download certificates URL: https://github.com/apache/cloudstack/pull/2995#issuecomment-497429208 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #2995: KVM: Improvements on upload direct download certificates
rhtyd commented on issue #2995: KVM: Improvements on upload direct download certificates URL: https://github.com/apache/cloudstack/pull/2995#issuecomment-497428978 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3361: Fix 4.11 VR Issues with Multiple Public Subnets
rhtyd commented on issue #3361: Fix 4.11 VR Issues with Multiple Public Subnets URL: https://github.com/apache/cloudstack/pull/3361#issuecomment-497428483 Test lgtm This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3362: vmware: fix potential NPE when memory hotplug capability is checked
blueorangutan commented on issue #3362: vmware: fix potential NPE when memory hotplug capability is checked URL: https://github.com/apache/cloudstack/pull/3362#issuecomment-497424554 Trillian test result (tid-3606) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 37738 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3362-t3606-vmware-65u2.zip Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Smoke tests completed. 65 look OK, 3 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_extract_template | `Failure` | 144.90 | test_templates.py ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py test_06_download_detached_volume | `Failure` | 172.69 | test_volumes.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193)
rhtyd commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193) URL: https://github.com/apache/cloudstack/pull/3194#issuecomment-497421648 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193)
blueorangutan commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193) URL: https://github.com/apache/cloudstack/pull/3194#issuecomment-497421772 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3356: Increase POST timeout for local template upload
blueorangutan commented on issue #3356: Increase POST timeout for local template upload URL: https://github.com/apache/cloudstack/pull/3356#issuecomment-497420717 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3356: Increase POST timeout for local template upload
rhtyd commented on issue #3356: Increase POST timeout for local template upload URL: https://github.com/apache/cloudstack/pull/3356#issuecomment-497420323 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] melnik13 edited a comment on issue #3194: Suspending a VM before snapshot deletion (see PR #3193)
melnik13 edited a comment on issue #3194: Suspending a VM before snapshot deletion (see PR #3193) URL: https://github.com/apache/cloudstack/pull/3194#issuecomment-497418473 @Slair1 > Here is a link to an article talking about not using qemu-img to take snapshots of running VMs (there are lots of other posts/pages agreeing). > https://www.cyberciti.biz/faq/how-to-create-create-snapshot-in-linux-kvm-vmdomain/ > Should we be suspending the VM before taking the snapshot? Is suspending enough to prevent corruption or is it just "safer"? We are just very gun shy with snapshots on KVM after experiencing corruption on several VMs... You're absolutely right, but ACS do not use qemu-img to create a snapshot of a running instance. It runs qemu-img only if the instance is stopped, but for the running one it calls libvirt to perform the job (and libvirt always suspends the VM). The problem occurs when ACS is deleting the snapshot from the running instance's volume. When the deletion procedure is being performed, libvirt doesn't suspend an instance (well, the instance is being frozen somehow, but `virsh list` still shows it as running). As I think, it's not a bug of ACS, as it seems to be a bug of libvirt or QEMU/KVM (by the way, users of Proxmox are facing these issues too), but our workaround (manually suspending the instance before the snapshot deletion) could help us to outflank the problem. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] melnik13 commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193)
melnik13 commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193) URL: https://github.com/apache/cloudstack/pull/3194#issuecomment-497418473 @Slair1 > Here is a link to an article talking about not using qemu-img to take snapshots of running VMs (there are lots of other posts/pages agreeing). > https://www.cyberciti.biz/faq/how-to-create-create-snapshot-in-linux-kvm-vmdomain/ > Should we be suspending the VM before taking the snapshot? Is suspending enough to prevent corruption or is it just "safer"? We are just very gun shy with snapshots on KVM after experiencing corruption on several VMs... You're absolutely right, but ACS do not use qemu-img to create a snapshot of a running instance. It runs qemu-img only if the instance is stopped, but for the running one it calls libvirt to perform the job (and libvirt always suspends the VM). The problem occurs when ACS is deleting the snapshot from the running instance's volume. When the deletion procedure is being performed, libvirt doesn't suspend an instance (well, the instance is being frozen somehow, but `virsh list` still shows it as running). As I think, it's not a bug of ACS, as it seems to be a bug libvirt of QEMU/KVM (by the way, users of Proxmox are facing these issues too), but our workaround (manually suspending the instance before the snapshot deletion) could help us to outflank the problem. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3205: server: update dhcp configurations in vrs while update default nic of running vms
blueorangutan commented on issue #3205: server: update dhcp configurations in vrs while update default nic of running vms URL: https://github.com/apache/cloudstack/pull/3205#issuecomment-497413887 Trillian test result (tid-3609) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 27949 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3205-t3609-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py Smoke tests completed. 68 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] Slair1 commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193)
Slair1 commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193) URL: https://github.com/apache/cloudstack/pull/3194#issuecomment-497413681 @melnik13 @rhtyd From everything I've been able to find, it isn't supportable to take snapshots of volumes on running VMs w/ KVM. I see in the CloudStack code, this functionality is also disabled by default with "kvm.snapshot.enabled" set to false by default. The code does however allow snapshots if VMs are stopped or the volume is detached. Here is a link to an article talking about not using qemu-img to take snapshots of running VMs (there are lots of other posts/pages agreeing). https://www.cyberciti.biz/faq/how-to-create-create-snapshot-in-linux-kvm-vmdomain/ Should we be suspending the VM before taking the snapshot? Is suspending enough to prevent corruption or is it just "safer"? We are just very gun shy with snapshots on KVM after experiencing corruption on several VMs... Thanks for any input! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193)
blueorangutan commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193) URL: https://github.com/apache/cloudstack/pull/3194#issuecomment-497410224 Trillian test result (tid-3610) Environment: kvm-centos6 (x2), Advanced Networking with Mgmt server 7 Total time taken: 27219 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3194-t3610-kvm-centos6.zip Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Smoke tests completed. 67 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_service_offering_cpu_limit_use | `Error` | 1.33 | test_service_offerings.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3356: Increase POST timeout for local template upload
blueorangutan commented on issue #3356: Increase POST timeout for local template upload URL: https://github.com/apache/cloudstack/pull/3356#issuecomment-497408016 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2818 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3365: DPDK live migrations
blueorangutan commented on issue #3365: DPDK live migrations URL: https://github.com/apache/cloudstack/pull/3365#issuecomment-497406189 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3365: DPDK live migrations
borisstoyanov commented on issue #3365: DPDK live migrations URL: https://github.com/apache/cloudstack/pull/3365#issuecomment-497406040 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3365: DPDK live migrations
blueorangutan commented on issue #3365: DPDK live migrations URL: https://github.com/apache/cloudstack/pull/3365#issuecomment-497405737 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2817 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3356: Increase POST timeout for local template upload
blueorangutan commented on issue #3356: Increase POST timeout for local template upload URL: https://github.com/apache/cloudstack/pull/3356#issuecomment-497398077 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text
blueorangutan commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text URL: https://github.com/apache/cloudstack/pull/3240#issuecomment-497397776 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs
blueorangutan commented on issue #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs URL: https://github.com/apache/cloudstack/pull/3344#issuecomment-497397792 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3356: Increase POST timeout for local template upload
rhtyd commented on issue #3356: Increase POST timeout for local template upload URL: https://github.com/apache/cloudstack/pull/3356#issuecomment-497397817 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text
rhtyd commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text URL: https://github.com/apache/cloudstack/pull/3240#issuecomment-497397703 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs
rhtyd commented on issue #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs URL: https://github.com/apache/cloudstack/pull/3344#issuecomment-497397568 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3365: DPDK live migrations
blueorangutan commented on issue #3365: DPDK live migrations URL: https://github.com/apache/cloudstack/pull/3365#issuecomment-497394061 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3365: DPDK live migrations
borisstoyanov commented on issue #3365: DPDK live migrations URL: https://github.com/apache/cloudstack/pull/3365#issuecomment-497393842 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3361: Fix 4.11 VR Issues with Multiple Public Subnets
blueorangutan commented on issue #3361: Fix 4.11 VR Issues with Multiple Public Subnets URL: https://github.com/apache/cloudstack/pull/3361#issuecomment-497385617 Trillian test result (tid-3605) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32275 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3361-t3605-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 68 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-497369776 Trillian test result (tid-3611) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 15124 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3248-t3611-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 52 look OK, 22 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 29.27 | test_internal_lb.py test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 0.04 | test_internal_lb.py test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 28.09 | test_internal_lb.py test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 0.02 | test_internal_lb.py test_04_rvpc_privategw_static_routes | `Error` | 0.45 | test_privategw_acl.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py test_01_so_removal_resource_update | `Error` | 1.26 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py test_02_routervm_iptables_policies | `Error` | 1.18 | test_routers_iptables_default_policy.py test_01_single_VPC_iptables_policies | `Error` | 5.27 | test_routers_iptables_default_policy.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 1.29 | test_routers_network_ops.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 1.28 | test_routers_network_ops.py test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Error` | 5.17 | test_routers_network_ops.py test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 6.00 | test_routers_network_ops.py test_03_RVR_Network_check_router_state | `Error` | 5.99 | test_routers_network_ops.py test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py test_02_list_cpvm_vm | `Failure` | 0.02 | test_ssvm.py test_03_ssvm_internals | `Failure` | 0.02 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.02 | test_ssvm.py test_05_stop_ssvm | `Failure` | 0.02 | test_ssvm.py test_06_stop_cpvm | `Failure` | 0.02 | test_ssvm.py test_07_reboot_ssvm | `Failure` | 0.02 | test_ssvm.py test_08_reboot_cpvm | `Failure` | 0.02 | test_ssvm.py test_09_destroy_ssvm | `Failure` | 0.03 | test_ssvm.py test_10_destroy_cpvm | `Failure` | 0.02 | test_ssvm.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py test_01_sys_vm_start | `Failure` | 0.07 | test_secondary_storage.py ContextSuite
[GitHub] [cloudstack] blueorangutan commented on issue #3338: ui: fix enable static nat only towards first nic and not on any other interface
blueorangutan commented on issue #3338: ui: fix enable static nat only towards first nic and not on any other interface URL: https://github.com/apache/cloudstack/pull/3338#issuecomment-497367646 Trillian test result (tid-3604) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31644 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3338-t3604-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 68 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3365: DPDK live migrations
blueorangutan commented on issue #3365: DPDK live migrations URL: https://github.com/apache/cloudstack/pull/3365#issuecomment-497321624 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3365: DPDK live migrations
borisstoyanov commented on issue #3365: DPDK live migrations URL: https://github.com/apache/cloudstack/pull/3365#issuecomment-497321516 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3365: DPDK live migrations
blueorangutan commented on issue #3365: DPDK live migrations URL: https://github.com/apache/cloudstack/pull/3365#issuecomment-497321425 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2816 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez opened a new pull request #3365: DPDK live migrations
nvazquez opened a new pull request #3365: DPDK live migrations URL: https://github.com/apache/cloudstack/pull/3365 ## Description Allow DPDK live migrations ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3365: DPDK live migrations
borisstoyanov commented on issue #3365: DPDK live migrations URL: https://github.com/apache/cloudstack/pull/3365#issuecomment-497315901 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3365: DPDK live migrations
blueorangutan commented on issue #3365: DPDK live migrations URL: https://github.com/apache/cloudstack/pull/3365#issuecomment-497316039 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3242: [WIP DO NOT MERGE] server: add support for sorting zones in UI/API
blueorangutan commented on issue #3242: [WIP DO NOT MERGE] server: add support for sorting zones in UI/API URL: https://github.com/apache/cloudstack/pull/3242#issuecomment-497309103 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2814 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs
blueorangutan commented on issue #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs URL: https://github.com/apache/cloudstack/pull/3344#issuecomment-497309102 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2815 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text
blueorangutan commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text URL: https://github.com/apache/cloudstack/pull/3240#issuecomment-497308729 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2813 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3356: Increase POST timeout for local template upload
blueorangutan commented on issue #3356: Increase POST timeout for local template upload URL: https://github.com/apache/cloudstack/pull/3356#issuecomment-497307980 Packaging result: ✔centos6 ✖centos7 ✔debian. JID-2812 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr commented on a change in pull request #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
shwstppr commented on a change in pull request #3248: [WIP DO NOT MERGE]
server: offerings for specified domain(s) and zone(s)
URL: https://github.com/apache/cloudstack/pull/3248#discussion_r288954966
##
File path: server/src/main/java/com/cloud/acl/DomainChecker.java
##
@@ -167,81 +182,155 @@ public boolean checkAccess(User user, ControlledEntity
entity) throws Permission
}
@Override
-public boolean checkAccess(Account account, DiskOffering dof) throws
PermissionDeniedException {
-if (account == null || dof == null || dof.getDomainId() == null)
{//public offering
-return true;
+public boolean checkAccess(Account account, DiskOffering dof, DataCenter
zone) throws PermissionDeniedException {
+boolean isAccess = false;
+// Check fo domains
+if (account == null || dof == null) {
+isAccess = true;
} else {
//admin has all permissions
if (_accountService.isRootAdmin(account.getId())) {
-return true;
+isAccess = true;
}
//if account is normal user or domain admin
-//check if account's domain is a child of zone's domain (Note:
This is made consistent with the list command for disk offering)
+//check if account's domain is a child of offering's domain (Note:
This is made consistent with the list command for disk offering)
else if (_accountService.isNormalUser(account.getId())
|| account.getType() ==
Account.ACCOUNT_TYPE_RESOURCE_DOMAIN_ADMIN
|| _accountService.isDomainAdmin(account.getId())
|| account.getType() == Account.ACCOUNT_TYPE_PROJECT) {
-if (account.getDomainId() == dof.getDomainId()) {
-return true; //disk offering and account at exact node
+final List doDomainIds =
diskOfferingDetailsDao.findDomainIds(dof.getId());
+if (doDomainIds.isEmpty()) {
+isAccess = true;
} else {
-Domain domainRecord =
_domainDao.findById(account.getDomainId());
-if (domainRecord != null) {
-while (true) {
-if (domainRecord.getId() == dof.getDomainId()) {
-//found as a child
-return true;
-}
-if (domainRecord.getParent() != null) {
-domainRecord =
_domainDao.findById(domainRecord.getParent());
-} else {
-break;
-}
+for (Long domainId : doDomainIds) {
+if (_domainDao.isChildDomain(domainId,
account.getDomainId())) {
+isAccess = true;
+break;
}
}
}
}
}
-//not found
-return false;
+// Check for zones
+if (isAccess && dof != null && zone != null) {
+final List doZoneIds =
diskOfferingDetailsDao.findZoneIds(dof.getId());
+isAccess = doZoneIds.isEmpty() || doZoneIds.contains(zone.getId());
+}
+return isAccess;
}
@Override
-public boolean checkAccess(Account account, ServiceOffering so) throws
PermissionDeniedException {
-if (account == null || so.getDomainId() == null) {//public offering
-return true;
+public boolean checkAccess(Account account, ServiceOffering so, DataCenter
zone) throws PermissionDeniedException {
+boolean isAccess = false;
+// Check fo domains
+if (account == null || so == null) {
+isAccess = true;
} else {
//admin has all permissions
if (_accountService.isRootAdmin(account.getId())) {
-return true;
+isAccess = true;
}
//if account is normal user or domain admin
-//check if account's domain is a child of zone's domain (Note:
This is made consistent with the list command for service offering)
+//check if account's domain is a child of offering's domain (Note:
This is made consistent with the list command for service offering)
else if (_accountService.isNormalUser(account.getId())
|| account.getType() ==
Account.ACCOUNT_TYPE_RESOURCE_DOMAIN_ADMIN
|| _accountService.isDomainAdmin(account.getId())
|| account.getType() == Account.ACCOUNT_TYPE_PROJECT) {
-if (account.getDomainId() == so.getDomainId()) {
-return true; //service offering and account at exact node
+final List soDomainIds =
[GitHub] [cloudstack] shwstppr commented on a change in pull request #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
shwstppr commented on a change in pull request #3248: [WIP DO NOT MERGE]
server: offerings for specified domain(s) and zone(s)
URL: https://github.com/apache/cloudstack/pull/3248#discussion_r288954853
##
File path: server/src/main/java/com/cloud/acl/DomainChecker.java
##
@@ -167,81 +182,155 @@ public boolean checkAccess(User user, ControlledEntity
entity) throws Permission
}
@Override
-public boolean checkAccess(Account account, DiskOffering dof) throws
PermissionDeniedException {
-if (account == null || dof == null || dof.getDomainId() == null)
{//public offering
-return true;
+public boolean checkAccess(Account account, DiskOffering dof, DataCenter
zone) throws PermissionDeniedException {
+boolean isAccess = false;
+// Check fo domains
+if (account == null || dof == null) {
+isAccess = true;
} else {
//admin has all permissions
if (_accountService.isRootAdmin(account.getId())) {
-return true;
+isAccess = true;
}
//if account is normal user or domain admin
-//check if account's domain is a child of zone's domain (Note:
This is made consistent with the list command for disk offering)
+//check if account's domain is a child of offering's domain (Note:
This is made consistent with the list command for disk offering)
else if (_accountService.isNormalUser(account.getId())
|| account.getType() ==
Account.ACCOUNT_TYPE_RESOURCE_DOMAIN_ADMIN
|| _accountService.isDomainAdmin(account.getId())
|| account.getType() == Account.ACCOUNT_TYPE_PROJECT) {
-if (account.getDomainId() == dof.getDomainId()) {
-return true; //disk offering and account at exact node
+final List doDomainIds =
diskOfferingDetailsDao.findDomainIds(dof.getId());
+if (doDomainIds.isEmpty()) {
+isAccess = true;
} else {
-Domain domainRecord =
_domainDao.findById(account.getDomainId());
-if (domainRecord != null) {
-while (true) {
-if (domainRecord.getId() == dof.getDomainId()) {
-//found as a child
-return true;
-}
-if (domainRecord.getParent() != null) {
-domainRecord =
_domainDao.findById(domainRecord.getParent());
-} else {
-break;
-}
+for (Long domainId : doDomainIds) {
+if (_domainDao.isChildDomain(domainId,
account.getDomainId())) {
+isAccess = true;
+break;
}
}
}
}
}
-//not found
-return false;
+// Check for zones
+if (isAccess && dof != null && zone != null) {
+final List doZoneIds =
diskOfferingDetailsDao.findZoneIds(dof.getId());
+isAccess = doZoneIds.isEmpty() || doZoneIds.contains(zone.getId());
+}
+return isAccess;
}
@Override
-public boolean checkAccess(Account account, ServiceOffering so) throws
PermissionDeniedException {
-if (account == null || so.getDomainId() == null) {//public offering
-return true;
+public boolean checkAccess(Account account, ServiceOffering so, DataCenter
zone) throws PermissionDeniedException {
+boolean isAccess = false;
+// Check fo domains
+if (account == null || so == null) {
+isAccess = true;
} else {
//admin has all permissions
if (_accountService.isRootAdmin(account.getId())) {
-return true;
+isAccess = true;
}
//if account is normal user or domain admin
-//check if account's domain is a child of zone's domain (Note:
This is made consistent with the list command for service offering)
+//check if account's domain is a child of offering's domain (Note:
This is made consistent with the list command for service offering)
else if (_accountService.isNormalUser(account.getId())
|| account.getType() ==
Account.ACCOUNT_TYPE_RESOURCE_DOMAIN_ADMIN
|| _accountService.isDomainAdmin(account.getId())
|| account.getType() == Account.ACCOUNT_TYPE_PROJECT) {
-if (account.getDomainId() == so.getDomainId()) {
-return true; //service offering and account at exact node
+final List soDomainIds =
[GitHub] [cloudstack] shwstppr commented on a change in pull request #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
shwstppr commented on a change in pull request #3248: [WIP DO NOT MERGE]
server: offerings for specified domain(s) and zone(s)
URL: https://github.com/apache/cloudstack/pull/3248#discussion_r288954906
##
File path: server/src/main/java/com/cloud/acl/DomainChecker.java
##
@@ -167,81 +182,155 @@ public boolean checkAccess(User user, ControlledEntity
entity) throws Permission
}
@Override
-public boolean checkAccess(Account account, DiskOffering dof) throws
PermissionDeniedException {
-if (account == null || dof == null || dof.getDomainId() == null)
{//public offering
-return true;
+public boolean checkAccess(Account account, DiskOffering dof, DataCenter
zone) throws PermissionDeniedException {
+boolean isAccess = false;
+// Check fo domains
+if (account == null || dof == null) {
+isAccess = true;
} else {
//admin has all permissions
if (_accountService.isRootAdmin(account.getId())) {
-return true;
+isAccess = true;
}
//if account is normal user or domain admin
-//check if account's domain is a child of zone's domain (Note:
This is made consistent with the list command for disk offering)
+//check if account's domain is a child of offering's domain (Note:
This is made consistent with the list command for disk offering)
else if (_accountService.isNormalUser(account.getId())
|| account.getType() ==
Account.ACCOUNT_TYPE_RESOURCE_DOMAIN_ADMIN
|| _accountService.isDomainAdmin(account.getId())
|| account.getType() == Account.ACCOUNT_TYPE_PROJECT) {
-if (account.getDomainId() == dof.getDomainId()) {
-return true; //disk offering and account at exact node
+final List doDomainIds =
diskOfferingDetailsDao.findDomainIds(dof.getId());
+if (doDomainIds.isEmpty()) {
+isAccess = true;
} else {
-Domain domainRecord =
_domainDao.findById(account.getDomainId());
-if (domainRecord != null) {
-while (true) {
-if (domainRecord.getId() == dof.getDomainId()) {
-//found as a child
-return true;
-}
-if (domainRecord.getParent() != null) {
-domainRecord =
_domainDao.findById(domainRecord.getParent());
-} else {
-break;
-}
+for (Long domainId : doDomainIds) {
+if (_domainDao.isChildDomain(domainId,
account.getDomainId())) {
+isAccess = true;
+break;
}
}
}
}
}
-//not found
-return false;
+// Check for zones
+if (isAccess && dof != null && zone != null) {
+final List doZoneIds =
diskOfferingDetailsDao.findZoneIds(dof.getId());
+isAccess = doZoneIds.isEmpty() || doZoneIds.contains(zone.getId());
+}
+return isAccess;
}
@Override
-public boolean checkAccess(Account account, ServiceOffering so) throws
PermissionDeniedException {
-if (account == null || so.getDomainId() == null) {//public offering
-return true;
+public boolean checkAccess(Account account, ServiceOffering so, DataCenter
zone) throws PermissionDeniedException {
+boolean isAccess = false;
+// Check fo domains
+if (account == null || so == null) {
+isAccess = true;
} else {
//admin has all permissions
if (_accountService.isRootAdmin(account.getId())) {
-return true;
+isAccess = true;
}
//if account is normal user or domain admin
-//check if account's domain is a child of zone's domain (Note:
This is made consistent with the list command for service offering)
+//check if account's domain is a child of offering's domain (Note:
This is made consistent with the list command for service offering)
else if (_accountService.isNormalUser(account.getId())
|| account.getType() ==
Account.ACCOUNT_TYPE_RESOURCE_DOMAIN_ADMIN
|| _accountService.isDomainAdmin(account.getId())
|| account.getType() == Account.ACCOUNT_TYPE_PROJECT) {
-if (account.getDomainId() == so.getDomainId()) {
-return true; //service offering and account at exact node
+final List soDomainIds =
[GitHub] [cloudstack] shwstppr commented on a change in pull request #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
shwstppr commented on a change in pull request #3248: [WIP DO NOT MERGE]
server: offerings for specified domain(s) and zone(s)
URL: https://github.com/apache/cloudstack/pull/3248#discussion_r288954822
##
File path: server/src/main/java/com/cloud/acl/DomainChecker.java
##
@@ -167,81 +182,155 @@ public boolean checkAccess(User user, ControlledEntity
entity) throws Permission
}
@Override
-public boolean checkAccess(Account account, DiskOffering dof) throws
PermissionDeniedException {
-if (account == null || dof == null || dof.getDomainId() == null)
{//public offering
-return true;
+public boolean checkAccess(Account account, DiskOffering dof, DataCenter
zone) throws PermissionDeniedException {
+boolean isAccess = false;
+// Check fo domains
+if (account == null || dof == null) {
+isAccess = true;
} else {
//admin has all permissions
if (_accountService.isRootAdmin(account.getId())) {
-return true;
+isAccess = true;
}
//if account is normal user or domain admin
-//check if account's domain is a child of zone's domain (Note:
This is made consistent with the list command for disk offering)
+//check if account's domain is a child of offering's domain (Note:
This is made consistent with the list command for disk offering)
else if (_accountService.isNormalUser(account.getId())
|| account.getType() ==
Account.ACCOUNT_TYPE_RESOURCE_DOMAIN_ADMIN
|| _accountService.isDomainAdmin(account.getId())
|| account.getType() == Account.ACCOUNT_TYPE_PROJECT) {
-if (account.getDomainId() == dof.getDomainId()) {
-return true; //disk offering and account at exact node
+final List doDomainIds =
diskOfferingDetailsDao.findDomainIds(dof.getId());
+if (doDomainIds.isEmpty()) {
+isAccess = true;
} else {
-Domain domainRecord =
_domainDao.findById(account.getDomainId());
-if (domainRecord != null) {
-while (true) {
-if (domainRecord.getId() == dof.getDomainId()) {
-//found as a child
-return true;
-}
-if (domainRecord.getParent() != null) {
-domainRecord =
_domainDao.findById(domainRecord.getParent());
-} else {
-break;
-}
+for (Long domainId : doDomainIds) {
+if (_domainDao.isChildDomain(domainId,
account.getDomainId())) {
+isAccess = true;
+break;
}
}
}
}
}
-//not found
-return false;
+// Check for zones
+if (isAccess && dof != null && zone != null) {
+final List doZoneIds =
diskOfferingDetailsDao.findZoneIds(dof.getId());
+isAccess = doZoneIds.isEmpty() || doZoneIds.contains(zone.getId());
+}
+return isAccess;
}
@Override
-public boolean checkAccess(Account account, ServiceOffering so) throws
PermissionDeniedException {
-if (account == null || so.getDomainId() == null) {//public offering
-return true;
+public boolean checkAccess(Account account, ServiceOffering so, DataCenter
zone) throws PermissionDeniedException {
+boolean isAccess = false;
+// Check fo domains
+if (account == null || so == null) {
+isAccess = true;
} else {
//admin has all permissions
if (_accountService.isRootAdmin(account.getId())) {
-return true;
+isAccess = true;
}
//if account is normal user or domain admin
-//check if account's domain is a child of zone's domain (Note:
This is made consistent with the list command for service offering)
+//check if account's domain is a child of offering's domain (Note:
This is made consistent with the list command for service offering)
else if (_accountService.isNormalUser(account.getId())
|| account.getType() ==
Account.ACCOUNT_TYPE_RESOURCE_DOMAIN_ADMIN
|| _accountService.isDomainAdmin(account.getId())
|| account.getType() == Account.ACCOUNT_TYPE_PROJECT) {
-if (account.getDomainId() == so.getDomainId()) {
-return true; //service offering and account at exact node
+final List soDomainIds =
[GitHub] [cloudstack] shwstppr commented on a change in pull request #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
shwstppr commented on a change in pull request #3248: [WIP DO NOT MERGE]
server: offerings for specified domain(s) and zone(s)
URL: https://github.com/apache/cloudstack/pull/3248#discussion_r288954646
##
File path: server/src/main/java/com/cloud/acl/DomainChecker.java
##
@@ -167,81 +182,155 @@ public boolean checkAccess(User user, ControlledEntity
entity) throws Permission
}
@Override
-public boolean checkAccess(Account account, DiskOffering dof) throws
PermissionDeniedException {
-if (account == null || dof == null || dof.getDomainId() == null)
{//public offering
-return true;
+public boolean checkAccess(Account account, DiskOffering dof, DataCenter
zone) throws PermissionDeniedException {
+boolean isAccess = false;
+// Check fo domains
+if (account == null || dof == null) {
+isAccess = true;
} else {
//admin has all permissions
if (_accountService.isRootAdmin(account.getId())) {
-return true;
+isAccess = true;
}
//if account is normal user or domain admin
-//check if account's domain is a child of zone's domain (Note:
This is made consistent with the list command for disk offering)
+//check if account's domain is a child of offering's domain (Note:
This is made consistent with the list command for disk offering)
else if (_accountService.isNormalUser(account.getId())
|| account.getType() ==
Account.ACCOUNT_TYPE_RESOURCE_DOMAIN_ADMIN
|| _accountService.isDomainAdmin(account.getId())
|| account.getType() == Account.ACCOUNT_TYPE_PROJECT) {
-if (account.getDomainId() == dof.getDomainId()) {
-return true; //disk offering and account at exact node
+final List doDomainIds =
diskOfferingDetailsDao.findDomainIds(dof.getId());
+if (doDomainIds.isEmpty()) {
+isAccess = true;
} else {
-Domain domainRecord =
_domainDao.findById(account.getDomainId());
-if (domainRecord != null) {
-while (true) {
-if (domainRecord.getId() == dof.getDomainId()) {
-//found as a child
-return true;
-}
-if (domainRecord.getParent() != null) {
-domainRecord =
_domainDao.findById(domainRecord.getParent());
-} else {
-break;
-}
+for (Long domainId : doDomainIds) {
+if (_domainDao.isChildDomain(domainId,
account.getDomainId())) {
+isAccess = true;
+break;
}
}
}
}
}
-//not found
-return false;
+// Check for zones
+if (isAccess && dof != null && zone != null) {
+final List doZoneIds =
diskOfferingDetailsDao.findZoneIds(dof.getId());
+isAccess = doZoneIds.isEmpty() || doZoneIds.contains(zone.getId());
+}
+return isAccess;
}
@Override
-public boolean checkAccess(Account account, ServiceOffering so) throws
PermissionDeniedException {
-if (account == null || so.getDomainId() == null) {//public offering
-return true;
+public boolean checkAccess(Account account, ServiceOffering so, DataCenter
zone) throws PermissionDeniedException {
+boolean isAccess = false;
+// Check fo domains
+if (account == null || so == null) {
+isAccess = true;
} else {
//admin has all permissions
if (_accountService.isRootAdmin(account.getId())) {
-return true;
+isAccess = true;
}
//if account is normal user or domain admin
-//check if account's domain is a child of zone's domain (Note:
This is made consistent with the list command for service offering)
+//check if account's domain is a child of offering's domain (Note:
This is made consistent with the list command for service offering)
else if (_accountService.isNormalUser(account.getId())
|| account.getType() ==
Account.ACCOUNT_TYPE_RESOURCE_DOMAIN_ADMIN
|| _accountService.isDomainAdmin(account.getId())
|| account.getType() == Account.ACCOUNT_TYPE_PROJECT) {
-if (account.getDomainId() == so.getDomainId()) {
-return true; //service offering and account at exact node
+final List soDomainIds =
[GitHub] [cloudstack] shwstppr commented on a change in pull request #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
shwstppr commented on a change in pull request #3248: [WIP DO NOT MERGE]
server: offerings for specified domain(s) and zone(s)
URL: https://github.com/apache/cloudstack/pull/3248#discussion_r288954604
##
File path: server/src/main/java/com/cloud/acl/DomainChecker.java
##
@@ -167,81 +182,155 @@ public boolean checkAccess(User user, ControlledEntity
entity) throws Permission
}
@Override
-public boolean checkAccess(Account account, DiskOffering dof) throws
PermissionDeniedException {
-if (account == null || dof == null || dof.getDomainId() == null)
{//public offering
-return true;
+public boolean checkAccess(Account account, DiskOffering dof, DataCenter
zone) throws PermissionDeniedException {
+boolean isAccess = false;
+// Check fo domains
+if (account == null || dof == null) {
+isAccess = true;
} else {
//admin has all permissions
if (_accountService.isRootAdmin(account.getId())) {
-return true;
+isAccess = true;
Review comment:
Because later in this method there is checkAccess for the zone as well. It
might be possible that offering is not specified for the passed zone.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] shwstppr commented on a change in pull request #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
shwstppr commented on a change in pull request #3248: [WIP DO NOT MERGE]
server: offerings for specified domain(s) and zone(s)
URL: https://github.com/apache/cloudstack/pull/3248#discussion_r288954542
##
File path: server/src/main/java/com/cloud/acl/DomainChecker.java
##
@@ -167,81 +182,155 @@ public boolean checkAccess(User user, ControlledEntity
entity) throws Permission
}
@Override
-public boolean checkAccess(Account account, DiskOffering dof) throws
PermissionDeniedException {
-if (account == null || dof == null || dof.getDomainId() == null)
{//public offering
-return true;
+public boolean checkAccess(Account account, DiskOffering dof, DataCenter
zone) throws PermissionDeniedException {
+boolean isAccess = false;
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] shwstppr commented on a change in pull request #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
shwstppr commented on a change in pull request #3248: [WIP DO NOT MERGE]
server: offerings for specified domain(s) and zone(s)
URL: https://github.com/apache/cloudstack/pull/3248#discussion_r288953397
##
File path: server/src/main/java/com/cloud/acl/DomainChecker.java
##
@@ -167,81 +182,155 @@ public boolean checkAccess(User user, ControlledEntity
entity) throws Permission
}
@Override
-public boolean checkAccess(Account account, DiskOffering dof) throws
PermissionDeniedException {
-if (account == null || dof == null || dof.getDomainId() == null)
{//public offering
-return true;
+public boolean checkAccess(Account account, DiskOffering dof, DataCenter
zone) throws PermissionDeniedException {
+boolean isAccess = false;
+// Check fo domains
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd closed pull request #2995: KVM: Improvements on upload direct download certificates
rhtyd closed pull request #2995: KVM: Improvements on upload direct download certificates URL: https://github.com/apache/cloudstack/pull/2995 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez opened a new pull request #2995: KVM: Improvements on upload direct download certificates
nvazquez opened a new pull request #2995: KVM: Improvements on upload direct download certificates URL: https://github.com/apache/cloudstack/pull/2995 ## Description - Report cases of failure, API method 'uploadTemplateDirectDownloadCertificate' always returns 'success:true' - Perform sanity check before sending certificate to hosts ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? 2 KVM hosts - Upload valid certificate, verify certificate is imported on both hosts -> OK - Upload invalid certificate -> ERROR - Upload existing alias certificate -> ERROR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #2995: KVM: Improvements on upload direct download certificates
rhtyd commented on issue #2995: KVM: Improvements on upload direct download certificates URL: https://github.com/apache/cloudstack/pull/2995#issuecomment-497297592 Closed-reopened PR to re-kick Travis. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3364: LDAP users with similar permissions do not see each other's networks
andrijapanicsb commented on issue #3364: LDAP users with similar permissions do not see each other's networks URL: https://github.com/apache/cloudstack/issues/3364#issuecomment-497294148 Heard a similar thing from another user. "LDAP-authenticated" ADMIN vs. "local-authenticated" ADMIN - can't see each other's networks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr commented on a change in pull request #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
shwstppr commented on a change in pull request #3248: [WIP DO NOT MERGE]
server: offerings for specified domain(s) and zone(s)
URL: https://github.com/apache/cloudstack/pull/3248#discussion_r288948696
##
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##
@@ -2782,11 +2808,50 @@
sc.addAnd("vmType", SearchCriteria.Op.EQ, vmTypeStr);
}
+if (zoneId != null) {
+SearchBuilder sb =
_srvOfferingJoinDao.createSearchBuilder();
+sb.and("zoneId", sb.entity().getZoneId(), Op.FIND_IN_SET);
+sb.or("zId", sb.entity().getZoneId(), Op.NULL);
+sb.done();
+SearchCriteria zoneSC = sb.create();
+zoneSC.setParameters("zoneId", String.valueOf(zoneId));
+sc.addAnd("zoneId", SearchCriteria.Op.SC, zoneSC);
+}
+
Pair, Integer> result =
_srvOfferingJoinDao.searchAndCount(sc, searchFilter);
//Couldn't figure out a smart way to filter offerings based on tags in
sql so doing it in Java.
List filteredOfferings =
filterOfferingsOnCurrentTags(result.first(), currentVmOffering);
-return new Pair<>(filteredOfferings, result.second());
+// Remove offerings that are not associated with caller's domain
+// TODO: Better approach
Review comment:
@rhtyd I was hoping to do this with Java ArrayList _removeIf_ method to make
code concise but it won't work.
Concerned code needs to filter offerings.
Recursively - when listing offerings for root or domain admin in
ServiceOfferings page
Non-recursively(including offerings from parent domain) - when listing
offerings for vm deployment.
Since we have multiple domains are linked with offerings, it is not possible
to filter them with DB params alone as our *_offering_view gives
comma-separated list of linked domains. Therefore had to be handled in Java
code, I'll remove TODO comment.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #2727: maven: bump up vmware sdk jar to 6.7
rhtyd commented on issue #2727: maven: bump up vmware sdk jar to 6.7 URL: https://github.com/apache/cloudstack/pull/2727#issuecomment-497291659 I had recently ran tests against vmware 6.5u2, no regressions seen other than usual intermittent environment caused failures @onitake This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs
blueorangutan commented on issue #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs URL: https://github.com/apache/cloudstack/pull/3344#issuecomment-497291338 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3242: [WIP DO NOT MERGE] server: add support for sorting zones in UI/API
blueorangutan commented on issue #3242: [WIP DO NOT MERGE] server: add support for sorting zones in UI/API URL: https://github.com/apache/cloudstack/pull/3242#issuecomment-497291109 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs
rhtyd commented on issue #3344: [WIP DO NOT MERGE] server: return usage description with resource names and UUIDs URL: https://github.com/apache/cloudstack/pull/3344#issuecomment-497291117 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3242: [WIP DO NOT MERGE] server: add support for sorting zones in UI/API
rhtyd commented on issue #3242: [WIP DO NOT MERGE] server: add support for sorting zones in UI/API URL: https://github.com/apache/cloudstack/pull/3242#issuecomment-497290987 Thanks @shwstppr @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
