[GitHub] [cloudstack] sureshanaparti commented on issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS cluster does not participate in load balancing.
sureshanaparti commented on issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS cluster does not participate in load balancing. URL: https://github.com/apache/cloudstack/pull/1257#issuecomment-508337781 @rhtyd sure, will update. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] sureshanaparti commented on issue #1897: CLOUDSTACK-9733: Concurrent volume snapshots of a VM are not allowed and are not limited per host as per the global configuration paramet
sureshanaparti commented on issue #1897: CLOUDSTACK-9733: Concurrent volume snapshots of a VM are not allowed and are not limited per host as per the global configuration parameter "concurrent.snapshots.threshold.perhost". URL: https://github.com/apache/cloudstack/pull/1897#issuecomment-508337502 @rhtyd Will work on this week, rebase and fix conflicts. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] huadream opened a new pull request #3463: quota: fix issue of QuotaType name
huadream opened a new pull request #3463: quota: fix issue of QuotaType name URL: https://github.com/apache/cloudstack/pull/3463 ## Description Fix issue of `QuotaType` name. This bug causes `Quota - Summary > Statement` to show the incorrect name of `VM_DISK_BYTES_WRITE`. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3462: Count Starting along with Running VMs for user dispersing planner
blueorangutan commented on issue #3462: Count Starting along with Running VMs for user dispersing planner URL: https://github.com/apache/cloudstack/pull/3462#issuecomment-508266780 Trillian test result (tid-95) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28611 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3462-t95-kvm-centos7.zip Smoke tests completed. 68 look OK, 3 have error(s) Only failed tests results shown below: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router
blueorangutan commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-508258925 Trillian test result (tid-94) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31262 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3350-t94-vmware-65u2.zip Smoke tests completed. 67 look OK, 4 have error(s) Only failed tests results shown below: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-508244666 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-82 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router
blueorangutan commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-508238482 Trillian test result (tid-93) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 27149 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3350-t93-kvm-centos7.zip Smoke tests completed. 71 look OK, 0 have error(s) Only failed tests results shown below: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-508238159 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
nvazquez commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-508237910 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] richardlawley commented on issue #3461: guest_os_hypervisor missing entries for XenServer 7.1.2
richardlawley commented on issue #3461: guest_os_hypervisor missing entries for XenServer 7.1.2 URL: https://github.com/apache/cloudstack/issues/3461#issuecomment-508229611 I'm fine with how to fix it on a one-off, but other people might be less comfortable. Regarding future versions, I think it's possible that they could potentially introduce new templates, so there should still be the capability to add specific overrides, but modifying it to try 7.1.2, 7.1.1, 7.1.0 etc should take care of most situations with the ability to add new rows if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] kioie commented on issue #3456: Memory Used is incorrect
kioie commented on issue #3456: Memory Used is incorrect URL: https://github.com/apache/cloudstack/issues/3456#issuecomment-508213647 The above is on 4.12, but looking at the code base on latest master, doesn't look like much anything has changed on this endpoint This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez edited a comment on issue #3374: KVM: Enhancements for direct download feature
nvazquez edited a comment on issue #3374: KVM: Enhancements for direct download feature URL: https://github.com/apache/cloudstack/pull/3374#issuecomment-508213146 @rhtyd yes, but couldn't start working on it yet rather than simple verification. The apache http client seems to be preferring ipv4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3374: KVM: Enhancements for direct download feature
nvazquez commented on issue #3374: KVM: Enhancements for direct download feature URL: https://github.com/apache/cloudstack/pull/3374#issuecomment-508213146 @rhtyd yes, but couldn't start working on it yet, rather than simple verification. The apache http client seems to be preferring ipv4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3457: Fix bug in counting items for search query
blueorangutan commented on issue #3457: Fix bug in counting items for search query URL: https://github.com/apache/cloudstack/pull/3457#issuecomment-508207630 Trillian test result (tid-90) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39738 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3457-t90-vmware-65u2.zip Smoke tests completed. 69 look OK, 2 have error(s) Only failed tests results shown below: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3456: Memory Used is incorrect
rhtyd commented on issue #3456: Memory Used is incorrect URL: https://github.com/apache/cloudstack/issues/3456#issuecomment-508202672 @kioie are you able to reproduce using latest master? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3458: Cannot create zone. "Fail to create a physical network" error with VMWare 6.5 hypervisor
rhtyd commented on issue #3458: Cannot create zone. "Fail to create a physical network" error with VMWare 6.5 hypervisor URL: https://github.com/apache/cloudstack/issues/3458#issuecomment-508202447 @AndreaGHG can you share your MySQL server version, and if you're using any forks such as MariaDB, or any mysql-proxy etc? Please set the `host` global setting to be the management server host IP address and the `management.network.cidr` to match the management network CIDR, then restart the management server. Per the exception `Caused by: com.mysql.jdbc.exceptions.jdbc4.MySQLTransactionRollbackException: Deadlock found when trying to get lock; try restarting transaction` there seems to be some database related issue in your environment. Are you running multiple management server(s)? Did you restart the mysql server after changing the proposed/recommended changes in the mysql cnf file: ``` [mysqld] server_id = 1 sql-mode="STRICT_TRANS_TABLES,NO_ENGINE_SUBSTITUTION,ERROR_FOR_DIVISION_BY_ZERO,NO_ZERO_DATE,NO_ZERO_IN_DATE,NO_ENGINE_SUBSTITUTION" innodb_rollback_on_timeout=1 innodb_lock_wait_timeout=600 max_connections=1000 log-bin=mysql-bin binlog-format = 'ROW' ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3461: guest_os_hypervisor missing entries for XenServer 7.1.2
rhtyd commented on issue #3461: guest_os_hypervisor missing entries for XenServer 7.1.2 URL: https://github.com/apache/cloudstack/issues/3461#issuecomment-508200645 @richardlawley You can see `engine/schema/src/main/resources/META-INF/db/schema-41000to41100.sql` as a reference on how to add support for a xenserver version. Is it fair to assume that every 7.1.x will support the same sets of xenserver guests? If yes, we can modify the business logic to take any existing mapping for any 7.1.x XenServer version to be used for any new 7.1.y version. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd edited a comment on issue #3460: CloudStack install on Ubuntu 18.04 fails on mvn -P deps
rhtyd edited a comment on issue #3460: CloudStack install on Ubuntu 18.04 fails on mvn -P deps URL: https://github.com/apache/cloudstack/issues/3460#issuecomment-508198645 @zjohn77 thanks for reporting, the build docs on the project docs website are old and need fixing. If you'd prefer to send a pull request to the `cloudstack-documentation` repo, you can do so here: https://github.com/apache/cloudstack-documentation/blob/master/source/installguide/building_from_source.rst For building/development please refer to: https://github.com/apache/cloudstack/blob/master/INSTALL.md Or, https://github.com/rhtyd/monkeybox#cloudstack-development For developing, checkout 4.11.2.0 git tag or download the src tarball and ensure that JDK8 is installed, i.e. `mvn -v` should return java version to be 1.8.x. If you've any further questions kindly raise them on the dev@ mailing list: http://cloudstack.apache.org/mailing-lists.html Closing on this remark. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd closed issue #3460: CloudStack install on Ubuntu 18.04 fails on mvn -P deps
rhtyd closed issue #3460: CloudStack install on Ubuntu 18.04 fails on mvn -P deps URL: https://github.com/apache/cloudstack/issues/3460 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3460: CloudStack install on Ubuntu 18.04 fails on mvn -P deps
rhtyd commented on issue #3460: CloudStack install on Ubuntu 18.04 fails on mvn -P deps URL: https://github.com/apache/cloudstack/issues/3460#issuecomment-508198645 @zjohn77 thanks for reporting, the build docs on the project docs website are old and need fixing. If you'd prefer to send a pull request to the `cloudstack-documentation` repo, you can do so here: https://github.com/apache/cloudstack-documentation/blob/master/source/installguide/building_from_source.rst For building/development please refer to: https://github.com/apache/cloudstack/blob/master/INSTALL.md Or, https://github.com/rhtyd/monkeybox#cloudstack-development This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts
blueorangutan commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-508198255 Trillian test result (tid-91) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 29015 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3331-t91-kvm-centos7.zip Smoke tests completed. 70 look OK, 2 have error(s) Only failed tests results shown below: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] zjohn77 commented on issue #3460: CloudStack install on Ubuntu 18.04 fails on mvn -P deps
zjohn77 commented on issue #3460: CloudStack install on Ubuntu 18.04 fails on mvn -P deps URL: https://github.com/apache/cloudstack/issues/3460#issuecomment-508181952 openjdk version "1.8.0_212" OpenJDK Runtime Environment (build 1.8.0_212-8u212-b03-0ubuntu1.18.04.1-b03) OpenJDK 64-Bit Server VM (build 25.212-b03, mixed mode) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on a change in pull request #3454: [WIP DO NOT MERGE] Add support for new heuristics based VM Deployement
anuragaw commented on a change in pull request #3454: [WIP DO NOT MERGE] Add support for new heuristics based VM Deployement URL: https://github.com/apache/cloudstack/pull/3454#discussion_r300044341 ## File path: api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java ## @@ -138,6 +140,12 @@ @Parameter(name = ApiConstants.SSH_KEYPAIR, type = CommandType.STRING, description = "name of the ssh key pair used to login to the virtual machine") private String sshKeyPairName; +@Parameter(name = ApiConstants.POD_ID, type = CommandType.UUID, entityType = PodResponse.class, description = "destination Pod ID to deploy the VM to - parameter available for root admin only") Review comment: That's a very good point. Let me investigate and see possibilities. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-508156050 Trillian test result (tid-89) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31629 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3248-t89-kvm-centos7.zip Smoke tests completed. 75 look OK, 0 have error(s) Only failed tests results shown below: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3332: Switch instance to another compute/service offering
anuragaw commented on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-508150626 Copy @rhtyd This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure
anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better
tracking host maintanence success and failure
URL: https://github.com/apache/cloudstack/pull/3425#discussion_r300031163
##
File path: api/src/main/java/com/cloud/resource/ResourceState.java
##
@@ -22,17 +22,26 @@
import com.cloud.utils.fsm.StateMachine;
public enum ResourceState {
-Creating, Enabled, Disabled, PrepareForMaintenance, ErrorInMaintenance,
Maintenance, Error;
+Creating,
+Enabled,
+Disabled,
+PrepareForMaintenance,
+ErrorInMaintenance,
+Maintenance,
+Error,
+PrepareForMaintenanceErrorsPresent;
Review comment:
Okay. I get your point. Fixing in the next commit.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure
blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-508133128 Trillian test result (tid-88) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28692 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3425-t88-kvm-centos7.zip Smoke tests completed. 69 look OK, 2 have error(s) Only failed tests results shown below: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts
blueorangutan commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-508121141 Trillian test result (tid-87) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28647 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3331-t87-kvm-centos7.zip Smoke tests completed. 70 look OK, 2 have error(s) Only failed tests results shown below: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3341: Ability to add custom disk offer to data disk (created from multi-disk template)
rhtyd commented on issue #3341: Ability to add custom disk offer to data disk (created from multi-disk template) URL: https://github.com/apache/cloudstack/issues/3341#issuecomment-508109574 Custom disk offering for multi-disk ova is not supported because the ova template already may have a data disk/template with fixed size. A custom disk offering would mean, if the provided value is smaller then the data disk is shrunk otherwise expanded. @nvazquez can you share your view? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #1897: CLOUDSTACK-9733: Concurrent volume snapshots of a VM are not allowed and are not limited per host as per the global configuration parameter "concu
rhtyd commented on issue #1897: CLOUDSTACK-9733: Concurrent volume snapshots of a VM are not allowed and are not limited per host as per the global configuration parameter "concurrent.snapshots.threshold.perhost". URL: https://github.com/apache/cloudstack/pull/1897#issuecomment-508108768 ping @sureshanaparti are you able to work on this, rebase/fix conflicts as well? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV
rhtyd commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-508107970 cc @swill This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS cluster does not participate in load balancing.
rhtyd commented on issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS cluster does not participate in load balancing. URL: https://github.com/apache/cloudstack/pull/1257#issuecomment-508107118 @sureshanaparti can you help fix the conflicts? I can help kick tests towards 4.13. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3332: Switch instance to another compute/service offering
rhtyd commented on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-508106616 Looks like a backend regression, in the UI I see this:  @anuragaw since you may be working on outstanding UI issue can you have a look at this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #2724: Service Offering Sorting is broken in UI
rhtyd commented on issue #2724: Service Offering Sorting is broken in UI URL: https://github.com/apache/cloudstack/issues/2724#issuecomment-508103766 As per remarks on https://github.com/apache/cloudstack/pull/3445, this is fixed. Closing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd closed issue #2724: Service Offering Sorting is broken in UI
rhtyd closed issue #2724: Service Offering Sorting is broken in UI URL: https://github.com/apache/cloudstack/issues/2724 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3029: project - infrastructure - "Select View: Group by Account" (ui problem)
rhtyd commented on issue #3029: project - infrastructure - "Select View: Group by Account" (ui problem) URL: https://github.com/apache/cloudstack/issues/3029#issuecomment-508103441 @pbankonier @svenvogel I think this feature could be (a) removed as it does not work, or (b) display list of routers/account this way -> routers belong to networks of project -> find accounts that belong with the project, group accounts by project and group networks to the project -> then group of routers ... (this is complicated), or (c) Alternatively, when project is selected don't pass project id (fixes the issue). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3412: Allow for the VM Hostname to be edited when VM is switched off
rhtyd commented on issue #3412: Allow for the VM Hostname to be edited when VM is switched off URL: https://github.com/apache/cloudstack/pull/3412#issuecomment-508099118 LGTM but did not test it. @anuragaw @svenvogel have you tested the latest change? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3444: Enhance gulp autoprefixer task
rhtyd commented on issue #3444: Enhance gulp autoprefixer task URL: https://github.com/apache/cloudstack/pull/3444#issuecomment-508098214 Thanks @webermaximilian92 I'll try to follow This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3434: Build css from scss sources in client ui build
rhtyd commented on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-508095165 Thanks for explaining @pbankonier I would have asked for a complete design document for all sorts of UI changes that are coming because they have long term impact on all developers including build and CI systems. I'm sure there are others in the community who're unable to track the intent spread across a couple of related PRs. I was not aware of the PR https://github.com/apache/cloudstack/pull/3307 and was not tracking it as it was not tagged against a milestone (just added one because it's already merged). Generally reviewers, RMs and co-RMs working towards a release/milestone may not track PRs that bring wide amount of changes or break several existing PRs because it will be a lot of work to get authors of existing PRs which may get merge conflict if a PR like this would be merged. We have about 90-100 open items on 4.13.0.0 milestone and many of which have UI/css changes or are UI issues that may require fixes in css files. Due to this, I have moved milestone of this PR to 4.14, hope I've your support and understanding. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3462: Count Starting along with Running VMs for user dispersing planner
blueorangutan commented on issue #3462: Count Starting along with Running VMs for user dispersing planner URL: https://github.com/apache/cloudstack/pull/3462#issuecomment-508090709 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3462: Count Starting along with Running VMs for user dispersing planner
rhtyd commented on issue #3462: Count Starting along with Running VMs for user dispersing planner URL: https://github.com/apache/cloudstack/pull/3462#issuecomment-508090271 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router
rhtyd commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-508090158 @borisstoyanov as I've mentioned, it is still work in progress, XenServer support is not implemented yet. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3312: 'sed -i' need postfix on mac
rhtyd commented on issue #3312: 'sed -i' need postfix on mac URL: https://github.com/apache/cloudstack/pull/3312#issuecomment-508089732 This is `onhold` until Travis passes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3462: Count Starting along with Running VMs for user dispersing planner
blueorangutan commented on issue #3462: Count Starting along with Running VMs for user dispersing planner URL: https://github.com/apache/cloudstack/pull/3462#issuecomment-508086907 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-81 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3462: Count Starting along with Running VMs for user dispersing planner
blueorangutan commented on issue #3462: Count Starting along with Running VMs for user dispersing planner URL: https://github.com/apache/cloudstack/pull/3462#issuecomment-508079006 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3462: Count Starting along with Running VMs for user dispersing planner
borisstoyanov commented on issue #3462: Count Starting along with Running VMs for user dispersing planner URL: https://github.com/apache/cloudstack/pull/3462#issuecomment-508078611 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router
blueorangutan commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-508066153 @borisstoyanov a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router
borisstoyanov commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-508065936 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router
blueorangutan commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-508065143 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-80 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] kioie commented on issue #3460: CloudStack install on Ubuntu 18.04 fails on mvn -P deps
kioie commented on issue #3460: CloudStack install on Ubuntu 18.04 fails on mvn -P deps URL: https://github.com/apache/cloudstack/issues/3460#issuecomment-508063213 Could you confirm which Java version you're running? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router
blueorangutan commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-508058884 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router
borisstoyanov commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-508058819 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] pbankonier edited a comment on issue #3434: Build css from scss sources in client ui build
pbankonier edited a comment on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-508055720 @rhtyd That these css files get finally removed is just a consequence from this change https://github.com/apache/cloudstack/pull/3307. The css files should not be edited nonetheless right now, because they get build from the scss sources. So the css files should have been removed already in that PR. Everyone who wants to make a styling change should edit the scss files and then build the css from them. Normally you would not keep the css files in the repo, because have redundant information regarding the scss files, so when someone changes one without the other we will get an inconsistent state of these files, which results in the necessity of someone keeping them in sync manually. So to prevent this it is important to get this change merged, which compiles the scss files to css during the build of the module and removes the responsibility for keeping these files in sync from the devs. There is no impact in the usage. The only alternative would be to remove the scss files again, but this would result in keeping these massive css files which are difficult to maintain. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] pbankonier edited a comment on issue #3434: Build css from scss sources in client ui build
pbankonier edited a comment on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-508055720 @rhtyd That these css files get finally removed is just a consequence from this change https://github.com/apache/cloudstack/pull/3307. The css files should not be edited nonetheless right now, because they get build from the scss sources. So the css files should have been removed already in that PR. Everyone who wants to make a styling change should edit the scss files and then build the css from them. Normally you would not keep the css files in the repo, because have redundant information regarding the scss files, so when someone changes one without the other we will get an inconsistent state of these files, which results in the necessity of someone keeping them in sync manually. So to prevent this it is important to get this change merged, which compiles the scss files to css during the build of the module and removes the responsibility for keeping these files in sync from the devs. There is no impact in the usage. The only alternative would be to remove the scss files again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3462: Count Starting along with Running VMs for user dispersing planner
rhtyd commented on a change in pull request #3462: Count Starting along with
Running VMs for user dispersing planner
URL: https://github.com/apache/cloudstack/pull/3462#discussion_r299910373
##
File path: engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java
##
@@ -749,10 +749,10 @@ public Long countActiveByHostId(long hostId) {
}
@Override
-public Long countRunningByAccount(long accountId) {
-SearchCriteria sc = CountRunningByAccount.create();
+public Long countRunningAndStartingByAccount(long accountId) {
+SearchCriteria sc = CountRunningAndStartingByAccount.create();
sc.setParameters("account", accountId);
-sc.setParameters("state", State.Running);
+sc.setParameters("states", new Object[] {State.Starting,
State.Running});
Review comment:
You can simply also write, `State.Starting, State.Running`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] pbankonier commented on issue #3434: Build css from scss sources in client ui build
pbankonier commented on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-508055720 @rhtyd That these css files get finally removed is just a consequence from this change https://github.com/apache/cloudstack/pull/3307. The css files should not be edited nonetheless right now, because they get build from the scss sources. So the css files should have been removed already in that PR. Everyone who wants to make a styling change should edit the scss files and then build the css from them. Normally you would not keep the css files in the repo, because have redundant information regarding the scss files, so when someone changes one without the other we will get an inconsistent state of these files, which results in the necessity of someone keeping them in sync manually. So to prevent this it is important to get this change merged, which compiles the scss files to css during the build of the module and removes the responsibility for keeping these files in sync from the devs. There is no impact in the usage. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3462: Count Starting along with Running VMs for user dispersing planner
anuragaw commented on issue #3462: Count Starting along with Running VMs for user dispersing planner URL: https://github.com/apache/cloudstack/pull/3462#issuecomment-508054813 ping @rhtyd , @shwstppr , @nvazquez , @borisstoyanov - for review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw opened a new pull request #3462: Count Starting along with Running VMs for user dispersing planner
anuragaw opened a new pull request #3462: Count Starting along with Running VMs for user dispersing planner URL: https://github.com/apache/cloudstack/pull/3462 Consider running and starting VMs when considering load ona host for VM deployement for more accurate dispersion. ## Description Fixes: #3442 ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? Deploy VMs quickly through CMK on a 2 host environment. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3442: UserDispersingPlanner only counts Running vms on hosts.
anuragaw commented on issue #3442: UserDispersingPlanner only counts Running vms on hosts. URL: https://github.com/apache/cloudstack/issues/3442#issuecomment-508047798 Testing was little tricky locally but the PR would be out later today. Verified that counting stating VMs makes sense does not break anything. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] richardlawley opened a new issue #3461: guest_os_hypervisor missing entries for XenServer 7.1.2
richardlawley opened a new issue #3461: guest_os_hypervisor missing entries for XenServer 7.1.2 URL: https://github.com/apache/cloudstack/issues/3461 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ DB ~~~ # CLOUDSTACK VERSION ~~~ 4.11.2, 4.11.3 ~~~ # CONFIGURATION N/A # OS / ENVIRONMENT XenServer 7.1.2 (7.1 CU2) Hosts # SUMMARY There are no entries in guest_os_hypervisor for XenServer 7.1 CU2 (the current LTS XenServer) which means guests are booted using the "Other Install Media" template. Amongst other things, this means that PV guests boot as HV, but also likely means guests won't get XenServer optimisations for their OS type. Perhaps a better way rather than just inserting specific rows for this version would be to add logic to ignore the revision number in a version matching pattern x.y.z if there are no rows found, e.g. look for row with version = 7.1.2, fallback to row with version = 7.1.0 (would still work if XenServer is updated without CloudStack being updated). Related: #3086 # STEPS TO REPRODUCE Install Fresh CloudStack instance with new XenServer 7.1.2 hosts. Wait for CS to try to deploy system VMs. ~~~ ~~~ # EXPECTED RESULTS System VMs should boot using the Debian Wheezy 7.0 (64-bit) XenServer template ~~~ ~~~ # ACTUAL RESULTS System VMs should boot using the Other Install Media XenServer template (which fails to boot in a virtual environment using XenServer running on VMs, only capable of running PV). ~~~ ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router
blueorangutan commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-508032492 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-79 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd edited a comment on issue #3253: Load balancer appcookie configuration deprecated in HAproxy
rhtyd edited a comment on issue #3253: Load balancer appcookie configuration deprecated in HAproxy URL: https://github.com/apache/cloudstack/issues/3253#issuecomment-508027245 The appcookie feature was primary driven by the netscalar implementation (if I recall correctly). Per the haproxy docs `As of version 1.6, appsessions was removed. It is more flexible and more convenient to use stick-tables instead, and stick-tables support multi-master replication and data conservation across reloads, which appsessions did not.`. We can explore if an upgrade path is possible. The LB feature needs some overall cleanup and fixing, other than the tcp round-robin (most preferred use-case), SSL off loading etc don't work, as they were primarily netscalar driven in the past. cc @PaulAngus This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3455: Configurable disk size of systemvm
ustcweizhou commented on issue #3455: Configurable disk size of systemvm URL: https://github.com/apache/cloudstack/issues/3455#issuecomment-508028789 @rhtyd awesome !! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3253: Load balancer appcookie configuration deprecated in HAproxy
rhtyd commented on issue #3253: Load balancer appcookie configuration deprecated in HAproxy URL: https://github.com/apache/cloudstack/issues/3253#issuecomment-508027245 The appcookie feature was primary driven by the netscalar implementation (if I recall correctly). Per the haproxy docs `As of version 1.6, appsessions was removed. It is more flexible and more convenient to use stick-tables instead, and stick-tables support multi-master replication and data conservation across reloads, which appsessions did not.`. We can explore if an upgrade path is possible. The LB feature needs some overall cleanup and fixing, other than the tcp round-robin (most preferred use-case), SSL off loading etc don't work, as they were primarily netscalar driven in the past. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3144: Password Reset ignores redundant VR status when saving new password
rhtyd commented on issue #3144: Password Reset ignores redundant VR status when saving new password URL: https://github.com/apache/cloudstack/issues/3144#issuecomment-508026393 Related/previous old PR https://github.com/apache/cloudstack/pull/1965 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router
rhtyd commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-508023094 Issue with test is that on XenServer, it assumes it can copy from the systemvm directly, it has to be done via the xenserver host/dom0 via a router_proxy or other script. I'll need to check that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router
blueorangutan commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-508019527 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router
rhtyd commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-508019400 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router
rhtyd commented on issue #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-508019075 Marvin test needs fixing, I'm on it now. cc @borisstoyanov This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts
blueorangutan commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-508017301 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3378: project id added in test
DaanHoogland commented on a change in pull request #3378: project id added in
test
URL: https://github.com/apache/cloudstack/pull/3378#discussion_r299862808
##
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##
@@ -646,7 +646,16 @@
Ternary
domainIdRecursiveListProject = new Ternary(cmd.getDomainId(), cmd.isRecursive(), null);
-_accountMgr.buildACLSearchParameters(caller, null,
cmd.getAccountName(), cmd.getProjectId(), permittedAccounts,
domainIdRecursiveListProject, listAll, false);
+Long projectId = cmd.getProjectId();
+if (resourceType.equalsIgnoreCase("project") && projectId == null) {
+try {
+projectId = Long.parseLong(resourceId);
+} catch (NumberFormatException e) {
+projectId = _projectDao.findByUuid(resourceId).getId();
Review comment:
it throws an exception: garbage in, garbage out. should we handle that? I
think it is the exception @rhtyd is pointing at. How do you suggest this should
be handled?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts
rhtyd commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-508017208 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd edited a comment on issue #3455: Configurable disk size of systemvm
rhtyd edited a comment on issue #3455: Configurable disk size of systemvm URL: https://github.com/apache/cloudstack/issues/3455#issuecomment-508016526 @ustcweizhou @richardlawley yes, we can consider that. The main reason to keep separate partitions was to ensure that filling of logs and process creates files in /var/cache/cloud doesn't kill the VM. Do note that the VR could be public facing and may be prone to attacks. I would propose to keep at least the /var as a separate partition and to support pvgrub based boot on xenserver the /boot has to be an ext2 (separate) partition. I think starting 4.11.2+, there is an option to pass and specify the root disk size we could (1) introduce a systemvm/vr specific global setting that is the root disk size, which is not defined/null by default, (2) when this global setting is defined it resizes the root disk before deployment, (3) during patching via bootstrap.sh the script can extend one or all the partitions to fill any empty space if necessary and if we move to something like cloud-init it can do that for us. I've few other ideas around the new systemvmtemplate, where the whole root disk could be simply used as data disk while the appliance OS (a custom debian 10 or alpine based) boots via the systemvm.iso directly as a read-only system (no need to ship separate systemvmtemplate appliances and force users to go through the register/setup steps during install/upgrade). I also have some ideas that I'll document and propose after 4.13 around live patching (no need to reboot VRs during upgrade), runc/containerd inclusion for dnsmasq/nginx/strongswan/* services and a light-weight tls-secured VR agent than use the ssh-based programming model. More on that after 4.13. cc @PaulAngus This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd edited a comment on issue #3455: Configurable disk size of systemvm
rhtyd edited a comment on issue #3455: Configurable disk size of systemvm URL: https://github.com/apache/cloudstack/issues/3455#issuecomment-508016526 @ustcweizhou @richardlawley yes, we can consider that. The main reason to keep separate partitions was to ensure that filling of logs and process creates files in /var/cache/cloud doesn't kill the VM. Do note that the VR could be public facing and may be prone to attacks. I would propose to keep at least the /var as a separate partition and to support pvgrub based boot on xenserver the /boot has to be an ext2 (separate) partition. I think starting 4.11.2+, there is an option to pass and specify the root disk size we could (1) introduce a systemvm/vr specific global setting that is the root disk size, which is not defined/null by default, (2) when this global setting is defined it resizes the root disk before deployment, (3) during patching via bootstrap.sh the script can extend one or all the partitions to fill any empty space if necessary and if we move to something like cloud-init it can do that for us. I've few other ideas around the new systemvmtemplate, where the whole root disk could be simply used as data disk while the appliance OS (a custom debian 10 or alpine based) boots via the systemvm.iso directly as a read-only system (no need to ship separate systemvmtemplate appliances and force users to go through the register/setup steps during install/upgrade). I also have some ideas that I'll document and propose after 4.13 around live patching (no need to reboot VRs during upgrade), runc/containerd inclusion for dnsmasq/nginx/strongswan/* services and a light-weight tls-secured VR agent than use the ssh-based programming model. More on that after 4.13. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd edited a comment on issue #3455: Configurable disk size of systemvm
rhtyd edited a comment on issue #3455: Configurable disk size of systemvm URL: https://github.com/apache/cloudstack/issues/3455#issuecomment-508016526 @ustcweizhou @richardlawley yes, we can consider that. The main reason to keep separate partitions was to ensure that filling of logs and process creates files in /var/cache/cloud doesn't kill the VM. Do note that the VR could be public facing and may be prone to attacks. I would propose to keep at least the /var as a separate partition and to support pvgrub based boot on xenserver the /boot has to be an ext2 (separate) partition. I think starting 4.11.2+, there is an option to pass and specify the root disk size we could (1) introduce a systemvm/vr specific global setting that is the root disk size, which is not defined/null by default, (2) when this global setting is defined it resizes the root disk before deployment, (3) during patching via bootstrap.sh the script can extend one or all the partitions to fill any empty space if necessary and if we move to something like cloud-init it can do that for us. I've few other ideas around the new systemvmtemplate, where the whole root disk could be simply used as data disk while the appliance OS (a custom debian 10 or alpine based) boots via the systemvm.iso directly as a read-only system (no need to ship separate). I also have some ideas that I'll document and propose after 4.13 around live patching (no need to reboot VRs during upgrade), runc/containerd inclusion for dnsmasq/nginx/strongswan/* services and a light-weight tls-secured VR agent than use the ssh-based programming model. More on that after 4.13. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3455: Configurable disk size of systemvm
rhtyd commented on issue #3455: Configurable disk size of systemvm URL: https://github.com/apache/cloudstack/issues/3455#issuecomment-508016526 @ustcweizhou yes, we can consider that. The main reason to keep separate partitions was to ensure that filling of logs and process creates files in /var/cache/cloud doesn't kill the VM. Do note that the VR could be public facing and may be prone to attacks. I would propose to keep at least the /var as a separate partition and to support pvgrub based boot on xenserver the /boot has to be an ext2 (separate) partition. I think starting 4.11.2+, there is an option to pass and specify the root disk size we could (1) introduce a systemvm/vr specific global setting that is the root disk size, which is not defined/null by default, (2) when this global setting is defined it resizes the root disk before deployment, (3) during patching via bootstrap.sh the script can extend one or all the partitions to fill any empty space if necessary and if we move to something like cloud-init it can do that for us. I've few other ideas around the new systemvmtemplate, where the whole root disk could be simply used as data disk while the appliance OS (a custom debian 10 or alpine based) boots via the systemvm.iso directly as a read-only system (no need to ship separate). I also have some ideas that I'll document and propose after 4.13 around live patching (no need to reboot VRs during upgrade), runc/containerd inclusion for dnsmasq/nginx/strongswan/* services and a light-weight tls-secured VR agent than use the ssh-based programming model. More on that after 4.13. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3455: Configurable disk size of systemvm
ustcweizhou commented on issue #3455: Configurable disk size of systemvm URL: https://github.com/apache/cloudstack/issues/3455#issuecomment-508009568 @richardlawley yes, that's also what we did. @rhtyd can we do in three steps ? (1) only one partition in systemvm template (2) a fixed bigger disk size (?) (3) configurable disk size. this has low priority if the default size is increased. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] richardlawley commented on issue #3455: Configurable disk size of systemvm
richardlawley commented on issue #3455: Configurable disk size of systemvm URL: https://github.com/apache/cloudstack/issues/3455#issuecomment-508003015 We create our own systemvm templates and have switched to just root/boot partitions as the many partitions approach just led to inefficient use of space. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #3400: Allow normal users to download template when template are not extractable
Spaceman1984 commented on issue #3400: Allow normal users to download template when template are not extractable URL: https://github.com/apache/cloudstack/issues/3400#issuecomment-507998852 I'll take this one on This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] onitake commented on issue #3450: Port 8096 allows unauthenticated access from any IP.
onitake commented on issue #3450: Port 8096 allows unauthenticated access from any IP. URL: https://github.com/apache/cloudstack/issues/3450#issuecomment-507997260 By the way: The description was improved in 4.11.3. It now says "Default API port. To disable set it to 0 or negative." In 4.11.2, it was simply "Default API port." This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
svn commit: r34758 - /dev/cloudstack/4.11.3.0/ /release/cloudstack/releases/4.11.3.0/
Author: paul_a Date: Wed Jul 3 08:30:11 2019 New Revision: 34758 Log: Publishing 4.11.3.0 release Added: release/cloudstack/releases/4.11.3.0/ - copied from r34757, dev/cloudstack/4.11.3.0/ Removed: dev/cloudstack/4.11.3.0/
[cloudstack] branch 4.11 updated: Updating pom.xml version numbers for release 4.11.4.0-SNAPSHOT
This is an automated email from the ASF dual-hosted git repository. paul_a pushed a commit to branch 4.11 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.11 by this push: new b72aadb Updating pom.xml version numbers for release 4.11.4.0-SNAPSHOT b72aadb is described below commit b72aadb65dbe88a52c1209f5b205889efc83b171 Author: Paul Angus AuthorDate: Wed Jul 3 09:28:09 2019 +0100 Updating pom.xml version numbers for release 4.11.4.0-SNAPSHOT Signed-off-by: Paul Angus --- agent/pom.xml| 2 +- api/pom.xml | 2 +- client/pom.xml | 2 +- core/pom.xml | 2 +- debian/changelog | 12 ++-- developer/pom.xml| 2 +- engine/api/pom.xml | 2 +- engine/components-api/pom.xml| 2 +- engine/network/pom.xml | 2 +- engine/orchestration/pom.xml | 2 +- engine/pom.xml | 2 +- engine/schema/pom.xml| 2 +- engine/service/pom.xml | 2 +- engine/storage/cache/pom.xml | 2 +- engine/storage/configdrive/pom.xml | 2 +- engine/storage/datamotion/pom.xml| 2 +- engine/storage/image/pom.xml | 2 +- engine/storage/integration-test/pom.xml | 2 +- engine/storage/pom.xml | 2 +- engine/storage/snapshot/pom.xml | 2 +- engine/storage/volume/pom.xml| 2 +- framework/agent-lb/pom.xml | 2 +- framework/ca/pom.xml | 2 +- framework/cluster/pom.xml| 2 +- framework/config/pom.xml | 2 +- framework/db/pom.xml | 2 +- framework/direct-download/pom.xml| 2 +- framework/events/pom.xml | 2 +- framework/ipc/pom.xml| 2 +- framework/jobs/pom.xml | 2 +- framework/managed-context/pom.xml| 2 +- framework/pom.xml| 2 +- framework/quota/pom.xml | 2 +- framework/rest/pom.xml | 2 +- framework/security/pom.xml | 2 +- framework/spring/lifecycle/pom.xml | 2 +- framework/spring/module/pom.xml | 2 +- maven-standard/pom.xml | 2 +- plugins/acl/dynamic-role-based/pom.xml | 2 +- plugins/acl/static-role-based/pom.xml| 2 +- .../affinity-group-processors/explicit-dedication/pom.xml| 2 +- plugins/affinity-group-processors/host-affinity/pom.xml | 2 +- plugins/affinity-group-processors/host-anti-affinity/pom.xml | 2 +- plugins/alert-handlers/snmp-alerts/pom.xml | 2 +- plugins/alert-handlers/syslog-alerts/pom.xml | 2 +- plugins/api/discovery/pom.xml| 2 +- plugins/api/rate-limit/pom.xml | 2 +- plugins/api/solidfire-intg-test/pom.xml | 2 +- plugins/api/vmware-sioc/pom.xml | 2 +- plugins/ca/root-ca/pom.xml | 2 +- plugins/database/mysql-ha/pom.xml| 2 +- plugins/database/quota/pom.xml | 2 +- plugins/dedicated-resources/pom.xml | 2 +- plugins/deployment-planners/implicit-dedication/pom.xml | 2 +- plugins/deployment-planners/user-concentrated-pod/pom.xml| 2 +- plugins/deployment-planners/user-dispersing/pom.xml | 2 +- plugins/event-bus/inmemory/pom.xml | 2 +- plugins/event-bus/kafka/pom.xml | 2 +- plugins/event-bus/rabbitmq/pom.xml | 2 +- plugins/file-systems/netapp/pom.xml | 2 +- plugins/ha-planners/skip-heurestics/pom.xml | 2 +- plugins/host-allocators/random/pom.xml | 2 +- plugins/hypervisors/baremetal/pom.xml| 2 +-
[GitHub] [cloudstack] AndreaGHG commented on issue #3458: Cannot create zone. "Fail to create a physical network" error with VMWare 6.5 hypervisor
AndreaGHG commented on issue #3458: Cannot create zone. "Fail to create a physical network" error with VMWare 6.5 hypervisor URL: https://github.com/apache/cloudstack/issues/3458#issuecomment-507993709 @ustcweizhou I've setted up 'host' and 'management.network.cidr' settings and restarted the service, nothing has changed. Here you can find the log since the restart: [csman.log](https://github.com/apache/cloudstack/files/3353936/csman.log) Thank you! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts
blueorangutan commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-507993736 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-78 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] NuxRo commented on issue #3343: listVirtualMachines does not show instances belonging to a project
NuxRo commented on issue #3343: listVirtualMachines does not show instances belonging to a project URL: https://github.com/apache/cloudstack/issues/3343#issuecomment-507991891 Thanks Rohit, that makes sense. To be honest I would not have raised this issue had I known about projectid=-1, but that listall=true does not sound too bad if it could be done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch 4.11.3.0-RC20190625T2045 deleted (was d895983)
This is an automated email from the ASF dual-hosted git repository. paul_a pushed a change to branch 4.11.3.0-RC20190625T2045 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was d895983 Updating pom.xml version numbers for release 4.11.3.0 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
[cloudstack] branch 4.11 updated (9ac32aa -> f855e6d)
This is an automated email from the ASF dual-hosted git repository. paul_a pushed a change to branch 4.11 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 9ac32aa server: VPC redundant vrs run on same hypervisor (#3421) add d895983 Updating pom.xml version numbers for release 4.11.3.0 new f855e6d Merge branch '4.11.3.0-RC20190625T2045' into 4.11 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: debian/changelog | 6 ++ 1 file changed, 6 insertions(+)
[cloudstack] 01/01: Merge branch '4.11.3.0-RC20190625T2045' into 4.11
This is an automated email from the ASF dual-hosted git repository. paul_a pushed a commit to branch 4.11 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit f855e6d3b90cb0519c292e8a000c5fbef32cd69a Merge: 9ac32aa d895983 Author: Paul Angus AuthorDate: Wed Jul 3 09:10:24 2019 +0100 Merge branch '4.11.3.0-RC20190625T2045' into 4.11 debian/changelog | 6 ++ 1 file changed, 6 insertions(+)
[cloudstack] tag 4.11.3.0 created (now d895983)
This is an automated email from the ASF dual-hosted git repository. paul_a pushed a change to tag 4.11.3.0 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. at d895983 (commit) No new revisions were added by this update.
[GitHub] [cloudstack] blueorangutan commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts
blueorangutan commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-507986406 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #2740: Potential mismatch on guest OS - hypervisor mappings on upgrades
rhtyd commented on issue #2740: Potential mismatch on guest OS - hypervisor mappings on upgrades URL: https://github.com/apache/cloudstack/issues/2740#issuecomment-507986570 @nvazquez unless you want to send a PR before 4.13.0.0 freeze, I've moved this to the next major milestone. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts
rhtyd commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-507986264 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3343: listVirtualMachines does not show instances belonging to a project
rhtyd commented on issue #3343: listVirtualMachines does not show instances belonging to a project URL: https://github.com/apache/cloudstack/issues/3343#issuecomment-507984777 The workaround is to either specify a specific projectid= or projectid=-1. A resource under a project is owned by a project (a project account) than a member of the project, which is why such resources are not shown in the default list APIs/views. If we allow listing of all resources, then it may break the UI semantics (backward compatibility). A middle ground could be if `listall=true` is provided than all resources where user can access on could be listed on. Since we're close to 4.13.0.0, I've moved this to the next major milestone. cc @PaulAngus @ustcweizhou @NuxRo This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts
blueorangutan commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-507976473 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-77 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr commented on issue #3264: Volume snapshot listing failing when originating primary pool removed
shwstppr commented on issue #3264: Volume snapshot listing failing when originating primary pool removed URL: https://github.com/apache/cloudstack/issues/3264#issuecomment-507975121 working on this This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd closed issue #3375: listProjects API command returns same tags as many times as there are accounts in the Project
rhtyd closed issue #3375: listProjects API command returns same tags as many times as there are accounts in the Project URL: https://github.com/apache/cloudstack/issues/3375 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3375: listProjects API command returns same tags as many times as there are accounts in the Project
rhtyd commented on issue #3375: listProjects API command returns same tags as many times as there are accounts in the Project URL: https://github.com/apache/cloudstack/issues/3375#issuecomment-507975002 Closing on @shwstppr 's remark. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr commented on issue #3375: listProjects API command returns same tags as many times as there are accounts in the Project
shwstppr commented on issue #3375: listProjects API command returns same tags as many times as there are accounts in the Project URL: https://github.com/apache/cloudstack/issues/3375#issuecomment-507974906 Tested this locally with changes from #3306, fixed now. Can be closed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure
rhtyd commented on a change in pull request #3425: [WIP DO NOT MERGE] Better
tracking host maintanence success and failure
URL: https://github.com/apache/cloudstack/pull/3425#discussion_r299806698
##
File path: api/src/main/java/com/cloud/resource/ResourceState.java
##
@@ -22,17 +22,26 @@
import com.cloud.utils.fsm.StateMachine;
public enum ResourceState {
-Creating, Enabled, Disabled, PrepareForMaintenance, ErrorInMaintenance,
Maintenance, Error;
+Creating,
+Enabled,
+Disabled,
+PrepareForMaintenance,
+ErrorInMaintenance,
+Maintenance,
+Error,
+PrepareForMaintenanceErrorsPresent;
Review comment:
(minor nit)
I understand, if the intent of the new state to say errors happened while
doing `...` then I'm simply asking the name of the new state to be uniform with
other state names. For example, `Maintenance` has `ErrorInMaintenance`; so
`PrepareForMaintenance` can have a similar `ErrorInPrepareForMaintenance`
state.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure
rhtyd commented on a change in pull request #3425: [WIP DO NOT MERGE] Better
tracking host maintanence success and failure
URL: https://github.com/apache/cloudstack/pull/3425#discussion_r299806130
##
File path: server/src/main/java/com/cloud/ha/HighAvailabilityManagerImpl.java
##
@@ -101,9 +103,14 @@
* ha.retry.wait | time to wait before retrying the work item |
seconds | 120 || || stop.retry.wait | time to wait
* before retrying the stop | seconds | 120 || * }
**/
-public class HighAvailabilityManagerImpl extends ManagerBase implements
HighAvailabilityManager, ClusterManagerListener {
+public class HighAvailabilityManagerImpl extends ManagerBase implements
HighAvailabilityManager, ClusterManagerListener, Configurable {
protected static final Logger s_logger =
Logger.getLogger(HighAvailabilityManagerImpl.class);
+private ConfigKey MaxRetries = new ConfigKey<>("Advanced",
Integer.class,
+"max.retries","5",
Review comment:
If the global setting already exists, then don't rename them (for backward
compatibility reasons) or re-define them. If they are new settings rename them.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
