[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-08-02 Thread GitBox
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow 
configuring appliances on the VM instance wizard when OVF properties are 
available
URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-517852997
 
 
   Trillian test result (tid-258)
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 47161 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3271-t258-vmware-65u2.zip
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Smoke tests completed. 75 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_list_snapshots_with_removed_data_store | `Error` | 1.19 | 
test_snapshots.py
   test_01_volume_usage | `Error` | 12.52 | test_usage.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3537: Revert #3152

2019-08-02 Thread GitBox
blueorangutan commented on issue #3537: Revert #3152
URL: https://github.com/apache/cloudstack/pull/3537#issuecomment-517785221
 
 
   Trillian test result (tid-259)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 32121 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3537-t259-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Smoke tests completed. 77 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on a change in pull request #3533: KVM local migration issue #3521

2019-08-02 Thread GitBox
rhtyd commented on a change in pull request #3533: KVM local migration issue 
#3521
URL: https://github.com/apache/cloudstack/pull/3533#discussion_r310178941
 
 

 ##
 File path: 
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
 ##
 @@ -1905,6 +1911,23 @@ public void copyAsync(Map 
volumeDataStoreMap, VirtualMach
 }
 }
 
+/**
+ * Returns true if at least one of the entries on the map 
'volumeDataStoreMap' has both source and destination storage pools of Network 
Filesystem (NFS).
+ */
+protected boolean isSourceAndDestinationPoolTypeOfNfs(Map volumeDataStoreMap) {
+for (Map.Entry entry : 
volumeDataStoreMap.entrySet()) {
+VolumeInfo srcVolumeInfo = entry.getKey();
+DataStore destDataStore = entry.getValue();
+
+StoragePoolVO destStoragePool = 
_storagePoolDao.findById(destDataStore.getId());
+StoragePoolVO sourceStoragePool = 
_storagePoolDao.findById(srcVolumeInfo.getPoolId());
+if (sourceStoragePool.getPoolType() == 
StoragePoolType.NetworkFilesystem && destStoragePool.getPoolType() == 
StoragePoolType.NetworkFilesystem) {
 
 Review comment:
   @GabrielBrascher shouldn't it loop and check for all volumes before 
returning true? It could be like it can return false if any of the src/dest 
pools are not nfs


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack-documentation] branch vm-snapshot-doc-update created (now 5264ac0)

2019-08-02 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a change to branch vm-snapshot-doc-update
in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git.


  at 5264ac0  vm snapshots tags and corrections

This branch includes the following new commits:

 new 5264ac0  vm snapshots tags and corrections

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.




[cloudstack-documentation] 01/01: vm snapshots tags and corrections

2019-08-02 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a commit to branch vm-snapshot-doc-update
in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git

commit 5264ac0f37f34e47c7ac1da9304103549692e1e0
Author: Andrija Panic <45762285+andrijapani...@users.noreply.github.com>
AuthorDate: Fri Aug 2 16:05:37 2019 +0200

vm snapshots tags and corrections
---
 source/adminguide/virtual_machines.rst | 31 +++
 1 file changed, 15 insertions(+), 16 deletions(-)

diff --git a/source/adminguide/virtual_machines.rst 
b/source/adminguide/virtual_machines.rst
index 2fc74c3..9d1229d 100644
--- a/source/adminguide/virtual_machines.rst
+++ b/source/adminguide/virtual_machines.rst
@@ -416,7 +416,7 @@ To delete an affinity group:
 Virtual Machine Snapshots
 -
 
-(Supported on VMware and XenServer)
+(Supported on VMware, XenServer and KVM partially)
 
 In addition to the existing CloudStack ability to snapshot individual VM
 volumes, you can take a VM snapshot to preserve all the VM's data
@@ -441,6 +441,13 @@ create a long chain of these parent/child snapshots, which 
amount to a
 "redo" record leading from the current state of the VM back to the
 original.
 
+After VM snapshots are created, they can be tagged with a key/value pair,
+like many other resources in CloudStack.
+
+KVM supports VM snapshots when using NFS shared storage. If raw block storage
+is used (i.e. Ceph), then VM snapshots are not possible, since there is no 
possibility
+to write RAM memory content anywhere.
+
 If you need more information about VM snapshots on VMware, check out the
 VMware documentation and the VMware Knowledge Base, especially
 `Understanding virtual machine snapshots 
@@ -475,22 +482,14 @@ The cloud administrator can use global configuration 
variables to
 control the behavior of VM snapshots. To set these variables, go through
 the Global Settings area of the CloudStack UI.
 
-Configuration Setting Name
-
-Description
-
-vmsnapshots.max
-
-The maximum number of VM snapshots that can be saved for any given
-virtual machine in the cloud. The total possible number of VM snapshots
-in the cloud is (number of VMs) \* vmsnapshots.max. If the number of
-snapshots for any VM ever hits the maximum, the older ones are removed
-by the snapshot expunge job.
-
-vmsnapshot.create.wait
+.. cssclass:: table-striped table-bordered table-hover
 
-Number of seconds to wait for a snapshot job to succeed before declaring
-failure and issuing an error.
+== 
+Configuration  Description   Type
+== 
+vmsnapshots.maxThe maximum number of VM snapshots that can be saved 
for any given virtual machine in the cloud. The total possible number of VM 
snapshots in the cloud is (number of VMs) \* vmsnapshots.max. If the number of 
snapshots for any VM ever hits the maximum, the older ones are removed by the 
snapshot expunge job
+vmsnapshot.create.wait Number of seconds to wait for a snapshot job to succeed 
before declaring failure and issuing an error.
+== 
 
 
 Using VM Snapshots



[GitHub] [cloudstack] rhtyd commented on issue #3537: Revert #3152

2019-08-02 Thread GitBox
rhtyd commented on issue #3537: Revert #3152
URL: https://github.com/apache/cloudstack/pull/3537#issuecomment-517686852
 
 
   Smoketests are not in yet @andrijapanicsb


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb merged pull request #3537: Revert #3152

2019-08-02 Thread GitBox
andrijapanicsb merged pull request #3537: Revert #3152
URL: https://github.com/apache/cloudstack/pull/3537
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb merged pull request #3535: Misc fixes to sharing templates functionality

2019-08-02 Thread GitBox
andrijapanicsb merged pull request #3535: Misc fixes to sharing templates 
functionality
URL: https://github.com/apache/cloudstack/pull/3535
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack] branch master updated (d3b292a -> a9569d5)

2019-08-02 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from d3b292a  server: Fixes API permissions, global settings and template 
UX (#3534)
 new 8190b68  Misc fixes to sharing templates functionality
 new f9b3771  Add usernames to map for remove operations as well
 new a9569d5  Merge pull request #3535 from shapeblue/minor_413_fixes

The 32132 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 ui/scripts/cloudStack.js  |  4 
 ui/scripts/sharedFunctions.js |  2 +-
 ui/scripts/templates.js   | 16 ++--
 3 files changed, 15 insertions(+), 7 deletions(-)



[GitHub] [cloudstack] andrijapanicsb commented on issue #3535: Misc fixes to sharing templates functionality

2019-08-02 Thread GitBox
andrijapanicsb commented on issue #3535: Misc fixes to sharing templates 
functionality
URL: https://github.com/apache/cloudstack/pull/3535#issuecomment-517653038
 
 
   Merging based on 2 x LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3537: Revert #3152

2019-08-02 Thread GitBox
blueorangutan commented on issue #3537: Revert #3152
URL: https://github.com/apache/cloudstack/pull/3537#issuecomment-517604271
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3537: Revert #3152

2019-08-02 Thread GitBox
rhtyd commented on issue #3537: Revert #3152
URL: https://github.com/apache/cloudstack/pull/3537#issuecomment-517604179
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3537: Revert #3152

2019-08-02 Thread GitBox
blueorangutan commented on issue #3537: Revert #3152
URL: https://github.com/apache/cloudstack/pull/3537#issuecomment-517603384
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-211


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-08-02 Thread GitBox
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow 
configuring appliances on the VM instance wizard when OVF properties are 
available
URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-517598263
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-08-02 Thread GitBox
rhtyd commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring 
appliances on the VM instance wizard when OVF properties are available
URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-517598089
 
 
   @blueorangutan test centos7 vmware-65u2


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3536: Extract systemvm.iso using bsdtar if available.

2019-08-02 Thread GitBox
rhtyd commented on issue #3536: Extract systemvm.iso using bsdtar if available.
URL: https://github.com/apache/cloudstack/pull/3536#issuecomment-517597155
 
 
   @cl-k-takahashi I've moved the milestone to 4.14, in which we'll remove 
support for CentOS6 (reference https://markmail.org/message/eenfpyya2wfgd2gw), 
then your PR will be acceptable. Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3537: Revert #3152

2019-08-02 Thread GitBox
rhtyd commented on issue #3537: Revert #3152
URL: https://github.com/apache/cloudstack/pull/3537#issuecomment-517596230
 
 
   Backend packaging kicked.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd edited a comment on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage)

2019-08-02 Thread GitBox
rhtyd edited a comment on issue #3538: Refactoring to remove duplicate code (by 
Frank/Nuage)
URL: https://github.com/apache/cloudstack/pull/3538#issuecomment-517594071
 
 
   @fmaximus please see https://github.com/apache/cloudstack/pull/3537, we'll 
need to revert your PR #3152 for this purpose I've reopened your PR from the 
original branch. Kindly help test and fix regressions discovered in your 
branch, esp around registration and upload of archived templates and iso 
(templates/isos that are extractable like *.bz2, *gz etc).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd removed a comment on issue #3537: Revert #3152

2019-08-02 Thread GitBox
rhtyd removed a comment on issue #3537: Revert #3152
URL: https://github.com/apache/cloudstack/pull/3537#issuecomment-517594261
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3537: Revert #3152

2019-08-02 Thread GitBox
rhtyd commented on issue #3537: Revert #3152
URL: https://github.com/apache/cloudstack/pull/3537#issuecomment-517594388
 
 
   @blueorangutan package
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3537: Revert #3152

2019-08-02 Thread GitBox
rhtyd commented on issue #3537: Revert #3152
URL: https://github.com/apache/cloudstack/pull/3537#issuecomment-517594261
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan removed a comment on issue #3537: Revert #3152

2019-08-02 Thread GitBox
blueorangutan removed a comment on issue #3537: Revert #3152
URL: https://github.com/apache/cloudstack/pull/3537#issuecomment-517495977
 
 
   Trillian test result (tid-252)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 36283 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3537-t252-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_affinity_groups_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_deploy_vm_with_userdata.py
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_domain_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
   Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_multipleips_per_nic.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_nested_virtualization.py
   Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_network.py
   Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_portforwardingrules.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_resource_accounting.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers.py
   Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 39 look OK, 38 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
   ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | 
test_accounts.py
   test_DeleteDomain | `Error` | 1.46 | test_accounts.py
   test_forceDeleteDomain | `Error` | 1.45 | test_accounts.py
   ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 5.90 | 
test_accounts.py
   ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | 
test_affinity_groups_projects.py
   test_query_async_job_result | `Error` | 0.00 | test_async_job.py
   ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | 
test_deploy_virtio_scsi_vm.py
   ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | 
test_internal_lb.py
   test_deploy_vm_from_iso | `Error` | 0.00 | test_deploy_vm_iso.py
   ContextSuite context=TestDeployVmWithVariedPlanners>:setup | `Error` | 0.00 
| test_deploy_vms_with_varied_deploymentplanners.py
   test_01_create_iso | `Failure` | 1515.44 | test_iso.py
   ContextSuite context=TestISO>:setup | `Error` | 3032.02 | test_iso.py
   ContextSuite context=TestDeployVmWithUserData>:setup | `Error` | 0.00 | 
test_deploy_vm_with_userdata.py
   ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | 
test_diagnostics.py
   ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | 
test_loadbalance.py
   ContextSuite context=TestDomainsServiceOfferings>:setup | `Error` | 3.79 | 

[GitHub] [cloudstack] rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage)

2019-08-02 Thread GitBox
rhtyd commented on issue #3538: Refactoring to remove duplicate code (by 
Frank/Nuage)
URL: https://github.com/apache/cloudstack/pull/3538#issuecomment-517594071
 
 
   @fmaximus please see https://github.com/apache/cloudstack/pull/3537, we'll 
need to revert your PR #3152 for this purpose I've reopened your PR from the 
original branch. Kindly help test and fix regressions discovered in your 
branch, esp around registration and upload of archived templates and iso 
(templates/isos that are extractable liike *.bz2, *gz etc).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3152: Refactoring to remove duplicate code.

2019-08-02 Thread GitBox
rhtyd commented on issue #3152: Refactoring to remove duplicate code.
URL: https://github.com/apache/cloudstack/pull/3152#issuecomment-517593226
 
 
   Reopened it here: https://github.com/apache/cloudstack/pull/3538


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd opened a new pull request #3538: Refactoring to remove duplicate code

2019-08-02 Thread GitBox
rhtyd opened a new pull request #3538: Refactoring to remove duplicate code
URL: https://github.com/apache/cloudstack/pull/3538
 
 
   Re-created PR as #3152 caused regressions. This PR can be attempted to fix 
those regressions and merged towards 4.14.
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [x] Cleanup (Code refactoring and cleanup, that may add test cases)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-08-02 Thread GitBox
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow 
configuring appliances on the VM instance wizard when OVF properties are 
available
URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-517586442
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-210


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-08-02 Thread GitBox
borisstoyanov commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow 
configuring appliances on the VM instance wizard when OVF properties are 
available
URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-517579558
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-08-02 Thread GitBox
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow 
configuring appliances on the VM instance wizard when OVF properties are 
available
URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-517579771
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] cl-k-takahashi commented on issue #3536: Extract systemvm.iso using bsdtar if available.

2019-08-02 Thread GitBox
cl-k-takahashi commented on issue #3536: Extract systemvm.iso using bsdtar if 
available.
URL: https://github.com/apache/cloudstack/pull/3536#issuecomment-517571024
 
 
   I added bsdtar as the dependency for rpm(CentOS7)/debian packages.
   The cloud.spec for CentOS 6 is untouched.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services