[GitHub] [cloudstack] kioie commented on a change in pull request #3522: New API endpoint: UpdateVlanIpRange
kioie commented on a change in pull request #3522: New API endpoint: UpdateVlanIpRange URL: https://github.com/apache/cloudstack/pull/3522#discussion_r311844222 ## File path: api/src/org/apache/cloudstack/api/command/admin/vlan/UpdateVlanIpRangeCmd.java ## @@ -0,0 +1,137 @@ +package org.apache.cloudstack.api.command.admin.vlan; Review comment: added This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519334950 Trillian test result (tid-285) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32678 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3271-t285-vmware-65u2.zip Intermittent failure detected: /marvin/tests/smoke/test_network.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Smoke tests completed. 73 look OK, 4 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_reboot_router | `Error` | 276.16 | test_network.py test_08_start_router | `Error` | 49.17 | test_routers.py test_09_reboot_router | `Error` | 1.10 | test_routers.py test_02_list_snapshots_with_removed_data_store | `Error` | 1.15 | test_snapshots.py test_01_volume_usage | `Error` | 8.34 | test_usage.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519315633 Trillian test result (tid-283) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 26433 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3271-t283-xenserver-71.zip Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py Smoke tests completed. 75 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_03_list_snapshots | `Error` | 0.03 | test_list_ids_parameter.py test_01_scale_vm | `Failure` | 13.35 | test_scale_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] kioie commented on a change in pull request #3532: Add new "Add volume" button, to add volume to VM instance directly
kioie commented on a change in pull request #3532: Add new "Add volume" button, to add volume to VM instance directly URL: https://github.com/apache/cloudstack/pull/3532#discussion_r311722997 ## File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java ## @@ -736,8 +717,47 @@ public VolumeVO allocVolume(CreateVolumeCmd cmd) throws ResourceAllocationExcept String userSpecifiedName = getVolumeNameFromCommand(cmd); -return commitVolume(cmd, caller, owner, displayVolume, zoneId, diskOfferingId, provisioningType, size, minIops, maxIops, parentVolume, userSpecifiedName, +VolumeVO volume= commitVolume(cmd, caller, owner, displayVolume, zoneId, diskOfferingId, provisioningType, size, +minIops, +maxIops, parentVolume, userSpecifiedName, _uuidMgr.generateUuid(Volume.class, cmd.getCustomId())); + Review comment: Is this better now? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519176163 @nvazquez a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
nvazquez commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519176099 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] onitake commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception
onitake commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception URL: https://github.com/apache/cloudstack/pull/3546#issuecomment-519174665 Sorry, scratch that last remark. These function only get a boolean return value. No risk of an NPE there. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519172743 Trillian test result (tid-277) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 30806 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3271-t277-xenserver-71.zip Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py Smoke tests completed. 75 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_03_list_snapshots | `Error` | 0.05 | test_list_ids_parameter.py test_01_scale_vm | `Failure` | 15.57 | test_scale_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] onitake commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception
onitake commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception URL: https://github.com/apache/cloudstack/pull/3546#issuecomment-519171822 I suspect that `orchestrateDeleteVMSnapshot(VmWorkDeleteVMSnapshot work)` and `orchestrateDeleteAllVMSnapshots(VmWorkDeleteAllVMSnapshots work)` have similar problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] onitake commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception
onitake commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception URL: https://github.com/apache/cloudstack/pull/3546#issuecomment-519170384 `VMSnapshotManagerImpl.orchestrateCreateVMSnapshot(Long vmId, Long vmSnapshotId, Boolean quiescevm)` is used in two places: - `VMSnapshotManagerImpl.orchestrateCreateVMSnapshot(VmWorkCreateVMSnapshot work)` where the null value will lead to the NPE and stray DB entry - `VMSnapshotManagerImpl.createVMSnapshot(Long vmId, Long vmSnapshotId, Boolean quiescevm)` where it is returned directly `createVMSnapshot` in turn is used in two places: - `CreateVMSnapshotCmd.execute()`, where the null value is checked and a different exception is thrown (`ServerApiException`) - `StorageSystemSnapshotStrategy.takeHypervisorSnapshot(VolumeInfo volumeInfo)` where the null value is also checked and a `CloudRuntimeException` is thrown. An alternative fix for the NPE would be to modify `VMSnapshotManagerImpl.orchestrateCreateVMSnapshot(VmWorkCreateVMSnapshot work) in the snapshot.getId()` to check for a null value before calling `getId()`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack-documentation] branch service-offerings-linked-to-zones-doc-update updated (c3aa1b4 -> c923762)
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch service-offerings-linked-to-zones-doc-update in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from c3aa1b4 service-offerings-linked-to-zones-doc-update add c923762 typo No new revisions were added by this update. Summary of changes: source/adminguide/service_offerings.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519158261 Trillian test result (tid-278) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28678 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3271-t278-kvm-centos7.zip Smoke tests completed. 77 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519156564 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-234 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack-documentation] branch service-offerings-linked-to-zones-doc-update created (now c3aa1b4)
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch service-offerings-linked-to-zones-doc-update in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. at c3aa1b4 service-offerings-linked-to-zones-doc-update This branch includes the following new commits: new c3aa1b4 service-offerings-linked-to-zones-doc-update The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[cloudstack-documentation] 01/01: service-offerings-linked-to-zones-doc-update
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a commit to branch service-offerings-linked-to-zones-doc-update in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git commit c3aa1b43ab7b2e0c1a8a09128e147dbedabdd033 Author: Andrija Panic <45762285+andrijapani...@users.noreply.github.com> AuthorDate: Wed Aug 7 17:44:04 2019 +0200 service-offerings-linked-to-zones-doc-update Added explanation that service offerings can be linked to specific zones --- source/adminguide/service_offerings.rst | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/source/adminguide/service_offerings.rst b/source/adminguide/service_offerings.rst index 29975c7..a02ad34 100644 --- a/source/adminguide/service_offerings.rst +++ b/source/adminguide/service_offerings.rst @@ -57,12 +57,27 @@ present users with choices when creating a new instance: creating a new instance. For example, CloudStack includes CentOS as a template. See Working with Templates. -In addition to these choices that are provided for users, there is +In addition to these choices that are provided for users, there is another type of service offering which is available only to the CloudStack -root administrator, and is used for configuring virtual infrastructure -resources. For more information, see Upgrading a Virtual Router with +root administrator, and is used for configuring virtual infrastructure +resources. For more information, see Upgrading a Virtual Router with System Service Offerings. +Compute offering, disk offering, network offering and VPC offering cab be +linked (made available to) specific domain(s) and zone(s) or to all domains/zones. +Existing offerings can be updated with updateServiceOffering, updateDiskOffering, +updateNetworkOffering and updateVpcOffering API calls, by passing "domainid" and +"zoneid" parameters. To make a domain-specific offering public with root admin access, +“domainid=public” can be passed in the API call. To make a zone-specific offering available +for all zones with root admin access, “zoneid=all” can be passed in the API call. +Domain-admins can update service or compute offerings. However, they cannot change zones +for the offerings specified for their domain or subdomains. They cannot change the name, display text, +sort-key for offerings specified for their domains/subdomains and for other +domains which are not child domain for them. They can change domains (within +their subdomains) for the offerings specified for their domains/subdomains, +even if the offering is also specified for other domains which are not child +domain for them as such domains will not be affected by the update operation + Compute and Disk Service Offerings --
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519148516 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
nvazquez commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519148327 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] onitake opened a new pull request #3546: [FIX] Rethrow takeVMSnapshot() exception
onitake opened a new pull request #3546: [FIX] Rethrow takeVMSnapshot() exception URL: https://github.com/apache/cloudstack/pull/3546 ## Description This patch changes the behaviour of `VMSnapshotManagerImpl.VMSnapshot orchestrateCreateVMSnapshot(Long vmId, Long vmSnapshotId, Boolean quiescevm)` to rethrow the exception when `takeVMSnapshot()` fails, instead of returning null. If null is returned, this will lead to a NullPointerException in `VMSnapshotManagerImpl.orchestrateCreateVMSnapshot(VmWorkCreateVMSnapshot work)` in the `snapshot.getId()` call, and causes an incomplete snapshot entry to remain in the database. Fixes: #3518 See there for more details. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? This change has not been tested yet. At this point, it is unknown if it will cause unexpected side effects. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519106539 Trillian test result (tid-279) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 21426 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3271-t279-vmware-65u2.zip Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 56 look OK, 21 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py test_01_so_removal_resource_update | `Error` | 1.44 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py test_01_sys_vm_start | `Failure` | 0.11 | test_secondary_storage.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py test_02_routervm_iptables_policies | `Error` | 1.38 | test_routers_iptables_default_policy.py test_01_single_VPC_iptables_policies | `Error` | 5.44 | test_routers_iptables_default_policy.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 1.50 | test_routers_network_ops.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 1.52 | test_routers_network_ops.py test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Error` | 4.71 | test_routers_network_ops.py test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 6.00 | test_routers_network_ops.py test_03_RVR_Network_check_router_state | `Error` | 6.00 | test_routers_network_ops.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py ContextSuite context=TestScaleVm>:setup | `Error` | 0.00 | test_scale_vm.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 2.34 | test_service_offerings.py test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py test_02_list_cpvm_vm | `Failure` | 0.04 | test_ssvm.py test_03_ssvm_internals | `Failure` | 0.03 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.03 | test_ssvm.py test_05_stop_ssvm | `Failure` | 0.03 | test_ssvm.py test_06_stop_cpvm | `Failure` | 0.03 | test_ssvm.py test_07_reboot_ssvm | `Failure` | 0.03 | test_ssvm.py test_08_reboot_cpvm | `Failure` | 0.04 | test_ssvm.py test_09_destroy_ssvm | `Failure` | 0.03 | test_ssvm.py test_10_destroy_cpvm | `Failure` | 0.04 | test_ssvm.py test_02_create_template_with_checksum_sha1 | `Error` | 65.48 | test_templates.py test_03_create_template_with_checksum_sha256 | `Error` | 65.47 | test_templates.py test_04_create_template_with_checksum_md5 | `Error` | 65.50 | test_templates.py test_05_create_template_with_no_checksum | `Error` | 65.47 | test_templates.py ContextSuite
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519106417 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-233 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519097638 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
borisstoyanov commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519097274 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: ui: fix for custom constrained offering params range check (#3545)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new a10e539 ui: fix for custom constrained offering params range check
(#3545)
a10e539 is described below
commit a10e539dd6226dc98d36bc2a459b69be48b5a947
Author: Abhishek Kumar
AuthorDate: Wed Aug 7 18:38:22 2019 +0530
ui: fix for custom constrained offering params range check (#3545)
This PR fixes range check in VM deployment wizard while using custom
constrained offering.
Existing code was failing while checking user input value in the form for
CPU cores and RAM size when minimum and maximum value vary in digit count.
Also, while re-selecting offerings slider position was not restored to
minimum value. THis has been fixed with changes.
Signed-off-by: Abhishek Kumar
---
ui/scripts/ui-custom/instanceWizard.js | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/ui/scripts/ui-custom/instanceWizard.js
b/ui/scripts/ui-custom/instanceWizard.js
index 5ce1870..b240c37 100644
--- a/ui/scripts/ui-custom/instanceWizard.js
+++ b/ui/scripts/ui-custom/instanceWizard.js
@@ -636,8 +636,8 @@
$step.find('.custom-slider-container').show();
var setupSlider =
function(sliderClassName, minVal, maxVal) {
$step.find('.custom-slider-container .' + sliderClassName + ' .size.min
span').html(minVal);
-
$step.find('.custom-slider-container .' + sliderClassName + '
input[type=text]').val(minVal);
$step.find('.custom-slider-container .' + sliderClassName + ' .size.max
span').html(maxVal);
+
$step.find('.custom-slider-container .' + sliderClassName + '
input[type=text]').val(minVal);
$step.find('.custom-slider-container .' + sliderClassName + '
.slider').each(function() {
var $slider = $(this);
$slider.slider({
@@ -651,20 +651,22 @@
});
$step.find('.custom-slider-container .' + sliderClassName + '
input[type=text]').bind('change', function() {
-var val =
$step.find('.custom-slider-container .' + sliderClassName + '
input[type=text]').val();
+var val =
parseInt($(this).val(), 10);
if (val < minVal ||
val > maxVal) {
cloudStack.dialog.notice({ message:
$.validator.format(_l('message.validate.range'), [minVal, maxVal]) });
}
if (val < minVal) {
val = minVal;
-
$step.find('.custom-slider-container .' + sliderClassName + '
input[type=text]').val(val);
+$(this).val(val);
}
if(val > maxVal) {
val = maxVal;
-
$step.find('.custom-slider-container .' + sliderClassName + '
input[type=text]').val(val);
+$(this).val(val);
}
$step.find('span.custom-slider-container .' + sliderClassName).html(_s(val));
+
$step.find('.custom-slider-container .' + sliderClassName + '
span.ui-slider-handle').css('left', (((val-minVal)/(maxVal-minVal))*100)+'%');
});
+
$step.find('.custom-slider-container .' + sliderClassName + '
span.ui-slider-handle').css('left', '0%');
}
setupSlider('slider-cpu-cores', minCpuNumber, maxCpuNumber);
setupSlider('slider-memory-mb', minMemory, maxMemory);
[GitHub] [cloudstack] rhtyd merged pull request #3545: ui: fix for custom constrained offering params range check
rhtyd merged pull request #3545: ui: fix for custom constrained offering params range check URL: https://github.com/apache/cloudstack/pull/3545 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3517: 4.13.0.0/master: health checks smoketests
blueorangutan commented on issue #3517: 4.13.0.0/master: health checks smoketests URL: https://github.com/apache/cloudstack/pull/3517#issuecomment-519082420 Trillian test result (tid-276) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 27134 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3517-t276-xenserver-71.zip Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py Smoke tests completed. 75 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_03_list_snapshots | `Error` | 0.06 | test_list_ids_parameter.py test_01_scale_vm | `Failure` | 14.54 | test_scale_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr commented on issue #3517: 4.13.0.0/master: health checks smoketests
shwstppr commented on issue #3517: 4.13.0.0/master: health checks smoketests URL: https://github.com/apache/cloudstack/pull/3517#issuecomment-519079962 VMware router start failure is with, ``` 2019-08-05 15:41:04,252 ERROR [c.c.u.s.SshHelper] (DirectAgent-177:ctx-8fff0c25 10.2.2.141, job-1912/job-1913, cmd: AggregationControlCommand) (logid:cf1e62b8) SSH execution of command /opt/cloud/bin/vr_cfg.sh -c /var/cache/cloud/VR-0eb49049-ddcc-4176-9b97-ad1cac301d3b.cfg has an error status code in return. Result output: 2019-08-05 15:41:04,252 DEBUG [c.c.h.v.r.VmwareResource] (DirectAgent-177:ctx-8fff0c25 10.2.2.141, job-1912/job-1913, cmd: AggregationControlCommand) (logid:cf1e62b8) vr_cfg.sh execution result: false ``` On manual stop/start VR, script execution returns true with following output, ``` P[true:Error: argument "table" is wrong: node type value is invalid RTNETLINK answers: File exists Error: argument "table" is wrong: node type value is invalid RTNETLINK answers: File exists Error: argument "table" is wrong: node type value is invalid RTNETLINK answers: File exists Error: argument "table" is wrong: node type value is invalid RTNETLINK answers: File exists [Wed Aug 7 12:44:20 2019] (pid=2105) [ERROR] can't open config file `/etc/conntrackd/conntrackd.conf' ] ``` Will further investigate This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3545: ui: fix for custom constrained offering params range check
blueorangutan commented on issue #3545: ui: fix for custom constrained offering params range check URL: https://github.com/apache/cloudstack/pull/3545#issuecomment-519077001 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-232 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3545: ui: fix for custom constrained offering params range check
blueorangutan commented on issue #3545: ui: fix for custom constrained offering params range check URL: https://github.com/apache/cloudstack/pull/3545#issuecomment-519069969 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr commented on issue #3545: ui: fix for custom constrained offering params range check
shwstppr commented on issue #3545: ui: fix for custom constrained offering params range check URL: https://github.com/apache/cloudstack/pull/3545#issuecomment-519069781 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3545: ui: fix for custom constrained offering params range check
blueorangutan commented on issue #3545: ui: fix for custom constrained offering params range check URL: https://github.com/apache/cloudstack/pull/3545#issuecomment-519057931 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-231 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage)
blueorangutan commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage) URL: https://github.com/apache/cloudstack/pull/3538#issuecomment-519057125 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-230 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion
blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3540#issuecomment-519041693 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-229 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3545: ui: fix for custom constrained offering params range check
blueorangutan commented on issue #3545: ui: fix for custom constrained offering params range check URL: https://github.com/apache/cloudstack/pull/3545#issuecomment-519039901 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3545: ui: fix for custom constrained offering params range check
borisstoyanov commented on issue #3545: ui: fix for custom constrained offering params range check URL: https://github.com/apache/cloudstack/pull/3545#issuecomment-519039728 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage)
blueorangutan commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage) URL: https://github.com/apache/cloudstack/pull/3538#issuecomment-519038071 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage)
rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage) URL: https://github.com/apache/cloudstack/pull/3538#issuecomment-519037899 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr commented on issue #3545: ui: fix for custom constrained offering params range check
shwstppr commented on issue #3545: ui: fix for custom constrained offering params range check URL: https://github.com/apache/cloudstack/pull/3545#issuecomment-519037374 @borisstoyanov @andrijapanicsb @anuragaw @rhtyd @svenvogel kindly consider this for 4.13 milestone and please review changes This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr opened a new pull request #3545: ui: fix for custom constrained offering params range check
shwstppr opened a new pull request #3545: ui: fix for custom constrained offering params range check URL: https://github.com/apache/cloudstack/pull/3545 ## Description This PR fixes range check in VM deployment wizard while using custom constrained offering. Existing code was failing while checking user input value in the form for CPU cores and RAM size when minimum and maximum value vary in digit count. Also, while re-selecting offerings slider position was not restored to minimum value. THis has been fixed with changes. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): Entering a valid value for RAM but getting error,   Selecting custom constrained offering initially, then making changes for CPU, RAM parameters, then selecting a fixed offering and then again selecting custom constrained offering. Though text input shows minimum values but slider is not at the start.   ## How Has This Been Tested? UI This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: KVM local migration issue #3521 (#3533)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new 5dc982d KVM local migration issue #3521 (#3533)
5dc982d is described below
commit 5dc982d8bab4ed16533dd56b39e98dadc79eeafe
Author: Gabriel Beims Bräscher
AuthorDate: Wed Aug 7 07:11:30 2019 -0300
KVM local migration issue #3521 (#3533)
Fix regression bug that affects KVM local storage migration. Some of the
desired execution flows for KVM local storage migration had been altered to
allow only managed storage to execute. Fixed allowing managed and non managed
storages to execute.
Fixes #3521
---
.../java/com/cloud/agent/api/MigrateCommand.java | 9
.../motion/StorageSystemDataMotionStrategy.java| 40 +++
.../StorageSystemDataMotionStrategyTest.java | 60 ++
.../hypervisor/kvm/resource/MigrateKVMAsync.java | 12 ++---
.../wrapper/LibvirtMigrateCommandWrapper.java | 4 +-
5 files changed, 109 insertions(+), 16 deletions(-)
diff --git a/core/src/main/java/com/cloud/agent/api/MigrateCommand.java
b/core/src/main/java/com/cloud/agent/api/MigrateCommand.java
index 93324d2..c7aeb69 100644
--- a/core/src/main/java/com/cloud/agent/api/MigrateCommand.java
+++ b/core/src/main/java/com/cloud/agent/api/MigrateCommand.java
@@ -32,6 +32,7 @@ public class MigrateCommand extends Command {
private String destIp;
private Map migrateStorage;
private boolean migrateStorageManaged;
+private boolean migrateNonSharedInc;
private boolean autoConvergence;
private String hostGuid;
private boolean isWindows;
@@ -75,6 +76,14 @@ public class MigrateCommand extends Command {
this.migrateStorageManaged = migrateStorageManaged;
}
+public boolean isMigrateNonSharedInc() {
+return migrateNonSharedInc;
+}
+
+public void setMigrateNonSharedInc(boolean migrateNonSharedInc) {
+this.migrateNonSharedInc = migrateNonSharedInc;
+}
+
public void setAutoConvergence(boolean autoConvergence) {
this.autoConvergence = autoConvergence;
}
diff --git
a/engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
b/engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
index 45cd295..4d3ec18 100644
---
a/engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
+++
b/engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
@@ -1828,16 +1828,19 @@ public class StorageSystemDataMotionStrategy implements
DataMotionStrategy {
String destPath = generateDestPath(destHost, destStoragePool,
destVolumeInfo);
MigrateCommand.MigrateDiskInfo migrateDiskInfo;
-if (managedStorageDestination) {
-migrateDiskInfo = configureMigrateDiskInfo(srcVolumeInfo,
destPath);
-
migrateDiskInfo.setSourceDiskOnStorageFileSystem(isStoragePoolTypeOfFile(sourceStoragePool));
-migrateDiskInfoList.add(migrateDiskInfo);
-} else {
+
+boolean isNonManagedNfsToNfs = sourceStoragePool.getPoolType()
== StoragePoolType.NetworkFilesystem
+&& destStoragePool.getPoolType() ==
StoragePoolType.NetworkFilesystem && !managedStorageDestination;
+if (isNonManagedNfsToNfs) {
migrateDiskInfo = new
MigrateCommand.MigrateDiskInfo(srcVolumeInfo.getPath(),
MigrateCommand.MigrateDiskInfo.DiskType.FILE,
MigrateCommand.MigrateDiskInfo.DriverType.QCOW2,
MigrateCommand.MigrateDiskInfo.Source.FILE,
connectHostToVolume(destHost,
destVolumeInfo.getPoolId(), volumeIdentifier));
+} else {
+migrateDiskInfo = configureMigrateDiskInfo(srcVolumeInfo,
destPath);
+
migrateDiskInfo.setSourceDiskOnStorageFileSystem(isStoragePoolTypeOfFile(sourceStoragePool));
+migrateDiskInfoList.add(migrateDiskInfo);
}
migrateStorage.put(srcVolumeInfo.getPath(), migrateDiskInfo);
@@ -1864,11 +1867,14 @@ public class StorageSystemDataMotionStrategy implements
DataMotionStrategy {
VMInstanceVO vm = _vmDao.findById(vmTO.getId());
boolean isWindows =
_guestOsCategoryDao.findById(_guestOsDao.findById(vm.getGuestOSId()).getCategoryId()).getName().equalsIgnoreCase("Windows");
+boolean migrateNonSharedInc =
isSourceAndDestinationPoolTypeOfNfs(volumeDataStoreMap);
+
MigrateCommand migrateCommand = new
[GitHub] [cloudstack] rhtyd merged pull request #3533: KVM local migration issue #3521
rhtyd merged pull request #3533: KVM local migration issue #3521 URL: https://github.com/apache/cloudstack/pull/3533 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd closed issue #3521: Regression bug in 4.13.0.0-SNAPSHOT that affects KVM local storage migration
rhtyd closed issue #3521: Regression bug in 4.13.0.0-SNAPSHOT that affects KVM local storage migration URL: https://github.com/apache/cloudstack/issues/3521 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3533: KVM local migration issue #3521
rhtyd commented on issue #3533: KVM local migration issue #3521 URL: https://github.com/apache/cloudstack/pull/3533#issuecomment-519033783 I think for EL6, storage migration (live) would be limiting. The feature should largely be encouraged on newer distros with newer libvirt. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-518974000 @borisstoyanov a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
borisstoyanov commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-518973810 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
