[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3600: Allow deploy Admin/System VMs in disabled zones/pods/clusters
GabrielBrascher commented on a change in pull request #3600: Allow deploy
Admin/System VMs in disabled zones/pods/clusters
URL: https://github.com/apache/cloudstack/pull/3600#discussion_r327940429
##
File path:
engine/components-api/src/main/java/com/cloud/deploy/DeploymentPlanningManager.java
##
@@ -24,6 +26,12 @@
public interface DeploymentPlanningManager extends Manager {
+static final ConfigKey allowSytemVmInDisabledResource = new
ConfigKey("Advanced", Boolean.class,
"allow.system.vm.disabled.resource", "true",
+"Allow deploying System VMs in disabled Clusters, Pods, and Zones
(does not require restart)", true);
+
+static final ConfigKey allowAdminVmInDisabledResource = new
ConfigKey("Advanced", Boolean.class,
"allow.admin.vm.disabled.resources", "false",
Review comment:
@rhtyd I've added a commit addressing your comment, thx!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3604: Fix Policy Based Routing for private gateway static routes
blueorangutan commented on issue #3604: Fix Policy Based Routing for private gateway static routes URL: https://github.com/apache/cloudstack/pull/3604#issuecomment-534861741 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot'
blueorangutan commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot' URL: https://github.com/apache/cloudstack/pull/3605#issuecomment-534861500 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3604: Fix Policy Based Routing for private gateway static routes
rhtyd commented on issue #3604: Fix Policy Based Routing for private gateway static routes URL: https://github.com/apache/cloudstack/pull/3604#issuecomment-534861537 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3608: server: Cleanup dhcp and dns entries only on expunging VM
blueorangutan commented on issue #3608: server: Cleanup dhcp and dns entries only on expunging VM URL: https://github.com/apache/cloudstack/pull/3608#issuecomment-534861272 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot'
rhtyd commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot' URL: https://github.com/apache/cloudstack/pull/3605#issuecomment-534861278 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3608: server: Cleanup dhcp and dns entries only on expunging VM
rhtyd commented on issue #3608: server: Cleanup dhcp and dns entries only on expunging VM URL: https://github.com/apache/cloudstack/pull/3608#issuecomment-534861188 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3608: server: Cleanup dhcp and dns entries only on expunging VM
blueorangutan commented on issue #3608: server: Cleanup dhcp and dns entries only on expunging VM URL: https://github.com/apache/cloudstack/pull/3608#issuecomment-534858902 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-290 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3607: allocator: in case of null guest OS don't fail prioritisation completely
blueorangutan commented on issue #3607: allocator: in case of null guest OS don't fail prioritisation completely URL: https://github.com/apache/cloudstack/pull/3607#issuecomment-534856488 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-289 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3607: allocator: in case of null guest OS don't fail prioritisation completely
blueorangutan commented on issue #3607: allocator: in case of null guest OS don't fail prioritisation completely URL: https://github.com/apache/cloudstack/pull/3607#issuecomment-534856634 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3607: allocator: in case of null guest OS don't fail prioritisation completely
rhtyd commented on issue #3607: allocator: in case of null guest OS don't fail prioritisation completely URL: https://github.com/apache/cloudstack/pull/3607#issuecomment-534856569 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3608: server: Cleanup dhcp and dns entries only on expunging VM
blueorangutan commented on issue #3608: server: Cleanup dhcp and dns entries only on expunging VM URL: https://github.com/apache/cloudstack/pull/3608#issuecomment-534853226 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3608: server: Cleanup dhcp and dns entries only on expunging VM
rhtyd commented on issue #3608: server: Cleanup dhcp and dns entries only on expunging VM URL: https://github.com/apache/cloudstack/pull/3608#issuecomment-534853117 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd opened a new pull request #3608: server: Cleanup dhcp and dns entries only on expunging VM
rhtyd opened a new pull request #3608: server: Cleanup dhcp and dns entries only on expunging VM URL: https://github.com/apache/cloudstack/pull/3608 This fixes a behaviour to not cleanup DHCP and DNS rules for NICs of a VM in the VR when it is stopped, but instead when VM is expunged because stopped VMs in CloudStack still retain the IPs and records. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [x] Cleanup (Code refactoring and cleanup, that may add test cases) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3607: allocator: in case of null guest OS don't fail prioritisation completely
blueorangutan commented on issue #3607: allocator: in case of null guest OS don't fail prioritisation completely URL: https://github.com/apache/cloudstack/pull/3607#issuecomment-534851003 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated (8170ec5 -> 7f91964)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 8170ec5 kvm: Logrotate should not touch agent.log (#3597) add 7f91964 refactoring: Remove duplicate code (by Frank/Nuage) (#3538) No new revisions were added by this update. Summary of changes: .../com/cloud/template/VirtualMachineTemplate.java | 2 - .../cloudstack/api/BaseListTaggedResourcesCmd.java | 22 +-- .../api/BaseListTemplateOrIsoPermissionsCmd.java | 8 +- .../org/apache/cloudstack/api/TaggedResources.java | 72 ++ .../api/command/ResponseViewProvider.java} | 13 +- .../cloudstack/api/command/admin/AdminCmd.java}| 14 +- .../admin/address/AssociateIPAddrCmdByAdmin.java | 39 + .../address/ListPublicIpAddressesCmdByAdmin.java | 29 +--- .../UpdateVMAffinityGroupCmdByAdmin.java | 34 + .../api/command/admin/domain/ListDomainsCmd.java | 3 +- .../admin/domain/ListDomainsCmdByAdmin.java| 4 +- .../api/command/admin/iso/AttachIsoCmdByAdmin.java | 31 +--- .../api/command/admin/iso/DetachIsoCmdByAdmin.java | 25 +--- .../admin/iso/ListIsoPermissionsCmdByAdmin.java| 14 +- .../api/command/admin/iso/ListIsosCmdByAdmin.java | 3 +- .../command/admin/iso/RegisterIsoCmdByAdmin.java | 30 +--- .../api/command/admin/iso/UpdateIsoCmdByAdmin.java | 22 +-- .../ListLoadBalancerRuleInstancesCmdByAdmin.java | 69 + .../admin/network/CreateNetworkCmdByAdmin.java | 25 +--- .../admin/network/ListNetworksCmdByAdmin.java | 26 +--- .../admin/network/UpdateNetworkCmdByAdmin.java | 29 +--- .../admin/template/CopyTemplateCmdByAdmin.java | 48 +-- .../admin/template/CreateTemplateCmdByAdmin.java | 41 +- .../ListTemplatePermissionsCmdByAdmin.java | 10 +- .../admin/template/ListTemplatesCmdByAdmin.java| 3 +- .../admin/template/RegisterTemplateCmdByAdmin.java | 37 + .../admin/template/UpdateTemplateCmdByAdmin.java | 25 +--- .../api/command/admin/vm/AddNicToVMCmdByAdmin.java | 32 + .../api/command/admin/vm/DeployVMCmdByAdmin.java | 51 +-- .../api/command/admin/vm/DestroyVMCmdByAdmin.java | 34 + .../api/command/admin/vm/ListVMsCmdByAdmin.java| 3 +- .../api/command/admin/vm/RebootVMCmdByAdmin.java | 28 +--- .../admin/vm/RemoveNicFromVMCmdByAdmin.java| 32 + .../admin/vm/ResetVMPasswordCmdByAdmin.java| 29 +--- .../command/admin/vm/ResetVMSSHKeyCmdByAdmin.java | 32 + .../api/command/admin/vm/RestoreVMCmdByAdmin.java | 31 +--- .../api/command/admin/vm/ScaleVMCmdByAdmin.java| 45 +- .../api/command/admin/vm/StartVMCmdByAdmin.java| 57 +--- .../api/command/admin/vm/StopVMCmdByAdmin.java | 30 +--- .../admin/vm/UpdateDefaultNicForVMCmdByAdmin.java | 33 + .../api/command/admin/vm/UpdateVMCmdByAdmin.java | 27 +--- .../api/command/admin/vm/UpgradeVMCmdByAdmin.java | 34 + .../vmsnapshot/RevertToVMSnapshotCmdByAdmin.java | 36 + .../admin/volume/AttachVolumeCmdByAdmin.java | 24 +--- .../admin/volume/CreateVolumeCmdByAdmin.java | 37 + .../admin/volume/DetachVolumeCmdByAdmin.java | 25 +--- .../admin/volume/ListVolumesCmdByAdmin.java| 5 +- .../admin/volume/MigrateVolumeCmdByAdmin.java | 19 +-- .../admin/volume/ResizeVolumeCmdByAdmin.java | 30 +--- .../admin/volume/UpdateVolumeCmdByAdmin.java | 21 +-- .../admin/volume/UploadVolumeCmdByAdmin.java | 33 + .../api/command/admin/vpc/CreateVPCCmdByAdmin.java | 44 +- .../api/command/admin/vpc/ListVPCsCmdByAdmin.java | 30 +--- .../api/command/admin/vpc/UpdateVPCCmdByAdmin.java | 23 +-- .../command/admin/zone/ListZonesCmdByAdmin.java| 3 +- .../cloudstack/api/command/user/UserCmd.java} | 16 +-- .../api/command/user/account/ListAccountsCmd.java | 3 +- .../command/user/address/AssociateIPAddrCmd.java | 5 +- .../user/address/ListPublicIpAddressesCmd.java | 5 +- .../affinitygroup/UpdateVMAffinityGroupCmd.java| 7 +- .../api/command/user/iso/AttachIsoCmd.java | 5 +- .../api/command/user/iso/DetachIsoCmd.java | 5 +- .../command/user/iso/ListIsoPermissionsCmd.java| 8 +- .../api/command/user/iso/ListIsosCmd.java | 3 +- .../api/command/user/iso/RegisterIsoCmd.java | 5 +- .../api/command/user/iso/UpdateIsoCmd.java | 5 +- .../ListLoadBalancerRuleInstancesCmd.java | 6 +- .../api/command/user/network/CreateNetworkCmd.java | 5 +- .../api/command/user/network/ListNetworksCmd.java | 5 +- .../api/command/user/network/UpdateNetworkCmd.java | 5 +- .../api/command/user/project/ListProjectsCmd.java | 21 +-- .../api/command/user/tag/CreateTagsCmd.java| 18 +-- .../api/command/user/template/CopyTemplateCmd.java | 5 +-
[GitHub] [cloudstack] rhtyd commented on issue #3607: allocator: in case of null guest OS don't fail prioritisation completely
rhtyd commented on issue #3607: allocator: in case of null guest OS don't fail prioritisation completely URL: https://github.com/apache/cloudstack/pull/3607#issuecomment-534850739 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage)
rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage) URL: https://github.com/apache/cloudstack/pull/3538#issuecomment-534850580 LGTM, tests LGTM as well. Using lgtms from the original PR, merging this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd merged pull request #3538: Refactoring to remove duplicate code (by Frank/Nuage)
rhtyd merged pull request #3538: Refactoring to remove duplicate code (by Frank/Nuage) URL: https://github.com/apache/cloudstack/pull/3538 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd opened a new pull request #3607: allocator: in case of null guest OS don't fail prioritisation completely
rhtyd opened a new pull request #3607: allocator: in case of null guest OS don't fail prioritisation completely URL: https://github.com/apache/cloudstack/pull/3607 In case of null guest OS found for a template, don't fail prioritisation completely (could still work based on HVM etc). ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-534796714 @anuragaw a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-534796593 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot'
GabrielBrascher commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot' URL: https://github.com/apache/cloudstack/pull/3605#issuecomment-534715094 @andrijapanicsb Can you please check if RBD snapshot rollback will work for you with this fix? Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage)
blueorangutan commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage) URL: https://github.com/apache/cloudstack/pull/3538#issuecomment-534639970 Trillian test result (tid-377) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32381 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3538-t377-kvm-centos7.zip Smoke tests completed. 77 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3606: [WIP DO NOT MERGE] VM ingestion
blueorangutan commented on issue #3606: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3606#issuecomment-534624431 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-288 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr closed pull request #3540: [WIP DO NOT MERGE] VM ingestion
shwstppr closed pull request #3540: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3540 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr commented on issue #3540: [WIP DO NOT MERGE] VM ingestion
shwstppr commented on issue #3540: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3540#issuecomment-534614423 Moved here, https://github.com/apache/cloudstack/pull/3606 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr opened a new pull request #3606: [WIP DO NOT MERGE] VM ingestion
shwstppr opened a new pull request #3606: [WIP DO NOT MERGE] VM ingestion
URL: https://github.com/apache/cloudstack/pull/3606
## Description
VM ingestion feature allows CloudStack to discover, on-board, import
existing VMs in an infra. The feature currently works only for VMware, with a
hypervisor agnostic framework which may be extended for KVM and XenServer in
future.
Two new APIs have been added, `listUnmanagedInstances` and
`importUnmanagedInstance`.
### listUnmanagedInstances
API will list all unmanaged virtual machine for a give cluster. Optionally,
name for an existing unmanaged virtual machine can be given to retrieve VM
details.
**API request params -**
`clusterid`(UUID of cluster)
`name`(instance name)
**Response -**
`clusterid`
`hostid`
`name`
`osdisplayname`
`memory`
`powerstate`
`cpuCoresPerSocket`
`cpunumber`
`cpuspeed`
`disk`
- `id`
- `capacity`
- `controller`
- `controllerunit`
- `imagepath`
- `position`
`nic`
- `id`
- `macaddress`
- `networkname`
- `vlanid`
- `pcislot`
### importUnmanagedInstance
API will import an exisitng unmanaged virtual machine into CloudStack for a
given cluster and virtual machine name. Service offering for the VM, disk
offerings for volumes and networks for NICs of the VM can be mapped. Some
optional parameters like projectid, domainid, hostname, details, etc can also
be given. Appropritate networks, service offering and disk offerings need to be
present before import and cannot be created on the fly during the API call.
**API request params -**
`clusterid`(UUID of cluster)
`name`(instance name)
`displayname`
`hostname`
`domainid`
`projectid`
`templateid`
`serviceofferingid`
`diskofferingid`(UUID of disk offering for root disk)
`nicnetworklist`(Map for NIC ID and corresponding Network UUID)
`datadiskofferinglist`(Map for disk ID and corresponding disk offering UUID)
`details`(Map for VM details)
**Response -**
Same response as that of `deployVirtualMachine` API
## Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## API sample calls:
**List**
```
> list unmanagedinstances clusterid=079a19c2-2710-4ed6-9110-027dd5e0f262
{
"count": 2,
"unmanagedinstance": [
{
"clusterid": "079a19c2-2710-4ed6-9110-027dd5e0f262",
"cpucorespersocket": 1,
"cpunumber": 1,
"cpuspeed": 0,
"disk": [
{
"capacity": 2097152,
"controller": "ide",
"controllerunit": 0,
"id": "51-3001",
"imagepath": "[8aca30d6f7803420973f01cc91c1c011]
test-unmanaged/test-unmanaged_64.vmdk",
"label": "Hard disk 1",
"position": 1
},
{
"capacity": 5242880,
"controller": "scsi",
"controllerunit": 0,
"id": "51-2000",
"imagepath": "[8aca30d6f7803420973f01cc91c1c011]
test-unmanaged/test-unmanaged_63.vmdk",
"label": "Hard disk 2",
"position": 0
}
],
"hostid": "4ab4147a-7e40-4abe-a0e2-2fac1aa6f0bf",
"memory": 512,
"name": "test-unmanaged",
"nic": [
{
"id": "Network adapter 1",
"macaddress": "02:00:39:7c:00:24",
"networkname": "cloud.guest.1212.200.1-vSwitch1",
"vlanid": 1212
}
],
"osdisplayname": "CentOS 4/5 or later (64-bit)",
"powerstate": "POWERED_ON"
}
]
}
```
**Import**
```
> import unmanagedinstance name=test-unmanaged
templateid=200f3fe9-c845-11e9-b69f-1e003c0107c4
clusterid=079a19c2-2710-4ed6-9110-027dd5e0f262
diskofferingid=e9eb069f-2946-4e26-8d81-07aebba868d1
serviceofferingid=c4c5b9e8-8a4a-422d-bccc-2f1bcc166c59
datadiskofferinglist[0].disk=51-2000
datadiskofferinglist[0].diskOffering=e9eb069f-2946-4e26-8d81-07aebba868d1
displayname=NewVm nicNetworkList[0].nic="Network adapter 1"
nicNetworkList[0].network=4c44312b-f009-4d33-b942-989169f3d2fc
{
"virtualmachine": {
"account": "admin",
"affinitygroup": [],
"cpunumber": 1,
"cpuspeed": 500,
"created": "2019-09-05T11:32:04+",
"details": {},
"diskofferingid": "e9eb069f-2946-4e26-8d81-07aebba868d1",
"diskofferingname": "Custom",
"displayname": "NewVm",
"displayvm": true,
"domain": "ROOT",
"domainid": "20088b4d-c845-11e9-b69f-1e003c0107c4",
[GitHub] [cloudstack] rhtyd commented on issue #3540: [WIP DO NOT MERGE] VM ingestion
rhtyd commented on issue #3540: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3540#issuecomment-534520453 @shwstppr a lot of conflicts here, can you rebase or fix conflict? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion
blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3540#issuecomment-534512448 Packaging result: ✖centos6 ✖centos7 ✖debian. JID-287 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-534423671 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-286 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage)
blueorangutan commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage) URL: https://github.com/apache/cloudstack/pull/3538#issuecomment-534421555 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage)
rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage) URL: https://github.com/apache/cloudstack/pull/3538#issuecomment-534421461 CentOS7 job failed, rekicking @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-534417449 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-534417589 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
