[GitHub] [cloudstack] nvazquez commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks
nvazquez commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568159608 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3775: New feature: Acquire specific public IP for network
blueorangutan commented on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-568146627 Trillian test result (tid-660) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 36796 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3775-t660-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 76 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_05_rvpc_multi_tiers | `Failure` | 415.34 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 442.73 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on a change in pull request #3778: Endless settings on templates and instances
anuragaw commented on a change in pull request #3778: Endless settings on
templates and instances
URL: https://github.com/apache/cloudstack/pull/3778#discussion_r360624658
##
File path: ui/scripts/instances.js
##
@@ -3437,6 +3437,13 @@
custom:
cloudStack.uiCustom.granularDetails({
resourceType: 'UserVm',
dataProvider:
function(args) {
+// no paging for listVirtualMachines details
+if (args.page > 1){
+args.response.success({
+data: []
+});
+return;
+}
Review comment:
Isn't this supposed to be inside dataProvider @DaanHoogland ? So should be
more right aligned?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] anuragaw commented on a change in pull request #3778: Endless settings on templates and instances
anuragaw commented on a change in pull request #3778: Endless settings on
templates and instances
URL: https://github.com/apache/cloudstack/pull/3778#discussion_r360624658
##
File path: ui/scripts/instances.js
##
@@ -3437,6 +3437,13 @@
custom:
cloudStack.uiCustom.granularDetails({
resourceType: 'UserVm',
dataProvider:
function(args) {
+// no paging for listVirtualMachines details
+if (args.page > 1){
+args.response.success({
+data: []
+});
+return;
+}
Review comment:
Isn't this supposed to be inside dataProvider @DaanHoogland ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3778: Endless settings on templates and instances
DaanHoogland commented on a change in pull request #3778: Endless settings on
templates and instances
URL: https://github.com/apache/cloudstack/pull/3778#discussion_r360579834
##
File path: ui/scripts/templates.js
##
@@ -2489,6 +2489,13 @@
custom:
cloudStack.uiCustom.granularDetails({
resourceType: 'Template',
dataProvider: function(args) {
+// no paging for listTemplates details
+if (args.page > 1){
+args.response.success({
+data: []
+});
+return;
+}
Review comment:
or here?!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3778: Endless settings on templates and instances
DaanHoogland commented on a change in pull request #3778: Endless settings on
templates and instances
URL: https://github.com/apache/cloudstack/pull/3778#discussion_r360579718
##
File path: ui/scripts/instances.js
##
@@ -3437,6 +3437,13 @@
custom:
cloudStack.uiCustom.granularDetails({
resourceType: 'UserVm',
dataProvider:
function(args) {
+// no paging for listVirtualMachines details
+if (args.page > 1){
+args.response.success({
+data: []
+});
+return;
+}
Review comment:
What do you mean @anuragaw ? I see no problem with the indentation here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3776: Fix HA config keys
blueorangutan commented on issue #3776: Fix HA config keys URL: https://github.com/apache/cloudstack/pull/3776#issuecomment-568079770 Trillian test result (tid-657) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33207 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3776-t657-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 76 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_rvpc_network_garbage_collector_nics | `Failure` | 299.63 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Failure` | 429.21 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 456.52 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms
blueorangutan commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms URL: https://github.com/apache/cloudstack/pull/3510#issuecomment-568077178 Trillian test result (tid-659) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28093 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3510-t659-kvm-centos7.zip Smoke tests completed. 78 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568070482 Trillian test result (tid-658) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 27800 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3575-t658-kvm-centos7.zip Smoke tests completed. 77 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shindere commented on issue #3692: Accessibility issue: unable to get API and secret keys
shindere commented on issue #3692: Accessibility issue: unable to get API and secret keys URL: https://github.com/apache/cloudstack/issues/3692#issuecomment-568068829 EK (2019/12/20 05:51 -0800): > Not sure if I'll be at FOSDEM, but we can always setup a call and come > up with a list of things we can do, then we can share with the > community as a starting point. Sure, that's a good idea, thanks! Perhaps let's see first whether you can make it to FOSDEM and fall back to setting up a call if you can't? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag
andrijapanicsb commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag URL: https://github.com/apache/cloudstack/pull/3780#issuecomment-568044158 @radeksm I can see edge cases where this constraint can be useful (operator lack of understanding how things should be done/tagged), but otherwise, I don't see the usability of this in the wider sense - why at all putting such constraint? Apologies if I'm missing something This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3746: Fix OS category for some OS-es added in 4.13
andrijapanicsb commented on issue #3746: Fix OS category for some OS-es added in 4.13 URL: https://github.com/apache/cloudstack/pull/3746#issuecomment-568043129 @DaanHoogland can we merge this one to 4.13 as well - check the SQLs please, they are safe to be "done" in 4.13.0.0 to 4.13.1.0, and then executed again in the 4.13.x.x to 4.14.0.0 (if that makes sense?) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks
blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568041406 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-498 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-560406657 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-417 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks
nvazquez removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-561613544 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-56045 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks
nvazquez removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-560399923 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-561613572 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks
andrijapanicsb removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-564536852 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-564536985 @andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-561619635 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-421 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-564546630 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-457 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-566090007 @andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks
blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568035792 @andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-566098066 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-473 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks
andrijapanicsb removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-566089627 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-567463314 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-491 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks
andrijapanicsb removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-567709267 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-567819893 Trillian test result (tid-653) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 29116 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3732-t653-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Smoke tests completed. 77 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks
andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568035672 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-567710399 @andrijapanicsb a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-567456244 @andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] andrijapanicsb removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks
andrijapanicsb removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-567456072 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3775: New feature: Acquire specific public IP for network
anuragaw commented on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-567985003 We can merge after tests job above succeeds. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] NuxRo opened a new issue #3783: Create volume or template from snapshot is broken
NuxRo opened a new issue #3783: Create volume or template from snapshot is
broken
URL: https://github.com/apache/cloudstack/issues/3783
Hi,
I'm on 4.13 KVM + local storage, trying to create a volume or a template
from a snapshot.
Cloudmonkey says:
```
(localcloud) > create volume snapshotid=985f20b1-b57e-458e-983d-ce69848fe06c
Error: (HTTP 530, error code )
```
management-server.log says:
```
2019-12-20 16:17:58,558 DEBUG [o.e.j.s.HttpChannel] (qtp504527234-813:null)
(logid:)
HttpChannelOverHttp@5d83425d{r=1,c=false,a=IDLE,uri=//192-168-140-220.cloud.tld:8443/client/api?apiKey=-Rt233Gc8hogf2d-mLvno6fzoTueIja8W_io56YM1Bh4
35Rk6dXex0w_t29X_sv2MMhbuM1k2GbS63chKglc4A=createVolume=json=d603641c-dff4-43aa-8da1-07afaa0a35d3=zcUn58qI0MLg2y2%2FJC30D8ThDc8%3D}
onContentComplete
2019-12-20 16:17:58,558 DEBUG [o.e.j.s.HttpChannel] (qtp504527234-813:null)
(logid:)
HttpChannelOverHttp@5d83425d{r=1,c=false,a=IDLE,uri=//192-168-140-220.cloud.tld:8443/client/api?apiKey=-Rt233Gc8hogf2d-mLvno6fzoTueIja8W_io56YM1Bh4
35Rk6dXex0w_t29X_sv2MMhbuM1k2GbS63chKglc4A=createVolume=json=d603641c-dff4-43aa-8da1-07afaa0a35d3=zcUn58qI0MLg2y2%2FJC30D8ThDc8%3D}
onRequestComplete
2019-12-20 16:17:58,558 DEBUG [o.e.j.s.HttpInput] (qtp504527234-813:null)
(logid:) HttpInputOverHTTP@23b3db24[c=0,q=0,[0]=null,s=STREAM] addContent EOF
2019-12-20 16:17:58,558 DEBUG [o.e.j.s.HttpConnection]
(qtp504527234-813:null) (logid:) HttpConnection@12ce2981[p=HttpParser{s=END,0
of
-1},g=HttpGenerator@5598102f{s=START}]=>HttpChannelOverHttp@5d83425d{r=1,c=false,a=IDLE,uri=//109-70-
140-220.cloud.tld:8443/client/api?apiKey=-Rt233Gc8hogf2d-mLvno6fzoTueIja8W_io56YM1Bh435Rk6dXex0w_t29X_sv2MMhbuM1k2GbS63chKglc4A=createVolume=json=d603641c-dff4-43aa-8da1-07afaa0a35d3=zcUn58qI0M
Lg2y2%2FJC30D8ThDc8%3D}<-DecryptedEndPoint@16f82720{/192.168.140.220:35676<->/192.168.140.220:8443,OPEN,fill=-,flush=-,to=3/3}->HttpConnection@12ce2981[p=HttpParser{s=END,0
of -1},g=HttpGenerator@5598102f{s=START}]=>HttpChannelOverHttp
@5d83425d{r=1,c=false,a=IDLE,uri=//192-168-140-220.cloud.tld:8443/client/api?apiKey=-Rt233Gc8hogf2d-mLvno6fzoTueIja8W_io56YM1Bh435Rk6dXex0w_t29X_sv2MMhbuM1k2GbS63chKglc4A=createVolume=json=d603641c-dff4-4
3aa-8da1-07afaa0a35d3=zcUn58qI0MLg2y2%2FJC30D8ThDc8%3D}->SocketChannelEndPoint@643edcc0{/192.168.140.220:35676<->/192.168.140.220:8443,OPEN,fill=-,flush=-,to=1/3}{io=1/0,kio=1,kro=1}->SslConnection@28eec9b{NOT_HANDSHAKING,eio
=-1/-1,di=-1}=>HttpConnection@12ce2981[p=HttpParser{s=END,0 of
-1},g=HttpGenerator@5598102f{s=START}]=>HttpChannelOverHttp@5d83425d{r=1,c=false,a=IDLE,uri=//192-168-140-220.cloud.tld:8443/client/api?apiKey=-Rt233Gc8hogf2d-mLvno6fzoT
ueIja8W_io56YM1Bh435Rk6dXex0w_t29X_sv2MMhbuM1k2GbS63chKglc4A=createVolume=json=d603641c-dff4-43aa-8da1-07afaa0a35d3=zcUn58qI0MLg2y2%2FJC30D8ThDc8%3D}
parsed true HttpParser{s=END,0 of -1}
2019-12-20 16:17:58,558 DEBUG [o.e.j.s.HttpConnection]
(qtp504527234-813:null) (logid:) releaseRequestBuffer
HttpConnection@12ce2981[p=HttpParser{s=END,0 of
-1},g=HttpGenerator@5598102f{s=START}]=>HttpChannelOverHttp@5d83425d{r=1,c=false
,a=IDLE,uri=//192-168-140-220.cloud.tld:8443/client/api?apiKey=-Rt233Gc8hogf2d-mLvno6fzoTueIja8W_io56YM1Bh435Rk6dXex0w_t29X_sv2MMhbuM1k2GbS63chKglc4A=createVolume=json=d603641c-dff4-43aa-8da1-07afaa0a35d3
=zcUn58qI0MLg2y2%2FJC30D8ThDc8%3D}<-DecryptedEndPoint@16f82720{/192.168.140.220:35676<->/192.168.140.220:8443,OPEN,fill=-,flush=-,to=3/3}->HttpConnection@12ce2981[p=HttpParser{s=END,0
of -1},g=HttpGenerator@5598102f{s=START}]
=>HttpChannelOverHttp@5d83425d{r=1,c=false,a=IDLE,uri=//192-168-140-220.cloud.tld:8443/client/api?apiKey=-Rt233Gc8hogf2d-mLvno6fzoTueIja8W_io56YM1Bh435Rk6dXex0w_t29X_sv2MMhbuM1k2GbS63chKglc4A=createVolume=json
hotid=d603641c-dff4-43aa-8da1-07afaa0a35d3=zcUn58qI0MLg2y2%2FJC30D8ThDc8%3D}->SocketChannelEndPoint@643edcc0{/192.168.140.220:35676<->/192.168.140.220:8443,OPEN,fill=-,flush=-,to=1/3}{io=1/0,kio=1,kro=1}->SslConnection@28eec9
b{NOT_HANDSHAKING,eio=-1/-1,di=-1}=>HttpConnection@12ce2981[p=HttpParser{s=END,0
of
-1},g=HttpGenerator@5598102f{s=START}]=>HttpChannelOverHttp@5d83425d{r=1,c=false,a=IDLE,uri=//192-168-140-220.cloud.tld:8443/client/api?apiKey=-Rt23
3Gc8hogf2d-mLvno6fzoTueIja8W_io56YM1Bh435Rk6dXex0w_t29X_sv2MMhbuM1k2GbS63chKglc4A=createVolume=json=d603641c-dff4-43aa-8da1-07afaa0a35d3=zcUn58qI0MLg2y2%2FJC30D8ThDc8%3D}
2019-12-20 16:17:58,558 DEBUG [o.e.j.s.HttpChannel] (qtp504527234-813:null)
(logid:)
HttpChannelOverHttp@5d83425d{r=1,c=false,a=IDLE,uri=//192-168-140-220.cloud.tld:8443/client/api?apiKey=-Rt233Gc8hogf2d-mLvno6fzoTueIja8W_io56YM1Bh4
35Rk6dXex0w_t29X_sv2MMhbuM1k2GbS63chKglc4A=createVolume=json=d603641c-dff4-43aa-8da1-07afaa0a35d3=zcUn58qI0MLg2y2%2FJC30D8ThDc8%3D}
handle //192-168-140-220.cloud.tld:8443/client/api?apiKey=-Rt2
[GitHub] [cloudstack] anuragaw commented on a change in pull request #3778: Endless settings on templates and instances
anuragaw commented on a change in pull request #3778: Endless settings on
templates and instances
URL: https://github.com/apache/cloudstack/pull/3778#discussion_r360445086
##
File path: ui/scripts/instances.js
##
@@ -3437,6 +3437,13 @@
custom:
cloudStack.uiCustom.granularDetails({
resourceType: 'UserVm',
dataProvider:
function(args) {
+// no paging for listVirtualMachines details
+if (args.page > 1){
+args.response.success({
+data: []
+});
+return;
+}
Review comment:
Can you fix indentation @Spaceman1984 ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] anuragaw commented on a change in pull request #3778: Endless settings on templates and instances
anuragaw commented on a change in pull request #3778: Endless settings on
templates and instances
URL: https://github.com/apache/cloudstack/pull/3778#discussion_r360445185
##
File path: ui/scripts/templates.js
##
@@ -2489,6 +2489,13 @@
custom:
cloudStack.uiCustom.granularDetails({
resourceType: 'Template',
dataProvider: function(args) {
+// no paging for listTemplates details
+if (args.page > 1){
+args.response.success({
+data: []
+});
+return;
+}
Review comment:
same here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3775: New feature: Acquire specific public IP for network
blueorangutan commented on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-567981322 @anuragaw a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3775: New feature: Acquire specific public IP for network
anuragaw commented on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-567981071 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3775: New feature: Acquire specific public IP for network
blueorangutan commented on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-567980934 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-497 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3775: New feature: Acquire specific public IP for network
anuragaw commented on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-567974058 Running Marvin Tests on the PR. @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3775: New feature: Acquire specific public IP for network
blueorangutan commented on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-567974078 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3776: Fix HA config keys
anuragaw commented on issue #3776: Fix HA config keys URL: https://github.com/apache/cloudstack/pull/3776#issuecomment-567972443 Travis failure was unrelated @mdominka . The tests that I've run are more exhaustive and should succeed in sometime. Did you see unrelated files' changes ? Not something that's terrible but it's a matter of choice - personally I don't like having redundant noise in my PRs to keep clean git history by not committing unintended changes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360432047 ## File path: plugins/user-authenticators/ldap/pom.xml ## @@ -27,6 +27,11 @@ 4.14.0.0-SNAPSHOT ../../pom.xml + + +2.0.0.AM26-SNAPSHOT Review comment: i downed the version to 2.0.0.AM25 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rakgenius commented on issue #3775: New feature: Acquire specific public IP for network
rakgenius commented on issue #3775: New feature: Acquire specific public IP for
network
URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-567969213
> > > Code looks good. Haven't tested though.
> > > One question - When the IP Address requested is invalid or unavailable
in `user_ip_address` do we add that reason in exception or log it? (could'nt
see it).
> >
> >
> > The dropdown displays only the "Free" IP's available in that particular
network or VPC. If there are not free IP in that network/VPC then it wont
display the drop down list
>
> But that doesn't cover API usage outside UI @rakgenius , which is how a
large number of users access CS.
@anuragaw Just tested it and if the IP is already allocated, it will throw
```Insufficient address capacity``` exception
```
(local) > associate ipaddress
networkid=6efa8597-d5e8-4bf6-8686-3db26d568ed1 ipaddress=10.11.113.150
{
"accountid": "9c185c1d-00b2-11ea-a7cf-069f8fac",
"cmd":
"org.apache.cloudstack.api.command.admin.address.AssociateIPAddrCmdByAdmin",
"completed": "2019-12-20T15:38:35+",
"created": "2019-12-20T15:38:35+",
"jobid": "ca7f3410-a1be-43ec-880e-448facff96c7",
"jobinstanceid": "f7a584ca-8a3c-4f72-b647-c92ed31397aa",
"jobinstancetype": "IpAddress",
"jobprocstatus": 0,
"jobresult": {
"ipaddress": {
"account": "test",
"allocated": "2019-12-20T15:38:35+",
"associatednetworkname": "test",
"domain": "test",
"fordisplay": true,
"forvirtualnetwork": true,
"id": "f7a584ca-8a3c-4f72-b647-c92ed31397aa",
"ipaddress": "10.11.113.150",
"isportable": false,
"issourcenat": false,
"isstaticnat": false,
"issystem": false,
"state": "Allocating",
"tags": [],
"vlanname": "vlan://untagged",
"zonename": "zone113-2"
}
},
"jobresultcode": 0,
"jobresulttype": "object",
"jobstatus": 1
}
```
```
(local) > associate ipaddress
networkid=6efa8597-d5e8-4bf6-8686-3db26d568ed1 ipaddress=10.11.113.150
Error 533: Insufficient address capacity
```
```
2019-12-20 15:42:35,163 WARN [c.c.n.IpAddressManagerImpl]
(qtp858242339-18:ctx-9d0b2eb1 ctx-a86c335b) (logid:5b743076) Unable to get ip
address in zone id=1, vlanId id=[1]: requested ip 10.11.113.150 is not
available
2019-12-20 15:42:35,264 TRACE [o.a.c.a.c.u.a.AssociateIPAddrCmd]
(qtp858242339-18:ctx-9d0b2eb1 ctx-a86c335b) (logid:5b743076)
com.cloud.exception.InsufficientAddressCapacityException: Insufficient address
capacityScope=interface com.cloud.dc.DataCenter; id=1
2019-12-20 15:42:35,264 INFO [c.c.a.ApiServer]
(qtp858242339-18:ctx-9d0b2eb1 ctx-a86c335b) (logid:5b743076) Insufficient
address capacity
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland merged pull request #3782: 4.13
DaanHoogland merged pull request #3782: 4.13 URL: https://github.com/apache/cloudstack/pull/3782 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland closed issue #3252: Load balancer protocols bug
DaanHoogland closed issue #3252: Load balancer protocols bug URL: https://github.com/apache/cloudstack/issues/3252 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland closed issue #3702: Cannot create a VM connected to 2 tiers of a VPC
DaanHoogland closed issue #3702: Cannot create a VM connected to 2 tiers of a VPC URL: https://github.com/apache/cloudstack/issues/3702 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland closed issue #3093: KVM Agent with Local Storage requests other local storage pools from LibVirt
DaanHoogland closed issue #3093: KVM Agent with Local Storage requests other local storage pools from LibVirt URL: https://github.com/apache/cloudstack/issues/3093 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland closed issue #3683: Stop "mgmt server needs restart" message on global setting that doesn't require it
DaanHoogland closed issue #3683: Stop "mgmt server needs restart" message on global setting that doesn't require it URL: https://github.com/apache/cloudstack/issues/3683 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated (0606039 -> 482d0fd)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 0606039 Honour promiscuous mode from networkOffering (#3765) (#3781) add 482d0fd 4.13 (#3782) No new revisions were added by this update. Summary of changes: .../org/apache/cloudstack/api/ApiConstants.java| 1 + .../api/response/ConfigurationResponse.java| 13 .../main/java/com/cloud/api/ApiResponseHelper.java | 1 + .../main/java/com/cloud/vm/UserVmManagerImpl.java | 23 +++--- ui/scripts/globalSettings.js | 4 ++-- ui/scripts/network.js | 3 ++- 6 files changed, 31 insertions(+), 14 deletions(-)
[GitHub] [cloudstack] DaanHoogland closed issue #3596: Zone wide storage pools hypervisor checks missing while retrieving statistics
DaanHoogland closed issue #3596: Zone wide storage pools hypervisor checks missing while retrieving statistics URL: https://github.com/apache/cloudstack/issues/3596 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3694: Ldap fixes
nvazquez commented on issue #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#issuecomment-567960404 Thanks @DaanHoogland looking good, I'll post my final review once the last comment about reflection is sorted This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on a change in pull request #3694: Ldap fixes
nvazquez commented on a change in pull request #3694: Ldap fixes
URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360414511
##
File path:
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java
##
@@ -104,20 +241,251 @@ public long getEntityOwnerId() {
return Account.ACCOUNT_ID_SYSTEM;
}
-private String getListType() {
+String getListTypeString() {
return listType == null ? "all" : listType;
}
-private boolean isACloudstackUser(final LdapUser ldapUser) {
-final ListResponse response =
_queryService.searchForUsers(new ListUsersCmd());
-final List cloudstackUsers = response.getResponses();
+String getUserFilterString() {
+return userFilter == null ? getListTypeString() == null ? "NoFilter" :
getListTypeString().equals("all") ? "NoFilter" : "AnyDomain" : userFilter;
+}
+
+UserFilter getUserFilter() {
+return UserFilter.fromString(getUserFilterString());
+}
+
+boolean isACloudstackUser(final LdapUser ldapUser) {
+boolean rc = false;
+final List cloudstackUsers = getCloudstackUsers();
+if (cloudstackUsers != null) {
+for (final UserResponse cloudstackUser : cloudstackUsers) {
+if
(ldapUser.getUsername().equals(cloudstackUser.getUsername())) {
Review comment:
Just defensive check prior comparison, but ok to leave it as it is if the
received list does not contain empty usernames (which shouldnt)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on a change in pull request #3694: Ldap fixes
nvazquez commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360413353 ## File path: plugins/user-authenticators/ldap/pom.xml ## @@ -27,6 +27,11 @@ 4.14.0.0-SNAPSHOT ../../pom.xml + + +2.0.0.AM26-SNAPSHOT Review comment: Should be good to rely on a release version to avoid any changes that may break functionality on this PR, but ok anyways This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes
DaanHoogland commented on a change in pull request #3694: Ldap fixes
URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360407183
##
File path:
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java
##
@@ -66,34 +122,115 @@ public LdapListUsersCmd(final LdapManager ldapManager,
final QueryService queryS
_queryService = queryService;
}
+/**
+ * (as a check for isACloudstackUser is done) only non cloudstack users
should be shown
+ * @param users a list of {@code LdapUser}s
+ * @return a (filtered?) list of user response objects
+ */
private List createLdapUserResponse(final List
users) {
final List ldapResponses = new
ArrayList();
for (final LdapUser user : users) {
-if (getListType().equals("all") || !isACloudstackUser(user)) {
-final LdapUserResponse ldapResponse =
_ldapManager.createLdapUserResponse(user);
-ldapResponse.setObjectName("LdapUser");
-ldapResponses.add(ldapResponse);
-}
+final LdapUserResponse ldapResponse =
_ldapManager.createLdapUserResponse(user);
+ldapResponse.setObjectName("LdapUser");
+ldapResponses.add(ldapResponse);
}
return ldapResponses;
}
+private List cloudstackUsers = null;
+
@Override
public void execute() throws ServerApiException {
-List ldapResponses = null;
+cloudstackUsers = null;
+List ldapResponses = new
ArrayList();
final ListResponse response = new
ListResponse();
try {
-final List users = _ldapManager.getUsers(null);
+final List users = _ldapManager.getUsers(domainId);
ldapResponses = createLdapUserResponse(users);
+//now filter and annotate
+ldapResponses = applyUserFilter(ldapResponses);
} catch (final NoLdapUserMatchingQueryException ex) {
-ldapResponses = new ArrayList();
+// ok, we'll make do with the empty list ldapResponses = new
ArrayList();
} finally {
response.setResponses(ldapResponses);
response.setResponseName(getCommandName());
setResponseObject(response);
}
}
+private List getCloudstackUsers() {
+// get a list of relevant cloudstack users, meaning
+// if we are filtering for local domain, only get users for the
current domain
+// if we are filtering for any domain, get recursive all users for the
root domain
+// if we are filtering for potential imports,
+//we are only looking for users in the linked domains/accounts,
+//which is only relevant if we ask ldap users for this domain.
+//So we are asking for all users in the current domain as well
+// in case of no filter we should find all users in the current domain
for annotation.
+if (cloudstackUsers == null) {
+ListResponse cloudstackUsersresponse;
+switch (getUserFilter()) {
+case ANY_DOMAIN:
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes
DaanHoogland commented on a change in pull request #3694: Ldap fixes
URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360407044
##
File path:
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java
##
@@ -66,34 +122,115 @@ public LdapListUsersCmd(final LdapManager ldapManager,
final QueryService queryS
_queryService = queryService;
}
+/**
+ * (as a check for isACloudstackUser is done) only non cloudstack users
should be shown
+ * @param users a list of {@code LdapUser}s
+ * @return a (filtered?) list of user response objects
+ */
private List createLdapUserResponse(final List
users) {
final List ldapResponses = new
ArrayList();
for (final LdapUser user : users) {
-if (getListType().equals("all") || !isACloudstackUser(user)) {
-final LdapUserResponse ldapResponse =
_ldapManager.createLdapUserResponse(user);
-ldapResponse.setObjectName("LdapUser");
-ldapResponses.add(ldapResponse);
-}
+final LdapUserResponse ldapResponse =
_ldapManager.createLdapUserResponse(user);
+ldapResponse.setObjectName("LdapUser");
+ldapResponses.add(ldapResponse);
}
return ldapResponses;
}
+private List cloudstackUsers = null;
+
@Override
public void execute() throws ServerApiException {
-List ldapResponses = null;
+cloudstackUsers = null;
+List ldapResponses = new
ArrayList();
final ListResponse response = new
ListResponse();
try {
-final List users = _ldapManager.getUsers(null);
+final List users = _ldapManager.getUsers(domainId);
ldapResponses = createLdapUserResponse(users);
+//now filter and annotate
+ldapResponses = applyUserFilter(ldapResponses);
} catch (final NoLdapUserMatchingQueryException ex) {
-ldapResponses = new ArrayList();
+// ok, we'll make do with the empty list ldapResponses = new
ArrayList();
} finally {
response.setResponses(ldapResponses);
response.setResponseName(getCommandName());
setResponseObject(response);
}
}
+private List getCloudstackUsers() {
+// get a list of relevant cloudstack users, meaning
+// if we are filtering for local domain, only get users for the
current domain
+// if we are filtering for any domain, get recursive all users for the
root domain
+// if we are filtering for potential imports,
+//we are only looking for users in the linked domains/accounts,
+//which is only relevant if we ask ldap users for this domain.
+//So we are asking for all users in the current domain as well
+// in case of no filter we should find all users in the current domain
for annotation.
+if (cloudstackUsers == null) {
+ListResponse cloudstackUsersresponse;
+switch (getUserFilter()) {
+case ANY_DOMAIN:
+// get the user domain so if the calling user is a root admin
+cloudstackUsersresponse =
_queryService.searchForUsers(CallContext.current().getCallingAccount().getDomainId(),
true);
+break;
+case NO_FILTER:
+cloudstackUsersresponse =
_queryService.searchForUsers(this.domainId,true);
+break;
+case POTENTIAL_IMPORT:
+case LOCAL_DOMAIN:
+cloudstackUsersresponse =
_queryService.searchForUsers(this.domainId,false);
+break;
+default:
+throw new CloudRuntimeException("error in program login; we
are not filtering but still querying users to filter???");
+}
+cloudstackUsers = cloudstackUsersresponse.getResponses();
Review comment:
_queryService.searchForUsers(..) will at least return an empty list of
userresponses, never null.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360404508 ## File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java ## @@ -38,24 +48,70 @@ import com.cloud.user.Account; -@APICommand(name = "listLdapUsers", responseObject = LdapUserResponse.class, description = "Lists all LDAP Users", since = "4.2.0", -requestHasSensitiveInfo = false, responseHasSensitiveInfo = false) +/** + * @startuml + * start + * :list ldap users request; + * :get ldap binding; + * if (domain == null) then (true) + * :get global trust domain; + * else (false) + * :get trustdomain for domain; + * endif + * :get ldap users\n using trust domain; + * if (filter == 'NoFilter') then (pass as is) + * elseif (filter == 'AnyDomain') then (anydomain) + * :filterList = all\n\t\tcloudstack\n\t\tusers; + * elseif (filter == 'LocalDomain') + * :filterList = local users\n\t\tfor domain; + * elseif (filter == 'PotentialImport') then (address account\nsynchronisation\nconfigurations) + * :query\n the account\n bindings; + * :check and markup\n ldap users\n for bound OUs\n with usersource; + * else ( unknown value for filter ) + * :throw invalid parameter; + * stop + * endif + * :remove users in filterList\nfrom ldap users list; + * :return remaining; + * stop + * @enduml + */ Review comment: done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3775: New feature: Acquire specific public IP for network
anuragaw commented on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-567949543 > > Code looks good. Haven't tested though. > > One question - When the IP Address requested is invalid or unavailable in `user_ip_address` do we add that reason in exception or log it? (could'nt see it). > > The dropdown displays only the "Free" IP's available in that particular network or VPC. If there are not free IP in that network/VPC then it wont display the drop down list But that doesn't cover API usage outside UI @rakgenius , which is how a large number of users access CS. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes
DaanHoogland commented on a change in pull request #3694: Ldap fixes
URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360403041
##
File path:
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java
##
@@ -104,20 +241,251 @@ public long getEntityOwnerId() {
return Account.ACCOUNT_ID_SYSTEM;
}
-private String getListType() {
+String getListTypeString() {
return listType == null ? "all" : listType;
}
-private boolean isACloudstackUser(final LdapUser ldapUser) {
-final ListResponse response =
_queryService.searchForUsers(new ListUsersCmd());
-final List cloudstackUsers = response.getResponses();
+String getUserFilterString() {
+return userFilter == null ? getListTypeString() == null ? "NoFilter" :
getListTypeString().equals("all") ? "NoFilter" : "AnyDomain" : userFilter;
+}
+
+UserFilter getUserFilter() {
+return UserFilter.fromString(getUserFilterString());
+}
+
+boolean isACloudstackUser(final LdapUser ldapUser) {
+boolean rc = false;
+final List cloudstackUsers = getCloudstackUsers();
+if (cloudstackUsers != null) {
+for (final UserResponse cloudstackUser : cloudstackUsers) {
+if
(ldapUser.getUsername().equals(cloudstackUser.getUsername())) {
+if(s_logger.isTraceEnabled()) {
+s_logger.trace(String.format("found user %s in
cloudstack", ldapUser.getUsername()));
+}
+
+rc = true;
+} else {
+if(s_logger.isTraceEnabled()) {
+s_logger.trace(String.format("ldap user %s does not
match cloudstack user", ldapUser.getUsername(), cloudstackUser.getUsername()));
+}
+}
+}
+}
+return rc;
+}
+
+boolean isACloudstackUser(final LdapUserResponse ldapUser) {
+if(s_logger.isTraceEnabled()) {
+s_logger.trace("checking response : " + ldapUser.toString());
+}
+final List cloudstackUsers = getCloudstackUsers();
if (cloudstackUsers != null && cloudstackUsers.size() != 0) {
-for (final UserResponse cloudstackUser : response.getResponses()) {
+for (final UserResponse cloudstackUser : cloudstackUsers) {
if
(ldapUser.getUsername().equals(cloudstackUser.getUsername())) {
+if(s_logger.isTraceEnabled()) {
+s_logger.trace(String.format("found user %s in
cloudstack", ldapUser.getUsername()));
+}
return true;
+} else {
+if(s_logger.isTraceEnabled()) {
+s_logger.trace(String.format("ldap user %s does not
match cloudstack user", ldapUser.getUsername(), cloudstackUser.getUsername()));
+}
}
}
}
return false;
}
+/**
+ * typecheck for userfilter values
+ */
+enum UserFilter {
+NO_FILTER("NoFilter"),
+LOCAL_DOMAIN("LocalDomain"),
+ANY_DOMAIN("AnyDomain"),
+POTENTIAL_IMPORT("PotentialImport");
+
+private final String value;
+
+UserFilter(String val) {
+this.value = val;
+}
+
+static UserFilter fromString(String val) {
+if(NO_FILTER.toString().equalsIgnoreCase(val)) {
+return NO_FILTER;
+} else if (LOCAL_DOMAIN.toString().equalsIgnoreCase(val)) {
+return LOCAL_DOMAIN;
+} else if(ANY_DOMAIN.toString().equalsIgnoreCase(val)) {
+return ANY_DOMAIN;
+} else if(POTENTIAL_IMPORT.toString().equalsIgnoreCase(val)) {
+return POTENTIAL_IMPORT;
+} else {
+throw new IllegalArgumentException(String.format("%s is not a
legal 'UserFilter' value", val));
+}
+}
+
+@Override public String toString() {
+return value;
+}
+}
+
+/**
+ * no filtering but improve with annotation of source for existing ACS
users
+ * @param input ldap response list of users
+ * @return unfiltered list of the input list of ldap users
+ */
+public List filterNoFilter(List input)
{
+if(s_logger.isTraceEnabled()) {
+s_logger.trace("returning unfiltered list of ldap users");
+}
+annotateUserListWithSources(input);
+return input;
+}
+
+/**
+ * filter the list of ldap users. no users visible to the caller should be
in the returned list
+ * @param input ldap response list of users
+ * @return a list of ldap users not already in ACS
+ */
+public List filterAnyDomain(List
input) {
+if(s_logger.isTraceEnabled()) {
+s_logger.trace("filtering existing users");
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes
DaanHoogland commented on a change in pull request #3694: Ldap fixes
URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360401916
##
File path:
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java
##
@@ -104,20 +241,251 @@ public long getEntityOwnerId() {
return Account.ACCOUNT_ID_SYSTEM;
}
-private String getListType() {
+String getListTypeString() {
return listType == null ? "all" : listType;
}
-private boolean isACloudstackUser(final LdapUser ldapUser) {
-final ListResponse response =
_queryService.searchForUsers(new ListUsersCmd());
-final List cloudstackUsers = response.getResponses();
+String getUserFilterString() {
+return userFilter == null ? getListTypeString() == null ? "NoFilter" :
getListTypeString().equals("all") ? "NoFilter" : "AnyDomain" : userFilter;
+}
+
+UserFilter getUserFilter() {
+return UserFilter.fromString(getUserFilterString());
+}
+
+boolean isACloudstackUser(final LdapUser ldapUser) {
+boolean rc = false;
+final List cloudstackUsers = getCloudstackUsers();
+if (cloudstackUsers != null) {
+for (final UserResponse cloudstackUser : cloudstackUsers) {
+if
(ldapUser.getUsername().equals(cloudstackUser.getUsername())) {
+if(s_logger.isTraceEnabled()) {
+s_logger.trace(String.format("found user %s in
cloudstack", ldapUser.getUsername()));
+}
+
+rc = true;
+} else {
+if(s_logger.isTraceEnabled()) {
+s_logger.trace(String.format("ldap user %s does not
match cloudstack user", ldapUser.getUsername(), cloudstackUser.getUsername()));
+}
+}
+}
+}
+return rc;
+}
+
+boolean isACloudstackUser(final LdapUserResponse ldapUser) {
+if(s_logger.isTraceEnabled()) {
+s_logger.trace("checking response : " + ldapUser.toString());
+}
+final List cloudstackUsers = getCloudstackUsers();
if (cloudstackUsers != null && cloudstackUsers.size() != 0) {
-for (final UserResponse cloudstackUser : response.getResponses()) {
+for (final UserResponse cloudstackUser : cloudstackUsers) {
if
(ldapUser.getUsername().equals(cloudstackUser.getUsername())) {
+if(s_logger.isTraceEnabled()) {
+s_logger.trace(String.format("found user %s in
cloudstack", ldapUser.getUsername()));
+}
return true;
+} else {
+if(s_logger.isTraceEnabled()) {
+s_logger.trace(String.format("ldap user %s does not
match cloudstack user", ldapUser.getUsername(), cloudstackUser.getUsername()));
+}
}
}
}
return false;
}
+/**
+ * typecheck for userfilter values
+ */
+enum UserFilter {
+NO_FILTER("NoFilter"),
+LOCAL_DOMAIN("LocalDomain"),
+ANY_DOMAIN("AnyDomain"),
+POTENTIAL_IMPORT("PotentialImport");
+
+private final String value;
+
+UserFilter(String val) {
+this.value = val;
+}
+
+static UserFilter fromString(String val) {
+if(NO_FILTER.toString().equalsIgnoreCase(val)) {
+return NO_FILTER;
+} else if (LOCAL_DOMAIN.toString().equalsIgnoreCase(val)) {
+return LOCAL_DOMAIN;
+} else if(ANY_DOMAIN.toString().equalsIgnoreCase(val)) {
+return ANY_DOMAIN;
+} else if(POTENTIAL_IMPORT.toString().equalsIgnoreCase(val)) {
+return POTENTIAL_IMPORT;
+} else {
+throw new IllegalArgumentException(String.format("%s is not a
legal 'UserFilter' value", val));
+}
+}
+
+@Override public String toString() {
+return value;
+}
+}
+
+/**
+ * no filtering but improve with annotation of source for existing ACS
users
+ * @param input ldap response list of users
+ * @return unfiltered list of the input list of ldap users
+ */
+public List filterNoFilter(List input)
{
+if(s_logger.isTraceEnabled()) {
+s_logger.trace("returning unfiltered list of ldap users");
+}
+annotateUserListWithSources(input);
+return input;
+}
+
+/**
+ * filter the list of ldap users. no users visible to the caller should be
in the returned list
+ * @param input ldap response list of users
+ * @return a list of ldap users not already in ACS
+ */
+public List filterAnyDomain(List
input) {
+if(s_logger.isTraceEnabled()) {
+s_logger.trace("filtering existing users");
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes
DaanHoogland commented on a change in pull request #3694: Ldap fixes
URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360401970
##
File path:
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java
##
@@ -104,20 +241,251 @@ public long getEntityOwnerId() {
return Account.ACCOUNT_ID_SYSTEM;
}
-private String getListType() {
+String getListTypeString() {
return listType == null ? "all" : listType;
}
-private boolean isACloudstackUser(final LdapUser ldapUser) {
-final ListResponse response =
_queryService.searchForUsers(new ListUsersCmd());
-final List cloudstackUsers = response.getResponses();
+String getUserFilterString() {
+return userFilter == null ? getListTypeString() == null ? "NoFilter" :
getListTypeString().equals("all") ? "NoFilter" : "AnyDomain" : userFilter;
+}
+
+UserFilter getUserFilter() {
+return UserFilter.fromString(getUserFilterString());
+}
+
+boolean isACloudstackUser(final LdapUser ldapUser) {
+boolean rc = false;
+final List cloudstackUsers = getCloudstackUsers();
+if (cloudstackUsers != null) {
+for (final UserResponse cloudstackUser : cloudstackUsers) {
+if
(ldapUser.getUsername().equals(cloudstackUser.getUsername())) {
+if(s_logger.isTraceEnabled()) {
+s_logger.trace(String.format("found user %s in
cloudstack", ldapUser.getUsername()));
+}
+
+rc = true;
+} else {
+if(s_logger.isTraceEnabled()) {
+s_logger.trace(String.format("ldap user %s does not
match cloudstack user", ldapUser.getUsername(), cloudstackUser.getUsername()));
+}
+}
+}
+}
+return rc;
+}
+
+boolean isACloudstackUser(final LdapUserResponse ldapUser) {
+if(s_logger.isTraceEnabled()) {
+s_logger.trace("checking response : " + ldapUser.toString());
+}
+final List cloudstackUsers = getCloudstackUsers();
if (cloudstackUsers != null && cloudstackUsers.size() != 0) {
-for (final UserResponse cloudstackUser : response.getResponses()) {
+for (final UserResponse cloudstackUser : cloudstackUsers) {
if
(ldapUser.getUsername().equals(cloudstackUser.getUsername())) {
+if(s_logger.isTraceEnabled()) {
+s_logger.trace(String.format("found user %s in
cloudstack", ldapUser.getUsername()));
+}
return true;
+} else {
+if(s_logger.isTraceEnabled()) {
+s_logger.trace(String.format("ldap user %s does not
match cloudstack user", ldapUser.getUsername(), cloudstackUser.getUsername()));
+}
}
}
}
return false;
}
+/**
+ * typecheck for userfilter values
+ */
+enum UserFilter {
+NO_FILTER("NoFilter"),
+LOCAL_DOMAIN("LocalDomain"),
+ANY_DOMAIN("AnyDomain"),
+POTENTIAL_IMPORT("PotentialImport");
+
+private final String value;
+
+UserFilter(String val) {
+this.value = val;
+}
+
+static UserFilter fromString(String val) {
+if(NO_FILTER.toString().equalsIgnoreCase(val)) {
+return NO_FILTER;
+} else if (LOCAL_DOMAIN.toString().equalsIgnoreCase(val)) {
+return LOCAL_DOMAIN;
+} else if(ANY_DOMAIN.toString().equalsIgnoreCase(val)) {
+return ANY_DOMAIN;
+} else if(POTENTIAL_IMPORT.toString().equalsIgnoreCase(val)) {
+return POTENTIAL_IMPORT;
+} else {
+throw new IllegalArgumentException(String.format("%s is not a
legal 'UserFilter' value", val));
+}
+}
+
+@Override public String toString() {
+return value;
+}
+}
+
+/**
+ * no filtering but improve with annotation of source for existing ACS
users
+ * @param input ldap response list of users
+ * @return unfiltered list of the input list of ldap users
+ */
+public List filterNoFilter(List input)
{
+if(s_logger.isTraceEnabled()) {
+s_logger.trace("returning unfiltered list of ldap users");
+}
+annotateUserListWithSources(input);
+return input;
+}
+
+/**
+ * filter the list of ldap users. no users visible to the caller should be
in the returned list
+ * @param input ldap response list of users
+ * @return a list of ldap users not already in ACS
+ */
+public List filterAnyDomain(List
input) {
+if(s_logger.isTraceEnabled()) {
+s_logger.trace("filtering existing users");
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes
DaanHoogland commented on a change in pull request #3694: Ldap fixes
URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360398649
##
File path:
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java
##
@@ -104,20 +241,251 @@ public long getEntityOwnerId() {
return Account.ACCOUNT_ID_SYSTEM;
}
-private String getListType() {
+String getListTypeString() {
return listType == null ? "all" : listType;
}
-private boolean isACloudstackUser(final LdapUser ldapUser) {
-final ListResponse response =
_queryService.searchForUsers(new ListUsersCmd());
-final List cloudstackUsers = response.getResponses();
+String getUserFilterString() {
+return userFilter == null ? getListTypeString() == null ? "NoFilter" :
getListTypeString().equals("all") ? "NoFilter" : "AnyDomain" : userFilter;
+}
+
+UserFilter getUserFilter() {
+return UserFilter.fromString(getUserFilterString());
+}
+
+boolean isACloudstackUser(final LdapUser ldapUser) {
+boolean rc = false;
+final List cloudstackUsers = getCloudstackUsers();
+if (cloudstackUsers != null) {
+for (final UserResponse cloudstackUser : cloudstackUsers) {
+if
(ldapUser.getUsername().equals(cloudstackUser.getUsername())) {
Review comment:
not sure if this is the place to check for validity of user names. Why do
you think we could encounter a blank here?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes
DaanHoogland commented on a change in pull request #3694: Ldap fixes
URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360396116
##
File path:
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java
##
@@ -38,24 +48,70 @@
import com.cloud.user.Account;
-@APICommand(name = "listLdapUsers", responseObject = LdapUserResponse.class,
description = "Lists all LDAP Users", since = "4.2.0",
-requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+/**
+ * @startuml
+ * start
+ * :list ldap users request;
+ * :get ldap binding;
+ * if (domain == null) then (true)
+ * :get global trust domain;
+ * else (false)
+ * :get trustdomain for domain;
+ * endif
+ * :get ldap users\n using trust domain;
+ * if (filter == 'NoFilter') then (pass as is)
+ * elseif (filter == 'AnyDomain') then (anydomain)
+ * :filterList = all\n\t\tcloudstack\n\t\tusers;
+ * elseif (filter == 'LocalDomain')
+ * :filterList = local users\n\t\tfor domain;
+ * elseif (filter == 'PotentialImport') then (address
account\nsynchronisation\nconfigurations)
+ * :query\n the account\n bindings;
+ * :check and markup\n ldap users\n for bound OUs\n with usersource;
+ * else ( unknown value for filter )
+ * :throw invalid parameter;
+ * stop
+ * endif
+ * :remove users in filterList\nfrom ldap users list;
+ * :return remaining;
+ * stop
+ * @enduml
+ */
+@APICommand(name = "listLdapUsers", responseObject = LdapUserResponse.class,
description = "Lists LDAP Users according to the specifications from the user
request.", since = "4.2.0",
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
authorized = {RoleType.Admin,RoleType.DomainAdmin})
public class LdapListUsersCmd extends BaseListCmd {
public static final Logger s_logger =
Logger.getLogger(LdapListUsersCmd.class.getName());
private static final String s_name = "ldapuserresponse";
@Inject
private LdapManager _ldapManager;
+// TODO queryservice is already injected oin basecmd remove it here
@Inject
private QueryService _queryService;
Review comment:
yes, i didn't have headspace to think on testing this, yet.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland merged pull request #3729: config: add isdynamic flag in configuration response
DaanHoogland merged pull request #3729: config: add isdynamic flag in configuration response URL: https://github.com/apache/cloudstack/pull/3729 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch 4.13 updated (3ac03c8 -> 2712dec)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 3ac03c8 filter hosts to query on zone wide storage (#3733) add 2712dec config: add isdynamic flag in configuration response (#3729) No new revisions were added by this update. Summary of changes: .../main/java/org/apache/cloudstack/api/ApiConstants.java | 1 + .../cloudstack/api/response/ConfigurationResponse.java | 13 + server/src/main/java/com/cloud/api/ApiResponseHelper.java | 1 + ui/scripts/globalSettings.js| 4 ++-- 4 files changed, 17 insertions(+), 2 deletions(-)
[GitHub] [cloudstack] DaanHoogland commented on issue #3729: config: add isdynamic flag in configuration response
DaanHoogland commented on issue #3729: config: add isdynamic flag in configuration response URL: https://github.com/apache/cloudstack/pull/3729#issuecomment-567939411 discussed with @rohit offline. this is a significant improvement over the current situation in spite of his remarks. We'll need to deal with the 10% of exceptions as we encounter them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rakgenius commented on issue #3775: New feature: Acquire specific public IP for network
rakgenius commented on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-567939292 > Code looks good. Haven't tested though. > > One question - When the IP Address requested is invalid or unavailable in `user_ip_address` do we add that reason in exception or log it? (could'nt see it). The dropdown displays only the "Free" IP's available in that particular network or VPC. If there are not free IP in that network/VPC then it wont display the drop down list This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rakgenius commented on issue #3775: New feature: Acquire specific public IP for network
rakgenius commented on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-567938446 > Can I specify a public IP when creating an isolated network or VPC? If you comment out the first diff in network.js then you can specify any free IP in that network or VPC This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes
DaanHoogland commented on a change in pull request #3694: Ldap fixes
URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360387379
##
File path:
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/LdapConstants.java
##
@@ -0,0 +1,21 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api;
+
+public interface LdapConstants {
Review comment:
anticipation. I'm not against moving it but it is a very specific ldap
related term, so leaving it for now.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360386594 ## File path: plugins/user-authenticators/ldap/pom.xml ## @@ -81,38 +86,126 @@ **/*Spec.groovy **/*Test.java + +META-INF/*.SF +META-INF/*.DSA +META-INF/*.RSA + com.btmatthews.maven.plugins ldap-maven-plugin -1.1.0 +1.1.3 11389 ldap false dc=cloudstack,dc=org 10389 -test/resources/cloudstack.org.ldif +src/test/resources/cloudstack.org.ldif -test +src/test/java + +com.btmatthews.ldapunit +ldapunit +1.1.3 Review comment: Pulling the global ones from the top level pom and the local ones that are test specific only in the local properties section. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360384545 ## File path: plugins/user-authenticators/ldap/pom.xml ## @@ -27,6 +27,11 @@ 4.14.0.0-SNAPSHOT ../../pom.xml + + +2.0.0.AM26-SNAPSHOT Review comment: i'll test, but i think not :( This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] kioie commented on issue #3692: Accessibility issue: unable to get API and secret keys
kioie commented on issue #3692: Accessibility issue: unable to get API and secret keys URL: https://github.com/apache/cloudstack/issues/3692#issuecomment-567931304 Not sure if I'll be at FOSDEM, but we can always setup a call and come up with a list of things we can do, then we can share with the community as a starting point. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] kioie commented on issue #3757: Files in /var/cache/cloud/processed on virtual router are not cleaned up
kioie commented on issue #3757: Files in /var/cache/cloud/processed on virtual router are not cleaned up URL: https://github.com/apache/cloudstack/issues/3757#issuecomment-567929079 What would trigger a cleanup and what would be the frequency? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3776: Fix HA config keys
DaanHoogland commented on issue #3776: Fix HA config keys URL: https://github.com/apache/cloudstack/pull/3776#issuecomment-567923074 @mdominka it is because we strain travis too much but it is unrelated to the tests @anuragaw is doing. The log was longer than travis allows and we've been getting those more and more lately. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland opened a new pull request #3782: 4.13
DaanHoogland opened a new pull request #3782: 4.13 URL: https://github.com/apache/cloudstack/pull/3782 ## Description some fixess merged forward: Fixes: #3702 Fixes: #3252 Fixes: #3596 Fixes: #3093 ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland merged pull request #3733: filter hosts to query on zone wide storage
DaanHoogland merged pull request #3733: filter hosts to query on zone wide storage URL: https://github.com/apache/cloudstack/pull/3733 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch 4.13 updated (90ce1d8 -> 3ac03c8)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 90ce1d8 convert protocal names to be found as labels (#3747) add 3ac03c8 filter hosts to query on zone wide storage (#3733) No new revisions were added by this update. Summary of changes: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-)
[GitHub] [cloudstack] DaanHoogland merged pull request #3747: convert protocal names to be found as labels
DaanHoogland merged pull request #3747: convert protocal names to be found as labels URL: https://github.com/apache/cloudstack/pull/3747 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch 4.13 updated (0b34971 -> 90ce1d8)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 0b34971 Once again allow a VM to be on multiple networks from VPCs (#3754) add 90ce1d8 convert protocal names to be found as labels (#3747) No new revisions were added by this update. Summary of changes: ui/scripts/network.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
[cloudstack] branch 4.13 updated (5afff61 -> 0b34971)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 5afff61 create template from snapshot regression (partly reverted) (#3767) add 0b34971 Once again allow a VM to be on multiple networks from VPCs (#3754) No new revisions were added by this update. Summary of changes: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java | 9 - 1 file changed, 9 deletions(-)
[GitHub] [cloudstack] DaanHoogland merged pull request #3754: Once again allow a VM to be on multiple networks from VPCs
DaanHoogland merged pull request #3754: Once again allow a VM to be on multiple networks from VPCs URL: https://github.com/apache/cloudstack/pull/3754 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] mdominka commented on issue #3776: Fix HA config keys
mdominka commented on issue #3776: Fix HA config keys URL: https://github.com/apache/cloudstack/pull/3776#issuecomment-567918671 One travis test failed, but i see no relation to my changes. Can you test again @anuragaw This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch 4.13 updated (c75c228 -> 5afff61)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from c75c228 Honour promiscuous mode from networkOffering (#3765) add 5afff61 create template from snapshot regression (partly reverted) (#3767) No new revisions were added by this update. Summary of changes: ui/scripts/sharedFunctions.js | 102 ++ ui/scripts/storage.js | 2 +- 2 files changed, 103 insertions(+), 1 deletion(-)
[GitHub] [cloudstack] DaanHoogland merged pull request #3767: create template from snapshot regression (partly reverted)
DaanHoogland merged pull request #3767: create template from snapshot regression (partly reverted) URL: https://github.com/apache/cloudstack/pull/3767 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3565: vmware dvSwitches - promiscuous mode gets 'reject' when another network is attached to a VM
DaanHoogland commented on issue #3565: vmware dvSwitches - promiscuous mode gets 'reject' when another network is attached to a VM URL: https://github.com/apache/cloudstack/issues/3565#issuecomment-567915930 fixed by merge of 4.13 in master (#3781 ) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland merged pull request #3781: Honour promiscuous mode from networkOffering (#3765)
DaanHoogland merged pull request #3781: Honour promiscuous mode from networkOffering (#3765) URL: https://github.com/apache/cloudstack/pull/3781 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated (45503e1 -> 0606039)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 45503e1 Revert "Revert "Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt (#3371)" (#3771)" (#3772) add c75c228 Honour promiscuous mode from networkOffering (#3765) add 0606039 Honour promiscuous mode from networkOffering (#3765) (#3781) No new revisions were added by this update. Summary of changes: .../main/java/com/cloud/vm/VirtualMachineManagerImpl.java | 14 ++ 1 file changed, 14 insertions(+)
[GitHub] [cloudstack] DaanHoogland opened a new pull request #3781: Honour promiscuous mode from networkOffering (#3765)
DaanHoogland opened a new pull request #3781: Honour promiscuous mode from networkOffering (#3765) URL: https://github.com/apache/cloudstack/pull/3781 ## Description ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch 4.13 updated (07d64cb -> c75c228)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 07d64cb [KVM] Agent LB Fix: Connections from disabled KVM host agents are refused (#3617) add c75c228 Honour promiscuous mode from networkOffering (#3765) No new revisions were added by this update. Summary of changes: .../main/java/com/cloud/vm/VirtualMachineManagerImpl.java | 14 ++ 1 file changed, 14 insertions(+)
[GitHub] [cloudstack] DaanHoogland merged pull request #3765: Honour promiscuous mode from networkOffering
DaanHoogland merged pull request #3765: Honour promiscuous mode from networkOffering URL: https://github.com/apache/cloudstack/pull/3765 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms
blueorangutan commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms URL: https://github.com/apache/cloudstack/pull/3510#issuecomment-567904671 @anuragaw a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms
anuragaw commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms URL: https://github.com/apache/cloudstack/pull/3510#issuecomment-567904602 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms
blueorangutan commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms URL: https://github.com/apache/cloudstack/pull/3510#issuecomment-567904119 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-496 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3729: config: add isdynamic flag in configuration response
rhtyd commented on issue #3729: config: add isdynamic flag in configuration response URL: https://github.com/apache/cloudstack/pull/3729#issuecomment-567902158 cc @PaulAngus this adds feature to know if restarting mgmt server is needed after updating a global setting. I'll see what we can do to detect/fix this in Primate. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms
blueorangutan commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms URL: https://github.com/apache/cloudstack/pull/3510#issuecomment-567899553 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-567899312 @anuragaw a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms
anuragaw commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms URL: https://github.com/apache/cloudstack/pull/3510#issuecomment-567899360 ping @DaanHoogland for re-review when you have time. @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router
anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-567899111 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on a change in pull request #3510: [WIP DO NOT MERGE] Allow additional config to vms
anuragaw commented on a change in pull request #3510: [WIP DO NOT MERGE] Allow
additional config to vms
URL: https://github.com/apache/cloudstack/pull/3510#discussion_r360337798
##
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##
@@ -5105,32 +5130,132 @@ public UserVm createVirtualMachine(DeployVMCmd cmd)
throws InsufficientCapacityE
}
/**
- * Persist extra configurations as details for VMware VMs
+ * Persist extra configuration data in the user_vm_details table as
key/value pair
+ * @param decodedUrl String consisting of the extra config data to
appended onto the vmx file for VMware instances
*/
protected void persistExtraConfigVmware(String decodedUrl, UserVm vm) {
-String[] configDataArr = decodedUrl.split("\\r?\\n");
-for (String config: configDataArr) {
-String[] keyValue = config.split("=");
-try {
-userVmDetailsDao.addDetail(vm.getId(), keyValue[0],
keyValue[1], true);
-} catch (ArrayIndexOutOfBoundsException e) {
-throw new CloudRuntimeException("Issue occurred during parsing
of:" + config);
+boolean isValidConfig = isValidKeyValuePair(decodedUrl);
+if (isValidConfig) {
+String[] extraConfigs = decodedUrl.split("\\r?\\n");
+for (String cfg : extraConfigs) {
+// Validate cfg against unsupported operations set by admin
here
+String[] allowedKeyList =
VmwareAdditionalConfigAllowList.value().split(",");
+boolean validXenOrVmwareConfiguration =
isValidXenOrVmwareConfiguration(cfg, allowedKeyList);
+String[] paramArray = cfg.split("=");
+if (validXenOrVmwareConfiguration && paramArray.length == 2) {
+try {
+userVmDetailsDao.addDetail(vm.getId(),
paramArray[0].trim(), paramArray[1].trim(), true);
+} catch (ArrayIndexOutOfBoundsException e) {
+throw new CloudRuntimeException("Issue occurred during
parsing of:" + cfg);
Review comment:
This was redundant as above if checks length. Cleaned up.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
